)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"78be37e4d44af830773d085d76981a871dc88cc6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     a9e48a33 (Add build-essential to required packages for development)"},{"line_number":2,"context_line":"Author:     Jim Rollenhagen \u003cjim@jimrollenhagen.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-07-20 14:45:30 -0700"},{"line_number":4,"context_line":"Commit:     Galyna Zholtkevych \u003cgzholtkevych@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-22 10:55:14 +0300"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_78b86d2b","line":2,"updated":"2016-07-22 08:33:09.000000000","message":"O really?","commit_id":"4b374655e156b992752e83de93f71f697097cd20"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"78be37e4d44af830773d085d76981a871dc88cc6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated tests for db migration scripts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updated tests for db migration scripts taking"},{"line_number":10,"context_line":"into account previous reviews."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie4b46cf264a2199e1b422862fa47bc41789fd729"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_9877219f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"updated":"2016-07-22 08:33:09.000000000","message":"Please do not change commit message between patchsets if it\u0027s not needed. Anyone can look gerrit history and read reviewers comments. Thanks.","commit_id":"4b374655e156b992752e83de93f71f697097cd20"}],"doc/source/dev/dev-quickstart.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e6153188f1780fd0a44cba7d893a04e0b82195f9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- Ubuntu/Debian::"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    sudo apt-get install build-essential python-dev libssl-dev python-pip libmysqlclient-dev libxml2-dev libxslt-dev libpq-dev git git-review libffi-dev gettext ipmitool psmisc graphviz libjpeg-dev"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- Fedora 21/RHEL7/CentOS7::"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dada55a8_9dfc57b9","line":27,"updated":"2016-07-21 15:34:58.000000000","message":"This seems like some rebase issue, it was a separate patch that is already merged.","commit_id":"1b7bc6acf895ccfb219c774311a99d9e3b023a2f"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d75ae457b3a1e49d62cb29909e14472614bb820d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"from oslo_db.sqlalchemy import utils as db_utils"},{"line_number":46,"context_line":"from oslo_log import log as logging"},{"line_number":47,"context_line":"from oslo_utils import uuidutils"},{"line_number":48,"context_line":"import random"},{"line_number":49,"context_line":"import sqlalchemy"},{"line_number":50,"context_line":"import sqlalchemy.exc"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_420b738e","line":48,"updated":"2016-07-20 08:58:23.000000000","message":"Let\u0027s not pick random values as part of unittests","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"1cf281d20a5e025f0ff36b78b09aa8470d2439ea","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"},{"line_number":329,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":330,"context_line":"        column_names \u003d [column.name for column in nodes.c]"},{"line_number":331,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, column_names)"},{"line_number":332,"context_line":"        self.assertIn(\u0027inspection_finished_at\u0027, column_names)"},{"line_number":333,"context_line":"        self.assertIsInstance(nodes.c.inspection_started_at.type,"},{"line_number":334,"context_line":"                              sqlalchemy.types.DateTime)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f047fa1a","line":331,"range":{"start_line":331,"start_character":13,"end_line":331,"end_character":21},"updated":"2016-07-19 15:00:07.000000000","message":"A good place is \none assert / one test","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d75ae457b3a1e49d62cb29909e14472614bb820d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"},{"line_number":329,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":330,"context_line":"        column_names \u003d [column.name for column in nodes.c]"},{"line_number":331,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, column_names)"},{"line_number":332,"context_line":"        self.assertIn(\u0027inspection_finished_at\u0027, column_names)"},{"line_number":333,"context_line":"        self.assertIsInstance(nodes.c.inspection_started_at.type,"},{"line_number":334,"context_line":"                              sqlalchemy.types.DateTime)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_627677a5","line":331,"range":{"start_line":331,"start_character":13,"end_line":331,"end_character":21},"in_reply_to":"dada55a8_f047fa1a","updated":"2016-07-20 08:58:23.000000000","message":"I don\u0027t follow the comment, but this test seems to be doing what the other tests do when adding a new column in the db (see the tests above). It seems fine.","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"1cf281d20a5e025f0ff36b78b09aa8470d2439ea","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":353,"context_line":"                          nodes.insert().execute, data)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def _check_487deb87cc9d(self, engine, data):"},{"line_number":356,"context_line":"        conductors \u003d db_utils.get_table(engine, \u0027conductors\u0027)"},{"line_number":357,"context_line":"        column_names \u003d [column.name for column in conductors.c]"},{"line_number":358,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_70166aa8","line":355,"range":{"start_line":355,"start_character":8,"end_line":355,"end_character":27},"updated":"2016-07-19 15:00:07.000000000","message":"To complicated test.","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"1cf281d20a5e025f0ff36b78b09aa8470d2439ea","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.assertIn(\u0027online\u0027, column_names)"},{"line_number":360,"context_line":"        self.assertTrue(isinstance(conductors.c.online.type,"},{"line_number":361,"context_line":"                                   sqlalchemy.types.Boolean)"},{"line_number":362,"context_line":"                        or isinstance(conductors.c.online.type,"},{"line_number":363,"context_line":"                                      sqlalchemy.types.Integer))"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_10fa8e75","line":362,"range":{"start_line":362,"start_character":23,"end_line":362,"end_character":27},"updated":"2016-07-19 15:00:07.000000000","message":"Not good idea use `or` in assert","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d75ae457b3a1e49d62cb29909e14472614bb820d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.assertIn(\u0027online\u0027, column_names)"},{"line_number":360,"context_line":"        self.assertTrue(isinstance(conductors.c.online.type,"},{"line_number":361,"context_line":"                                   sqlalchemy.types.Boolean)"},{"line_number":362,"context_line":"                        or isinstance(conductors.c.online.type,"},{"line_number":363,"context_line":"                                      sqlalchemy.types.Integer))"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_42a8938d","line":362,"range":{"start_line":362,"start_character":23,"end_line":362,"end_character":27},"in_reply_to":"dada55a8_10fa8e75","updated":"2016-07-20 08:58:23.000000000","message":"It\u0027s ugly, but I think it\u0027s necessary in this case because depending on the backend it will be either a boolean or integer.\n\nI see the same situation on L245. \n\nSo I\u0027m good with this, unless you have another idea on how to check it.","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d75ae457b3a1e49d62cb29909e14472614bb820d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.assertIsInstance(nodes.c.conductor_affinity.type,"},{"line_number":369,"context_line":"                              sqlalchemy.types.Integer)"},{"line_number":370,"context_line":"        conductor_id \u003d random.randint(1000, 2000)"},{"line_number":371,"context_line":"        data_conductor \u003d {\u0027id\u0027: conductor_id, \u0027hostname\u0027: \u0027test_host\u0027}"},{"line_number":372,"context_line":"        conductors.insert().execute(data_conductor)"},{"line_number":373,"context_line":"        data_node \u003d {\u0027uuid\u0027: uuidutils.generate_uuid(),"},{"line_number":374,"context_line":"                     \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_a2aeaf7e","line":371,"updated":"2016-07-20 08:58:23.000000000","message":"I don\u0027t think we should use random stuff in unittests. Let\u0027s just pick a conductor id","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"1cf281d20a5e025f0ff36b78b09aa8470d2439ea","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        data_node \u003d {\u0027uuid\u0027: uuidutils.generate_uuid(),"},{"line_number":374,"context_line":"                     \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"},{"line_number":375,"context_line":"        nodes.insert().execute(data_node)"},{"line_number":376,"context_line":"        node \u003d nodes.select(nodes.c.uuid \u003d\u003d data_node[\u0027uuid\u0027]).\\"},{"line_number":377,"context_line":"            execute().first()"},{"line_number":378,"context_line":"        self.assertEqual(data_conductor[\u0027id\u0027], node[\u0027conductor_affinity\u0027])"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_10cc4e69","line":376,"range":{"start_line":376,"start_character":63,"end_line":376,"end_character":64},"updated":"2016-07-19 15:00:07.000000000","message":"It\u0027s ok when next string starts with:\n.execute().first()\nIt could be something like this:\nnode \u003d nodes.select(nodes.c.uuid \u003d\u003d data_node[\u0027uuid\u0027])\n        .execute().first()","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d75ae457b3a1e49d62cb29909e14472614bb820d","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        data_node \u003d {\u0027uuid\u0027: uuidutils.generate_uuid(),"},{"line_number":374,"context_line":"                     \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"},{"line_number":375,"context_line":"        nodes.insert().execute(data_node)"},{"line_number":376,"context_line":"        node \u003d nodes.select(nodes.c.uuid \u003d\u003d data_node[\u0027uuid\u0027]).\\"},{"line_number":377,"context_line":"            execute().first()"},{"line_number":378,"context_line":"        self.assertEqual(data_conductor[\u0027id\u0027], node[\u0027conductor_affinity\u0027])"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_a2db4f4e","line":376,"range":{"start_line":376,"start_character":63,"end_line":376,"end_character":64},"in_reply_to":"dada55a8_10cc4e69","updated":"2016-07-20 08:58:23.000000000","message":"++\n\nIn this case, it seems to fit all in the same line.","commit_id":"a545257ba968159179ed88ca996d9d63ac2e1efb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4b698b36c18cd49624fe283dcd34b582a4fb3fee","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        self.assertIn(\u0027name\u0027, column_names)"},{"line_number":341,"context_line":"        self.assertIsInstance(nodes.c.name.type,"},{"line_number":342,"context_line":"                              sqlalchemy.types.String)"},{"line_number":343,"context_line":"        node_name \u003d \u0027node\u0027"},{"line_number":344,"context_line":"        data \u003d {\u0027driver\u0027: \u0027fake\u0027,"},{"line_number":345,"context_line":"                \u0027uuid\u0027: uuidutils.generate_uuid(),"},{"line_number":346,"context_line":"                \u0027instance_uuid\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_df5568fa","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":17},"updated":"2016-07-20 14:27:16.000000000","message":"nit: node_name is used only once and may be set directly in the dict.","commit_id":"35e02d8116b39d41df436a00b0ea2c2a24890b9e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"063dd2cc0043c3ebea01b64f1801898d5bf967b1","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        column_names \u003d [column.name for column in conductors.c]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        self.assertIn(\u0027online\u0027, column_names)"},{"line_number":359,"context_line":"        self.assertTrue(isinstance(conductors.c.online.type,"},{"line_number":360,"context_line":"                                   sqlalchemy.types.Boolean)"},{"line_number":361,"context_line":"                        or isinstance(conductors.c.online.type,"},{"line_number":362,"context_line":"                                      sqlalchemy.types.Integer))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_801ec36d","line":359,"updated":"2016-07-21 10:12:33.000000000","message":"To get rid of \"or\" that people seem to be concerned about, you can do\n\n self.assertIsInstance(conductors.c.online.type, (sqlalchemy.types.Boolean, sqlalchemy.types.Integer))\n\nhttps://docs.python.org/2.7/library/unittest.html#unittest.TestCase.assertIsInstance","commit_id":"35e02d8116b39d41df436a00b0ea2c2a24890b9e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"803728899410be8c351c759b7b75620c7676cda5","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        column_names \u003d [column.name for column in conductors.c]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        self.assertIn(\u0027online\u0027, column_names)"},{"line_number":359,"context_line":"        self.assertTrue(isinstance(conductors.c.online.type,"},{"line_number":360,"context_line":"                                   sqlalchemy.types.Boolean)"},{"line_number":361,"context_line":"                        or isinstance(conductors.c.online.type,"},{"line_number":362,"context_line":"                                      sqlalchemy.types.Integer))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3e24585c","line":359,"in_reply_to":"dada55a8_801ec36d","updated":"2016-07-21 10:30:39.000000000","message":"We can also get engine name from sqlalchemy engine parameter and check different type for MySQL and Postgress, but I\u0027m not sure that it\u0027s needed. You can propose this logic in separate patch for this and also 3cb628139ea4.","commit_id":"35e02d8116b39d41df436a00b0ea2c2a24890b9e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5431a300daf744a353a9fa590ceb56ad294bc3ed","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertIsInstance(nodes.c.conductor_affinity.type,"},{"line_number":368,"context_line":"                              sqlalchemy.types.Integer)"},{"line_number":369,"context_line":"        conductor_id \u003d 456"},{"line_number":370,"context_line":"        data_conductor \u003d {\u0027id\u0027: conductor_id, \u0027hostname\u0027: \u0027test_host\u0027}"},{"line_number":371,"context_line":"        conductors.insert().execute(data_conductor)"},{"line_number":372,"context_line":"        data_node \u003d {\u0027uuid\u0027: uuidutils.generate_uuid(),"},{"line_number":373,"context_line":"                     \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8989fe77","line":370,"updated":"2016-07-20 14:20:27.000000000","message":"nit: conductor_id is only used once, we can set the value direct in the dict instead of creating a variable first.","commit_id":"35e02d8116b39d41df436a00b0ea2c2a24890b9e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"063dd2cc0043c3ebea01b64f1801898d5bf967b1","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        self.assertIsInstance(nodes.c.conductor_affinity.type,"},{"line_number":368,"context_line":"                              sqlalchemy.types.Integer)"},{"line_number":369,"context_line":"        conductor_id \u003d 456"},{"line_number":370,"context_line":"        data_conductor \u003d {\u0027id\u0027: conductor_id, \u0027hostname\u0027: \u0027test_host\u0027}"},{"line_number":371,"context_line":"        conductors.insert().execute(data_conductor)"},{"line_number":372,"context_line":"        data_node \u003d {\u0027uuid\u0027: uuidutils.generate_uuid(),"},{"line_number":373,"context_line":"                     \u0027conductor_affinity\u0027: data_conductor[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8066c34e","line":370,"in_reply_to":"dada55a8_8989fe77","updated":"2016-07-21 10:12:33.000000000","message":"I don\u0027t really like setting id manually, you could create a conductor only with hostname and then query by it to get the id. But then it should not create any problems so might be OK","commit_id":"35e02d8116b39d41df436a00b0ea2c2a24890b9e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"063dd2cc0043c3ebea01b64f1801898d5bf967b1","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        nodes.insert().execute(data_node)"},{"line_number":375,"context_line":"        node \u003d nodes.select("},{"line_number":376,"context_line":"            nodes.c.uuid \u003d\u003d data_node[\u0027uuid\u0027]).execute().first()"},{"line_number":377,"context_line":"        self.assertEqual(data_conductor[\u0027id\u0027], node[\u0027conductor_affinity\u0027])"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def _check_2fb93ffd2af1(self, engine, data):"},{"line_number":380,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_801883d4","line":377,"updated":"2016-07-21 10:12:33.000000000","message":"You could also assert that online is True by default in conductors table.","commit_id":"35e02d8116b39d41df436a00b0ea2c2a24890b9e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e6153188f1780fd0a44cba7d893a04e0b82195f9","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        nodes.insert().execute(data_node)"},{"line_number":377,"context_line":"        node \u003d nodes.select("},{"line_number":378,"context_line":"            nodes.c.uuid \u003d\u003d data_node[\u0027uuid\u0027]).execute().first()"},{"line_number":379,"context_line":"        self.assertEqual(conductor[\u0027id\u0027], node[\u0027conductor_affinity\u0027])"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _check_2fb93ffd2af1(self, engine, data):"},{"line_number":382,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_1dece728","line":379,"updated":"2016-07-21 15:34:58.000000000","message":"Still missing self.assertTrue(conductor[\u0027online\u0027]) :)","commit_id":"1b7bc6acf895ccfb219c774311a99d9e3b023a2f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f4917ddb7eceea04e49109fd1c4114d4f8a4af3e","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        self.assertIsInstance(nodes.c.target_raid_config.type,"},{"line_number":325,"context_line":"                              sqlalchemy.types.String)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"},{"line_number":328,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":329,"context_line":"        column_names \u003d [column.name for column in nodes.c]"},{"line_number":330,"context_line":"        self.assertIn(\u0027inspection_started_at\u0027, column_names)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_0aab651e","line":327,"updated":"2016-07-25 21:03:43.000000000","message":"this should go after _check_3ae36a5f5131()","commit_id":"b8dd9c0b47e222b4bd20208b472f4fed8b0dfde7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f4917ddb7eceea04e49109fd1c4114d4f8a4af3e","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        self.assertIsInstance(nodes.c.inspection_finished_at.type,"},{"line_number":335,"context_line":"                              sqlalchemy.types.DateTime)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def _check_3ae36a5f5131(self, engine, data):"},{"line_number":338,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":339,"context_line":"        column_names \u003d [column.name for column in nodes.c]"},{"line_number":340,"context_line":"        self.assertIn(\u0027name\u0027, column_names)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_8ab0f5de","line":337,"updated":"2016-07-25 21:03:43.000000000","message":"it would be good to put this after line 308","commit_id":"b8dd9c0b47e222b4bd20208b472f4fed8b0dfde7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f4917ddb7eceea04e49109fd1c4114d4f8a4af3e","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":350,"context_line":"        data[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":351,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":352,"context_line":"                          nodes.insert().execute, data)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _check_487deb87cc9d(self, engine, data):"},{"line_number":355,"context_line":"        conductors \u003d db_utils.get_table(engine, \u0027conductors\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_aa77b939","line":352,"updated":"2016-07-25 21:03:43.000000000","message":"What exactly are you testing for here? uuid, instance_uuid, and name all have to be unique.","commit_id":"b8dd9c0b47e222b4bd20208b472f4fed8b0dfde7"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"30527efd81e53fcc92b6065f74d864ac13ef7294","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":350,"context_line":"        data[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":351,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":352,"context_line":"                          nodes.insert().execute, data)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _check_487deb87cc9d(self, engine, data):"},{"line_number":355,"context_line":"        conductors \u003d db_utils.get_table(engine, \u0027conductors\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_bbe53a0a","line":352,"in_reply_to":"dada55a8_aa77b939","updated":"2016-07-26 08:23:01.000000000","message":"Thank you for your review,\n\nI am testing here the unique constraint of node\u0027s name, so I ensure that duplicated name of node will not be added to the table.","commit_id":"b8dd9c0b47e222b4bd20208b472f4fed8b0dfde7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f4917ddb7eceea04e49109fd1c4114d4f8a4af3e","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":352,"context_line":"                          nodes.insert().execute, data)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _check_487deb87cc9d(self, engine, data):"},{"line_number":355,"context_line":"        conductors \u003d db_utils.get_table(engine, \u0027conductors\u0027)"},{"line_number":356,"context_line":"        column_names \u003d [column.name for column in conductors.c]"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_2a662929","line":354,"updated":"2016-07-25 21:03:43.000000000","message":"would be good to put this after line 262","commit_id":"b8dd9c0b47e222b4bd20208b472f4fed8b0dfde7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1af182bbc7809fa7d2561ea3b1d1c0154510032e","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":349,"context_line":"        data[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":350,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":351,"context_line":"                          nodes.insert().execute, data)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"},{"line_number":354,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_1fb477cf","line":351,"updated":"2016-07-28 15:55:31.000000000","message":"continuing the discussion from revision 6.\n\nIf instance_uuid also has to be unique, how do you know this fails due to duplicate node name instead of duplicate instance_uuid?","commit_id":"40e8fc8d2f820a09311c5c1e791664a0a9c9e5e4"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"47eeda66e258f177be3d1d943a7a5814ca3d3911","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":349,"context_line":"        data[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":350,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":351,"context_line":"                          nodes.insert().execute, data)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"},{"line_number":354,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_2c05b4bb","line":351,"in_reply_to":"bacf61ea_1fb477cf","updated":"2016-07-29 08:33:25.000000000","message":"Done","commit_id":"40e8fc8d2f820a09311c5c1e791664a0a9c9e5e4"},{"author":{"_account_id":20522,"name":"Aline Bousquet","email":"albousque@gmail.com","username":"alineb"},"change_message_id":"af6c6b32c91b4739fc1cda9bf3119eb29d10d8d4","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        self.assertIn(\u0027online\u0027, column_names)"},{"line_number":269,"context_line":"        self.assertIsInstance(conductors.c.online.type,"},{"line_number":270,"context_line":"                              (sqlalchemy.types.Boolean,"},{"line_number":271,"context_line":"                               sqlalchemy.types.Integer))"},{"line_number":272,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":273,"context_line":"        column_names \u003d [column.name for column in nodes.c]"},{"line_number":274,"context_line":"        self.assertIn(\u0027conductor_affinity\u0027, column_names)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_72560f5d","line":271,"range":{"start_line":270,"start_character":30,"end_line":271,"end_character":56},"updated":"2016-08-01 10:54:14.000000000","message":"Maybe you could add a comment here explaining why this is needed? (like at line 240)","commit_id":"8baf29fe6a5d067f1061cc2f5eced0ed48188b21"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"5b46c2aced7f344df3f18c544fa64869c4ee090f","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                }"},{"line_number":347,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":348,"context_line":"        data[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":349,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":350,"context_line":"                          nodes.insert().execute, data)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_bad559ba","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":25},"updated":"2016-08-09 21:01:13.000000000","message":"I think it\u0027s no good idea to combine asserts with assertRises","commit_id":"8baf29fe6a5d067f1061cc2f5eced0ed48188b21"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"d8c99ad0d7d72ead954c186448b18b06c98a15fc","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                }"},{"line_number":347,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":348,"context_line":"        data[\u0027uuid\u0027] \u003d uuidutils.generate_uuid()"},{"line_number":349,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry,"},{"line_number":350,"context_line":"                          nodes.insert().execute, data)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def _check_1e1d5ace7dc6(self, engine, data):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_9fc0307e","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":25},"in_reply_to":"9ad45d7e_bad559ba","updated":"2016-08-10 08:23:41.000000000","message":"Due to framework rules, it is necessary to write one migration test per method. It has own revision id for it\nand no way to split this method by asserts.\n\nAnyway, I think, in this method combining such asserts is ok,\nassertRaises just checks unique constraint on node name.\nOnce a test for adding node (in another test module) will be created, there is a point to create there the separate test with checking duplicate name","commit_id":"8baf29fe6a5d067f1061cc2f5eced0ed48188b21"}]}
