)]}'
{"ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5cb0e54b26c066184b2ba9e4e0278fdf490d3887","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        :param address: MAC address of the port."},{"line_number":167,"context_line":"        :param extra: Meta data of the port. Default: {\u0027foo\u0027: \u0027bar\u0027}."},{"line_number":168,"context_line":"        :param uuid: UUID of the port."},{"line_number":169,"context_line":"        :param local_link_connection: Port binding profile. Default: None."},{"line_number":170,"context_line":"        :param pxe_enabled: Optional boolean. Used to set PXE use on port."},{"line_number":171,"context_line":"        :return: A tuple with the server response and the created port."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_4f22a901","line":169,"updated":"2016-08-22 10:36:11.000000000","message":"nit: Optional.","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"af84b7dbd9f7ce4446b6813029f06622b30503f3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        :param address: MAC address of the port."},{"line_number":167,"context_line":"        :param extra: Meta data of the port. Default: {\u0027foo\u0027: \u0027bar\u0027}."},{"line_number":168,"context_line":"        :param uuid: UUID of the port."},{"line_number":169,"context_line":"        :param local_link_connection: Port binding profile. Default: None."},{"line_number":170,"context_line":"        :param pxe_enabled: Optional boolean. Used to set PXE use on port."},{"line_number":171,"context_line":"        :return: A tuple with the server response and the created port."},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e73d71bc","line":169,"in_reply_to":"1ac06dbe_4f22a901","updated":"2016-08-22 13:41:47.000000000","message":"Done","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5cb0e54b26c066184b2ba9e4e0278fdf490d3887","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        return self._patch_request(\u0027nodes\u0027, uuid, patch)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @base.handle_errors"},{"line_number":241,"context_line":"    def patch_node(self, uuid, patch):"},{"line_number":242,"context_line":"        \"\"\"Update the specified node via a supplied patch."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param uuid: The unique identifier of the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_6f1cc577","line":241,"updated":"2016-08-22 10:36:11.000000000","message":"why we need to have a new method for this? I think we should use existing update_node()","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"af84b7dbd9f7ce4446b6813029f06622b30503f3","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        return self._patch_request(\u0027nodes\u0027, uuid, patch)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @base.handle_errors"},{"line_number":241,"context_line":"    def patch_node(self, uuid, patch):"},{"line_number":242,"context_line":"        \"\"\"Update the specified node via a supplied patch."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param uuid: The unique identifier of the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_8790fd44","line":241,"in_reply_to":"1ac06dbe_6f1cc577","updated":"2016-08-22 13:41:47.000000000","message":"I\u0027m updating the description to better communicate intention behind this, please let me know what you think.","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bc50900d209f7503003ae47d78b5933b9afd5d4d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        return self._patch_request(\u0027nodes\u0027, uuid, patch)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @base.handle_errors"},{"line_number":241,"context_line":"    def patch_node(self, uuid, patch):"},{"line_number":242,"context_line":"        \"\"\"Update the specified node via a supplied patch."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :param uuid: The unique identifier of the node."}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_299805c0","line":241,"in_reply_to":"1ac06dbe_6f1cc577","updated":"2016-08-22 11:49:31.000000000","message":"Just starting my first cup of coffee, so this may be out of date since other patches may have landed in the last month.\n\nThe second method is because the pre-existing method has a number of assumptions built around it that prevent it\u0027s use without substantial re-writing.\n\nThe alternative was to supplying a full patch object to be sent to the API, which is the route I went down because then I could specify if it was add/update, or remove in a patch object.  Alternatively, we could just rip out the  existing patch, replace the patch generation with jsonpatch....\n\nI think part of the motivation was also to keep the context that this might actually be physical hardware someone is running tempest against, since I know of some users who do execute the tempest tests against running setups real baremetal nodes.","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"}],"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5cb0e54b26c066184b2ba9e4e0278fdf490d3887","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return node is not None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if (not tempest.test.call_until_true("},{"line_number":139,"context_line":"            _get_node, 30, 1)):"},{"line_number":140,"context_line":"            msg \u003d (\u0027Timed out waiting for node to be deleted %s\u0027"},{"line_number":141,"context_line":"                   % node_id)"},{"line_number":142,"context_line":"            raise lib_exc.TimeoutException(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_d2cbdea3","line":139,"updated":"2016-08-22 10:36:11.000000000","message":"Might be introduce a new configuration variable?","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"af84b7dbd9f7ce4446b6813029f06622b30503f3","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return node is not None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        if (not tempest.test.call_until_true("},{"line_number":139,"context_line":"            _get_node, 30, 1)):"},{"line_number":140,"context_line":"            msg \u003d (\u0027Timed out waiting for node to be deleted %s\u0027"},{"line_number":141,"context_line":"                   % node_id)"},{"line_number":142,"context_line":"            raise lib_exc.TimeoutException(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e7f45188","line":139,"in_reply_to":"1ac06dbe_d2cbdea3","updated":"2016-08-22 13:41:47.000000000","message":"Done","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5cb0e54b26c066184b2ba9e4e0278fdf490d3887","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    def get_last_available_node(self):"},{"line_number":322,"context_line":"        _, body \u003d self.baremetal_client.list_nodes("},{"line_number":323,"context_line":"            provision_state\u003dBaremetalProvisionStates.AVAILABLE"},{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_927a06f0","line":324,"updated":"2016-08-22 10:36:11.000000000","message":"we should check that maintenance is false also.","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f937ee7efe7b62976a9e830b7541e017a27bc999","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    def get_last_available_node(self):"},{"line_number":322,"context_line":"        _, body \u003d self.baremetal_client.list_nodes("},{"line_number":323,"context_line":"            provision_state\u003dBaremetalProvisionStates.AVAILABLE"},{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_8993f94e","line":324,"in_reply_to":"1ac06dbe_927a06f0","updated":"2016-08-22 11:52:14.000000000","message":"++ Will do once coffee wakes me up.","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"af84b7dbd9f7ce4446b6813029f06622b30503f3","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    def get_last_available_node(self):"},{"line_number":322,"context_line":"        _, body \u003d self.baremetal_client.list_nodes("},{"line_number":323,"context_line":"            provision_state\u003dBaremetalProvisionStates.AVAILABLE"},{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_c7a03546","line":324,"in_reply_to":"1ac06dbe_927a06f0","updated":"2016-08-22 13:41:47.000000000","message":"Done","commit_id":"4d6ae8e5cdeb104d8e9cc57e6b91f0da2dfd8f58"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5e2b2833ff25a12595e532cb2ae35bf4d453d1a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def get_ports_detail(self, node_uuid):"},{"line_number":163,"context_line":"        \"\"\"Returns a list of ports with details.\"\"\""},{"line_number":164,"context_line":"        ports \u003d []"},{"line_number":165,"context_line":"        _, body \u003d self.baremetal_client.list_node_ports(node_uuid)"},{"line_number":166,"context_line":"        for port in body[\u0027ports\u0027]:"},{"line_number":167,"context_line":"            _, p \u003d self.baremetal_client.show_port_by_address(port[\u0027address\u0027])"},{"line_number":168,"context_line":"            ports.append(p[\u0027ports\u0027][0])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_2303ef0e","line":165,"updated":"2016-08-22 16:54:00.000000000","message":"Let\u0027s use this with detail so that we don\u0027t have to do 2 requests. (ie get nodes/uuid/ports/detail)","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def get_ports_detail(self, node_uuid):"},{"line_number":163,"context_line":"        \"\"\"Returns a list of ports with details.\"\"\""},{"line_number":164,"context_line":"        ports \u003d []"},{"line_number":165,"context_line":"        _, body \u003d self.baremetal_client.list_node_ports(node_uuid)"},{"line_number":166,"context_line":"        for port in body[\u0027ports\u0027]:"},{"line_number":167,"context_line":"            _, p \u003d self.baremetal_client.show_port_by_address(port[\u0027address\u0027])"},{"line_number":168,"context_line":"            ports.append(p[\u0027ports\u0027][0])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_f3a88022","line":165,"in_reply_to":"1ac06dbe_2303ef0e","updated":"2016-08-22 17:59:27.000000000","message":"I think tried doing that originally but there was some weird data structural issue if memory serves.  I\u0027ll take another look at this.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eda65003306e79859931e794cfdcc09a274ef7c1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    def get_ports_detail(self, node_uuid):"},{"line_number":163,"context_line":"        \"\"\"Returns a list of ports with details.\"\"\""},{"line_number":164,"context_line":"        ports \u003d []"},{"line_number":165,"context_line":"        _, body \u003d self.baremetal_client.list_node_ports(node_uuid)"},{"line_number":166,"context_line":"        for port in body[\u0027ports\u0027]:"},{"line_number":167,"context_line":"            _, p \u003d self.baremetal_client.show_port_by_address(port[\u0027address\u0027])"},{"line_number":168,"context_line":"            ports.append(p[\u0027ports\u0027][0])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_c2980cc3","line":165,"in_reply_to":"1ac06dbe_f3a88022","updated":"2016-10-07 18:19:06.000000000","message":"Polling /v1/ports/detail returns a PortCollection which has an extremely limited field list as compared to retrieving the entire port.  This seems like the best way to return all of the data to the caller, in our case for reconstruction of the port.\n\nhttp://docs.openstack.org/developer/ironic/webapi/v1.html#get--v1-ports-detail","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d58bf956185f6941086e4f4dd79fc50f6201ca3c","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            interval\u003d30)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def set_maintenance_mode(self, node_uuid, reason\u003dNone):"},{"line_number":246,"context_line":"        self.baremetal_client.set_maintenance_mode(node_uuid, reason)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def remove_maintenance_mode(self, node_uuid):"},{"line_number":249,"context_line":"        self.baremetal_client.remove_maintenance_mode(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_fddcdee5","line":246,"updated":"2016-08-22 14:19:33.000000000","message":"we need to ensure that maintenance is taking affect?","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            interval\u003d30)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def set_maintenance_mode(self, node_uuid, reason\u003dNone):"},{"line_number":246,"context_line":"        self.baremetal_client.set_maintenance_mode(node_uuid, reason)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def remove_maintenance_mode(self, node_uuid):"},{"line_number":249,"context_line":"        self.baremetal_client.remove_maintenance_mode(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_f37520fa","line":246,"in_reply_to":"1ac06dbe_fddcdee5","updated":"2016-08-22 17:59:27.000000000","message":"This is just a pass-through to help facilitate, I think the test should actually ensure desired or required state when necessary.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d58bf956185f6941086e4f4dd79fc50f6201ca3c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        self.baremetal_client.set_maintenance_mode(node_uuid, reason)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def remove_maintenance_mode(self, node_uuid):"},{"line_number":249,"context_line":"        self.baremetal_client.remove_maintenance_mode(node_uuid)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def create_node(self, **kwargs):"},{"line_number":252,"context_line":"        \"\"\"Create a baremetal node in the API."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_5df25270","line":249,"updated":"2016-08-22 14:19:33.000000000","message":"ditto about ensure.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        self.baremetal_client.set_maintenance_mode(node_uuid, reason)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def remove_maintenance_mode(self, node_uuid):"},{"line_number":249,"context_line":"        self.baremetal_client.remove_maintenance_mode(node_uuid)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def create_node(self, **kwargs):"},{"line_number":252,"context_line":"        \"\"\"Create a baremetal node in the API."}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_b356085a","line":249,"in_reply_to":"1ac06dbe_5df25270","updated":"2016-08-22 17:59:27.000000000","message":"Same reply for set.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d58bf956185f6941086e4f4dd79fc50f6201ca3c","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        :param uuid: Node UUID if pre-defined. Default: None."},{"line_number":258,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":259,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":260,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":261,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":262,"context_line":"        :param driver: Driver name. Default: \"fake\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_21bbf428","line":259,"updated":"2016-08-22 14:19:33.000000000","message":"just a note: these default values confusing a little, theirs default values are set at baremetal_client https://github.com/openstack/ironic/blob/10d00c040f3121bdf21beac4dfc9198bbf034bf2/ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py#L138","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        :param uuid: Node UUID if pre-defined. Default: None."},{"line_number":258,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":259,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":260,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":261,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":262,"context_line":"        :param driver: Driver name. Default: \"fake\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_1606ea1c","line":259,"in_reply_to":"1ac06dbe_21bbf428","updated":"2016-08-22 17:59:27.000000000","message":"That was intentional.  If they seem confusing, I can just rip them out, but It seems like the intention was for tests to not call the client directly unless absolutely, to abstract away some of the client in this file.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d58bf956185f6941086e4f4dd79fc50f6201ca3c","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def power_on_node(self, uuid):"},{"line_number":303,"context_line":"        self.baremetal_client.set_node_power_state("},{"line_number":304,"context_line":"            uuid, BaremetalPowerStates.POWER_ON"},{"line_number":305,"context_line":"        )"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def power_off_node(self, uuid):"},{"line_number":308,"context_line":"        self.baremetal_client.set_node_power_state("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_fdcb3e51","line":305,"updated":"2016-08-22 14:19:33.000000000","message":"should we wait and ensure that power state is changed? The same is for power_off_node()","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    def power_on_node(self, uuid):"},{"line_number":303,"context_line":"        self.baremetal_client.set_node_power_state("},{"line_number":304,"context_line":"            uuid, BaremetalPowerStates.POWER_ON"},{"line_number":305,"context_line":"        )"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def power_off_node(self, uuid):"},{"line_number":308,"context_line":"        self.baremetal_client.set_node_power_state("}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_d646124e","line":305,"in_reply_to":"1ac06dbe_fdcb3e51","updated":"2016-08-22 17:59:27.000000000","message":"The purpose is to explicitly set the power on.  I think the test should actually test if the power state has been changed.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d58bf956185f6941086e4f4dd79fc50f6201ca3c","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            BaremetalProvisionStates.MANAGE"},{"line_number":316,"context_line":"        )"},{"line_number":317,"context_line":"        self.wait_provisioning_state("},{"line_number":318,"context_line":"            uuid, BaremetalProvisionStates.MANAGEABLE, 30"},{"line_number":319,"context_line":"        )"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def get_last_available_node(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_9d484a89","line":318,"range":{"start_line":318,"start_character":55,"end_line":318,"end_character":57},"updated":"2016-08-22 14:19:33.000000000","message":"I think we can introduce new general config option like node_state_change_timeout.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            BaremetalProvisionStates.MANAGE"},{"line_number":316,"context_line":"        )"},{"line_number":317,"context_line":"        self.wait_provisioning_state("},{"line_number":318,"context_line":"            uuid, BaremetalProvisionStates.MANAGEABLE, 30"},{"line_number":319,"context_line":"        )"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def get_last_available_node(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_b6b1d649","line":318,"range":{"start_line":318,"start_character":55,"end_line":318,"end_character":57},"in_reply_to":"1ac06dbe_9d484a89","updated":"2016-08-22 17:59:27.000000000","message":"Agreed, I\u0027ll put this in my next revision.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d58bf956185f6941086e4f4dd79fc50f6201ca3c","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027],"},{"line_number":327,"context_line":"                                 maintenance\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_6127acb6","line":327,"updated":"2016-08-22 14:19:33.000000000","message":"will it work? I think we need to add maintenance filter to list_nodes()","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b22fb641138f35e4b56221a05bae081e6887e4e2","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027],"},{"line_number":327,"context_line":"                                 maintenance\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_4f9d6a58","line":327,"in_reply_to":"1ac06dbe_432c2b02","updated":"2016-08-22 17:59:27.000000000","message":"I was thinking the method being called took kwargs, but I may be off, I\u0027ve not looked yet given my monday morning meetings.\n\n-1 to get the last node in the list as matching the method name.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eda65003306e79859931e794cfdcc09a274ef7c1","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027],"},{"line_number":327,"context_line":"                                 maintenance\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_9c7679d5","line":327,"in_reply_to":"1ac06dbe_4f9d6a58","updated":"2016-10-07 18:19:06.000000000","message":"Yup, totally swapped the two around in my head \\o/.  Will be fixed in next revision.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d5e2b2833ff25a12595e532cb2ae35bf4d453d1a","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        )"},{"line_number":325,"context_line":"        if body[\u0027nodes\u0027]:"},{"line_number":326,"context_line":"            return self.get_node(node_id\u003dbody[\u0027nodes\u0027][-1][\u0027uuid\u0027],"},{"line_number":327,"context_line":"                                 maintenance\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_432c2b02","line":327,"in_reply_to":"1ac06dbe_6127acb6","updated":"2016-08-22 16:54:00.000000000","message":"++ also why do you pick -1? Any of them should be OK.","commit_id":"7456da9c51904251161b96c8c2be01724ac7976f"}]}
