)]}'
{"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_20_NETWORK_INTERFACE:"},{"line_number":141,"context_line":"        obj.network_interface \u003d wsme.Unset"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_21_RESOURCE_CLASS:"},{"line_number":144,"context_line":"        obj.resource_class \u003d wsme.Unset"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_cb2429b1","line":143,"updated":"2016-07-27 14:33:29.000000000","message":"would be better as\n\n    if not allow_resource_class()\n\nsome of the other ones above could be cleaned up too. I can clean this all up in a separate patch.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_20_NETWORK_INTERFACE:"},{"line_number":141,"context_line":"        obj.network_interface \u003d wsme.Unset"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_21_RESOURCE_CLASS:"},{"line_number":144,"context_line":"        obj.resource_class \u003d wsme.Unset"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_bd2bf332","line":143,"in_reply_to":"bacf61ea_cb2429b1","updated":"2016-07-27 16:14:50.000000000","message":"I\u0027ll fix this one so we aren\u0027t introducing more cruft, I added allow_resource_class() later, so I missed it.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":703,"context_line":"    \"\"\"This node\u0027s meta data\"\"\""},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    resource_class \u003d wsme.wsattr(wtypes.text)"},{"line_number":706,"context_line":"    \"\"\"The resource class for the node, used by Nova.\"\"\""},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    # NOTE: properties should use a class to enforce required properties"},{"line_number":709,"context_line":"    #       current list: arch, cpus, disk, ram, image"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_e81f7359","line":706,"updated":"2016-07-27 14:33:29.000000000","message":"I don\u0027t like how this is so closely tied to Nova, although I realize that\u0027s why we are adding it.\n\nHow about something like\n\nThe resource class for the node, useful for classifying or grouping the nodes. Used, for example, by Nova for scheduling purposes.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":703,"context_line":"    \"\"\"This node\u0027s meta data\"\"\""},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    resource_class \u003d wsme.wsattr(wtypes.text)"},{"line_number":706,"context_line":"    \"\"\"The resource class for the node, used by Nova.\"\"\""},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    # NOTE: properties should use a class to enforce required properties"},{"line_number":709,"context_line":"    #       current list: arch, cpus, disk, ram, image"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_dd9d075b","line":706,"in_reply_to":"bacf61ea_e81f7359","updated":"2016-07-27 16:14:50.000000000","message":"++ done","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":825,"context_line":"                     inspection_finished_at\u003dNone, inspection_started_at\u003dtime,"},{"line_number":826,"context_line":"                     console_enabled\u003dFalse, clean_step\u003d{},"},{"line_number":827,"context_line":"                     raid_config\u003dNone, target_raid_config\u003dNone,"},{"line_number":828,"context_line":"                     network_interface\u003d\u0027flat\u0027)"},{"line_number":829,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":830,"context_line":"        # _chassis_uuid variable:"},{"line_number":831,"context_line":"        sample._chassis_uuid \u003d \u0027edcad704-b2da-41d5-96d9-afd580ecfa12\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_e87bf379","line":828,"updated":"2016-07-27 14:33:29.000000000","message":"should add resource_class to this example.\n\nAlthough with the api-ref, will we still want this? Anyway, that is an aside.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":825,"context_line":"                     inspection_finished_at\u003dNone, inspection_started_at\u003dtime,"},{"line_number":826,"context_line":"                     console_enabled\u003dFalse, clean_step\u003d{},"},{"line_number":827,"context_line":"                     raid_config\u003dNone, target_raid_config\u003dNone,"},{"line_number":828,"context_line":"                     network_interface\u003d\u0027flat\u0027)"},{"line_number":829,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":830,"context_line":"        # _chassis_uuid variable:"},{"line_number":831,"context_line":"        sample._chassis_uuid \u003d \u0027edcad704-b2da-41d5-96d9-afd580ecfa12\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_fd6c4b0a","line":828,"in_reply_to":"bacf61ea_e87bf379","updated":"2016-07-27 16:14:50.000000000","message":"Done","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":1141,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":1142,"context_line":"                maintenance\u003dNone, provision_state\u003dNone, marker\u003dNone,"},{"line_number":1143,"context_line":"                limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, driver\u003dNone,"},{"line_number":1144,"context_line":"                resource_class\u003dNone, fields\u003dNone):"},{"line_number":1145,"context_line":"        \"\"\"Retrieve a list of nodes."},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        :param chassis_uuid: Optional UUID of a chassis, to get only nodes for"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_28e7cb13","line":1144,"updated":"2016-07-27 14:33:29.000000000","message":"does the ordering matter? (I don\u0027t think so but am not sure.) Wondering if it should be put at the end.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":1141,"context_line":"    def get_all(self, chassis_uuid\u003dNone, instance_uuid\u003dNone, associated\u003dNone,"},{"line_number":1142,"context_line":"                maintenance\u003dNone, provision_state\u003dNone, marker\u003dNone,"},{"line_number":1143,"context_line":"                limit\u003dNone, sort_key\u003d\u0027id\u0027, sort_dir\u003d\u0027asc\u0027, driver\u003dNone,"},{"line_number":1144,"context_line":"                resource_class\u003dNone, fields\u003dNone):"},{"line_number":1145,"context_line":"        \"\"\"Retrieve a list of nodes."},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        :param chassis_uuid: Optional UUID of a chassis, to get only nodes for"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_dd3fc7d4","line":1144,"in_reply_to":"bacf61ea_28e7cb13","updated":"2016-07-27 16:14:50.000000000","message":"It doesn\u0027t, so I will.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        api_utils.check_for_invalid_state_and_allow_filter(provision_state)"},{"line_number":1172,"context_line":"        api_utils.check_allow_specify_driver(driver)"},{"line_number":1173,"context_line":"        api_utils.check_allow_specify_resource_class(resource_class)"},{"line_number":1174,"context_line":"        api_utils.check_allow_specify_network_interface_in_fields(fields)"},{"line_number":1175,"context_line":"        if fields is None:"},{"line_number":1176,"context_line":"            fields \u003d _DEFAULT_RETURN_FIELDS"},{"line_number":1177,"context_line":"        return self._get_nodes_collection(chassis_uuid, instance_uuid,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_2b41853a","line":1174,"updated":"2016-07-27 14:33:29.000000000","message":"should also call api_utils.check_allow_specify_resource_class_in_fields()","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":1171,"context_line":"        api_utils.check_for_invalid_state_and_allow_filter(provision_state)"},{"line_number":1172,"context_line":"        api_utils.check_allow_specify_driver(driver)"},{"line_number":1173,"context_line":"        api_utils.check_allow_specify_resource_class(resource_class)"},{"line_number":1174,"context_line":"        api_utils.check_allow_specify_network_interface_in_fields(fields)"},{"line_number":1175,"context_line":"        if fields is None:"},{"line_number":1176,"context_line":"            fields \u003d _DEFAULT_RETURN_FIELDS"},{"line_number":1177,"context_line":"        return self._get_nodes_collection(chassis_uuid, instance_uuid,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_9d1c2f79","line":1174,"in_reply_to":"bacf61ea_2b41853a","updated":"2016-07-27 16:14:50.000000000","message":"Done","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"                                          associated, maintenance,"},{"line_number":1227,"context_line":"                                          provision_state, marker,"},{"line_number":1228,"context_line":"                                          limit, sort_key, sort_dir,"},{"line_number":1229,"context_line":"                                          driver, resource_class,"},{"line_number":1230,"context_line":"                                          resource_url)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    @METRICS.timer(\u0027NodesController.validate\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_88ba37bf","line":1229,"updated":"2016-07-27 14:33:29.000000000","message":"sigh. I know it wasn\u0027t done, but I\u0027d prefer if this was driver\u003ddriver,resource_class\u003dresource_class, resource_url\u003dresource_url.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"                                          associated, maintenance,"},{"line_number":1227,"context_line":"                                          provision_state, marker,"},{"line_number":1228,"context_line":"                                          limit, sort_key, sort_dir,"},{"line_number":1229,"context_line":"                                          driver, resource_class,"},{"line_number":1230,"context_line":"                                          resource_url)"},{"line_number":1231,"context_line":""},{"line_number":1232,"context_line":"    @METRICS.timer(\u0027NodesController.validate\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_cf254eaf","line":1229,"in_reply_to":"bacf61ea_88ba37bf","updated":"2016-07-27 16:14:50.000000000","message":"I agree, I\u0027ll fix this up everywhere.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2b09bb26674c886300a42f817b55a5e58c301871","unresolved":false,"context_lines":[{"line_number":702,"context_line":"    extra \u003d {wtypes.text: types.jsontype}"},{"line_number":703,"context_line":"    \"\"\"This node\u0027s meta data\"\"\""},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    resource_class \u003d wsme.wsattr(wtypes.text)"},{"line_number":706,"context_line":"    \"\"\"The resource class for the node, useful for classifying or grouping"},{"line_number":707,"context_line":"       nodes. Used, for example, to classify nodes in Nova\u0027s placement"},{"line_number":708,"context_line":"       engine.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_bc490b8e","line":705,"updated":"2016-07-28 10:42:55.000000000","message":"We need to validate the input here, currently, in the database the length of resource_class is 80 characters. When I try to input a resource_class that is larger than 80 characters I get a 500 HTTP error returned, see: http://paste.openstack.org/show/543234/\n\nWe can use the wtypes.StringType for this field and it will take care of validating it for us, e.g:\n\nresource_class \u003d wtypes.StringType(max_length\u003d80)\n\nSo when I try to input something larger I now get a 400 HTTP error returned with a proper error message, see: http://paste.openstack.org/show/543236/","commit_id":"48ad0cf651fc2480de89316a9d4fc627c16b18bf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"73c376d2ee889c0fe315718767db0ff3b0d2b6bf","unresolved":false,"context_lines":[{"line_number":702,"context_line":"    extra \u003d {wtypes.text: types.jsontype}"},{"line_number":703,"context_line":"    \"\"\"This node\u0027s meta data\"\"\""},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    resource_class \u003d wsme.wsattr(wtypes.text)"},{"line_number":706,"context_line":"    \"\"\"The resource class for the node, useful for classifying or grouping"},{"line_number":707,"context_line":"       nodes. Used, for example, to classify nodes in Nova\u0027s placement"},{"line_number":708,"context_line":"       engine.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_f14ba129","line":705,"in_reply_to":"bacf61ea_bc490b8e","updated":"2016-07-28 13:23:17.000000000","message":"Good catch!","commit_id":"48ad0cf651fc2480de89316a9d4fc627c16b18bf"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":256,"context_line":"def check_allow_specify_resource_class_in_fields(fields):"},{"line_number":257,"context_line":"    \"\"\"Check if fetching a resource_class attribute is allowed."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Version 1.21 of the API allows to fetching a resource_class"},{"line_number":260,"context_line":"    attribute. This method check if the required version is being"},{"line_number":261,"context_line":"    requested."},{"line_number":262,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_a878dbf9","line":259,"updated":"2016-07-27 14:33:29.000000000","message":"this is why i hate letting stuff in that is grammatically incorrect. the copy/paste explosion.\n\ns/to fetching/fetching/","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"def check_allow_specify_resource_class_in_fields(fields):"},{"line_number":257,"context_line":"    \"\"\"Check if fetching a resource_class attribute is allowed."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Version 1.21 of the API allows to fetching a resource_class"},{"line_number":260,"context_line":"    attribute. This method check if the required version is being"},{"line_number":261,"context_line":"    requested."},{"line_number":262,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_4faf9ee3","line":259,"in_reply_to":"bacf61ea_a878dbf9","updated":"2016-07-27 16:14:50.000000000","message":"Ooo, good catch. Thanks.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    \"\"\"Check if fetching a resource_class attribute is allowed."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Version 1.21 of the API allows to fetching a resource_class"},{"line_number":260,"context_line":"    attribute. This method check if the required version is being"},{"line_number":261,"context_line":"    requested."},{"line_number":262,"context_line":"    \"\"\""},{"line_number":263,"context_line":"    if (fields is not None"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_286d0b33","line":260,"updated":"2016-07-27 14:33:29.000000000","message":"s/check/checks/","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    \"\"\"Check if fetching a resource_class attribute is allowed."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Version 1.21 of the API allows to fetching a resource_class"},{"line_number":260,"context_line":"    attribute. This method check if the required version is being"},{"line_number":261,"context_line":"    requested."},{"line_number":262,"context_line":"    \"\"\""},{"line_number":263,"context_line":"    if (fields is not None"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_2faceaec","line":260,"in_reply_to":"bacf61ea_286d0b33","updated":"2016-07-27 16:14:50.000000000","message":"Done","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if (fields is not None"},{"line_number":264,"context_line":"            and \u0027resource_class\u0027 in fields"},{"line_number":265,"context_line":"                and not allow_resource_class()):"},{"line_number":266,"context_line":"        raise exception.NotAcceptable()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# NOTE(vsaienko) The validation is performed on API side, all conductors"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_0822c7b9","line":266,"updated":"2016-07-27 14:33:29.000000000","message":"I\u0027m guessing that both check_allow_specify_resource_class_in_fields() and check_allow_specify_network_interface_in_fields() will both be called a the same time, so can be combined into one eg \u0027check_allow_specific_fields()\u0027.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    if (fields is not None"},{"line_number":264,"context_line":"            and \u0027resource_class\u0027 in fields"},{"line_number":265,"context_line":"                and not allow_resource_class()):"},{"line_number":266,"context_line":"        raise exception.NotAcceptable()"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# NOTE(vsaienko) The validation is performed on API side, all conductors"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_afd45a47","line":266,"in_reply_to":"bacf61ea_0822c7b9","updated":"2016-07-27 16:14:50.000000000","message":"Fair enough :)\n\nWe already have check_allow_specify_fields, so I made a check_allowed_fields so they aren\u0027t too similar.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"70f7066d0fad063e3b7d532e3bcdb11adae03987","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    attribute."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    Version 1.21 of the API allows fetching a resource_class"},{"line_number":253,"context_line":"    attribute. This method checks if the required version is being"},{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    if fields is None:"},{"line_number":256,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_de87ba10","line":253,"updated":"2016-07-27 17:54:36.000000000","message":"delete \u0027This method checks...\u0027\n\nI\u0027m actually fine if we don\u0027t put the Version 1.20, version 1.21 descriptions above.","commit_id":"f2932a188551a3c7e3d4423cde76376676f57e8d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8498e080b6e4c4c1a68ddeaaac82ef78c92608e5","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    attribute."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    Version 1.21 of the API allows fetching a resource_class"},{"line_number":253,"context_line":"    attribute. This method checks if the required version is being"},{"line_number":254,"context_line":"    \"\"\""},{"line_number":255,"context_line":"    if fields is None:"},{"line_number":256,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_69541354","line":253,"in_reply_to":"bacf61ea_de87ba10","updated":"2016-07-27 20:50:19.000000000","message":"Done","commit_id":"f2932a188551a3c7e3d4423cde76376676f57e8d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"70f7066d0fad063e3b7d532e3bcdb11adae03987","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        raise exception.NotAcceptable()"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"def check_allow_specify_resource_class_in_fields(fields):"},{"line_number":264,"context_line":"    \"\"\"Check if fetching a resource_class attribute is allowed."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    Version 1.21 of the API allows fetching a resource_class"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_bebac6be","line":263,"updated":"2016-07-27 17:54:36.000000000","message":"don\u0027t need this method anymore?","commit_id":"f2932a188551a3c7e3d4423cde76376676f57e8d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8498e080b6e4c4c1a68ddeaaac82ef78c92608e5","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        raise exception.NotAcceptable()"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"def check_allow_specify_resource_class_in_fields(fields):"},{"line_number":264,"context_line":"    \"\"\"Check if fetching a resource_class attribute is allowed."},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    Version 1.21 of the API allows fetching a resource_class"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_49514f62","line":263,"in_reply_to":"bacf61ea_bebac6be","updated":"2016-07-27 20:50:19.000000000","message":"Done","commit_id":"f2932a188551a3c7e3d4423cde76376676f57e8d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"37273ad1c09b06a6bd650156f48e1aaee6f86b1a","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def check_allowed_fields(fields):"},{"line_number":244,"context_line":"    \"\"\"Check if fetching a particular field is allowed.\"\"\""},{"line_number":245,"context_line":"    if fields is None:"},{"line_number":246,"context_line":"        return"},{"line_number":247,"context_line":"    if \u0027network_interface\u0027 in fields and not allow_network_interface():"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_f42576ae","line":244,"updated":"2016-07-27 20:58:37.000000000","message":"I was fine if you removed the Version 1.20 etc, stuff but I did like the \u0027This method checks if the required version is being requested for fields that are only allowed to be fetched in a particular API version.\u0027\n\nNo big deal :)","commit_id":"caade5cb77243c7ee159e58b67af9e06670214b5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9d73a139ffe1cc71591831b2ba00debc8da45d37","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def check_allowed_fields(fields):"},{"line_number":244,"context_line":"    \"\"\"Check if fetching a particular field is allowed.\"\"\""},{"line_number":245,"context_line":"    if fields is None:"},{"line_number":246,"context_line":"        return"},{"line_number":247,"context_line":"    if \u0027network_interface\u0027 in fields and not allow_network_interface():"}],"source_content_type":"text/x-python","patch_set":10,"id":"bacf61ea_6f0c1343","line":244,"in_reply_to":"bacf61ea_f42576ae","updated":"2016-07-27 21:43:34.000000000","message":"Oops, totally misread your comment :/ fixing","commit_id":"caade5cb77243c7ee159e58b67af9e06670214b5"}],"ironic/db/sqlalchemy/alembic/versions/dd34e1f1303b_add_resource_class_to_node.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0e09d7243a070b6f06e4c92573c7f5b9adb9a79e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027network_interface\u0027, sa.String(100),"},{"line_number":33,"context_line":"                                     default\u003d\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_52079817","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":55},"updated":"2016-07-20 22:19:06.000000000","message":"wrong column name","commit_id":"52fdd067f80baf14d594a02a15d3e786dc19cad5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0e09d7243a070b6f06e4c92573c7f5b9adb9a79e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027network_interface\u0027, sa.String(100),"},{"line_number":33,"context_line":"                                     default\u003d\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d23268f1","line":33,"updated":"2016-07-20 22:19:06.000000000","message":"Why default value not added to model?","commit_id":"52fdd067f80baf14d594a02a15d3e786dc19cad5"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6f28a8095e272581fcb20f0a7f70e640f6ad0609","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    driver_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":119,"context_line":"    driver_internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":120,"context_line":"    clean_step \u003d Column(db_types.JsonEncodedDict)"},{"line_number":121,"context_line":"    resource_class \u003d Column(String(100))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    raid_config \u003d Column(db_types.JsonEncodedDict)"},{"line_number":124,"context_line":"    target_raid_config \u003d Column(db_types.JsonEncodedDict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_e6be3c63","line":121,"updated":"2016-07-24 23:45:02.000000000","message":"We should make this nullable, for sanity.","commit_id":"410c66088987a68021fd60e70d6b4701b2010004"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if \u0027network_interface\u0027 not in kw:"},{"line_number":99,"context_line":"        node.pop(\u0027network_interface\u0027)"},{"line_number":100,"context_line":"    if \u0027resource_class\u0027 not in kw:"},{"line_number":101,"context_line":"        node.pop(\u0027resource_class\u0027)"},{"line_number":102,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":103,"context_line":"    return remove_internal(node, internal)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_4b74b9fc","line":101,"updated":"2016-07-27 14:33:29.000000000","message":"vdrok modified the comment above in a separate patch. wonder if we need to modify it now that this one is being added.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"24a71b95c5c6f98f5faaab69ec9bc4b1d2839bb5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    if \u0027network_interface\u0027 not in kw:"},{"line_number":99,"context_line":"        node.pop(\u0027network_interface\u0027)"},{"line_number":100,"context_line":"    if \u0027resource_class\u0027 not in kw:"},{"line_number":101,"context_line":"        node.pop(\u0027resource_class\u0027)"},{"line_number":102,"context_line":"    internal \u003d node_controller.NodePatchType.internal_attrs()"},{"line_number":103,"context_line":"    return remove_internal(node, internal)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_85f175d0","line":101,"in_reply_to":"bacf61ea_4b74b9fc","updated":"2016-07-27 16:42:38.000000000","message":"Done","commit_id":"6455aab759507d41ced44417594607b4f364802f"}],"releasenotes/notes/add-node-resource-class-c31e26df4196293e.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    which will be used by Nova to define which nodes may"},{"line_number":5,"context_line":"    quantitatively match a Nova flavor. Operators should"},{"line_number":6,"context_line":"    populate this accordingly before deploying the Ocata"},{"line_number":7,"context_line":"    version of Nova."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - Adds a `resource_class` field to the node resource,"},{"line_number":10,"context_line":"    which will be used by Nova to define which nodes may"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_2b5ea545","line":7,"updated":"2016-07-27 14:33:29.000000000","message":"should we mention something like s/Ocata version/Ocata version (or version with XXX? feature)/","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    which will be used by Nova to define which nodes may"},{"line_number":5,"context_line":"    quantitatively match a Nova flavor. Operators should"},{"line_number":6,"context_line":"    populate this accordingly before deploying the Ocata"},{"line_number":7,"context_line":"    version of Nova."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - Adds a `resource_class` field to the node resource,"},{"line_number":10,"context_line":"    which will be used by Nova to define which nodes may"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_3210cd4e","line":7,"in_reply_to":"bacf61ea_2b5ea545","updated":"2016-07-27 16:14:50.000000000","message":"Eh, Ocata is the plan, I\u0027d prefer to just use that.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3cd2c79239014a4ef1269741a9cc97592113a778","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    which will be used by Nova to define which nodes may"},{"line_number":11,"context_line":"    quantitatively match a Nova flavor. Operators should"},{"line_number":12,"context_line":"    populate this accordingly before deploying the Ocata"},{"line_number":13,"context_line":"    version of Nova."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_ee081b2b","line":13,"updated":"2016-07-27 14:33:29.000000000","message":"I don\u0027t know that we should say \u0027should\u0027. They may populate this if they want to take advantage of the new feature in nova.","commit_id":"6455aab759507d41ced44417594607b4f364802f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"6226b392f79253f169ce5aa6691557b7af51538a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    which will be used by Nova to define which nodes may"},{"line_number":11,"context_line":"    quantitatively match a Nova flavor. Operators should"},{"line_number":12,"context_line":"    populate this accordingly before deploying the Ocata"},{"line_number":13,"context_line":"    version of Nova."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_725fe50e","line":13,"in_reply_to":"bacf61ea_ee081b2b","updated":"2016-07-27 16:14:50.000000000","message":"Well, I believe the plan is to deprecate the old way in P, so they\u0027ll want to move to this model in Ocata, and as such should be doing this before deploying Ocata. It won\u0027t break, but it is recommended, so I like should here. We can discuss more, though.\n\nThey can populate this during Ocata, but it will make it more painful as it will need to be done in coordination with applying changes to flavors.","commit_id":"6455aab759507d41ced44417594607b4f364802f"}]}
