)]}'
{"doc/source/drivers/ilo.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e7e9a40715cfdd1f4363dbbb7174f8bdfe2ea3c4","unresolved":false,"context_lines":[{"line_number":598,"context_line":"* When boot mode capability is not configured:"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"  - If config variable ``preferred_boot_mode`` in ``[ilo]`` section of"},{"line_number":601,"context_line":"    ``/etc/ironic/ironic.conf`` is defined, then iLO drivers use that boot"},{"line_number":602,"context_line":"    mode for provisioning the baremetal ProLiant servers."},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"  - If the pending boot mode is set on the node then iLO drivers use that boot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dada55a8_f705ac13","line":601,"updated":"2016-07-21 17:29:53.000000000","message":"Please use ironic configuration file instead of the path :)","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0f4661ac8d9d42ec093677c510d934689d25df9e","unresolved":false,"context_lines":[{"line_number":598,"context_line":"* When boot mode capability is not configured:"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"  - If config variable ``preferred_boot_mode`` in ``[ilo]`` section of"},{"line_number":601,"context_line":"    ``/etc/ironic/ironic.conf`` is defined, then iLO drivers use that boot"},{"line_number":602,"context_line":"    mode for provisioning the baremetal ProLiant servers."},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"  - If the pending boot mode is set on the node then iLO drivers use that boot"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dada55a8_ad090e97","line":601,"in_reply_to":"dada55a8_f705ac13","updated":"2016-07-22 06:05:40.000000000","message":"Done","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fdd495eb5629ba8ffc3d345484c456ed0c42b8dc","unresolved":false,"context_lines":[{"line_number":627,"context_line":"* When boot mode capability is not configured:"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"  - If config variable ``default_boot_mode`` in ``[ilo]`` section of"},{"line_number":630,"context_line":"    ironic configuration file is defined, then iLO drivers use that boot mode"},{"line_number":631,"context_line":"    for provisioning the baremetal ProLiant servers."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"  - If the pending boot mode is set on the node then iLO drivers use that boot"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3ac371cc_70a2d9af","line":630,"range":{"start_line":630,"start_character":33,"end_line":630,"end_character":40},"updated":"2016-08-16 16:11:38.000000000","message":"It seems it should be not \u0027defined\u0027, but set to either \u0027bios\u0027 or \u0027uefi\u0027.","commit_id":"3a0332cf3f5695e0d24f526f666d649b3bc1e63f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d75ea532378474f910606622ea91540fa26e681a","unresolved":false,"context_lines":[{"line_number":627,"context_line":"* When boot mode capability is not configured:"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"  - If config variable ``default_boot_mode`` in ``[ilo]`` section of"},{"line_number":630,"context_line":"    ironic configuration file is defined, then iLO drivers use that boot mode"},{"line_number":631,"context_line":"    for provisioning the baremetal ProLiant servers."},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"  - If the pending boot mode is set on the node then iLO drivers use that boot"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3ac371cc_e9b40d36","line":630,"range":{"start_line":630,"start_character":33,"end_line":630,"end_character":40},"in_reply_to":"3ac371cc_70a2d9af","updated":"2016-08-17 03:21:32.000000000","message":"Done","commit_id":"3a0332cf3f5695e0d24f526f666d649b3bc1e63f"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f44b51b52596393f89494d4460475964adf3522a","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"#ca_file \u003d \u003cNone\u003e"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"# Default boot mode to be used in provisioning when it is not"},{"line_number":1186,"context_line":"# specified in node capabilities. Value of \"auto\" is provided"},{"line_number":1187,"context_line":"# for backward compatibility. When \"auto\" is specified,"},{"line_number":1188,"context_line":"# default boot mode will be selected based on boot mode"},{"line_number":1189,"context_line":"# settings on the node. (string value)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bacf61ea_0f984977","line":1186,"updated":"2016-08-05 15:13:32.000000000","message":"I think you meant to say \"The default is \"auto\" for backward compatibility.\"","commit_id":"bb75c4e91351ca5566930316d960277e480bd692"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d5eb9c6814163077caee2e2a9e54f7233e9816f1","unresolved":false,"context_lines":[{"line_number":1183,"context_line":"#ca_file \u003d \u003cNone\u003e"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"# Default boot mode to be used in provisioning when it is not"},{"line_number":1186,"context_line":"# specified in node capabilities. Value of \"auto\" is provided"},{"line_number":1187,"context_line":"# for backward compatibility. When \"auto\" is specified,"},{"line_number":1188,"context_line":"# default boot mode will be selected based on boot mode"},{"line_number":1189,"context_line":"# settings on the node. (string value)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9ad45d7e_e0dc3ae6","line":1186,"in_reply_to":"bacf61ea_0f984977","updated":"2016-08-10 05:58:57.000000000","message":"Done","commit_id":"bb75c4e91351ca5566930316d960277e480bd692"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fdd495eb5629ba8ffc3d345484c456ed0c42b8dc","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"# Size of RPC connection pool. (integer value)"},{"line_number":247,"context_line":"# Deprecated group/name - [DEFAULT]/rpc_conn_pool_size"},{"line_number":248,"context_line":"#rpc_conn_pool_size \u003d 30"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# ZeroMQ bind address. Should be a wildcard (*), an ethernet"},{"line_number":251,"context_line":"# interface, or IP. The \"host\" option should point or resolve"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3ac371cc_21b6553d","line":248,"updated":"2016-08-16 16:11:38.000000000","message":"These should not be removed, please rebuild your venv","commit_id":"3a0332cf3f5695e0d24f526f666d649b3bc1e63f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d75ea532378474f910606622ea91540fa26e681a","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"# Size of RPC connection pool. (integer value)"},{"line_number":247,"context_line":"# Deprecated group/name - [DEFAULT]/rpc_conn_pool_size"},{"line_number":248,"context_line":"#rpc_conn_pool_size \u003d 30"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# ZeroMQ bind address. Should be a wildcard (*), an ethernet"},{"line_number":251,"context_line":"# interface, or IP. The \"host\" option should point or resolve"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3ac371cc_890d99ea","line":248,"in_reply_to":"3ac371cc_21b6553d","updated":"2016-08-17 03:21:32.000000000","message":"Done","commit_id":"3a0332cf3f5695e0d24f526f666d649b3bc1e63f"}],"ironic/conf/ilo.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4c588823097549382f56571902ce32a3432cd19b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003d2,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Amount of time in seconds to wait in between power \u0027"},{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027preferred_boot_mode\u0027,"},{"line_number":82,"context_line":"               choices\u003d[\u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":83,"context_line":"               help\u003d_(\u0027Preferred boot mode to be used in provisioning when \u0027"},{"line_number":84,"context_line":"                      \u0027it is not specified in node capabilities\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_4cccebba","line":81,"updated":"2016-07-21 17:18:59.000000000","message":"You wrote in the commit message \"A new configuration parameter \u0027[ilo]/preferred_boot_mode\u0027 has been added to specify default boot mode\". I think better name for this option is \u0027default_boot_mode\u0027","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0f4661ac8d9d42ec093677c510d934689d25df9e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003d2,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Amount of time in seconds to wait in between power \u0027"},{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027preferred_boot_mode\u0027,"},{"line_number":82,"context_line":"               choices\u003d[\u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":83,"context_line":"               help\u003d_(\u0027Preferred boot mode to be used in provisioning when \u0027"},{"line_number":84,"context_line":"                      \u0027it is not specified in node capabilities\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8dda4a15","line":81,"in_reply_to":"dada55a8_4cccebba","updated":"2016-07-22 06:05:40.000000000","message":"Done","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9950c215182108b29c5dee4fbb103cfc84dd8440","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":82,"context_line":"               choices\u003d[\u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":83,"context_line":"               help\u003d_(\u0027Default boot mode to be used in provisioning when \u0027"},{"line_number":84,"context_line":"                      \u0027it is not specified in node capabilities\u0027)),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_c9b4b236","line":83,"updated":"2016-07-26 01:20:16.000000000","message":"please include a choice that is \"None\", to indicate no config setting. Having the default value implicitly None when that isn\u0027t a viable configuration option setting is poor -- this could break users who uncomment every option in the config file (eg, by using config management)\n\nYou may choose to set the default to \"None\" to preserve compatibility, or to change it (noting the potential impact on users of this driver in your release notes)","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"300339f331ff862c37101a3e5a32923e1e11085a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":82,"context_line":"               choices\u003d[\u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":83,"context_line":"               help\u003d_(\u0027Default boot mode to be used in provisioning when \u0027"},{"line_number":84,"context_line":"                      \u0027it is not specified in node capabilities\u0027)),"},{"line_number":85,"context_line":"]"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_62379c4d","line":83,"in_reply_to":"dada55a8_c9b4b236","updated":"2016-07-26 04:05:54.000000000","message":"Done","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d91dd8b6de991d7b28460438793228a6cd1b9e78","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":82,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":84,"context_line":"               default\u003d\u0027None\u0027,"},{"line_number":85,"context_line":"               choices\u003d[\u0027None\u0027, \u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":86,"context_line":"               help\u003d_(\u0027Default boot mode to be used in provisioning when \u0027"},{"line_number":87,"context_line":"                      \u0027it is not specified in node capabilities. Value \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_51b5862f","line":84,"updated":"2016-08-02 12:52:46.000000000","message":"please use Python None, not a string \"None\" (i.e. just remove this \"default\" argument)","commit_id":"78cec371d0668205b0516bedb791efbddc04cfa6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a98d8dc01569d07422c91e7720f713f63e3276b1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.StrOpt(\u0027ca_file\u0027,"},{"line_number":82,"context_line":"               help\u003d_(\u0027CA certificate file to validate iLO.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\u0027default_boot_mode\u0027,"},{"line_number":84,"context_line":"               default\u003d\u0027None\u0027,"},{"line_number":85,"context_line":"               choices\u003d[\u0027None\u0027, \u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":86,"context_line":"               help\u003d_(\u0027Default boot mode to be used in provisioning when \u0027"},{"line_number":87,"context_line":"                      \u0027it is not specified in node capabilities. Value \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_999a476d","line":84,"in_reply_to":"bacf61ea_51b5862f","updated":"2016-08-03 13:13:10.000000000","message":"Have replaced it with \u0027auto\u0027.","commit_id":"78cec371d0668205b0516bedb791efbddc04cfa6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"199de0c6534b02a292383ebfae65f757a8e6b3c1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027it is not specified in node capabilities. Value \u0027"},{"line_number":88,"context_line":"                      \u0027of \"auto\" is provided for backward compatibility. When \u0027"},{"line_number":89,"context_line":"                      \u0027\"auto\" is specified, default boot mode will be \u0027"},{"line_number":90,"context_line":"                      \u0027selected based on boot mode settings on the node.\u0027)),"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_6dd4c81f","line":90,"updated":"2016-08-10 00:00:23.000000000","message":"After reading this, I\u0027m a little confused about the intention of this patch.\n\nWill this setting override a boot_mode setting in a node\u0027s capabilities? If not, why are you referencing boot mode settings on the node?","commit_id":"bb75c4e91351ca5566930316d960277e480bd692"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d5eb9c6814163077caee2e2a9e54f7233e9816f1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \u0027it is not specified in node capabilities. Value \u0027"},{"line_number":88,"context_line":"                      \u0027of \"auto\" is provided for backward compatibility. When \u0027"},{"line_number":89,"context_line":"                      \u0027\"auto\" is specified, default boot mode will be \u0027"},{"line_number":90,"context_line":"                      \u0027selected based on boot mode settings on the node.\u0027)),"},{"line_number":91,"context_line":"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_63bb34e6","line":90,"in_reply_to":"9ad45d7e_6dd4c81f","updated":"2016-08-10 05:58:57.000000000","message":"It would be used when \u0027boot_mode\u0027 capability is not provided in the node \u0027properties/capabilities\u0027. Have rephrased it, please check if this is more clear.","commit_id":"bb75c4e91351ca5566930316d960277e480bd692"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7d7d5d03e3ac7aa2eacd5a5855a7c35eb414cc3f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \u0027\"properties/capabilities\" of the node. The default is \u0027"},{"line_number":89,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":90,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":91,"context_line":"                      \u0027on boot mode settings on the node.\u0027)),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_357d1a6f","line":91,"updated":"2016-08-16 00:08:36.000000000","message":"by \"on the node\", do we mean preexisting firmware configurations? If so, I\u0027d change the word \"node\" to \"system\" or \"ilo\" or whatever else could indicate you\u0027re talking about the hardware, not the ironic node","commit_id":"5c200d6d51ab251d3252531c5b0b73a6f256331c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f9d521eb98509345f4ef5a4337be9eca2b97eec1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      \u0027\"properties/capabilities\" of the node. The default is \u0027"},{"line_number":89,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":90,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"},{"line_number":91,"context_line":"                      \u0027on boot mode settings on the node.\u0027)),"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_0cef3488","line":91,"in_reply_to":"3ac371cc_357d1a6f","updated":"2016-08-16 06:18:37.000000000","message":"Done","commit_id":"5c200d6d51ab251d3252531c5b0b73a6f256331c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"29c1b2933ac4b8dab4d4fd456b1d0ed7007e89cc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               default\u003d\u0027auto\u0027,"},{"line_number":85,"context_line":"               choices\u003d[\u0027auto\u0027, \u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":86,"context_line":"               help\u003d_(\u0027Default boot mode to be used in provisioning when \u0027"},{"line_number":87,"context_line":"                      \u0027\"boot_mode\" capability is not provided in the\u0027"},{"line_number":88,"context_line":"                      \u0027\"properties/capabilities\" of the node. The default is \u0027"},{"line_number":89,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":90,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_bee2b69d","line":87,"updated":"2016-08-19 15:48:55.000000000","message":"missed space","commit_id":"8b2ec52e42fc49646309ab07145d1fe5e20ce0bb"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fe9317a38fe78cdb7a40c6d68ad98477a4eb3a3c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               default\u003d\u0027auto\u0027,"},{"line_number":85,"context_line":"               choices\u003d[\u0027auto\u0027, \u0027bios\u0027, \u0027uefi\u0027],"},{"line_number":86,"context_line":"               help\u003d_(\u0027Default boot mode to be used in provisioning when \u0027"},{"line_number":87,"context_line":"                      \u0027\"boot_mode\" capability is not provided in the\u0027"},{"line_number":88,"context_line":"                      \u0027\"properties/capabilities\" of the node. The default is \u0027"},{"line_number":89,"context_line":"                      \u0027\"auto\" for backward compatibility. When \"auto\" is \u0027"},{"line_number":90,"context_line":"                      \u0027specified, default boot mode will be selected based \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a8ec9b2_255f940f","line":87,"in_reply_to":"1ac06dbe_bee2b69d","updated":"2016-09-19 22:03:25.000000000","message":"I didn\u0027t see anyone address this, so I submitted https://review.openstack.org/372784","commit_id":"8b2ec52e42fc49646309ab07145d1fe5e20ce0bb"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4c588823097549382f56571902ce32a3432cd19b","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                 CONF.ilo.preferred_boot_mode)"},{"line_number":432,"context_line":"    if boot_mode:"},{"line_number":433,"context_line":"        if boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":434,"context_line":"            LOG.info(_LI(\"No boot mode is specified for node %(uuid)s, \""},{"line_number":435,"context_line":"                         \"using preferred boot mode %(boot_mode)s\"),"},{"line_number":436,"context_line":"                     {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":437,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":438,"context_line":"            instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b7de94da","line":435,"range":{"start_line":434,"start_character":26,"end_line":435,"end_character":66},"updated":"2016-07-21 17:18:59.000000000","message":"This can be a wrong message because we do not known here boot_mode comes from get_boot_mode_for_deploy() or from config option.","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0f4661ac8d9d42ec093677c510d934689d25df9e","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                 CONF.ilo.preferred_boot_mode)"},{"line_number":432,"context_line":"    if boot_mode:"},{"line_number":433,"context_line":"        if boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":434,"context_line":"            LOG.info(_LI(\"No boot mode is specified for node %(uuid)s, \""},{"line_number":435,"context_line":"                         \"using preferred boot mode %(boot_mode)s\"),"},{"line_number":436,"context_line":"                     {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":437,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":438,"context_line":"            instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_4dcdf264","line":435,"range":{"start_line":434,"start_character":26,"end_line":435,"end_character":66},"in_reply_to":"dada55a8_b29982c6","updated":"2016-07-22 06:05:40.000000000","message":"Done","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e7e9a40715cfdd1f4363dbbb7174f8bdfe2ea3c4","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                 CONF.ilo.preferred_boot_mode)"},{"line_number":432,"context_line":"    if boot_mode:"},{"line_number":433,"context_line":"        if boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]:"},{"line_number":434,"context_line":"            LOG.info(_LI(\"No boot mode is specified for node %(uuid)s, \""},{"line_number":435,"context_line":"                         \"using preferred boot mode %(boot_mode)s\"),"},{"line_number":436,"context_line":"                     {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":437,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":438,"context_line":"            instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b29982c6","line":435,"range":{"start_line":434,"start_character":26,"end_line":435,"end_character":66},"in_reply_to":"dada55a8_b7de94da","updated":"2016-07-21 17:29:53.000000000","message":"++","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"74ea220b0776fe7ae183c49df7adda364b33d57b","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":438,"context_line":"            instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"},{"line_number":439,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":440,"context_line":"            node.save()"},{"line_number":441,"context_line":"        else:"},{"line_number":442,"context_line":"            LOG.warning(_LW(\"Ignornig \u0027[ilo]/preferred_boot_mode\u0027 \""},{"line_number":443,"context_line":"                            \"configuration for node %(uuid)s. Invalid \""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f24ada53","line":440,"updated":"2016-07-21 17:23:44.000000000","message":"This DB update is not needed if \u0027deploy_boot_mode\u0027 already in node.instance_info.","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0f4661ac8d9d42ec093677c510d934689d25df9e","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            instance_info \u003d node.instance_info"},{"line_number":438,"context_line":"            instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"},{"line_number":439,"context_line":"            node.instance_info \u003d instance_info"},{"line_number":440,"context_line":"            node.save()"},{"line_number":441,"context_line":"        else:"},{"line_number":442,"context_line":"            LOG.warning(_LW(\"Ignornig \u0027[ilo]/preferred_boot_mode\u0027 \""},{"line_number":443,"context_line":"                            \"configuration for node %(uuid)s. Invalid \""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2dc87e54","line":440,"in_reply_to":"dada55a8_f24ada53","updated":"2016-07-22 06:05:40.000000000","message":"Done","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e7e9a40715cfdd1f4363dbbb7174f8bdfe2ea3c4","unresolved":false,"context_lines":[{"line_number":442,"context_line":"            LOG.warning(_LW(\"Ignornig \u0027[ilo]/preferred_boot_mode\u0027 \""},{"line_number":443,"context_line":"                            \"configuration for node %(uuid)s. Invalid \""},{"line_number":444,"context_line":"                            \"value \u0027%(boot_mode)s\u0027 is given. \""},{"line_number":445,"context_line":"                            \"Valid values are \u0027bios\u0027 or \u0027uefi\u0027.\"),"},{"line_number":446,"context_line":"                        {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":447,"context_line":"            boot_mode \u003d None"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_d266b6b9","line":445,"updated":"2016-07-21 17:29:53.000000000","message":"These are the only valid options, how can you specify the incorrect one?","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0f4661ac8d9d42ec093677c510d934689d25df9e","unresolved":false,"context_lines":[{"line_number":442,"context_line":"            LOG.warning(_LW(\"Ignornig \u0027[ilo]/preferred_boot_mode\u0027 \""},{"line_number":443,"context_line":"                            \"configuration for node %(uuid)s. Invalid \""},{"line_number":444,"context_line":"                            \"value \u0027%(boot_mode)s\u0027 is given. \""},{"line_number":445,"context_line":"                            \"Valid values are \u0027bios\u0027 or \u0027uefi\u0027.\"),"},{"line_number":446,"context_line":"                        {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":447,"context_line":"            boot_mode \u003d None"},{"line_number":448,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_6dbef6ae","line":445,"in_reply_to":"dada55a8_d266b6b9","updated":"2016-07-22 06:05:40.000000000","message":"My bad. oslo would take care of this.","commit_id":"cf466cd613e7df27ca3808a5e5010bf918e1cfbf"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9950c215182108b29c5dee4fbb103cfc84dd8440","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    # No boot mode found. Check if default_boot_mode is defined"},{"line_number":433,"context_line":"    if not boot_mode and CONF.ilo.default_boot_mode:"},{"line_number":434,"context_line":"        boot_mode \u003d CONF.ilo.default_boot_mode"},{"line_number":435,"context_line":"        LOG.info(_LI(\"No boot mode is specified for node %(uuid)s, \""},{"line_number":436,"context_line":"                     \"using default boot mode %(boot_mode)s\"),"},{"line_number":437,"context_line":"                 {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":438,"context_line":"        instance_info \u003d node.instance_info"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a9afbee1","line":435,"updated":"2016-07-26 01:20:16.000000000","message":"why is this logging at INFO level...","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"300339f331ff862c37101a3e5a32923e1e11085a","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    # No boot mode found. Check if default_boot_mode is defined"},{"line_number":433,"context_line":"    if not boot_mode and CONF.ilo.default_boot_mode:"},{"line_number":434,"context_line":"        boot_mode \u003d CONF.ilo.default_boot_mode"},{"line_number":435,"context_line":"        LOG.info(_LI(\"No boot mode is specified for node %(uuid)s, \""},{"line_number":436,"context_line":"                     \"using default boot mode %(boot_mode)s\"),"},{"line_number":437,"context_line":"                 {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":438,"context_line":"        instance_info \u003d node.instance_info"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_024ce0c6","line":435,"in_reply_to":"dada55a8_a9afbee1","updated":"2016-07-26 04:05:54.000000000","message":"Done","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9950c215182108b29c5dee4fbb103cfc84dd8440","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    # Boot mode is computed, setting it for the deploy"},{"line_number":444,"context_line":"    if boot_mode:"},{"line_number":445,"context_line":"        LOG.debug(\"Node %(uuid)s boot mode is being set to %(boot_mode)s\","},{"line_number":446,"context_line":"                  {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":447,"context_line":"        set_boot_mode(node, boot_mode)"},{"line_number":448,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_89aabad0","line":445,"updated":"2016-07-26 01:20:16.000000000","message":"but this is logging at DEBUG level?\n\nI would expect these messages to use the same log level, since they indicate the same type of information.\n\nFurthermore, i would expect this information to be logged exactly once, not potentially twice.","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"300339f331ff862c37101a3e5a32923e1e11085a","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    # Boot mode is computed, setting it for the deploy"},{"line_number":444,"context_line":"    if boot_mode:"},{"line_number":445,"context_line":"        LOG.debug(\"Node %(uuid)s boot mode is being set to %(boot_mode)s\","},{"line_number":446,"context_line":"                  {\u0027uuid\u0027: node.uuid, \u0027boot_mode\u0027: boot_mode})"},{"line_number":447,"context_line":"        set_boot_mode(node, boot_mode)"},{"line_number":448,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_a2523465","line":445,"in_reply_to":"dada55a8_89aabad0","updated":"2016-07-26 04:05:54.000000000","message":"Done","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d91dd8b6de991d7b28460438793228a6cd1b9e78","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    # No boot mode found. Check if default_boot_mode is defined"},{"line_number":441,"context_line":"    if not boot_mode and (CONF.ilo.default_boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]):"},{"line_number":442,"context_line":"        boot_mode \u003d CONF.ilo.default_boot_mode"},{"line_number":443,"context_line":"        instance_info \u003d node.instance_info"},{"line_number":444,"context_line":"        instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_71b88a2b","line":441,"updated":"2016-08-02 12:52:46.000000000","message":"if you apply the fix suggested above, it will be just\n\n if not boot_mode and CONF.ilo.default_boot_mode:","commit_id":"78cec371d0668205b0516bedb791efbddc04cfa6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a98d8dc01569d07422c91e7720f713f63e3276b1","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    # No boot mode found. Check if default_boot_mode is defined"},{"line_number":441,"context_line":"    if not boot_mode and (CONF.ilo.default_boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]):"},{"line_number":442,"context_line":"        boot_mode \u003d CONF.ilo.default_boot_mode"},{"line_number":443,"context_line":"        instance_info \u003d node.instance_info"},{"line_number":444,"context_line":"        instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_59cc4f61","line":441,"in_reply_to":"bacf61ea_71b88a2b","updated":"2016-08-03 13:13:10.000000000","message":"Added \u0027auto\u0027 as a option instead of \u0027None\u0027. No further code change required here.","commit_id":"78cec371d0668205b0516bedb791efbddc04cfa6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"29c1b2933ac4b8dab4d4fd456b1d0ed7007e89cc","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    # No boot mode found. Check if default_boot_mode is defined"},{"line_number":441,"context_line":"    if not boot_mode and (CONF.ilo.default_boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]):"},{"line_number":442,"context_line":"        boot_mode \u003d CONF.ilo.default_boot_mode"},{"line_number":443,"context_line":"        instance_info \u003d node.instance_info"},{"line_number":444,"context_line":"        instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_e1c81377","line":441,"updated":"2016-08-19 15:48:55.000000000","message":"CONF.ilo.default_boot_mode \u003d\u003d \u0027auto\u0027","commit_id":"8b2ec52e42fc49646309ab07145d1fe5e20ce0bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"75bd6e826737c0b029080a674fc4bbf2fdd2f9b4","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    # No boot mode found. Check if default_boot_mode is defined"},{"line_number":441,"context_line":"    if not boot_mode and (CONF.ilo.default_boot_mode in [\u0027bios\u0027, \u0027uefi\u0027]):"},{"line_number":442,"context_line":"        boot_mode \u003d CONF.ilo.default_boot_mode"},{"line_number":443,"context_line":"        instance_info \u003d node.instance_info"},{"line_number":444,"context_line":"        instance_info[\u0027deploy_boot_mode\u0027] \u003d boot_mode"}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_4103e773","line":441,"in_reply_to":"1ac06dbe_e1c81377","updated":"2016-08-19 15:49:56.000000000","message":"I\u0027m sorry should be not equal: CONF.ilo.default_boot_mode !\u003d \u0027auto\u0027","commit_id":"8b2ec52e42fc49646309ab07145d1fe5e20ce0bb"}],"ironic/tests/unit/drivers/modules/ilo/test_common.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"29c1b2933ac4b8dab4d4fd456b1d0ed7007e89cc","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    @mock.patch.object(ilo_common, \u0027get_ilo_object\u0027, spec_set\u003dTrue,"},{"line_number":389,"context_line":"                       autospec\u003dTrue)"},{"line_number":390,"context_line":"    def test_update_boot_mode(self, get_ilo_object_mock):"},{"line_number":391,"context_line":"        self.config(default_boot_mode\u003d\"auto\", group\u003d\u0027ilo\u0027)"},{"line_number":392,"context_line":"        ilo_mock_obj \u003d get_ilo_object_mock.return_value"},{"line_number":393,"context_line":"        ilo_mock_obj.get_pending_boot_mode.return_value \u003d \u0027LEGACY\u0027"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1ac06dbe_5e446273","line":391,"updated":"2016-08-19 15:48:55.000000000","message":"it is a default value, seems line is not needed.","commit_id":"8b2ec52e42fc49646309ab07145d1fe5e20ce0bb"}],"releasenotes/notes/ilo-inconsistent-default-boot-mode-ef5a7c56372f89f1.yaml":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"9950c215182108b29c5dee4fbb103cfc84dd8440","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    no boot mode is explicitly passed to iLO drivers."},{"line_number":13,"context_line":"    iLO drivers will exhibit current behavior if this"},{"line_number":14,"context_line":"    configuration parameter is \u0027None\u0027 or has invalid"},{"line_number":15,"context_line":"    value."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dada55a8_e9b9b62f","line":15,"updated":"2016-07-26 01:20:16.000000000","message":"invalid config value should result in ironic-conductor process refusing to start","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"300339f331ff862c37101a3e5a32923e1e11085a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    no boot mode is explicitly passed to iLO drivers."},{"line_number":13,"context_line":"    iLO drivers will exhibit current behavior if this"},{"line_number":14,"context_line":"    configuration parameter is \u0027None\u0027 or has invalid"},{"line_number":15,"context_line":"    value."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dada55a8_8209f086","line":15,"in_reply_to":"dada55a8_e9b9b62f","updated":"2016-07-26 04:05:54.000000000","message":"My bad. Done.","commit_id":"674e0ec4e3e6dfa1156bb12b7f0eb63a73c6dae7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"199de0c6534b02a292383ebfae65f757a8e6b3c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    drivers, it picks default boot mode based on series"},{"line_number":5,"context_line":"    of factors like, pending boot mode setting, UEFI"},{"line_number":6,"context_line":"    boot mode support on the node. This causes confusion"},{"line_number":7,"context_line":"    to the users as these factors are node specific and"},{"line_number":8,"context_line":"    beyond user\u0027s control. User expects a predictable"},{"line_number":9,"context_line":"    behavior when no boot mode is explicitly passed."},{"line_number":10,"context_line":"    Added a new configuration parameter"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_ed69d8bf","line":7,"updated":"2016-08-10 00:00:23.000000000","message":"This release note is not clear at all, and given we\u0027re close to a release it should be before this patch merges.\n\nSuggested rewrite of this entire section:\n\nWhen no boot mode is explicitly set on a node using an iLO driver, ironic automatically picks a boot mode. This confuses deployers, as these factors are node specific and not configurable. In order to ensure predictable behavior, a new configuration parameter, ``[ilo]/default_boot_mode``, was added to allow deployers to explicitly set a default. The default value of this option keeps behavior consistent for existing deployments.","commit_id":"bb75c4e91351ca5566930316d960277e480bd692"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d5eb9c6814163077caee2e2a9e54f7233e9816f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    drivers, it picks default boot mode based on series"},{"line_number":5,"context_line":"    of factors like, pending boot mode setting, UEFI"},{"line_number":6,"context_line":"    boot mode support on the node. This causes confusion"},{"line_number":7,"context_line":"    to the users as these factors are node specific and"},{"line_number":8,"context_line":"    beyond user\u0027s control. User expects a predictable"},{"line_number":9,"context_line":"    behavior when no boot mode is explicitly passed."},{"line_number":10,"context_line":"    Added a new configuration parameter"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_c05ad64f","line":7,"in_reply_to":"9ad45d7e_ed69d8bf","updated":"2016-08-10 05:58:57.000000000","message":"Done","commit_id":"bb75c4e91351ca5566930316d960277e480bd692"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c47949ee74bea01cd38bed3f941cc2efc42b9e81","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When no boot mode is explicitly set on a node using"},{"line_number":4,"context_line":"    an iLO driver, ironic automatically picks a boot"},{"line_number":5,"context_line":"    mode. This confuses deployers, as these factors are"},{"line_number":6,"context_line":"    node specific and not configurable. In order to"},{"line_number":7,"context_line":"    ensure predictable behavior, a new configuration"},{"line_number":8,"context_line":"    parameter, ``[ilo]/default_boot_mode``, was added"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ac371cc_763ea3b9","line":5,"updated":"2016-08-15 10:05:51.000000000","message":"nit: \"picks a boot mode based on hardware capabilities\"","commit_id":"5c200d6d51ab251d3252531c5b0b73a6f256331c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f9d521eb98509345f4ef5a4337be9eca2b97eec1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When no boot mode is explicitly set on a node using"},{"line_number":4,"context_line":"    an iLO driver, ironic automatically picks a boot"},{"line_number":5,"context_line":"    mode. This confuses deployers, as these factors are"},{"line_number":6,"context_line":"    node specific and not configurable. In order to"},{"line_number":7,"context_line":"    ensure predictable behavior, a new configuration"},{"line_number":8,"context_line":"    parameter, ``[ilo]/default_boot_mode``, was added"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ac371cc_2c483087","line":5,"in_reply_to":"3ac371cc_7521524d","updated":"2016-08-16 06:18:37.000000000","message":"Done","commit_id":"5c200d6d51ab251d3252531c5b0b73a6f256331c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"f9d521eb98509345f4ef5a4337be9eca2b97eec1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When no boot mode is explicitly set on a node using"},{"line_number":4,"context_line":"    an iLO driver, ironic automatically picks a boot"},{"line_number":5,"context_line":"    mode. This confuses deployers, as these factors are"},{"line_number":6,"context_line":"    node specific and not configurable. In order to"},{"line_number":7,"context_line":"    ensure predictable behavior, a new configuration"},{"line_number":8,"context_line":"    parameter, ``[ilo]/default_boot_mode``, was added"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ac371cc_6c5a2852","line":5,"in_reply_to":"3ac371cc_763ea3b9","updated":"2016-08-16 06:18:37.000000000","message":"Done","commit_id":"5c200d6d51ab251d3252531c5b0b73a6f256331c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7d7d5d03e3ac7aa2eacd5a5855a7c35eb414cc3f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - When no boot mode is explicitly set on a node using"},{"line_number":4,"context_line":"    an iLO driver, ironic automatically picks a boot"},{"line_number":5,"context_line":"    mode. This confuses deployers, as these factors are"},{"line_number":6,"context_line":"    node specific and not configurable. In order to"},{"line_number":7,"context_line":"    ensure predictable behavior, a new configuration"},{"line_number":8,"context_line":"    parameter, ``[ilo]/default_boot_mode``, was added"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3ac371cc_7521524d","line":5,"in_reply_to":"3ac371cc_763ea3b9","updated":"2016-08-16 00:08:36.000000000","message":"If this is what\u0027s intended, we should make it clearer in the config description that I commented on as well.","commit_id":"5c200d6d51ab251d3252531c5b0b73a6f256331c"}]}
