)]}'
{"ironic/drivers/modules/ilo/inspect.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6313d4eeefd8ba24050cc535111b6d1a65fc81a9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        except exception.MACAlreadyExists:"},{"line_number":59,"context_line":"            LOG.warning(_LW(\"Port already exists for MAC address %(address)s \""},{"line_number":60,"context_line":"                            \"for node %(node)s\"),"},{"line_number":61,"context_line":"                        {\u0027address\u0027: mac, \u0027node\u0027: node.uuid})"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _get_essential_properties(node, ilo_object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_7b9c7ec0","line":61,"updated":"2016-08-22 12:27:16.000000000","message":"might be better to move LOG.info ourside of try:\n\ntry:\n    port.create()\nexcept ...:\n    ...\nelse:\n    LOG.info(_LI(\"Port created for MAC address %(address)s for node \"\n                         \"%(node)s\"), {\u0027address\u0027: mac, \u0027node\u0027: node.uuid})","commit_id":"8009703cd47b5f625f2223374d1933e80e3cdea9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47cf7771bb1ca8e7657234e29532518bdb3c811c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        except exception.MACAlreadyExists:"},{"line_number":59,"context_line":"            LOG.warning(_LW(\"Port already exists for MAC address %(address)s \""},{"line_number":60,"context_line":"                            \"for node %(node)s\"),"},{"line_number":61,"context_line":"                        {\u0027address\u0027: mac, \u0027node\u0027: node.uuid})"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _get_essential_properties(node, ilo_object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_fbdceee5","line":61,"in_reply_to":"1ac06dbe_7b9c7ec0","updated":"2016-08-22 12:59:15.000000000","message":"Will be the same semantic because LOG.info() does not raise MACAlreadyExists.","commit_id":"8009703cd47b5f625f2223374d1933e80e3cdea9"}],"ironic/tests/unit/drivers/modules/ilo/test_inspect.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1193ac80c18718cbc0b9f7f07890b3a52ec8f81d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":241,"context_line":"            ilo_inspect._create_ports_if_not_exist(task, macs)"},{"line_number":242,"context_line":"            self.assertTrue(log_mock.called)"},{"line_number":243,"context_line":"            port_mock.assert_any_call(task.context, **port_dict1)"},{"line_number":244,"context_line":"            port_mock.assert_any_call(task.context, **port_dict2)"},{"line_number":245,"context_line":"            port_obj1.create.assert_called_once_with()"},{"line_number":246,"context_line":"            port_obj2.create.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_0409b031","line":243,"range":{"start_line":243,"start_character":22,"end_line":243,"end_character":37},"updated":"2016-08-22 12:13:12.000000000","message":"you could use assert_has_calls here.","commit_id":"8009703cd47b5f625f2223374d1933e80e3cdea9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47cf7771bb1ca8e7657234e29532518bdb3c811c","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":241,"context_line":"            ilo_inspect._create_ports_if_not_exist(task, macs)"},{"line_number":242,"context_line":"            self.assertTrue(log_mock.called)"},{"line_number":243,"context_line":"            port_mock.assert_any_call(task.context, **port_dict1)"},{"line_number":244,"context_line":"            port_mock.assert_any_call(task.context, **port_dict2)"},{"line_number":245,"context_line":"            port_obj1.create.assert_called_once_with()"},{"line_number":246,"context_line":"            port_obj2.create.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_6ebb1ee6","line":243,"range":{"start_line":243,"start_character":22,"end_line":243,"end_character":37},"in_reply_to":"1ac06dbe_0409b031","updated":"2016-08-22 12:59:15.000000000","message":"Done","commit_id":"8009703cd47b5f625f2223374d1933e80e3cdea9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8da6d05ae82361287f9bf22f509ec3dbcfdbfc11","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":261,"context_line":"            ilo_inspect._create_ports_if_not_exist(task, macs)"},{"line_number":262,"context_line":"        log_warn_mock.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":263,"context_line":"        log_info_mock.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test__get_essential_properties_ok(self):"},{"line_number":266,"context_line":"        ilo_mock \u003d mock.MagicMock(spec\u003d[\u0027get_essential_properties\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_b8d27cd0","line":263,"updated":"2016-08-22 12:22:02.000000000","message":"log_info seems to be shouldn\u0027t be called if exception occurs.","commit_id":"8009703cd47b5f625f2223374d1933e80e3cdea9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"47cf7771bb1ca8e7657234e29532518bdb3c811c","unresolved":false,"context_lines":[{"line_number":260,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":261,"context_line":"            ilo_inspect._create_ports_if_not_exist(task, macs)"},{"line_number":262,"context_line":"        log_warn_mock.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":263,"context_line":"        log_info_mock.assert_called_once_with(mock.ANY, mock.ANY)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test__get_essential_properties_ok(self):"},{"line_number":266,"context_line":"        ilo_mock \u003d mock.MagicMock(spec\u003d[\u0027get_essential_properties\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_0eeeeaeb","line":263,"in_reply_to":"1ac06dbe_b8d27cd0","updated":"2016-08-22 12:59:15.000000000","message":"If called for one port of two (see side_effect). This test can be simple.","commit_id":"8009703cd47b5f625f2223374d1933e80e3cdea9"}]}
