)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dfbad4a427951c16e11e0cfffe74594fc53786b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-19 13:46:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add storage_interface DB field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add storage_interface DB field, database migration,"},{"line_number":10,"context_line":"and object entry for storage_interface for boot from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1a6eadb0_fa032ab6","line":7,"updated":"2016-12-20 22:14:46.000000000","message":"would be useful it it said node somewhere. I mistakenly thought it was a new table.","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fab4d9eba0736e5fa5f71c544ce9e09fcaccb170","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Julia Kreger \u003cjuliaashleykreger@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-19 13:46:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add storage_interface DB field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add storage_interface DB field, database migration,"},{"line_number":10,"context_line":"and object entry for storage_interface for boot from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1a6eadb0_23539be3","line":7,"in_reply_to":"1a6eadb0_fa032ab6","updated":"2016-12-21 15:29:40.000000000","message":"Done","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dfbad4a427951c16e11e0cfffe74594fc53786b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"but since then Ironic\u0027s code has drifted such that"},{"line_number":15,"context_line":"adding an object for an interface has to take place"},{"line_number":16,"context_line":"with the entire driver interface, thus that will"},{"line_number":17,"context_line":"need to be moved to the next revision."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Stephane Miller \u003cstephane@alum.mit.edu\u003e"},{"line_number":20,"context_line":"Change-Id: Ib5d5de87163570949c12d9e95c73e17c1c12eec1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1a6eadb0_7add5a41","line":17,"updated":"2016-12-20 22:14:46.000000000","message":"took me awhile to figure out what this was talking about. The Node object already exists, you mean adding a storage_interface field to the Node object, right?","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fab4d9eba0736e5fa5f71c544ce9e09fcaccb170","unresolved":false,"context_lines":[{"line_number":14,"context_line":"but since then Ironic\u0027s code has drifted such that"},{"line_number":15,"context_line":"adding an object for an interface has to take place"},{"line_number":16,"context_line":"with the entire driver interface, thus that will"},{"line_number":17,"context_line":"need to be moved to the next revision."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Stephane Miller \u003cstephane@alum.mit.edu\u003e"},{"line_number":20,"context_line":"Change-Id: Ib5d5de87163570949c12d9e95c73e17c1c12eec1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1a6eadb0_43b41734","line":17,"in_reply_to":"1a6eadb0_7add5a41","updated":"2016-12-21 15:29:40.000000000","message":"Yes, exactly.  I can remove this, it was much more of an information for those reading commit messages as to why this this patch is so light at this point.","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"}],"ironic/db/sqlalchemy/alembic/versions/1d6951876d68_add_storage_interface_db_field_and_.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"e8e1f2a348dad1d06b4b352f3749499787e76772","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose ta system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("}],"source_content_type":"text/x-python","patch_set":25,"id":"7a77a97e_dcb42584","line":43,"range":{"start_line":43,"start_character":37,"end_line":43,"end_character":39},"updated":"2016-11-21 07:13:33.000000000","message":"Nit: Is this a typo?","commit_id":"ed96eb8f48edce952e2f4e8089fc1a5ff2b953f3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1e25e59fb2ed6ad0ef934ae8bb24bd1403306ae","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose ta system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("}],"source_content_type":"text/x-python","patch_set":25,"id":"7a77a97e_2430859e","line":43,"range":{"start_line":43,"start_character":37,"end_line":43,"end_character":39},"in_reply_to":"7a77a97e_dcb42584","updated":"2016-11-21 16:55:11.000000000","message":"It is!  Good catch, thank you!","commit_id":"ed96eb8f48edce952e2f4e8089fc1a5ff2b953f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6df1188e8885087da76450c64ac7b1532980ec3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027storage_interface\u0027,"},{"line_number":33,"context_line":"                                     sa.String(255),"},{"line_number":34,"context_line":"                                     default\u003d\u0027no-storage\u0027,"},{"line_number":35,"context_line":"                                     nullable\u003dTrue))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    node \u003d table(\u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_e9559dfa","line":34,"updated":"2016-12-07 14:14:35.000000000","message":"I\u0027d prefer we don\u0027t do it here, please update https://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L75-L99 instead","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e412d099082fde708d75c4859d32df70dd5d7ba","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027storage_interface\u0027,"},{"line_number":33,"context_line":"                                     sa.String(255),"},{"line_number":34,"context_line":"                                     default\u003d\u0027no-storage\u0027,"},{"line_number":35,"context_line":"                                     nullable\u003dTrue))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    node \u003d table(\u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_0bee4322","line":34,"in_reply_to":"3a71b18c_e9559dfa","updated":"2016-12-12 22:04:30.000000000","message":"Done, the default will apply with new tasks in the next revision.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1a600259c3efc19c55579ff1f8c5cf265c0396c2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                 column(\u0027uuid\u0027, String(36)),"},{"line_number":39,"context_line":"                 column(\u0027storage_interface\u0027, String(255)))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_6a98c66a","line":41,"updated":"2016-12-06 19:09:48.000000000","message":"I believe that can be added after this patch lands: https://review.openstack.org/#/c/336626/21/etc/ironic/ironic.conf.sample","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e412d099082fde708d75c4859d32df70dd5d7ba","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                 column(\u0027uuid\u0027, String(36)),"},{"line_number":39,"context_line":"                 column(\u0027storage_interface\u0027, String(255)))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_2bf3ff0b","line":41,"in_reply_to":"3a71b18c_6a98c66a","updated":"2016-12-12 22:04:30.000000000","message":"Removing because I don\u0027t think we need it with driver comp.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6df1188e8885087da76450c64ac7b1532980ec3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_095bb92f","line":43,"updated":"2016-12-07 14:14:35.000000000","message":"I don\u0027t think we should change the migration, but I also don\u0027t think it\u0027s necessary: the migration will run when no nodes still support storage. But I also don\u0027t think we should do it at all, because check_and_update_node_interfaces runs on both storing a node and loading it. Let\u0027s update it instead.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6df1188e8885087da76450c64ac7b1532980ec3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("},{"line_number":47,"context_line":"        node.update().where("}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_29407535","line":44,"updated":"2016-12-07 14:14:35.000000000","message":"actually we also don\u0027t have such entry point. I think we need it to be created in this patch, otherwise I\u0027m not sure how we\u0027ll load such nodes..","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e412d099082fde708d75c4859d32df70dd5d7ba","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":42,"context_line":"    # option is available, we should update the upgrade"},{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("},{"line_number":47,"context_line":"        node.update().where("}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_8248845d","line":44,"in_reply_to":"3a71b18c_29407535","updated":"2016-12-12 22:04:30.000000000","message":"Well, we add the field into the driver interface later.  The key here is to create a field with an initially populated value.  This part of the code, is still needed though, to set the field to an initial value so we don\u0027t fail upon upgrades.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1a600259c3efc19c55579ff1f8c5cf265c0396c2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("},{"line_number":47,"context_line":"        node.update().where("},{"line_number":48,"context_line":"            node.c.storage_interface \u003d\u003d null()).values("},{"line_number":49,"context_line":"                {\u0027storage_interface\u0027: storage_iface}))"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_6aafe67c","line":46,"updated":"2016-12-06 19:09:48.000000000","message":"Is this needed, given that the default is no-storage? It won\u0027t hurt, I suppose.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e412d099082fde708d75c4859d32df70dd5d7ba","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    # to allow an operator to choose the system wide default."},{"line_number":44,"context_line":"    storage_iface \u003d \u0027no-storage\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op.execute("},{"line_number":47,"context_line":"        node.update().where("},{"line_number":48,"context_line":"            node.c.storage_interface \u003d\u003d null()).values("},{"line_number":49,"context_line":"                {\u0027storage_interface\u0027: storage_iface}))"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_eb81074f","line":46,"in_reply_to":"3a71b18c_6aafe67c","updated":"2016-12-12 22:04:30.000000000","message":"Removing because I don\u0027t think we need it with driver comp.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"317071fbf401c5e6c19e9a7b16210ffc34cb66f9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    raid_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":154,"context_line":"    power_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":155,"context_line":"    vendor_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":156,"context_line":"    storage_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_4a5ba32e","line":156,"updated":"2016-12-13 19:00:21.000000000","message":"nit: I\u0027d slightly prefer this columns definitions to be sorted","commit_id":"c048957d630c95fe2dadd91afe660c0b88014584"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dfbad4a427951c16e11e0cfffe74594fc53786b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    raid_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":154,"context_line":"    power_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":155,"context_line":"    vendor_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":156,"context_line":"    storage_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_9af6b6f7","line":156,"updated":"2016-12-20 22:14:46.000000000","message":"nit: the other interfaces are in alpha order, so would be nice if this was too.","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fab4d9eba0736e5fa5f71c544ce9e09fcaccb170","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    raid_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":154,"context_line":"    power_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":155,"context_line":"    vendor_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":156,"context_line":"    storage_interface \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class Port(Base):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_08f79c8b","line":156,"in_reply_to":"1a6eadb0_9af6b6f7","updated":"2016-12-21 15:29:40.000000000","message":"Done","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"}],"ironic/objects/node.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"e8e1f2a348dad1d06b4b352f3749499787e76772","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _default_storage_interfaces():"},{"line_number":39,"context_line":"    # TODO(Presently the only available option is \u0027no-storage\u0027, however"},{"line_number":40,"context_line":"    # once default_storage_interfaces is introduced in configuration,"},{"line_number":41,"context_line":"    # this will need to be updated. I.e. in the next patch."},{"line_number":42,"context_line":"    storage_interface \u003d \u0027no-storage\u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a77a97e_1c5dbd48","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":11},"updated":"2016-11-21 07:13:33.000000000","message":"Nit: Should this be TODO(TheJulia): instead?","commit_id":"ed96eb8f48edce952e2f4e8089fc1a5ff2b953f3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d1e25e59fb2ed6ad0ef934ae8bb24bd1403306ae","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _default_storage_interfaces():"},{"line_number":39,"context_line":"    # TODO(Presently the only available option is \u0027no-storage\u0027, however"},{"line_number":40,"context_line":"    # once default_storage_interfaces is introduced in configuration,"},{"line_number":41,"context_line":"    # this will need to be updated. I.e. in the next patch."},{"line_number":42,"context_line":"    storage_interface \u003d \u0027no-storage\u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a77a97e_84cdd988","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":11},"in_reply_to":"7a77a97e_1c5dbd48","updated":"2016-11-21 16:55:11.000000000","message":"ROFL, yes!  Will be fixed shortly, thank you!","commit_id":"ed96eb8f48edce952e2f4e8089fc1a5ff2b953f3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"3effacb0384dc1e76c4b7c1c29eb1923ec41517f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027raid_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":142,"context_line":"        \u0027vendor_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":143,"context_line":"        \u0027storage_interface\u0027: object_fields.StringFieldThatAcceptsCallable("},{"line_number":144,"context_line":"            nullable\u003dFalse, default\u003d_default_storage_interfaces),"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _validate_property_values(self, properties):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_11bb6d0f","line":144,"updated":"2016-11-25 12:01:18.000000000","message":"this is probably correct, but in my patch I\u0027m getting rid of this StringFieldThatAcceptsCallable thing in favor of just a nullable string.. do you think you could calculate the default on conductor side to avoid me doing the same for your interface?","commit_id":"14dd997b11eb3b45de87f709b7a5bb44c24af556"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64f2f416d3f9a80faec8dfeb777ba5455c08ffa","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027raid_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":142,"context_line":"        \u0027vendor_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":143,"context_line":"        \u0027storage_interface\u0027: object_fields.StringFieldThatAcceptsCallable("},{"line_number":144,"context_line":"            nullable\u003dFalse, default\u003d_default_storage_interfaces),"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _validate_property_values(self, properties):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_fa723d10","line":144,"in_reply_to":"5a74a57a_11bb6d0f","updated":"2016-11-25 16:14:40.000000000","message":"So are you thinking \"if I as the conductor see a null value, then I automatically fill in the blank when I load up the driver?\"  I feel like I/we tried that, first with network, and myself later with storage and we ran into nothing but issues.\n\nUltimately the whole of driver composition may fix those headaches.  But creation being moved to the conductor, and becoming a blocking operation attempting to create a node from the defined data would make that simple.  Although, then what about upgrades...","commit_id":"14dd997b11eb3b45de87f709b7a5bb44c24af556"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c48e2d9924028ab787c33f74129107806f40149","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027raid_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":142,"context_line":"        \u0027vendor_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":143,"context_line":"        \u0027storage_interface\u0027: object_fields.StringFieldThatAcceptsCallable("},{"line_number":144,"context_line":"            nullable\u003dFalse, default\u003d_default_storage_interfaces),"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _validate_property_values(self, properties):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_8d334cf6","line":144,"in_reply_to":"5a74a57a_868c34db","updated":"2016-11-29 20:13:37.000000000","message":"I\u0027ve reviewed it.  I\u0027m hoping it lands quickly because otherwise your ask effectively blocks me from continuing until it, or the volume target RPC revisions land. :)","commit_id":"14dd997b11eb3b45de87f709b7a5bb44c24af556"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"650ebe8ad4bbfacce21a7b9146ca0e4138da3ca4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \u0027raid_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":142,"context_line":"        \u0027vendor_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":143,"context_line":"        \u0027storage_interface\u0027: object_fields.StringFieldThatAcceptsCallable("},{"line_number":144,"context_line":"            nullable\u003dFalse, default\u003d_default_storage_interfaces),"},{"line_number":145,"context_line":"    }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _validate_property_values(self, properties):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_868c34db","line":144,"in_reply_to":"5a74a57a_fa723d10","updated":"2016-11-29 08:44:48.000000000","message":"Please see https://review.openstack.org/401311 for what I\u0027m changing and how.","commit_id":"14dd997b11eb3b45de87f709b7a5bb44c24af556"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b6df1188e8885087da76450c64ac7b1532980ec3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \u0027power_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":125,"context_line":"        \u0027raid_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":126,"context_line":"        \u0027vendor_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":127,"context_line":"        \u0027storage_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _validate_property_values(self, properties):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_c950e10d","line":127,"updated":"2016-12-07 14:14:35.000000000","message":"nit: the list of interfaces is sorted","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e412d099082fde708d75c4859d32df70dd5d7ba","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \u0027power_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":125,"context_line":"        \u0027raid_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":126,"context_line":"        \u0027vendor_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":127,"context_line":"        \u0027storage_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _validate_property_values(self, properties):"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_811a3916","line":127,"in_reply_to":"3a71b18c_c950e10d","updated":"2016-12-12 22:04:30.000000000","message":"Done","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1a600259c3efc19c55579ff1f8c5cf265c0396c2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        name \u003d \u0027%s_interface\u0027 % iface"},{"line_number":105,"context_line":"        if name not in kw:"},{"line_number":106,"context_line":"            node.pop(name)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if \u0027resource_class\u0027 not in kw:"},{"line_number":109,"context_line":"        node.pop(\u0027resource_class\u0027)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_8ae9a2b9","line":107,"updated":"2016-12-06 19:09:48.000000000","message":"nit: this is unrelated","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8e412d099082fde708d75c4859d32df70dd5d7ba","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        name \u003d \u0027%s_interface\u0027 % iface"},{"line_number":105,"context_line":"        if name not in kw:"},{"line_number":106,"context_line":"            node.pop(name)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    if \u0027resource_class\u0027 not in kw:"},{"line_number":109,"context_line":"        node.pop(\u0027resource_class\u0027)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_c1b991ee","line":107,"in_reply_to":"3a71b18c_8ae9a2b9","updated":"2016-12-12 22:04:30.000000000","message":"Fixed, was legacy from prior to driver comp.","commit_id":"3393ebb017b9c687a8368fac5e07cce4b3d6fabe"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"d1936e7f2eb67bfe7baf50c6e7b9fb1462286869","unresolved":false,"context_lines":[{"line_number":2591,"context_line":"                    \u0027raid\u0027: {\u0027result\u0027: True},"},{"line_number":2592,"context_line":"                    \u0027deploy\u0027: {\u0027result\u0027: True},"},{"line_number":2593,"context_line":"                    \u0027network\u0027: {\u0027result\u0027: True}}"},{"line_number":2594,"context_line":""},{"line_number":2595,"context_line":"        self.assertEqual(expected, ret)"},{"line_number":2596,"context_line":"        mock_iwdi.assert_called_once_with(self.context, node.instance_info)"},{"line_number":2597,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_5800ebaa","line":2594,"updated":"2016-12-19 18:14:43.000000000","message":"nit: change is unrelated","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fab4d9eba0736e5fa5f71c544ce9e09fcaccb170","unresolved":false,"context_lines":[{"line_number":2591,"context_line":"                    \u0027raid\u0027: {\u0027result\u0027: True},"},{"line_number":2592,"context_line":"                    \u0027deploy\u0027: {\u0027result\u0027: True},"},{"line_number":2593,"context_line":"                    \u0027network\u0027: {\u0027result\u0027: True}}"},{"line_number":2594,"context_line":""},{"line_number":2595,"context_line":"        self.assertEqual(expected, ret)"},{"line_number":2596,"context_line":"        mock_iwdi.assert_called_once_with(self.context, node.instance_info)"},{"line_number":2597,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_2847f8bc","line":2594,"in_reply_to":"1a6eadb0_5800ebaa","updated":"2016-12-21 15:29:40.000000000","message":"Ahh, result of ripping the storage interface back out of this patchset again.  Removing.","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dfbad4a427951c16e11e0cfffe74594fc53786b","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        for row in result:"},{"line_number":624,"context_line":"            self.assertEqual(CONF.default_portgroup_mode, row[\u0027mode\u0027])"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def _pre_upgrade_1d6951876d68(self, engine):"},{"line_number":627,"context_line":"        # Add nodes for verification"},{"line_number":628,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":629,"context_line":"        data \u003d [{\u0027uuid\u0027: uuidutils.generate_uuid()}]"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_7a0f1ae1","line":626,"updated":"2016-12-20 22:14:46.000000000","message":"this isn\u0027t needed; I don\u0027t see it being used in the test at L633","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fab4d9eba0736e5fa5f71c544ce9e09fcaccb170","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        for row in result:"},{"line_number":624,"context_line":"            self.assertEqual(CONF.default_portgroup_mode, row[\u0027mode\u0027])"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def _pre_upgrade_1d6951876d68(self, engine):"},{"line_number":627,"context_line":"        # Add nodes for verification"},{"line_number":628,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":629,"context_line":"        data \u003d [{\u0027uuid\u0027: uuidutils.generate_uuid()}]"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_c814c44e","line":626,"in_reply_to":"1a6eadb0_7a0f1ae1","updated":"2016-12-21 15:29:40.000000000","message":"Done","commit_id":"a1d9ade9bd1c0c50782093634b09a1d7e4864773"}]}
