)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"5a617c43fc91d22b5c074cbde9269be5dad90c80","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# operator deployment specific capability. A complete list of"},{"line_number":60,"context_line":"# storage interfaces present on the conductor can be found by"},{"line_number":61,"context_line":"# enumerating the \"ironic.hardware.interfaces.storage\""},{"line_number":62,"context_line":"# entrypoint. This value must be the same on all ironic-"},{"line_number":63,"context_line":"# conductor services. (list value)"},{"line_number":64,"context_line":"#enabled_storage_interfaces \u003d no-storage"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Default storage interface to be used for nodes that do not"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"7a77a97e_bf02fb07","line":63,"range":{"start_line":62,"start_character":14,"end_line":63,"end_character":20},"updated":"2016-11-21 07:59:05.000000000","message":"Just a question, what happens if this is not the case?  Can you point me to the consequences of this?","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b9a78bc40685433a25c06f905283843de8c678d2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# operator deployment specific capability. A complete list of"},{"line_number":60,"context_line":"# storage interfaces present on the conductor can be found by"},{"line_number":61,"context_line":"# enumerating the \"ironic.hardware.interfaces.storage\""},{"line_number":62,"context_line":"# entrypoint. This value must be the same on all ironic-"},{"line_number":63,"context_line":"# conductor services. (list value)"},{"line_number":64,"context_line":"#enabled_storage_interfaces \u003d no-storage"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Default storage interface to be used for nodes that do not"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"7a77a97e_e962a83c","line":63,"range":{"start_line":62,"start_character":14,"end_line":63,"end_character":20},"in_reply_to":"7a77a97e_0077ee02","updated":"2016-11-22 18:10:58.000000000","message":"It would be the same for any interface that was not configured under driver composition, the control of the node or specific action requested would fail.  For storage specifically, attachment, detachment, teardown would all fail.","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c54ff1be063a503d2b2b1ce3f58458a23f47368e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# operator deployment specific capability. A complete list of"},{"line_number":60,"context_line":"# storage interfaces present on the conductor can be found by"},{"line_number":61,"context_line":"# enumerating the \"ironic.hardware.interfaces.storage\""},{"line_number":62,"context_line":"# entrypoint. This value must be the same on all ironic-"},{"line_number":63,"context_line":"# conductor services. (list value)"},{"line_number":64,"context_line":"#enabled_storage_interfaces \u003d no-storage"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Default storage interface to be used for nodes that do not"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"7a77a97e_c476f105","line":63,"range":{"start_line":62,"start_character":14,"end_line":63,"end_character":20},"in_reply_to":"7a77a97e_bf02fb07","updated":"2016-11-21 17:04:22.000000000","message":"This is because any conductor can be be responsible for the management of a node, as the failover model is presently designed as such.  Until we have any az/region or geographic understanding built into ironic, this will be the case.","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"039490fc1d65d42d87170e01b9a30d1bacc84b92","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# operator deployment specific capability. A complete list of"},{"line_number":60,"context_line":"# storage interfaces present on the conductor can be found by"},{"line_number":61,"context_line":"# enumerating the \"ironic.hardware.interfaces.storage\""},{"line_number":62,"context_line":"# entrypoint. This value must be the same on all ironic-"},{"line_number":63,"context_line":"# conductor services. (list value)"},{"line_number":64,"context_line":"#enabled_storage_interfaces \u003d no-storage"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Default storage interface to be used for nodes that do not"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"7a77a97e_0077ee02","line":63,"range":{"start_line":62,"start_character":14,"end_line":63,"end_character":20},"in_reply_to":"7a77a97e_c476f105","updated":"2016-11-21 19:40:13.000000000","message":"Thanks Julia -sorry, I didn\u0027t make myself clear in my question.  What would actually happen if this was not followed? What would the consequences be for a node that is rebalanced between conductors if the storage interfaces weren\u0027t the same?","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# entrypoint. (string value)"},{"line_number":52,"context_line":"#default_network_interface \u003d \u003cNone\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Specify the list of storage interfaces to load during"},{"line_number":55,"context_line":"# service initialization. Missing storage interfaces, or"},{"line_number":56,"context_line":"# storage interfaces that fail to initialize, will prevent the"},{"line_number":57,"context_line":"# conductor service from starting. The default configuration"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"3a71b18c_69542dca","line":54,"updated":"2016-12-07 14:18:54.000000000","message":"Probably one of the patches should be rebased on the other.. or we should just wait for one to merge :)","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ed1ce4ac3048939a7a778105964d6ccdadd21da7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# entrypoint. (string value)"},{"line_number":52,"context_line":"#default_network_interface \u003d \u003cNone\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Specify the list of storage interfaces to load during"},{"line_number":55,"context_line":"# service initialization. Missing storage interfaces, or"},{"line_number":56,"context_line":"# storage interfaces that fail to initialize, will prevent the"},{"line_number":57,"context_line":"# conductor service from starting. The default configuration"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"3a71b18c_6ad0c6c9","line":54,"updated":"2016-12-06 19:19:11.000000000","message":"Will it matter if this merges before https://review.openstack.org/#/c/336626/ ?","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# entrypoint. (string value)"},{"line_number":52,"context_line":"#default_network_interface \u003d \u003cNone\u003e"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Specify the list of storage interfaces to load during"},{"line_number":55,"context_line":"# service initialization. Missing storage interfaces, or"},{"line_number":56,"context_line":"# storage interfaces that fail to initialize, will prevent the"},{"line_number":57,"context_line":"# conductor service from starting. The default configuration"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"1a6eadb0_0e049113","line":54,"in_reply_to":"3a71b18c_69542dca","updated":"2016-12-12 22:22:07.000000000","message":"It is a race to merge! ;)","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ed1ce4ac3048939a7a778105964d6ccdadd21da7","unresolved":false,"context_lines":[{"line_number":374,"context_line":"# False means to keep queue and messages even if server is"},{"line_number":375,"context_line":"# disconnected, when the server appears we send all"},{"line_number":376,"context_line":"# accumulated messages to it. (boolean value)"},{"line_number":377,"context_line":"#zmq_immediate \u003d true"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"# Enable/disable TCP keepalive (KA) mechanism. The default"},{"line_number":380,"context_line":"# value of -1 (or any other negative value) means to skip any"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"3a71b18c_8a5c427e","line":377,"updated":"2016-12-06 19:19:11.000000000","message":"A lot of these changes seem unrelated. Is this just the result of regenerating the config against latest master?","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":374,"context_line":"# False means to keep queue and messages even if server is"},{"line_number":375,"context_line":"# disconnected, when the server appears we send all"},{"line_number":376,"context_line":"# accumulated messages to it. (boolean value)"},{"line_number":377,"context_line":"#zmq_immediate \u003d true"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"# Enable/disable TCP keepalive (KA) mechanism. The default"},{"line_number":380,"context_line":"# value of -1 (or any other negative value) means to skip any"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"1a6eadb0_ab062f1e","line":377,"in_reply_to":"3a71b18c_8a5c427e","updated":"2016-12-12 22:22:07.000000000","message":"Fairly recent, interesting.  I\u0027ll regenerate it again and see what happens since I\u0027m presently rebasing off master again.","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"}],"ironic/common/driver_factory.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        storage_driver \u003d storage_factory.get_driver(storage_interface)"},{"line_number":78,"context_line":"    except KeyError:"},{"line_number":79,"context_line":"        raise exception.DriverNotFoundInEntrypoint("},{"line_number":80,"context_line":"            driver_name\u003dstorage_interface,"},{"line_number":81,"context_line":"            entrypoint\u003dstorage_factory._entrypoint_name)"},{"line_number":82,"context_line":"    driver.storage \u003d storage_driver"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_294a3528","line":79,"updated":"2016-12-07 14:18:54.000000000","message":"s/Driver/Interface/","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    try:"},{"line_number":77,"context_line":"        storage_driver \u003d storage_factory.get_driver(storage_interface)"},{"line_number":78,"context_line":"    except KeyError:"},{"line_number":79,"context_line":"        raise exception.DriverNotFoundInEntrypoint("},{"line_number":80,"context_line":"            driver_name\u003dstorage_interface,"},{"line_number":81,"context_line":"            entrypoint\u003dstorage_factory._entrypoint_name)"},{"line_number":82,"context_line":"    driver.storage \u003d storage_driver"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_cb4b6baf","line":79,"in_reply_to":"3a71b18c_294a3528","updated":"2016-12-12 22:22:07.000000000","message":"Done","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                entrypoint\u003dStorageInterfaceFactory._entrypoint_name,"},{"line_number":115,"context_line":"                valid\u003dStorageInterfaceFactory().names)"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        node.storage_interface \u003d (CONF.default_storage_interface or \u0027noop\u0027)"},{"line_number":118,"context_line":"        change_applied \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return change_applied"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_4947711d","line":117,"updated":"2016-12-07 14:18:54.000000000","message":"here you call it \"noop\", previous patch used \"no-storage\".. I think this variant is correct actually.","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                entrypoint\u003dStorageInterfaceFactory._entrypoint_name,"},{"line_number":115,"context_line":"                valid\u003dStorageInterfaceFactory().names)"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        node.storage_interface \u003d (CONF.default_storage_interface or \u0027noop\u0027)"},{"line_number":118,"context_line":"        change_applied \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return change_applied"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_8b233305","line":117,"in_reply_to":"3a71b18c_4947711d","updated":"2016-12-12 22:22:07.000000000","message":"Yeah, should be noop.  I somehow didn\u0027t end up updating the other revision when I thought I had. :(","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"83a43e8fe18d02a1e3984a30bb85bd09352f5757","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                entrypoint\u003dStorageInterfaceFactory._entrypoint_name,"},{"line_number":115,"context_line":"                valid\u003dStorageInterfaceFactory().names)"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        node.storage_interface \u003d (CONF.default_storage_interface or \u0027noop\u0027)"},{"line_number":118,"context_line":"        change_applied \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return change_applied"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6eadb0_4a13a30d","line":117,"updated":"2016-12-13 19:05:08.000000000","message":"I\u0027m actually fixing this in the driver composition patch, but this code may end up with \u0027noop\u0027 assigned even if it\u0027s not enabled.. it\u0027s the same for networks, so I guess it\u0027s fine for now.","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"08c9bea2ce5ff7b306385170dda094c3738801a6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                entrypoint\u003dStorageInterfaceFactory._entrypoint_name,"},{"line_number":115,"context_line":"                valid\u003dStorageInterfaceFactory().names)"},{"line_number":116,"context_line":"    else:"},{"line_number":117,"context_line":"        node.storage_interface \u003d (CONF.default_storage_interface or \u0027noop\u0027)"},{"line_number":118,"context_line":"        change_applied \u003d True"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    return change_applied"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6eadb0_440d578f","line":117,"in_reply_to":"1a6eadb0_4a13a30d","updated":"2016-12-13 20:31:10.000000000","message":"I think the default ending up as noop is perfectly fine in the grand scheme of things, considering they are in a sense, optional to the core functions of ironic. :)","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\"Attach interface implementations to a bare driver object."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    For classic drivers, copies implementations from the singleton driver"},{"line_number":70,"context_line":"    object, then attaches the dynamic interfaces (network_interface for classic"},{"line_number":71,"context_line":"    drivers, all interfaces for dynamic drivers made of hardware types)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    For hardware types, load all interface implementations dynamically."}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_5a989e1b","line":70,"updated":"2016-12-21 02:03:46.000000000","message":"network \u0026 storage?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # NOTE(dtantsur): only network interface is dynamic for classic"},{"line_number":92,"context_line":"        # drivers, thus it requires separate treatment."},{"line_number":93,"context_line":"        # NOTE(TheJulia): The sotrage interface is added to classic"},{"line_number":94,"context_line":"        # drivers to support storage operations."},{"line_number":95,"context_line":"        dynamic_interfaces \u003d [\u0027network\u0027, \u0027storage\u0027]"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_3a604235","line":93,"updated":"2016-12-21 02:03:46.000000000","message":"nit: s/sotrage/storage/\n\nBoth NOTEs could be combined. storage interface is also dynamic for classic drivers too, right?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # NOTE(dtantsur): only network interface is dynamic for classic"},{"line_number":92,"context_line":"        # drivers, thus it requires separate treatment."},{"line_number":93,"context_line":"        # NOTE(TheJulia): The sotrage interface is added to classic"},{"line_number":94,"context_line":"        # drivers to support storage operations."},{"line_number":95,"context_line":"        dynamic_interfaces \u003d [\u0027network\u0027, \u0027storage\u0027]"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_a7d33637","line":93,"in_reply_to":"1a6eadb0_3a604235","updated":"2016-12-21 16:49:45.000000000","message":"Done","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # drivers, thus it requires separate treatment."},{"line_number":93,"context_line":"        # NOTE(TheJulia): The sotrage interface is added to classic"},{"line_number":94,"context_line":"        # drivers to support storage operations."},{"line_number":95,"context_line":"        dynamic_interfaces \u003d [\u0027network\u0027, \u0027storage\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    for iface in dynamic_interfaces:"},{"line_number":98,"context_line":"        impl_name \u003d getattr(node, \u0027%s_interface\u0027 % iface)"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_fa4ecabf","line":95,"updated":"2016-12-21 02:03:46.000000000","message":"Do we need to do this, or can we make storage interface only available with hardware types? (What do we do with future interfaces? Do they have to be avail with classic and hardware types?)","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8cceb4c971e331ba40bb6e8bd25821cb6dcfbea5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # drivers, thus it requires separate treatment."},{"line_number":93,"context_line":"        # NOTE(TheJulia): The sotrage interface is added to classic"},{"line_number":94,"context_line":"        # drivers to support storage operations."},{"line_number":95,"context_line":"        dynamic_interfaces \u003d [\u0027network\u0027, \u0027storage\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    for iface in dynamic_interfaces:"},{"line_number":98,"context_line":"        impl_name \u003d getattr(node, \u0027%s_interface\u0027 % iface)"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_920bdbd5","line":95,"in_reply_to":"1a6eadb0_7e9c4ec0","updated":"2016-12-21 15:05:33.000000000","message":"Ok, I\u0027m fine with storage being avail with classic drivers. Jim R. agrees. We\u0027re both not quite sure about future interfaces though; we\u0027ll have that discussion later :)","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # drivers, thus it requires separate treatment."},{"line_number":93,"context_line":"        # NOTE(TheJulia): The sotrage interface is added to classic"},{"line_number":94,"context_line":"        # drivers to support storage operations."},{"line_number":95,"context_line":"        dynamic_interfaces \u003d [\u0027network\u0027, \u0027storage\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    for iface in dynamic_interfaces:"},{"line_number":98,"context_line":"        impl_name \u003d getattr(node, \u0027%s_interface\u0027 % iface)"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_47e50207","line":95,"in_reply_to":"1a6eadb0_920bdbd5","updated":"2016-12-21 16:49:45.000000000","message":"Thank you!","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # drivers, thus it requires separate treatment."},{"line_number":93,"context_line":"        # NOTE(TheJulia): The sotrage interface is added to classic"},{"line_number":94,"context_line":"        # drivers to support storage operations."},{"line_number":95,"context_line":"        dynamic_interfaces \u003d [\u0027network\u0027, \u0027storage\u0027]"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    for iface in dynamic_interfaces:"},{"line_number":98,"context_line":"        impl_name \u003d getattr(node, \u0027%s_interface\u0027 % iface)"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_7e9c4ec0","line":95,"in_reply_to":"1a6eadb0_fa4ecabf","updated":"2016-12-21 13:45:13.000000000","message":"The spec was written as an integration into existing drivers using the same approach for driver composition compatibility, expecting it to potentially land.\n\nI think future interfaces would depend on how they are written and what their purpose is.  I\u0027m not sure restricting new dynamic interfaces to only being supported on hardware types would be logical since the same underlying code must be modified, and we would be artificially blocking adoption since not every operator will want to immediately switch to a massively different way of conceiving how to configure a node when they just want it to work with a new feature.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    is_hardware_type \u003d isinstance(driver_or_hw_type,"},{"line_number":193,"context_line":"                                  hardware_type.AbstractHardwareType)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    # Legacy network interface defaults"},{"line_number":196,"context_line":"    additional_defaults \u003d {"},{"line_number":197,"context_line":"        \u0027network\u0027: \u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027 else \u0027noop\u0027,"},{"line_number":198,"context_line":"        \u0027storage\u0027: \u0027noop\u0027"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_ba02923c","line":195,"updated":"2016-12-21 02:03:46.000000000","message":"this needs to be updated...","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    if is_hardware_type:"},{"line_number":202,"context_line":"        factories \u003d _INTERFACE_LOADERS"},{"line_number":203,"context_line":"    else:"},{"line_number":204,"context_line":"        # Only network interface is dynamic for classic drivers"},{"line_number":205,"context_line":"        factories \u003d {\u0027network\u0027: _INTERFACE_LOADERS[\u0027network\u0027],"},{"line_number":206,"context_line":"                     \u0027storage\u0027: _INTERFACE_LOADERS[\u0027storage\u0027]}"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_1af8e648","line":204,"updated":"2016-12-21 02:03:46.000000000","message":"ditto","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0085f521353e2a7cada90bb282a85bdd078b647c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"\"\"Attach interface implementations to a bare driver object."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    For classic drivers, copies implementations from the singleton driver"},{"line_number":70,"context_line":"    object, then attaches the dynamic interfaces (network_interface for classic"},{"line_number":71,"context_line":"    drivers, all interfaces for dynamic drivers made of hardware types)."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    For hardware types, load all interface implementations dynamically."}],"source_content_type":"text/x-python","patch_set":34,"id":"da4df55a_f7457817","line":70,"updated":"2016-12-21 20:19:17.000000000","message":"s/network_interface/network \u0026 storage interfaces/","commit_id":"1c8ad50cfc2ddb2f42b734f92c10858ad030fac2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0085f521353e2a7cada90bb282a85bdd078b647c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    is_hardware_type \u003d isinstance(driver_or_hw_type,"},{"line_number":191,"context_line":"                                  hardware_type.AbstractHardwareType)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # Legacy network interface defaults"},{"line_number":194,"context_line":"    additional_defaults \u003d {"},{"line_number":195,"context_line":"        \u0027network\u0027: \u0027flat\u0027 if CONF.dhcp.dhcp_provider \u003d\u003d \u0027neutron\u0027 else \u0027noop\u0027,"},{"line_number":196,"context_line":"        \u0027storage\u0027: \u0027noop\u0027"}],"source_content_type":"text/x-python","patch_set":34,"id":"da4df55a_d7c954ae","line":193,"updated":"2016-12-21 20:19:17.000000000","message":"this is incorrect now","commit_id":"1c8ad50cfc2ddb2f42b734f92c10858ad030fac2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0085f521353e2a7cada90bb282a85bdd078b647c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if is_hardware_type:"},{"line_number":200,"context_line":"        factories \u003d _INTERFACE_LOADERS"},{"line_number":201,"context_line":"    else:"},{"line_number":202,"context_line":"        # Only network interface is dynamic for classic drivers"},{"line_number":203,"context_line":"        factories \u003d {\u0027network\u0027: _INTERFACE_LOADERS[\u0027network\u0027],"},{"line_number":204,"context_line":"                     \u0027storage\u0027: _INTERFACE_LOADERS[\u0027storage\u0027]}"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"da4df55a_17c4bc90","line":202,"updated":"2016-12-21 20:19:17.000000000","message":"ditto","commit_id":"1c8ad50cfc2ddb2f42b734f92c10858ad030fac2"}],"ironic/conductor/base_manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Consistent hash ring which maps drivers to conductors.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE(deva): these calls may raise DriverLoadError or DriverNotFound"},{"line_number":83,"context_line":"        # NOTE(vdrok): instantiate network interface factory on startup so that"},{"line_number":84,"context_line":"        # all the network interfaces are loaded at the very beginning, and"},{"line_number":85,"context_line":"        # failures prevent the conductor from starting."},{"line_number":86,"context_line":"        drivers \u003d driver_factory.drivers()"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_7ab63a8b","line":83,"updated":"2016-12-21 02:03:46.000000000","message":"do we need to update this to include storage too?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8cceb4c971e331ba40bb6e8bd25821cb6dcfbea5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Consistent hash ring which maps drivers to conductors.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE(deva): these calls may raise DriverLoadError or DriverNotFound"},{"line_number":83,"context_line":"        # NOTE(vdrok): instantiate network interface factory on startup so that"},{"line_number":84,"context_line":"        # all the network interfaces are loaded at the very beginning, and"},{"line_number":85,"context_line":"        # failures prevent the conductor from starting."},{"line_number":86,"context_line":"        drivers \u003d driver_factory.drivers()"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_f2032f40","line":83,"in_reply_to":"1a6eadb0_5eb95214","updated":"2016-12-21 15:05:33.000000000","message":"Well, it only mentions network, but storage is also being done. so either the comment is incorrect/incomplete, or the code is.\n\nAre we going to have factories for all the interfaces?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Consistent hash ring which maps drivers to conductors.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE(deva): these calls may raise DriverLoadError or DriverNotFound"},{"line_number":83,"context_line":"        # NOTE(vdrok): instantiate network interface factory on startup so that"},{"line_number":84,"context_line":"        # all the network interfaces are loaded at the very beginning, and"},{"line_number":85,"context_line":"        # failures prevent the conductor from starting."},{"line_number":86,"context_line":"        drivers \u003d driver_factory.drivers()"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_5eb95214","line":83,"in_reply_to":"1a6eadb0_7ab63a8b","updated":"2016-12-21 13:45:13.000000000","message":"I didn\u0027t really see a point since in adding a note, but I can do so.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        \"\"\"Consistent hash ring which maps drivers to conductors.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # NOTE(deva): these calls may raise DriverLoadError or DriverNotFound"},{"line_number":83,"context_line":"        # NOTE(vdrok): instantiate network interface factory on startup so that"},{"line_number":84,"context_line":"        # all the network interfaces are loaded at the very beginning, and"},{"line_number":85,"context_line":"        # failures prevent the conductor from starting."},{"line_number":86,"context_line":"        drivers \u003d driver_factory.drivers()"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_0325bf07","line":83,"in_reply_to":"1a6eadb0_f2032f40","updated":"2016-12-21 16:49:45.000000000","message":"I\u0027m not entirely sure, I think this is largely a result of dynamic interface on top of an existing driver. Regardless, updating the note.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"ironic/db/sqlalchemy/alembic/versions/1d6951876d68_add_storage_interface_db_field_and_.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"5a617c43fc91d22b5c074cbde9269be5dad90c80","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":44,"context_line":"    # option is available, we should update the upgrade"},{"line_number":45,"context_line":"    # to allow an operator to choose ta system wide default."},{"line_number":46,"context_line":"    storage_iface \u003d (CONF.default_storage_interface or \u0027no-storage\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    op.execute("}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_7f194379","line":45,"range":{"start_line":45,"start_character":37,"end_line":45,"end_character":39},"updated":"2016-11-21 07:59:05.000000000","message":"Nit: Is this a typo?","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c54ff1be063a503d2b2b1ce3f58458a23f47368e","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # TODO(TheJulia): Once the default_storage_interface"},{"line_number":44,"context_line":"    # option is available, we should update the upgrade"},{"line_number":45,"context_line":"    # to allow an operator to choose ta system wide default."},{"line_number":46,"context_line":"    storage_iface \u003d (CONF.default_storage_interface or \u0027no-storage\u0027)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    op.execute("}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_c4e431ae","line":45,"range":{"start_line":45,"start_character":37,"end_line":45,"end_character":39},"in_reply_to":"7a77a97e_7f194379","updated":"2016-11-21 17:04:22.000000000","message":"Fixed in prior rev.","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027storage_interface\u0027,"},{"line_number":35,"context_line":"                                     sa.String(255),"},{"line_number":36,"context_line":"                                     default\u003d\u0027noop\u0027,"},{"line_number":37,"context_line":"                                     nullable\u003dTrue))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    node \u003d table(\u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_e93f5d85","line":36,"updated":"2016-12-07 14:18:54.000000000","message":"this should go to the previous patch, otherwise there may be nodes with incorrect \"no-storage\" value","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027nodes\u0027, sa.Column(\u0027storage_interface\u0027,"},{"line_number":35,"context_line":"                                     sa.String(255),"},{"line_number":36,"context_line":"                                     default\u003d\u0027noop\u0027,"},{"line_number":37,"context_line":"                                     nullable\u003dTrue))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    node \u003d table(\u0027nodes\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_eb2ae7e6","line":36,"in_reply_to":"3a71b18c_e93f5d85","updated":"2016-12-12 22:22:07.000000000","message":"Removed.","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                 column(\u0027uuid\u0027, String(36)),"},{"line_number":41,"context_line":"                 column(\u0027storage_interface\u0027, String(255)))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    storage_iface \u003d (CONF.default_storage_interface or \u0027noop\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    op.execute("},{"line_number":46,"context_line":"        node.update().where("}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_09457916","line":43,"updated":"2016-12-07 14:18:54.000000000","message":"let\u0027s not duplicate the logic in driver_factory - see my comments on the previous patch","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                 column(\u0027uuid\u0027, String(36)),"},{"line_number":41,"context_line":"                 column(\u0027storage_interface\u0027, String(255)))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    storage_iface \u003d (CONF.default_storage_interface or \u0027noop\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    op.execute("},{"line_number":46,"context_line":"        node.update().where("}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_0b300356","line":43,"in_reply_to":"3a71b18c_09457916","updated":"2016-12-12 22:22:07.000000000","message":"Removed.","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"}],"ironic/drivers/base.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"25e3a7ea5e5920a821e026de0ca324576bb4a72b","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        \"\"\""},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    @abc.abstractmethod"},{"line_number":1117,"context_line":"    def sync_config(self, task):"},{"line_number":1118,"context_line":"        \"\"\"Synchronize volume configuration from the storage system."},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        This method provides an interface to request the storage driver to"},{"line_number":1121,"context_line":"        synchronze the node connector and target information with the storage"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_ba37b94b","line":1118,"range":{"start_line":1117,"start_character":7,"end_line":1118,"end_character":29},"updated":"2016-08-01 13:00:45.000000000","message":"Removed from specification as the information visibility simply does not exist in cinder.","commit_id":"4157f9c69a6abf8710d963b7b6013e3c373da293"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"064a452df2d73cde624587babb1285f875f0de3a","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"        :raises: InvalidParameterValue, if the storage interface configuration"},{"line_number":1015,"context_line":"                 is invalid."},{"line_number":1016,"context_line":"        :raises: MissingParameterValue, if some parameters are missing."},{"line_number":1017,"context_line":"        \"\"\""},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"    def get_properties(self):"},{"line_number":1020,"context_line":"        \"\"\"Returns the properties of the interface."}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_b197198f","line":1017,"updated":"2016-11-25 11:59:38.000000000","message":"validate is defined in BaseInterface, do you really want to override it with noop implementation here?","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"064a452df2d73cde624587babb1285f875f0de3a","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"        \"\"\"Returns the properties of the interface."},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        :returns: dictionary of \u003cproperty name\u003e:\u003cproperty description\u003e entries."},{"line_number":1023,"context_line":"        \"\"\""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    @abc.abstractmethod"},{"line_number":1026,"context_line":"    def attach_volumes(self, task):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_d192d59e","line":1023,"updated":"2016-11-25 11:59:38.000000000","message":"returning None here is incorrect. please either drop this to use the base implementation or return {} to override the base implementation","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"83a43e8fe18d02a1e3984a30bb85bd09352f5757","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        self.core_interfaces.append(\u0027storage\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.storage \u003d None"},{"line_number":180,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6eadb0_6afa1fbf","line":177,"updated":"2016-12-13 19:05:08.000000000","message":"duplicated definition","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"20c07b21af65da5d2e816e66f8cad3a93fe419ee","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        self.core_interfaces.append(\u0027storage\u0027)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        self.storage \u003d None"},{"line_number":180,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6eadb0_64b893e6","line":177,"in_reply_to":"1a6eadb0_6afa1fbf","updated":"2016-12-13 20:27:16.000000000","message":"DOH!","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.core_interfaces.append(\u0027network\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.storage \u003d None"},{"line_number":174,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_3a31220c","line":174,"updated":"2016-12-21 02:03:46.000000000","message":"why is this a core interface, not a standard interface?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.core_interfaces.append(\u0027network\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.storage \u003d None"},{"line_number":174,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_e7a7eeb9","line":174,"in_reply_to":"1a6eadb0_0daecee5","updated":"2016-12-21 16:49:45.000000000","message":"Agreed, changing.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.core_interfaces.append(\u0027network\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.storage \u003d None"},{"line_number":174,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_9ec04a52","line":174,"in_reply_to":"1a6eadb0_3a31220c","updated":"2016-12-21 13:45:13.000000000","message":"I guess it could be a standard interface.  Largely it was intended, as described by the spec to mirror the network interface in terms of interface implementation.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8cceb4c971e331ba40bb6e8bd25821cb6dcfbea5","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.core_interfaces.append(\u0027network\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.storage \u003d None"},{"line_number":174,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_0daecee5","line":174,"in_reply_to":"1a6eadb0_9ec04a52","updated":"2016-12-21 15:05:33.000000000","message":"Discussed with jroll in irc[1] and we both feel like storage is a standard interface because it isn\u0027t essential/needed, whereas network is.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2016-12-21.log.html#t2016-12-21T14:26:42","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    @abc.abstractmethod"},{"line_number":1005,"context_line":"    def attach_volumes(self, task):"},{"line_number":1006,"context_line":"        \"\"\"Informs the storage subsystem to detach all volumes for the node."},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        :param task: a TaskManager instance."},{"line_number":1009,"context_line":"        :raises: UnsupportedDriverExtension"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_fd3404df","line":1006,"updated":"2016-12-21 02:03:46.000000000","message":"wouldn\u0027t it want to attach, not detach?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    @abc.abstractmethod"},{"line_number":1005,"context_line":"    def attach_volumes(self, task):"},{"line_number":1006,"context_line":"        \"\"\"Informs the storage subsystem to detach all volumes for the node."},{"line_number":1007,"context_line":""},{"line_number":1008,"context_line":"        :param task: a TaskManager instance."},{"line_number":1009,"context_line":"        :raises: UnsupportedDriverExtension"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_7e060ecf","line":1006,"in_reply_to":"1a6eadb0_fd3404df","updated":"2016-12-21 13:45:13.000000000","message":"*blinks* Okay, yeah, it should be attach.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        \"\"\"Determines if deploy should perform the image write-out."},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        :param task: a TaskManager instance."},{"line_number":1025,"context_line":"        :returns: Boolean value to indicate if the driver expects"},{"line_number":1026,"context_line":"                  the image to be written by Ironic."},{"line_number":1027,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":1028,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_dd3ca8c1","line":1025,"updated":"2016-12-21 02:03:46.000000000","message":"s/driver/interface/ or \u0027interface implementation\u0027?\n\nSo True if the image should be written by ironic, false otherwise. Maybe \u0027check_write_image\u0027 isn\u0027t the best name.  If I recall, most of our check_* functions don\u0027t return any value, they just \u0027check\u0027.\n\nThe spec shows \u0027should_write_image()\u0027 -- did someone suggest changing it?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        \"\"\"Determines if deploy should perform the image write-out."},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        :param task: a TaskManager instance."},{"line_number":1025,"context_line":"        :returns: Boolean value to indicate if the driver expects"},{"line_number":1026,"context_line":"                  the image to be written by Ironic."},{"line_number":1027,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":1028,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_de84820c","line":1025,"in_reply_to":"1a6eadb0_dd3ca8c1","updated":"2016-12-21 13:45:13.000000000","message":"Good catch, I guess it should be should_write_image.  This was one of those things where there where the suggestion kept shifting.  I\u0027ll fix in the next update.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0085f521353e2a7cada90bb282a85bdd078b647c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.core_interfaces.append(\u0027network\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.storage \u003d None"},{"line_number":174,"context_line":"        \"\"\"`Core` attribute for (remote) storage interface."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        A reference to an instance of :class:StorageInterface."},{"line_number":177,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":34,"id":"da4df55a_7717c8ed","line":174,"updated":"2016-12-21 20:19:17.000000000","message":"s/Core/Standard/","commit_id":"1c8ad50cfc2ddb2f42b734f92c10858ad030fac2"}],"ironic/drivers/fake_hardware.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def supported_storage_interfaces(self):"},{"line_number":71,"context_line":"        \"\"\"List of classes of supported storage interfaces.\"\"\""},{"line_number":72,"context_line":"        return [fake.FakeStorage]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def supported_vendor_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_bdf9acca","line":72,"updated":"2016-12-21 02:03:46.000000000","message":"Should this be here? there is no supported_network_interfaces() here and I can\u0027t recall why, but am wondering if storage has to be treated in a similar fashion to network.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def supported_storage_interfaces(self):"},{"line_number":71,"context_line":"        \"\"\"List of classes of supported storage interfaces.\"\"\""},{"line_number":72,"context_line":"        return [fake.FakeStorage]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def supported_vendor_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_fef93e81","line":72,"in_reply_to":"1a6eadb0_bdf9acca","updated":"2016-12-21 13:45:13.000000000","message":"Driver factory testing for driver composition fails without it. In the grand scheme of the universe, it does not hurt to have it in my opinion.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8cceb4c971e331ba40bb6e8bd25821cb6dcfbea5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def supported_storage_interfaces(self):"},{"line_number":71,"context_line":"        \"\"\"List of classes of supported storage interfaces.\"\"\""},{"line_number":72,"context_line":"        return [fake.FakeStorage]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def supported_vendor_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_6d890226","line":72,"in_reply_to":"1a6eadb0_fef93e81","updated":"2016-12-21 15:05:33.000000000","message":"Those are good reasons to have it :)","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"ironic/drivers/modules/fake.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    \"\"\"Example implementation of simple storage Interface.\"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def validate(self, task):"},{"line_number":234,"context_line":"        return True"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get_properties(self):"},{"line_number":237,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_9d85d008","line":234,"updated":"2016-12-21 02:03:46.000000000","message":"this can be pass, doesn\u0027t look like validate() returns a Boolean.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    \"\"\"Example implementation of simple storage Interface.\"\"\""},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def validate(self, task):"},{"line_number":234,"context_line":"        return True"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get_properties(self):"},{"line_number":237,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_be80a6c0","line":234,"in_reply_to":"1a6eadb0_9d85d008","updated":"2016-12-21 13:45:13.000000000","message":"Will fix, thanks.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        pass"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def check_write_image(self, task):"},{"line_number":246,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_fdc88476","line":246,"updated":"2016-12-21 02:03:46.000000000","message":"shouldn\u0027t this return True (or False)?","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        pass"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def check_write_image(self, task):"},{"line_number":246,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_0ab6aff8","line":246,"in_reply_to":"1a6eadb0_deeac273","updated":"2016-12-21 16:49:45.000000000","message":"True, because when the logic is implemented, we won\u0027t want to break the existing process.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        pass"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def check_write_image(self, task):"},{"line_number":246,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_deeac273","line":246,"in_reply_to":"1a6eadb0_fdc88476","updated":"2016-12-21 13:45:13.000000000","message":"I guess it should be False, will fix in next update.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"ironic/drivers/modules/noop.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ed1ce4ac3048939a7a778105964d6ccdadd21da7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    create_configuration \u003d delete_configuration \u003d _fail"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class NoopStorage(base.StorageInterface):"},{"line_number":71,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def validate(self, task):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_4a1eaa70","line":70,"updated":"2016-12-06 19:19:11.000000000","message":"I wonder if this should be in the storage directory, similarly to how the network noop interface is in the drivers/modules/network directory.","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    create_configuration \u003d delete_configuration \u003d _fail"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class NoopStorage(base.StorageInterface):"},{"line_number":71,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def validate(self, task):"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_6bf8977d","line":70,"in_reply_to":"3a71b18c_4a1eaa70","updated":"2016-12-12 22:22:07.000000000","message":"That is how I was thinking and how it was originally.  Dmitry requested it to be in a single noop file.  Granted NoopStorage is a little different than a NoStorage interface... *shrug*","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def validate(self, task):"},{"line_number":74,"context_line":"        return True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_properties(self):"},{"line_number":77,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_c93aa198","line":74,"updated":"2016-12-07 14:18:54.000000000","message":"validate() does not return anything.. I wonder if we should raise actually (maybe not)","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def validate(self, task):"},{"line_number":74,"context_line":"        return True"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_properties(self):"},{"line_number":77,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_6bd177fb","line":74,"in_reply_to":"3a71b18c_c93aa198","updated":"2016-12-12 22:22:07.000000000","message":"I think we should be returning true so node.validate succeed.","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"83a43e8fe18d02a1e3984a30bb85bd09352f5757","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class NoopStorage(base.StorageInterface):"},{"line_number":71,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def validate(self, task):"},{"line_number":74,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6eadb0_8af5bbcc","line":71,"updated":"2016-12-13 19:05:08.000000000","message":"btw, after our discussion on one of previous patchset, I no longer insist this class to be in this file, drivers.modules.storage.noop is just as fine. I used to assume that it will behave more closely to No* interfaces (i.e. raise exceptions).","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"20c07b21af65da5d2e816e66f8cad3a93fe419ee","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class NoopStorage(base.StorageInterface):"},{"line_number":71,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def validate(self, task):"},{"line_number":74,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a6eadb0_44ac77a0","line":71,"in_reply_to":"1a6eadb0_8af5bbcc","updated":"2016-12-13 20:27:16.000000000","message":"Oh, okay!  I\u0027ll change it back to the separate file so we don\u0027t drive anyone crazy down the road. :)","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"}],"ironic/drivers/modules/storage/noop.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"064a452df2d73cde624587babb1285f875f0de3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a74a57a_f191919a","updated":"2016-11-25 11:59:38.000000000","message":"please move this to ironic.drivers.modules.noop and make all user-visible methods throw exception (see other implementation there)","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f832c9bc6820ffd2e397165a4df50c49331740b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a74a57a_26f44059","in_reply_to":"5a74a57a_0effbaaa","updated":"2016-11-29 08:43:34.000000000","message":"I think attach_volumes and detach_volumes should raise in this case, but I\u0027m not entirely sure now. Are they called by API users directly or are they called from e.g. deploy interface?","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8b6111581388f48edc932721360ce459b15c15e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a74a57a_2da958e0","in_reply_to":"5a74a57a_26f44059","updated":"2016-11-29 20:16:31.000000000","message":"It would be called from other interfaces at this time.  Later on, we can wire in the capability for triggering it directly via an api interaction, but one step at a time.","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0cbcd9a7ae9f39d5ee9888ea40ea5fc7121b3dc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a74a57a_e89e6eb7","in_reply_to":"5a74a57a_f191919a","updated":"2016-11-29 20:49:05.000000000","message":"Additionally, noop in this case shouldn\u0027t raise exceptions since the specification explicitly calls for it to be opt-in, which means validate should still pass in noop/no-storage.","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"28d8c829e2d0bbaabbc678252b914179f5c7d1a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5a74a57a_0effbaaa","in_reply_to":"5a74a57a_f191919a","updated":"2016-11-25 16:17:32.000000000","message":"What exactly do you mean by \"user\" in this context?","commit_id":"98a5f504e0f5e294ca81958135c84b61c11d2e23"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \"\"\"No-op Storage Interface.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def validate(self, task):"},{"line_number":20,"context_line":"        return True"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def get_properties(self):"},{"line_number":23,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_eaa7b3b9","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":14},"updated":"2016-12-21 16:49:45.000000000","message":"Changed to pass","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def detach_volumes(self, task):"},{"line_number":29,"context_line":"        pass"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def check_write_image(self, task):"},{"line_number":32,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_aa885b23","line":32,"range":{"start_line":31,"start_character":9,"end_line":32,"end_character":12},"updated":"2016-12-21 16:49:45.000000000","message":"Changed to should_write_image and default return of True.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"ironic/objects/node.py":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"5a617c43fc91d22b5c074cbde9269be5dad90c80","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # TODO(Presently the only available option is \u0027no-storage\u0027, however"},{"line_number":40,"context_line":"    # once default_storage_interfaces is introduced in configuration,"},{"line_number":41,"context_line":"    # this will need to be updated. I.e. in the next patch."},{"line_number":42,"context_line":"    storage_interface \u003d (CONF.default_storage_interface or \u0027no-storage\u0027)"},{"line_number":43,"context_line":"    return storage_interface"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_aa2477b2","line":42,"range":{"start_line":42,"start_character":60,"end_line":42,"end_character":70},"updated":"2016-11-21 07:59:05.000000000","message":"This string \u0027no-storage\u0027 is used in 4 places in this patch (ironic/conf/default.py, ironic/db/sqlalchemy/alembic/versions/1d6951876d68_add_storage_interface_db_field_and_.py, ironic/objects/node.py, and ironic/tests/unit/common/test_driver_factory.py) - is there any possibility for it to be defined once and referenced?","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c54ff1be063a503d2b2b1ce3f58458a23f47368e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # TODO(Presently the only available option is \u0027no-storage\u0027, however"},{"line_number":40,"context_line":"    # once default_storage_interfaces is introduced in configuration,"},{"line_number":41,"context_line":"    # this will need to be updated. I.e. in the next patch."},{"line_number":42,"context_line":"    storage_interface \u003d (CONF.default_storage_interface or \u0027no-storage\u0027)"},{"line_number":43,"context_line":"    return storage_interface"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_e42bed92","line":42,"range":{"start_line":42,"start_character":60,"end_line":42,"end_character":70},"in_reply_to":"7a77a97e_aa2477b2","updated":"2016-11-21 17:04:22.000000000","message":"I don\u0027t think so :\\  And even then, I think that would make it more complex, and wouldn\u0027t really jive with network interface work, nor potentially driver composition.","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        \u0027target_power_state\u0027: (\u0027node\u0027, \u0027target_power_state\u0027),"},{"line_number":437,"context_line":"        \u0027target_provision_state\u0027: (\u0027node\u0027, \u0027target_provision_state\u0027),"},{"line_number":438,"context_line":"        \u0027updated_at\u0027: (\u0027node\u0027, \u0027updated_at\u0027),"},{"line_number":439,"context_line":"        \u0027uuid\u0027: (\u0027node\u0027, \u0027uuid\u0027)"},{"line_number":440,"context_line":"    }"},{"line_number":441,"context_line":"    # Version 1.0: Initial version, based off of Node version 1.18."},{"line_number":442,"context_line":"    # Version 1.1: Type of network_interface changed to just nullable string"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_49153a99","line":439,"updated":"2016-12-21 02:03:46.000000000","message":"hmm. do we add storage_interface now, or maybe do that later? If we do it later (i think we should), maybe we should add a NOTE here about that, otherwise we might forget.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        \u0027target_power_state\u0027: (\u0027node\u0027, \u0027target_power_state\u0027),"},{"line_number":437,"context_line":"        \u0027target_provision_state\u0027: (\u0027node\u0027, \u0027target_provision_state\u0027),"},{"line_number":438,"context_line":"        \u0027updated_at\u0027: (\u0027node\u0027, \u0027updated_at\u0027),"},{"line_number":439,"context_line":"        \u0027uuid\u0027: (\u0027node\u0027, \u0027uuid\u0027)"},{"line_number":440,"context_line":"    }"},{"line_number":441,"context_line":"    # Version 1.0: Initial version, based off of Node version 1.18."},{"line_number":442,"context_line":"    # Version 1.1: Type of network_interface changed to just nullable string"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_1e243ac3","line":439,"in_reply_to":"1a6eadb0_49153a99","updated":"2016-12-21 13:45:13.000000000","message":"I was thinking later, I can add a todo in-line.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    # Version 1.1: Type of network_interface changed to just nullable string"},{"line_number":443,"context_line":"    #              similar to version 1.20 of Node."},{"line_number":444,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":445,"context_line":"    fields \u003d {"},{"line_number":446,"context_line":"        \u0027clean_step\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":447,"context_line":"        \u0027console_enabled\u0027: object_fields.BooleanField(),"},{"line_number":448,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_e920c6f9","line":445,"updated":"2016-12-21 02:03:46.000000000","message":"when we add storage_interface, we\u0027ll have to bump the version here, and for any objects that inherit this.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    # Version 1.1: Type of network_interface changed to just nullable string"},{"line_number":443,"context_line":"    #              similar to version 1.20 of Node."},{"line_number":444,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":445,"context_line":"    fields \u003d {"},{"line_number":446,"context_line":"        \u0027clean_step\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":447,"context_line":"        \u0027console_enabled\u0027: object_fields.BooleanField(),"},{"line_number":448,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_aa2bfbe9","line":445,"in_reply_to":"1a6eadb0_e10b6322","updated":"2016-12-21 16:49:45.000000000","message":"Adding a TODO note reflecting both comments.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    # Version 1.1: Type of network_interface changed to just nullable string"},{"line_number":443,"context_line":"    #              similar to version 1.20 of Node."},{"line_number":444,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":445,"context_line":"    fields \u003d {"},{"line_number":446,"context_line":"        \u0027clean_step\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":447,"context_line":"        \u0027console_enabled\u0027: object_fields.BooleanField(),"},{"line_number":448,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_e10b6322","line":445,"in_reply_to":"1a6eadb0_e920c6f9","updated":"2016-12-21 13:45:13.000000000","message":"Fun!  Good to know.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"ironic/tests/unit/common/test_driver_factory.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self.assertEqual([\u0027flat\u0027, \u0027neutron\u0027, \u0027noop\u0027],"},{"line_number":141,"context_line":"                         sorted(factory._enabled_driver_list))"},{"line_number":142,"context_line":"        # NOTE(TheJulia) We should only check that the warn check is called,"},{"line_number":143,"context_line":"        # as opposed to called a number of times as it is called, for it is"},{"line_number":144,"context_line":"        # called as part of the driver loading interface in ironic, and"},{"line_number":145,"context_line":"        # inclusion of dynamic interfaces cause this number to need to be"},{"line_number":146,"context_line":"        # incremented per change which is not ideal."}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_c94f8abc","line":143,"updated":"2016-12-21 02:03:46.000000000","message":"maybe you mean s/called a number of times as it is called/the number of times it was called/","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # as opposed to called a number of times as it is called, for it is"},{"line_number":144,"context_line":"        # called as part of the driver loading interface in ironic, and"},{"line_number":145,"context_line":"        # inclusion of dynamic interfaces cause this number to need to be"},{"line_number":146,"context_line":"        # incremented per change which is not ideal."},{"line_number":147,"context_line":"        self.assertTrue(mock_warn.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_build_driver_for_task_default_is_none(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_a9db2eec","line":146,"updated":"2016-12-21 02:03:46.000000000","message":"i\u0027m actually ok with checking the actual number and up\u0027ing this value. how many dynamic interfaces are we going to add? the test failing w/o up\u0027ing the number is a good sign that things are working.\n\nAlthough I suppose this test is should only be about the NetworkInterface...\n\nWhat about just checking if mock_warn was called with the appropriate parameters for the 3 network interfaces (if that\u0027s what we\u0027re interested in here).","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # as opposed to called a number of times as it is called, for it is"},{"line_number":144,"context_line":"        # called as part of the driver loading interface in ironic, and"},{"line_number":145,"context_line":"        # inclusion of dynamic interfaces cause this number to need to be"},{"line_number":146,"context_line":"        # incremented per change which is not ideal."},{"line_number":147,"context_line":"        self.assertTrue(mock_warn.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_build_driver_for_task_default_is_none(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_f0a7a2b9","line":146,"in_reply_to":"1a6eadb0_2dc2aa34","updated":"2016-12-21 16:49:45.000000000","message":"Looks like all we get is a stevedore extension being passed to the call, and since it is dynamic, I\u0027m not really sure there is a good way to compare the calls against the interfaces. :(","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8cceb4c971e331ba40bb6e8bd25821cb6dcfbea5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # as opposed to called a number of times as it is called, for it is"},{"line_number":144,"context_line":"        # called as part of the driver loading interface in ironic, and"},{"line_number":145,"context_line":"        # inclusion of dynamic interfaces cause this number to need to be"},{"line_number":146,"context_line":"        # incremented per change which is not ideal."},{"line_number":147,"context_line":"        self.assertTrue(mock_warn.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_build_driver_for_task_default_is_none(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_2dc2aa34","line":146,"in_reply_to":"1a6eadb0_61e2f330","updated":"2016-12-21 15:05:33.000000000","message":"Sounds like too much work for not much gain.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # as opposed to called a number of times as it is called, for it is"},{"line_number":144,"context_line":"        # called as part of the driver loading interface in ironic, and"},{"line_number":145,"context_line":"        # inclusion of dynamic interfaces cause this number to need to be"},{"line_number":146,"context_line":"        # incremented per change which is not ideal."},{"line_number":147,"context_line":"        self.assertTrue(mock_warn.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_build_driver_for_task_default_is_none(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_61e2f330","line":146,"in_reply_to":"1a6eadb0_a9db2eec","updated":"2016-12-21 13:45:13.000000000","message":"So, counting the calls is actually broken in that when you change the way tox is executing, such as adding a new test file.  Deva\u0027s thought when I discussed it with him was that we should be using fixtures, but short of rewriting things to keep the unit tests happy... Well, you likely now understand why I changed it.\n\nI guess we could change it to evaluate the list of calls and look for the each of the three drivers being called for mock_warn, which is not even a warn, it is a check to if we should warn, which is why it felt silly to even count.  My only fear is given how far down the stack it is, that evaluating the the calls might actually turn into a test that has spurious failures.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"10d7dfced672d137e912862c19991a46f45f61c9","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            if iface \u003d\u003d \u0027network\u0027:"},{"line_number":317,"context_line":"                self.ifaces[iface] \u003d \u0027noop\u0027"},{"line_number":318,"context_line":"                enabled \u003d [\u0027noop\u0027]"},{"line_number":319,"context_line":"            elif iface \u003d\u003d \u0027storage\u0027:"},{"line_number":320,"context_line":"                self.ifaces[iface] \u003d \u0027noop\u0027"},{"line_number":321,"context_line":"                enabled \u003d [\u0027noop\u0027]"},{"line_number":322,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":35,"id":"da4df55a_67193b79","line":319,"updated":"2016-12-27 12:40:49.000000000","message":"nit:\n\n if iface in (\u0027network\u0027, \u0027storage\u0027):","commit_id":"c491e93a082ede262e617cebfd3022090e3e715b"}],"ironic/tests/unit/conductor/test_base_manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @mock.patch.object(driver_factory, \u0027NetworkInterfaceFactory\u0027)"},{"line_number":81,"context_line":"    @mock.patch.object(driver_factory, \u0027StorageInterfaceFactory\u0027)"},{"line_number":82,"context_line":"    def test_start_registers_driver_names(self, net_factory,"},{"line_number":83,"context_line":"                                          storage_factory):"},{"line_number":84,"context_line":"        init_names \u003d [\u0027fake1\u0027, \u0027fake2\u0027]"},{"line_number":85,"context_line":"        restart_names \u003d [\u0027fake3\u0027, \u0027fake4\u0027]"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_a4dd1572","line":83,"updated":"2016-12-21 02:03:46.000000000","message":"it is the other way around, isn\u0027t it? test...names(self, storage_factory, net_factory)","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @mock.patch.object(driver_factory, \u0027NetworkInterfaceFactory\u0027)"},{"line_number":81,"context_line":"    @mock.patch.object(driver_factory, \u0027StorageInterfaceFactory\u0027)"},{"line_number":82,"context_line":"    def test_start_registers_driver_names(self, net_factory,"},{"line_number":83,"context_line":"                                          storage_factory):"},{"line_number":84,"context_line":"        init_names \u003d [\u0027fake1\u0027, \u0027fake2\u0027]"},{"line_number":85,"context_line":"        restart_names \u003d [\u0027fake3\u0027, \u0027fake4\u0027]"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"1a6eadb0_a1188bd4","line":83,"in_reply_to":"1a6eadb0_a4dd1572","updated":"2016-12-21 13:45:13.000000000","message":"Heh, yes, I\u0027ll fix in the next revision.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"ironic/tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"4f4ae1e091ec28002e6a92a35047bc978e534f6b","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        # Add nodes for verification"},{"line_number":567,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":568,"context_line":"        data \u003d [{\u0027uuid\u0027: uuidutils.generate_uuid()}]"},{"line_number":569,"context_line":"        data \u003d [{\u0027uuid\u0027: uuidutils.generate_uuid()}]"},{"line_number":570,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":571,"context_line":"        return data"},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a89bdaa_d8d52de5","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":52},"updated":"2016-09-08 13:15:30.000000000","message":"Not clear why do we need assigned `data` two times?","commit_id":"2f117e404e9e2073da1708a153cac2a88777b6ab"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3c5a6f5be2367e6f15b8ab94433e341fe5bdb864","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        # Add nodes for verification"},{"line_number":567,"context_line":"        nodes \u003d db_utils.get_table(engine, \u0027nodes\u0027)"},{"line_number":568,"context_line":"        data \u003d [{\u0027uuid\u0027: uuidutils.generate_uuid()}]"},{"line_number":569,"context_line":"        data \u003d [{\u0027uuid\u0027: uuidutils.generate_uuid()}]"},{"line_number":570,"context_line":"        nodes.insert().values(data).execute()"},{"line_number":571,"context_line":"        return data"},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a89bdaa_00371bff","line":569,"range":{"start_line":569,"start_character":8,"end_line":569,"end_character":52},"in_reply_to":"9a89bdaa_d8d52de5","updated":"2016-09-08 14:25:00.000000000","message":"We don\u0027t... I wonder how that got there.  Anyway, I\u0027ll clean that up.  Thank you for pointing it out.","commit_id":"2f117e404e9e2073da1708a153cac2a88777b6ab"}],"releasenotes/notes/add-storage-interface-d4e64224804207fc.yaml":[{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"5a617c43fc91d22b5c074cbde9269be5dad90c80","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the initial substrate to allow for the creation of storage_interface"},{"line_number":5,"context_line":"    drivers. The default, interface for nodes is ``noop``, which routes to a no-op"},{"line_number":6,"context_line":"    driver that is inclued with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"},{"line_number":9,"context_line":"    [DEFAULT]enabled_storage_interfaces."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7a77a97e_ffb9d37a","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"updated":"2016-11-21 07:59:05.000000000","message":"typo:included","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c54ff1be063a503d2b2b1ce3f58458a23f47368e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the initial substrate to allow for the creation of storage_interface"},{"line_number":5,"context_line":"    drivers. The default, interface for nodes is ``noop``, which routes to a no-op"},{"line_number":6,"context_line":"    driver that is inclued with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"},{"line_number":9,"context_line":"    [DEFAULT]enabled_storage_interfaces."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7a77a97e_1f78368f","line":6,"range":{"start_line":6,"start_character":19,"end_line":6,"end_character":26},"in_reply_to":"7a77a97e_ffb9d37a","updated":"2016-11-21 17:04:22.000000000","message":"Done","commit_id":"81cd3f4d1135f672d171e072eb87be119cfbcade"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"83a43e8fe18d02a1e3984a30bb85bd09352f5757","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The ``[DEFAULT]default_storage_interface`` configuration option may be used"},{"line_number":12,"context_line":"    to override the default ``noop`` value for new nodes or existing nodes to"},{"line_number":13,"context_line":"    receieve upon the database schema being upgraded."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1a6eadb0_aa0437c0","line":13,"updated":"2016-12-13 19:05:08.000000000","message":"this no longer happens on database upgrade","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"20c07b21af65da5d2e816e66f8cad3a93fe419ee","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The ``[DEFAULT]default_storage_interface`` configuration option may be used"},{"line_number":12,"context_line":"    to override the default ``noop`` value for new nodes or existing nodes to"},{"line_number":13,"context_line":"    receieve upon the database schema being upgraded."}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1a6eadb0_64afb394","line":13,"in_reply_to":"1a6eadb0_aa0437c0","updated":"2016-12-13 20:27:16.000000000","message":"Good catch, will update.","commit_id":"519a7516e568f763bf37475f2c891a3a7a9e94a6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the initial substrate to allow for the creation of storage_interface"},{"line_number":5,"context_line":"    drivers. The default, interface for nodes is ``noop``, which routes to a no-op"},{"line_number":6,"context_line":"    driver that is included with the substrate."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a6eadb0_a4c43592","line":4,"updated":"2016-12-21 02:03:46.000000000","message":"s/Added/Adds/","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the initial substrate to allow for the creation of storage_interface"},{"line_number":5,"context_line":"    drivers. The default, interface for nodes is ``noop``, which routes to a no-op"},{"line_number":6,"context_line":"    driver that is included with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a6eadb0_e4554dc6","line":5,"updated":"2016-12-21 02:03:46.000000000","message":"are we calling them drivers? Maybe we can just say \u0027for the creation of storage interfaces\u0027.\n\ns/default, interface/default storage interface/","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the initial substrate to allow for the creation of storage_interface"},{"line_number":5,"context_line":"    drivers. The default, interface for nodes is ``noop``, which routes to a no-op"},{"line_number":6,"context_line":"    driver that is included with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a6eadb0_6172f312","line":5,"in_reply_to":"1a6eadb0_e4554dc6","updated":"2016-12-21 13:45:13.000000000","message":"Good point, it should be interface.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"817c6ff35e7a97f10f0448818802c3ccf034ec2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    driver that is included with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"},{"line_number":9,"context_line":"    [DEFAULT]enabled_storage_interfaces."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a6eadb0_8429f939","line":9,"updated":"2016-12-21 02:03:46.000000000","message":"I\u0027m not sure how useful this feature is for operators, since it is a noop interface right now and if we add nothing more, there won\u0027t be any diff to ironic from their point of view. (except for db change I guess). I don\u0027t know that we added \u0027intermediate\u0027 release notes for other features, but I don\u0027t recall. I guess we can remove/change this release note later.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a64d93969c12155694fe938329389b263a2144d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    driver that is included with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"},{"line_number":9,"context_line":"    [DEFAULT]enabled_storage_interfaces."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a6eadb0_308afabf","line":9,"in_reply_to":"1a6eadb0_8161cf3b","updated":"2016-12-21 16:49:45.000000000","message":"I\u0027m going to remove it since we\u0027re aligning with driver composition.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f7a2b4e19baf86988d357582667b5d38d89fa05a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    driver that is included with the substrate."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The configuration parameter for this substrate is"},{"line_number":9,"context_line":"    [DEFAULT]enabled_storage_interfaces."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1a6eadb0_8161cf3b","line":9,"in_reply_to":"1a6eadb0_8429f939","updated":"2016-12-21 13:45:13.000000000","message":"I suspected we would just update as we go, but we can defer it until later.","commit_id":"be0ce14c3eb5365ac8e6da19d3a7a3310083da16"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"30db5fb33bf6d22ceff54841768a581dbcab9a09","unresolved":false,"context_lines":[{"line_number":117,"context_line":"ironic.hardware.interfaces.vendor \u003d"},{"line_number":118,"context_line":"    no-vendor \u003d ironic.drivers.modules.noop:NoVendor"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"ironic.hardware.interfaces.storage \u003d"},{"line_number":121,"context_line":"    noop \u003d ironic.drivers.modules.noop:NoopStorage"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"ironic.database.migration_backend \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":28,"id":"3a71b18c_895189db","line":120,"updated":"2016-12-07 14:18:54.000000000","message":"nit: the ironic.hardware.interfaces entry point are currently sorted in this file","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6b1e925e4e27348d75240f5f71b04b7d0df59bc6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"ironic.hardware.interfaces.vendor \u003d"},{"line_number":118,"context_line":"    no-vendor \u003d ironic.drivers.modules.noop:NoVendor"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"ironic.hardware.interfaces.storage \u003d"},{"line_number":121,"context_line":"    noop \u003d ironic.drivers.modules.noop:NoopStorage"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"ironic.database.migration_backend \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":28,"id":"1a6eadb0_2b821f01","line":120,"in_reply_to":"3a71b18c_895189db","updated":"2016-12-12 22:22:07.000000000","message":"Done","commit_id":"1e7a3e793d04fad5949fd93e7d98697e7aa85710"}]}
