)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"df9f5115a3ad38f59ea435c65a03e3355f5b8861","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic management I/F for Inject NMI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the generic management interface to support Inject"},{"line_number":10,"context_line":"NMI."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1526226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"5a3905b3_88d5b844","line":9,"updated":"2017-01-19 21:16:50.000000000","message":"Can a longer explanation be put into this commit message?\n\nWhat is being done?\n\nWhy is it being done?","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"54617a5622872b3f269a7a1c616eff71d024b0bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic management I/F for Inject NMI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the generic management interface to support Inject"},{"line_number":10,"context_line":"NMI."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1526226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"5a3905b3_2eba036f","line":9,"in_reply_to":"5a3905b3_88d5b844","updated":"2017-01-20 02:16:14.000000000","message":"I\u0027ll fix that.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"}],"etc/ironic/policy.json.sample":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"6de8204580db5c8a88172c8fc8e742eebc929813","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\"admin_api\": \"role:admin or role:administrator\""},{"line_number":3,"context_line":"# Internal flag for public API routes"},{"line_number":4,"context_line":"\"public_api\": \"is_public_api:True\""},{"line_number":5,"context_line":"# Show or mask secrets within node driver information in API responses"},{"line_number":6,"context_line":"\"show_password\": \"!\""},{"line_number":7,"context_line":"# Show or mask secrets within instance information in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa6399be_edff7463","line":5,"updated":"2016-10-17 14:05:14.000000000","message":"Is this change related to this NMI feature?\nThis change seems to have been contained accidently.","commit_id":"ad70d03b72e0d65aedf2ffad18cbfc8e3ca194a4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5bd9c5866a8464a5b49a1c2e461822c6b2048ec0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\"admin_api\": \"role:admin or role:administrator\""},{"line_number":3,"context_line":"# Internal flag for public API routes"},{"line_number":4,"context_line":"\"public_api\": \"is_public_api:True\""},{"line_number":5,"context_line":"# Show or mask secrets within node driver information in API responses"},{"line_number":6,"context_line":"\"show_password\": \"!\""},{"line_number":7,"context_line":"# Show or mask secrets within instance information in API responses"},{"line_number":8,"context_line":"\"show_instance_secrets\": \"!\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"fa6399be_2a8e2f2e","line":5,"in_reply_to":"fa6399be_edff7463","updated":"2016-10-20 05:38:29.000000000","message":"No, this file is created by \u0027$ tox -egenpolicy\u0027","commit_id":"ad70d03b72e0d65aedf2ffad18cbfc8e3ca194a4"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"c06c4b8b88991a189888f4e68804f3419be85c71","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":262,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":263,"context_line":"                 inject nmi."},{"line_number":264,"context_line":"        \"\"\""},{"line_number":265,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":266,"context_line":"            raise exception.NotAcceptable()"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_d7af3fe1","line":264,"updated":"2016-09-21 02:29:53.000000000","message":"policy.authorize() is necessary like other APIs.","commit_id":"3c8143bc42cb866fd0448f8839d7f19a94339071"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"86905e0c9435529d53c212c71327925924cab9fb","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":262,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":263,"context_line":"                 inject nmi."},{"line_number":264,"context_line":"        \"\"\""},{"line_number":265,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":266,"context_line":"            raise exception.NotAcceptable()"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_9c7073de","line":264,"in_reply_to":"7a8ec9b2_d7af3fe1","updated":"2016-09-21 07:36:36.000000000","message":"I\u0027ll fix that.","commit_id":"3c8143bc42cb866fd0448f8839d7f19a94339071"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e63921a2bdf055a3a0c18ee19894f5ea737179c7","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotAcceptable()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":271,"context_line":"        policy.authorize(\u0027baremetal:node:inject_nmi\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a3c09a3_fc7ac775","line":268,"range":{"start_line":268,"start_character":18,"end_line":268,"end_character":43},"updated":"2017-01-18 15:39:11.000000000","message":"This is a new endpoint, our convention is to use 404 in such case.","commit_id":"32067ecdd370e96f12d6de42968692e95d75fb73"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6cb0b1d28a6977e8f41dc9adffcb70b0f72aa135","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotAcceptable()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":271,"context_line":"        policy.authorize(\u0027baremetal:node:inject_nmi\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a3905b3_87d87a1f","line":268,"range":{"start_line":268,"start_character":18,"end_line":268,"end_character":43},"in_reply_to":"7a3c09a3_fc7ac775","updated":"2017-01-19 05:16:11.000000000","message":"I\u0027ll fix that.","commit_id":"32067ecdd370e96f12d6de42968692e95d75fb73"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f4e6ade90b0a2c06ed42c14bbfe65532dc4b67","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":264,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_85b94d31","line":265,"updated":"2017-01-19 08:59:43.000000000","message":"nit: may raise more exceptions Forbidden when not authorized, NodeNotFound,  and all exceptions from inject_nmi rpc call https://review.openstack.org/#/c/348191/25/ironic/conductor/rpcapi.py@568","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eb8406bf15e4ed20e6bc2abf3413acb02f393561","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":264,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_6826ccbb","line":265,"in_reply_to":"5a3905b3_5bf666d8","updated":"2017-01-19 21:07:08.000000000","message":"++ please fix before merging","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1980929f8cbfc1d5ceb49dabade3606683357f54","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":264,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_e8c47c93","line":265,"in_reply_to":"5a3905b3_6826ccbb","updated":"2017-01-19 21:18:45.000000000","message":"+1","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"54617a5622872b3f269a7a1c616eff71d024b0bb","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":264,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_4821074d","line":265,"in_reply_to":"5a3905b3_85b94d31","updated":"2017-01-20 02:16:14.000000000","message":"I\u0027ll fix that.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1d338bc3b4d699289580cdb87d51d28f9573d3b7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param node_ident: the UUID or logical name of a node."},{"line_number":264,"context_line":"        :raises: NotAcceptable if requested version of the API doesn\u0027t support"},{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_5bf666d8","line":265,"in_reply_to":"5a3905b3_85b94d31","updated":"2017-01-19 09:07:45.000000000","message":"Oh, right, need to pay more attention to docstrings :) And it does not raise NotAcceptable anymore.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"df9f5115a3ad38f59ea435c65a03e3355f5b8861","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":271,"context_line":"        policy.authorize(\u0027baremetal:node:inject_nmi\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_284a04c6","line":268,"updated":"2017-01-19 21:16:50.000000000","message":"Is this the same exception that would have been raised before this patch?","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"54617a5622872b3f269a7a1c616eff71d024b0bb","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                 inject nmi."},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if not api_utils.allow_inject_nmi():"},{"line_number":268,"context_line":"            raise exception.NotFound()"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":271,"context_line":"        policy.authorize(\u0027baremetal:node:inject_nmi\u0027, cdict, cdict)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_a868ab88","line":268,"in_reply_to":"5a3905b3_284a04c6","updated":"2017-01-20 02:16:14.000000000","message":"Yes, because this is a new endpoint as Vladyslav pointed out.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f4e6ade90b0a2c06ed42c14bbfe65532dc4b67","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    return pecan.request.version.minor \u003e\u003d versions.MINOR_27_SOFT_POWER_OFF"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"def allow_inject_nmi():"},{"line_number":382,"context_line":"    \"\"\"Check if Inject NMI is allowed for the node."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    Version 1.29 of the API allows Inject NMI for the node."}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_c5cfd5b1","line":381,"updated":"2017-01-19 08:59:43.000000000","message":"Can we have a unit tests for this?","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"54617a5622872b3f269a7a1c616eff71d024b0bb","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    return pecan.request.version.minor \u003e\u003d versions.MINOR_27_SOFT_POWER_OFF"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"def allow_inject_nmi():"},{"line_number":382,"context_line":"    \"\"\"Check if Inject NMI is allowed for the node."},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    Version 1.29 of the API allows Inject NMI for the node."}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_65ac2e36","line":381,"in_reply_to":"5a3905b3_c5cfd5b1","updated":"2017-01-20 02:16:14.000000000","message":"I\u0027ll add that.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"}],"ironic/conductor/manager.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a23e4acf81c72c5df27264c1a84d36b093a6276b","unresolved":false,"context_lines":[{"line_number":2020,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":2021,"context_line":"                    driver\u003dnode.driver, extension\u003d\u0027management\u0027)"},{"line_number":2022,"context_line":"            task.driver.management.validate(task)"},{"line_number":2023,"context_line":"            task.driver.management.inject_nmi(task)"},{"line_number":2024,"context_line":""},{"line_number":2025,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2026,"context_line":"                                   exception.UnsupportedDriverExtension,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_2c428a68","line":2023,"updated":"2016-10-03 03:05:31.000000000","message":"IMO, when a NotImplementedError is raised, it would be better to raise a similar exception to exception.UnsupportedDriverExtention for consistency.\nIf simply a NotImplementedError is raised, no information is provided to a user.","commit_id":"f3336e087571474f407d46f35a0c45619f6c1299"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5bdc0b45456086780342d488fb29df96ce4fe041","unresolved":false,"context_lines":[{"line_number":2020,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":2021,"context_line":"                    driver\u003dnode.driver, extension\u003d\u0027management\u0027)"},{"line_number":2022,"context_line":"            task.driver.management.validate(task)"},{"line_number":2023,"context_line":"            task.driver.management.inject_nmi(task)"},{"line_number":2024,"context_line":""},{"line_number":2025,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2026,"context_line":"                                   exception.UnsupportedDriverExtension,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_ed6b351c","line":2023,"in_reply_to":"3a98d1f4_2c428a68","updated":"2016-10-03 07:21:56.000000000","message":"If NotImplementedError is raised, it is raised as is to the caller.\n\nI\u0027ll add the docstring:\n\n:raises: NotImplementedError","commit_id":"f3336e087571474f407d46f35a0c45619f6c1299"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8566a1f5e9349a74a48e66a6f9a762f8fc8c7c16","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is"},{"line_number":2055,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":2056,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":2057,"context_line":"        :raises: NotImplementedError"},{"line_number":2058,"context_line":"        \"\"\""},{"line_number":2059,"context_line":"        LOG.debug(\u0027RPC inject_nmi called for node %(node)s\u0027, node_id)"},{"line_number":2060,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_a10b007c","line":2057,"range":{"start_line":2057,"start_character":17,"end_line":2057,"end_character":36},"updated":"2016-10-14 14:51:36.000000000","message":"NotImplementedError doesn\u0027t contain any http code or any message.\nIf it is raised as is, no helpful information is returned to a user (only 500 internal server error is returned).\nI prefer raising another exception with http code and error message.","commit_id":"e8a3fa583a4df08ecfd4f92cde10a7897a21f445"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e969c961d2e671f9ed2a08104e5f0fa68be13659","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is"},{"line_number":2055,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":2056,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":2057,"context_line":"        :raises: NotImplementedError"},{"line_number":2058,"context_line":"        \"\"\""},{"line_number":2059,"context_line":"        LOG.debug(\u0027RPC inject_nmi called for node %(node)s\u0027, node_id)"},{"line_number":2060,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_09a74ebd","line":2057,"range":{"start_line":2057,"start_character":17,"end_line":2057,"end_character":36},"in_reply_to":"fa6399be_a10b007c","updated":"2016-10-17 05:08:31.000000000","message":"I\u0027ll fix that.","commit_id":"e8a3fa583a4df08ecfd4f92cde10a7897a21f445"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"6de8204580db5c8a88172c8fc8e742eebc929813","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":2055,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":2056,"context_line":"        \"\"\""},{"line_number":2057,"context_line":"        LOG.debug(\u0027RPC inject_nmi called for node %(node)s\u0027, node_id)"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"        with task_manager.acquire(context, node_id,"},{"line_number":2060,"context_line":"                                  purpose\u003d\u0027inject nmi\u0027) as task:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_68ec32bb","line":2057,"range":{"start_line":2057,"start_character":50,"end_line":2057,"end_character":58},"updated":"2016-10-17 14:05:14.000000000","message":"nit: %s","commit_id":"ad70d03b72e0d65aedf2ffad18cbfc8e3ca194a4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5bd9c5866a8464a5b49a1c2e461822c6b2048ec0","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":2055,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":2056,"context_line":"        \"\"\""},{"line_number":2057,"context_line":"        LOG.debug(\u0027RPC inject_nmi called for node %(node)s\u0027, node_id)"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"        with task_manager.acquire(context, node_id,"},{"line_number":2060,"context_line":"                                  purpose\u003d\u0027inject nmi\u0027) as task:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_6ab667fa","line":2057,"range":{"start_line":2057,"start_character":50,"end_line":2057,"end_character":58},"in_reply_to":"fa6399be_68ec32bb","updated":"2016-10-20 05:38:29.000000000","message":"I\u0027ll fix that.","commit_id":"ad70d03b72e0d65aedf2ffad18cbfc8e3ca194a4"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a4eb7cb5f50ec37c2f3a17dc34950dc84d85a40f","unresolved":false,"context_lines":[{"line_number":2025,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2026,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2027,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":2028,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":2029,"context_line":"    def inject_nmi(self, context, node_id):"},{"line_number":2030,"context_line":"        \"\"\"Inject NMI for a node."},{"line_number":2031,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_de7115e2","line":2028,"range":{"start_line":2028,"start_character":35,"end_line":2028,"end_character":66},"updated":"2016-11-09 01:24:25.000000000","message":"I\u0027ll remove here too.","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6ea907a3d74506740727acab9f4bae421180f7ac","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2061,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2062,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":2063,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":2064,"context_line":"    def get_supported_boot_devices(self, context, node_id):"},{"line_number":2065,"context_line":"        \"\"\"Get the list of supported devices."},{"line_number":2066,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_31ce2084","line":2063,"updated":"2016-11-07 11:10:59.000000000","message":"This should be fixed, but outside the scope of this patch.\n\nThere are others that should be fixed as well, see L2167","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bfd93909d3a09f707c62175dfa56dfda769287a4","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2061,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2062,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":2063,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":2064,"context_line":"    def get_supported_boot_devices(self, context, node_id):"},{"line_number":2065,"context_line":"        \"\"\"Get the list of supported devices."},{"line_number":2066,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_3c4fb493","line":2063,"in_reply_to":"9a629dbe_31ce2084","updated":"2016-11-08 01:57:11.000000000","message":"Okay, I\u0027ll revert it, and submit another patch to fix here and L.2167.","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"25c9d818a56f372e3b635953ba18f892421a10ba","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2061,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2062,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":2063,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":2064,"context_line":"    def get_supported_boot_devices(self, context, node_id):"},{"line_number":2065,"context_line":"        \"\"\"Get the list of supported devices."},{"line_number":2066,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_f24645be","line":2063,"in_reply_to":"9a629dbe_3c4fb493","updated":"2016-11-08 02:59:05.000000000","message":"submitted https://review.openstack.org/#/c/394713/","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a4eb7cb5f50ec37c2f3a17dc34950dc84d85a40f","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2061,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2062,"context_line":"                                   exception.InvalidParameterValue,"},{"line_number":2063,"context_line":"                                   exception.MissingParameterValue)"},{"line_number":2064,"context_line":"    def get_supported_boot_devices(self, context, node_id):"},{"line_number":2065,"context_line":"        \"\"\"Get the list of supported devices."},{"line_number":2066,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_1ead4d31","line":2063,"in_reply_to":"9a629dbe_f24645be","updated":"2016-11-09 01:24:25.000000000","message":"Abandoned [1] since MissingParameterValue is subclass of InvalidParameterValue.\n\n[1] https://review.openstack.org/#/c/394713/","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"daa09c2ef03bf54da23d07e6adb0187b7ff42cb5","unresolved":false,"context_lines":[{"line_number":2202,"context_line":"                task.driver.management.inject_nmi(task)"},{"line_number":2203,"context_line":"            except NotImplementedError:"},{"line_number":2204,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":2205,"context_line":"                    driver\u003dtask.driver.management.__class__.__name__,"},{"line_number":2206,"context_line":"                    extension\u003d\u0027inject_nmi\u0027)"},{"line_number":2207,"context_line":""},{"line_number":2208,"context_line":"    @METRICS.timer(\u0027ConductorManager.get_supported_boot_devices\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a3c09a3_45fc1a72","line":2205,"updated":"2017-01-17 17:17:26.000000000","message":"interface class names are less known to users, we may still want to use node.driver here","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f8fe98a2b12538ec1ee65da5ab9a1bb729f7199e","unresolved":false,"context_lines":[{"line_number":2202,"context_line":"                task.driver.management.inject_nmi(task)"},{"line_number":2203,"context_line":"            except NotImplementedError:"},{"line_number":2204,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":2205,"context_line":"                    driver\u003dtask.driver.management.__class__.__name__,"},{"line_number":2206,"context_line":"                    extension\u003d\u0027inject_nmi\u0027)"},{"line_number":2207,"context_line":""},{"line_number":2208,"context_line":"    @METRICS.timer(\u0027ConductorManager.get_supported_boot_devices\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a3c09a3_137b2b29","line":2205,"in_reply_to":"7a3c09a3_45fc1a72","updated":"2017-01-18 00:44:14.000000000","message":"I\u0027ll fix that.","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7c98ea87953f5f5399c0b400b9e9d4b980150886","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"            task.driver.management.validate(task)"},{"line_number":2201,"context_line":"            try:"},{"line_number":2202,"context_line":"                task.driver.management.inject_nmi(task)"},{"line_number":2203,"context_line":"            except exception.UnsupportedDriverExtension:"},{"line_number":2204,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":2205,"context_line":"                    driver\u003dnode.driver, extension\u003d\u0027inject_nmi\u0027)"},{"line_number":2206,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7a3c09a3_34539418","line":2203,"updated":"2017-01-18 12:09:24.000000000","message":"there is no point in catching this exception and replacing it with the same, just let it fall through","commit_id":"32067ecdd370e96f12d6de42968692e95d75fb73"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6cb0b1d28a6977e8f41dc9adffcb70b0f72aa135","unresolved":false,"context_lines":[{"line_number":2200,"context_line":"            task.driver.management.validate(task)"},{"line_number":2201,"context_line":"            try:"},{"line_number":2202,"context_line":"                task.driver.management.inject_nmi(task)"},{"line_number":2203,"context_line":"            except exception.UnsupportedDriverExtension:"},{"line_number":2204,"context_line":"                raise exception.UnsupportedDriverExtension("},{"line_number":2205,"context_line":"                    driver\u003dnode.driver, extension\u003d\u0027inject_nmi\u0027)"},{"line_number":2206,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5a3905b3_c708c294","line":2203,"in_reply_to":"7a3c09a3_34539418","updated":"2017-01-19 05:16:11.000000000","message":"Right, I\u0027ll fix that.","commit_id":"32067ecdd370e96f12d6de42968692e95d75fb73"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f4e6ade90b0a2c06ed42c14bbfe65532dc4b67","unresolved":false,"context_lines":[{"line_number":2174,"context_line":"    @METRICS.timer(\u0027ConductorManager.inject_nmi\u0027)"},{"line_number":2175,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2176,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2177,"context_line":"                                   exception.InvalidParameterValue)"},{"line_number":2178,"context_line":"    def inject_nmi(self, context, node_id):"},{"line_number":2179,"context_line":"        \"\"\"Inject NMI for a node."},{"line_number":2180,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_255df9e9","line":2177,"updated":"2017-01-19 08:59:43.000000000","message":"MissingParameterValue should be here too.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1d338bc3b4d699289580cdb87d51d28f9573d3b7","unresolved":false,"context_lines":[{"line_number":2174,"context_line":"    @METRICS.timer(\u0027ConductorManager.inject_nmi\u0027)"},{"line_number":2175,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2176,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2177,"context_line":"                                   exception.InvalidParameterValue)"},{"line_number":2178,"context_line":"    def inject_nmi(self, context, node_id):"},{"line_number":2179,"context_line":"        \"\"\"Inject NMI for a node."},{"line_number":2180,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_3b20ba49","line":2177,"in_reply_to":"5a3905b3_255df9e9","updated":"2017-01-19 09:07:45.000000000","message":"Nope, it is inherited from missing, should be fine as is.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"df9f5115a3ad38f59ea435c65a03e3355f5b8861","unresolved":false,"context_lines":[{"line_number":2174,"context_line":"    @METRICS.timer(\u0027ConductorManager.inject_nmi\u0027)"},{"line_number":2175,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2176,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2177,"context_line":"                                   exception.InvalidParameterValue)"},{"line_number":2178,"context_line":"    def inject_nmi(self, context, node_id):"},{"line_number":2179,"context_line":"        \"\"\"Inject NMI for a node."},{"line_number":2180,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_88093898","line":2177,"in_reply_to":"5a3905b3_3b20ba49","updated":"2017-01-19 21:16:50.000000000","message":"MissingParameterValue inherits from InvalidParameterValue","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f0ed2fcea740e886a0553d6e6b2b7a328fd21e1c","unresolved":false,"context_lines":[{"line_number":2174,"context_line":"    @METRICS.timer(\u0027ConductorManager.inject_nmi\u0027)"},{"line_number":2175,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked,"},{"line_number":2176,"context_line":"                                   exception.UnsupportedDriverExtension,"},{"line_number":2177,"context_line":"                                   exception.InvalidParameterValue)"},{"line_number":2178,"context_line":"    def inject_nmi(self, context, node_id):"},{"line_number":2179,"context_line":"        \"\"\"Inject NMI for a node."},{"line_number":2180,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_68bc0c6d","line":2177,"in_reply_to":"5a3905b3_88093898","updated":"2017-01-19 21:20:41.000000000","message":"both UnsuportedRiverExtension and InvalidParameterValue are inherited from Invalid, but we specify both of them.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"5bdc0b45456086780342d488fb29df96ce4fe041","unresolved":false,"context_lines":[{"line_number":552,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":553,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"        \"\"\""},{"line_number":556,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.36\u0027)"},{"line_number":557,"context_line":"        return cctxt.call(context, \u0027inject_nmi\u0027, node_id\u003dnode_id)"},{"line_number":558,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_ad5ccd7d","line":555,"range":{"start_line":555,"start_character":8,"end_line":555,"end_character":11},"updated":"2016-10-03 07:21:56.000000000","message":"I\u0027ll add the docstring \n\n:raises: NotImplementedError","commit_id":"f3336e087571474f407d46f35a0c45619f6c1299"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"daa09c2ef03bf54da23d07e6adb0187b7ff42cb5","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is"},{"line_number":571,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":572,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":573,"context_line":"        :raises: NotImplementedError"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        \"\"\""},{"line_number":576,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.40\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a3c09a3_6501166a","line":573,"updated":"2017-01-17 17:17:26.000000000","message":"we don\u0027t allow NotImplementedError to propagate from Manager\u0027s inject_nmi, so it should not be here","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f8fe98a2b12538ec1ee65da5ab9a1bb729f7199e","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        :raises: InvalidParameterValue when the wrong driver info is"},{"line_number":571,"context_line":"                 specified or an invalid boot device is specified."},{"line_number":572,"context_line":"        :raises: MissingParameterValue if missing supplied info."},{"line_number":573,"context_line":"        :raises: NotImplementedError"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        \"\"\""},{"line_number":576,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.40\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a3c09a3_b6088529","line":573,"in_reply_to":"7a3c09a3_6501166a","updated":"2017-01-18 00:44:14.000000000","message":"I\u0027ll fix that.","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"}],"ironic/drivers/base.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"c914f400a9a7e8f2e37630403019d76d7b516231","unresolved":false,"context_lines":[{"line_number":895,"context_line":"                      }"},{"line_number":896,"context_line":"        \"\"\""},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        @abc.abstractmethod"},{"line_number":899,"context_line":"        def inject_nmi(self, task):"},{"line_number":900,"context_line":"            \"\"\"Inject NMI, Non Maskable Interrupt."},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_a8f05efe","line":898,"range":{"start_line":898,"start_character":4,"end_line":898,"end_character":8},"updated":"2016-09-23 02:54:35.000000000","message":"Indent is incorrect.","commit_id":"4bf1bd184f93929a3745cefcacae31032b6a691c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"9cb1762cd3b596558d9accef2f2111cbf1b0f7d7","unresolved":false,"context_lines":[{"line_number":895,"context_line":"                      }"},{"line_number":896,"context_line":"        \"\"\""},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        @abc.abstractmethod"},{"line_number":899,"context_line":"        def inject_nmi(self, task):"},{"line_number":900,"context_line":"            \"\"\"Inject NMI, Non Maskable Interrupt."},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_fe406f36","line":898,"range":{"start_line":898,"start_character":4,"end_line":898,"end_character":8},"in_reply_to":"7a8ec9b2_a8f05efe","updated":"2016-09-26 05:14:31.000000000","message":"I\u0027ll fix that.","commit_id":"4bf1bd184f93929a3745cefcacae31032b6a691c"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7aa955f581b4670959d8bd444ba576e3f3bbac03","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":904,"context_line":"        :returns: None"},{"line_number":905,"context_line":"        \"\"\""},{"line_number":906,"context_line":"        pass"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_33dcb772","line":906,"updated":"2016-09-26 13:56:48.000000000","message":"It would be better to raise an exception to let a user know this method is not implemented in a driver.","commit_id":"15c8aea1354c4adaa75e115ad767a2e072ed7c85"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"77c50ee77355da4a26c360b2e75cb81b6220dd80","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":904,"context_line":"        :returns: None"},{"line_number":905,"context_line":"        \"\"\""},{"line_number":906,"context_line":"        pass"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_13ca361b","line":906,"in_reply_to":"5a8bc5a2_33dcb772","updated":"2016-09-27 01:33:35.000000000","message":"I\u0027ll fix that.","commit_id":"15c8aea1354c4adaa75e115ad767a2e072ed7c85"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"daa09c2ef03bf54da23d07e6adb0187b7ff42cb5","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":831,"context_line":"        :raises: NotImplementedError"},{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":"        raise NotImplementedError(_(\"inject_nmi is not implemented\"))"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"class InspectInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a3c09a3_250b8e8f","line":833,"updated":"2017-01-17 17:17:26.000000000","message":"I wonder why not raise UnsupportedDriverExtension here instead of raising NotImplementedError, then catching it and re-raising UnsupportedDriverExtension","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f8fe98a2b12538ec1ee65da5ab9a1bb729f7199e","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":831,"context_line":"        :raises: NotImplementedError"},{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":"        raise NotImplementedError(_(\"inject_nmi is not implemented\"))"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"class InspectInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a3c09a3_163959d7","line":833,"in_reply_to":"7a3c09a3_250b8e8f","updated":"2017-01-18 00:44:14.000000000","message":"I\u0027ll fix that.","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7c98ea87953f5f5399c0b400b9e9d4b980150886","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":834,"context_line":"            _(\"inject_nmi is not implemented\"))"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"class InspectInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a3c09a3_1450580a","line":834,"updated":"2017-01-18 12:09:24.000000000","message":"please raise it in the same manner as it was re-raised in conductor:\n\n raise exception.UnsupportedDriverExtension(driver\u003dtask.node.driver, extension\u003d\"inject_nmi\")","commit_id":"32067ecdd370e96f12d6de42968692e95d75fb73"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6cb0b1d28a6977e8f41dc9adffcb70b0f72aa135","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":832,"context_line":"        \"\"\""},{"line_number":833,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":834,"context_line":"            _(\"inject_nmi is not implemented\"))"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"class InspectInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a3905b3_e26daccd","line":834,"in_reply_to":"7a3c09a3_1450580a","updated":"2017-01-19 05:16:11.000000000","message":"I\u0027ll fix that.","commit_id":"32067ecdd370e96f12d6de42968692e95d75fb73"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f4e6ade90b0a2c06ed42c14bbfe65532dc4b67","unresolved":false,"context_lines":[{"line_number":3091,"context_line":"                            % self.node.uuid, {},"},{"line_number":3092,"context_line":"                            headers\u003d{api_base.Version.string: \"1.29\"},"},{"line_number":3093,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":3094,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_code)"},{"line_number":3095,"context_line":"        self.assertTrue(ret.json[\u0027error_message\u0027])"},{"line_number":3096,"context_line":"        mock_inject_nmi.assert_called_once_with(mock.ANY, self.node.uuid,"},{"line_number":3097,"context_line":"                                                topic\u003d\u0027test-topic\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_20b5e7cc","line":3094,"updated":"2017-01-19 08:59:43.000000000","message":"We have similar thing with raid if it is not supported we raise NOT_FOUND https://github.com/openstack/ironic/blob/1e49c7b07beb61cf2b5d4c15e3c344e158ade796/ironic/api/controllers/v1/node.py#L438","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1980929f8cbfc1d5ceb49dabade3606683357f54","unresolved":false,"context_lines":[{"line_number":3091,"context_line":"                            % self.node.uuid, {},"},{"line_number":3092,"context_line":"                            headers\u003d{api_base.Version.string: \"1.29\"},"},{"line_number":3093,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":3094,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_code)"},{"line_number":3095,"context_line":"        self.assertTrue(ret.json[\u0027error_message\u0027])"},{"line_number":3096,"context_line":"        mock_inject_nmi.assert_called_once_with(mock.ANY, self.node.uuid,"},{"line_number":3097,"context_line":"                                                topic\u003d\u0027test-topic\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_68796cfc","line":3094,"in_reply_to":"5a3905b3_20b5e7cc","updated":"2017-01-19 21:18:45.000000000","message":"BAD_REQUEST does match the error for the nodes/{node}/management/boot_device endpoint though, so maybe it should stay as-is for consistency","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"71dc5e1f96fabbf4904482cb4735fcbaefaf05bd","unresolved":false,"context_lines":[{"line_number":3091,"context_line":"                            % self.node.uuid, {},"},{"line_number":3092,"context_line":"                            headers\u003d{api_base.Version.string: \"1.29\"},"},{"line_number":3093,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":3094,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_code)"},{"line_number":3095,"context_line":"        self.assertTrue(ret.json[\u0027error_message\u0027])"},{"line_number":3096,"context_line":"        mock_inject_nmi.assert_called_once_with(mock.ANY, self.node.uuid,"},{"line_number":3097,"context_line":"                                                topic\u003d\u0027test-topic\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_e32472b0","line":3094,"in_reply_to":"5a3905b3_5c8536ab","updated":"2017-01-20 15:21:02.000000000","message":"Well, as always, our status codes are not good :( Looking at their descriptions, 501 Not Implemented fits the best.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f632aaf624fdde67c7c2cf45456718b0120e6bf3","unresolved":false,"context_lines":[{"line_number":3091,"context_line":"                            % self.node.uuid, {},"},{"line_number":3092,"context_line":"                            headers\u003d{api_base.Version.string: \"1.29\"},"},{"line_number":3093,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":3094,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_code)"},{"line_number":3095,"context_line":"        self.assertTrue(ret.json[\u0027error_message\u0027])"},{"line_number":3096,"context_line":"        mock_inject_nmi.assert_called_once_with(mock.ANY, self.node.uuid,"},{"line_number":3097,"context_line":"                                                topic\u003d\u0027test-topic\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_5c8536ab","line":3094,"in_reply_to":"5a3905b3_68796cfc","updated":"2017-01-20 11:08:55.000000000","message":"BAD_REQUEST comes when invalid boot device specified, while in this case extension is not supported. It is a different cases.\nI still think here should be NOT_FOUND.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"47b6120b92a11a059ee466df2769b11dc5aff838","unresolved":false,"context_lines":[{"line_number":3091,"context_line":"                            % self.node.uuid, {},"},{"line_number":3092,"context_line":"                            headers\u003d{api_base.Version.string: \"1.29\"},"},{"line_number":3093,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":3094,"context_line":"        self.assertEqual(http_client.BAD_REQUEST, ret.status_code)"},{"line_number":3095,"context_line":"        self.assertTrue(ret.json[\u0027error_message\u0027])"},{"line_number":3096,"context_line":"        mock_inject_nmi.assert_called_once_with(mock.ANY, self.node.uuid,"},{"line_number":3097,"context_line":"                                                topic\u003d\u0027test-topic\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"5a3905b3_43f46685","line":3094,"in_reply_to":"5a3905b3_e32472b0","updated":"2017-01-20 15:27:23.000000000","message":"Oh, actually, a relevant guideline from api-wg -- https://specs.openstack.org/openstack/api-wg/guidelines/http.html#use-of-501-not-implemented\n\nSeems like bad request is the way to go!","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6ea907a3d74506740727acab9f4bae421180f7ac","unresolved":false,"context_lines":[{"line_number":3397,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":3398,"context_line":"        self.assertEqual(exception.UnsupportedDriverExtension,"},{"line_number":3399,"context_line":"                         exc.exc_info[0])"},{"line_number":3400,"context_line":""},{"line_number":3401,"context_line":"    def test_get_supported_boot_devices(self):"},{"line_number":3402,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":3403,"context_line":"        bootdevs \u003d self.service.get_supported_boot_devices(self.context,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_f1d028cc","line":3400,"updated":"2016-11-07 11:10:59.000000000","message":"MissingParameterValue as well ?","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bfd93909d3a09f707c62175dfa56dfda769287a4","unresolved":false,"context_lines":[{"line_number":3397,"context_line":"        # Compare true exception hidden by @messaging.expected_exceptions"},{"line_number":3398,"context_line":"        self.assertEqual(exception.UnsupportedDriverExtension,"},{"line_number":3399,"context_line":"                         exc.exc_info[0])"},{"line_number":3400,"context_line":""},{"line_number":3401,"context_line":"    def test_get_supported_boot_devices(self):"},{"line_number":3402,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027fake\u0027)"},{"line_number":3403,"context_line":"        bootdevs \u003d self.service.get_supported_boot_devices(self.context,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a629dbe_bf3e56b6","line":3400,"in_reply_to":"9a629dbe_f1d028cc","updated":"2016-11-08 01:57:11.000000000","message":"I\u0027ll add that.","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"}],"releasenotes/notes/inject-nmi-dacd692b1f259a30.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6ea907a3d74506740727acab9f4bae421180f7ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support Inject NMI CLI and API for a node."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_f10bc87b","line":3,"updated":"2016-11-07 11:10:59.000000000","message":"Should mention the API version bump here","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bfd93909d3a09f707c62175dfa56dfda769287a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support Inject NMI CLI and API for a node."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9a629dbe_5ff37a0a","line":3,"in_reply_to":"9a629dbe_f10bc87b","updated":"2016-11-08 01:57:11.000000000","message":"I\u0027ll add that.","commit_id":"c2d296747c40a585f557952d19b367c497348ce1"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b18845f653990c0f74e62e777aad2b6f616b2004","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support Inject NMI CLI and API with API version 1.28 for a node."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5201f7_14fef4ad","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":43},"updated":"2017-01-11 15:30:55.000000000","message":"So this change does not contain the CLI change, unless that has already landed, we shouldn\u0027t mention it here.\n\nnit: Too many three letter acronyms.  Perhaps \"Add support for the injection of Non-Masking Interrupts (NMI)\" ?","commit_id":"cc1d742d7c5e4c3f2e3ee85116f1410c4aa4c608"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ad6e48ea1e2e370f0d1a67614380f6ea84ee2692","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Support Inject NMI CLI and API with API version 1.28 for a node."}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5201f7_7fe45f3b","line":3,"range":{"start_line":3,"start_character":19,"end_line":3,"end_character":43},"in_reply_to":"ba5201f7_14fef4ad","updated":"2017-01-12 02:50:34.000000000","message":"I\u0027ll fix that.","commit_id":"cc1d742d7c5e4c3f2e3ee85116f1410c4aa4c608"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"daa09c2ef03bf54da23d07e6adb0187b7ff42cb5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for the injection of Non-Masking Interrupts (NMI) with"},{"line_number":4,"context_line":"    API version 1.29 for a node."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a3c09a3_85fa8273","line":4,"updated":"2017-01-17 17:17:26.000000000","message":"It\u0027s worth mentioning that actual support for this feature depends on a driver.","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f8fe98a2b12538ec1ee65da5ab9a1bb729f7199e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for the injection of Non-Masking Interrupts (NMI) with"},{"line_number":4,"context_line":"    API version 1.29 for a node."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a3c09a3_b63a45e5","line":4,"in_reply_to":"7a3c09a3_85fa8273","updated":"2017-01-18 00:44:14.000000000","message":"I\u0027ll fix that.","commit_id":"e75b5aca2ffb789d9d609ed3db806af8e6da6c87"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f4e6ade90b0a2c06ed42c14bbfe65532dc4b67","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for the injection of Non-Masking Interrupts (NMI) with"},{"line_number":4,"context_line":"    API version 1.29 for a node. Actual support for this feature"},{"line_number":5,"context_line":"    depends on a driver."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5a3905b3_201167ad","line":5,"updated":"2017-01-19 08:59:43.000000000","message":"Might be rephrase to \"Add support for the injection of Non-Masking Interrupts (NMI) for a node in Ironic API 1.29\"\n\nAlso might be mention what exactly management driver should support it.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eb8406bf15e4ed20e6bc2abf3413acb02f393561","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for the injection of Non-Masking Interrupts (NMI) with"},{"line_number":4,"context_line":"    API version 1.29 for a node. Actual support for this feature"},{"line_number":5,"context_line":"    depends on a driver."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5a3905b3_a87c3473","line":5,"in_reply_to":"5a3905b3_201167ad","updated":"2017-01-19 21:07:08.000000000","message":"Maybe leave the what drivers support it bit for... the patches that implement driver support ;).\n\nI do think adding a small blurb about the usefulness of NMI to the release note is a good idea as well, as it\u0027s not a commonly known acronym.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1980929f8cbfc1d5ceb49dabade3606683357f54","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for the injection of Non-Masking Interrupts (NMI) with"},{"line_number":4,"context_line":"    API version 1.29 for a node. Actual support for this feature"},{"line_number":5,"context_line":"    depends on a driver."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5a3905b3_e8547c55","line":5,"in_reply_to":"5a3905b3_a87c3473","updated":"2017-01-19 21:18:45.000000000","message":"+1 to small blurb about what this is useful for, i.e. \"can be used for hardware diagnostics\" or something","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"54617a5622872b3f269a7a1c616eff71d024b0bb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for the injection of Non-Masking Interrupts (NMI) with"},{"line_number":4,"context_line":"    API version 1.29 for a node. Actual support for this feature"},{"line_number":5,"context_line":"    depends on a driver."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5a3905b3_ce609f38","line":5,"in_reply_to":"5a3905b3_e8547c55","updated":"2017-01-20 02:16:14.000000000","message":"I\u0027ll fix that.","commit_id":"e9aee1cdfa55f4ab089fae59d0c6688ef47e7b4d"}]}
