)]}'
{"doc/source/dev/notifications.rst":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"d5aec4520022762620171464b97d72a5075e4524","unresolved":false,"context_lines":[{"line_number":324,"context_line":"  level INFO."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":327,"context_line":"  successfully changes provision state without transition (example is AVAILABLE"},{"line_number":328,"context_line":"  to MANAGEABLE). It has notification level INFO."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":18,"id":"fa6399be_42f734f5","line":327,"range":{"start_line":327,"start_character":39,"end_line":327,"end_character":57},"updated":"2016-10-17 22:29:31.000000000","message":"I think this could be worded more clearly. Maybe something like \"instantly, without any intermediate tasks required\"?\n\nOr, maybe we could document stable and unstable states somewhere and link to that documentation. Basically I think the code in https://review.openstack.org/#/c/348437/18/ironic/conductor/task_manager.py is more understandable than what\u0027s here at the moment.","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"2e3e16535591fdf4dae88d90aca345237b75c6f6","unresolved":false,"context_lines":[{"line_number":324,"context_line":"  level INFO."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":327,"context_line":"  successfully changes provision state without transition (example is AVAILABLE"},{"line_number":328,"context_line":"  to MANAGEABLE). It has notification level INFO."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":18,"id":"fa6399be_90408f09","line":327,"range":{"start_line":327,"start_character":39,"end_line":327,"end_character":57},"in_reply_to":"fa6399be_22bb0777","updated":"2016-10-18 19:05:17.000000000","message":"From discussion with Vasyl in https://review.openstack.org/#/c/385459/, I think it\u0027s best to make the docs match what the code does (update docs to say stable state \u003d\u003d state that can be a \"target\"). I\u0027ll get around to this in the next week or so if we don\u0027t land it in that patch set.","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4e8b82e9e44c5c7a6e5f656c1db4681573d23303","unresolved":false,"context_lines":[{"line_number":324,"context_line":"  level INFO."},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":327,"context_line":"  successfully changes provision state without transition (example is AVAILABLE"},{"line_number":328,"context_line":"  to MANAGEABLE). It has notification level INFO."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":18,"id":"fa6399be_22bb0777","line":327,"range":{"start_line":327,"start_character":39,"end_line":327,"end_character":57},"in_reply_to":"fa6399be_42f734f5","updated":"2016-10-18 13:55:16.000000000","message":"1) Good point, done. 2) There is terminology difference about \"stable states\" between the FSM code and documentation, and some states which look \"stable\" by documentation are not documented. I\u0027m not sure about good solution about terminology.","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1712c4881092bb5b2921bd618412059e14e35d70","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":327,"context_line":"  successfully changes provision state instantly, without any intermediate"},{"line_number":328,"context_line":"  worker required (example is AVAILABLE"},{"line_number":329,"context_line":"  to MANAGEABLE). It has notification level INFO."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":19,"id":"fa6399be_214722bd","line":328,"range":{"start_line":328,"start_character":2,"end_line":328,"end_character":8},"updated":"2016-10-20 15:35:36.000000000","message":"nit: s/worker/work","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"751cf39087dba3b448bf5924550df49236e0447d","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":327,"context_line":"  successfully changes provision state instantly, without any intermediate"},{"line_number":328,"context_line":"  worker required (example is AVAILABLE"},{"line_number":329,"context_line":"  to MANAGEABLE). It has notification level INFO."},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6895a0_1ad83e53","line":328,"range":{"start_line":328,"start_character":2,"end_line":328,"end_character":8},"in_reply_to":"fa6399be_214722bd","updated":"2016-10-21 12:18:59.000000000","message":"Done","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1712c4881092bb5b2921bd618412059e14e35d70","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Here is an example payload for a notification with this event type. The"},{"line_number":336,"context_line":"\"previous_provision_state\" and \"previous_target_provision_state\" payload fields"},{"line_number":337,"context_line":"indicates node\u0027s provision states before state change, \"event\" is the FSM event"},{"line_number":338,"context_line":"that triggered the state change::"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"   {"}],"source_content_type":"text/x-rst","patch_set":19,"id":"fa6399be_211e42bb","line":337,"range":{"start_line":337,"start_character":0,"end_line":337,"end_character":16},"updated":"2016-10-20 15:35:36.000000000","message":"nit: s/indicates node\u0027s/indicate a node\u0027s","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"751cf39087dba3b448bf5924550df49236e0447d","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Here is an example payload for a notification with this event type. The"},{"line_number":336,"context_line":"\"previous_provision_state\" and \"previous_target_provision_state\" payload fields"},{"line_number":337,"context_line":"indicates node\u0027s provision states before state change, \"event\" is the FSM event"},{"line_number":338,"context_line":"that triggered the state change::"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"   {"}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6895a0_9ae44e0e","line":337,"range":{"start_line":337,"start_character":0,"end_line":337,"end_character":16},"in_reply_to":"fa6399be_211e42bb","updated":"2016-10-21 12:18:59.000000000","message":"Done","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"189b6334c4313035a5def69a39b395bd4179054a","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"* ``baremetal.node.provision_set.start`` is emitted by the ironic-conductor"},{"line_number":320,"context_line":"  service when it begins a provision state transition. It has notification"},{"line_number":321,"context_line":"  level INFO."},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"* ``baremetal.node.provision_set.end`` is emitted when ironic-conductor"},{"line_number":324,"context_line":"  successfully completes a provision state transition. It has notification"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9a629dbe_856b4ab6","line":321,"updated":"2016-11-11 19:44:04.000000000","message":"nit - it has INFO notification level, same for other bullet points.","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"189b6334c4313035a5def69a39b395bd4179054a","unresolved":false,"context_lines":[{"line_number":325,"context_line":"  level INFO."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":328,"context_line":"  successfully changes provision state instantly, without any intermediate"},{"line_number":329,"context_line":"  work required (example is AVAILABLE to MANAGEABLE). It has notification level"},{"line_number":330,"context_line":"  INFO."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":22,"id":"9a629dbe_657e366b","line":329,"range":{"start_line":328,"start_character":39,"end_line":329,"end_character":15},"updated":"2016-11-11 19:44:04.000000000","message":"instead of this I\u0027d just say \"synchronously\". Oh, I see Mario\u0027s suggestions on previous patches. Still, I don\u0027t really like the word \"instantly\" :)","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a4402e33339ef3e1b70fdff4059f609351c7fce","unresolved":false,"context_lines":[{"line_number":325,"context_line":"  level INFO."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"* ``baremetal.node.provision_set.success`` is emitted when ironic-conductor"},{"line_number":328,"context_line":"  successfully changes provision state instantly, without any intermediate"},{"line_number":329,"context_line":"  work required (example is AVAILABLE to MANAGEABLE). It has notification level"},{"line_number":330,"context_line":"  INFO."},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"* ``baremetal.node.provision_set.error`` is emitted by ironic-conductor when it"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_9a87f10e","line":329,"range":{"start_line":328,"start_character":39,"end_line":329,"end_character":15},"in_reply_to":"9a629dbe_657e366b","updated":"2016-11-15 12:23:03.000000000","message":"\"synchronously\" is not correct here. We do \"start\" states change also synchronously.","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Here is an example payload for a notification with this event type. The"},{"line_number":337,"context_line":"\"previous_provision_state\" and \"previous_target_provision_state\" payload fields"},{"line_number":338,"context_line":"indicate a node\u0027s provision states before state change, \"event\" is the FSM"},{"line_number":339,"context_line":"event that triggered the state change::"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   {"}],"source_content_type":"text/x-rst","patch_set":23,"id":"7a77a97e_f0e35603","line":338,"updated":"2016-11-16 19:20:07.000000000","message":"nit, might want to s/FSM/FSM (finite state machine)/","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":"Here is an example payload for a notification with this event type. The"},{"line_number":337,"context_line":"\"previous_provision_state\" and \"previous_target_provision_state\" payload fields"},{"line_number":338,"context_line":"indicate a node\u0027s provision states before state change, \"event\" is the FSM"},{"line_number":339,"context_line":"event that triggered the state change::"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"   {"}],"source_content_type":"text/x-rst","patch_set":23,"id":"7a77a97e_717641a5","line":338,"in_reply_to":"7a77a97e_f0e35603","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"}],"ironic/common/states.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"189b6334c4313035a5def69a39b395bd4179054a","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"UNSTABLE_STATES \u003d (DEPLOYING, DEPLOYWAIT, CLEANING, CLEANWAIT, VERIFYING,"},{"line_number":199,"context_line":"                   DELETING, INSPECTING, ADOPTING)"},{"line_number":200,"context_line":"\"\"\"States that can be changed without external request.\"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"##############"},{"line_number":203,"context_line":"# Power states"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a629dbe_85fc2ab9","line":200,"range":{"start_line":200,"start_character":19,"end_line":200,"end_character":29},"updated":"2016-11-11 19:44:04.000000000","message":"to be more in line with stable states, I\u0027d suggest \"transition\" instead.","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a4402e33339ef3e1b70fdff4059f609351c7fce","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"UNSTABLE_STATES \u003d (DEPLOYING, DEPLOYWAIT, CLEANING, CLEANWAIT, VERIFYING,"},{"line_number":199,"context_line":"                   DELETING, INSPECTING, ADOPTING)"},{"line_number":200,"context_line":"\"\"\"States that can be changed without external request.\"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"##############"},{"line_number":203,"context_line":"# Power states"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_e9ac9def","line":200,"range":{"start_line":200,"start_character":19,"end_line":200,"end_character":29},"in_reply_to":"9a629dbe_85fc2ab9","updated":"2016-11-15 12:23:03.000000000","message":"Comment l196 about stable states is not correct https://review.openstack.org/#/c/385459/2/ironic/common/states.py","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"}],"ironic/conductor/notification_utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"d5aec4520022762620171464b97d72a5075e4524","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    )"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def mask_secrets(payload):"},{"line_number":128,"context_line":"    \"\"\"Remove secrets from payload object.\"\"\""},{"line_number":129,"context_line":"    mask \u003d \u0027******\u0027"},{"line_number":130,"context_line":"    instance_info \u003d payload.instance_info"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_425c94ed","line":127,"updated":"2016-10-17 22:29:31.000000000","message":"I\u0027d check to make sure this masks everything we want to mask here, but you may just be able to use oslo strutils.mask_dict_password, like we do for the API: https://github.com/openstack/ironic/blob/33c62a1e368ed358514b015b3778415580b895a2/ironic/api/controllers/v1/node.py#L827","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4e8b82e9e44c5c7a6e5f656c1db4681573d23303","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    )"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"def mask_secrets(payload):"},{"line_number":128,"context_line":"    \"\"\"Remove secrets from payload object.\"\"\""},{"line_number":129,"context_line":"    mask \u003d \u0027******\u0027"},{"line_number":130,"context_line":"    instance_info \u003d payload.instance_info"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_0713725d","line":127,"in_reply_to":"fa6399be_425c94ed","updated":"2016-10-18 13:55:16.000000000","message":"I plan to do this later but it works for \"configdrive\", thanks.","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"eccc7571dc8a64586483ab20f2149f3686b481d5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _emit_conductor_node_notification(task, notification_method,"}],"source_content_type":"text/x-python","patch_set":20,"id":"da6895a0_fec45941","line":38,"updated":"2016-10-21 14:37:18.000000000","message":"I think you can just do mask_dict_password here as well. That\u0027s what the API does to mask driver_info secrets:\n\nhttps://github.com/openstack/ironic/blob/c101fce33ab36605c6826e4ac354d27f0930cb8c/ironic/api/controllers/v1/node.py#L827","commit_id":"0912604236fa686cac76fc09afbb6c771806bdf4"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"dc11d533f0a7eb1418358b3bfc71741236071839","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _emit_conductor_node_notification(task, notification_method,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_4243df12","line":38,"in_reply_to":"da6895a0_2f94c6e0","updated":"2016-11-03 21:11:46.000000000","message":"Good to know. Oslo docs aren\u0027t very clear on what is/isn\u0027t masked. Maybe one way to do this with minimal effort is to first use mask_dict_password, then also manually mask things like image_url that aren\u0027t covered by oslo, after masking everything else automatically.","commit_id":"0912604236fa686cac76fc09afbb6c771806bdf4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c47f42bb5c15ae9ad8a5feaa801de577467140c1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _emit_conductor_node_notification(task, notification_method,"}],"source_content_type":"text/x-python","patch_set":20,"id":"da6895a0_2f94c6e0","line":38,"in_reply_to":"da6895a0_fec45941","updated":"2016-10-22 16:07:17.000000000","message":"mask_dict_password does not work with \"image_url\". Temp url is a kind of secret. There is a difference between API and notifications. API access require proper rights, notifications are intended for external service(s). Searchlight for example writes all incoming data to the log in debug mode. Usually access to logs is less strict than to admin level API.","commit_id":"0912604236fa686cac76fc09afbb6c771806bdf4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"189b6334c4313035a5def69a39b395bd4179054a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Remove secrets from payload object.\"\"\""},{"line_number":31,"context_line":"    mask \u003d \u0027******\u0027"},{"line_number":32,"context_line":"    if hasattr(payload, \u0027instance_info\u0027):"},{"line_number":33,"context_line":"        payload.instance_info \u003d strutils.mask_dict_password("},{"line_number":34,"context_line":"            payload.instance_info, mask)"},{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a629dbe_4598526a","line":33,"updated":"2016-11-11 19:44:04.000000000","message":"Hm, is there any key with name \".*password.*\" in instance_info? Doesn\u0027t hurt adding this, but still, not really meaningful with any of in-tree drivers.","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a4402e33339ef3e1b70fdff4059f609351c7fce","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Remove secrets from payload object.\"\"\""},{"line_number":31,"context_line":"    mask \u003d \u0027******\u0027"},{"line_number":32,"context_line":"    if hasattr(payload, \u0027instance_info\u0027):"},{"line_number":33,"context_line":"        payload.instance_info \u003d strutils.mask_dict_password("},{"line_number":34,"context_line":"            payload.instance_info, mask)"},{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_3a797dfd","line":33,"in_reply_to":"9a629dbe_4598526a","updated":"2016-11-15 12:23:03.000000000","message":"This function intended only for notifications. All keys like you mentioned should be masked.","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            payload.instance_info, mask)"},{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_5096caf0","line":37,"updated":"2016-11-16 19:20:07.000000000","message":"Oh, this is interesting; I don\u0027t think we mask it at the API level.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            payload.instance_info, mask)"},{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_31e68944","line":37,"in_reply_to":"7a77a97e_5096caf0","updated":"2016-11-17 13:59:11.000000000","message":"We do mask any \u0027image_url\u0027 values in the API. I\u0027m not sure that solution here is very good.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ee4b9e695d146a7df8024e444121a8841fa53a9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            payload.instance_info, mask)"},{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_e75a81f1","line":37,"updated":"2016-11-17 17:58:09.000000000","message":"I think that if we mask the entire instance_info[image_url] [1], we should do a similar thing here.\n\nIn a separate patch, if we can, we should consolidate the \"secret\" code into one place so that wherever in ironic we have to remove secrets, it\u0027ll be consistent.\n\n[1] https://github.com/openstack/ironic/blob/1f616540194bd3ae675b4fc5afe1b7c40b3f47ac/ironic/api/controllers/v1/node.py#L850","commit_id":"0765f2c409de5491317c9ac5b1f7a349d51b5d3b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5c623035ca0c1a549ef420ef89ff563a3b3a5aa4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            payload.instance_info, mask)"},{"line_number":35,"context_line":"        if (\u0027image_url\u0027 in payload.instance_info and"},{"line_number":36,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":37,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":38,"context_line":"    # TODO(yuriyz): add \"driver_info\" support"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_38c47e3e","line":37,"in_reply_to":"7a77a97e_e75a81f1","updated":"2016-11-18 10:29:16.000000000","message":"Done","commit_id":"0765f2c409de5491317c9ac5b1f7a349d51b5d3b"}],"ironic/conductor/provision_notify.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14e6b7a0fc209f57c1ac2b5f1f4e0936812585f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# coding\u003dutf-8"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_dc5dcded","line":1,"updated":"2016-09-20 11:58:42.000000000","message":"is this needed?","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14e6b7a0fc209f57c1ac2b5f1f4e0936812585f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            level\u003dlevel,"},{"line_number":61,"context_line":"            payload\u003dpayload).emit(context)"},{"line_number":62,"context_line":"    except Exception:"},{"line_number":63,"context_line":"        LOG.exception(_LE(\"Failed to send provision state notification.\"))"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_9cbee5fd","line":63,"updated":"2016-09-20 11:58:42.000000000","message":"This exception seems to be not covered by unittests.","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7013eec9499be2e2f6dbbdaf92e01921911e11d0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            level\u003dlevel,"},{"line_number":61,"context_line":"            payload\u003dpayload).emit(context)"},{"line_number":62,"context_line":"    except Exception:"},{"line_number":63,"context_line":"        LOG.exception(_LE(\"Failed to send provision state notification.\"))"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_c4bc04de","line":63,"in_reply_to":"7a8ec9b2_9cbee5fd","updated":"2016-09-20 15:05:27.000000000","message":"Will do in the next patchset.","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"}],"ironic/conductor/task_manager.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"547125358786dbbebe00544a0c55181327d6855d","unresolved":false,"context_lines":[{"line_number":458,"context_line":"            self._notify_provision_state_change()"},{"line_number":459,"context_line":"        else:"},{"line_number":460,"context_line":"            # save if resources will be released before notification at exit"},{"line_number":461,"context_line":"            self._node \u003d copy.deepcopy(self.node)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def __enter__(self):"},{"line_number":464,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3cb85ee5","line":461,"updated":"2016-07-28 18:30:33.000000000","message":"Copy is not needed here.","commit_id":"495168f7b9b7507b19f917ab6deb08c94a549937"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14e6b7a0fc209f57c1ac2b5f1f4e0936812585f","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":491,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":492,"context_line":"                # thread finishes."},{"line_number":493,"context_line":"                self._notify_provision_state_change()"},{"line_number":494,"context_line":"                return"},{"line_number":495,"context_line":"            except Exception as e:"},{"line_number":496,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_fc84495e","line":493,"updated":"2016-09-20 11:58:42.000000000","message":"Why under try: except? _notify_provision_state_change doesn\u0027t raise any exception.","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7013eec9499be2e2f6dbbdaf92e01921911e11d0","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":491,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":492,"context_line":"                # thread finishes."},{"line_number":493,"context_line":"                self._notify_provision_state_change()"},{"line_number":494,"context_line":"                return"},{"line_number":495,"context_line":"            except Exception as e:"},{"line_number":496,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_0486ecda","line":493,"in_reply_to":"7a8ec9b2_fc84495e","updated":"2016-09-20 15:05:27.000000000","message":"We should do this before return l494.","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"d5aec4520022762620171464b97d72a5075e4524","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":489,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":490,"context_line":"                # thread finishes."},{"line_number":491,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":492,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":493,"context_line":"                # Per-node locks should be added in this case."},{"line_number":494,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_979270f5","line":491,"updated":"2016-10-17 22:29:31.000000000","message":"There\u0027s no race condition with current eventlet behavior, right? What about the behavior would have to change to create a race condition?","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4e8b82e9e44c5c7a6e5f656c1db4681573d23303","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":489,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":490,"context_line":"                # thread finishes."},{"line_number":491,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":492,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":493,"context_line":"                # Per-node locks should be added in this case."},{"line_number":494,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6399be_a7780691","line":491,"in_reply_to":"fa6399be_979270f5","updated":"2016-10-18 13:55:16.000000000","message":"It\u0027s not critical for ironic, therefore maybe is good as is. Mentioned locks looks like https://review.openstack.org/#/c/383738/3/ironic/conductor/task_manager.py","commit_id":"51b731a44278de73aab379815235b083449b05d8"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1712c4881092bb5b2921bd618412059e14e35d70","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":509,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":510,"context_line":"                # Per-node locks should be added in this case."},{"line_number":511,"context_line":"                self._notify_provision_state_change()"},{"line_number":512,"context_line":"                return"},{"line_number":513,"context_line":"            except Exception as e:"},{"line_number":514,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa6399be_07e30ea5","line":511,"updated":"2016-10-20 15:35:36.000000000","message":"Maybe I\u0027m understanding the way this works incorrectly, but what happens here? https://github.com/openstack/ironic/blob/e05e0609641b7706682be1fc59bd89ef998755bb/ironic/conductor/manager.py#L760\n\nI see it as:\n\n1. process_event gets called, no callback so notification is sent on L477 for cleanwait-\u003ecleaning\n\n2. _spawn_method gets attached here:\nhttps://github.com/openstack/ironic/blob/e05e0609641b7706682be1fc59bd89ef998755bb/ironic/conductor/manager.py#L764\n\n3. with context closes out after that, so __exit__ gets called, no exception and we have a _spawn_method, so call ends up here\n\n3. thread spawned above to do next clean step\n\n4. notification is sent again here\n\nso we get duplicate notifications? or does something in eventlet prevent this?","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"3f5bf1ddb596974d28d2204c2c7a3c7041993cd5","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":509,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":510,"context_line":"                # Per-node locks should be added in this case."},{"line_number":511,"context_line":"                self._notify_provision_state_change()"},{"line_number":512,"context_line":"                return"},{"line_number":513,"context_line":"            except Exception as e:"},{"line_number":514,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":19,"id":"da6895a0_fe9ff95c","line":511,"in_reply_to":"da6895a0_baf112d0","updated":"2016-10-21 14:34:47.000000000","message":"Thanks, this should work now. Can you add a regression test to the ConductorManager tests for this case?","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"751cf39087dba3b448bf5924550df49236e0447d","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":509,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":510,"context_line":"                # Per-node locks should be added in this case."},{"line_number":511,"context_line":"                self._notify_provision_state_change()"},{"line_number":512,"context_line":"                return"},{"line_number":513,"context_line":"            except Exception as e:"},{"line_number":514,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":19,"id":"da6895a0_baf112d0","line":511,"in_reply_to":"fa6399be_07e30ea5","updated":"2016-10-21 12:18:59.000000000","message":"Thanks, fixed.","commit_id":"577183d07497632e1cffdf5456a92e54c4aa8034"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"dc11d533f0a7eb1418358b3bfc71741236071839","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":509,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":510,"context_line":"                # thread finishes."},{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":513,"context_line":"                # Per-node locks should be added in this case."},{"line_number":514,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_78488bcc","line":511,"updated":"2016-11-03 21:11:46.000000000","message":"One thing I\u0027m concerned about is this case:\n\n1. State transition occurs that has a callback attached. Node is saved with the new state on L471.\n2. There\u0027s no free conductor worker to execute the callback, or callback fails for some other reason on L502-508 (before the notification is emitted)\n\nThe node\u0027s now in a new state, but no notification about it was sent.\n\nIs this possible or am I misunderstanding this? Maybe a fix if this is possible is to move the notification above _spawn_method.","commit_id":"0912604236fa686cac76fc09afbb6c771806bdf4"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"cd88b77b0ab5925c25124d5df5da29a6e61c13ca","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":509,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":510,"context_line":"                # thread finishes."},{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":513,"context_line":"                # Per-node locks should be added in this case."},{"line_number":514,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_0dc017e0","line":511,"in_reply_to":"ba5da102_32dc6074","updated":"2016-11-04 14:39:46.000000000","message":"I see. So there is a potential small inconsistency between the node provision state and the notifications in between L471 and the rollback, and that\u0027s the race you\u0027re mentioning here?\n\nI\u0027ll respond to the message on the dev list shortly.\n\nI think this race is an acceptable risk, given the current primary use-case for provision state notifications (Searchlight), which doesn\u0027t involve checking the API for the node. Therefore it\u0027s very unlikely that the race will be triggered in a harmful way, especially since in most cases, there will be a lock on the node anyway and you won\u0027t be able to write to it until the state change is rolled back. In other words, this will be a read-only race.","commit_id":"0912604236fa686cac76fc09afbb6c771806bdf4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"77fb9fd31b0e591def3eb1c7b14d265472cd2450","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":509,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":510,"context_line":"                # thread finishes."},{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":513,"context_line":"                # Per-node locks should be added in this case."},{"line_number":514,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba5da102_32dc6074","line":511,"in_reply_to":"ba5da102_78488bcc","updated":"2016-11-04 09:20:20.000000000","message":"We nave state \"rollback\" mechanism https://github.com/openstack/ironic/blob/master/ironic/conductor/utils.py#L223-L228 executed as in error hook l521 Please read my email to openstack-dev http://lists.openstack.org/pipermail/openstack-dev/2016-October/106256.html","commit_id":"0912604236fa686cac76fc09afbb6c771806bdf4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"189b6334c4313035a5def69a39b395bd4179054a","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                        pass"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _notify_provision_state_change(self):"},{"line_number":372,"context_line":"        \"\"\"Emit notification about change node provision state.\"\"\""},{"line_number":373,"context_line":"        if self._event is None:"},{"line_number":374,"context_line":"            return"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a629dbe_e814d6a0","line":372,"range":{"start_line":372,"start_character":35,"end_line":372,"end_character":46},"updated":"2016-11-11 19:44:04.000000000","message":"....change of the node....","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a4402e33339ef3e1b70fdff4059f609351c7fce","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                        pass"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _notify_provision_state_change(self):"},{"line_number":372,"context_line":"        \"\"\"Emit notification about change node provision state.\"\"\""},{"line_number":373,"context_line":"        if self._event is None:"},{"line_number":374,"context_line":"            return"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_89ca49a0","line":372,"range":{"start_line":372,"start_character":35,"end_line":372,"end_character":46},"in_reply_to":"9a629dbe_e814d6a0","updated":"2016-11-15 12:23:03.000000000","message":"Done","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"189b6334c4313035a5def69a39b395bd4179054a","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":509,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":510,"context_line":"                # thread finishes."},{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":513,"context_line":"                # Per-node locks should be added in this case."},{"line_number":514,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a629dbe_a8057e14","line":511,"updated":"2016-11-11 19:44:04.000000000","message":"Just to fully understand this, is it the race because of which you added L483?","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"2a4402e33339ef3e1b70fdff4059f609351c7fce","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                fut.add_done_callback(self._thread_release_resources)"},{"line_number":509,"context_line":"                # Don\u0027t unlock! The unlock will occur when the"},{"line_number":510,"context_line":"                # thread finishes."},{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback can be here if eventlet changes behavior."},{"line_number":513,"context_line":"                # Per-node locks should be added in this case."},{"line_number":514,"context_line":"                self._notify_provision_state_change()"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_e96f3d90","line":511,"in_reply_to":"9a629dbe_a8057e14","updated":"2016-11-15 12:23:03.000000000","message":"Comment updated.","commit_id":"4e8ac72d540cc205e16ddbef1d20f1a4634fb41b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        if callback is None:"},{"line_number":480,"context_line":"            self._notify_provision_state_change()"},{"line_number":481,"context_line":"        else:"},{"line_number":482,"context_line":"            # save if resources will be released before notification at exit"},{"line_number":483,"context_line":"            self._saved_node \u003d self.node"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def __enter__(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_161fea5f","line":482,"updated":"2016-11-16 19:20:07.000000000","message":"maybe \u0027save the node, in case it is released before a notification is emitted at __exit__().\u0027","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        if callback is None:"},{"line_number":480,"context_line":"            self._notify_provision_state_change()"},{"line_number":481,"context_line":"        else:"},{"line_number":482,"context_line":"            # save if resources will be released before notification at exit"},{"line_number":483,"context_line":"            self._saved_node \u003d self.node"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def __enter__(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_d129d538","line":482,"in_reply_to":"7a77a97e_161fea5f","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback is possible here if eventlet changes behavior (if"},{"line_number":513,"context_line":"                # execution of new thread finished quickly with event"},{"line_number":514,"context_line":"                # processing \"end\" notification can be emitted before \"start\")."},{"line_number":515,"context_line":"                # Per-node locks should be added in this case."},{"line_number":516,"context_line":"                self._notify_provision_state_change()"},{"line_number":517,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_b3ce48b2","line":514,"updated":"2016-11-16 19:20:07.000000000","message":"maybe instead of the \u0027(if ...)\u0027 and assuming I understand this,\n\nE.g., if the execution of the new thread (that handles the event processing) finishes before we get here, that new thread may emit the \"end\" notification before we emit the following \"start\" notification.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":511,"context_line":"                # NOTE(yuriyz): A race condition with process_event()"},{"line_number":512,"context_line":"                # in callback is possible here if eventlet changes behavior (if"},{"line_number":513,"context_line":"                # execution of new thread finished quickly with event"},{"line_number":514,"context_line":"                # processing \"end\" notification can be emitted before \"start\")."},{"line_number":515,"context_line":"                # Per-node locks should be added in this case."},{"line_number":516,"context_line":"                self._notify_provision_state_change()"},{"line_number":517,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_31f049c9","line":514,"in_reply_to":"7a77a97e_b3ce48b2","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ee4b9e695d146a7df8024e444121a8841fa53a9","unresolved":false,"context_lines":[{"line_number":514,"context_line":"                # E.g., if the execution of the new thread (that handles the"},{"line_number":515,"context_line":"                # event processing) finishes before we get here, that new"},{"line_number":516,"context_line":"                # thread may emit the \"end\" notification before we emit the"},{"line_number":517,"context_line":"                # following \"start\" notification. Per-node locks should be"},{"line_number":518,"context_line":"                # added in this case."},{"line_number":519,"context_line":"                self._notify_provision_state_change()"},{"line_number":520,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_a73249a5","line":517,"updated":"2016-11-17 17:58:09.000000000","message":"the comment about per-node locks -- maybe that ought to be a TODO ?","commit_id":"0765f2c409de5491317c9ac5b1f7a349d51b5d3b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5c623035ca0c1a549ef420ef89ff563a3b3a5aa4","unresolved":false,"context_lines":[{"line_number":514,"context_line":"                # E.g., if the execution of the new thread (that handles the"},{"line_number":515,"context_line":"                # event processing) finishes before we get here, that new"},{"line_number":516,"context_line":"                # thread may emit the \"end\" notification before we emit the"},{"line_number":517,"context_line":"                # following \"start\" notification. Per-node locks should be"},{"line_number":518,"context_line":"                # added in this case."},{"line_number":519,"context_line":"                self._notify_provision_state_change()"},{"line_number":520,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a77a97e_f898467a","line":517,"in_reply_to":"7a77a97e_a73249a5","updated":"2016-11-18 10:29:16.000000000","message":"I think better to remove this sentence, because there are different ways to fix it.","commit_id":"0765f2c409de5491317c9ac5b1f7a349d51b5d3b"}],"ironic/tests/unit/conductor/test_notification_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        payload \u003d init_kwargs[\u0027payload\u0027]"},{"line_number":208,"context_line":"        self.assertEqual(\u0027******\u0027, payload.instance_info[\u0027configdrive\u0027])"},{"line_number":209,"context_line":"        self.assertEqual(\u0027******\u0027, payload.instance_info[\u0027image_url\u0027])"},{"line_number":210,"context_line":"        self.assertEqual(\u0027fake-value\u0027, payload.instance_info[\u0027some_value\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_d94cc544","line":210,"updated":"2016-11-16 19:20:07.000000000","message":"I\u0027d like to see tests that only test mask_secrets() so we could focus on testing just that method. To test the above, and a test for .instance_info[\u0027image_url\u0027] when it doesn\u0027t have a temp_url_sig. And then test for driver_info later.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        payload \u003d init_kwargs[\u0027payload\u0027]"},{"line_number":208,"context_line":"        self.assertEqual(\u0027******\u0027, payload.instance_info[\u0027configdrive\u0027])"},{"line_number":209,"context_line":"        self.assertEqual(\u0027******\u0027, payload.instance_info[\u0027image_url\u0027])"},{"line_number":210,"context_line":"        self.assertEqual(\u0027fake-value\u0027, payload.instance_info[\u0027some_value\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_d1eb9576","line":210,"in_reply_to":"7a77a97e_d94cc544","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"}],"ironic/tests/unit/conductor/test_task_manager.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14e6b7a0fc209f57c1ac2b5f1f4e0936812585f","unresolved":false,"context_lines":[{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        spawn_mock.assert_called_once_with(1, 2, foo\u003d\u0027bar\u0027, cat\u003d\u0027meow\u0027)"},{"line_number":480,"context_line":"        task_release_mock.assert_called_once_with()"},{"line_number":481,"context_line":"        self.assertFalse(notify_mock.called)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def test_spawn_after_link_fails("},{"line_number":484,"context_line":"            self, get_portgroups_mock, get_ports_mock, build_driver_mock,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_d9b5dfd0","line":481,"updated":"2016-09-20 11:58:42.000000000","message":"notify_mock.assert_not_called()","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7013eec9499be2e2f6dbbdaf92e01921911e11d0","unresolved":false,"context_lines":[{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        spawn_mock.assert_called_once_with(1, 2, foo\u003d\u0027bar\u0027, cat\u003d\u0027meow\u0027)"},{"line_number":480,"context_line":"        task_release_mock.assert_called_once_with()"},{"line_number":481,"context_line":"        self.assertFalse(notify_mock.called)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def test_spawn_after_link_fails("},{"line_number":484,"context_line":"            self, get_portgroups_mock, get_ports_mock, build_driver_mock,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_0470acdb","line":481,"in_reply_to":"7a8ec9b2_d9b5dfd0","updated":"2016-09-20 15:05:27.000000000","message":"Will do in the next patchset.","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14e6b7a0fc209f57c1ac2b5f1f4e0936812585f","unresolved":false,"context_lines":[{"line_number":795,"context_line":"        self.node.provision_state \u003d \u0027fake\u0027"},{"line_number":796,"context_line":"        self.task._prev_provision_state \u003d \u0027fake\u0027"},{"line_number":797,"context_line":"        self.task.notifier(self.task)"},{"line_number":798,"context_line":"        self.assertFalse(emit_mock.called)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    def test_notify_error_state(self, emit_mock):"},{"line_number":801,"context_line":"        self.node.provision_state \u003d states.DEPLOYFAIL"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_59d1cffa","line":798,"updated":"2016-09-20 11:58:42.000000000","message":"ditto about assert_not_called","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        self.assertFalse(task_release_mock.called)"},{"line_number":444,"context_line":"        notify_mock.assert_called_once_with(task)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def test_spawn_after_exception_while_yielded("},{"line_number":447,"context_line":"            self, get_portgroups_mock, get_ports_mock, build_driver_mock,"},{"line_number":448,"context_line":"            reserve_mock, release_mock, node_get_mock):"},{"line_number":449,"context_line":"        spawn_mock \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_391db9bd","line":446,"updated":"2016-11-16 19:20:07.000000000","message":"do we want to mock _notify_provision_state_changes? Otherwise, won\u0027t it get called?\n\nI\u0027m not that familiar with this class of tests; wondering if we should mock _notify_provision_state_changes for all of them, similar to the other mocks.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        self.assertFalse(task_release_mock.called)"},{"line_number":444,"context_line":"        notify_mock.assert_called_once_with(task)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def test_spawn_after_exception_while_yielded("},{"line_number":447,"context_line":"            self, get_portgroups_mock, get_ports_mock, build_driver_mock,"},{"line_number":448,"context_line":"            reserve_mock, release_mock, node_get_mock):"},{"line_number":449,"context_line":"        spawn_mock \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_b4db674e","line":446,"in_reply_to":"7a77a97e_391db9bd","updated":"2016-11-17 13:59:11.000000000","message":"It called in any of this cases. But notifications are disabled by default in the config, therefore we do only high-level data preparation, NotificationBase.emit() does nothing.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        emit_mock.assert_called_once_with(self.task,"},{"line_number":803,"context_line":"                                          fields.NotificationLevel.ERROR,"},{"line_number":804,"context_line":"                                          fields.NotificationStatus.ERROR,"},{"line_number":805,"context_line":"                                          \u0027fake\u0027, \u0027oldtarget\u0027, \u0027fail\u0027)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def test_notify_unstable_to_unstable(self, emit_mock):"},{"line_number":808,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_b93f09d5","line":805,"updated":"2016-11-16 19:20:07.000000000","message":"maybe assert that self.task._event \u003d None","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        emit_mock.assert_called_once_with(self.task,"},{"line_number":803,"context_line":"                                          fields.NotificationLevel.ERROR,"},{"line_number":804,"context_line":"                                          fields.NotificationStatus.ERROR,"},{"line_number":805,"context_line":"                                          \u0027fake\u0027, \u0027oldtarget\u0027, \u0027fail\u0027)"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    def test_notify_unstable_to_unstable(self, emit_mock):"},{"line_number":808,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_54c4d35d","line":805,"in_reply_to":"7a77a97e_b93f09d5","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        self.task.notifier(self.task)"},{"line_number":868,"context_line":"        self.task.notifier(self.task)"},{"line_number":869,"context_line":"        self.assertEqual(1, emit_mock.call_count)"},{"line_number":870,"context_line":"        self.assertIsNone(self.task._event)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_e4e39403","line":870,"updated":"2016-11-16 19:20:07.000000000","message":"you could do this after line 867 too.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        self.task.notifier(self.task)"},{"line_number":868,"context_line":"        self.task.notifier(self.task)"},{"line_number":869,"context_line":"        self.assertEqual(1, emit_mock.call_count)"},{"line_number":870,"context_line":"        self.assertIsNone(self.task._event)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a77a97e_747b8ff5","line":870,"in_reply_to":"7a77a97e_e4e39403","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"}],"releasenotes/notes/provision-state-notifications-33c44841a18080c3.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b14e6b7a0fc209f57c1ac2b5f1f4e0936812585f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add versioned notifications about node provision"},{"line_number":4,"context_line":"    state changes, detail in the specification"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/347242/"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7a8ec9b2_39aec398","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":44},"updated":"2016-09-20 11:58:42.000000000","message":"This patch will be merged when specification is merged, so I think we can add here a link to openstack.org","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7013eec9499be2e2f6dbbdaf92e01921911e11d0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add versioned notifications about node provision"},{"line_number":4,"context_line":"    state changes, detail in the specification"},{"line_number":5,"context_line":"    https://review.openstack.org/#/c/347242/"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7a8ec9b2_c7016606","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":44},"in_reply_to":"7a8ec9b2_39aec398","updated":"2016-09-20 15:05:27.000000000","message":"I change this link when after merge.","commit_id":"be06dde642ea7fde26d94468fb2c1368b33bb88c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for node\u0027s provision state changes, event types are"},{"line_number":4,"context_line":"    \"baremetal.node.provision_set.{start, end, success, error}\""},{"line_number":5,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_763bbe9c","line":3,"updated":"2016-11-16 19:20:07.000000000","message":"s/Add/Adds/","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for node\u0027s provision state changes, event types are"},{"line_number":4,"context_line":"    \"baremetal.node.provision_set.{start, end, success, error}\""},{"line_number":5,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_d4d463be","line":3,"in_reply_to":"7a77a97e_763bbe9c","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for node\u0027s provision state changes, event types are"},{"line_number":4,"context_line":"    \"baremetal.node.provision_set.{start, end, success, error}\""},{"line_number":5,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_b65c76ee","line":4,"updated":"2016-11-16 19:20:07.000000000","message":"nit: missing period at the end.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d65a666cc00ad31c192a06957631d4f91d527b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for node\u0027s provision state changes, event types are"},{"line_number":4,"context_line":"    \"baremetal.node.provision_set.{start, end, success, error}\""},{"line_number":5,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_166e0a95","line":5,"updated":"2016-11-16 19:20:07.000000000","message":"Do we mean http://docs.openstack.org/developer/ironic/dev/notifications.html? Maybe we should just link to that.","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"5edec103a3a8b4abd000633242e690999f41f180","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for node\u0027s provision state changes, event types are"},{"line_number":4,"context_line":"    \"baremetal.node.provision_set.{start, end, success, error}\""},{"line_number":5,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7a77a97e_d43e23d9","line":5,"in_reply_to":"7a77a97e_166e0a95","updated":"2016-11-17 13:59:11.000000000","message":"Done","commit_id":"81cac2a8691c8ce12068bd97609bab9bbb9f8d4d"}]}
