)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f6bedeb9ee79fdb1f81da0df8ae50010564a945e","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"            msg \u003d (_(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":1057,"context_line":"                   {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1058,"context_line":"            LOG.error(msg)"},{"line_number":1059,"context_line":"            node.last_error \u003d msg"},{"line_number":1060,"context_line":"            node.save()"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_c1013d6c","line":1059,"updated":"2016-09-21 02:32:23.000000000","message":"This API looks synchronous.\nIt would be better to inform a user of the error by raising an exception.","commit_id":"0f8957074417a104e5efb2588d4d02c51a3d1d48"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"02d1ab37682d9f9d7329232dda005875045edb30","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"            msg \u003d (_(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":1057,"context_line":"                   {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1058,"context_line":"            LOG.error(msg)"},{"line_number":1059,"context_line":"            node.last_error \u003d msg"},{"line_number":1060,"context_line":"            node.save()"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_4ff1c869","line":1059,"in_reply_to":"7a8ec9b2_c1013d6c","updated":"2016-09-21 08:37:15.000000000","message":"I\u0027ll fix that.","commit_id":"0f8957074417a104e5efb2588d4d02c51a3d1d48"},{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"59233c06a074eb736cd98c05a99fce942b378b0e","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                   {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1060,"context_line":"            LOG.error(msg)"},{"line_number":1061,"context_line":"            node.last_error \u003d msg"},{"line_number":1062,"context_line":"            node.save()"},{"line_number":1063,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_c6278c62","line":1062,"range":{"start_line":1062,"start_character":21,"end_line":1062,"end_character":23},"updated":"2016-10-25 10:14:21.000000000","message":"should the node be saved here? I read other methods in this file, they don\u0027t save nodes. Maybe save it in ironic.conductor.manager is better.","commit_id":"32e22d62668a168abb4988eef2d91b4520552060"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"eae427e41f4726eb36ad4379402ebdd4e1eafd4f","unresolved":false,"context_lines":[{"line_number":1059,"context_line":"                   {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1060,"context_line":"            LOG.error(msg)"},{"line_number":1061,"context_line":"            node.last_error \u003d msg"},{"line_number":1062,"context_line":"            node.save()"},{"line_number":1063,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_45c8c022","line":1062,"range":{"start_line":1062,"start_character":21,"end_line":1062,"end_character":23},"in_reply_to":"da6895a0_c6278c62","updated":"2016-10-26 05:14:49.000000000","message":"inject_nmi() has similar effect with set_boot_device().\nSo I\u0027ll update here such as L.943-951.","commit_id":"32e22d62668a168abb4988eef2d91b4520552060"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4994b2eb1c21a3a14b8c67b81a1dbf1ee51859fa","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"            _exec_ipmitool(driver_info, \"power diag\")"},{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.warning(_LW(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":1058,"context_line":"                        {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_46acbced","line":1057,"range":{"start_line":1057,"start_character":16,"end_line":1057,"end_character":23},"updated":"2016-11-07 10:37:03.000000000","message":"Feels more like an error for me instead of a warning. Cause the operation (injecting NMI) erroer and nothing happened, warning, IMHO, is more like something unexpected happened but the operation (partially) succeeded.","commit_id":"f3d5d15fe9284eb0779586584e474e5686040ebc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4172c2481acb0df69f47e94ee0c0a84f9c7e0012","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"            _exec_ipmitool(driver_info, \"power diag\")"},{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.warning(_LW(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":1058,"context_line":"                        {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_0d6ef794","line":1057,"range":{"start_line":1057,"start_character":77,"end_line":1057,"end_character":78},"updated":"2016-11-09 10:21:06.000000000","message":"s/%/,\nstring interpolation should be delayed, ie we shouldn\u0027t use %.\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages\n\n+1 to Lucas notice it should be ERROR.","commit_id":"f3d5d15fe9284eb0779586584e474e5686040ebc"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"40f3c40527e36d7bced8973daa1800af6fec6da1","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"            _exec_ipmitool(driver_info, \"power diag\")"},{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.warning(_LW(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":1058,"context_line":"                        {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_90b77c85","line":1057,"range":{"start_line":1057,"start_character":77,"end_line":1057,"end_character":78},"in_reply_to":"9a629dbe_0d6ef794","updated":"2016-11-09 10:34:29.000000000","message":"Indeed about interpolation. In fact, I\u0027ve just approved a patch that will enforce it: https://review.openstack.org/#/c/395102/","commit_id":"f3d5d15fe9284eb0779586584e474e5686040ebc"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"02f40cc9c555d6552f507a10a03260f16cff6e82","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"            _exec_ipmitool(driver_info, \"power diag\")"},{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.warning(_LW(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":1058,"context_line":"                        {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_e5d453be","line":1057,"range":{"start_line":1057,"start_character":77,"end_line":1057,"end_character":78},"in_reply_to":"9a629dbe_90b77c85","updated":"2016-11-10 04:29:29.000000000","message":"Lucus, Vasyl,\n\nThanks for the kind review.\n\nI\u0027ll fix the interpolation.\n\nIn terms of the log severity, I chose LOG.error originally, but I changed it to LOG.warning for the consistency with set_boot_device() considering the comment in [1].\n\nDo you have some reasoning which is superior to keeping the consistency?\n\n[1] https://review.openstack.org/#/c/348721/5..7/ironic/drivers/modules/ipmitool.py\n\nBest regards,\nNaohiro","commit_id":"f3d5d15fe9284eb0779586584e474e5686040ebc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f9bbbd7ca7ab68a0d93784c84a044cc7c2fc396f","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"            _exec_ipmitool(driver_info, \"power diag\")"},{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.warning(_LW(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":1058,"context_line":"                        {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_81da1d16","line":1057,"range":{"start_line":1057,"start_character":12,"end_line":1057,"end_character":23},"updated":"2017-01-09 14:51:57.000000000","message":"I\u0027m not sure why we use warning for failures in this file, but this one is definitely a failure. Please make it LOG.error(_LE(...))","commit_id":"50c3b25dc560585cd6e6d8b8029b2f8602c2b1d2"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"aef0696dda9bbfe16834f57c96ebb2aeda1f2c88","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"            _exec_ipmitool(driver_info, \"power diag\")"},{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.warning(_LW(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":1058,"context_line":"                        {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_02c52f5a","line":1057,"range":{"start_line":1057,"start_character":12,"end_line":1057,"end_character":23},"in_reply_to":"ba5201f7_81da1d16","updated":"2017-01-10 07:05:32.000000000","message":"I\u0027ll fix that.","commit_id":"50c3b25dc560585cd6e6d8b8029b2f8602c2b1d2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"af05b58f48386b73caab38284a046f1bc2428fd2","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.error(_LE(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":1058,"context_line":"                      {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a3c09a3_e5a50647","line":1058,"updated":"2017-01-17 17:19:13.000000000","message":"driver_info[\u0027uuid\u0027] does not seem to be a thing. I think you meant task.node.uuid","commit_id":"3f0151bc2f56f8ed573fcd53310aa4478f08b612"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ed3302b91ae16a7bfb7fb34951b66f1a39bfaa0d","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.error(_LE(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":1058,"context_line":"                      {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a3c09a3_bd6bef83","line":1058,"in_reply_to":"7a3c09a3_31dc9f72","updated":"2017-01-18 10:48:27.000000000","message":"Actually UUID is present in it: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L351\n\nBut yeah, task.node.uuid is more convenient anyway.","commit_id":"3f0151bc2f56f8ed573fcd53310aa4478f08b612"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e7d620ce260cd763c5331bfbc3520b543da26c82","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"        except (exception.PasswordFileFailedToCreate,"},{"line_number":1056,"context_line":"                processutils.ProcessExecutionError) as err:"},{"line_number":1057,"context_line":"            LOG.error(_LE(\u0027Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":1058,"context_line":"                      {\u0027node\u0027: driver_info[\u0027uuid\u0027], \u0027err\u0027: err})"},{"line_number":1059,"context_line":"            raise exception.IPMIFailure(cmd\u003d\"power diag\")"},{"line_number":1060,"context_line":""},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a3c09a3_31dc9f72","line":1058,"in_reply_to":"7a3c09a3_e5a50647","updated":"2017-01-18 00:55:12.000000000","message":"I\u0027ll fix that.","commit_id":"3f0151bc2f56f8ed573fcd53310aa4478f08b612"}],"ironic/tests/unit/drivers/modules/test_ipmitool.py":[{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"59233c06a074eb736cd98c05a99fce942b378b0e","unresolved":false,"context_lines":[{"line_number":1941,"context_line":""},{"line_number":1942,"context_line":"    @mock.patch.object(ipmi.LOG, \u0027error\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":1943,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":1944,"context_line":"    def test_management_interface_inject_nmi_ng(self, mock_exec, mock_log):"},{"line_number":1945,"context_line":"        mock_exec.side_effect \u003d exception.PasswordFileFailedToCreate(\u0027error\u0027)"},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_068b44c4","line":1944,"range":{"start_line":1944,"start_character":45,"end_line":1944,"end_character":47},"updated":"2016-10-25 10:14:21.000000000","message":"what does the ng mean?","commit_id":"32e22d62668a168abb4988eef2d91b4520552060"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"eae427e41f4726eb36ad4379402ebdd4e1eafd4f","unresolved":false,"context_lines":[{"line_number":1941,"context_line":""},{"line_number":1942,"context_line":"    @mock.patch.object(ipmi.LOG, \u0027error\u0027, spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":1943,"context_line":"    @mock.patch.object(ipmi, \u0027_exec_ipmitool\u0027, autospec\u003dTrue)"},{"line_number":1944,"context_line":"    def test_management_interface_inject_nmi_ng(self, mock_exec, mock_log):"},{"line_number":1945,"context_line":"        mock_exec.side_effect \u003d exception.PasswordFileFailedToCreate(\u0027error\u0027)"},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_658ce435","line":1944,"range":{"start_line":1944,"start_character":45,"end_line":1944,"end_character":47},"in_reply_to":"da6895a0_068b44c4","updated":"2016-10-26 05:14:49.000000000","message":"NG means No Good or Not Good.\n\nI\u0027ll change it to fail such as L.1923.","commit_id":"32e22d62668a168abb4988eef2d91b4520552060"}],"releasenotes/notes/ipmitool-inject-nmi-3dd1e778eba4e03e.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"058ba6347d09553c94f330bdc276f45387ca2501","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: Adds Inject NMI support to ipmitool management driver."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba5201f7_f9ab72d4","line":2,"range":{"start_line":2,"start_character":46,"end_line":2,"end_character":56},"updated":"2017-01-10 11:21:10.000000000","message":"s/management//g OR s/driver/interface/g","commit_id":"070e07c7c33168f4267f18c89f38ba926e785502"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"951a33a5e7b0b3423c27edf54d424eaa007338b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: Adds Inject NMI support to ipmitool management driver."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba5201f7_c4386240","line":2,"range":{"start_line":2,"start_character":46,"end_line":2,"end_character":56},"in_reply_to":"ba5201f7_f9ab72d4","updated":"2017-01-11 01:28:58.000000000","message":"I\u0027ll fix that.","commit_id":"070e07c7c33168f4267f18c89f38ba926e785502"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c8f36cef34595cc7de7e629694eb7d247218bdcc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: Adds support for the injection of Non-Masking Interrupts"},{"line_number":3,"context_line":"          (NMI) to ipmitool driver."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"5a3905b3_8c00d167","line":3,"range":{"start_line":2,"start_character":10,"end_line":3,"end_character":35},"updated":"2017-01-24 00:37:09.000000000","message":"I\u0027ll submit a follow up patch to make it list.","commit_id":"22a3a5a271d738530861615fd7586bb7d808a6d4"}]}
