)]}'
{"ironic/drivers/modules/irmc/management.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"cae8c2744a3ebbdcbdc1c048faac32727015fd95","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        node \u003d task.node"},{"line_number":244,"context_line":"        irmc_client \u003d irmc_common.get_irmc_client(node)"},{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            irmc_client(scci.POWER_RAISE_NMI)"},{"line_number":247,"context_line":"        except scci.SCCIClientError as err:"},{"line_number":248,"context_line":"            msg \u003d (_(\u0027iRMC Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":249,"context_line":"                   {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_718cae35","line":246,"updated":"2016-10-25 21:02:54.000000000","message":"I see that there is https://review.openstack.org/#/c/348721 implemented. \n\nMaybe it\u0027s a good idea, to do a similiar thing as in get_sensors data - set a field irmc_nmi_method in driver_info, and if set to ipmitool - call super, if \u0027scci\u0027 - irmc_client(scci.POWER_RAISE_NMI)?","commit_id":"e62b448006778e153cba6958212cbfd1a7cac67e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3654f8c633bc7c8a3c49389cfa93e59905f3ec66","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        node \u003d task.node"},{"line_number":244,"context_line":"        irmc_client \u003d irmc_common.get_irmc_client(node)"},{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            irmc_client(scci.POWER_RAISE_NMI)"},{"line_number":247,"context_line":"        except scci.SCCIClientError as err:"},{"line_number":248,"context_line":"            msg \u003d (_(\u0027iRMC Inject NMI failed for node %(node)s: %(err)s.\u0027) %"},{"line_number":249,"context_line":"                   {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_98fe3504","line":246,"in_reply_to":"da6895a0_718cae35","updated":"2016-10-26 06:00:51.000000000","message":"The current irmc get_sensors_data() is a tentative implementation due to the limitation of the current integration wat with Ceilometer [1].\n\n http://specs.openstack.org/openstack/ironic-specs/specs/backlog/support-per-driver-sensor-meters.html\n\nAnyway I\u0027ll align the implementation with ipmitool.","commit_id":"e62b448006778e153cba6958212cbfd1a7cac67e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"476020435f842f34ae908a6b67841ba58c68de93","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        try:"},{"line_number":252,"context_line":"            irmc_client(scci.POWER_RAISE_NMI)"},{"line_number":253,"context_line":"        except scci.SCCIClientError as err:"},{"line_number":254,"context_line":"            LOG.warning("},{"line_number":255,"context_line":"                _LW(\u0027iRMC Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":256,"context_line":"                {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"},{"line_number":257,"context_line":"            raise exception.IRMCOperationError("},{"line_number":258,"context_line":"                operation\u003dscci.POWER_RAISE_NMI, error\u003derr)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_f4d9b784","line":255,"range":{"start_line":254,"start_character":12,"end_line":255,"end_character":21},"updated":"2017-01-10 11:40:18.000000000","message":"LOG.error(_LE(\n\nTo be consistent with the IPMItool implementation.","commit_id":"5b71bbec92d7903229ecea82b7af1594c2501ea1"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a53ee27c58b7ba83ddfd87e8db4214bc7cca8878","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        try:"},{"line_number":252,"context_line":"            irmc_client(scci.POWER_RAISE_NMI)"},{"line_number":253,"context_line":"        except scci.SCCIClientError as err:"},{"line_number":254,"context_line":"            LOG.warning("},{"line_number":255,"context_line":"                _LW(\u0027iRMC Inject NMI failed for node %(node)s: %(err)s.\u0027),"},{"line_number":256,"context_line":"                {\u0027node\u0027: node.uuid, \u0027err\u0027: err})"},{"line_number":257,"context_line":"            raise exception.IRMCOperationError("},{"line_number":258,"context_line":"                operation\u003dscci.POWER_RAISE_NMI, error\u003derr)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_2777703b","line":255,"range":{"start_line":254,"start_character":12,"end_line":255,"end_character":21},"in_reply_to":"ba5201f7_f4d9b784","updated":"2017-01-11 02:03:05.000000000","message":"I\u0027ll fix that.","commit_id":"5b71bbec92d7903229ecea82b7af1594c2501ea1"}],"ironic/tests/unit/drivers/modules/irmc/test_management.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f0a50728c82fb55a30fdff54725bb6264e0ee846","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        irmc_management.scci.SCCIClientError \u003d Exception"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":390,"context_line":"            self.assertRaises(irmc_management.scci.SCCIClientError,"},{"line_number":391,"context_line":"                              self.driver.management.inject_nmi,"},{"line_number":392,"context_line":"                              task)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6895a0_318dd67b","line":390,"updated":"2016-10-25 20:47:22.000000000","message":"Shouldn\u0027t IRMCOperationError  be asserted here (that\u0027s what inject_nmi raises)?","commit_id":"e62b448006778e153cba6958212cbfd1a7cac67e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3654f8c633bc7c8a3c49389cfa93e59905f3ec66","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        irmc_management.scci.SCCIClientError \u003d Exception"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":390,"context_line":"            self.assertRaises(irmc_management.scci.SCCIClientError,"},{"line_number":391,"context_line":"                              self.driver.management.inject_nmi,"},{"line_number":392,"context_line":"                              task)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_b8785991","line":390,"in_reply_to":"da6895a0_318dd67b","updated":"2016-10-26 06:00:51.000000000","message":"Yes, it should be.\nBut scci package is mocked in ironic/tests/unit/drivers/third_party_driver_mocks.py.\nSo we cannot instantiate it.\nOther vendor driver such as ilo also makes use of the same technique.","commit_id":"e62b448006778e153cba6958212cbfd1a7cac67e"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f602d6467e976a636c531f0bc17447072941861f","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        irmc_management.scci.SCCIClientError \u003d Exception"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":390,"context_line":"            self.assertRaises(irmc_management.scci.SCCIClientError,"},{"line_number":391,"context_line":"                              self.driver.management.inject_nmi,"},{"line_number":392,"context_line":"                              task)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_24825001","line":390,"updated":"2016-10-26 21:38:41.000000000","message":"I actually see IRMCOperationError exception being used in ironic/tests/unit/drivers/modules/irmc/test_power.py and test_boot.py\n\nUsing other exception type name is misleading even if they are the same due to mocking. Unit tests are considered a \"low-level documentation\", and I\u0027m still a fan of using IRMCOperationError","commit_id":"f9ce917c9c7b84344dd2ff644d3169e09b7183b0"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1992f6934e3d074bcc595bab70ff0b009b3cf497","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        irmc_management.scci.SCCIClientError \u003d Exception"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":390,"context_line":"            self.assertRaises(irmc_management.scci.SCCIClientError,"},{"line_number":391,"context_line":"                              self.driver.management.inject_nmi,"},{"line_number":392,"context_line":"                              task)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_d14eb1c0","line":390,"in_reply_to":"ba5da102_24825001","updated":"2016-10-27 02:12:52.000000000","message":"Joanna,\n\nOh, I\u0027m sorry, you are right! I just overlooked it. I\u0027ll fix that.\n\n -            self.assertRaises(irmc_management.scci.SCCIClientError,\n +            self.assertRaises(exception.IRMCOperationError,\n\nThanks.\nNaohiro","commit_id":"f9ce917c9c7b84344dd2ff644d3169e09b7183b0"}],"releasenotes/notes/irmc-inject-nmi-20b7824abad6beda.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"84c7918d7ae4fb19c308d1a4c820bf067234b6a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: Adds Inject NMI support to iRMC driver."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5a3905b3_b2942c43","line":2,"updated":"2017-01-23 12:34:12.000000000","message":"this should be a list, otherwise every letter renders as a separate item. like\n\nfeatures:\n  - Adds ....","commit_id":"b1949bb34615e0c240d154e68c6dc782a6311b8c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b50ecd6a9f74e3598fb9bc1281c4a78e8a9cfa8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features: Adds Inject NMI support to iRMC driver."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5a3905b3_2ca43db8","line":2,"in_reply_to":"5a3905b3_b2942c43","updated":"2017-01-24 00:32:01.000000000","message":"I\u0027ll fix that.","commit_id":"b1949bb34615e0c240d154e68c6dc782a6311b8c"}]}
