)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functional test is not enabled in Ironic. But many unit"},{"line_number":10,"context_line":"tests are over tested because they are not faking anything,"},{"line_number":11,"context_line":"but actually started a real pecan server to do the tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bug #1607679 aims to split them. This patch could be the"},{"line_number":14,"context_line":"first step of it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_63f76b8b","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":20},"updated":"2016-08-01 10:34:31.000000000","message":"Nit: start","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Functional test is not enabled in Ironic. But many unit"},{"line_number":10,"context_line":"tests are over tested because they are not faking anything,"},{"line_number":11,"context_line":"but actually started a real pecan server to do the tests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Bug #1607679 aims to split them. This patch could be the"},{"line_number":14,"context_line":"first step of it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_031be181","line":11,"range":{"start_line":11,"start_character":13,"end_line":11,"end_character":20},"in_reply_to":"bacf61ea_63f76b8b","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DbTestCase and BaseApiTest are base classes for functional"},{"line_number":17,"context_line":"tests. They should be put in functional dir. This patch"},{"line_number":18,"context_line":"copy them to functional dir instead of moving so that we"},{"line_number":19,"context_line":"can keep the current unit tests code untouched. And when"},{"line_number":20,"context_line":"we finish to grab all the functional tests out, we can"},{"line_number":21,"context_line":"simply remove the ones in unit dir."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_a344c3b6","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":4},"updated":"2016-08-01 10:34:31.000000000","message":"Nit: copies","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DbTestCase and BaseApiTest are base classes for functional"},{"line_number":17,"context_line":"tests. They should be put in functional dir. This patch"},{"line_number":18,"context_line":"copy them to functional dir instead of moving so that we"},{"line_number":19,"context_line":"can keep the current unit tests code untouched. And when"},{"line_number":20,"context_line":"we finish to grab all the functional tests out, we can"},{"line_number":21,"context_line":"simply remove the ones in unit dir."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_4311595c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":4},"in_reply_to":"bacf61ea_a344c3b6","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":21,"context_line":"simply remove the ones in unit dir."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch also enables functional tests in tox.ini. And"},{"line_number":24,"context_line":"the follow-up patches can easily do functional tests."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ib58635aa7f8518632053338f7d83e1bdb593bfc4"},{"line_number":27,"context_line":"Partial-bug: #1607679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_037b0ff6","line":24,"range":{"start_line":24,"start_character":33,"end_line":24,"end_character":35},"updated":"2016-08-01 10:34:31.000000000","message":"Nit: add more","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":21,"context_line":"simply remove the ones in unit dir."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch also enables functional tests in tox.ini. And"},{"line_number":24,"context_line":"the follow-up patches can easily do functional tests."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: Ib58635aa7f8518632053338f7d83e1bdb593bfc4"},{"line_number":27,"context_line":"Partial-bug: #1607679"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_2314254b","line":24,"range":{"start_line":24,"start_character":33,"end_line":24,"end_character":35},"in_reply_to":"bacf61ea_037b0ff6","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"}],"ironic/tests/functional/api/base.py":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    framework."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    SOURCE_DATA \u003d {\u0027test_source\u0027: {\u0027somekey\u0027: \u0027666\u0027}}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(BaseApiTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_630beb2a","line":44,"range":{"start_line":44,"start_character":47,"end_line":44,"end_character":50},"updated":"2016-08-01 10:34:31.000000000","message":"Nit: 42 sounds more polite ;)","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"0549db6be632b95b7242ebe8caf4b884afc9930a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    framework."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    SOURCE_DATA \u003d {\u0027test_source\u0027: {\u0027somekey\u0027: \u0027666\u0027}}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(BaseApiTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_95917f55","line":44,"range":{"start_line":44,"start_character":47,"end_line":44,"end_character":50},"in_reply_to":"bacf61ea_46404707","updated":"2016-08-05 13:23:31.000000000","message":"It\u0027s sort of a joke from Hitchhiker\u0027s guide to the galaxy novel by Douglas Adams. It\u0027s \"The answer to life, the universe, and everything\"[1] ;)\n\n[1] https://en.wikipedia.org/wiki/The_Hitchhiker%27s_Guide_to_the_Galaxy_(novel)","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    framework."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    SOURCE_DATA \u003d {\u0027test_source\u0027: {\u0027somekey\u0027: \u0027666\u0027}}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(BaseApiTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_46404707","line":44,"range":{"start_line":44,"start_character":47,"end_line":44,"end_character":50},"in_reply_to":"bacf61ea_630beb2a","updated":"2016-08-02 10:55:35.000000000","message":"Sure.  Just curious, does 42 mean anything here ?  I think I\u0027m a little lack of English speaking country culture. :)","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return pecan.testing.load_test_app(self.config)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _request_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":81,"context_line":"                      method\u003d\"post\", extra_environ\u003dNone, status\u003dNone,"},{"line_number":82,"context_line":"                      path_prefix\u003dPATH_PREFIX):"},{"line_number":83,"context_line":"        \"\"\"Sends simulated HTTP request to Pecan test app."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_378009f7","line":80,"range":{"start_line":80,"start_character":34,"end_line":80,"end_character":40},"updated":"2016-08-01 10:34:31.000000000","message":"rename params to data; should also have a default: params\u003dNone; ... if params is not None: ....","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return pecan.testing.load_test_app(self.config)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _request_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":81,"context_line":"                      method\u003d\"post\", extra_environ\u003dNone, status\u003dNone,"},{"line_number":82,"context_line":"                      path_prefix\u003dPATH_PREFIX):"},{"line_number":83,"context_line":"        \"\"\"Sends simulated HTTP request to Pecan test app."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1ccd2cb7","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":21},"updated":"2016-08-01 10:34:31.000000000","message":"what is the reason for this method not being public?","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        return pecan.testing.load_test_app(self.config)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _request_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":81,"context_line":"                      method\u003d\"post\", extra_environ\u003dNone, status\u003dNone,"},{"line_number":82,"context_line":"                      path_prefix\u003dPATH_PREFIX):"},{"line_number":83,"context_line":"        \"\"\"Sends simulated HTTP request to Pecan test app."}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ad991e7b","line":80,"range":{"start_line":80,"start_character":34,"end_line":80,"end_character":40},"in_reply_to":"bacf61ea_378009f7","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return pecan.testing.load_test_app(self.config)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _request_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":81,"context_line":"                      method\u003d\"post\", extra_environ\u003dNone, status\u003dNone,"},{"line_number":82,"context_line":"                      path_prefix\u003dPATH_PREFIX):"},{"line_number":83,"context_line":"        \"\"\"Sends simulated HTTP request to Pecan test app."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_57a2dd99","line":81,"range":{"start_line":81,"start_character":22,"end_line":81,"end_character":28},"updated":"2016-08-01 10:34:31.000000000","message":"I\u0027d make method a mandatory parameter without a default value (why should \"post\" be default?)","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return pecan.testing.load_test_app(self.config)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _request_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":81,"context_line":"                      method\u003d\"post\", extra_environ\u003dNone, status\u003dNone,"},{"line_number":82,"context_line":"                      path_prefix\u003dPATH_PREFIX):"},{"line_number":83,"context_line":"        \"\"\"Sends simulated HTTP request to Pecan test app."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ad5c7e19","line":81,"range":{"start_line":81,"start_character":22,"end_line":81,"end_character":28},"in_reply_to":"bacf61ea_57a2dd99","updated":"2016-08-02 10:55:35.000000000","message":"I have no idea why \"post\" is the default. I moved it to the decorator.","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            extra_environ\u003dextra_environ,"},{"line_number":105,"context_line":"            expect_errors\u003dexpect_errors"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":108,"context_line":"        return response"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def put_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a6e2112d","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":34},"updated":"2016-08-01 10:34:31.000000000","message":"I\u0027d LOG.debug instead","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            extra_environ\u003dextra_environ,"},{"line_number":105,"context_line":"            expect_errors\u003dexpect_errors"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":108,"context_line":"        return response"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def put_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_46d047c9","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":34},"in_reply_to":"bacf61ea_a6e2112d","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":108,"context_line":"        return response"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def put_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":111,"context_line":"                 extra_environ\u003dNone, status\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Sends simulated HTTP PUT request to Pecan test app."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1ca88cda","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":16},"updated":"2016-08-01 10:34:31.000000000","message":"these \u003cverb\u003e_json methods actually decorate the self._request_json method with a fixed parameter value. I\u0027d recommend converting those to a parameterized decorator call instead:\n  put_json \u003d request(\u0027put\u0027)(_request_json)\n  post_json \u003d request(\u0027post\u0027)(_request_json)\n   .\n   .\n   .","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":108,"context_line":"        return response"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def put_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":111,"context_line":"                 extra_environ\u003dNone, status\u003dNone):"},{"line_number":112,"context_line":"        \"\"\"Sends simulated HTTP PUT request to Pecan test app."},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f24f718f","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":16},"in_reply_to":"bacf61ea_1ca88cda","updated":"2016-08-02 10:55:35.000000000","message":"Good idea. :)","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                  headers\u003dheaders, extra_environ\u003dextra_environ,"},{"line_number":126,"context_line":"                                  status\u003dstatus, method\u003d\"put\")"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def post_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":129,"context_line":"                  extra_environ\u003dNone, status\u003dNone):"},{"line_number":130,"context_line":"        \"\"\"Sends simulated HTTP POST request to Pecan test app."},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5c8844c5","line":128,"range":{"start_line":128,"start_character":30,"end_line":128,"end_character":36},"updated":"2016-08-01 10:34:31.000000000","message":"I\u0027d rename to data.","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                  headers\u003dheaders, extra_environ\u003dextra_environ,"},{"line_number":126,"context_line":"                                  status\u003dstatus, method\u003d\"put\")"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def post_json(self, path, params, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":129,"context_line":"                  extra_environ\u003dNone, status\u003dNone):"},{"line_number":130,"context_line":"        \"\"\"Sends simulated HTTP POST request to Pecan test app."},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d257cd23","line":128,"range":{"start_line":128,"start_character":30,"end_line":128,"end_character":36},"in_reply_to":"bacf61ea_5c8844c5","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        :param path_prefix: prefix of the url path"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":178,"context_line":"        print(\u0027DELETE: %s\u0027 % (full_path))"},{"line_number":179,"context_line":"        response \u003d self.app.delete(str(full_path),"},{"line_number":180,"context_line":"                                   headers\u003dheaders,"},{"line_number":181,"context_line":"                                   status\u003dstatus,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_66cdb984","line":178,"range":{"start_line":178,"start_character":0,"end_line":178,"end_character":41},"updated":"2016-08-01 10:34:31.000000000","message":"ditto. please, LOG.debug instead.","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        :param path_prefix: prefix of the url path"},{"line_number":176,"context_line":"        \"\"\""},{"line_number":177,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":178,"context_line":"        print(\u0027DELETE: %s\u0027 % (full_path))"},{"line_number":179,"context_line":"        response \u003d self.app.delete(str(full_path),"},{"line_number":180,"context_line":"                                   headers\u003dheaders,"},{"line_number":181,"context_line":"                                   status\u003dstatus,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e665fb44","line":178,"range":{"start_line":178,"start_character":0,"end_line":178,"end_character":41},"in_reply_to":"bacf61ea_66cdb984","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                   status\u003dstatus,"},{"line_number":182,"context_line":"                                   extra_environ\u003dextra_environ,"},{"line_number":183,"context_line":"                                   expect_errors\u003dexpect_errors)"},{"line_number":184,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":185,"context_line":"        return response"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def get_json(self, path, expect_errors\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e6a7e9ba","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":34},"updated":"2016-08-01 10:34:31.000000000","message":"ditto.","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                   status\u003dstatus,"},{"line_number":182,"context_line":"                                   extra_environ\u003dextra_environ,"},{"line_number":183,"context_line":"                                   expect_errors\u003dexpect_errors)"},{"line_number":184,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":185,"context_line":"        return response"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def get_json(self, path, expect_errors\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4659678d","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":34},"in_reply_to":"bacf61ea_e6a7e9ba","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return response"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def get_json(self, path, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":188,"context_line":"                 extra_environ\u003dNone, q\u003d[], path_prefix\u003dPATH_PREFIX, **params):"},{"line_number":189,"context_line":"        \"\"\"Sends simulated HTTP GET request to Pecan test app."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param path: url path of target service"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7c41c8a8","line":188,"range":{"start_line":188,"start_character":38,"end_line":188,"end_character":42},"updated":"2016-08-01 10:34:31.000000000","message":"q\u003dNone; mutable in function defaults (most likely you don\u0027t want this)","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        return response"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def get_json(self, path, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":188,"context_line":"                 extra_environ\u003dNone, q\u003d[], path_prefix\u003dPATH_PREFIX, **params):"},{"line_number":189,"context_line":"        \"\"\"Sends simulated HTTP GET request to Pecan test app."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param path: url path of target service"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_523abde7","line":188,"range":{"start_line":188,"start_character":38,"end_line":188,"end_character":42},"in_reply_to":"bacf61ea_7c41c8a8","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        :param params: content for wsgi.input of request"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":203,"context_line":"        query_params \u003d {\u0027q.field\u0027: [],"},{"line_number":204,"context_line":"                        \u0027q.value\u0027: [],"},{"line_number":205,"context_line":"                        \u0027q.op\u0027: [],"},{"line_number":206,"context_line":"                        }"},{"line_number":207,"context_line":"        for query in q:"},{"line_number":208,"context_line":"            for name in [\u0027field\u0027, \u0027op\u0027, \u0027value\u0027]:"},{"line_number":209,"context_line":"                query_params[\u0027q.%s\u0027 % name].append(query.get(name, \u0027\u0027))"},{"line_number":210,"context_line":"        all_params \u003d {}"},{"line_number":211,"context_line":"        all_params.update(params)"},{"line_number":212,"context_line":"        if q:"},{"line_number":213,"context_line":"            all_params.update(query_params)"},{"line_number":214,"context_line":"        print(\u0027GET: %s %r\u0027 % (full_path, all_params))"},{"line_number":215,"context_line":"        response \u003d self.app.get(full_path,"},{"line_number":216,"context_line":"                                params\u003dall_params,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f7b791d5","line":213,"range":{"start_line":203,"start_character":4,"end_line":213,"end_character":43},"updated":"2016-08-01 10:34:31.000000000","message":"this again decorates the self._request_json method with augmented input. I\u0027d therefore make it a decorator:\n\n  get_json \u003d data_query(request(\u0027get\u0027)(_request_json))","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        :param params: content for wsgi.input of request"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":203,"context_line":"        query_params \u003d {\u0027q.field\u0027: [],"},{"line_number":204,"context_line":"                        \u0027q.value\u0027: [],"},{"line_number":205,"context_line":"                        \u0027q.op\u0027: [],"},{"line_number":206,"context_line":"                        }"},{"line_number":207,"context_line":"        for query in q:"},{"line_number":208,"context_line":"            for name in [\u0027field\u0027, \u0027op\u0027, \u0027value\u0027]:"},{"line_number":209,"context_line":"                query_params[\u0027q.%s\u0027 % name].append(query.get(name, \u0027\u0027))"},{"line_number":210,"context_line":"        all_params \u003d {}"},{"line_number":211,"context_line":"        all_params.update(params)"},{"line_number":212,"context_line":"        if q:"},{"line_number":213,"context_line":"            all_params.update(query_params)"},{"line_number":214,"context_line":"        print(\u0027GET: %s %r\u0027 % (full_path, all_params))"},{"line_number":215,"context_line":"        response \u003d self.app.get(full_path,"},{"line_number":216,"context_line":"                                params\u003dall_params,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_29707471","line":213,"range":{"start_line":203,"start_character":4,"end_line":213,"end_character":43},"in_reply_to":"bacf61ea_f7b791d5","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        all_params.update(params)"},{"line_number":212,"context_line":"        if q:"},{"line_number":213,"context_line":"            all_params.update(query_params)"},{"line_number":214,"context_line":"        print(\u0027GET: %s %r\u0027 % (full_path, all_params))"},{"line_number":215,"context_line":"        response \u003d self.app.get(full_path,"},{"line_number":216,"context_line":"                                params\u003dall_params,"},{"line_number":217,"context_line":"                                headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_77cc416a","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":53},"updated":"2016-08-01 10:34:31.000000000","message":"use LOG.debug","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        all_params.update(params)"},{"line_number":212,"context_line":"        if q:"},{"line_number":213,"context_line":"            all_params.update(query_params)"},{"line_number":214,"context_line":"        print(\u0027GET: %s %r\u0027 % (full_path, all_params))"},{"line_number":215,"context_line":"        response \u003d self.app.get(full_path,"},{"line_number":216,"context_line":"                                params\u003dall_params,"},{"line_number":217,"context_line":"                                headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_8657df56","line":214,"range":{"start_line":214,"start_character":0,"end_line":214,"end_character":53},"in_reply_to":"bacf61ea_77cc416a","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"168de941ddc291ee2973137020f60e6a923fe675","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                expect_errors\u003dexpect_errors)"},{"line_number":220,"context_line":"        if not expect_errors:"},{"line_number":221,"context_line":"            response \u003d response.json"},{"line_number":222,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":223,"context_line":"        return response"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def validate_link(self, link, bookmark\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_667bf928","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":34},"updated":"2016-08-01 10:34:31.000000000","message":"ditto.","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"33ab1f33ed27c29481595e6978fbf752cbaba184","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                expect_errors\u003dexpect_errors)"},{"line_number":220,"context_line":"        if not expect_errors:"},{"line_number":221,"context_line":"            response \u003d response.json"},{"line_number":222,"context_line":"        print(\u0027GOT:%s\u0027 % response)"},{"line_number":223,"context_line":"        return response"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def validate_link(self, link, bookmark\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a64823b4","line":222,"range":{"start_line":222,"start_character":0,"end_line":222,"end_character":34},"in_reply_to":"bacf61ea_667bf928","updated":"2016-08-02 10:55:35.000000000","message":"Done","commit_id":"5ac3e58cf5f24c32b4b72335e8f50b781fd6cfe6"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"33668d74985d1f441dcf27407d8c7810abfd78ad","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                      should be used rather than passing attribute in."},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        def wrapper(func):"},{"line_number":91,"context_line":"            def _request(self, path, data\u003d\u0027\u0027, expect_errors\u003dFalse,"},{"line_number":92,"context_line":"                         headers\u003dNone, extra_environ\u003dNone, status\u003dNone,"},{"line_number":93,"context_line":"                         path_prefix\u003dPATH_PREFIX):"},{"line_number":94,"context_line":"                \"\"\"Sends simulated HTTP request to Pecan test app."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"                :param path: url path of target service"},{"line_number":97,"context_line":"                :param data: content for wsgi.input of request"},{"line_number":98,"context_line":"                :param expect_errors: Boolean value; whether an error is"},{"line_number":99,"context_line":"                                      expected based on request"},{"line_number":100,"context_line":"                :param headers: a dictionary of headers to send along with"},{"line_number":101,"context_line":"                                the request"},{"line_number":102,"context_line":"                :param extra_environ: a dictionary of environ variables to"},{"line_number":103,"context_line":"                                      send along with the request"},{"line_number":104,"context_line":"                :param status: expected status code of response"},{"line_number":105,"context_line":"                :param path_prefix: prefix of the url path"},{"line_number":106,"context_line":"                \"\"\""},{"line_number":107,"context_line":"                full_path \u003d path_prefix + path"},{"line_number":108,"context_line":"                LOG.debug(\u0027%(method)s: %(full_path)s %(data)s\u0027,"},{"line_number":109,"context_line":"                          {\u0027method\u0027: method.upper(),"},{"line_number":110,"context_line":"                           \u0027full_path\u0027: full_path,"},{"line_number":111,"context_line":"                           \u0027data\u0027: data})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"                response \u003d getattr(self.app, \"%s\" % method)("},{"line_number":114,"context_line":"                    str(full_path),"},{"line_number":115,"context_line":"                    params\u003ddata,"},{"line_number":116,"context_line":"                    headers\u003dheaders,"},{"line_number":117,"context_line":"                    status\u003dstatus,"},{"line_number":118,"context_line":"                    extra_environ\u003dextra_environ,"},{"line_number":119,"context_line":"                    expect_errors\u003dexpect_errors"},{"line_number":120,"context_line":"                )"},{"line_number":121,"context_line":"                LOG.debug(\u0027GOT: %s\u0027, response)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"                return response"},{"line_number":124,"context_line":"            return _request"},{"line_number":125,"context_line":"        return wrapper"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a0cb12a3","line":123,"range":{"start_line":91,"start_character":0,"end_line":123,"end_character":31},"updated":"2016-08-05 14:40:12.000000000","message":"This this code is imo better moved out of the decorator to a separate generic request method so that e.g its doc string is publicly visible (currently this method is hidden)","commit_id":"dc44b0d5c54830c6850b15333b19b495b2ce0dc0"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"33668d74985d1f441dcf27407d8c7810abfd78ad","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return wrapper"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @request(\u0027put_json\u0027)"},{"line_number":128,"context_line":"    def put_json(self, path, data\u003dNone, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":129,"context_line":"                 extra_environ\u003dNone, status\u003dNone, path_prefix\u003dPATH_PREFIX):"},{"line_number":130,"context_line":"        \"\"\"Sends simulated HTTP PUT request to Pecan test app.\"\"\""},{"line_number":131,"context_line":"        pass"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_60ee3a23","line":129,"range":{"start_line":128,"start_character":17,"end_line":129,"end_character":73},"updated":"2016-08-05 14:40:12.000000000","message":"repeating of these args/kwargs can be prevented, if there\u0027s a generic request method that exposes and documents those and a couple of decorators as this:\n\n    def request(rest_method):\n        def outer(func):\n            @functools.wraps(func)\n            def inner(self, *args, **kwargs):\n                return func(self, rest_method, *args,\n                            **kwargs)\n            return inner\n        return outer  \n\n    def json_request(func):\n        @functools.wraps(func)\n        def wrapper(self, *args, **kwargs):\n            data \u003d kwargs.pop(\u0027data\u0027, None)\n            if data:\n               data\u003djson.dumps(data)\n            return func(self, *args, data\u003ddata, **kwargs)\n        return wrapper\n        \n    def generic_request(self, rest_method, data\u003dNone...):\n        \"\"\"Doc string here...\"\"\"\n\n    put_json \u003d request(\u0027put\u0027)(json_request(generic_request))\n    post_json \u003d request(\u0027post\u0027)(json_request(generic_request))\n    patch_json \u003d request(\u0027patch\u0027)(json_request(generic_request))\n    delete \u003d request(\u0027delete\u0027)(generic_request)\n    get \u003d request(\u0027get\u0027)(generic_request)\n\n    def json_response(func):\n        @functool.wraps(func)\n        def wrapper(self, *args, **kwargs):\n            expect_errors \u003d kwargs.pop(\u0027expect_errors\u0027, False)\n            response \u003d func(self, *args, expect_errors\u003dexpect_errors, \n                            **kwargs)\n            if not expect_errors:\n               return response.json()\n            return response\n\n    get_json \u003d json_response(get)\n \n\nEtc. The cool thing is the docstring and call args/kwargs reference should be preserved this way thanks to @functools.wraps and should point to the generic_method","commit_id":"dc44b0d5c54830c6850b15333b19b495b2ce0dc0"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"eda244e1b7c512308ab862b7a3270402f9a96542","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return wrapper"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @request(\u0027put_json\u0027)"},{"line_number":128,"context_line":"    def put_json(self, path, data\u003dNone, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":129,"context_line":"                 extra_environ\u003dNone, status\u003dNone, path_prefix\u003dPATH_PREFIX):"},{"line_number":130,"context_line":"        \"\"\"Sends simulated HTTP PUT request to Pecan test app.\"\"\""},{"line_number":131,"context_line":"        pass"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_9faa5d6f","line":129,"range":{"start_line":128,"start_character":17,"end_line":129,"end_character":73},"in_reply_to":"bacf61ea_60ee3a23","updated":"2016-08-15 06:55:55.000000000","message":"Hi Milan,\n\nThanks for the wonderful coding here. I\u0027m sorry I didn\u0027t get your point before. Will fix them. \n\nThank you very much. :)","commit_id":"dc44b0d5c54830c6850b15333b19b495b2ce0dc0"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"33668d74985d1f441dcf27407d8c7810abfd78ad","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def put_json(self, path, data\u003dNone, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":129,"context_line":"                 extra_environ\u003dNone, status\u003dNone, path_prefix\u003dPATH_PREFIX):"},{"line_number":130,"context_line":"        \"\"\"Sends simulated HTTP PUT request to Pecan test app.\"\"\""},{"line_number":131,"context_line":"        pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @request(\u0027post_json\u0027)"},{"line_number":134,"context_line":"    def post_json(self, path, data\u003dNone, expect_errors\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_401cd669","line":131,"range":{"start_line":131,"start_character":8,"end_line":131,"end_character":12},"updated":"2016-08-05 14:40:12.000000000","message":"\"pass\" isn\u0027t necessary when doc string is present","commit_id":"dc44b0d5c54830c6850b15333b19b495b2ce0dc0"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"eda244e1b7c512308ab862b7a3270402f9a96542","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def put_json(self, path, data\u003dNone, expect_errors\u003dFalse, headers\u003dNone,"},{"line_number":129,"context_line":"                 extra_environ\u003dNone, status\u003dNone, path_prefix\u003dPATH_PREFIX):"},{"line_number":130,"context_line":"        \"\"\"Sends simulated HTTP PUT request to Pecan test app.\"\"\""},{"line_number":131,"context_line":"        pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @request(\u0027post_json\u0027)"},{"line_number":134,"context_line":"    def post_json(self, path, data\u003dNone, expect_errors\u003dFalse, headers\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_95908397","line":131,"range":{"start_line":131,"start_character":8,"end_line":131,"end_character":12},"in_reply_to":"bacf61ea_401cd669","updated":"2016-08-15 06:55:55.000000000","message":"Done","commit_id":"dc44b0d5c54830c6850b15333b19b495b2ce0dc0"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cff8e904e31cf7ba4e0f58e7191f981fb900b8f6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"import pecan.testing"},{"line_number":31,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.tests.unit.db import base"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_e910df50","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":22},"updated":"2016-08-15 17:39:05.000000000","message":"Can\u0027t we import it from functional now?","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"import pecan.testing"},{"line_number":31,"context_line":"from six.moves.urllib import parse as urlparse"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from ironic.tests.unit.db import base"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_fe5a3782","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":22},"in_reply_to":"3ac371cc_e910df50","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cff8e904e31cf7ba4e0f58e7191f981fb900b8f6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(BaseApiTest, self).setUp()"},{"line_number":54,"context_line":"        cfg.CONF.set_override(\"auth_version\", \"v2.0\","},{"line_number":55,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":56,"context_line":"        cfg.CONF.set_override(\"admin_user\", \"admin\","},{"line_number":57,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_a97387b0","line":54,"range":{"start_line":54,"start_character":47,"end_line":54,"end_character":51},"updated":"2016-08-15 17:39:05.000000000","message":"We support v3 now, let\u0027s use it.","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(BaseApiTest, self).setUp()"},{"line_number":54,"context_line":"        cfg.CONF.set_override(\"auth_version\", \"v2.0\","},{"line_number":55,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":56,"context_line":"        cfg.CONF.set_override(\"admin_user\", \"admin\","},{"line_number":57,"context_line":"                              group\u003d\u0027keystone_authtoken\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_de5dbb7a","line":54,"range":{"start_line":54,"start_character":47,"end_line":54,"end_character":51},"in_reply_to":"3ac371cc_a97387b0","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0439e9a3d88c192cb8944a4ba61f29273133227","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.addCleanup(reset_pecan)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        p \u003d mock.patch(\u0027ironic.api.controllers.v1.Controller._check_version\u0027)"},{"line_number":66,"context_line":"        self._check_version \u003d p.start()"},{"line_number":67,"context_line":"        self.addCleanup(p.stop)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _make_app(self, enable_acl\u003dFalse):"},{"line_number":70,"context_line":"        # Determine where we are so we can set up paths in the config"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_e7c01fe3","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":31},"updated":"2016-08-15 11:44:25.000000000","message":"this mock seems unused here, so let\u0027s move it to the class as a decorator:\n\n @mock.patch(\u0027ironic.api.controllers.v1.Controller._check_version\u0027, lambda _ver, _hdr: None)\n class BaseApiTest(base.DbTestCase):","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.addCleanup(reset_pecan)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        p \u003d mock.patch(\u0027ironic.api.controllers.v1.Controller._check_version\u0027)"},{"line_number":66,"context_line":"        self._check_version \u003d p.start()"},{"line_number":67,"context_line":"        self.addCleanup(p.stop)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _make_app(self, enable_acl\u003dFalse):"},{"line_number":70,"context_line":"        # Determine where we are so we can set up paths in the config"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_09de0611","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":31},"in_reply_to":"3ac371cc_e7c01fe3","updated":"2016-08-16 08:20:35.000000000","message":"It is used in the second patch, test_root.py. I\u0027ll move it to the second patch.","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0439e9a3d88c192cb8944a4ba61f29273133227","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                \u0027static_root\u0027: \u0027%s/public\u0027 % root_dir,"},{"line_number":78,"context_line":"                \u0027template_path\u0027: \u0027%s/api/templates\u0027 % root_dir,"},{"line_number":79,"context_line":"                \u0027enable_acl\u0027: enable_acl,"},{"line_number":80,"context_line":"                \u0027acl_public_routes\u0027: [\u0027/\u0027, \u0027/v1\u0027],"},{"line_number":81,"context_line":"            },"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_c7588359","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":50},"updated":"2016-08-15 11:44:25.000000000","message":"not sure why you need this if you do not enable ACL.. anyway, this does not match what we have in public routes right now.\n\nI\u0027d prefer we take the real config from https://github.com/openstack/ironic/blob/master/ironic/api/config.py#L24 and then modify the field we need for tests.","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                \u0027static_root\u0027: \u0027%s/public\u0027 % root_dir,"},{"line_number":78,"context_line":"                \u0027template_path\u0027: \u0027%s/api/templates\u0027 % root_dir,"},{"line_number":79,"context_line":"                \u0027enable_acl\u0027: enable_acl,"},{"line_number":80,"context_line":"                \u0027acl_public_routes\u0027: [\u0027/\u0027, \u0027/v1\u0027],"},{"line_number":81,"context_line":"            },"},{"line_number":82,"context_line":"        }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_ac68a088","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":50},"in_reply_to":"3ac371cc_c7588359","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0439e9a3d88c192cb8944a4ba61f29273133227","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                      should be used rather than passing attribute in."},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        def outer(func):"},{"line_number":93,"context_line":"            @functools.wraps(func)"},{"line_number":94,"context_line":"            def inner(self, *args, **kwargs):"},{"line_number":95,"context_line":"                return func(self, method, *args, **kwargs)"},{"line_number":96,"context_line":"            return inner"},{"line_number":97,"context_line":"        return outer"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def json_request(func):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_823af9cb","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":24},"updated":"2016-08-15 11:44:25.000000000","message":"return functools.partial(func, method)","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"cff8e904e31cf7ba4e0f58e7191f981fb900b8f6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                      should be used rather than passing attribute in."},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        def outer(func):"},{"line_number":93,"context_line":"            @functools.wraps(func)"},{"line_number":94,"context_line":"            def inner(self, *args, **kwargs):"},{"line_number":95,"context_line":"                return func(self, method, *args, **kwargs)"},{"line_number":96,"context_line":"            return inner"},{"line_number":97,"context_line":"        return outer"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def json_request(func):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_a9e26701","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":24},"in_reply_to":"3ac371cc_823af9cb","updated":"2016-08-15 17:39:05.000000000","message":"Also please use six.wraps.","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                      should be used rather than passing attribute in."},{"line_number":91,"context_line":"        \"\"\""},{"line_number":92,"context_line":"        def outer(func):"},{"line_number":93,"context_line":"            @functools.wraps(func)"},{"line_number":94,"context_line":"            def inner(self, *args, **kwargs):"},{"line_number":95,"context_line":"                return func(self, method, *args, **kwargs)"},{"line_number":96,"context_line":"            return inner"},{"line_number":97,"context_line":"        return outer"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def json_request(func):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_589a8264","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":24},"in_reply_to":"3ac371cc_823af9cb","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0439e9a3d88c192cb8944a4ba61f29273133227","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        return outer"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def json_request(func):"},{"line_number":100,"context_line":"        \"\"\"Decorator of request methods sending json data.\"\"\""},{"line_number":101,"context_line":"        @functools.wraps(func)"},{"line_number":102,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":103,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_62ac1dee","line":100,"updated":"2016-08-15 11:44:25.000000000","message":"please document what it does to \u0027data\u0027","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        return outer"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def json_request(func):"},{"line_number":100,"context_line":"        \"\"\"Decorator of request methods sending json data.\"\"\""},{"line_number":101,"context_line":"        @functools.wraps(func)"},{"line_number":102,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":103,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_d8f3129d","line":100,"in_reply_to":"3ac371cc_62ac1dee","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0439e9a3d88c192cb8944a4ba61f29273133227","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return wrapper"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def json_response(func):"},{"line_number":110,"context_line":"        \"\"\"Decorator that changes response to json.\"\"\""},{"line_number":111,"context_line":"        @functools.wraps(func)"},{"line_number":112,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":113,"context_line":"            expect_errors \u003d kwargs.pop(\u0027expect_errors\u0027, False)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_02828952","line":110,"updated":"2016-08-15 11:44:25.000000000","message":"please document what it does to \u0027expect_errors\u0027","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        return wrapper"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def json_response(func):"},{"line_number":110,"context_line":"        \"\"\"Decorator that changes response to json.\"\"\""},{"line_number":111,"context_line":"        @functools.wraps(func)"},{"line_number":112,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":113,"context_line":"            expect_errors \u003d kwargs.pop(\u0027expect_errors\u0027, False)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_78f49e86","line":110,"in_reply_to":"3ac371cc_02828952","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b0439e9a3d88c192cb8944a4ba61f29273133227","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\"Decorator that changes response to json.\"\"\""},{"line_number":111,"context_line":"        @functools.wraps(func)"},{"line_number":112,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":113,"context_line":"            expect_errors \u003d kwargs.pop(\u0027expect_errors\u0027, False)"},{"line_number":114,"context_line":"            response \u003d func(self, *args, expect_errors\u003dexpect_errors, **kwargs)"},{"line_number":115,"context_line":"            if not expect_errors:"},{"line_number":116,"context_line":"                return response.json()"},{"line_number":117,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_029ba9ca","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":79},"updated":"2016-08-15 11:44:25.000000000","message":"simpler:\n\n expect_errors \u003d kwargs.get(\u0027expect_errors\u0027)\n response \u003d func(self, *args, **kwargs)","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"faf4db8ec447325fb76401e11b8c90619951c36c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\"Decorator that changes response to json.\"\"\""},{"line_number":111,"context_line":"        @functools.wraps(func)"},{"line_number":112,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":113,"context_line":"            expect_errors \u003d kwargs.pop(\u0027expect_errors\u0027, False)"},{"line_number":114,"context_line":"            response \u003d func(self, *args, expect_errors\u003dexpect_errors, **kwargs)"},{"line_number":115,"context_line":"            if not expect_errors:"},{"line_number":116,"context_line":"                return response.json()"},{"line_number":117,"context_line":"            return response"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_98f99a83","line":114,"range":{"start_line":113,"start_character":0,"end_line":114,"end_character":79},"in_reply_to":"3ac371cc_029ba9ca","updated":"2016-08-16 08:20:35.000000000","message":"Done","commit_id":"6c654d4bd83027e249973b07b8d713ebc900931d"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"4140902d4c2fc1819987f8ca6e3f2d2850d5a118","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"},{"line_number":152,"context_line":"    post_json \u003d request(\u0027post\u0027)(json_request(_request))"},{"line_number":153,"context_line":"    patch_json \u003d request(\u0027patch\u0027)(json_request(_request))"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_20289332","line":151,"range":{"start_line":151,"start_character":15,"end_line":151,"end_character":53},"updated":"2016-08-19 06:24:50.000000000","message":"Just a thought (please, correct me if I\u0027m wrong) if the method is a json_request at the core, shouldn\u0027t it be a json_response too? I mean the server most likely answers with a json-encoded response.","commit_id":"70d5d47f5b43c3da57572f7be6b3f6577cedf4f8"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"56b355d6093ffb37e11f713e633ae41fb679f71d","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"},{"line_number":152,"context_line":"    post_json \u003d request(\u0027post\u0027)(json_request(_request))"},{"line_number":153,"context_line":"    patch_json \u003d request(\u0027patch\u0027)(json_request(_request))"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_a1ad5f33","line":151,"range":{"start_line":151,"start_character":15,"end_line":151,"end_character":53},"in_reply_to":"3ac371cc_20289332","updated":"2016-08-26 09:36:54.000000000","message":"IIUC, the response is encapsulated in a Response object. And we have a json_response() wrapper to translate it.","commit_id":"70d5d47f5b43c3da57572f7be6b3f6577cedf4f8"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"2edf8a4aecb3bc31d4bfa578080e2f60243e154d","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"},{"line_number":152,"context_line":"    post_json \u003d request(\u0027post\u0027)(json_request(_request))"},{"line_number":153,"context_line":"    patch_json \u003d request(\u0027patch\u0027)(json_request(_request))"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa7ab95a_4d77c59f","line":151,"range":{"start_line":151,"start_character":15,"end_line":151,"end_character":53},"in_reply_to":"fa7ab95a_a1ad5f33","updated":"2016-08-30 07:16:38.000000000","message":"I had:\n   \n   put_json \u003d json_response(request(\u0027put\u0027)(json_request(_request)))\n   # ...\n   self.assertEqual({\u0027error\u0027: None}, self.put_json({\u0027hello\u0027: \u0027there\u0027})\n   self.assertEqual({\u0027error\u0027: \u0027Invalid data\u0027}, self.put_json({\u0027there\u0027: \u0027hello\u0027},\n       expect_errors\u003dTrue)\n\non my mind but the truth is the response details (such as code) would be lost this way as the response object would be hidden from the user.","commit_id":"70d5d47f5b43c3da57572f7be6b3f6577cedf4f8"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"87e40d839a2836b10ebfa076053aa95c1d649585","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    framework."},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    SOURCE_DATA \u003d {\u0027test_source\u0027: {\u0027somekey\u0027: \u002742\u0027}}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(BaseApiTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_4d2ee5fb","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":52},"updated":"2016-08-30 07:15:47.000000000","message":"this value is never used, remove?","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"10ce4788afa149f09e6d6f83dd20eb2678abec78","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    framework."},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    SOURCE_DATA \u003d {\u0027test_source\u0027: {\u0027somekey\u0027: \u002742\u0027}}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(BaseApiTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa7ab95a_f93dbb2b","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":52},"in_reply_to":"fa7ab95a_4d2ee5fb","updated":"2016-09-01 04:23:40.000000000","message":"Done","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"683fcefe23f1d7fc55e7a36cb8fcc295ba896d50","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        @wraps(func)"},{"line_number":91,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":92,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"},{"line_number":93,"context_line":"            if data:"},{"line_number":94,"context_line":"                data \u003d json.dumps(data)"},{"line_number":95,"context_line":"            return func(self, *args, data\u003ddata, **kwargs)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_1672eae5","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":43},"updated":"2016-09-02 17:47:57.000000000","message":"We were not doing this previously, we just passed further down whatever was passed as params.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a2ce52d17a6d5c08d116af426ce60ad5b47e7c62","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        @wraps(func)"},{"line_number":91,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":92,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"},{"line_number":93,"context_line":"            if data:"},{"line_number":94,"context_line":"                data \u003d json.dumps(data)"},{"line_number":95,"context_line":"            return func(self, *args, data\u003ddata, **kwargs)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_bc638619","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":43},"in_reply_to":"da7fb54a_1672eae5","updated":"2016-09-06 12:13:02.000000000","message":"Yes. And this was pointed out by Milan that if we may return the response in json format, we\u0027d better provide a function that enable us to make the request in json format. \n\nAt the same time, request() will do the request in the old way, just pass down whatever was passed as params. It is up to the test case author to choose which of them to use.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"683fcefe23f1d7fc55e7a36cb8fcc295ba896d50","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":92,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"},{"line_number":93,"context_line":"            if data:"},{"line_number":94,"context_line":"                data \u003d json.dumps(data)"},{"line_number":95,"context_line":"            return func(self, *args, data\u003ddata, **kwargs)"},{"line_number":96,"context_line":"        return wrapper"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_aa5f0e0d","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":39},"updated":"2016-09-02 17:47:57.000000000","message":"Also it seems like it\u0027s done automatically by webtest app if we use the *_json methods, why reinvent this?","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"b05f0307a3785d2a66df7b7c16e83637b2d8b6fe","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":92,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"},{"line_number":93,"context_line":"            if data:"},{"line_number":94,"context_line":"                data \u003d json.dumps(data)"},{"line_number":95,"context_line":"            return func(self, *args, data\u003ddata, **kwargs)"},{"line_number":96,"context_line":"        return wrapper"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_2ce451de","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":39},"in_reply_to":"9a89bdaa_9335d0f8","updated":"2016-09-13 11:34:32.000000000","message":"I wasn\u0027t aware of that, sorry","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a2ce52d17a6d5c08d116af426ce60ad5b47e7c62","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":92,"context_line":"            data \u003d kwargs.pop(\u0027data\u0027, None)"},{"line_number":93,"context_line":"            if data:"},{"line_number":94,"context_line":"                data \u003d json.dumps(data)"},{"line_number":95,"context_line":"            return func(self, *args, data\u003ddata, **kwargs)"},{"line_number":96,"context_line":"        return wrapper"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_9335d0f8","line":94,"range":{"start_line":94,"start_character":16,"end_line":94,"end_character":39},"in_reply_to":"da7fb54a_aa5f0e0d","updated":"2016-09-06 12:13:02.000000000","message":"Oh, yes, indeed. In webtest.utils, *_json has done the dumps. I didn\u0027t notice that.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"683fcefe23f1d7fc55e7a36cb8fcc295ba896d50","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param status: expected status code of response"},{"line_number":128,"context_line":"        :param path_prefix: prefix of the url path"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":131,"context_line":"        LOG.debug(\u0027%(method)s: %(full_path)s %(data)s\u0027,"},{"line_number":132,"context_line":"                  {\u0027method\u0027: method.upper(),"},{"line_number":133,"context_line":"                   \u0027full_path\u0027: full_path,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_6a37c6e3","line":130,"updated":"2016-09-02 17:47:57.000000000","message":"Please check the get_json method from unittests, it does a whole bunch of other stuff, I\u0027m not sure where this logic is now.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"6951f442aef393016fc54d2f4b164d08c27cf60c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param status: expected status code of response"},{"line_number":128,"context_line":"        :param path_prefix: prefix of the url path"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":131,"context_line":"        LOG.debug(\u0027%(method)s: %(full_path)s %(data)s\u0027,"},{"line_number":132,"context_line":"                  {\u0027method\u0027: method.upper(),"},{"line_number":133,"context_line":"                   \u0027full_path\u0027: full_path,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_c4a9b591","line":130,"in_reply_to":"9a89bdaa_ecb6e9da","updated":"2016-09-19 12:20:51.000000000","message":"I don\u0027t think this code is ever used in Ironic tests. I greped the code, but found nowhere this q\u003d[] param used.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"b05f0307a3785d2a66df7b7c16e83637b2d8b6fe","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        :param status: expected status code of response"},{"line_number":128,"context_line":"        :param path_prefix: prefix of the url path"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        full_path \u003d path_prefix + path"},{"line_number":131,"context_line":"        LOG.debug(\u0027%(method)s: %(full_path)s %(data)s\u0027,"},{"line_number":132,"context_line":"                  {\u0027method\u0027: method.upper(),"},{"line_number":133,"context_line":"                   \u0027full_path\u0027: full_path,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_ecb6e9da","line":130,"in_reply_to":"da7fb54a_6a37c6e3","updated":"2016-09-13 11:34:32.000000000","message":"Yeah, this needs fixing, what would you say to making the _request always handle the queries if present so we\u0027ve got a generic request method? Later we could use the functools.partial to bind the method to the _request;\nWould basically mean to copy\u0026paste the code from https://github.com/openstack/ironic/blob/master/ironic/tests/unit/api/base.py#L202-#L213 and then do the getattr magic below with all the params. WDYT?","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"683fcefe23f1d7fc55e7a36cb8fcc295ba896d50","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                   \u0027full_path\u0027: full_path,"},{"line_number":134,"context_line":"                   \u0027data\u0027: data})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        response \u003d getattr(self.app, \"%s\" % method)("},{"line_number":137,"context_line":"            str(full_path),"},{"line_number":138,"context_line":"            params\u003ddata,"},{"line_number":139,"context_line":"            headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_16ed8a8b","line":136,"range":{"start_line":136,"start_character":38,"end_line":136,"end_character":40},"updated":"2016-09-02 17:47:57.000000000","message":"the method that gets propagated here is post, patch, put, while originally it had _json appended to the method. Is it the reason you added json_request function? If so, I\u0027d switch back to p{ost,ut,atch}_json instead of p{ost,ut,atch}.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a2ce52d17a6d5c08d116af426ce60ad5b47e7c62","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                   \u0027full_path\u0027: full_path,"},{"line_number":134,"context_line":"                   \u0027data\u0027: data})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        response \u003d getattr(self.app, \"%s\" % method)("},{"line_number":137,"context_line":"            str(full_path),"},{"line_number":138,"context_line":"            params\u003ddata,"},{"line_number":139,"context_line":"            headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_9603fe0c","line":136,"range":{"start_line":136,"start_character":38,"end_line":136,"end_character":40},"in_reply_to":"da7fb54a_16ed8a8b","updated":"2016-09-06 12:13:02.000000000","message":"Agreed.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"b05f0307a3785d2a66df7b7c16e83637b2d8b6fe","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                   \u0027full_path\u0027: full_path,"},{"line_number":134,"context_line":"                   \u0027data\u0027: data})"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        response \u003d getattr(self.app, \"%s\" % method)("},{"line_number":137,"context_line":"            str(full_path),"},{"line_number":138,"context_line":"            params\u003ddata,"},{"line_number":139,"context_line":"            headers\u003dheaders,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_9794868b","line":136,"range":{"start_line":136,"start_character":38,"end_line":136,"end_character":40},"in_reply_to":"da7fb54a_16ed8a8b","updated":"2016-09-13 11:34:32.000000000","message":"the other reason was to be able to have a non-json version of the method (you would skip the json_* decorator) but no point in doing that since, as you say, webtest.utils handles this already. Sorry, I didn\u0027t know about it.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"683fcefe23f1d7fc55e7a36cb8fcc295ba896d50","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return response"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_36ce0e84","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":30},"updated":"2016-09-02 17:47:57.000000000","message":"I don\u0027t quite like this, it makes the code harder to read, I think using functools.partial on _request would be a bit clearer.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a2ce52d17a6d5c08d116af426ce60ad5b47e7c62","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return response"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_b6100203","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":30},"in_reply_to":"da7fb54a_36ce0e84","updated":"2016-09-06 12:13:02.000000000","message":"Done","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"b05f0307a3785d2a66df7b7c16e83637b2d8b6fe","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        return response"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_7796224d","line":148,"range":{"start_line":148,"start_character":13,"end_line":148,"end_character":30},"in_reply_to":"da7fb54a_36ce0e84","updated":"2016-09-13 11:34:32.000000000","message":"yeah, on the retrospect it does seem more clear.\nLet\u0027s replace the request decorator with functools.partial then.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"683fcefe23f1d7fc55e7a36cb8fcc295ba896d50","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return response"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"},{"line_number":152,"context_line":"    post_json \u003d request(\u0027post\u0027)(json_request(_request))"}],"source_content_type":"text/x-python","patch_set":14,"id":"da7fb54a_56c71245","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":34},"updated":"2016-09-02 17:47:57.000000000","message":"Is there any example of get that does not return json? Or is it for the case when we have an empty response? I\u0027d rather change the response_json to handle empty response than to introduce an additional function.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a2ce52d17a6d5c08d116af426ce60ad5b47e7c62","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        return response"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":149,"context_line":"    get \u003d request(\u0027get\u0027)(_request)"},{"line_number":150,"context_line":"    get_json \u003d json_response(get)"},{"line_number":151,"context_line":"    put_json \u003d request(\u0027put\u0027)(json_request(_request))"},{"line_number":152,"context_line":"    post_json \u003d request(\u0027post\u0027)(json_request(_request))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_9664de49","line":149,"range":{"start_line":149,"start_character":4,"end_line":149,"end_character":34},"in_reply_to":"da7fb54a_56c71245","updated":"2016-09-06 12:13:02.000000000","message":"I\u0027m sorry I haven\u0027t checked all the tests. There is one in test_root, but it can be replaced with get_json(), I think.","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"5c6f174fd6a2e1a5be8946098f60bccc7fa88202","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return pecan.testing.load_test_app(self.app_config)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def request(method):"},{"line_number":69,"context_line":"        \"\"\"Decorator of request methods."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        param method: Request method type. Appropriate method function call"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_72971090","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":24},"updated":"2016-09-13 11:46:06.000000000","message":"please, drop this in favor of six.functools.partial as vdrok suggests in #14.","commit_id":"eb590f1001f09134578a13d0bdd9fd073ba86781"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f4e32083475728d53c458816c57f87dc4426695b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        return pecan.testing.load_test_app(self.app_config)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def request(method):"},{"line_number":69,"context_line":"        \"\"\"Decorator of request methods."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        param method: Request method type. Appropriate method function call"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_d8b44083","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":24},"in_reply_to":"9a89bdaa_72971090","updated":"2016-09-19 12:15:58.000000000","message":"Done","commit_id":"eb590f1001f09134578a13d0bdd9fd073ba86781"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"5c6f174fd6a2e1a5be8946098f60bccc7fa88202","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                  {\u0027method\u0027: method.upper(),"},{"line_number":101,"context_line":"                   \u0027full_path\u0027: full_path,"},{"line_number":102,"context_line":"                   \u0027data\u0027: data})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        response \u003d getattr(self.app, \"%s\" % method)("},{"line_number":105,"context_line":"            str(full_path),"},{"line_number":106,"context_line":"            params\u003ddata,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_52a76c0a","line":103,"updated":"2016-09-13 11:46:06.000000000","message":"how about handling the query parameters in _request (instead of get_json https://github.com/openstack/ironic/blob/master/ironic/tests/unit/api/base.py#L202-#L213)?","commit_id":"eb590f1001f09134578a13d0bdd9fd073ba86781"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f4e32083475728d53c458816c57f87dc4426695b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                  {\u0027method\u0027: method.upper(),"},{"line_number":101,"context_line":"                   \u0027full_path\u0027: full_path,"},{"line_number":102,"context_line":"                   \u0027data\u0027: data})"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        response \u003d getattr(self.app, \"%s\" % method)("},{"line_number":105,"context_line":"            str(full_path),"},{"line_number":106,"context_line":"            params\u003ddata,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_c96b90ef","line":103,"in_reply_to":"9a89bdaa_52a76c0a","updated":"2016-09-19 12:15:58.000000000","message":"I think I can do this. But I just greped the code, and I didn\u0027t find anyone used this param. So I removed it in the patch. I think we can add it when we need it. How do you think ?","commit_id":"eb590f1001f09134578a13d0bdd9fd073ba86781"},{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"5c6f174fd6a2e1a5be8946098f60bccc7fa88202","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            return response.json"},{"line_number":116,"context_line":"        return response"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":119,"context_line":"    get_json \u003d request(\u0027get\u0027)(_request)"},{"line_number":120,"context_line":"    put_json \u003d request(\u0027put_json\u0027)(_request)"},{"line_number":121,"context_line":"    post_json \u003d request(\u0027post_json\u0027)(_request)"},{"line_number":122,"context_line":"    patch_json \u003d request(\u0027patch_json\u0027)(_request)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def validate_link(self, link, bookmark\u003dFalse):"},{"line_number":125,"context_line":"        \"\"\"Check if the given link can get correct data.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_92701474","line":122,"range":{"start_line":118,"start_character":2,"end_line":122,"end_character":48},"updated":"2016-09-13 11:46:06.000000000","message":"please, replace:\n\n    request(\u003cmethod_name\u003e)(_request)\n\nwith:\n\n    (six.)functools.partial(_request, \u003cmethod_name\u003e)","commit_id":"eb590f1001f09134578a13d0bdd9fd073ba86781"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f4e32083475728d53c458816c57f87dc4426695b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            return response.json"},{"line_number":116,"context_line":"        return response"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    delete \u003d request(\u0027delete\u0027)(_request)"},{"line_number":119,"context_line":"    get_json \u003d request(\u0027get\u0027)(_request)"},{"line_number":120,"context_line":"    put_json \u003d request(\u0027put_json\u0027)(_request)"},{"line_number":121,"context_line":"    post_json \u003d request(\u0027post_json\u0027)(_request)"},{"line_number":122,"context_line":"    patch_json \u003d request(\u0027patch_json\u0027)(_request)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def validate_link(self, link, bookmark\u003dFalse):"},{"line_number":125,"context_line":"        \"\"\"Check if the given link can get correct data.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_f3275d60","line":122,"range":{"start_line":118,"start_character":2,"end_line":122,"end_character":48},"in_reply_to":"9a89bdaa_92701474","updated":"2016-09-19 12:15:58.000000000","message":"Done","commit_id":"eb590f1001f09134578a13d0bdd9fd073ba86781"}],"tox.ini":[{"author":{"_account_id":18653,"name":"Milan Kováčik","email":"mkovacik@redhat.com","username":"dparalen"},"change_message_id":"87e40d839a2836b10ebfa076053aa95c1d649585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.8"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py35,py34,py27,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"}],"source_content_type":"text/x-properties","patch_set":14,"id":"fa7ab95a_0de5bda6","line":4,"updated":"2016-08-30 07:15:47.000000000","message":"please, add:\n\n    ,functional","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"10ce4788afa149f09e6d6f83dd20eb2678abec78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.8"},{"line_number":3,"context_line":"skipsdist \u003d True"},{"line_number":4,"context_line":"envlist \u003d py35,py34,py27,pep8"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"}],"source_content_type":"text/x-properties","patch_set":14,"id":"fa7ab95a_99e74fab","line":4,"in_reply_to":"fa7ab95a_0de5bda6","updated":"2016-09-01 04:23:40.000000000","message":"Done","commit_id":"bf530e903a69702b55efc06e31afd4603145c443"}]}
