)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"739071d4c16e71989fdd8b7ca0400736963bd82d","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"#power_wait \u003d 2"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"# Priority for erase devices clean step. If unset it defaults"},{"line_number":1162,"context_line":"# to 10. If set to 0, the step will be disabled and will not run "},{"line_number":1163,"context_line":"# during cleaning."},{"line_number":1164,"context_line":"#clean_priority_hardware_disk_erase \u003d 0"},{"line_number":1165,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bacf61ea_52b93acb","line":1162,"range":{"start_line":1162,"start_character":61,"end_line":1162,"end_character":65},"updated":"2016-08-01 15:45:54.000000000","message":"Extra space? Or conf file needs to be regenerated.","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"}],"ironic/conf/ilo.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"739071d4c16e71989fdd8b7ca0400736963bd82d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003d2,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Amount of time in seconds to wait in between power \u0027"},{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":82,"context_line":"               default\u003d10,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":84,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_352c7098","line":81,"updated":"2016-08-01 15:45:54.000000000","message":"Wont it be useful to use existing config \u0027erase_devices_priority \u0027 as it is used in similar fashion?\nhttps://github.com/openstack/ironic/blob/master/etc/ironic/ironic.conf.sample#L867","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a645a7493e4b46cb21e1a4d07a891931e86b209d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003d2,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Amount of time in seconds to wait in between power \u0027"},{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":82,"context_line":"               default\u003d10,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":84,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c88f2073","line":81,"in_reply_to":"bacf61ea_352c7098","updated":"2016-08-02 06:36:53.000000000","message":"Since it is iLO drivers specific clean step is it okay to use the existing config \u0027erase_devices_priority \u0027?\n\n Also If there is a need to perform both \u0027erase_devices\u0027 and \u0027hardware_disk_erase\u0027 clean steps with different priority then having them as separate config parameters will be useful.","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"739071d4c16e71989fdd8b7ca0400736963bd82d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":82,"context_line":"               default\u003d10,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":84,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"},{"line_number":85,"context_line":"                      \u0027disabled and will not run during cleaning.\u0027)),"},{"line_number":86,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b21eb609","line":83,"range":{"start_line":83,"start_character":32,"end_line":83,"end_character":49},"updated":"2016-08-01 15:45:54.000000000","message":"s/ \u0027for erase devices\u0027 / \u0027for hardware based erase devices\u0027","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a645a7493e4b46cb21e1a4d07a891931e86b209d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      \u0027operations\u0027)),"},{"line_number":81,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":82,"context_line":"               default\u003d10,"},{"line_number":83,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":84,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"},{"line_number":85,"context_line":"                      \u0027disabled and will not run during cleaning.\u0027)),"},{"line_number":86,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e8a664bf","line":83,"range":{"start_line":83,"start_character":32,"end_line":83,"end_character":49},"in_reply_to":"bacf61ea_b21eb609","updated":"2016-08-02 06:36:53.000000000","message":"Done","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"739071d4c16e71989fdd8b7ca0400736963bd82d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"},{"line_number":87,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":88,"context_line":"               choices\u003d[\u0027zero\u0027, \u0027random_zero\u0027, \u0027random_random_zero\u0027],"},{"line_number":89,"context_line":"               help\u003d_(\u0027The pattern to be used to perform the disk erase. \u0027"},{"line_number":90,"context_line":"                      \u0027The possible values are zero, random_zero, \u0027"},{"line_number":91,"context_line":"                      \u0027random_random_zero.\u0027))"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b26b561d","line":89,"range":{"start_line":89,"start_character":57,"end_line":89,"end_character":72},"updated":"2016-08-01 15:45:54.000000000","message":"s/ \u0027the disk erase\u0027 / \u0027the hardware based disk erase\u0027 /","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a645a7493e4b46cb21e1a4d07a891931e86b209d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"},{"line_number":87,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":88,"context_line":"               choices\u003d[\u0027zero\u0027, \u0027random_zero\u0027, \u0027random_random_zero\u0027],"},{"line_number":89,"context_line":"               help\u003d_(\u0027The pattern to be used to perform the disk erase. \u0027"},{"line_number":90,"context_line":"                      \u0027The possible values are zero, random_zero, \u0027"},{"line_number":91,"context_line":"                      \u0027random_random_zero.\u0027))"},{"line_number":92,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_48aa1086","line":89,"range":{"start_line":89,"start_character":57,"end_line":89,"end_character":72},"in_reply_to":"bacf61ea_b26b561d","updated":"2016-08-02 06:36:53.000000000","message":"Done","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"739071d4c16e71989fdd8b7ca0400736963bd82d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":88,"context_line":"               choices\u003d[\u0027zero\u0027, \u0027random_zero\u0027, \u0027random_random_zero\u0027],"},{"line_number":89,"context_line":"               help\u003d_(\u0027The pattern to be used to perform the disk erase. \u0027"},{"line_number":90,"context_line":"                      \u0027The possible values are zero, random_zero, \u0027"},{"line_number":91,"context_line":"                      \u0027random_random_zero.\u0027))"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_92aa9283","line":90,"range":{"start_line":90,"start_character":64,"end_line":90,"end_character":67},"updated":"2016-08-01 15:45:54.000000000","message":"s/ \u0027, \u0027 / \u0027and\u0027","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a645a7493e4b46cb21e1a4d07a891931e86b209d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":88,"context_line":"               choices\u003d[\u0027zero\u0027, \u0027random_zero\u0027, \u0027random_random_zero\u0027],"},{"line_number":89,"context_line":"               help\u003d_(\u0027The pattern to be used to perform the disk erase. \u0027"},{"line_number":90,"context_line":"                      \u0027The possible values are zero, random_zero, \u0027"},{"line_number":91,"context_line":"                      \u0027random_random_zero.\u0027))"},{"line_number":92,"context_line":"]"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c89e0062","line":90,"range":{"start_line":90,"start_character":64,"end_line":90,"end_character":67},"in_reply_to":"bacf61ea_92aa9283","updated":"2016-08-02 06:36:53.000000000","message":"Done","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2135a29742a696cdd47657b135383d9e761490a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"clean_opts \u003d ["},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":43,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0f8de9d5","line":40,"updated":"2016-08-01 12:45:33.000000000","message":"This should be moved to ironic/conf/ilo now.","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ccdc069c0004122615b446f6eb8a043a0e7f5d80","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"clean_opts \u003d ["},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":43,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e0597f8f","line":40,"in_reply_to":"bacf61ea_0f8de9d5","updated":"2016-08-01 14:19:03.000000000","message":"Done","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2135a29742a696cdd47657b135383d9e761490a2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"clean_opts \u003d ["},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":43,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"},{"line_number":44,"context_line":"                      \u0027disabled and will not run during cleaning.\u0027)),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027zero\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4ff2419b","line":43,"updated":"2016-08-01 12:45:33.000000000","message":"No default\u003d10 here.","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ccdc069c0004122615b446f6eb8a043a0e7f5d80","unresolved":false,"context_lines":[{"line_number":40,"context_line":"clean_opts \u003d ["},{"line_number":41,"context_line":"    cfg.IntOpt(\u0027clean_priority_hardware_disk_erase\u0027,"},{"line_number":42,"context_line":"               help\u003d_(\u0027Priority for erase devices clean step. If unset, \u0027"},{"line_number":43,"context_line":"                      \u0027it defaults to 10. If set to 0, the step will be \u0027"},{"line_number":44,"context_line":"                      \u0027disabled and will not run during cleaning.\u0027)),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027zero\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_c05c3b7f","line":43,"in_reply_to":"bacf61ea_4ff2419b","updated":"2016-08-01 14:19:03.000000000","message":"Done","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2135a29742a696cdd47657b135383d9e761490a2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":47,"context_line":"               help\u003d_(\u0027The pattern to be used to perform the disk erase. \u0027"},{"line_number":48,"context_line":"                      \u0027The possible values are zero, random_zero, \u0027"},{"line_number":49,"context_line":"                      \u0027random_random_zero.\u0027))"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ef7a1523","line":48,"updated":"2016-08-01 12:45:33.000000000","message":"Please add choices\u003d[\u0027zero\u0027, \u0027random_zero\u0027...] here","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ccdc069c0004122615b446f6eb8a043a0e7f5d80","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027hardware_erase_pattern\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":47,"context_line":"               help\u003d_(\u0027The pattern to be used to perform the disk erase. \u0027"},{"line_number":48,"context_line":"                      \u0027The possible values are zero, random_zero, \u0027"},{"line_number":49,"context_line":"                      \u0027random_random_zero.\u0027))"},{"line_number":50,"context_line":"]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2058b787","line":48,"in_reply_to":"bacf61ea_ef7a1523","updated":"2016-08-01 14:19:03.000000000","message":"Done","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2135a29742a696cdd47657b135383d9e761490a2","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def _get_ilo_clean_steps(task):"},{"line_number":196,"context_line":"        \"\"\"Get the list of clean steps from the agent."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param task: a TaskManager object containing the node"},{"line_number":199,"context_line":"        :raises NodeCleaningFailure: if the clean steps are not yet"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6f31055a","line":196,"updated":"2016-08-01 12:45:33.000000000","message":"overindent","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ccdc069c0004122615b446f6eb8a043a0e7f5d80","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def _get_ilo_clean_steps(task):"},{"line_number":196,"context_line":"        \"\"\"Get the list of clean steps from the agent."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        :param task: a TaskManager object containing the node"},{"line_number":199,"context_line":"        :raises NodeCleaningFailure: if the clean steps are not yet"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_604e2fc2","line":196,"in_reply_to":"bacf61ea_6f31055a","updated":"2016-08-01 14:19:03.000000000","message":"Done","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2135a29742a696cdd47657b135383d9e761490a2","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        :returns: A list of clean step dictionaries"},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        import pdb"},{"line_number":366,"context_line":"        pdb.set_trace()"},{"line_number":367,"context_line":"        return _get_ilo_clean_steps(task)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2f1b8dcb","line":365,"updated":"2016-08-01 12:45:33.000000000","message":"This should not be here :)","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ccdc069c0004122615b446f6eb8a043a0e7f5d80","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        :returns: A list of clean step dictionaries"},{"line_number":363,"context_line":"        \"\"\""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        import pdb"},{"line_number":366,"context_line":"        pdb.set_trace()"},{"line_number":367,"context_line":"        return _get_ilo_clean_steps(task)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_40496bb6","line":365,"in_reply_to":"bacf61ea_2f1b8dcb","updated":"2016-08-01 14:19:03.000000000","message":"Done","commit_id":"c343edba71b429519146a17b82b2e1c90dbf5321"}],"releasenotes/notes/bug-1593194-447835be4db684f1.yaml":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"739071d4c16e71989fdd8b7ca0400736963bd82d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to perform hardware_disk_erase as a cleaning step "},{"line_number":4,"context_line":"    for iLO drivers."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a [ilo]clean_priority_hardware_disk_erase configuration option to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_f5d5b8e4","line":3,"range":{"start_line":3,"start_character":64,"end_line":3,"end_character":67},"updated":"2016-08-01 15:45:54.000000000","message":"nit: extra space at end","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a645a7493e4b46cb21e1a4d07a891931e86b209d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support to perform hardware_disk_erase as a cleaning step "},{"line_number":4,"context_line":"    for iLO drivers."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Adds a [ilo]clean_priority_hardware_disk_erase configuration option to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_082f783f","line":3,"range":{"start_line":3,"start_character":64,"end_line":3,"end_character":67},"in_reply_to":"bacf61ea_f5d5b8e4","updated":"2016-08-02 06:36:53.000000000","message":"Done","commit_id":"6db0a610b2a900e8e9229f9e81cb423b684120de"}]}
