)]}'
{"ironic/objects/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8b63367531a6326bb2f2126d1b0348e2b0ed1f99","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        \u0027network_interface\u0027: object_fields.StringField("},{"line_number":121,"context_line":"            nullable\u003dFalse, default\u003d_default_network_interface()),"},{"line_number":122,"context_line":"    }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3908b02d","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":64},"updated":"2016-08-02 16:08:17.000000000","message":"It is not needed anymore.","commit_id":"cedff4e3780191f6d43d5ccfa6a1a363c728d859"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e1d11266ae3fbd4f3aa9e2589c49d7f34039e915","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    @mock.patch(\u0027ironic.conductor.utils.node_power_action\u0027, autospec\u003dTrue)"},{"line_number":445,"context_line":"    def test_tear_down(self, power_mock, unconfigure_tenant_nets_mock):"},{"line_number":446,"context_line":"        self.node.network_interface \u003d \u0027flat\u0027"},{"line_number":447,"context_line":"        self.node.save()"},{"line_number":448,"context_line":"        with task_manager.acquire("},{"line_number":449,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"},{"line_number":450,"context_line":"            driver_return \u003d self.driver.tear_down(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_57a61654","line":447,"updated":"2016-08-02 13:28:47.000000000","message":"Hm, why do we need to do this? Shouldn\u0027t the default thing do it correctly?","commit_id":"dc6654e167874a4d55af998c58470e4253b62360"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bc44362c03eeb11409a4f03ff52f70442894976a","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    @mock.patch(\u0027ironic.conductor.utils.node_power_action\u0027, autospec\u003dTrue)"},{"line_number":445,"context_line":"    def test_tear_down(self, power_mock, unconfigure_tenant_nets_mock):"},{"line_number":446,"context_line":"        self.node.network_interface \u003d \u0027flat\u0027"},{"line_number":447,"context_line":"        self.node.save()"},{"line_number":448,"context_line":"        with task_manager.acquire("},{"line_number":449,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"},{"line_number":450,"context_line":"            driver_return \u003d self.driver.tear_down(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e25dca7a","line":447,"in_reply_to":"bacf61ea_57a61654","updated":"2016-08-02 13:37:40.000000000","message":"The reason is the default network interface is set at a class/module level time so when we update it in other tests it can bleed over into tests that are assuming specific defaults.","commit_id":"dc6654e167874a4d55af998c58470e4253b62360"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9f6151b81417cdf92a2e9b94e37b6bf77a09ae3f","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    @mock.patch(\u0027ironic.conductor.utils.node_power_action\u0027, autospec\u003dTrue)"},{"line_number":445,"context_line":"    def test_tear_down(self, power_mock, unconfigure_tenant_nets_mock):"},{"line_number":446,"context_line":"        self.node.network_interface \u003d \u0027flat\u0027"},{"line_number":447,"context_line":"        self.node.save()"},{"line_number":448,"context_line":"        with task_manager.acquire("},{"line_number":449,"context_line":"                self.context, self.node[\u0027uuid\u0027], shared\u003dFalse) as task:"},{"line_number":450,"context_line":"            driver_return \u003d self.driver.tear_down(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_85f17598","line":447,"in_reply_to":"bacf61ea_e25dca7a","updated":"2016-08-02 14:33:12.000000000","message":"Hmm, do we need to make the same for all the places that assume a particular network interface then? Like the next test for example on L461?","commit_id":"dc6654e167874a4d55af998c58470e4253b62360"}],"ironic/tests/unit/objects/test_node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8b63367531a6326bb2f2126d1b0348e2b0ed1f99","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestNodeObject, self).setUp()"},{"line_number":32,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":33,"context_line":"        self.fake_node \u003d utils.get_test_node()"},{"line_number":34,"context_line":"        self.node \u003d obj_utils.get_test_node(self.ctxt, **self.fake_node)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9d7d45b4","line":32,"updated":"2016-08-02 16:08:17.000000000","message":"This is not necessary, just self.context can be used.","commit_id":"cedff4e3780191f6d43d5ccfa6a1a363c728d859"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8b63367531a6326bb2f2126d1b0348e2b0ed1f99","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(TestNodeObject, self).setUp()"},{"line_number":32,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":33,"context_line":"        self.fake_node \u003d utils.get_test_node()"},{"line_number":34,"context_line":"        self.node \u003d obj_utils.get_test_node(self.ctxt, **self.fake_node)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_get_by_id(self):"},{"line_number":37,"context_line":"        node_id \u003d self.fake_node[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5d5aad51","line":34,"updated":"2016-08-02 16:08:17.000000000","message":"We can move this inside the first test now.","commit_id":"cedff4e3780191f6d43d5ccfa6a1a363c728d859"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8b63367531a6326bb2f2126d1b0348e2b0ed1f99","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    def test_get_network_interface_use_conf(self):"},{"line_number":207,"context_line":"        for nif in (\u0027neutron\u0027, \u0027flat\u0027, \u0027noop\u0027):"},{"line_number":208,"context_line":"            CONF.set_override(\u0027default_network_interface\u0027, nif)"},{"line_number":209,"context_line":"            self.node \u003d obj_utils.get_test_node(self.ctxt, **self.fake_node)"},{"line_number":210,"context_line":"            self.assertEqual(nif, self.node.network_interface)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_get_network_interface_use_dhcp_provider(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dd1b3d7f","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":21},"updated":"2016-08-02 16:08:17.000000000","message":"Why self.node, not just node?","commit_id":"cedff4e3780191f6d43d5ccfa6a1a363c728d859"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8b63367531a6326bb2f2126d1b0348e2b0ed1f99","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        CONF.set_override(\u0027default_network_interface\u0027, None)"},{"line_number":214,"context_line":"        for dhcp, nif in ((\u0027neutron\u0027, \u0027flat\u0027), (\u0027none\u0027, \u0027noop\u0027)):"},{"line_number":215,"context_line":"            CONF.set_override(\u0027dhcp_provider\u0027, dhcp, \u0027dhcp\u0027)"},{"line_number":216,"context_line":"            self.node \u003d obj_utils.get_test_node(self.ctxt, **self.fake_node)"},{"line_number":217,"context_line":"            self.assertEqual(nif, self.node.network_interface)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c01cf46c","line":216,"updated":"2016-08-02 16:08:17.000000000","message":"ditto","commit_id":"cedff4e3780191f6d43d5ccfa6a1a363c728d859"}]}