)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a5269842a9954f085930347ec7e72e1d70f19725","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _refresh_clean_steps(self, task):"},{"line_number":253,"context_line":"        \"\"\"Refresh the node\u0027s cached clean steps from the booted agent."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        Gets the node\u0027s clean steps from the booted agent and caches them."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dc0302b7","line":252,"range":{"start_line":252,"start_character":8,"end_line":252,"end_character":28},"updated":"2016-08-03 16:15:32.000000000","message":"this big utility might deserve its own timer","commit_id":"3a583f44f07929d2750c6d12fc0e04898b3f277f"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3ca86281d6d8e6991fa3019226f83773a82de866","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _refresh_clean_steps(self, task):"},{"line_number":253,"context_line":"        \"\"\"Refresh the node\u0027s cached clean steps from the booted agent."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        Gets the node\u0027s clean steps from the booted agent and caches them."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5c9f1203","line":252,"range":{"start_line":252,"start_character":8,"end_line":252,"end_character":28},"in_reply_to":"bacf61ea_dc0302b7","updated":"2016-08-03 16:24:20.000000000","message":"I\u0027ve avoided metric\u0027ing private methods... I could break that pattern for this if we thought it was really needed.","commit_id":"3a583f44f07929d2750c6d12fc0e04898b3f277f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"903dde283bbd51d85a57a0eb7964778181bd0f3a","unresolved":false,"context_lines":[{"line_number":614,"context_line":"            msg \u003d _(\u0027Failed to continue agent deployment.\u0027)"},{"line_number":615,"context_line":"            log_and_raise_deployment_error(task, msg)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.configure_local_boot\u0027)"},{"line_number":618,"context_line":"    def configure_local_boot(self, task, root_uuid\u003dNone,"},{"line_number":619,"context_line":"                             efi_system_part_uuid\u003dNone):"},{"line_number":620,"context_line":"        \"\"\"Helper method to configure local boot on the node."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_027877c3","line":617,"range":{"start_line":617,"start_character":4,"end_line":617,"end_character":59},"updated":"2016-08-04 06:49:56.000000000","message":"Strange, this line is causing test failure. Testcase looks fine.\n\nhttp://logs.openstack.org/17/350317/2/check/gate-ironic-python27-db-ubuntu-xenial/a513afc/console.html#_2016-08-03_21_18_14_286232\n\nI tried, removing this line and then tests passes. Am I missing anything here?","commit_id":"3a583f44f07929d2750c6d12fc0e04898b3f277f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"baa8ccc90fba64dd37a39bb9b350aee189cbc043","unresolved":false,"context_lines":[{"line_number":614,"context_line":"            msg \u003d _(\u0027Failed to continue agent deployment.\u0027)"},{"line_number":615,"context_line":"            log_and_raise_deployment_error(task, msg)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.configure_local_boot\u0027)"},{"line_number":618,"context_line":"    def configure_local_boot(self, task, root_uuid\u003dNone,"},{"line_number":619,"context_line":"                             efi_system_part_uuid\u003dNone):"},{"line_number":620,"context_line":"        \"\"\"Helper method to configure local boot on the node."}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_99720ee2","line":617,"range":{"start_line":617,"start_character":4,"end_line":617,"end_character":59},"in_reply_to":"bacf61ea_027877c3","updated":"2016-08-04 11:44:02.000000000","message":"I think the decorator confuses mock, so the test should be changed to match the expectations. Nothing terrible though.","commit_id":"3a583f44f07929d2750c6d12fc0e04898b3f277f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"53bd238976e31698ebcbb7953d5559a34ea77cc2","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin._refresh_clean_steps\u0027)"},{"line_number":253,"context_line":"    def _refresh_clean_steps(self, task):"},{"line_number":254,"context_line":"        \"\"\"Refresh the node\u0027s cached clean steps from the booted agent."},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_0b24885d","line":252,"range":{"start_line":252,"start_character":37,"end_line":252,"end_character":57},"updated":"2016-08-08 08:02:42.000000000","message":"_refresh_clean_steps() is called in methods that are wrapped by @METRICS is it not enough? Why do we need to calculate timings only for _refresh_clean_steps()?","commit_id":"5c05f9ab5c440a8df51a486b2072ec71443b74ad"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cf91cb1055fad4ca5f862adf8a4ad0ab3a050e99","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin._refresh_clean_steps\u0027)"},{"line_number":253,"context_line":"    def _refresh_clean_steps(self, task):"},{"line_number":254,"context_line":"        \"\"\"Refresh the node\u0027s cached clean steps from the booted agent."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        Gets the node\u0027s clean steps from the booted agent and caches them."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_922b4730","line":253,"updated":"2016-08-09 08:16:20.000000000","message":"I guess this one is big enough on its own to measure it... I\u0027d go for measuring more imporant private methods fwiw","commit_id":"8af7429d6eec94ed4fedad0185a35b68e0b7dc87"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5e7860f5100aa8480b6ce08b7c1f5be8015b8cdf","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        \"\"\""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin._refresh_clean_steps\u0027)"},{"line_number":253,"context_line":"    def _refresh_clean_steps(self, task):"},{"line_number":254,"context_line":"        \"\"\"Refresh the node\u0027s cached clean steps from the booted agent."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        Gets the node\u0027s clean steps from the booted agent and caches them."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_6e7c1521","line":253,"updated":"2016-08-08 15:32:24.000000000","message":"I\u0027m still wondered why do this only for specific private method?","commit_id":"8af7429d6eec94ed4fedad0185a35b68e0b7dc87"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"53bd238976e31698ebcbb7953d5559a34ea77cc2","unresolved":false,"context_lines":[{"line_number":912,"context_line":"            self.deploy.prepare_instance_to_boot(task, root_uuid,"},{"line_number":913,"context_line":"                                                 efi_system_part_uuid)"},{"line_number":914,"context_line":"            configure_mock.assert_called_once_with("},{"line_number":915,"context_line":"                    self.deploy, task,"},{"line_number":916,"context_line":"                    root_uuid\u003droot_uuid,"},{"line_number":917,"context_line":"                    efi_system_part_uuid\u003defi_system_part_uuid)"},{"line_number":918,"context_line":"            boot_option_mock.assert_called_once_with(task.node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8bd99824","line":915,"updated":"2016-08-08 08:02:42.000000000","message":"pep8 error 8 spaces instead of 4:\n             configure_mock.assert_called_once_with(\n-                    self.deploy, task,\n-                    root_uuid\u003droot_uuid,\n-                    efi_system_part_uuid\u003defi_system_part_uuid)\n+                self.deploy, task, root_uuid\u003droot_uuid,\n+                efi_system_part_uuid\u003defi_system_part_uuid)\n             boot_option_mock.assert_called_once_with(task.node)","commit_id":"5c05f9ab5c440a8df51a486b2072ec71443b74ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"53bd238976e31698ebcbb7953d5559a34ea77cc2","unresolved":false,"context_lines":[{"line_number":946,"context_line":"            self.assertRaises(exception.InstanceDeployFailure,"},{"line_number":947,"context_line":"                              self.deploy.prepare_instance_to_boot, task,"},{"line_number":948,"context_line":"                              root_uuid, efi_system_part_uuid)"},{"line_number":949,"context_line":"            configure_mock.assert_called_once_with("},{"line_number":950,"context_line":"                    self.deploy, task,"},{"line_number":951,"context_line":"                    root_uuid\u003droot_uuid,"},{"line_number":952,"context_line":"                    efi_system_part_uuid\u003defi_system_part_uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cb05507a","line":949,"updated":"2016-08-08 08:02:42.000000000","message":"ditto:\n             configure_mock.assert_called_once_with(\n-                    self.deploy, task,\n-                    root_uuid\u003droot_uuid,\n-                    efi_system_part_uuid\u003defi_system_part_uuid)\n+                self.deploy, task, root_uuid\u003droot_uuid,\n+                efi_system_part_uuid\u003defi_system_part_uuid)\n             boot_option_mock.assert_called_once_with(task.node)","commit_id":"5c05f9ab5c440a8df51a486b2072ec71443b74ad"}]}
