)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"91a634fea7e014f72e514cb415b95b0f2d382dac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangjl \u003czhangjl@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-03 06:33:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Installation Guide doc code is out of date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following the doc in install-guide,"},{"line_number":10,"context_line":"some code is out of date. Code changed frequently,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_fa6303af","line":7,"updated":"2016-08-05 10:20:08.000000000","message":"Please make this what is actually done in this change, not what the bug is.","commit_id":"e9b1ffbfb128d76720387a78695dee410ad9291d"},{"author":{"_account_id":3211,"name":"zhangjialong","email":"zhangjl@awcloud.com","username":"zhangjl"},"change_message_id":"619ed186c183b08fd8d4906658096e4c41d139b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangjl \u003czhangjl@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-03 06:33:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Installation Guide doc code is out of date"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following the doc in install-guide,"},{"line_number":10,"context_line":"some code is out of date. Code changed frequently,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_3543ec14","line":7,"in_reply_to":"bacf61ea_fa6303af","updated":"2016-08-05 10:38:27.000000000","message":"Done","commit_id":"e9b1ffbfb128d76720387a78695dee410ad9291d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"91a634fea7e014f72e514cb415b95b0f2d382dac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Following the doc in install-guide,"},{"line_number":10,"context_line":"some code is out of date. Code changed frequently,"},{"line_number":11,"context_line":"but doc not, for better tutorial we should modify"},{"line_number":12,"context_line":"the code in doc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1608916"},{"line_number":15,"context_line":"Signed-off-by: zhangjl \u003czhangjl@awcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_3a5abbf2","line":12,"updated":"2016-08-05 10:20:08.000000000","message":"Please make this what is actually done in this change, not what the bug is.","commit_id":"e9b1ffbfb128d76720387a78695dee410ad9291d"},{"author":{"_account_id":3211,"name":"zhangjialong","email":"zhangjl@awcloud.com","username":"zhangjl"},"change_message_id":"619ed186c183b08fd8d4906658096e4c41d139b7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Following the doc in install-guide,"},{"line_number":10,"context_line":"some code is out of date. Code changed frequently,"},{"line_number":11,"context_line":"but doc not, for better tutorial we should modify"},{"line_number":12,"context_line":"the code in doc."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1608916"},{"line_number":15,"context_line":"Signed-off-by: zhangjl \u003czhangjl@awcloud.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_d55250dd","line":12,"in_reply_to":"bacf61ea_3a5abbf2","updated":"2016-08-05 10:38:27.000000000","message":"Done","commit_id":"e9b1ffbfb128d76720387a78695dee410ad9291d"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"967c545861ba44e19a530a86ab03028aa641b555","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following the doc in install-guide, some code is out of date."},{"line_number":10,"context_line":"First, according to http://docs.openstack.org/mitaka/install-guide-rdo/,"},{"line_number":11,"context_line":"maybe, it`s better to using v3 commands replace the olds in creating"},{"line_number":12,"context_line":"endpoints."},{"line_number":13,"context_line":"Second, add xinetd package in install requirements."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_7677de02","line":11,"updated":"2016-08-08 10:30:16.000000000","message":"Nitpick: \"use v3 commands in place of the old ones\"","commit_id":"580c858c7c6f95e032105262ffc4b7f8bc3530a2"}],"doc/source/deploy/install-guide.rst":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"91a634fea7e014f72e514cb415b95b0f2d382dac","unresolved":false,"context_lines":[{"line_number":110,"context_line":"   and replace IRONIC_NODE with your Bare Metal service\u0027s API node::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":113,"context_line":"    baremetal admin http://IRONIC_NODE:6385"},{"line_number":114,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":115,"context_line":"    baremetal public http://IRONIC_NODE:6385"},{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_fa3ca394","line":113,"updated":"2016-08-05 10:20:08.000000000","message":"The old code works for me; the new code doesn\u0027t actually work, in my testing:\n\nstack@jroll-devstack:~$ openstack endpoint create --region RegionOne baremetal admin http://xxxxx:6385 \nusage: openstack endpoint create [-h] [-f {json,shell,table,value,yaml}]\n                                 [-c COLUMN] [--max-width \u003cinteger\u003e]\n                                 [--noindent] [--prefix PREFIX] --publicurl\n                                 \u003curl\u003e [--adminurl \u003curl\u003e]\n                                 [--internalurl \u003curl\u003e] [--region \u003cregion-id\u003e]\n                                 \u003cservice\u003e\nopenstack endpoint create: error: argument --publicurl is required","commit_id":"e9b1ffbfb128d76720387a78695dee410ad9291d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"05748a6bdb96009401df70abe9d247e9b0a642b2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"   and replace IRONIC_NODE with your Bare Metal service\u0027s API node::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":113,"context_line":"    baremetal admin http://IRONIC_NODE:6385"},{"line_number":114,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":115,"context_line":"    baremetal public http://IRONIC_NODE:6385"},{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_55e4a0de","line":113,"updated":"2016-08-05 10:43:03.000000000","message":"Copying my comment back from the previous version...\n\nThe old code works for me; the new code doesn\u0027t actually work, in my testing:\n\nstack@jroll-devstack:~$ openstack endpoint create --region RegionOne baremetal admin http://xxxxx:6385 \nusage: openstack endpoint create [-h] [-f {json,shell,table,value,yaml}]\n                                 [-c COLUMN] [--max-width \u003cinteger\u003e]\n                                 [--noindent] [--prefix PREFIX] --publicurl\n                                 \u003curl\u003e [--adminurl \u003curl\u003e]\n                                 [--internalurl \u003curl\u003e] [--region \u003cregion-id\u003e]\n                                 \u003cservice\u003e\nopenstack endpoint create: error: argument --publicurl is required","commit_id":"6e402c12897748782ee71c9f73094704347b6162"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a450cd975042bf474bf54aa30c4f0ea813adad8a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"   and replace IRONIC_NODE with your Bare Metal service\u0027s API node::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":113,"context_line":"    baremetal admin http://IRONIC_NODE:6385"},{"line_number":114,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":115,"context_line":"    baremetal public http://IRONIC_NODE:6385"},{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_10acaaec","line":113,"in_reply_to":"9ad45d7e_eaaac784","updated":"2016-08-08 09:39:48.000000000","message":"Hi @Zhangjl,\n\nI agree with @Jim here, can you split this in two please? One for v2 (old commands) and one for v3.\n\nI also tried it locally here in a instack installation (built with tripleo-quickstart) and it fails with the same error. Log: http://paste.openstack.org/show/551989/","commit_id":"6e402c12897748782ee71c9f73094704347b6162"},{"author":{"_account_id":3211,"name":"zhangjialong","email":"zhangjl@awcloud.com","username":"zhangjl"},"change_message_id":"a2591cb1fe72d8366c935420b26ed0c9a5fa7f6a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"   and replace IRONIC_NODE with your Bare Metal service\u0027s API node::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":113,"context_line":"    baremetal admin http://IRONIC_NODE:6385"},{"line_number":114,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":115,"context_line":"    baremetal public http://IRONIC_NODE:6385"},{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_753d642a","line":113,"in_reply_to":"bacf61ea_55e4a0de","updated":"2016-08-05 10:43:57.000000000","message":"According to http://docs.openstack.org/mitaka/install-guide-rdo/,\nmaybe, it`s better to using v3 commands replace the olds in creating endpoints.","commit_id":"6e402c12897748782ee71c9f73094704347b6162"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"e4568136de449bb891f4c46099de4a9fd003a04b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"   and replace IRONIC_NODE with your Bare Metal service\u0027s API node::"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":113,"context_line":"    baremetal admin http://IRONIC_NODE:6385"},{"line_number":114,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":115,"context_line":"    baremetal public http://IRONIC_NODE:6385"},{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad45d7e_eaaac784","line":113,"in_reply_to":"bacf61ea_753d642a","updated":"2016-08-08 09:14:04.000000000","message":"Okay, I guess you\u0027re right: http://docs.openstack.org/developer/python-openstackclient/command-objects/endpoint.html#endpoint-create\n\nSome people still run v2, though. Perhaps make this change, and below it add something like \"if only keystone v2 API is available, use these commands instead:: openstack endpoint create...\"","commit_id":"6e402c12897748782ee71c9f73094704347b6162"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4b96aa71133e1ba5c4613e53ddc60512c3fabde1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":117,"context_line":"    baremetal internal http://IRONIC_NODE:6385"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   If only keystone v2 API is available, use this commands instead::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"    --publicurl http://IRONIC_NODE:6385 \\"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad45d7e_96e1b2d3","line":119,"updated":"2016-08-08 10:25:22.000000000","message":"s/commands/command/ :)","commit_id":"26f5d9b92f232f963c746995672a06eb902447f2"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"d3cc422f7843aa1157bf838f5a83ddc2b9a58d1d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":117,"context_line":"    baremetal internal http://IRONIC_NODE:6385"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   If only keystone v2 API is available, use this commands instead::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"    --publicurl http://IRONIC_NODE:6385 \\"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9ad45d7e_61d8ba1e","line":119,"updated":"2016-08-08 10:46:49.000000000","message":"Nitpick: \"this command\"","commit_id":"6e5632e472556715b8359e1a7af36b878cd8ff39"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9f59cfac31ebc52046c33985701df2f07337808d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":117,"context_line":"    baremetal internal http://IRONIC_NODE:6385"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   If only keystone v2 API is available, use this commands instead::"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"    --publicurl http://IRONIC_NODE:6385 \\"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9ad45d7e_413f7625","line":119,"range":{"start_line":119,"start_character":50,"end_line":119,"end_character":58},"updated":"2016-08-08 10:47:33.000000000","message":"s/commands/command\n\nThe previous patch-set (#6) was correct.","commit_id":"6e5632e472556715b8359e1a7af36b878cd8ff39"}]}
