)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c4e4d63e0162fc0a4627d8d046ff7d69239c9862","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding follow-up patch for audit middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing nits of audit middleware changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib073598cea1e9acc9788e2db85f814f0295134ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_d1ab8173","line":9,"updated":"2016-08-11 08:17:00.000000000","message":"I would like to see here exact changes that were done by this patch.","commit_id":"a4cdc543e0bf33eb8fd9dd1a0c358ce4b36db017"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"51488818d4221e6865c8d2e9436027ac06c2ec2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding follow-up patch for audit middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing nits of audit middleware changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib073598cea1e9acc9788e2db85f814f0295134ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_826a59b1","line":9,"in_reply_to":"9ad45d7e_d1ab8173","updated":"2016-08-11 09:03:24.000000000","message":"Done","commit_id":"a4cdc543e0bf33eb8fd9dd1a0c358ce4b36db017"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b77f6d85b7c27df51c0a9646d606a9115103bb6e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lokesh S \u003clokesh.s@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-12 07:12:47 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding follow-up patch for audit middleware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing nits mentioned in previous patch"},{"line_number":10,"context_line":"https://review.openstack.org/272658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_c71fdfb5","line":7,"updated":"2016-08-12 16:50:45.000000000","message":"Instead of saying follow-up, please describe what is being done.\nMaybe:\n Documentation updates for the audit middleware\n\nOr something else :)","commit_id":"21af6b1434de5e4fe3a69ba024a02f5615ef70fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"12faf0862f434beb25dafe5116d54673683ee4ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Renaming ironic_api_audit_map.conf.sample file"},{"line_number":12,"context_line":"fixing doc --\u003e changing to [oslo_messaging_notifications]"},{"line_number":13,"context_line":"/driver as notification_driver is deprecated"},{"line_number":14,"context_line":"fixing nits in api_audit_map.conf.sample path_keywords"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib073598cea1e9acc9788e2db85f814f0295134ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a98d1f4_40181285","line":14,"updated":"2016-09-28 21:27:59.000000000","message":"I don\u0027t understand this. Maybe if you used bullets or clearly identified the sentences -- where the sentence starts and ends?\n\nJust looking at the code and it looks like you changed the default value for a configuration option -- which I should is worth mentioning in the commit message but I don\u0027t see it mentioned here.","commit_id":"47282f5eef6addee0a39cebb61ed55319f06d195"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7bce2d0ad85ebec6c3e8d958b223a0bb59ec00bd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Renaming audit map conf sample file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing nits mentioned in previous patch"},{"line_number":10,"context_line":"https://review.openstack.org/272658"},{"line_number":11,"context_line":"* Renaming ironic_api_audit_map.conf.sample file to"},{"line_number":12,"context_line":"api_audit_map.conf.sample"},{"line_number":13,"context_line":"* Doc change --\u003e changing to [oslo_messaging_notifications]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a74a57a_766ac0ef","line":10,"updated":"2016-11-25 20:03:16.000000000","message":"nit: typically we encourage people just to use the change-id since it would be tracked by gerrit if we were to back port something like this.","commit_id":"c80e78b42b62200f9aebeaff5678adc6bb197e3a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"002bc08ccb1b628989e3503de8f7af663cfe1913","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Renaming audit map conf sample file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixing nits mentioned in previous patch"},{"line_number":10,"context_line":"https://review.openstack.org/272658"},{"line_number":11,"context_line":"* Renaming ironic_api_audit_map.conf.sample file to"},{"line_number":12,"context_line":"api_audit_map.conf.sample"},{"line_number":13,"context_line":"* Doc change --\u003e changing to [oslo_messaging_notifications]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a71b18c_84f2f9d0","line":10,"in_reply_to":"5a74a57a_766ac0ef","updated":"2016-12-02 16:29:09.000000000","message":"or commit id, it can be tracked even by partial commit id both in gerrit and in hitsory","commit_id":"c80e78b42b62200f9aebeaff5678adc6bb197e3a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7bce2d0ad85ebec6c3e8d958b223a0bb59ec00bd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fixing nits mentioned in previous patch"},{"line_number":10,"context_line":"https://review.openstack.org/272658"},{"line_number":11,"context_line":"* Renaming ironic_api_audit_map.conf.sample file to"},{"line_number":12,"context_line":"api_audit_map.conf.sample"},{"line_number":13,"context_line":"* Doc change --\u003e changing to [oslo_messaging_notifications]"},{"line_number":14,"context_line":"/driver as notification_driver is deprecated"},{"line_number":15,"context_line":"* Renaming path_keyword vendor_passthru in api_audit_map.conf.sample"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a74a57a_1680ac8a","line":12,"updated":"2016-11-25 20:03:16.000000000","message":"More readable, but you may want to have started the wrapped portion of the line off with two spaces of indentation to start at the same point as the text from the above line.  That way it would have been more readable.","commit_id":"c80e78b42b62200f9aebeaff5678adc6bb197e3a"}],"doc/source/deploy/api-audit-support.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e2e4df45b0205040c717b15a1840f2db911ec93","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Audit middleware supports delivery of CADF audit events via Oslo messaging"},{"line_number":7,"context_line":"notifier capability. Based on `notification_driver` configuration, audit events"},{"line_number":8,"context_line":"can be routed to messaging infrastructure (notification_driver \u003d messagingv2)"},{"line_number":9,"context_line":"or can be routed to a log file ([oslo_messaging_notifications]/driver \u003d log)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Audit middleware creates two events per REST API interaction. First event has"},{"line_number":12,"context_line":"information extracted from request data and the second one has request outcome"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3ac371cc_c64f1090","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":75},"updated":"2016-08-18 14:44:31.000000000","message":"please enclose this in ````","commit_id":"3a5535dccd0c8f2f05e98eca07d5923a219140be"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"416730eacf4544830f0ca194ed831f9282f16679","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Audit middleware supports delivery of CADF audit events via Oslo messaging"},{"line_number":7,"context_line":"notifier capability. Based on `notification_driver` configuration, audit events"},{"line_number":8,"context_line":"can be routed to messaging infrastructure (notification_driver \u003d messagingv2)"},{"line_number":9,"context_line":"or can be routed to a log file ([oslo_messaging_notifications]/driver \u003d log)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Audit middleware creates two events per REST API interaction. First event has"},{"line_number":12,"context_line":"information extracted from request data and the second one has request outcome"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3ac371cc_4a3037e9","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":75},"in_reply_to":"3ac371cc_c64f1090","updated":"2016-08-18 17:21:00.000000000","message":"Done","commit_id":"3a5535dccd0c8f2f05e98eca07d5923a219140be"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b77f6d85b7c27df51c0a9646d606a9115103bb6e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"# The time-to-live in sec of idle connections in the pool"},{"line_number":255,"context_line":"# (integer value)"},{"line_number":256,"context_line":"#conn_pool_ttl \u003d 1200"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"# ZeroMQ bind address. Should be a wildcard (*), an ethernet"},{"line_number":259,"context_line":"# interface, or IP. The \"host\" option should point or resolve"},{"line_number":260,"context_line":"# to this address. (string value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9ad45d7e_a71c6bc2","side":"PARENT","line":257,"updated":"2016-08-12 16:50:45.000000000","message":"This large amount of deletions of the conf sample seems wrong to me","commit_id":"cd12d0b538a14b69280b66441bd17806a1067e77"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"77c356defc0cf34107796d1869786f46cd34abbd","unresolved":false,"context_lines":[{"line_number":254,"context_line":"# The time-to-live in sec of idle connections in the pool"},{"line_number":255,"context_line":"# (integer value)"},{"line_number":256,"context_line":"#conn_pool_ttl \u003d 1200"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"# ZeroMQ bind address. Should be a wildcard (*), an ethernet"},{"line_number":259,"context_line":"# interface, or IP. The \"host\" option should point or resolve"},{"line_number":260,"context_line":"# to this address. (string value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"3ac371cc_ec7c58ed","side":"PARENT","line":257,"in_reply_to":"9ad45d7e_a71c6bc2","updated":"2016-08-16 05:55:56.000000000","message":"It is generated by tox. I regenerated and see same changes.","commit_id":"cd12d0b538a14b69280b66441bd17806a1067e77"}],"releasenotes/notes/adding-audit-middleware-b95f2a00baed9750.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c4e4d63e0162fc0a4627d8d046ff7d69239c9862","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * ``[audit]/audit_map_file``"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    Further documentation for this feature is available at"},{"line_number":13,"context_line":"    http://docs.openstack.org/developer/ironic/deploy/api-audit-support.html."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_518031f7","line":13,"updated":"2016-08-11 08:17:00.000000000","message":"please add a space between link and dot, since it is rendered as not valid link","commit_id":"a4cdc543e0bf33eb8fd9dd1a0c358ce4b36db017"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"51488818d4221e6865c8d2e9436027ac06c2ec2f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * ``[audit]/audit_map_file``"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    Further documentation for this feature is available at"},{"line_number":13,"context_line":"    http://docs.openstack.org/developer/ironic/deploy/api-audit-support.html."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_c260d1d1","line":13,"in_reply_to":"9ad45d7e_518031f7","updated":"2016-08-11 09:03:24.000000000","message":"Done","commit_id":"a4cdc543e0bf33eb8fd9dd1a0c358ce4b36db017"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e2e4df45b0205040c717b15a1840f2db911ec93","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ironic-api service now supports logging audit messages of"},{"line_number":5,"context_line":"    api calls. The following configuration parameters have been added."},{"line_number":6,"context_line":"    By default audit logging for ironic-api service is turned off."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * ``[audit]/enabled``"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_66057c44","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"updated":"2016-08-18 14:44:31.000000000","message":"I\u0027d prefer API actually","commit_id":"3a5535dccd0c8f2f05e98eca07d5923a219140be"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"416730eacf4544830f0ca194ed831f9282f16679","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ironic-api service now supports logging audit messages of"},{"line_number":5,"context_line":"    api calls. The following configuration parameters have been added."},{"line_number":6,"context_line":"    By default audit logging for ironic-api service is turned off."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * ``[audit]/enabled``"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_6a61b3d3","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":7},"in_reply_to":"3ac371cc_66057c44","updated":"2016-08-18 17:21:00.000000000","message":"Done","commit_id":"3a5535dccd0c8f2f05e98eca07d5923a219140be"}]}
