)]}'
{"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":15907,"name":"Wei Hui","email":"huiweics@gmail.com","username":"huiweics"},"change_message_id":"8fd71cdee28bea56ea09bd6ccc2c3a404f637c56","unresolved":false,"context_lines":[{"line_number":1245,"context_line":"# This option is deprecated for removal."},{"line_number":1246,"context_line":"# Its value may be silently ignored in the future."},{"line_number":1247,"context_line":"# Reason: This option was moved to swift_image_store section"},{"line_number":1248,"context_line":"# which is more appropriate for itPlease use api_version in"},{"line_number":1249,"context_line":"# new section instead"},{"line_number":1250,"context_line":"#swift_account \u003d \u003cNone\u003e"},{"line_number":1251,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":50,"id":"ba5da102_681c0f78","line":1248,"updated":"2016-11-05 07:35:13.000000000","message":"lack blank","commit_id":"2b1b49bd142e8a238be4843922512815f4a83606"}],"ironic/common/glance_service/base_image_service.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8f8e1e3ef514f24105c4a796a12a9b0ce1275861","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if CONF.glance.auth_strategy \u003d\u003d \u0027keystone\u0027:"},{"line_number":96,"context_line":"            params[\u0027token\u0027] \u003d self.context.auth_token"},{"line_number":97,"context_line":"        endpoint \u003d \u0027%s://%s:%s\u0027 % (scheme, self.glance_host, self.glance_port)"},{"line_number":98,"context_line":"        self.client \u003d glance_client.Client(self.version,"},{"line_number":99,"context_line":"                                    endpoint, **params)"},{"line_number":100,"context_line":"        return func(self, *args, **kwargs)"},{"line_number":101,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":36,"id":"5a8bc5a2_91d670ef","line":98,"updated":"2016-09-26 11:00:24.000000000","message":"The reason of all the failures you see - the admin token generation was removed if it is not present in the context, which is the case for all requests originating from conductor itself, like checking image metadata. So you need to use the session you have here in the glance client constructor.","commit_id":"2e5a35191e1df8d4a2276ade6d29c6fd16b9a37e"}],"ironic/common/image_service.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"967a0dc1d3abe37b2a5066ec8f11882c101c4b61","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    session \u003d None"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if CONF.swift_image_store.auth_type \u003d\u003d \u0027password\u0027 and context is not None:"},{"line_number":69,"context_line":"        session \u003d _get_swift_session()"},{"line_number":70,"context_line":"    if session:"},{"line_number":71,"context_line":"        context.auth_token \u003d keystone.get_admin_auth_token(session)"},{"line_number":72,"context_line":"        return service_class(client, version, context, session)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_e8434640","line":69,"updated":"2016-09-16 07:52:33.000000000","message":"that\u0027s wrong. You are always creating the _swift_session for the Glance, but we use GlanceImageService to also fetch images from Glance, so that has to use the creds from [glance] section\n\nit seems that we\u0027d have to store two sessions for this, and modify the swift related parts to use swift session instead.\n\nQuite probably that would require rewriting the whole GlanceImageService code to instantiate glance client with session (the right way) instead of tokens.","commit_id":"ebcf1b041c89f58df97aee88f9c0bb5bc44cbc6e"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"9623fc1c14773d05bae3d24b9a7cbb4973df19a8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    session \u003d None"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if CONF.swift_image_store.auth_type \u003d\u003d \u0027password\u0027 and context is not None:"},{"line_number":69,"context_line":"        session \u003d _get_swift_session()"},{"line_number":70,"context_line":"    if session:"},{"line_number":71,"context_line":"        context.auth_token \u003d keystone.get_admin_auth_token(session)"},{"line_number":72,"context_line":"        return service_class(client, version, context, session)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_a11ae6c3","line":69,"in_reply_to":"7a8ec9b2_e8434640","updated":"2016-09-19 09:18:07.000000000","message":"Thank you for your review. I am working on it","commit_id":"ebcf1b041c89f58df97aee88f9c0bb5bc44cbc6e"}],"ironic/common/swift.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c7a3e4c6cac66a02e3efe70b234b0d7d61f0e63e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return CONF.swift_image_store.container"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# old method"},{"line_number":77,"context_line":"def get_temp_url(image_id):"},{"line_number":78,"context_line":"    url_fragments \u003d {"},{"line_number":79,"context_line":"        \u0027api_version\u0027: (CONF.swift_image_store.api_version or"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_80e2e0d3","line":76,"updated":"2016-08-15 16:46:06.000000000","message":"What is this comment for?","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"8899d9faaf583b8025814acc7445ea9639be58bd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return CONF.swift_image_store.container"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# old method"},{"line_number":77,"context_line":"def get_temp_url(image_id):"},{"line_number":78,"context_line":"    url_fragments \u003d {"},{"line_number":79,"context_line":"        \u0027api_version\u0027: (CONF.swift_image_store.api_version or"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_5251bad7","line":76,"in_reply_to":"3ac371cc_80e2e0d3","updated":"2016-08-16 09:19:01.000000000","message":"Done","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fd70bc9a69508182a53d636df981a9b265e85401","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# old method"},{"line_number":77,"context_line":"def get_temp_url(image_id):"},{"line_number":78,"context_line":"    url_fragments \u003d {"},{"line_number":79,"context_line":"        \u0027api_version\u0027: (CONF.swift_image_store.api_version or"},{"line_number":80,"context_line":"                        CONF.glance.swift_api_version),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_fd225db8","line":77,"updated":"2016-08-15 16:38:53.000000000","message":"Why do you need it here?","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"6fc4996978ec7c2efad5d422b95b78c09c39a8bc","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# old method"},{"line_number":77,"context_line":"def get_temp_url(image_id):"},{"line_number":78,"context_line":"    url_fragments \u003d {"},{"line_number":79,"context_line":"        \u0027api_version\u0027: (CONF.swift_image_store.api_version or"},{"line_number":80,"context_line":"                        CONF.glance.swift_api_version),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_229677f0","line":77,"in_reply_to":"3ac371cc_fd225db8","updated":"2016-08-16 07:11:58.000000000","message":"Methods related to swift in any way should be gathered in the swift module as mentioned here https://bugs.launchpad.net/ironic/+bug/1521197","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"}],"ironic/conf/glance.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fd70bc9a69508182a53d636df981a9b265e85401","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # radosgw-admin user modify --uid\u003duser --temp-url-key\u003dsecretkey"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027swift_temp_url_key\u0027,"},{"line_number":35,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":36,"context_line":"               deprecated_reason\u003d\u0027This option was moved to swift_image_store \u0027"},{"line_number":37,"context_line":"                                 \u0027section which is more appropriate for it.\u0027"},{"line_number":38,"context_line":"                                 \u0027Please use temp_url_key in new section \u0027"},{"line_number":39,"context_line":"                                 \u0027instead\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_7d8dcd30","line":36,"updated":"2016-08-15 16:38:53.000000000","message":"I think there is no need in doing this - you can just delete them, as you have the deprecated_group/deprecated_name on the new options, they will be able to accept the values from old place. The deprecation warning will be emitted too.","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"}],"ironic/conf/swift_image_store.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fd70bc9a69508182a53d636df981a9b265e85401","unresolved":false,"context_lines":[{"line_number":129,"context_line":"               choices\u003d[\u0027swift\u0027, \u0027radosgw\u0027],"},{"line_number":130,"context_line":"               help\u003d_(\u0027Type of endpoint to use for temporary URLs. If the \u0027"},{"line_number":131,"context_line":"                      \u0027Glance backend is Swift, use \"swift\"; if it is CEPH \u0027"},{"line_number":132,"context_line":"                      \u0027with RADOS gateway, use \"radosgw\".\u0027)),"},{"line_number":133,"context_line":"    cfg.StrOpt(\u0027swift_cacert\u0027,"},{"line_number":134,"context_line":"               help\u003d_(\u0027A string giving the CA certificate file to use in \u0027"},{"line_number":135,"context_line":"                      \u0027SSL connections for verifying certs.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_bdf8e5e6","line":132,"updated":"2016-08-15 16:38:53.000000000","message":"I think you can drop the swift prefix everywhere.","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"8899d9faaf583b8025814acc7445ea9639be58bd","unresolved":false,"context_lines":[{"line_number":129,"context_line":"               choices\u003d[\u0027swift\u0027, \u0027radosgw\u0027],"},{"line_number":130,"context_line":"               help\u003d_(\u0027Type of endpoint to use for temporary URLs. If the \u0027"},{"line_number":131,"context_line":"                      \u0027Glance backend is Swift, use \"swift\"; if it is CEPH \u0027"},{"line_number":132,"context_line":"                      \u0027with RADOS gateway, use \"radosgw\".\u0027)),"},{"line_number":133,"context_line":"    cfg.StrOpt(\u0027swift_cacert\u0027,"},{"line_number":134,"context_line":"               help\u003d_(\u0027A string giving the CA certificate file to use in \u0027"},{"line_number":135,"context_line":"                      \u0027SSL connections for verifying certs.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_92e052ce","line":132,"in_reply_to":"3ac371cc_bdf8e5e6","updated":"2016-08-16 09:19:01.000000000","message":"Done","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"fd70bc9a69508182a53d636df981a9b265e85401","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def register_opts(conf):"},{"line_number":146,"context_line":"    conf.register_opts(opts, group\u003d\u0027swift_image_store\u0027)"},{"line_number":147,"context_line":"    auth.register_auth_opts(conf, \u0027swift_image_store\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_1d977991","line":146,"updated":"2016-08-15 16:38:53.000000000","message":"We already have swift section, why add another one?","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"8899d9faaf583b8025814acc7445ea9639be58bd","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def register_opts(conf):"},{"line_number":146,"context_line":"    conf.register_opts(opts, group\u003d\u0027swift_image_store\u0027)"},{"line_number":147,"context_line":"    auth.register_auth_opts(conf, \u0027swift_image_store\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_3df7b8f6","line":146,"in_reply_to":"3ac371cc_1d977991","updated":"2016-08-16 09:19:01.000000000","message":"This bunch of options were in glance section which is irrelevant because they are related to swift. The first version of patch is planned like that: to gather swift-related options in a separate place and think where to put these options indeed","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"7a610646f7a25caa9bc398f6d0e82f13b1f0ad6b","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def register_opts(conf):"},{"line_number":146,"context_line":"    conf.register_opts(opts, group\u003d\u0027swift_image_store\u0027)"},{"line_number":147,"context_line":"    auth.register_auth_opts(conf, \u0027swift_image_store\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_bbb9e6cd","line":146,"in_reply_to":"3ac371cc_3df7b8f6","updated":"2016-08-16 11:16:18.000000000","message":"Vlad, there are two distinct swift \"users\" and use-cases involved - 1) the Ironic creating and managing objects/containers in Swift (configdrive, iLO) and 2) the user Glance is using to put images as objects in Swift, and Ironic through a bunch of config options tries to guess where they are stored. [swift] section is for the first case, [swift_image_store] is planned for the second, especially if we decide that it would be better to supply the actual user credentials instead of access part of the URL.","commit_id":"b74cc8372658c0c55b030d5cb607b331f2ca70df"}],"ironic/tests/unit/common/test_glance_service.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bd046c83e614de7ce2dff5f422b9134e63eed238","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.config(glance_host\u003d\u0027localhost\u0027, group\u003d\u0027glance\u0027)"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            self.config(auth_strategy\u003d\u0027keystone\u0027,"},{"line_number":110,"context_line":"                        group\u003d\u0027glance\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_3862a80a","line":109,"updated":"2016-08-23 17:31:41.000000000","message":"Why is this line changed?","commit_id":"2a823d03412a96b67064e9c360fced76298bf689"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"bd046c83e614de7ce2dff5f422b9134e63eed238","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self.assertEqual(0, num_images)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        ids \u003d []"},{"line_number":365,"context_line":"        for fixt in fixtures:"},{"line_number":366,"context_line":"            new_id \u003d self.service.create(fixt)[\u0027id\u0027]"},{"line_number":367,"context_line":"            ids.append(new_id)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_f83ad0e5","line":365,"updated":"2016-08-23 17:31:41.000000000","message":"Why is this changed?","commit_id":"2a823d03412a96b67064e9c360fced76298bf689"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"54b4e85a884c5ec33b5c6e7bdcc0a659f30b280b","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        self.assertEqual(0, num_images)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        ids \u003d []"},{"line_number":365,"context_line":"        for fixt in fixtures:"},{"line_number":366,"context_line":"            new_id \u003d self.service.create(fixt)[\u0027id\u0027]"},{"line_number":367,"context_line":"            ids.append(new_id)"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_85d367d4","line":365,"in_reply_to":"1ac06dbe_f83ad0e5","updated":"2016-08-23 22:13:16.000000000","message":"when tried to use keystone sessions the module called fixture was used and this variable was redefined. It was against pep8 rules. I think that for now it is safer to call variable not as the name of module anyway to avoid such mistakes in the future when the module called fixture will be used","commit_id":"2a823d03412a96b67064e9c360fced76298bf689"}]}
