)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4441cb5e031ad341317d58fd115df92608e3ba05","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                    state\u003dtask.node.provision_state)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":546,"context_line":"    def _do_node_tear_down(self, task):"},{"line_number":547,"context_line":"        \"\"\"Internal RPC method to tear down an existing node deployment.\"\"\""},{"line_number":548,"context_line":"        node \u003d task.node"},{"line_number":549,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_4ed044f8","line":546,"updated":"2016-08-18 19:42:26.000000000","message":"Aren\u0027t these more interesting wrt metrics gathering? This is where the real work is...","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"fc773778ec75488ce101d7aefbd94b2c6f3fec06","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                    state\u003dtask.node.provision_state)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":546,"context_line":"    def _do_node_tear_down(self, task):"},{"line_number":547,"context_line":"        \"\"\"Internal RPC method to tear down an existing node deployment.\"\"\""},{"line_number":548,"context_line":"        node \u003d task.node"},{"line_number":549,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_8df10204","line":546,"in_reply_to":"3ac371cc_4ed044f8","updated":"2016-08-29 13:12:37.000000000","message":"++++","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2f587587a1febb7af0f0d85e719de228d6e4a7b2","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                    state\u003dtask.node.provision_state)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":546,"context_line":"    def _do_node_tear_down(self, task):"},{"line_number":547,"context_line":"        \"\"\"Internal RPC method to tear down an existing node deployment.\"\"\""},{"line_number":548,"context_line":"        node \u003d task.node"},{"line_number":549,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_aa1f7e6a","line":546,"in_reply_to":"fa7ab95a_8df10204","updated":"2016-08-29 18:13:12.000000000","message":"The main reason I didn\u0027t metric this is because it\u0027s calling out to the driver, and will be metriced at that level. If you all think it\u0027s still worth doing, I can.","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4441cb5e031ad341317d58fd115df92608e3ba05","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                err_handler\u003dutils.provisioning_error_handler)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":1255,"context_line":"    def _do_adoption(self, task):"},{"line_number":1256,"context_line":"        \"\"\"Adopt the node."},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        Similar to node takeover, adoption performs a driver boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_0e0bec7e","line":1255,"updated":"2016-08-18 19:42:26.000000000","message":"wouldn\u0027t this be a good one to get timing info?","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"fc773778ec75488ce101d7aefbd94b2c6f3fec06","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                err_handler\u003dutils.provisioning_error_handler)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":1255,"context_line":"    def _do_adoption(self, task):"},{"line_number":1256,"context_line":"        \"\"\"Adopt the node."},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        Similar to node takeover, adoption performs a driver boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_6dd75e4b","line":1255,"in_reply_to":"3ac371cc_0e0bec7e","updated":"2016-08-29 13:12:37.000000000","message":"+1","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2f587587a1febb7af0f0d85e719de228d6e4a7b2","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"                err_handler\u003dutils.provisioning_error_handler)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":1255,"context_line":"    def _do_adoption(self, task):"},{"line_number":1256,"context_line":"        \"\"\"Adopt the node."},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        Similar to node takeover, adoption performs a driver boot"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_3d6bba86","line":1255,"in_reply_to":"fa7ab95a_6dd75e4b","updated":"2016-08-29 18:13:12.000000000","message":"Done","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4441cb5e031ad341317d58fd115df92608e3ba05","unresolved":false,"context_lines":[{"line_number":1628,"context_line":"                                 self._set_console_mode, task, enabled)"},{"line_number":1629,"context_line":""},{"line_number":1630,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":1631,"context_line":"    def _set_console_mode(self, task, enabled):"},{"line_number":1632,"context_line":"        \"\"\"Internal method to set console mode on a node.\"\"\""},{"line_number":1633,"context_line":"        node \u003d task.node"},{"line_number":1634,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_ae63b840","line":1631,"updated":"2016-08-18 19:42:26.000000000","message":"timing for this?","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2f587587a1febb7af0f0d85e719de228d6e4a7b2","unresolved":false,"context_lines":[{"line_number":1628,"context_line":"                                 self._set_console_mode, task, enabled)"},{"line_number":1629,"context_line":""},{"line_number":1630,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":1631,"context_line":"    def _set_console_mode(self, task, enabled):"},{"line_number":1632,"context_line":"        \"\"\"Internal method to set console mode on a node.\"\"\""},{"line_number":1633,"context_line":"        node \u003d task.node"},{"line_number":1634,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_9d2da697","line":1631,"in_reply_to":"3ac371cc_ae63b840","updated":"2016-08-29 18:13:12.000000000","message":"ditto to previous: The main reason I didn\u0027t metric this is because it\u0027s calling out to the driver, and will be metriced at that level. If you all think it\u0027s still worth doing, I can.","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"28692f01f5316778b8c4722a4788f3163c36849f","unresolved":false,"context_lines":[{"line_number":2394,"context_line":"        node.save()"},{"line_number":2395,"context_line":""},{"line_number":2396,"context_line":""},{"line_number":2397,"context_line":"@METRICS.timer(\u0027handle_sync_power_state_max_retries_exceeded\u0027)"},{"line_number":2398,"context_line":"@task_manager.require_exclusive_lock"},{"line_number":2399,"context_line":"def handle_sync_power_state_max_retries_exceeded(task, actual_power_state,"},{"line_number":2400,"context_line":"                                                 exception\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_76cb4373","line":2397,"updated":"2016-08-15 10:12:54.000000000","message":"dunno if this simple call requires metrics..","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2f587587a1febb7af0f0d85e719de228d6e4a7b2","unresolved":false,"context_lines":[{"line_number":2394,"context_line":"        node.save()"},{"line_number":2395,"context_line":""},{"line_number":2396,"context_line":""},{"line_number":2397,"context_line":"@METRICS.timer(\u0027handle_sync_power_state_max_retries_exceeded\u0027)"},{"line_number":2398,"context_line":"@task_manager.require_exclusive_lock"},{"line_number":2399,"context_line":"def handle_sync_power_state_max_retries_exceeded(task, actual_power_state,"},{"line_number":2400,"context_line":"                                                 exception\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_5d307ee8","line":2397,"in_reply_to":"3ac371cc_76cb4373","updated":"2016-08-29 18:13:12.000000000","message":"agreed, will remove","commit_id":"97cb04c465d6834c90da8230182db26d461f4286"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"5a1fd3e6cb1a10fe4f5b956a1a969a18b406e12d","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"    return \u0027configdrive-%s\u0027 % node.uuid"},{"line_number":2293,"context_line":""},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"def _store_configdrive(node, configdrive):"},{"line_number":2296,"context_line":"    \"\"\"Handle the storage of the config drive."},{"line_number":2297,"context_line":""},{"line_number":2298,"context_line":"    If configured, the config drive data are uploaded to Swift. The Node\u0027s"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_20ff7435","line":2295,"updated":"2016-08-31 15:59:46.000000000","message":"Why don\u0027t we time this?\n\nI can see why _get_configdrive_obj_name and some other functions from previous discussion aren\u0027t timed, but this calls out to an external service, so it may be useful to time independently of its caller.","commit_id":"c23cce33c08a5e89fba293f5430d20fef5702035"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"29933b08878134db2f5b8799698948702a7b3ce6","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"    return \u0027configdrive-%s\u0027 % node.uuid"},{"line_number":2293,"context_line":""},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"def _store_configdrive(node, configdrive):"},{"line_number":2296,"context_line":"    \"\"\"Handle the storage of the config drive."},{"line_number":2297,"context_line":""},{"line_number":2298,"context_line":"    If configured, the config drive data are uploaded to Swift. The Node\u0027s"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_34f3280c","line":2295,"in_reply_to":"fa7ab95a_20ff7435","updated":"2016-08-31 20:43:27.000000000","message":"++","commit_id":"c23cce33c08a5e89fba293f5430d20fef5702035"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ba25ac94f40b67bee6d47f300b7b8f0c8926ba0d","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"    return \u0027configdrive-%s\u0027 % node.uuid"},{"line_number":2293,"context_line":""},{"line_number":2294,"context_line":""},{"line_number":2295,"context_line":"def _store_configdrive(node, configdrive):"},{"line_number":2296,"context_line":"    \"\"\"Handle the storage of the config drive."},{"line_number":2297,"context_line":""},{"line_number":2298,"context_line":"    If configured, the config drive data are uploaded to Swift. The Node\u0027s"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_540fcc87","line":2295,"in_reply_to":"fa7ab95a_34f3280c","updated":"2016-08-31 20:52:28.000000000","message":"Thinking about it again, this is close. Let\u0027s land this as is and have a follow up patch.","commit_id":"c23cce33c08a5e89fba293f5430d20fef5702035"}]}
