)]}'
{"releasenotes/notes/multitenant-networking-0a13c4aba252573e.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4bdb60d727fbd5d2e2189bf896b85cc8d875732d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds multitenant networking support, via the concept of \"network"},{"line_number":5,"context_line":"    interfaces\" for a node, which represent a networking driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are three network interfaces available:"},{"line_number":8,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":9,"context_line":"      when using neutron for DHCP."},{"line_number":10,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_1e5bc288","line":7,"updated":"2016-08-09 17:20:36.000000000","message":"Needs to be a blank line below this.","commit_id":"b1fd134620489983bb228c2325e3073c47b43855"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d583dc055dd10012ec847fb8c29061e60610d3e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds multitenant networking support, via the concept of \"network"},{"line_number":5,"context_line":"    interfaces\" for a node, which represent a networking driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are three network interfaces available:"},{"line_number":8,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":9,"context_line":"      when using neutron for DHCP."},{"line_number":10,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_1e3c62e1","line":7,"in_reply_to":"9ad45d7e_1e5bc288","updated":"2016-08-09 18:52:51.000000000","message":"Done","commit_id":"b1fd134620489983bb228c2325e3073c47b43855"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"eb5a2cb1ba85b2e338e3f0427b46ea75786f3ef3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    interfaces\" for a node, which represent a networking driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are three network interfaces available:"},{"line_number":8,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":9,"context_line":"      when using neutron for DHCP."},{"line_number":10,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"},{"line_number":11,"context_line":"      DHCP, and is the default when ``[DHCP]/dhcp_provider`` is set to \"none\"."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_5e6eda2f","line":8,"updated":"2016-08-09 17:20:03.000000000","message":"You need a blank line here to separate the normal paragraph from the list.","commit_id":"b1fd134620489983bb228c2325e3073c47b43855"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d583dc055dd10012ec847fb8c29061e60610d3e9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    interfaces\" for a node, which represent a networking driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are three network interfaces available:"},{"line_number":8,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":9,"context_line":"      when using neutron for DHCP."},{"line_number":10,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"},{"line_number":11,"context_line":"      DHCP, and is the default when ``[DHCP]/dhcp_provider`` is set to \"none\"."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_fe3eaed8","line":8,"in_reply_to":"9ad45d7e_5e6eda2f","updated":"2016-08-09 18:52:51.000000000","message":"Done","commit_id":"b1fd134620489983bb228c2325e3073c47b43855"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c84c78a4723477b1313613ccdd34494f80697ea4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    themselves should be removed from DHCP provider so that network interface"},{"line_number":43,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":44,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":45,"context_line":"    deployments, but it will be required in the Ocata release."},{"line_number":46,"context_line":"upgrade:"},{"line_number":47,"context_line":"  - |"},{"line_number":48,"context_line":"    ``[DEFAULT]/default_network_interface`` configuration option is introduced,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_58ff2467","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":16},"updated":"2016-08-09 12:36:08.000000000","message":"nit: s/,/ upon upgrade,/\nnit: s/release/release if the ``flat`` network interface is enabled./","commit_id":"b1fd134620489983bb228c2325e3073c47b43855"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d583dc055dd10012ec847fb8c29061e60610d3e9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    themselves should be removed from DHCP provider so that network interface"},{"line_number":43,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":44,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":45,"context_line":"    deployments, but it will be required in the Ocata release."},{"line_number":46,"context_line":"upgrade:"},{"line_number":47,"context_line":"  - |"},{"line_number":48,"context_line":"    ``[DEFAULT]/default_network_interface`` configuration option is introduced,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ad45d7e_5e26dace","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":16},"in_reply_to":"9ad45d7e_58ff2467","updated":"2016-08-09 18:52:51.000000000","message":"Done","commit_id":"b1fd134620489983bb228c2325e3073c47b43855"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds multitenant networking support, via the concept of \"network"},{"line_number":5,"context_line":"    interfaces\" for a node, which represent a networking driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are three network interfaces available:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_d9630419","line":5,"updated":"2016-08-09 18:04:26.000000000","message":"probably a nit, but i have a hard time parsing this sentence. what represents a networking driver? the network interface for a node, or multitenant networking support?\n\nMaybe we shouldn\u0027t even mention \u0027networking driver\u0027...","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds multitenant networking support, via the concept of \"network"},{"line_number":5,"context_line":"    interfaces\" for a node, which represent a networking driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    There are three network interfaces available:"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_712aec7f","line":5,"in_reply_to":"9ad45d7e_d9630419","updated":"2016-08-09 19:27:14.000000000","message":"I think we need to mention that they are like a networking driver, or else the words \"network interface\" are confusing. I\u0027ll split it up to make it less ambiguous though.","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":10,"context_line":"      when using neutron for DHCP."},{"line_number":11,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"},{"line_number":12,"context_line":"      DHCP, and is the default when ``[DHCP]/dhcp_provider`` is set to \"none\"."},{"line_number":13,"context_line":"    * neutron: this allows for separating the provisioning and cleaning"},{"line_number":14,"context_line":"      networks from the tenant networks, and provides isolation from tenant"},{"line_number":15,"context_line":"      network to tenant network, and tenant network to control plane."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_397340e9","line":12,"updated":"2016-08-09 18:04:26.000000000","message":"s/when/when configuration option/","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":10,"context_line":"      when using neutron for DHCP."},{"line_number":11,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"},{"line_number":12,"context_line":"      DHCP, and is the default when ``[DHCP]/dhcp_provider`` is set to \"none\"."},{"line_number":13,"context_line":"    * neutron: this allows for separating the provisioning and cleaning"},{"line_number":14,"context_line":"      networks from the tenant networks, and provides isolation from tenant"},{"line_number":15,"context_line":"      network to tenant network, and tenant network to control plane."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_5136c8e6","line":12,"in_reply_to":"9ad45d7e_397340e9","updated":"2016-08-09 19:27:14.000000000","message":"Done","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    release. The logic they are implementing should be moved to a custom"},{"line_number":41,"context_line":"    network interface\u0027s ``add_cleaning_network`` and"},{"line_number":42,"context_line":"    ``remove_cleaning_network`` methods respectively. After that, the methods"},{"line_number":43,"context_line":"    themselves should be removed from DHCP provider so that network interface"},{"line_number":44,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":45,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":46,"context_line":"    deployments upon upgrade, but it will be required in the Ocata release if"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_7902d80c","line":43,"updated":"2016-08-09 18:04:26.000000000","message":"s/that/that the custom/","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    release. The logic they are implementing should be moved to a custom"},{"line_number":41,"context_line":"    network interface\u0027s ``add_cleaning_network`` and"},{"line_number":42,"context_line":"    ``remove_cleaning_network`` methods respectively. After that, the methods"},{"line_number":43,"context_line":"    themselves should be removed from DHCP provider so that network interface"},{"line_number":44,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":45,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":46,"context_line":"    deployments upon upgrade, but it will be required in the Ocata release if"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_315fd40f","line":43,"in_reply_to":"9ad45d7e_7902d80c","updated":"2016-08-09 19:27:14.000000000","message":"Done","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    network interface\u0027s ``add_cleaning_network`` and"},{"line_number":42,"context_line":"    ``remove_cleaning_network`` methods respectively. After that, the methods"},{"line_number":43,"context_line":"    themselves should be removed from DHCP provider so that network interface"},{"line_number":44,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":45,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":46,"context_line":"    deployments upon upgrade, but it will be required in the Ocata release if"},{"line_number":47,"context_line":"    the ``flat`` network interface is enabled."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_f40c0f3d","line":44,"updated":"2016-08-09 18:04:26.000000000","message":"I wonder if we should put the stuff about flat network interface in a separate deprecation bullet.","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    network interface\u0027s ``add_cleaning_network`` and"},{"line_number":42,"context_line":"    ``remove_cleaning_network`` methods respectively. After that, the methods"},{"line_number":43,"context_line":"    themselves should be removed from DHCP provider so that network interface"},{"line_number":44,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":45,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":46,"context_line":"    deployments upon upgrade, but it will be required in the Ocata release if"},{"line_number":47,"context_line":"    the ``flat`` network interface is enabled."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_51bb6827","line":44,"in_reply_to":"9ad45d7e_f40c0f3d","updated":"2016-08-09 19:27:14.000000000","message":"I think it makes more sense here, personally. Unless we duplicate a bunch of information.","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":45,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":46,"context_line":"    deployments upon upgrade, but it will be required in the Ocata release if"},{"line_number":47,"context_line":"    the ``flat`` network interface is enabled."},{"line_number":48,"context_line":"upgrade:"},{"line_number":49,"context_line":"  - |"},{"line_number":50,"context_line":"    ``[DEFAULT]/default_network_interface`` configuration option is introduced,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_34cd075e","line":47,"updated":"2016-08-09 18:04:26.000000000","message":"Should we also mention this in the upgrade part? (Or maybe we mention that in the Ocata release.)","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    is used instead. ``flat`` network interface does not require"},{"line_number":45,"context_line":"    ``[neutron]/cleaning_network_uuid`` for now so as not to break standalone"},{"line_number":46,"context_line":"    deployments upon upgrade, but it will be required in the Ocata release if"},{"line_number":47,"context_line":"    the ``flat`` network interface is enabled."},{"line_number":48,"context_line":"upgrade:"},{"line_number":49,"context_line":"  - |"},{"line_number":50,"context_line":"    ``[DEFAULT]/default_network_interface`` configuration option is introduced,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_d1f478f3","line":47,"in_reply_to":"9ad45d7e_34cd075e","updated":"2016-08-09 19:27:14.000000000","message":"Yeah, we\u0027ll mention that in Ocata when we fix it.","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    ``[DEFAULT]/default_network_interface`` is not set, everything should go as"},{"line_number":62,"context_line":"    expected. If it is set, ensure that it is set to the value that you wish"},{"line_number":63,"context_line":"    existing nodes to use."},{"line_number":64,"context_line":"  - Note that if ``[DEFAULT]/default_network_interface`` is set, it must be set"},{"line_number":65,"context_line":"    in the configuration file for both the API and conductor hosts."},{"line_number":66,"context_line":"  - If ``neutron`` network interface is specified in"},{"line_number":67,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_14428310","line":64,"updated":"2016-08-09 18:04:26.000000000","message":"s/if/if configuration option/","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    ``[DEFAULT]/default_network_interface`` is not set, everything should go as"},{"line_number":62,"context_line":"    expected. If it is set, ensure that it is set to the value that you wish"},{"line_number":63,"context_line":"    existing nodes to use."},{"line_number":64,"context_line":"  - Note that if ``[DEFAULT]/default_network_interface`` is set, it must be set"},{"line_number":65,"context_line":"    in the configuration file for both the API and conductor hosts."},{"line_number":66,"context_line":"  - If ``neutron`` network interface is specified in"},{"line_number":67,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``,"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_31e4f439","line":64,"in_reply_to":"9ad45d7e_14428310","updated":"2016-08-09 19:27:14.000000000","message":"Done","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    existing nodes to use."},{"line_number":64,"context_line":"  - Note that if ``[DEFAULT]/default_network_interface`` is set, it must be set"},{"line_number":65,"context_line":"    in the configuration file for both the API and conductor hosts."},{"line_number":66,"context_line":"  - If ``neutron`` network interface is specified in"},{"line_number":67,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``,"},{"line_number":68,"context_line":"    ``[neutron]/provisioning_network_uuid`` and"},{"line_number":69,"context_line":"    ``[neutron]/cleaning_network_uuid`` configuration options are required. If"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_74513fd8","line":66,"updated":"2016-08-09 18:04:26.000000000","message":"s/in/for configuration option/","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    existing nodes to use."},{"line_number":64,"context_line":"  - Note that if ``[DEFAULT]/default_network_interface`` is set, it must be set"},{"line_number":65,"context_line":"    in the configuration file for both the API and conductor hosts."},{"line_number":66,"context_line":"  - If ``neutron`` network interface is specified in"},{"line_number":67,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``,"},{"line_number":68,"context_line":"    ``[neutron]/provisioning_network_uuid`` and"},{"line_number":69,"context_line":"    ``[neutron]/cleaning_network_uuid`` configuration options are required. If"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_51c0887b","line":66,"in_reply_to":"9ad45d7e_74513fd8","updated":"2016-08-09 19:27:14.000000000","message":"Done","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"fa1ab7eecfcb16c9acb69028e2a538594b293ad9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``,"},{"line_number":68,"context_line":"    ``[neutron]/provisioning_network_uuid`` and"},{"line_number":69,"context_line":"    ``[neutron]/cleaning_network_uuid`` configuration options are required. If"},{"line_number":70,"context_line":"    any of them is not specified, the ironic-conductor service will fail to"},{"line_number":71,"context_line":"    start."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_d42c6b4c","line":70,"updated":"2016-08-09 18:04:26.000000000","message":"s/any of them is/both are/","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ef8910679c7b852f40252d6f8fa9f510dae52acb","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``,"},{"line_number":68,"context_line":"    ``[neutron]/provisioning_network_uuid`` and"},{"line_number":69,"context_line":"    ``[neutron]/cleaning_network_uuid`` configuration options are required. If"},{"line_number":70,"context_line":"    any of them is not specified, the ironic-conductor service will fail to"},{"line_number":71,"context_line":"    start."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_31bb5410","line":70,"in_reply_to":"9ad45d7e_d42c6b4c","updated":"2016-08-09 19:27:14.000000000","message":"Hm, it will fail if either are not specified, I think \u0027both\u0027 might imply one or the other may be unspecified.","commit_id":"ae4c4b3c370a9590931909b9c676f7a08af15184"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a8ef96a37bd026dda0d7325a9bcb8f7ae5fab05","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    There are three network interfaces available:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":12,"context_line":"      when using neutron for DHCP."},{"line_number":13,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"},{"line_number":14,"context_line":"      DHCP, and is the default when the configuration option"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_c33b0037","line":11,"updated":"2016-08-10 03:55:14.000000000","message":"I wonder if we should s/flat/``flat``/. (That\u0027s how it is depicted in the bullet in the deprecations section.)","commit_id":"7baa51b1ebae4567cebf95171158964eb26c3a2d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"95f962cef2675fe86c5782be3f78c7a188a9f782","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    There are three network interfaces available:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * flat: this replicates the old flat network behavior and is the default"},{"line_number":12,"context_line":"      when using neutron for DHCP."},{"line_number":13,"context_line":"    * noop: this replicates the old flat behavior when not using neutron for"},{"line_number":14,"context_line":"      DHCP, and is the default when the configuration option"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_a6c9a85b","line":11,"in_reply_to":"9ad45d7e_c33b0037","updated":"2016-08-10 11:20:57.000000000","message":"Done","commit_id":"7baa51b1ebae4567cebf95171158964eb26c3a2d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9a8ef96a37bd026dda0d7325a9bcb8f7ae5fab05","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    A network interface is set for a node by setting the ``network_interface``"},{"line_number":30,"context_line":"    field for the node via the REST API. This field is available in API version"},{"line_number":31,"context_line":"    1.20 and above. Changing the network interface may only be done in the"},{"line_number":32,"context_line":"    ENROLL, INSPECTING, and MANAGEABLE states."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    The configuration option ``[DEFAULT]/default_network_interface`` may be"},{"line_number":35,"context_line":"    used to specify which network interface is defined when a node is created."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_43e1d0cf","line":32,"updated":"2016-08-10 03:55:14.000000000","message":"I just realized. The user doesn\u0027t use/see ENROLL, INSPECTING or MANAGEABLE. They should be \u0027enroll\u0027, \u0027inspecting\u0027, \u0027manageable\u0027.","commit_id":"7baa51b1ebae4567cebf95171158964eb26c3a2d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"95f962cef2675fe86c5782be3f78c7a188a9f782","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    A network interface is set for a node by setting the ``network_interface``"},{"line_number":30,"context_line":"    field for the node via the REST API. This field is available in API version"},{"line_number":31,"context_line":"    1.20 and above. Changing the network interface may only be done in the"},{"line_number":32,"context_line":"    ENROLL, INSPECTING, and MANAGEABLE states."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    The configuration option ``[DEFAULT]/default_network_interface`` may be"},{"line_number":35,"context_line":"    used to specify which network interface is defined when a node is created."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_06c35439","line":32,"in_reply_to":"9ad45d7e_43e1d0cf","updated":"2016-08-10 11:20:57.000000000","message":"Done","commit_id":"7baa51b1ebae4567cebf95171158964eb26c3a2d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"619a9673b65f7e432155287365311a108d96c6dd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``, then"},{"line_number":72,"context_line":"    ``[neutron]/provisioning_network_uuid`` and"},{"line_number":73,"context_line":"    ``[neutron]/cleaning_network_uuid`` configuration options are required. If"},{"line_number":74,"context_line":"    either of them are not specified, the ironic-conductor service will fail to"},{"line_number":75,"context_line":"    start."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_fa2191b5","line":74,"updated":"2016-08-09 21:06:33.000000000","message":"I think it might be s/are/is/. but \u0027any of them are ..\u0027 ;)","commit_id":"7baa51b1ebae4567cebf95171158964eb26c3a2d"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"95f962cef2675fe86c5782be3f78c7a188a9f782","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    ``[DEFAULT]/enabled_network_interfaces``, then"},{"line_number":72,"context_line":"    ``[neutron]/provisioning_network_uuid`` and"},{"line_number":73,"context_line":"    ``[neutron]/cleaning_network_uuid`` configuration options are required. If"},{"line_number":74,"context_line":"    either of them are not specified, the ironic-conductor service will fail to"},{"line_number":75,"context_line":"    start."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_46df0c0d","line":74,"in_reply_to":"9ad45d7e_fa2191b5","updated":"2016-08-10 11:20:57.000000000","message":"Done","commit_id":"7baa51b1ebae4567cebf95171158964eb26c3a2d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31dd33636fdcefbd2f064f36a02bdbf8d3781218","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    The configuration option ``[DEFAULT]/default_network_interface`` may be"},{"line_number":35,"context_line":"    used to specify which network interface is defined when a node is created."},{"line_number":36,"context_line":"    WARNING: don\u0027t set this option before upgrading to this release without"},{"line_number":37,"context_line":"    reading the upgrade notes about it, due to data migrations depending on"},{"line_number":38,"context_line":"    the value."},{"line_number":39,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_aae682ad","line":36,"updated":"2016-08-10 13:56:35.000000000","message":"I wonder if we could somehow make this warning more prominent.. maybe use bold font and move it to a separate paragraph?","commit_id":"83a30163c9e30b95ef8a1008eb0b09a0e20e704f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a79010230fdbb96ac0e1088ca4b280f3e6a22cfe","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    The configuration option ``[DEFAULT]/default_network_interface`` may be"},{"line_number":35,"context_line":"    used to specify which network interface is defined when a node is created."},{"line_number":36,"context_line":"    WARNING: don\u0027t set this option before upgrading to this release without"},{"line_number":37,"context_line":"    reading the upgrade notes about it, due to data migrations depending on"},{"line_number":38,"context_line":"    the value."},{"line_number":39,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_492ef3a5","line":36,"in_reply_to":"9ad45d7e_aae682ad","updated":"2016-08-10 14:30:33.000000000","message":"Done","commit_id":"83a30163c9e30b95ef8a1008eb0b09a0e20e704f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"31dd33636fdcefbd2f064f36a02bdbf8d3781218","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    the network interface for nodes that don\u0027t have ``network_interface`` field"},{"line_number":56,"context_line":"    set. If it is not set, the network interface is determined by looking at"},{"line_number":57,"context_line":"    the ``[dhcp]/dhcp_provider`` value. If it is ``neutron`` - ``flat`` network"},{"line_number":58,"context_line":"    interface is the default, ``noop`` otherwise."},{"line_number":59,"context_line":"    The network interface will be set for all nodes without network_interface"},{"line_number":60,"context_line":"    already set via a database migration. This will be set following the logic"},{"line_number":61,"context_line":"    above. When running database migrations for an existing deployment, it\u0027s"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_8aebbe77","line":58,"updated":"2016-08-10 13:56:35.000000000","message":"please break this text into paragraphs (e.g. add one more newline here), otherwise it\u0027s a bit hard to read.","commit_id":"83a30163c9e30b95ef8a1008eb0b09a0e20e704f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"a79010230fdbb96ac0e1088ca4b280f3e6a22cfe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    the network interface for nodes that don\u0027t have ``network_interface`` field"},{"line_number":56,"context_line":"    set. If it is not set, the network interface is determined by looking at"},{"line_number":57,"context_line":"    the ``[dhcp]/dhcp_provider`` value. If it is ``neutron`` - ``flat`` network"},{"line_number":58,"context_line":"    interface is the default, ``noop`` otherwise."},{"line_number":59,"context_line":"    The network interface will be set for all nodes without network_interface"},{"line_number":60,"context_line":"    already set via a database migration. This will be set following the logic"},{"line_number":61,"context_line":"    above. When running database migrations for an existing deployment, it\u0027s"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_891aab7b","line":58,"in_reply_to":"9ad45d7e_8aebbe77","updated":"2016-08-10 14:30:33.000000000","message":"Done","commit_id":"83a30163c9e30b95ef8a1008eb0b09a0e20e704f"}]}
