)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ac9065c0288d3ae0010277c5e0f9a866c7bc7fb3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also does a major refactor on the set_boot_device() method"},{"line_number":14,"context_line":"from IPMITool. The ipmitool command does not seem to allow us to set"},{"line_number":15,"context_line":"UEFI + persistent (options\u003defiboot,persiste) as part of the command to"},{"line_number":16,"context_line":"change the boot deivce, therefore, this patch is sending raw data to"},{"line_number":17,"context_line":"apply the desired boot device and mode."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_3e78462b","line":15,"updated":"2016-08-09 17:28:05.000000000","message":"Typo: \"persistent\" (second occurrence)","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48ddfa5b5f84fb321dfc1f838f0b3d779fcfb8bc","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also does a major refactor on the set_boot_device() method"},{"line_number":14,"context_line":"from IPMITool. The ipmitool command does not seem to allow us to set"},{"line_number":15,"context_line":"UEFI + persistent (options\u003defiboot,persiste) as part of the command to"},{"line_number":16,"context_line":"change the boot deivce, therefore, this patch is sending raw data to"},{"line_number":17,"context_line":"apply the desired boot device and mode."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_df72a848","line":15,"in_reply_to":"9ad45d7e_3e78462b","updated":"2016-08-10 08:35:39.000000000","message":"Done","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ac9065c0288d3ae0010277c5e0f9a866c7bc7fb3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch also does a major refactor on the set_boot_device() method"},{"line_number":14,"context_line":"from IPMITool. The ipmitool command does not seem to allow us to set"},{"line_number":15,"context_line":"UEFI + persistent (options\u003defiboot,persiste) as part of the command to"},{"line_number":16,"context_line":"change the boot deivce, therefore, this patch is sending raw data to"},{"line_number":17,"context_line":"apply the desired boot device and mode."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1611306"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_1e9aa263","line":16,"updated":"2016-08-09 17:28:05.000000000","message":"Typo: \"device\"","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48ddfa5b5f84fb321dfc1f838f0b3d779fcfb8bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch also does a major refactor on the set_boot_device() method"},{"line_number":14,"context_line":"from IPMITool. The ipmitool command does not seem to allow us to set"},{"line_number":15,"context_line":"UEFI + persistent (options\u003defiboot,persiste) as part of the command to"},{"line_number":16,"context_line":"change the boot deivce, therefore, this patch is sending raw data to"},{"line_number":17,"context_line":"apply the desired boot device and mode."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1611306"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9ad45d7e_3f902443","line":16,"in_reply_to":"9ad45d7e_1e9aa263","updated":"2016-08-10 08:35:39.000000000","message":"Done","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"aa1c3d3cda00c16b6711ad4c501b80d3cc5f57af","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A FIXME note was left in the code. It seems that ipmitool has a problem"},{"line_number":14,"context_line":"setting the efiboot + persistent at the same time (see the bug"},{"line_number":15,"context_line":"raw bytes when changing the boot device."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1611306"},{"line_number":18,"context_line":"Change-Id: I11456fb035fe41fe46f1ff04e4d56c9f85b9e19d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_9c1e2c6e","line":15,"updated":"2016-08-11 13:38:42.000000000","message":"\"see the bug about\"?","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3d2139ea7e18bd249233835e27713bce86936747","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A FIXME note was left in the code. It seems that ipmitool has a problem"},{"line_number":14,"context_line":"setting the efiboot + persistent at the same time (see the bug"},{"line_number":15,"context_line":"raw bytes when changing the boot device."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1611306"},{"line_number":18,"context_line":"Change-Id: I11456fb035fe41fe46f1ff04e4d56c9f85b9e19d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_f78143fc","line":15,"in_reply_to":"9ad45d7e_9c1e2c6e","updated":"2016-08-11 13:42:25.000000000","message":":-(\n\nIt was suppose to be (see the bug #1611306)","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"b31e47e600579394a6e80476f621484ca890b1f6","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        options \u003d []"},{"line_number":917,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":918,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":919,"context_line":"            options.append(\u0027efiboot\u0027)"},{"line_number":920,"context_line":"        if persistent:"},{"line_number":921,"context_line":"            options.append(\u0027persistent\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        cmd \u003d \"chassis bootdev %s\" % device"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8cacbe36","line":920,"range":{"start_line":918,"start_character":8,"end_line":920,"end_character":22},"updated":"2016-08-09 13:31:09.000000000","message":"Looks like efiboot and persistent do not work together.","commit_id":"c876c0283a5d669bb9586d19e92c3a33d1a22697"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"329213e61e3e4c25d7d9c1e23a9333f4baaae871","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        options \u003d []"},{"line_number":917,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":918,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":919,"context_line":"            options.append(\u0027efiboot\u0027)"},{"line_number":920,"context_line":"        if persistent:"},{"line_number":921,"context_line":"            options.append(\u0027persistent\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        cmd \u003d \"chassis bootdev %s\" % device"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_c4e96a1c","line":920,"range":{"start_line":918,"start_character":8,"end_line":920,"end_character":22},"in_reply_to":"9ad45d7e_8cacbe36","updated":"2016-08-09 14:28:32.000000000","message":"Looks like it doesn\u0027t work with chassis command, and works with raw. At least there was a notice about it.\nhttps://review.openstack.org/gitweb?p\u003dopenstack/ironic.git;a\u003dblob;f\u003dironic/drivers/modules/irmc/management.py;h\u003d077ebf7e5ae3a9186977661fa5abe56b429a148b#l151","commit_id":"c876c0283a5d669bb9586d19e92c3a33d1a22697"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7618c1775923adf9a0dceed5da2d6b7c3813279d","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        options \u003d []"},{"line_number":917,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":918,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":919,"context_line":"            options.append(\u0027efiboot\u0027)"},{"line_number":920,"context_line":"        if persistent:"},{"line_number":921,"context_line":"            options.append(\u0027persistent\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        cmd \u003d \"chassis bootdev %s\" % device"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_cdbfc65e","line":920,"range":{"start_line":918,"start_character":8,"end_line":920,"end_character":22},"in_reply_to":"9ad45d7e_c4e96a1c","updated":"2016-08-09 16:30:07.000000000","message":"Yeah, that\u0027s what I noticed as well :-( (see the bug linked with this patch).\n\nI\u0027ve refactored the next patch-set to use raw data instead of the chassis command.","commit_id":"c876c0283a5d669bb9586d19e92c3a33d1a22697"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ac9065c0288d3ae0010277c5e0f9a866c7bc7fb3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"IPMITOOL_RETRYABLE_FAILURES \u003d [\u0027insufficient resources for session\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# NOTE(lucasagomes): A mapping for the boot devices and their hexdecimal"},{"line_number":144,"context_line":"# value. For more information about these values see the \"Set System Boot"},{"line_number":145,"context_line":"# Options Command\" section of the link below (page 418)"},{"line_number":146,"context_line":"# http://www.intel.com/content/www/us/en/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html  # noqa"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3e9fa651","line":143,"updated":"2016-08-09 17:28:05.000000000","message":"Typo: \"hexadecimal\"","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48ddfa5b5f84fb321dfc1f838f0b3d779fcfb8bc","unresolved":false,"context_lines":[{"line_number":140,"context_line":"IPMITOOL_RETRYABLE_FAILURES \u003d [\u0027insufficient resources for session\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# NOTE(lucasagomes): A mapping for the boot devices and their hexdecimal"},{"line_number":144,"context_line":"# value. For more information about these values see the \"Set System Boot"},{"line_number":145,"context_line":"# Options Command\" section of the link below (page 418)"},{"line_number":146,"context_line":"# http://www.intel.com/content/www/us/en/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html  # noqa"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3fb784d9","line":143,"in_reply_to":"9ad45d7e_3e9fa651","updated":"2016-08-10 08:35:39.000000000","message":"Done","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"9fb0268a15f78c9d38fcce9768155699a6f55184","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# NOTE(lucasagomes): A mapping for the boot devices and their hexdecimal"},{"line_number":144,"context_line":"# value. For more information about these values see the \"Set System Boot"},{"line_number":145,"context_line":"# Options Command\" section of the link below (page 418)"},{"line_number":146,"context_line":"# http://www.intel.com/content/www/us/en/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html  # noqa"},{"line_number":147,"context_line":"BOOT_DEVICE_HEX_MAP \u003d {"},{"line_number":148,"context_line":"    boot_devices.PXE: \u00270x04\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f986c8d9","line":145,"updated":"2016-08-09 18:18:31.000000000","message":"These options seem to be on page 396, not 418, using spec below, unless I am misreading it.\n\nI noticed this in irmc/management.py with the current definition of boot_devices.CDROM. Does this still apply?     \n               \n# boot_devices.CDROM is tentatively set to \u00270x20\u0027 rather\n# than \u00270x14\u0027 as a work-around to force iRMC vmedia boot.\nboot_devices.CDROM: \u00270x20\u0027,","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48ddfa5b5f84fb321dfc1f838f0b3d779fcfb8bc","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# NOTE(lucasagomes): A mapping for the boot devices and their hexdecimal"},{"line_number":144,"context_line":"# value. For more information about these values see the \"Set System Boot"},{"line_number":145,"context_line":"# Options Command\" section of the link below (page 418)"},{"line_number":146,"context_line":"# http://www.intel.com/content/www/us/en/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html  # noqa"},{"line_number":147,"context_line":"BOOT_DEVICE_HEX_MAP \u003d {"},{"line_number":148,"context_line":"    boot_devices.PXE: \u00270x04\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9a367ee5","line":145,"in_reply_to":"9ad45d7e_f986c8d9","updated":"2016-08-10 08:35:39.000000000","message":"The page 418 contains the \"Set System Boot Options Command\" which it explains about the boot options, then on page 422 you have the table with the option values.\n\n...\n\nGood point, so for IRMC 0x20 is the virtual media, like when you boot the node from an ISO attached via the network. Unfortunately, virtual media is vendor specific and the vanilla IPMI specification do not support it. So 0x14 is what we need to use for this driver (ipmitool is a generic, cross-vendor driver).","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"ac9065c0288d3ae0010277c5e0f9a866c7bc7fb3","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        # NOTE(lucasagomes):"},{"line_number":930,"context_line":"        # mode: \u00270xe0\u0027 persistent + UEFI"},{"line_number":931,"context_line":"        #       \u00270xa0\u0027 non-persistent  + UEFI"},{"line_number":932,"context_line":"        #       \u00270xc0\u0027 persistent + BIOS"},{"line_number":933,"context_line":"        #       \u00270x80\u0027 non-persistent + BIOS"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5e0d3a3d","line":930,"updated":"2016-08-09 17:28:05.000000000","message":"You could also do the calculation in Python code:\n\n    firmware_mode \u003d 2 if boot_mode \u003d\u003d \u0027uefi\u0027 else 0\n    persistence \u003d 12 if persistent else 8\n    boot_mode \u003d persistence | firmware_mode\n    raw_cmd \u003d \u00270x00 0x08 0x05 0x%(boot_mode)02x %(dev)s 0x00 0x00 0x00\u0027 % {\u0027boot_mode\u0027: boot_mode, \u0027dev\u0027: BOOT_DEVICE_HEX_MAP[device]}","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48ddfa5b5f84fb321dfc1f838f0b3d779fcfb8bc","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(node)"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        # NOTE(lucasagomes):"},{"line_number":930,"context_line":"        # mode: \u00270xe0\u0027 persistent + UEFI"},{"line_number":931,"context_line":"        #       \u00270xa0\u0027 non-persistent  + UEFI"},{"line_number":932,"context_line":"        #       \u00270xc0\u0027 persistent + BIOS"},{"line_number":933,"context_line":"        #       \u00270x80\u0027 non-persistent + BIOS"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3a75d297","line":930,"in_reply_to":"9ad45d7e_5e0d3a3d","updated":"2016-08-10 08:35:39.000000000","message":"Right, I think using the hexa values is more readeable. Let\u0027s see what all people think","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"286b2d7732399db215efad2bb74f0df472619e9a","unresolved":false,"context_lines":[{"line_number":933,"context_line":"        #       \u00270x80\u0027 non-persistent + BIOS"},{"line_number":934,"context_line":"        #"},{"line_number":935,"context_line":"        # dev: See the BOOT_DEVICE_HEX_MAP dictionary"},{"line_number":936,"context_line":"        raw_cmd \u003d \u00270x00 0x08 0x05 %(mode)s %(dev)s 0x00 0x00 0x00\u0027"},{"line_number":937,"context_line":"        mode \u003d None"},{"line_number":938,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":939,"context_line":"            mode \u003d \u00270xe0\u0027 if persistent else \u00270xa0\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_69ce6eb5","line":936,"updated":"2016-08-10 07:34:56.000000000","message":"Do we want to switch to raw for all cases here? I think we should send raw only for \"efiboot,persistent\" case.","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48ddfa5b5f84fb321dfc1f838f0b3d779fcfb8bc","unresolved":false,"context_lines":[{"line_number":933,"context_line":"        #       \u00270x80\u0027 non-persistent + BIOS"},{"line_number":934,"context_line":"        #"},{"line_number":935,"context_line":"        # dev: See the BOOT_DEVICE_HEX_MAP dictionary"},{"line_number":936,"context_line":"        raw_cmd \u003d \u00270x00 0x08 0x05 %(mode)s %(dev)s 0x00 0x00 0x00\u0027"},{"line_number":937,"context_line":"        mode \u003d None"},{"line_number":938,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":939,"context_line":"            mode \u003d \u00270xe0\u0027 if persistent else \u00270xa0\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9a479e1c","line":936,"in_reply_to":"9ad45d7e_69ce6eb5","updated":"2016-08-10 08:35:39.000000000","message":"That\u0027s a good point! I thought about using raw for everything because that would make it more consistent at least (clear code path).\n\nBut I will cook a patch changing it only for the persistent + UEFI case to see how it will look like.","commit_id":"c3f0c73d115da35115c8322a2939957a3a5c0da0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"aa1c3d3cda00c16b6711ad4c501b80d3cc5f57af","unresolved":false,"context_lines":[{"line_number":936,"context_line":"        # https://bugs.launchpad.net/ironic/+bug/1611306"},{"line_number":937,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":938,"context_line":"        if persistent and boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":939,"context_line":"            raw_cmd \u003d (\u00270x00 0x08 0x05 0xe0 %s 0x00 0x00 0x00\u0027 %"},{"line_number":940,"context_line":"                       BOOT_DEVICE_HEXA_MAP[device])"},{"line_number":941,"context_line":"            send_raw(task, raw_cmd)"},{"line_number":942,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_d7599f36","line":939,"updated":"2016-08-11 13:38:42.000000000","message":"Should we make this a constant somewhere, with a comment to make it obvious what it means? (I\u0027m unopinionated, just asking)","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3d2139ea7e18bd249233835e27713bce86936747","unresolved":false,"context_lines":[{"line_number":936,"context_line":"        # https://bugs.launchpad.net/ironic/+bug/1611306"},{"line_number":937,"context_line":"        boot_mode \u003d deploy_utils.get_boot_mode_for_deploy(task.node)"},{"line_number":938,"context_line":"        if persistent and boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":939,"context_line":"            raw_cmd \u003d (\u00270x00 0x08 0x05 0xe0 %s 0x00 0x00 0x00\u0027 %"},{"line_number":940,"context_line":"                       BOOT_DEVICE_HEXA_MAP[device])"},{"line_number":941,"context_line":"            send_raw(task, raw_cmd)"},{"line_number":942,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_37ce3b63","line":939,"in_reply_to":"9ad45d7e_d7599f36","updated":"2016-08-11 13:42:25.000000000","message":"What each hexa means?\n\nYeah that can be useful","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"69570be3a47badeee5c43420639c699630a88886","unresolved":false,"context_lines":[{"line_number":947,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":948,"context_line":"            options.append(\u0027efiboot\u0027)"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cmd \u003d \"chassis bootdev %s\" % device"},{"line_number":951,"context_line":"        if options:"},{"line_number":952,"context_line":"            cmd \u003d cmd + \" options\u003d%s\" % \u0027,\u0027.join(options)"},{"line_number":953,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_4976f306","line":950,"updated":"2016-08-10 14:23:38.000000000","message":"Have you checked that sending \"ipmitool -I lanplus -U xxx -P xxx -H X.X.X.X chassis bootdev pxe options\u003dpersistent,efiboot\" after raw will not clear persistent flag?","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5beddb2f014f33cb1ac9f5272f9258dfe67d542","unresolved":false,"context_lines":[{"line_number":947,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":948,"context_line":"            options.append(\u0027efiboot\u0027)"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cmd \u003d \"chassis bootdev %s\" % device"},{"line_number":951,"context_line":"        if options:"},{"line_number":952,"context_line":"            cmd \u003d cmd + \" options\u003d%s\" % \u0027,\u0027.join(options)"},{"line_number":953,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_a9a20f49","line":950,"in_reply_to":"9ad45d7e_4976f306","updated":"2016-08-10 14:25:59.000000000","message":"According to the examples in the bug sending string command with options\u003dpersistent,efiboot will clear previous persistent flag.","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bce1787300cc96d633fa6cfaefd646d69c0aaa19","unresolved":false,"context_lines":[{"line_number":947,"context_line":"        if boot_mode \u003d\u003d \u0027uefi\u0027:"},{"line_number":948,"context_line":"            options.append(\u0027efiboot\u0027)"},{"line_number":949,"context_line":""},{"line_number":950,"context_line":"        cmd \u003d \"chassis bootdev %s\" % device"},{"line_number":951,"context_line":"        if options:"},{"line_number":952,"context_line":"            cmd \u003d cmd + \" options\u003d%s\" % \u0027,\u0027.join(options)"},{"line_number":953,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_acea1daa","line":950,"in_reply_to":"9ad45d7e_a9a20f49","updated":"2016-08-10 14:34:15.000000000","message":"Hi there,\n\nIf you send it after the raw command it will clear the previous flag yes. But this patch won\u0027t send it, see the \"return\" at L942.\n\nAfter sending the raw command this function will return. Once we have the ipmitool utilities updated in the distro packages we can remove the conditional sending the raw bytes (L927-L942)","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"}],"ironic/tests/unit/drivers/modules/test_ipmitool.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0892e107fa48a30fad18361348799b0896f963da","unresolved":false,"context_lines":[{"line_number":1849,"context_line":"                                                   persistent\u003dTrue)"},{"line_number":1850,"context_line":"        mock_calls \u003d ["},{"line_number":1851,"context_line":"            mock.call(self.info, \"raw 0x00 0x08 0x03 0x08\"),"},{"line_number":1852,"context_line":"            # 0xe0 \u003d non-persistent + UEFI"},{"line_number":1853,"context_line":"            # 0x04 \u003d PXE"},{"line_number":1854,"context_line":"            mock.call(self.info, \"raw 0x00 0x08 0x05 0xe0 0x04 0x00 0x00 0x00\")"},{"line_number":1855,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_002a452c","line":1852,"updated":"2016-08-09 16:38:55.000000000","message":"urgh... I meant \"persistent + UEFI\"","commit_id":"96bbe0ea23c1a485045e12966f8d20d0b3016b30"}],"releasenotes/notes/ipmitool-bootdev-persistent-uefi-b1181a3c82343c8f.yaml":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"aa1c3d3cda00c16b6711ad4c501b80d3cc5f57af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a problem where the boot mode (uefi or bios) wasn\u0027t checked"},{"line_number":4,"context_line":"    as part of changing the boot device of a node, making it to wrongly"},{"line_number":5,"context_line":"    switch from UEFI to Legacy BIOS mode on some hardware models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_b73a2b97","line":3,"updated":"2016-08-11 13:38:42.000000000","message":"s/uefi/UEFI/\ns/bios/BIOS/","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"aa1c3d3cda00c16b6711ad4c501b80d3cc5f57af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a problem where the boot mode (uefi or bios) wasn\u0027t checked"},{"line_number":4,"context_line":"    as part of changing the boot device of a node, making it to wrongly"},{"line_number":5,"context_line":"    switch from UEFI to Legacy BIOS mode on some hardware models."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_775553c4","line":4,"updated":"2016-08-11 13:38:42.000000000","message":"s/to wrongly/incorrectly/","commit_id":"3cba61aa830236222cae025e15060f4fe31aee2f"}]}
