)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e82a1e5a456d69695e032416caaed16c4d8599b0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch makes the build of Ironic reproducible. If you don\u0027t know"},{"line_number":10,"context_line":"about reproducible build, please read on:"},{"line_number":11,"context_line":"https://wiki.debian.org/ReproducibleBuilds"},{"line_number":12,"context_line":"https://wiki.debian.org/ReproducibleBuilds/About"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Debian has SOURCE_DATE_EPOCH set according to the last date of"},{"line_number":15,"context_line":"debian/changelog, which makes it so that the time is constant,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_498f1375","line":12,"updated":"2016-08-10 14:14:41.000000000","message":"this is great, but I\u0027m not sure how modifying dates in a sample in one of our controllers make it more or less reproducible. Could you please elaborate on how it works in our case (and why you didn\u0027t update other samples).","commit_id":"95c72c666e2dfdc783cbf70e3e56ada3452ee948"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8026f7b5c72c2d8ffc375a4181bc5af7d73a21b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch makes the build of Ironic reproducible. If you don\u0027t know"},{"line_number":10,"context_line":"about reproducible build, please read on:"},{"line_number":11,"context_line":"https://wiki.debian.org/ReproducibleBuilds"},{"line_number":12,"context_line":"https://wiki.debian.org/ReproducibleBuilds/About"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Debian has SOURCE_DATE_EPOCH set according to the last date of"},{"line_number":15,"context_line":"debian/changelog, which makes it so that the time is constant,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_070e408b","line":12,"in_reply_to":"9ad45d7e_498f1375","updated":"2016-08-12 03:36:29.000000000","message":"@Dmitry. This is the only place where the sample changes because the date used in the sample changes. The other samples use fixed dates. Eg, for node.py, it uses time \u003d datetime.datetime(2000, 1, 1, 12, 0, 0).","commit_id":"95c72c666e2dfdc783cbf70e3e56ada3452ee948"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e82a1e5a456d69695e032416caaed16c4d8599b0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @classmethod"},{"line_number":165,"context_line":"    def sample(cls, expand\u003dTrue):"},{"line_number":166,"context_line":"        now \u003d datetime.datetime.utcfromtimestamp(int(os.environ.get("},{"line_number":167,"context_line":"                                            \u0027SOURCE_DATE_EPOCH\u0027, time.time())))"},{"line_number":168,"context_line":"        sample \u003d cls(uuid\u003d\u002727e3153e-d5bf-4b7e-b517-fb518e17f34c\u0027,"},{"line_number":169,"context_line":"                     address\u003d\u0027fe:54:00:77:07:d9\u0027,"},{"line_number":170,"context_line":"                     extra\u003d{\u0027foo\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_298c5f7e","line":167,"updated":"2016-08-10 14:14:41.000000000","message":"indentation is a bit off here","commit_id":"95c72c666e2dfdc783cbf70e3e56ada3452ee948"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"8026f7b5c72c2d8ffc375a4181bc5af7d73a21b1","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    @classmethod"},{"line_number":165,"context_line":"    def sample(cls, expand\u003dTrue):"},{"line_number":166,"context_line":"        now \u003d datetime.datetime.utcfromtimestamp(int(os.environ.get("},{"line_number":167,"context_line":"                                            \u0027SOURCE_DATE_EPOCH\u0027, time.time())))"},{"line_number":168,"context_line":"        sample \u003d cls(uuid\u003d\u002727e3153e-d5bf-4b7e-b517-fb518e17f34c\u0027,"},{"line_number":169,"context_line":"                     address\u003d\u0027fe:54:00:77:07:d9\u0027,"},{"line_number":170,"context_line":"                     extra\u003d{\u0027foo\u0027: \u0027bar\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_a775b432","line":167,"in_reply_to":"9ad45d7e_298c5f7e","updated":"2016-08-12 03:36:29.000000000","message":"Yes, that is a problem; it is causing pep8 to fail.","commit_id":"95c72c666e2dfdc783cbf70e3e56ada3452ee948"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e7b5c9f050f85653447043968de42b04fb7d3750","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @classmethod"},{"line_number":165,"context_line":"    def sample(cls, expand\u003dTrue):"},{"line_number":166,"context_line":"        now \u003d datetime.datetime.utcfromtimestamp(int(os.environ.get("},{"line_number":167,"context_line":"            \u0027SOURCE_DATE_EPOCH\u0027, time.time())))"},{"line_number":168,"context_line":"        sample \u003d cls(uuid\u003d\u002727e3153e-d5bf-4b7e-b517-fb518e17f34c\u0027,"},{"line_number":169,"context_line":"                     address\u003d\u0027fe:54:00:77:07:d9\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_de40a10a","line":166,"updated":"2016-10-04 14:16:16.000000000","message":"to avoid questions about SOURCE_DATE_EPOCH and to have consistency, I think we should use what node.py \u0026 chassis.py do:\n    time \u003d datetime.datetime(2000, 1, 1, 12, 0, 0)\n\nThere\u0027s no need to use the current time, this is just a sample. In fact, because it is a sample, it is probably best if the time doesn\u0027t get changed every time it is generated.","commit_id":"6ca299cf3f67118e149eb5ef2a524e19a7cd8270"}]}