)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1ecd4458b5834d07f22e5000aacd6c6a4f954833","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-10 11:18:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source openrc on subnode in multinide topology"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sourcing openrc occurs only when keystone service is enabled on node [0]"},{"line_number":10,"context_line":"Since Ironic requires access to OSC and openstack clients to setup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_32eaffdb","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":37},"updated":"2016-08-10 16:16:34.000000000","message":"multinode","commit_id":"39f655d592b635f0e3e2064ff35b966ea0a5fc21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f66a77132d2603a70694640523ef82796dc07b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vasyl Saienko \u003cvsaienko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-10 11:18:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Source openrc on subnode in multinide topology"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sourcing openrc occurs only when keystone service is enabled on node [0]"},{"line_number":10,"context_line":"Since Ironic requires access to OSC and openstack clients to setup"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_e2efd51b","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":37},"in_reply_to":"9ad45d7e_32eaffdb","updated":"2016-08-11 09:06:29.000000000","message":"Done","commit_id":"39f655d592b635f0e3e2064ff35b966ea0a5fc21"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"dcf11c9be98ad6b6c18c1e38ff1510ba00ded2fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_f8604b03","line":17,"updated":"2016-08-10 15:39:20.000000000","message":"Need a Depends-On to patch: I7e4ab0fec79f027302baea7257c9851f34d8be39","commit_id":"39f655d592b635f0e3e2064ff35b966ea0a5fc21"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15f66a77132d2603a70694640523ef82796dc07b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_22f60df9","line":17,"in_reply_to":"9ad45d7e_b291cf49","updated":"2016-08-11 09:06:29.000000000","message":"right, previous patch depends on that change already.","commit_id":"39f655d592b635f0e3e2064ff35b966ea0a5fc21"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1ecd4458b5834d07f22e5000aacd6c6a4f954833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ad45d7e_b291cf49","line":17,"in_reply_to":"9ad45d7e_f8604b03","updated":"2016-08-10 16:16:34.000000000","message":"Okay, I guess not. The parent patch in this patch chain has the Depends-On.","commit_id":"39f655d592b635f0e3e2064ff35b966ea0a5fc21"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"12240e76c6c6374e062b2b6e4c81ef20378e183c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cleaning_network_uuid for example, we need to source openrc at the beggining."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Reference:"},{"line_number":14,"context_line":"[0] https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1043"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7b8f8fb56ac78382b6d96be32ca586782de65b50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_329ac9b9","line":14,"updated":"2016-08-11 13:50:52.000000000","message":"Can this be made a perma-link?\n\nhttps://help.github.com/articles/getting-permanent-links-to-files/","commit_id":"c4bacc3d5fc4780773586c0f7eb995f7c907e917"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"43ebdf838b6f161cb5d7f3d67e62f1d729fc2dcd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"cleaning_network_uuid for example, we need to source openrc at the beggining."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Reference:"},{"line_number":14,"context_line":"[0] https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1043"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7b8f8fb56ac78382b6d96be32ca586782de65b50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_ee05e045","line":14,"in_reply_to":"9ad45d7e_329ac9b9","updated":"2016-08-11 17:25:33.000000000","message":"Done","commit_id":"c4bacc3d5fc4780773586c0f7eb995f7c907e917"}],"devstack/lib/ironic":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"8b8eea2d6ed034d506a5866acd77f3989aecd73e","unresolved":false,"context_lines":[{"line_number":317,"context_line":"IRONIC_AUTOMATED_CLEAN_ENABLED\u003d$(trueorfalse True IRONIC_AUTOMATED_CLEAN_ENABLED)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# NOTE(vsaienko) to execute OSC calls we need to source openrc for subnode."},{"line_number":320,"context_line":"# source it in stask.sh for nodes without keystone is skipped."},{"line_number":321,"context_line":"if [[ \"$MULTI_HOST_ROLE\" \u003d\u003d \u0027subnode\u0027 ]]; then"},{"line_number":322,"context_line":"    source $TOP_DIR/openrc admin admin"},{"line_number":323,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a8ec9b2_4caa1dd6","line":320,"range":{"start_line":320,"start_character":15,"end_line":320,"end_character":23},"updated":"2016-09-14 00:12:37.000000000","message":"stack.sh  ??\n\nI don\u0027t quite understand this. I don\u0027t see stack.sh (in devstack) sourcing openrc.","commit_id":"f2748eb0d6c1fee60d267d093c84ac97bcefafd8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"176e1a529abfcc1c0c74373d183864f7a926a2c7","unresolved":false,"context_lines":[{"line_number":317,"context_line":"IRONIC_AUTOMATED_CLEAN_ENABLED\u003d$(trueorfalse True IRONIC_AUTOMATED_CLEAN_ENABLED)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# NOTE(vsaienko) to execute OSC calls we need to source openrc for subnode."},{"line_number":320,"context_line":"# source it in stask.sh for nodes without keystone is skipped."},{"line_number":321,"context_line":"if [[ \"$MULTI_HOST_ROLE\" \u003d\u003d \u0027subnode\u0027 ]]; then"},{"line_number":322,"context_line":"    source $TOP_DIR/openrc admin admin"},{"line_number":323,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a8ec9b2_f62c8fad","line":320,"range":{"start_line":320,"start_character":15,"end_line":320,"end_character":23},"in_reply_to":"7a8ec9b2_4caa1dd6","updated":"2016-09-14 06:38:24.000000000","message":"Actually the file is called userrc_early there and it configures openstack ENV variables like openrc.\n\nhttps://github.com/openstack-dev/devstack/blob/fac8adbe1b2bdd2bae105228eb7acf2dd3f30da7/stack.sh#L1038-L1057\n\nI think that NOTE should be changed to something:\n\n\"To allow executing OSC and other clients calls we need to setup ENV variables. It is not happening automatically because keystone is not enabled\"","commit_id":"f2748eb0d6c1fee60d267d093c84ac97bcefafd8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0011f6e2937eab6f3d248eae631f5f06fd03e63a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"IRONIC_AUTOMATED_CLEAN_ENABLED\u003d$(trueorfalse True IRONIC_AUTOMATED_CLEAN_ENABLED)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# NOTE(vsaienko) to execute OSC calls we need to source openrc for subnode."},{"line_number":320,"context_line":"# source it in stask.sh for nodes without keystone is skipped."},{"line_number":321,"context_line":"if [[ \"$MULTI_HOST_ROLE\" \u003d\u003d \u0027subnode\u0027 ]]; then"},{"line_number":322,"context_line":"    source $TOP_DIR/openrc admin admin"},{"line_number":323,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a8ec9b2_2113cf0e","line":320,"range":{"start_line":320,"start_character":15,"end_line":320,"end_character":23},"in_reply_to":"7a8ec9b2_f62c8fad","updated":"2016-09-15 01:15:46.000000000","message":"Sounds good.","commit_id":"f2748eb0d6c1fee60d267d093c84ac97bcefafd8"}]}