)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"40fd81a88c1233fcf569f72ebdd6e4912e715bc7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a workarounds for cases when calling neutronclient.create_port()"},{"line_number":10,"context_line":"or neutronclient.list_ports() may return ports with empty id, or empty"},{"line_number":11,"context_line":"data, without raising an exception. This workarounds masks neutron bugs"},{"line_number":12,"context_line":"rather than fixes root cause permanently."},{"line_number":13,"context_line":"Also for example Nova doesn\u0027t have such workarounds, please see"},{"line_number":14,"context_line":"references. The patch drops them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_ac1c4b14","line":11,"updated":"2016-08-12 17:57:50.000000000","message":"These workarounds mask the neutron bugs","commit_id":"985ef3ba9e39ec653ca9df27c0f118928a94b6dc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d3e59d1bd0a79ab96ae497a97d59ef0a1322017d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a workarounds for cases when calling neutronclient.create_port()"},{"line_number":10,"context_line":"or neutronclient.list_ports() may return ports with empty id, or empty"},{"line_number":11,"context_line":"data, without raising an exception. This workarounds masks neutron bugs"},{"line_number":12,"context_line":"rather than fixes root cause permanently."},{"line_number":13,"context_line":"Also for example Nova doesn\u0027t have such workarounds, please see"},{"line_number":14,"context_line":"references. The patch drops them."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_620d0f90","line":11,"in_reply_to":"9ad45d7e_ac1c4b14","updated":"2016-08-16 07:20:21.000000000","message":"Done","commit_id":"985ef3ba9e39ec653ca9df27c0f118928a94b6dc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"40fd81a88c1233fcf569f72ebdd6e4912e715bc7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We have a workarounds for cases when calling neutronclient.create_port()"},{"line_number":10,"context_line":"or neutronclient.list_ports() may return ports with empty id, or empty"},{"line_number":11,"context_line":"data, without raising an exception. This workarounds masks neutron bugs"},{"line_number":12,"context_line":"rather than fixes root cause permanently."},{"line_number":13,"context_line":"Also for example Nova doesn\u0027t have such workarounds, please see"},{"line_number":14,"context_line":"references. The patch drops them."},{"line_number":15,"context_line":"Also provisioning will be interrupted with NetworkError() only when we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_0c1ab717","line":12,"updated":"2016-08-12 17:57:50.000000000","message":"rather than fixing the root cause.","commit_id":"985ef3ba9e39ec653ca9df27c0f118928a94b6dc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d3e59d1bd0a79ab96ae497a97d59ef0a1322017d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We have a workarounds for cases when calling neutronclient.create_port()"},{"line_number":10,"context_line":"or neutronclient.list_ports() may return ports with empty id, or empty"},{"line_number":11,"context_line":"data, without raising an exception. This workarounds masks neutron bugs"},{"line_number":12,"context_line":"rather than fixes root cause permanently."},{"line_number":13,"context_line":"Also for example Nova doesn\u0027t have such workarounds, please see"},{"line_number":14,"context_line":"references. The patch drops them."},{"line_number":15,"context_line":"Also provisioning will be interrupted with NetworkError() only when we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_0216dba6","line":12,"in_reply_to":"9ad45d7e_0c1ab717","updated":"2016-08-16 07:20:21.000000000","message":"Done","commit_id":"985ef3ba9e39ec653ca9df27c0f118928a94b6dc"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"40fd81a88c1233fcf569f72ebdd6e4912e715bc7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"data, without raising an exception. This workarounds masks neutron bugs"},{"line_number":12,"context_line":"rather than fixes root cause permanently."},{"line_number":13,"context_line":"Also for example Nova doesn\u0027t have such workarounds, please see"},{"line_number":14,"context_line":"references. The patch drops them."},{"line_number":15,"context_line":"Also provisioning will be interrupted with NetworkError() only when we"},{"line_number":16,"context_line":"failed to create all Neutron ports, if at least one port is created"},{"line_number":17,"context_line":"successfully we proceed with deployment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_ec1643f0","line":14,"updated":"2016-08-12 17:57:50.000000000","message":"references. This changes removes the workarounds.","commit_id":"985ef3ba9e39ec653ca9df27c0f118928a94b6dc"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d3e59d1bd0a79ab96ae497a97d59ef0a1322017d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"data, without raising an exception. This workarounds masks neutron bugs"},{"line_number":12,"context_line":"rather than fixes root cause permanently."},{"line_number":13,"context_line":"Also for example Nova doesn\u0027t have such workarounds, please see"},{"line_number":14,"context_line":"references. The patch drops them."},{"line_number":15,"context_line":"Also provisioning will be interrupted with NetworkError() only when we"},{"line_number":16,"context_line":"failed to create all Neutron ports, if at least one port is created"},{"line_number":17,"context_line":"successfully we proceed with deployment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_221317ba","line":14,"in_reply_to":"9ad45d7e_ec1643f0","updated":"2016-08-16 07:20:21.000000000","message":"Done","commit_id":"985ef3ba9e39ec653ca9df27c0f118928a94b6dc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1013273e62d712a0b2abf9e37e644741790e0834","unresolved":false,"context_lines":[{"line_number":14,"context_line":"references. This changes removes the workarounds."},{"line_number":15,"context_line":"Also provisioning will be interrupted with NetworkError() only when we"},{"line_number":16,"context_line":"failed to create all Neutron ports in provisioning network, if at least"},{"line_number":17,"context_line":"one port is created successfully we proceed with deployment."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Reference:"},{"line_number":20,"context_line":"[0]https://github.com/openstack/nova/blob/71c007d9/nova/network/neutronv2/api.py#L1071"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa7ab95a_5980a4c0","line":17,"updated":"2016-08-29 12:25:34.000000000","message":"this should go to a release note","commit_id":"6a33fa7252d7cbafb6617319f0ff20bfab5da8c8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2d10e45e1a0407a6c426ed64c922f07fb95f2e83","unresolved":false,"context_lines":[{"line_number":14,"context_line":"references. This changes removes the workarounds."},{"line_number":15,"context_line":"Also provisioning will be interrupted with NetworkError() only when we"},{"line_number":16,"context_line":"failed to create all Neutron ports in provisioning network, if at least"},{"line_number":17,"context_line":"one port is created successfully we proceed with deployment."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Reference:"},{"line_number":20,"context_line":"[0]https://github.com/openstack/nova/blob/71c007d9/nova/network/neutronv2/api.py#L1071"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa7ab95a_2a136e5c","line":17,"in_reply_to":"fa7ab95a_5980a4c0","updated":"2016-08-29 15:58:15.000000000","message":"Done","commit_id":"6a33fa7252d7cbafb6617319f0ff20bfab5da8c8"}],"ironic/common/neutron.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"64a1ef4daac1bdac3b7cf127369f1ca3e2fae1f6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        body[\u0027port\u0027][\u0027binding:profile\u0027] \u003d binding_profile"},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            port \u003d client.create_port(body)"},{"line_number":126,"context_line":"            ports[ironic_port.uuid] \u003d port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        except neutron_exceptions.NeutronClientException as e:"},{"line_number":128,"context_line":"            failures.append(ironic_port.uuid)"},{"line_number":129,"context_line":"            LOG.debug(\u0027Could not create neutron port for ironic port \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ea976738","line":126,"updated":"2016-08-12 08:53:38.000000000","message":"No need to have this like in the try-except block","commit_id":"37a1aee31228909f98f28d2b5442f9405da32765"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"43f391c5374c20f0cafa9bc61faaf6ed028b36d8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        body[\u0027port\u0027][\u0027binding:profile\u0027] \u003d binding_profile"},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            port \u003d client.create_port(body)"},{"line_number":126,"context_line":"            ports[ironic_port.uuid] \u003d port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        except neutron_exceptions.NeutronClientException as e:"},{"line_number":128,"context_line":"            failures.append(ironic_port.uuid)"},{"line_number":129,"context_line":"            LOG.debug(\u0027Could not create neutron port for ironic port \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_30956e88","line":126,"in_reply_to":"9ad45d7e_ea976738","updated":"2016-08-12 09:24:59.000000000","message":"Done","commit_id":"37a1aee31228909f98f28d2b5442f9405da32765"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"64a1ef4daac1bdac3b7cf127369f1ca3e2fae1f6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            ports[ironic_port.uuid] \u003d port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        except neutron_exceptions.NeutronClientException as e:"},{"line_number":128,"context_line":"            failures.append(ironic_port.uuid)"},{"line_number":129,"context_line":"            LOG.debug(\u0027Could not create neutron port for ironic port \u0027"},{"line_number":130,"context_line":"                      \u0027%(ir-port)s on given network %(net)s from node \u0027"},{"line_number":131,"context_line":"                      \u0027%(node)s. %(exc)s\u0027,"},{"line_number":132,"context_line":"                      {\u0027net\u0027: network_uuid, \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2ac97f5b","line":129,"updated":"2016-08-12 08:53:38.000000000","message":"We were raising exception here earlier, why change this? I\u0027d only remove try-except block with key error","commit_id":"37a1aee31228909f98f28d2b5442f9405da32765"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"43f391c5374c20f0cafa9bc61faaf6ed028b36d8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            ports[ironic_port.uuid] \u003d port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        except neutron_exceptions.NeutronClientException as e:"},{"line_number":128,"context_line":"            failures.append(ironic_port.uuid)"},{"line_number":129,"context_line":"            LOG.debug(\u0027Could not create neutron port for ironic port \u0027"},{"line_number":130,"context_line":"                      \u0027%(ir-port)s on given network %(net)s from node \u0027"},{"line_number":131,"context_line":"                      \u0027%(node)s. %(exc)s\u0027,"},{"line_number":132,"context_line":"                      {\u0027net\u0027: network_uuid, \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_90089adb","line":129,"in_reply_to":"9ad45d7e_2ac97f5b","updated":"2016-08-12 09:24:59.000000000","message":"When we updating tenant ports, or when flat network is used we continue deploy when we have at least 1 operational port.\nFor cleaning/provisioning we should do the same, fail only when all ports failed. \n\nhttps://github.com/openstack/ironic/blob/master/ironic/dhcp/neutron.py#L131","commit_id":"37a1aee31228909f98f28d2b5442f9405da32765"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1ebfe03b4df23edad769977d54d58a85c3bded38","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    if failures:"},{"line_number":137,"context_line":"        if len(failures) \u003d\u003d len(pxe_enabled_ports):"},{"line_number":138,"context_line":"            raise exception.NetworkError(_("},{"line_number":139,"context_line":"                \"Failed to crate neutron ports for any PXE enabled port \""},{"line_number":140,"context_line":"                \"on node %s.\") % node.uuid)"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            LOG.warning(_LW(\"Some errors were encountered when updating \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_10c02a7c","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":32},"updated":"2016-08-12 09:36:29.000000000","message":"create","commit_id":"df3408629eb4cf2955979df1bf4af0e90695b6b8"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"64d3a2679d7d03f0486293b489d8bf8ea27efaab","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    if failures:"},{"line_number":137,"context_line":"        if len(failures) \u003d\u003d len(pxe_enabled_ports):"},{"line_number":138,"context_line":"            raise exception.NetworkError(_("},{"line_number":139,"context_line":"                \"Failed to crate neutron ports for any PXE enabled port \""},{"line_number":140,"context_line":"                \"on node %s.\") % node.uuid)"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            LOG.warning(_LW(\"Some errors were encountered when updating \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_199de959","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":32},"in_reply_to":"9ad45d7e_10c02a7c","updated":"2016-08-12 13:14:50.000000000","message":"Done","commit_id":"df3408629eb4cf2955979df1bf4af0e90695b6b8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c333b72878b7a93e69fdbdee7b347ed4b23191d5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            port \u003d client.create_port(body)"},{"line_number":132,"context_line":"        except neutron_exceptions.NeutronClientException as e:"},{"line_number":133,"context_line":"            failures.append(ironic_port.uuid)"},{"line_number":134,"context_line":"            LOG.warning(_LW(\u0027Could not create neutron port for ironic port \u0027"},{"line_number":135,"context_line":"                        \u0027%(ir-port)s on given network %(net)s from node \u0027"},{"line_number":136,"context_line":"                        \u0027%(node)s. %(exc)s\u0027),"},{"line_number":137,"context_line":"                        {\u0027net\u0027: network_uuid, \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_caa4b0a7","line":134,"updated":"2016-08-22 16:04:15.000000000","message":"I\u0027d suggest:\n\nCould not create neutron port for node\u0027s \u003cuuid\u003e port \u003cport-uuid\u003e on the neutron network \u003cnet-uuid\u003e. \u003cexception\u003e","commit_id":"4a82652c8d098760bb3ccbadb3246c59c2411b1a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a9cf5e9a987b4cf2ff95e1befe746b2efbca4784","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            port \u003d client.create_port(body)"},{"line_number":132,"context_line":"        except neutron_exceptions.NeutronClientException as e:"},{"line_number":133,"context_line":"            failures.append(ironic_port.uuid)"},{"line_number":134,"context_line":"            LOG.warning(_LW(\u0027Could not create neutron port for ironic port \u0027"},{"line_number":135,"context_line":"                        \u0027%(ir-port)s on given network %(net)s from node \u0027"},{"line_number":136,"context_line":"                        \u0027%(node)s. %(exc)s\u0027),"},{"line_number":137,"context_line":"                        {\u0027net\u0027: network_uuid, \u0027node\u0027: node.uuid,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_2df2be6f","line":134,"in_reply_to":"1ac06dbe_caa4b0a7","updated":"2016-08-22 16:53:16.000000000","message":"Done","commit_id":"4a82652c8d098760bb3ccbadb3246c59c2411b1a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"2276b8840cc9282f4b627d8f1cdd1a3698a5d310","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if failures:"},{"line_number":143,"context_line":"        if len(failures) \u003d\u003d len(pxe_enabled_ports):"},{"line_number":144,"context_line":"            rollback_ports(task, network_uuid)"},{"line_number":145,"context_line":"            raise exception.NetworkError(_("},{"line_number":146,"context_line":"                \"Failed to create neutron ports for any PXE enabled port \""},{"line_number":147,"context_line":"                \"on node %s.\") % node.uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_0c3f06b5","line":144,"updated":"2016-08-26 15:53:08.000000000","message":"Why do we do this? We have not created any ports.","commit_id":"7500c1598b73c4a49d281997cdb347deef281d52"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"219c708ffdc732f5953fd2464bee5cf268759c20","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if failures:"},{"line_number":143,"context_line":"        if len(failures) \u003d\u003d len(pxe_enabled_ports):"},{"line_number":144,"context_line":"            rollback_ports(task, network_uuid)"},{"line_number":145,"context_line":"            raise exception.NetworkError(_("},{"line_number":146,"context_line":"                \"Failed to create neutron ports for any PXE enabled port \""},{"line_number":147,"context_line":"                \"on node %s.\") % node.uuid)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_2cc92a79","line":144,"in_reply_to":"fa7ab95a_0c3f06b5","updated":"2016-08-26 15:59:06.000000000","message":"It is possible (but unlikely) that the neutron client raises an exception but the request goes through successfully on the Neutron side. I guess this is here as a safety just in case that happens.","commit_id":"7500c1598b73c4a49d281997cdb347deef281d52"}],"ironic/tests/unit/common/test_neutron.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c333b72878b7a93e69fdbdee7b347ed4b23191d5","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                                                 is_flat\u003dTrue)"},{"line_number":216,"context_line":"            self.assertEqual(expected, ports)"},{"line_number":217,"context_line":"            self.client_mock.create_port.assert_called_once_with("},{"line_number":218,"context_line":"                expected_body)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_add_ports_with_client_id_to_flat_network(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_caf95082","line":218,"updated":"2016-08-22 16:04:15.000000000","message":"pep8 complains here.","commit_id":"4a82652c8d098760bb3ccbadb3246c59c2411b1a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"689db2ab5e94a0f68fc7b039a17009955a168307","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            self.client_mock.create_port.assert_called_once_with(expected_body)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @mock.patch.object(neutron, \u0027rollback_ports\u0027)"},{"line_number":250,"context_line":"    @mock.patch.object(neutron, \u0027LOG\u0027)"},{"line_number":251,"context_line":"    def test_add_network_all_ports_fail(self, log_mock, rollback_mock):"},{"line_number":252,"context_line":"        # Check that if creating a port fails, the ports are cleaned up"},{"line_number":253,"context_line":"        self.client_mock.create_port.side_effect \u003d \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_480f252e","line":250,"updated":"2016-08-26 22:36:43.000000000","message":"Why is this mocked? Doesn\u0027t seem to be used in an assert.\n\nMaybe need to add some asserts.","commit_id":"7500c1598b73c4a49d281997cdb347deef281d52"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"5d562fbc77e774dec71e40080a06d62a3902cafb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            self.client_mock.create_port.assert_called_once_with(expected_body)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @mock.patch.object(neutron, \u0027rollback_ports\u0027)"},{"line_number":250,"context_line":"    @mock.patch.object(neutron, \u0027LOG\u0027)"},{"line_number":251,"context_line":"    def test_add_network_all_ports_fail(self, log_mock, rollback_mock):"},{"line_number":252,"context_line":"        # Check that if creating a port fails, the ports are cleaned up"},{"line_number":253,"context_line":"        self.client_mock.create_port.side_effect \u003d \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_9e9dc35b","line":250,"in_reply_to":"fa7ab95a_480f252e","updated":"2016-08-29 07:08:49.000000000","message":"Done","commit_id":"7500c1598b73c4a49d281997cdb347deef281d52"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7c83f3a6cbdc648500b003dac1de3c24dbbad6e6","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                expected_body)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_add_ports_to_flat_network(self):"},{"line_number":221,"context_line":"        self._test_add_ports_to_flat_network(is_client_id\u003dFalse)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def test_add_ports_with_client_id_to_flat_network(self):"},{"line_number":224,"context_line":"        self._test_add_ports_to_flat_network(is_client_id\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_ee76b604","side":"PARENT","line":221,"updated":"2016-08-30 14:02:57.000000000","message":"Oops, this should not be removed.","commit_id":"5e07d2bb4c82fc0c0fc5bf87a0213b6741f01241"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7c83f3a6cbdc648500b003dac1de3c24dbbad6e6","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            rollback_mock.assert_called_once_with(task, self.network_uuid)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @mock.patch.object(neutron, \u0027LOG\u0027)"},{"line_number":262,"context_line":"    def test_add_network_fail_create_some_ports(self, log_mock):"},{"line_number":263,"context_line":"        object_utils.create_test_port("},{"line_number":264,"context_line":"            self.context, node_id\u003dself.node.id,"},{"line_number":265,"context_line":"            uuid\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_4ecde22f","line":262,"updated":"2016-08-30 14:02:57.000000000","message":"create_some_ports_fail","commit_id":"191ae6e8e01dc301ff0a8a3159279dc7105ced8b"}],"releasenotes/notes/remove-neutron-client-workarounds-996c59623684929b.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d36346ac359cf5dab91b32e885a41fd69efda0da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update create provisioning ports logic to fail only"},{"line_number":5,"context_line":"    when all neutron ports were not created. If we"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_fe43486a","line":2,"updated":"2016-09-01 08:17:17.000000000","message":"s/other/fixes/","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"22bfb146f2eccd50a488b73cf90b229d3322b231","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update create provisioning ports logic to fail only"},{"line_number":5,"context_line":"    when all neutron ports were not created. If we"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_cc221aa3","line":2,"in_reply_to":"fa7ab95a_fe43486a","updated":"2016-09-02 07:42:47.000000000","message":"Done","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d36346ac359cf5dab91b32e885a41fd69efda0da","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update create provisioning ports logic to fail only"},{"line_number":5,"context_line":"    when all neutron ports were not created. If we"},{"line_number":6,"context_line":"    created at least one neutron port, proceed with the"},{"line_number":7,"context_line":"    deployment. It was default behaviour for flat"},{"line_number":8,"context_line":"    scenario."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_1e470c78","line":5,"updated":"2016-09-01 08:17:17.000000000","message":"better: when no neutron ports were created","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"22bfb146f2eccd50a488b73cf90b229d3322b231","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Update create provisioning ports logic to fail only"},{"line_number":5,"context_line":"    when all neutron ports were not created. If we"},{"line_number":6,"context_line":"    created at least one neutron port, proceed with the"},{"line_number":7,"context_line":"    deployment. It was default behaviour for flat"},{"line_number":8,"context_line":"    scenario."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_ec427e3d","line":5,"in_reply_to":"fa7ab95a_1e470c78","updated":"2016-09-02 07:42:47.000000000","message":"Done","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d36346ac359cf5dab91b32e885a41fd69efda0da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Update create provisioning ports logic to fail only"},{"line_number":5,"context_line":"    when all neutron ports were not created. If we"},{"line_number":6,"context_line":"    created at least one neutron port, proceed with the"},{"line_number":7,"context_line":"    deployment. It was default behaviour for flat"},{"line_number":8,"context_line":"    scenario."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Drop neutron client workarounds when we expected"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_3e5e9045","line":7,"updated":"2016-09-01 08:17:17.000000000","message":"nit: the default","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"22bfb146f2eccd50a488b73cf90b229d3322b231","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Update create provisioning ports logic to fail only"},{"line_number":5,"context_line":"    when all neutron ports were not created. If we"},{"line_number":6,"context_line":"    created at least one neutron port, proceed with the"},{"line_number":7,"context_line":"    deployment. It was default behaviour for flat"},{"line_number":8,"context_line":"    scenario."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Drop neutron client workarounds when we expected"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_8c7ad286","line":7,"in_reply_to":"fa7ab95a_3e5e9045","updated":"2016-09-02 07:42:47.000000000","message":"Done","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d36346ac359cf5dab91b32e885a41fd69efda0da","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    scenario."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Drop neutron client workarounds when we expected"},{"line_number":11,"context_line":"    neutron port may return body with empty id."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_5e59945a","line":11,"updated":"2016-09-01 08:17:17.000000000","message":"I think this one is not needed, it\u0027s an internal refactoring. Only the first note is valuable for operators/users.","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c3e5708f1b0dd48f08519ee2bb9068ece1d967e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    deployment. It was default behaviour for flat"},{"line_number":8,"context_line":"    scenario."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Drop neutron client workarounds when we expected"},{"line_number":11,"context_line":"    neutron port may return body with empty id."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa7ab95a_c171b50d","line":11,"range":{"start_line":10,"start_character":4,"end_line":11,"end_character":47},"updated":"2016-08-30 16:53:58.000000000","message":"This reads a bit awkward to me. And I don\u0027t quite understand it.\n\nI\u0027m not sure what it is trying to say.","commit_id":"5ab9d4122da8366f2f1eddadcf95fdd2ac596f71"}]}
