)]}'
{"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"15cb824a458221270619628df74f1ebd56762763","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def skip_checks(cls):"},{"line_number":60,"context_line":"        super(BaremetalScenarioTest, cls).skip_checks()"},{"line_number":61,"context_line":"        if not CONF.baremetal.driver_enabled:"},{"line_number":62,"context_line":"            msg \u003d \u0027Ironic not available or Ironic compute driver not enabled\u0027"},{"line_number":63,"context_line":"            raise cls.skipException(msg)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_70a7bba6","side":"PARENT","line":61,"updated":"2016-11-12 21:30:07.000000000","message":"Do we really want to drop this check? Looks useful to me.","commit_id":"f6334c0ff51ce51ab0750e6d93ecc2528ff64c27"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ab3dc47cdfa9a5e89f1d9a42fc0f8a808deedb74","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def skip_checks(cls):"},{"line_number":60,"context_line":"        super(BaremetalScenarioTest, cls).skip_checks()"},{"line_number":61,"context_line":"        if not CONF.baremetal.driver_enabled:"},{"line_number":62,"context_line":"            msg \u003d \u0027Ironic not available or Ironic compute driver not enabled\u0027"},{"line_number":63,"context_line":"            raise cls.skipException(msg)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_5962bfae","side":"PARENT","line":61,"in_reply_to":"9a629dbe_70a7bba6","updated":"2016-11-14 15:00:33.000000000","message":"Probably not, I think tempest folks convinced Thiago this wasn\u0027t a good config to have... I\u0027m not sure. Will think about it.","commit_id":"f6334c0ff51ce51ab0750e6d93ecc2528ff64c27"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"fdec8b5c64aa7fa637d045763ca04659474ebdd0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if CONF.baremetal.use_provision_network:"},{"line_number":50,"context_line":"            msg \u003d (\"Ironic/Neutron tenant isolation is configured but isn\u0027t\""},{"line_number":51,"context_line":"                   \"supported by this test scenario.\")"},{"line_number":52,"context_line":"            raise cls.skipException(msg)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def rebuild_instance(self, preserve_ephemeral\u003dFalse):"},{"line_number":55,"context_line":"        self.rebuild_server(server_id\u003dself.instance[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_5ad1cafa","line":52,"updated":"2016-08-25 14:14:48.000000000","message":"Not sure this is true :)","commit_id":"c78228166e9bbb142216f939c2166bdd2dba98c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"47ea1907db1be3ba0e4dc4f7f1a2a0e20429e814","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        * Monitors the associated Ironic node for power and"},{"line_number":40,"context_line":"          expected state transitions"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def rebuild_instance(self, preserve_ephemeral\u003dFalse):"},{"line_number":44,"context_line":"        self.rebuild_server(server_id\u003dself.instance[\u0027id\u0027],"},{"line_number":45,"context_line":"                            preserve_ephemeral\u003dpreserve_ephemeral,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_3f234b07","line":42,"updated":"2016-11-14 19:29:22.000000000","message":"nit: unrelated change","commit_id":"ab6f73f7a06a9c9e497762e1dc917a9626cccd26"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ffbb2f118c6e6feb0b44fd02bab082a126d008f1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        * Monitors the associated Ironic node for power and"},{"line_number":40,"context_line":"          expected state transitions"},{"line_number":41,"context_line":"    \"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def rebuild_instance(self, preserve_ephemeral\u003dFalse):"},{"line_number":44,"context_line":"        self.rebuild_server(server_id\u003dself.instance[\u0027id\u0027],"},{"line_number":45,"context_line":"                            preserve_ephemeral\u003dpreserve_ephemeral,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_84516465","line":42,"in_reply_to":"7a77a97e_3f234b07","updated":"2016-11-15 02:24:43.000000000","message":"yeah, nice point.\nThe original Tempest code also doesn\u0027t this new line like https://review.openstack.org/#/c/355586/16/tempest/scenario/test_baremetal_basic_ops.py\n\nso I am not sure why this change comes, but that seems nit.\nIt would be nice to merge, I guess.","commit_id":"ab6f73f7a06a9c9e497762e1dc917a9626cccd26"}]}