)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fbbffe5e27ce546f01633a1ddb69b56e07e38d4c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some part in the code we import objects."},{"line_number":10,"context_line":"In the Openstack style guidelines they recommend to import only"},{"line_number":11,"context_line":"modules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib3ded82524071c97f4e0508af7933ead63cc2dc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_ac44d91a","line":11,"updated":"2016-08-17 08:51:06.000000000","message":"Would be good to have a link to the guidelines here:\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"52f21ceb52cd8891b125411aefe1700337e26ceb"}],"ironic/api/app.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d1961850f4a922a87455fdcf03f261797093812a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import keystonemiddleware.audit as audit_middleware"},{"line_number":19,"context_line":"from keystonemiddleware import audit"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"import oslo_middleware.cors as cors_middleware"},{"line_number":22,"context_line":"import pecan"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_4a7a3e78","line":19,"updated":"2016-08-17 19:58:58.000000000","message":"+1 but a follow-up patch is fine with me. Maybe just use the import from L18 and delete this import","commit_id":"d9bc09a4f5f756d1021f3c48d4a7be31852a5b25"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"71d1f4a3c234c39f0cd8f4871a6d72b4f0bf4e24","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import keystonemiddleware.audit as audit_middleware"},{"line_number":19,"context_line":"from keystonemiddleware import audit"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"import oslo_middleware.cors as cors_middleware"},{"line_number":22,"context_line":"import pecan"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_333944a5","line":19,"updated":"2016-08-17 17:14:41.000000000","message":"this line is now a duplicate of the import above it","commit_id":"d9bc09a4f5f756d1021f3c48d4a7be31852a5b25"}],"ironic/drivers/modules/amt/common.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"71d1f4a3c234c39f0cd8f4871a6d72b4f0bf4e24","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironic.common import boot_devices"},{"line_number":26,"context_line":"from ironic.common import exception"},{"line_number":27,"context_line":"from ironic.common.i18n import _"},{"line_number":28,"context_line":"from ironic.common.i18n import _LE"},{"line_number":29,"context_line":"from ironic.common import utils"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_133ec88b","line":27,"updated":"2016-08-17 17:14:41.000000000","message":"++","commit_id":"d9bc09a4f5f756d1021f3c48d4a7be31852a5b25"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"21b40db7c8999a7d7dac5b8085ab725a1cf5deb9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironic.common import boot_devices"},{"line_number":26,"context_line":"from ironic.common import exception"},{"line_number":27,"context_line":"from ironic.common.i18n import _"},{"line_number":28,"context_line":"from ironic.common.i18n import _LE"},{"line_number":29,"context_line":"from ironic.common import utils"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_8333a3aa","line":27,"updated":"2016-08-17 11:14:36.000000000","message":"According to the example in the doc importing i18n should be done in one line: from ironic.common.i18n import _, _LE","commit_id":"d9bc09a4f5f756d1021f3c48d4a7be31852a5b25"}],"ironic/drivers/modules/msftocs/msftocsclient.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"21b40db7c8999a7d7dac5b8085ab725a1cf5deb9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from requests import exceptions as requests_exceptions"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from ironic.common import exception"},{"line_number":30,"context_line":"from ironic.common.i18n import _"},{"line_number":31,"context_line":"from ironic.common.i18n import _LE"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_4316cbf1","line":30,"updated":"2016-08-17 11:14:36.000000000","message":"ditto about i18n","commit_id":"d9bc09a4f5f756d1021f3c48d4a7be31852a5b25"}],"ironic/tests/unit/drivers/modules/amt/utils.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fbbffe5e27ce546f01633a1ddb69b56e07e38d4c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from xml import etree as et"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_4ce60545","line":18,"updated":"2016-08-17 08:51:06.000000000","message":"nit: just leave it as etree ?","commit_id":"52f21ceb52cd8891b125411aefe1700337e26ceb"}]}