)]}'
{"ironic/conductor/manager.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fce31313ae28560680ec17c1ca33b375b53117bf","unresolved":false,"context_lines":[{"line_number":1649,"context_line":"        LOG.debug(\"RPC update_port called for port %s.\", port_uuid)"},{"line_number":1650,"context_line":"        node \u003d objects.Node.get(context, port_obj.node_id)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"        with task_manager.acquire(context, node.uuid,"},{"line_number":1653,"context_line":"                                  purpose\u003d\u0027port update\u0027) as task:"},{"line_number":1654,"context_line":"            node \u003d task.node"},{"line_number":1655,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_67e9a180","line":1652,"range":{"start_line":1652,"start_character":43,"end_line":1652,"end_character":52},"updated":"2016-08-16 06:43:11.000000000","message":"But I can see many other places in this file still using node_id. If we want to use uuid, would you fix all of them ?","commit_id":"dd31819000890b41c7d90851df0ca65409fa6a1a"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"3b25dbd8f987b6534652c44a360f7f997c9e1f48","unresolved":false,"context_lines":[{"line_number":1649,"context_line":"        LOG.debug(\"RPC update_port called for port %s.\", port_uuid)"},{"line_number":1650,"context_line":"        node \u003d objects.Node.get(context, port_obj.node_id)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"        with task_manager.acquire(context, node.uuid,"},{"line_number":1653,"context_line":"                                  purpose\u003d\u0027port update\u0027) as task:"},{"line_number":1654,"context_line":"            node \u003d task.node"},{"line_number":1655,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_6227cf64","line":1652,"range":{"start_line":1652,"start_character":43,"end_line":1652,"end_character":52},"in_reply_to":"3ac371cc_67e9a180","updated":"2016-08-16 06:59:38.000000000","message":"Yes, the argument name is \u0027node_id\", but in fact the RPC caller passed “node_uuid\" to the other functions.","commit_id":"dd31819000890b41c7d90851df0ca65409fa6a1a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3a922200c63cbd7c743b3d268de5760c9a1e1ff9","unresolved":false,"context_lines":[{"line_number":1648,"context_line":"        \"\"\""},{"line_number":1649,"context_line":"        port_uuid \u003d port_obj.uuid"},{"line_number":1650,"context_line":"        LOG.debug(\"RPC update_port called for port %s.\", port_uuid)"},{"line_number":1651,"context_line":"        node \u003d objects.Node.get(context, port_obj.node_id)"},{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"        with task_manager.acquire(context, node.uuid,"},{"line_number":1654,"context_line":"                                  purpose\u003d\u0027port update\u0027) as task:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_55b4af33","line":1651,"updated":"2016-08-17 15:10:55.000000000","message":"I agree with Lucas\u0027s comment below that this seems like the wrong place to make this change.  The doc string for TaskManager\u0027s __init__ method indicates that a ID (as in database ID) value or UUID of the node can be passed in.  I think in essence, that means the fix is along the lines of moving line 214 in task_manager.py up before the debug logging, since the object get method performs the determination of if it is a number or a UUID.","commit_id":"3af5cee2ebeba12ec1bd65a84b40a6698fe8060a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b0b8265d4af6c31cb0bcd04e094957f82e7dc7d5","unresolved":false,"context_lines":[{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"        with task_manager.acquire(context, node.uuid,"},{"line_number":1654,"context_line":"                                  purpose\u003d\u0027port update\u0027) as task:"},{"line_number":1655,"context_line":"            node \u003d task.node"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"            # Only allow updating MAC addresses for active nodes if maintenance"},{"line_number":1658,"context_line":"            # mode is on."}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_2ca62953","line":1655,"updated":"2016-08-17 09:04:37.000000000","message":"I think these are the wrong places to fix it, perhaps we could have a log at the task_manager.py [0] module that will check if the node_id is an uuid or numerical ID and in case of the latter we get the node object first and log the UUID ?\n\nThat will fix this problem for all, present and future, acquire() calls in Ironic.\n\n[0] https://github.com/openstack/ironic/blob/master/ironic/conductor/task_manager.py#L206\n\nHint: Just use the oslo\u0027s uuidutils.is_uuid_like() to figure out whether it\u0027s an UUID or not.","commit_id":"3af5cee2ebeba12ec1bd65a84b40a6698fe8060a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0a26be948dfa8b4e5dac8b3c56394fe3ad25c7b8","unresolved":false,"context_lines":[{"line_number":1652,"context_line":""},{"line_number":1653,"context_line":"        with task_manager.acquire(context, node.uuid,"},{"line_number":1654,"context_line":"                                  purpose\u003d\u0027port update\u0027) as task:"},{"line_number":1655,"context_line":"            node \u003d task.node"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"            # Only allow updating MAC addresses for active nodes if maintenance"},{"line_number":1658,"context_line":"            # mode is on."}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_cc3955f4","line":1655,"in_reply_to":"3ac371cc_2ca62953","updated":"2016-08-17 09:05:11.000000000","message":"Typo: have a logic at the task_manager.py*","commit_id":"3af5cee2ebeba12ec1bd65a84b40a6698fe8060a"}],"ironic/conductor/task_manager.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1df887e01151dd1cd7a480cd37f14908aafe1302","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        self._debug_timer \u003d timeutils.StopWatch()"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        try:"},{"line_number":206,"context_line":"            node \u003d objects.Node.get(context, node_id)"},{"line_number":207,"context_line":"            LOG.debug(\"Attempting to get %(type)s lock on node %(node)s (for \""},{"line_number":208,"context_line":"                      \"%(purpose)s)\","},{"line_number":209,"context_line":"                      {\u0027type\u0027: \u0027shared\u0027 if shared else \u0027exclusive\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_dda20b9a","line":206,"updated":"2016-08-19 09:10:52.000000000","message":"I was wondering if we need a try..except blog to log a better message here, but I think we are grand. This method was expected to return NodeNotFound already","commit_id":"48790b66aadf503b7720770989d77b0bb8fa5365"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1df887e01151dd1cd7a480cd37f14908aafe1302","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            node \u003d self.passthru.lookup(task.context, **kwargs)"},{"line_number":196,"context_line":"        self.assertEqual(expected, node[\u0027node\u0027])"},{"line_number":197,"context_line":"        self.assertEqual([mock.call(self.context, self.node.uuid),"},{"line_number":198,"context_line":"                         mock.call(self.context, \u0027fake-uuid\u0027)],"},{"line_number":199,"context_line":"                         mock_get_node.call_args_list)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @mock.patch.object(objects.port.Port, \u0027get_by_address\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_1d55c3c5","line":198,"range":{"start_line":198,"start_character":24,"end_line":198,"end_character":25},"updated":"2016-08-19 09:10:52.000000000","message":"Indentation here will fail on pep8","commit_id":"48790b66aadf503b7720770989d77b0bb8fa5365"}]}
