)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f62ffba50b75f5350b6f0a72f58683dfc526394d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow changing lock purpose on lock upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Upgrading inintial shared lock might have a reason, e.g performing a"},{"line_number":10,"context_line":"non-asyc deployment task on heartbeat made through the new heartbeat"},{"line_number":11,"context_line":"API."},{"line_number":12,"context_line":"Let\u0027s alllow changing the lock purpose on lock upgrade to have"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_1f9f26b5","line":9,"updated":"2016-08-16 20:35:20.000000000","message":"There maybe a reason to change the \u0027purpose\u0027 of a lock, for example performing a","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f62ffba50b75f5350b6f0a72f58683dfc526394d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Upgrading inintial shared lock might have a reason, e.g performing a"},{"line_number":10,"context_line":"non-asyc deployment task on heartbeat made through the new heartbeat"},{"line_number":11,"context_line":"API."},{"line_number":12,"context_line":"Let\u0027s alllow changing the lock purpose on lock upgrade to have"},{"line_number":13,"context_line":"better logging."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ife86e2b0dc74eaac7163000ea89cdb80a6cd3e87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_7fa61a11","line":12,"updated":"2016-08-16 20:35:20.000000000","message":"Allow changing of the lock purpose on lock upgrade to have","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"289e9282a9844a0588ae273d2ea5b3096aeda518","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There may be a reason to change the \u0027purpose\u0027 of a lock,"},{"line_number":10,"context_line":"for example performing a non-asyc deployment task on heartbeat"},{"line_number":11,"context_line":"made through the new heartbeat API."},{"line_number":12,"context_line":"Alllow changing of the lock purpose on lock upgrade to have better logging."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ife86e2b0dc74eaac7163000ea89cdb80a6cd3e87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_767a7889","line":12,"updated":"2016-08-17 23:27:07.000000000","message":"nit: Allow  (only two l characters)","commit_id":"449b56fc7f0e8a92e5e2b91efa3ba370e788e6ac"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1e3cd2503efeca65252273c543eb3801ab61ff4e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There may be a reason to change the \u0027purpose\u0027 of a lock,"},{"line_number":10,"context_line":"for example performing a non-asyc deployment task on heartbeat"},{"line_number":11,"context_line":"made through the new heartbeat API."},{"line_number":12,"context_line":"Alllow changing of the lock purpose on lock upgrade to have better logging."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ife86e2b0dc74eaac7163000ea89cdb80a6cd3e87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_a2ae602b","line":12,"in_reply_to":"3ac371cc_767a7889","updated":"2016-08-18 07:16:00.000000000","message":"oops :) will change if there would be another patch-set","commit_id":"449b56fc7f0e8a92e5e2b91efa3ba370e788e6ac"}],"ironic/conductor/task_manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"49a2c46eee87d2dae065cbbb6cfb5fb01fc73548","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        Also reloads node object from the database."},{"line_number":260,"context_line":"        If lock is already exclusive only changes the lock purpose"},{"line_number":261,"context_line":"        when provided with one."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param purpose: optionally change the purpose of the lock"},{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_cb11095f","line":262,"updated":"2016-08-17 23:23:25.000000000","message":"Ah, thanks I see it now :)","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f62ffba50b75f5350b6f0a72f58683dfc526394d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        Also reloads node object from the database."},{"line_number":260,"context_line":"        If lock is already exclusive only changes the lock purpose"},{"line_number":261,"context_line":"        when provided with one."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param purpose: optionally change the purpose of the lock"},{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_5fa99ede","line":262,"updated":"2016-08-16 20:35:20.000000000","message":"Please add a unit test to ensure that purpose does not get changed when set to None","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bc2d0fda524eadfb0fe159b8ec042430fe2971b3","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        Also reloads node object from the database."},{"line_number":260,"context_line":"        If lock is already exclusive only changes the lock purpose"},{"line_number":261,"context_line":"        when provided with one."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param purpose: optionally change the purpose of the lock"},{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_5b899574","line":262,"in_reply_to":"3ac371cc_5fa99ede","updated":"2016-08-17 10:34:54.000000000","message":"the unit test provided makes two upgrade calls, one without purpose (which is the same as purpose is None) and checks the _purpose is not changed, and next with purpose on already exclusive lock, and checks that _purpose is updated.\n\nwhat other test do you have in mind?","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f62ffba50b75f5350b6f0a72f58683dfc526394d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if purpose:"},{"line_number":268,"context_line":"            self._purpose \u003d purpose"},{"line_number":269,"context_line":"        if self.shared:"},{"line_number":270,"context_line":"            LOG.debug(\u0027Upgrading shared lock on node %(uuid)s for %(purpose)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_bfb09244","line":267,"updated":"2016-08-16 20:35:20.000000000","message":"if purpose is not None:","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"bc2d0fda524eadfb0fe159b8ec042430fe2971b3","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""},{"line_number":266,"context_line":"        \"\"\""},{"line_number":267,"context_line":"        if purpose:"},{"line_number":268,"context_line":"            self._purpose \u003d purpose"},{"line_number":269,"context_line":"        if self.shared:"},{"line_number":270,"context_line":"            LOG.debug(\u0027Upgrading shared lock on node %(uuid)s for %(purpose)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_fb9841c2","line":267,"in_reply_to":"3ac371cc_bfb09244","updated":"2016-08-17 10:34:54.000000000","message":"will change","commit_id":"989112b4a6cb320bf4f9c60aa016cb0737a38a4d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"09bfe126f77b414c737b987026580e16e3530604","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        If lock is already exclusive only changes the lock purpose"},{"line_number":261,"context_line":"        when provided with one."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param purpose: optionally change the purpose of the lock"},{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""},{"line_number":266,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_35aaa519","line":263,"updated":"2016-08-18 08:35:30.000000000","message":"nit: dot at the end","commit_id":"449b56fc7f0e8a92e5e2b91efa3ba370e788e6ac"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cf34070a94774e9bb85048c62f52d13c023d6eda","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        If lock is already exclusive only changes the lock purpose"},{"line_number":261,"context_line":"        when provided with one."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        :param purpose: optionally change the purpose of the lock"},{"line_number":264,"context_line":"        :raises: NodeLocked if an exclusive lock remains on the node after"},{"line_number":265,"context_line":"                            \"node_locked_retry_attempts\""},{"line_number":266,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_444ae328","line":263,"in_reply_to":"3ac371cc_35aaa519","updated":"2016-08-18 20:19:27.000000000","message":"@Vasyl, I don\u0027t think we have a convention of adding a period at the end. Personally, I don\u0027t like periods unless there is more than one sentence.","commit_id":"449b56fc7f0e8a92e5e2b91efa3ba370e788e6ac"}]}