)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ironic resources CRUD notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds notifications for create, update or delete ironic"},{"line_number":10,"context_line":"resources. Event types general form are:"},{"line_number":11,"context_line":"baremetal.\u003cresource\u003e.{create, update, delete}.{start,end,success,error}"},{"line_number":12,"context_line":"Developer documentation updated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a629dbe_3aa4eba4","line":9,"updated":"2016-11-08 19:28:46.000000000","message":"nit: you may want to add that this is just for chassis, port, and node resources\n\nthings like portgroups aren\u0027t included yet","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ironic resources CRUD notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds notifications for create, update or delete ironic"},{"line_number":10,"context_line":"resources. Event types general form are:"},{"line_number":11,"context_line":"baremetal.\u003cresource\u003e.{create, update, delete}.{start,end,success,error}"},{"line_number":12,"context_line":"Developer documentation updated."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9a629dbe_2f89e626","line":9,"in_reply_to":"9a629dbe_3aa4eba4","updated":"2016-11-09 14:02:56.000000000","message":"Done","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2da11aa665cf4cdfec55acda1427ace72de68913","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds notifications for create, update or delete ironic"},{"line_number":10,"context_line":"resources (node, port and chassis). Event types general form are:"},{"line_number":11,"context_line":"baremetal.\u003cresource\u003e.{create, update, delete}.{start,end,success,error}"},{"line_number":12,"context_line":"Developer documentation updated."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1606520"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1a6eadb0_f1314d5b","line":11,"updated":"2016-12-15 20:53:57.000000000","message":"no success now, right?","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e8ad997a2eb3743f96555a2e52b9f360d0bf6e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds notifications for create, update or delete ironic"},{"line_number":10,"context_line":"resources (node, port and chassis). Event types general form are:"},{"line_number":11,"context_line":"baremetal.\u003cresource\u003e.{create, update, delete}.{start,end,success,error}"},{"line_number":12,"context_line":"Developer documentation updated."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partial-Bug: #1606520"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1a6eadb0_57dc9a45","line":11,"in_reply_to":"1a6eadb0_f1314d5b","updated":"2016-12-16 11:58:16.000000000","message":"Done","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"}],"doc/source/deploy/notifications.rst":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70c2acffda578685e65d0070a3a05c6b538ea2f2","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"List of CRUD notifications for node:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* ``baremetal.node.create.success``"},{"line_number":114,"context_line":"* ``baremetal.node.update.start``"},{"line_number":115,"context_line":"* ``baremetal.node.update.end``"},{"line_number":116,"context_line":"* ``baremetal.node.update.error``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"5a74a57a_80190a7c","line":113,"range":{"start_line":113,"start_character":2,"end_line":113,"end_character":35},"updated":"2016-11-24 13:22:48.000000000","message":"what about error here? this doesn\u0027t differ much from update","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9e770ffacdd0fc0cc5b4832bc2d5e704d3b831c4","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"List of CRUD notifications for node:"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* ``baremetal.node.create.success``"},{"line_number":114,"context_line":"* ``baremetal.node.update.start``"},{"line_number":115,"context_line":"* ``baremetal.node.update.end``"},{"line_number":116,"context_line":"* ``baremetal.node.update.error``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"5a74a57a_8c24c0af","line":113,"range":{"start_line":113,"start_character":2,"end_line":113,"end_character":35},"in_reply_to":"5a74a57a_80190a7c","updated":"2016-11-25 14:04:29.000000000","message":"There is a difference. API service currently creates all resources via direct DB access.","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":79,"context_line":"These notifications are emitted from API service when ironic resources are"},{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. There"},{"line_number":81,"context_line":"are the same actions for different resources: \"create\", \"update\" and \"delete\""},{"line_number":82,"context_line":"with statuses described above. All CRUD notifications are emitted at INFO"},{"line_number":83,"context_line":"level, except with \"error\" status that has ERROR."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"List of CRUD notifications for chassis:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"5a74a57a_0bb891c7","line":82,"range":{"start_line":82,"start_character":24,"end_line":82,"end_character":29},"updated":"2016-11-25 16:01:54.000000000","message":"Don\u0027t see any statuses described above?","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"These notifications are emitted from API service when ironic resources are"},{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. There"},{"line_number":81,"context_line":"are the same actions for different resources: \"create\", \"update\" and \"delete\""},{"line_number":82,"context_line":"with statuses described above. All CRUD notifications are emitted at INFO"},{"line_number":83,"context_line":"level, except with \"error\" status that has ERROR."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"List of CRUD notifications for chassis:"}],"source_content_type":"text/x-rst","patch_set":21,"id":"5a74a57a_e6f0c3ff","line":82,"range":{"start_line":82,"start_character":24,"end_line":82,"end_character":29},"in_reply_to":"5a74a57a_0bb891c7","updated":"2016-11-28 08:54:39.000000000","message":"Done","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. There"},{"line_number":81,"context_line":"are the same actions for different resources: \"create\", \"update\" and \"delete\""},{"line_number":82,"context_line":"with statuses described above. All CRUD notifications are emitted at INFO"},{"line_number":83,"context_line":"level, except with \"error\" status that has ERROR."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"List of CRUD notifications for chassis:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"5a74a57a_2bbd4db7","line":83,"range":{"start_line":83,"start_character":14,"end_line":83,"end_character":18},"updated":"2016-11-25 16:01:54.000000000","message":"for","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. There"},{"line_number":81,"context_line":"are the same actions for different resources: \"create\", \"update\" and \"delete\""},{"line_number":82,"context_line":"with statuses described above. All CRUD notifications are emitted at INFO"},{"line_number":83,"context_line":"level, except with \"error\" status that has ERROR."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"List of CRUD notifications for chassis:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"5a74a57a_cbc21934","line":83,"range":{"start_line":83,"start_character":39,"end_line":83,"end_character":48},"updated":"2016-11-25 16:01:54.000000000","message":"is emitted at ERROR level","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. There"},{"line_number":81,"context_line":"are the same actions for different resources: \"create\", \"update\" and \"delete\""},{"line_number":82,"context_line":"with statuses described above. All CRUD notifications are emitted at INFO"},{"line_number":83,"context_line":"level, except with \"error\" status that has ERROR."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"List of CRUD notifications for chassis:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"5a74a57a_06f69ff8","line":83,"range":{"start_line":83,"start_character":39,"end_line":83,"end_character":48},"in_reply_to":"5a74a57a_cbc21934","updated":"2016-11-28 08:54:39.000000000","message":"Done","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"----------------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"These notifications are emitted from API service when ironic resources are"},{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. All"},{"line_number":81,"context_line":"CRUD notifications are emitted at INFO level, except for \"error\" status that"},{"line_number":82,"context_line":"is emitted at ERROR level."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a71b18c_d070a842","line":80,"updated":"2016-12-06 20:20:58.000000000","message":"to tie in CRUD with create/update/delete, maybe\n\n.. are modified as part of create, update, or delete (CRUD) [3]_ procedures.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"----------------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"These notifications are emitted from API service when ironic resources are"},{"line_number":80,"context_line":"modified (created, updated, or deleted) as part of CRUD [3]_ procedures. All"},{"line_number":81,"context_line":"CRUD notifications are emitted at INFO level, except for \"error\" status that"},{"line_number":82,"context_line":"is emitted at ERROR level."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a71b18c_caba8c71","line":80,"in_reply_to":"3a71b18c_d070a842","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"}],"doc/source/dev/notifications.rst":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":388,"context_line":"Resources CRUD notifications"},{"line_number":389,"context_line":"----------------------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"These notification are emitted from API service when ironic resource create,"},{"line_number":392,"context_line":"update or deleted. There are the same actions for different resources:"},{"line_number":393,"context_line":"\"create\", \"update\" and \"delete\" with statuses described above. All CRUD"},{"line_number":394,"context_line":"notifications have INFO level, except with \"error\" status that has ERROR."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a629dbe_fafef369","line":391,"range":{"start_line":391,"start_character":6,"end_line":391,"end_character":18},"updated":"2016-11-08 19:28:46.000000000","message":"nit: s/notification/notifications","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":388,"context_line":"Resources CRUD notifications"},{"line_number":389,"context_line":"----------------------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"These notification are emitted from API service when ironic resource create,"},{"line_number":392,"context_line":"update or deleted. There are the same actions for different resources:"},{"line_number":393,"context_line":"\"create\", \"update\" and \"delete\" with statuses described above. All CRUD"},{"line_number":394,"context_line":"notifications have INFO level, except with \"error\" status that has ERROR."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a629dbe_f9f25cd1","line":391,"range":{"start_line":391,"start_character":6,"end_line":391,"end_character":18},"in_reply_to":"9a629dbe_fafef369","updated":"2016-11-09 14:02:56.000000000","message":"Done","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":388,"context_line":"Resources CRUD notifications"},{"line_number":389,"context_line":"----------------------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"These notification are emitted from API service when ironic resource create,"},{"line_number":392,"context_line":"update or deleted. There are the same actions for different resources:"},{"line_number":393,"context_line":"\"create\", \"update\" and \"delete\" with statuses described above. All CRUD"},{"line_number":394,"context_line":"notifications have INFO level, except with \"error\" status that has ERROR."},{"line_number":395,"context_line":"List of CRUD notifications for node:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a629dbe_da2e8ff9","line":392,"range":{"start_line":391,"start_character":48,"end_line":392,"end_character":18},"updated":"2016-11-08 19:28:46.000000000","message":"nit: It\u0027s more grammatically correct if it\u0027s something like: \"when ironic resources are created, updated, or deleted.","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":388,"context_line":"Resources CRUD notifications"},{"line_number":389,"context_line":"----------------------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"These notification are emitted from API service when ironic resource create,"},{"line_number":392,"context_line":"update or deleted. There are the same actions for different resources:"},{"line_number":393,"context_line":"\"create\", \"update\" and \"delete\" with statuses described above. All CRUD"},{"line_number":394,"context_line":"notifications have INFO level, except with \"error\" status that has ERROR."},{"line_number":395,"context_line":"List of CRUD notifications for node:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a629dbe_79ac8ca0","line":392,"range":{"start_line":391,"start_character":48,"end_line":392,"end_character":18},"in_reply_to":"9a629dbe_da2e8ff9","updated":"2016-11-09 14:02:56.000000000","message":"Done","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ce44199f1bb7baab4c50c71bdbfb5e039e2040ea","unresolved":false,"context_lines":[{"line_number":391,"context_line":"These notifications are emitted from API service when ironic resources are"},{"line_number":392,"context_line":"created, updated, or deleted. There are the same actions for different"},{"line_number":393,"context_line":"resources: \"create\", \"update\" and \"delete\" with statuses described above."},{"line_number":394,"context_line":"All CRUD notifications have INFO level, except with \"error\" status that has"},{"line_number":395,"context_line":"ERROR."},{"line_number":396,"context_line":"List of CRUD notifications for node:"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a77a97e_f272b37b","line":394,"updated":"2016-11-15 19:20:41.000000000","message":"We should probably define CRUD (I\u0027m wondering how well a non-english speaker would know the acronym?).\n\nAlso, might wanna say \"notifications are emitted at INFO level\" rather than \"have INFO level\" which is a weird way of wording it.","commit_id":"235f30a1587e75a5041c8a0f1de413447b19558b"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7d61114ca7f3831e2e8b5be9b060c6e6fd8579ea","unresolved":false,"context_lines":[{"line_number":391,"context_line":"These notifications are emitted from API service when ironic resources are"},{"line_number":392,"context_line":"created, updated, or deleted. There are the same actions for different"},{"line_number":393,"context_line":"resources: \"create\", \"update\" and \"delete\" with statuses described above."},{"line_number":394,"context_line":"All CRUD notifications have INFO level, except with \"error\" status that has"},{"line_number":395,"context_line":"ERROR."},{"line_number":396,"context_line":"List of CRUD notifications for node:"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a77a97e_ecf1d66b","line":394,"in_reply_to":"7a77a97e_f272b37b","updated":"2016-11-16 13:40:12.000000000","message":"Done","commit_id":"235f30a1587e75a5041c8a0f1de413447b19558b"}],"ironic/api/app.wsgi":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ad57c77c016344e3fc9554e8252e1ebc3c462dfa","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"i18n.install(\u0027ironic\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"service_name.set_service_name(\"api\"\u0027)"},{"line_number":35,"context_line":"service.prepare_service(sys.argv)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"fa6399be_f4b3ea4a","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":36},"updated":"2016-10-14 21:46:42.000000000","message":"Is this correct syntax? Looks like there\u0027s an extra \u0027","commit_id":"a7716adc83b41d923272f0412871e8bb9fe2696d"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1503,"context_line":"            raise"},{"line_number":1504,"context_line":"        self._check_driver_changed_and_console_enabled(rpc_node, node_ident)"},{"line_number":1505,"context_line":"        # NOTE(yuriyz): no chassis_uuid in START and ERROR notifications"},{"line_number":1506,"context_line":"        with notify.emit_status_notifications(rpc_node, pecan.request.context,"},{"line_number":1507,"context_line":"                                              \u0027update\u0027, chassis_uuid\u003dNone):"},{"line_number":1508,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node("}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_85bafc08","line":1505,"updated":"2016-11-08 19:28:46.000000000","message":"Why not have the chassis_uuid here? I see it added to the node_dict in L1487. You could save the old version immediately after that before apply_jsonpatch is called.","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1503,"context_line":"            raise"},{"line_number":1504,"context_line":"        self._check_driver_changed_and_console_enabled(rpc_node, node_ident)"},{"line_number":1505,"context_line":"        # NOTE(yuriyz): no chassis_uuid in START and ERROR notifications"},{"line_number":1506,"context_line":"        with notify.emit_status_notifications(rpc_node, pecan.request.context,"},{"line_number":1507,"context_line":"                                              \u0027update\u0027, chassis_uuid\u003dNone):"},{"line_number":1508,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node("}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_f96dfc98","line":1505,"in_reply_to":"9a629dbe_85bafc08","updated":"2016-11-09 14:02:56.000000000","message":"Done, new small fix of our id\u003c-\u003euuid magic added for this.","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70c2acffda578685e65d0070a3a05c6b538ea2f2","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1531,"context_line":"            raise"},{"line_number":1532,"context_line":"        self._check_driver_changed_and_console_enabled(rpc_node, node_ident)"},{"line_number":1533,"context_line":"        with notify.emit_status_notifications(rpc_node, pecan.request.context,"},{"line_number":1534,"context_line":"                                              \u0027update\u0027,"},{"line_number":1535,"context_line":"                                              chassis_uuid\u003dnode.chassis_uuid):"},{"line_number":1536,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node("},{"line_number":1537,"context_line":"                pecan.request.context, rpc_node, topic)"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"        api_node \u003d Node.convert_with_links(new_node)"},{"line_number":1540,"context_line":"        notify.emit_update_end_notification(new_node, pecan.request.context,"},{"line_number":1541,"context_line":"                                            chassis_uuid\u003dapi_node.chassis_uuid)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        return api_node"},{"line_number":1544,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5a74a57a_604cee70","line":1541,"range":{"start_line":1533,"start_character":0,"end_line":1541,"end_character":73},"updated":"2016-11-24 13:22:48.000000000","message":"I\u0027m not sure why make this inconsistent with create. Also FYI I have a patch moving creation to conductor","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"4af5bf697199aae9874e11ae0fdf9029f93e500f","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1531,"context_line":"            raise"},{"line_number":1532,"context_line":"        self._check_driver_changed_and_console_enabled(rpc_node, node_ident)"},{"line_number":1533,"context_line":"        with notify.emit_status_notifications(rpc_node, pecan.request.context,"},{"line_number":1534,"context_line":"                                              \u0027update\u0027,"},{"line_number":1535,"context_line":"                                              chassis_uuid\u003dnode.chassis_uuid):"},{"line_number":1536,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node("},{"line_number":1537,"context_line":"                pecan.request.context, rpc_node, topic)"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"        api_node \u003d Node.convert_with_links(new_node)"},{"line_number":1540,"context_line":"        notify.emit_update_end_notification(new_node, pecan.request.context,"},{"line_number":1541,"context_line":"                                            chassis_uuid\u003dapi_node.chassis_uuid)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        return api_node"},{"line_number":1544,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5a74a57a_6ecd93b6","line":1541,"range":{"start_line":1533,"start_character":0,"end_line":1541,"end_character":73},"in_reply_to":"5a74a57a_0c90b0eb","updated":"2016-11-25 14:46:18.000000000","message":"And if you patch will be merged early maybe makes sense update the spec and make this consistent.","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9e770ffacdd0fc0cc5b4832bc2d5e704d3b831c4","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"            e.code \u003d http_client.BAD_REQUEST"},{"line_number":1531,"context_line":"            raise"},{"line_number":1532,"context_line":"        self._check_driver_changed_and_console_enabled(rpc_node, node_ident)"},{"line_number":1533,"context_line":"        with notify.emit_status_notifications(rpc_node, pecan.request.context,"},{"line_number":1534,"context_line":"                                              \u0027update\u0027,"},{"line_number":1535,"context_line":"                                              chassis_uuid\u003dnode.chassis_uuid):"},{"line_number":1536,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node("},{"line_number":1537,"context_line":"                pecan.request.context, rpc_node, topic)"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"        api_node \u003d Node.convert_with_links(new_node)"},{"line_number":1540,"context_line":"        notify.emit_update_end_notification(new_node, pecan.request.context,"},{"line_number":1541,"context_line":"                                            chassis_uuid\u003dapi_node.chassis_uuid)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        return api_node"},{"line_number":1544,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5a74a57a_0c90b0eb","line":1541,"range":{"start_line":1533,"start_character":0,"end_line":1541,"end_character":73},"in_reply_to":"5a74a57a_604cee70","updated":"2016-11-25 14:04:29.000000000","message":"Please read my comment in notifications.rst. I think if creation will be moved to conductor *create.success notification should be deprecated and not emitted after deprecation period.","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        # that as_dict() will contain chassis_id field when converting it"},{"line_number":778,"context_line":"        # before saving it in the database."},{"line_number":779,"context_line":"        self.fields.append(\u0027chassis_id\u0027)"},{"line_number":780,"context_line":"        if \u0027chassis_uuid\u0027 not in kwargs:"},{"line_number":781,"context_line":"            setattr(self, \u0027chassis_uuid\u0027, kwargs.get(\u0027chassis_id\u0027,"},{"line_number":782,"context_line":"                                                     wtypes.Unset))"},{"line_number":783,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_ceef87e7","line":780,"updated":"2016-11-25 16:01:54.000000000","message":"So if both chassis_uuid and chassis_id (it does not happen now, but who knows :)) were passed as kwargs here, previously, the value from kwargs[chassis_id] would overwrite kwargs[chassis_uuid] argument. Maybe this should be changed to \"if \u0027chassis_id\u0027 in kwargs\"?\n\nUPD: after discussing with Yuriy, it does not make any sense to pass chassis_id and chassis_uuid of the different chassis, so should be OK.","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"                pecan.request.context, rpc_node, topic)"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"        api_node \u003d Node.convert_with_links(new_node)"},{"line_number":1548,"context_line":"        notify.emit_update_end_notification(new_node, pecan.request.context,"},{"line_number":1549,"context_line":"                                            chassis_uuid\u003dapi_node.chassis_uuid)"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        return api_node"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_d9c67367","line":1548,"updated":"2016-11-25 16:01:54.000000000","message":"Why is this separate, and does not get emitted right in the emit_status_notifications context manager as eg \u0027delete\u0027 notification?\n\nIt seems to me, that we can emit end notification for both delete and update in the emit_status_notifications.\n\nOr do you think we should not consider the update successful if we can\u0027t do Node.convert_with_links? The node was actually updated on the conductor side, so I don\u0027t see why we need to take this into account.","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f4b535b995a97a6ff30040fff2348bca5f215ec4","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"                pecan.request.context, rpc_node, topic)"},{"line_number":1546,"context_line":""},{"line_number":1547,"context_line":"        api_node \u003d Node.convert_with_links(new_node)"},{"line_number":1548,"context_line":"        notify.emit_update_end_notification(new_node, pecan.request.context,"},{"line_number":1549,"context_line":"                                            chassis_uuid\u003dapi_node.chassis_uuid)"},{"line_number":1550,"context_line":""},{"line_number":1551,"context_line":"        return api_node"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_eeb7de37","line":1548,"in_reply_to":"5a74a57a_d9c67367","updated":"2016-11-25 16:10:31.000000000","message":"Oops, sorry, I see why now, nevermind, just seen the comment that it should contain the updated object.","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"43e70b620ef4b94e17ad55b2faf5f8fdba16be62","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        # that as_dict() will contain chassis_id field when converting it"},{"line_number":778,"context_line":"        # before saving it in the database."},{"line_number":779,"context_line":"        self.fields.append(\u0027chassis_id\u0027)"},{"line_number":780,"context_line":"        if \u0027chassis_uuid\u0027 not in kwargs:"},{"line_number":781,"context_line":"            setattr(self, \u0027chassis_uuid\u0027, kwargs.get(\u0027chassis_id\u0027,"},{"line_number":782,"context_line":"                                                     wtypes.Unset))"},{"line_number":783,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_8b71e546","line":780,"updated":"2016-12-05 16:40:13.000000000","message":"good addition, it would have already been set on L773","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        # that as_dict() will contain chassis_id field when converting it"},{"line_number":778,"context_line":"        # before saving it in the database."},{"line_number":779,"context_line":"        self.fields.append(\u0027chassis_id\u0027)"},{"line_number":780,"context_line":"        if \u0027chassis_uuid\u0027 not in kwargs:"},{"line_number":781,"context_line":"            setattr(self, \u0027chassis_uuid\u0027, kwargs.get(\u0027chassis_id\u0027,"},{"line_number":782,"context_line":"                                                     wtypes.Unset))"},{"line_number":783,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_252a512d","line":780,"in_reply_to":"3a71b18c_505c987c","updated":"2016-12-07 17:10:10.000000000","message":"This patch does not work correctly due to issue in internal representation of API node in some cases, we clear chassis_uuid that set in the loop before. This is not a bug because external API behavior is correct.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":777,"context_line":"        # that as_dict() will contain chassis_id field when converting it"},{"line_number":778,"context_line":"        # before saving it in the database."},{"line_number":779,"context_line":"        self.fields.append(\u0027chassis_id\u0027)"},{"line_number":780,"context_line":"        if \u0027chassis_uuid\u0027 not in kwargs:"},{"line_number":781,"context_line":"            setattr(self, \u0027chassis_uuid\u0027, kwargs.get(\u0027chassis_id\u0027,"},{"line_number":782,"context_line":"                                                     wtypes.Unset))"},{"line_number":783,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_505c987c","line":780,"in_reply_to":"3a71b18c_8b71e546","updated":"2016-12-06 20:20:58.000000000","message":"although I don\u0027t think it belongs in this patch. Anyway...","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2da11aa665cf4cdfec55acda1427ace72de68913","unresolved":false,"context_lines":[{"line_number":1519,"context_line":"            except exception.NoValidHost as e:"},{"line_number":1520,"context_line":"                # NOTE(deva): convert from 404 to 400 because client can see"},{"line_number":1521,"context_line":"                #             list of available drivers and shouldn\u0027t request"},{"line_number":1522,"context_line":"                #             one that doesn\u0027t exist."},{"line_number":1523,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1524,"context_line":"                raise"},{"line_number":1525,"context_line":"            self._check_driver_changed_and_console_enabled(rpc_node,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_31474578","line":1522,"updated":"2016-12-15 20:53:57.000000000","message":"if the only reason this fails is because the user specified a driver that doesn\u0027t exist, I think Mario said that we shouldn\u0027t issue a notification.error for this cuz it is a user error.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e8ad997a2eb3743f96555a2e52b9f360d0bf6e","unresolved":false,"context_lines":[{"line_number":1519,"context_line":"            except exception.NoValidHost as e:"},{"line_number":1520,"context_line":"                # NOTE(deva): convert from 404 to 400 because client can see"},{"line_number":1521,"context_line":"                #             list of available drivers and shouldn\u0027t request"},{"line_number":1522,"context_line":"                #             one that doesn\u0027t exist."},{"line_number":1523,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1524,"context_line":"                raise"},{"line_number":1525,"context_line":"            self._check_driver_changed_and_console_enabled(rpc_node,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_bcea2ed9","line":1522,"in_reply_to":"1a6eadb0_31474578","updated":"2016-12-16 11:58:16.000000000","message":"This can be not only user error. For example I have small env with 2 conductors and both are dead. But because there is probability of user error this code removed from notify context manager.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2da11aa665cf4cdfec55acda1427ace72de68913","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1524,"context_line":"                raise"},{"line_number":1525,"context_line":"            self._check_driver_changed_and_console_enabled(rpc_node,"},{"line_number":1526,"context_line":"                                                           node_ident)"},{"line_number":1527,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node(context,"},{"line_number":1528,"context_line":"                                                        rpc_node, topic)"},{"line_number":1529,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_f1378dfc","line":1526,"updated":"2016-12-15 20:53:57.000000000","message":"this one, I\u0027m not sure but I am OK with a .error notification being sent for this.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e8ad997a2eb3743f96555a2e52b9f360d0bf6e","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1524,"context_line":"                raise"},{"line_number":1525,"context_line":"            self._check_driver_changed_and_console_enabled(rpc_node,"},{"line_number":1526,"context_line":"                                                           node_ident)"},{"line_number":1527,"context_line":"            new_node \u003d pecan.request.rpcapi.update_node(context,"},{"line_number":1528,"context_line":"                                                        rpc_node, topic)"},{"line_number":1529,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_1c5de214","line":1526,"in_reply_to":"1a6eadb0_f1378dfc","updated":"2016-12-16 11:58:16.000000000","message":"I\u0027m not sure also. Removed from context manager.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2da11aa665cf4cdfec55acda1427ace72de68913","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"            try:"},{"line_number":1561,"context_line":"                topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":1562,"context_line":"            except exception.NoValidHost as e:"},{"line_number":1563,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1564,"context_line":"                raise"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"            pecan.request.rpcapi.destroy_node(context, rpc_node.uuid, topic)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_0c1eb05e","line":1563,"updated":"2016-12-15 20:53:57.000000000","message":"i think the same here. This happens if the user specifies a node that doesn\u0027t exist. So it is a user error. UNLESS the node got deleted by some other request around the same time... but maybe that is considered a user error too?","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"35eff24b5b7bd3d297a7d4adaca09c9f16d5eab5","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"            try:"},{"line_number":1561,"context_line":"                topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":1562,"context_line":"            except exception.NoValidHost as e:"},{"line_number":1563,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1564,"context_line":"                raise"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"            pecan.request.rpcapi.destroy_node(context, rpc_node.uuid, topic)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_3a08ded9","line":1563,"in_reply_to":"1a6eadb0_092f66a1","updated":"2016-12-16 12:18:42.000000000","message":"\"UNLESS the node got deleted by some other request around the same time...\" even if deleted after get_rpc_node() no exception will be here, only if no conductors which have node\u0027s driver.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e8ad997a2eb3743f96555a2e52b9f360d0bf6e","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"            try:"},{"line_number":1561,"context_line":"                topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":1562,"context_line":"            except exception.NoValidHost as e:"},{"line_number":1563,"context_line":"                e.code \u003d http_client.BAD_REQUEST"},{"line_number":1564,"context_line":"                raise"},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"            pecan.request.rpcapi.destroy_node(context, rpc_node.uuid, topic)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_092f66a1","line":1563,"in_reply_to":"1a6eadb0_0c1eb05e","updated":"2016-12-16 11:58:16.000000000","message":"If the user specifies a node that doesn\u0027t exist error will be in l1551. Error here is possible in race condition that you mentioned and also if no conductors.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"876534801938fdfbf5acbc274af2d655d287125c","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"        node.provision_state \u003d api_utils.initial_node_provision_state()"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        new_node \u003d objects.Node(context, **node.as_dict())"},{"line_number":1439,"context_line":"        notify.emit_start_notification(context, new_node, \u0027create\u0027,"},{"line_number":1440,"context_line":"                                       chassis_uuid\u003dnode.chassis_uuid)"},{"line_number":1441,"context_line":"        with notify.handle_error_notification(context, new_node, \u0027create\u0027,"},{"line_number":1442,"context_line":"                                              chassis_uuid\u003dnode.chassis_uuid):"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_a994a58a","line":1439,"updated":"2016-12-16 16:11:10.000000000","message":"We should send start notification before L1423. We should send start notification for case when there is no conductor available in the cloud.\n\nFurthermore it looks that we need send start notification befor policy check if we want to log 401 errors.","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"62a6b66cf49bcd24d4a6ed669145247c08513fd8","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"        node.provision_state \u003d api_utils.initial_node_provision_state()"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        new_node \u003d objects.Node(context, **node.as_dict())"},{"line_number":1439,"context_line":"        notify.emit_start_notification(context, new_node, \u0027create\u0027,"},{"line_number":1440,"context_line":"                                       chassis_uuid\u003dnode.chassis_uuid)"},{"line_number":1441,"context_line":"        with notify.handle_error_notification(context, new_node, \u0027create\u0027,"},{"line_number":1442,"context_line":"                                              chassis_uuid\u003dnode.chassis_uuid):"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_c4fb8845","line":1439,"in_reply_to":"1a6eadb0_a994a58a","updated":"2016-12-16 16:37:42.000000000","message":"1) There is a case when user posted wrong driver, see comments on previous patch set. 2) Policy error is a client error in most cases.","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"812311056579aac7738bcfebce883bfdf4a1d331","unresolved":false,"context_lines":[{"line_number":1436,"context_line":"        node.provision_state \u003d api_utils.initial_node_provision_state()"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        new_node \u003d objects.Node(context, **node.as_dict())"},{"line_number":1439,"context_line":"        notify.emit_start_notification(context, new_node, \u0027create\u0027,"},{"line_number":1440,"context_line":"                                       chassis_uuid\u003dnode.chassis_uuid)"},{"line_number":1441,"context_line":"        with notify.handle_error_notification(context, new_node, \u0027create\u0027,"},{"line_number":1442,"context_line":"                                              chassis_uuid\u003dnode.chassis_uuid):"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_f271d378","line":1439,"in_reply_to":"1a6eadb0_c4fb8845","updated":"2016-12-19 19:19:46.000000000","message":"Yeah, I consider policy errors, user-errors. I mean, user isn\u0027t allowed to issue the request, as opposed to an error while performing the operation associated with the request.","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"876534801938fdfbf5acbc274af2d655d287125c","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":1552,"context_line":"        chassis_uuid \u003d None"},{"line_number":1553,"context_line":"        if rpc_node.chassis_id:"},{"line_number":1554,"context_line":"            chassis_uuid \u003d objects.Chassis.get_by_id(context,"},{"line_number":1555,"context_line":"                                                     rpc_node.chassis_id).uuid"},{"line_number":1556,"context_line":"        notify.emit_start_notification(context, rpc_node, \u0027delete\u0027,"},{"line_number":1557,"context_line":"                                       chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_290b35d7","line":1554,"updated":"2016-12-16 16:11:10.000000000","message":"Do we want to sent notifications about requests maden to wrong subcontroller? We should move start notification before L1548 or even 1546 if want to see 401 errors.","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"62a6b66cf49bcd24d4a6ed669145247c08513fd8","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":1552,"context_line":"        chassis_uuid \u003d None"},{"line_number":1553,"context_line":"        if rpc_node.chassis_id:"},{"line_number":1554,"context_line":"            chassis_uuid \u003d objects.Chassis.get_by_id(context,"},{"line_number":1555,"context_line":"                                                     rpc_node.chassis_id).uuid"},{"line_number":1556,"context_line":"        notify.emit_start_notification(context, rpc_node, \u0027delete\u0027,"},{"line_number":1557,"context_line":"                                       chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_985490ca","line":1554,"in_reply_to":"1a6eadb0_290b35d7","updated":"2016-12-16 16:37:42.000000000","message":"Start notification should be finished by end or error. We shouldn\u0027t issue error for user errors (as result of IRC discussion).","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"812311056579aac7738bcfebce883bfdf4a1d331","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":1552,"context_line":"        chassis_uuid \u003d None"},{"line_number":1553,"context_line":"        if rpc_node.chassis_id:"},{"line_number":1554,"context_line":"            chassis_uuid \u003d objects.Chassis.get_by_id(context,"},{"line_number":1555,"context_line":"                                                     rpc_node.chassis_id).uuid"},{"line_number":1556,"context_line":"        notify.emit_start_notification(context, rpc_node, \u0027delete\u0027,"},{"line_number":1557,"context_line":"                                       chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_1293afa4","line":1554,"in_reply_to":"1a6eadb0_985490ca","updated":"2016-12-19 19:19:46.000000000","message":"++ to what Yuriy said. Issuing request to wrong subcontroller is more of a user error (or the way we designed this code, not sure, but it isn\u0027t an error wrt the desired operation.)","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"}],"ironic/api/controllers/v1/notification_utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        val \u003d val if uuidutils.is_uuid_like(val) else None"},{"line_number":63,"context_line":"        kwargs \u003d {key: val}"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":66,"context_line":"        payload_method \u003d CRUD_PAYLOADS[resource]"},{"line_number":67,"context_line":"        # Prepare our exception message just in case"},{"line_number":68,"context_line":"        exception_values \u003d {\"resource\": resource,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_4578e42b","line":65,"updated":"2016-11-08 19:28:46.000000000","message":"If someone tries to pass a resource that isn\u0027t allowed here (like a portgroup), this will throw an exception, the logger will try to log exception_message, which won\u0027t yet be defined, and then there will be an uncaught exception. I don\u0027t think this matters since that would only happen during development of a new notification, so not leaving -1 for this, but I just wanted to note it here.","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        val \u003d val if uuidutils.is_uuid_like(val) else None"},{"line_number":63,"context_line":"        kwargs \u003d {key: val}"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":66,"context_line":"        payload_method \u003d CRUD_PAYLOADS[resource]"},{"line_number":67,"context_line":"        # Prepare our exception message just in case"},{"line_number":68,"context_line":"        exception_values \u003d {\"resource\": resource,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_8c9da05b","line":65,"in_reply_to":"9a629dbe_4578e42b","updated":"2016-11-09 14:02:56.000000000","message":"Done","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        exception_values[\u0027error\u0027] \u003d e"},{"line_number":98,"context_line":"        LOG.warning(exception_message, exception_values)"},{"line_number":99,"context_line":"    except Exception as e:"},{"line_number":100,"context_line":"        # NOTE(mariojv) For unknown exceptions, also log the traceback."},{"line_number":101,"context_line":"        exception_values[\u0027error\u0027] \u003d e"},{"line_number":102,"context_line":"        LOG.exception(exception_message, exception_values)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_05b8ace4","line":100,"range":{"start_line":100,"start_character":15,"end_line":100,"end_character":22},"updated":"2016-11-08 19:28:46.000000000","message":"You can put NOTE(yuriyz) here instead :)","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"70c2acffda578685e65d0070a3a05c6b538ea2f2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            payload_name \u003d payload_method.__name__"},{"line_number":70,"context_line":"        except KeyError:"},{"line_number":71,"context_line":"            notification_name \u003d payload_name \u003d _(\"not defined for resource\")"},{"line_number":72,"context_line":"            raise"},{"line_number":73,"context_line":"        finally:"},{"line_number":74,"context_line":"            # Prepare our exception message just in case"},{"line_number":75,"context_line":"            exception_values \u003d {\"resource\": resource,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a74a57a_c09ea2b7","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":17},"updated":"2016-11-24 13:22:48.000000000","message":"message for KeyError is just the missing key. I don\u0027t think users will be glad to see such error, let\u0027s expand it.","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9e770ffacdd0fc0cc5b4832bc2d5e704d3b831c4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            payload_name \u003d payload_method.__name__"},{"line_number":70,"context_line":"        except KeyError:"},{"line_number":71,"context_line":"            notification_name \u003d payload_name \u003d _(\"not defined for resource\")"},{"line_number":72,"context_line":"            raise"},{"line_number":73,"context_line":"        finally:"},{"line_number":74,"context_line":"            # Prepare our exception message just in case"},{"line_number":75,"context_line":"            exception_values \u003d {\"resource\": resource,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a74a57a_4c93884f","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":17},"in_reply_to":"5a74a57a_c09ea2b7","updated":"2016-11-25 14:04:29.000000000","message":"Done. This exception will be raised if programmer pass resource instance that does not currently supported, and I\u0027m not sure that we should re-raise ironic exception here.","commit_id":"83be957cb4c380d2ca9e8f00fc6aff014e9984b4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    :param **kwargs: kwargs to use when creating the notification payload."},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":60,"context_line":"    if kwargs:"},{"line_number":61,"context_line":"        key, val \u003d kwargs.popitem()"},{"line_number":62,"context_line":"        val \u003d val if uuidutils.is_uuid_like(val) else None"},{"line_number":63,"context_line":"        kwargs \u003d {key: val}"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_7fa8dfdb","line":63,"range":{"start_line":60,"start_character":4,"end_line":63,"end_character":27},"updated":"2016-11-25 16:01:54.000000000","message":"That\u0027a a bit strange construct, considering that anything can be passed into kwargs. Could you add this caveat to the description? Or maybe make things explicit, with adding chassis_uuid\u003dNone and node_uuid\u003dNone here (and when portgroups are added, portgroup_uuid)?","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    :param **kwargs: kwargs to use when creating the notification payload."},{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":60,"context_line":"    if kwargs:"},{"line_number":61,"context_line":"        key, val \u003d kwargs.popitem()"},{"line_number":62,"context_line":"        val \u003d val if uuidutils.is_uuid_like(val) else None"},{"line_number":63,"context_line":"        kwargs \u003d {key: val}"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_8650efd5","line":63,"range":{"start_line":60,"start_character":4,"end_line":63,"end_character":27},"in_reply_to":"5a74a57a_7fa8dfdb","updated":"2016-11-28 08:54:39.000000000","message":"Comment added.","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                notification_name \u003d payload_name \u003d _(\"is not defined for \""},{"line_number":68,"context_line":"                                                     \"resource\")"},{"line_number":69,"context_line":"                raise KeyError(_(\"Unsupported resource: %s\") % resource)"},{"line_number":70,"context_line":"            notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":71,"context_line":"            payload_method \u003d CRUD_PAYLOADS[resource]"},{"line_number":72,"context_line":"            notification_name \u003d notification_method.__name__"},{"line_number":73,"context_line":"            payload_name \u003d payload_method.__name__"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_3aa2f5fd","line":70,"updated":"2016-11-25 16:01:54.000000000","message":"I\u0027d even say class :)","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                notification_name \u003d payload_name \u003d _(\"is not defined for \""},{"line_number":68,"context_line":"                                                     \"resource\")"},{"line_number":69,"context_line":"                raise KeyError(_(\"Unsupported resource: %s\") % resource)"},{"line_number":70,"context_line":"            notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":71,"context_line":"            payload_method \u003d CRUD_PAYLOADS[resource]"},{"line_number":72,"context_line":"            notification_name \u003d notification_method.__name__"},{"line_number":73,"context_line":"            payload_name \u003d payload_method.__name__"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_46a2579a","line":70,"in_reply_to":"5a74a57a_3aa2f5fd","updated":"2016-11-28 08:54:39.000000000","message":"This is consistent with conductor.notification_utils","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                                     \"resource\")"},{"line_number":69,"context_line":"                raise KeyError(_(\"Unsupported resource: %s\") % resource)"},{"line_number":70,"context_line":"            notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":71,"context_line":"            payload_method \u003d CRUD_PAYLOADS[resource]"},{"line_number":72,"context_line":"            notification_name \u003d notification_method.__name__"},{"line_number":73,"context_line":"            payload_name \u003d payload_method.__name__"},{"line_number":74,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_5aa33100","line":71,"updated":"2016-11-25 16:01:54.000000000","message":"ditto","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        finally:"},{"line_number":75,"context_line":"            # Prepare our exception message just in case"},{"line_number":76,"context_line":"            exception_values \u003d {\"resource\": resource,"},{"line_number":77,"context_line":"                                \"uuid\": obj.uuid,"},{"line_number":78,"context_line":"                                \"action\": action,"},{"line_number":79,"context_line":"                                \"status\": status,"},{"line_number":80,"context_line":"                                \"level\": level,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_ff7cefb6","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":48},"updated":"2016-11-25 16:01:54.000000000","message":"If we consider that any object can be here, this can raise AttributeError?","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        finally:"},{"line_number":75,"context_line":"            # Prepare our exception message just in case"},{"line_number":76,"context_line":"            exception_values \u003d {\"resource\": resource,"},{"line_number":77,"context_line":"                                \"uuid\": obj.uuid,"},{"line_number":78,"context_line":"                                \"action\": action,"},{"line_number":79,"context_line":"                                \"status\": status,"},{"line_number":80,"context_line":"                                \"level\": level,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_c60ae789","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":48},"in_reply_to":"5a74a57a_ff7cefb6","updated":"2016-11-28 08:54:39.000000000","message":"\"If we consider that any object can be here\" - any ironic resource object, resource object always has uuid.","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            oslo_msg_exc.MessageDeliveryFailure,"},{"line_number":104,"context_line":"            oslo_vo_exc.VersionedObjectsException) as e:"},{"line_number":105,"context_line":"        exception_values[\u0027error\u0027] \u003d e"},{"line_number":106,"context_line":"        LOG.warning(exception_message, exception_values)"},{"line_number":107,"context_line":"    except Exception as e:"},{"line_number":108,"context_line":"        exception_values[\u0027error\u0027] \u003d e"},{"line_number":109,"context_line":"        LOG.exception(exception_message, exception_values)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_1a60d9a4","line":106,"updated":"2016-11-25 16:01:54.000000000","message":"Why not LOG.exception here?","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            oslo_msg_exc.MessageDeliveryFailure,"},{"line_number":104,"context_line":"            oslo_vo_exc.VersionedObjectsException) as e:"},{"line_number":105,"context_line":"        exception_values[\u0027error\u0027] \u003d e"},{"line_number":106,"context_line":"        LOG.warning(exception_message, exception_values)"},{"line_number":107,"context_line":"    except Exception as e:"},{"line_number":108,"context_line":"        exception_values[\u0027error\u0027] \u003d e"},{"line_number":109,"context_line":"        LOG.exception(exception_message, exception_values)"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_4653376b","line":106,"in_reply_to":"5a74a57a_1a60d9a4","updated":"2016-11-28 08:54:39.000000000","message":"They are \"expected\" exception l100, we do not want trace here. See conductor.notification_utils for example.","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                              **kwargs)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"def emit_update_end_notification(obj, context, **kwargs):"},{"line_number":155,"context_line":"    \"\"\"Helper for emitting api update end notifications."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_b97b7727","line":154,"updated":"2016-11-25 16:01:54.000000000","message":"see the comment in the nodes controller on that, why not allow it on L147?","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dd2f68d4146573216bdfc89089c0f9cc4496c248","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                  **kwargs)"},{"line_number":147,"context_line":"    # a new resource should be used for update all resources and create node"},{"line_number":148,"context_line":"    if action \u003d\u003d \u0027delete\u0027:"},{"line_number":149,"context_line":"        emit_api_notification(obj, context, action,"},{"line_number":150,"context_line":"                              fields.NotificationLevel.INFO,"},{"line_number":151,"context_line":"                              fields.NotificationStatus.END,"},{"line_number":152,"context_line":"                              **kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def emit_end_notification(obj, context, action, **kwargs):"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a71b18c_f1353846","line":152,"range":{"start_line":149,"start_character":8,"end_line":152,"end_character":39},"updated":"2016-12-02 12:53:02.000000000","message":"emit_end_notification can be reused now","commit_id":"704b536085a717c64da6902d4cea766dbf1d6c9f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def emit_api_notification(obj, context, action, level, status, **kwargs):"},{"line_number":48,"context_line":"    \"\"\"Helper for emitting api notifications."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_335726cb","line":47,"updated":"2016-12-06 20:20:58.000000000","message":"I\u0027m not sure why, but I\u0027d prefer the context to be first. Don\u0027t feel strongly about it though.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def emit_api_notification(obj, context, action, level, status, **kwargs):"},{"line_number":48,"context_line":"    \"\"\"Helper for emitting api notifications."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_8f050616","line":47,"in_reply_to":"3a71b18c_335726cb","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def emit_api_notification(obj, context, action, level, status, **kwargs):"},{"line_number":48,"context_line":"    \"\"\"Helper for emitting api notifications."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    :param obj: resource rpc object."},{"line_number":51,"context_line":"    :param context: request context."}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_734efe3b","line":48,"updated":"2016-12-06 20:20:58.000000000","message":"s/api/API/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def emit_api_notification(obj, context, action, level, status, **kwargs):"},{"line_number":48,"context_line":"    \"\"\"Helper for emitting api notifications."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    :param obj: resource rpc object."},{"line_number":51,"context_line":"    :param context: request context."}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_ca61ac13","line":48,"in_reply_to":"3a71b18c_734efe3b","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    if kwargs:"},{"line_number":62,"context_line":"        key, val \u003d kwargs.popitem()"},{"line_number":63,"context_line":"        val \u003d val if uuidutils.is_uuid_like(val) else None"},{"line_number":64,"context_line":"        kwargs \u003d {key: val}"},{"line_number":65,"context_line":"    try:"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_b39ed660","line":64,"updated":"2016-12-06 20:20:58.000000000","message":"I don\u0027t understand the above. Are you assuming there is exactly one item in kwargs? Or that the first item popped is always ...something... Otherwise, why are you only using the first item that is popped?","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    if kwargs:"},{"line_number":62,"context_line":"        key, val \u003d kwargs.popitem()"},{"line_number":63,"context_line":"        val \u003d val if uuidutils.is_uuid_like(val) else None"},{"line_number":64,"context_line":"        kwargs \u003d {key: val}"},{"line_number":65,"context_line":"    try:"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_ca10ccae","line":64,"in_reply_to":"3a71b18c_b39ed660","updated":"2016-12-07 17:10:10.000000000","message":"Yes, currently only one item is used, {\"\u003cresource\u003e_uuid\": uuid}. For example we pass chassis_uuid from API representation of node, we should convert value wsme.Unset to None. Changed for future portgroup_uuid support.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"},{"line_number":68,"context_line":"                notification_name \u003d payload_name \u003d _(\"is not defined for \""},{"line_number":69,"context_line":"                                                     \"resource\")"},{"line_number":70,"context_line":"                raise KeyError(_(\"Unsupported resource: %s\") % resource)"},{"line_number":71,"context_line":"            notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":72,"context_line":"            payload_method \u003d CRUD_PAYLOADS[resource]"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_7357de57","line":69,"updated":"2016-12-06 20:20:58.000000000","message":"based on how it is being used, I think \u0027is not defined\u0027 would be sufficient.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"},{"line_number":68,"context_line":"                notification_name \u003d payload_name \u003d _(\"is not defined for \""},{"line_number":69,"context_line":"                                                     \"resource\")"},{"line_number":70,"context_line":"                raise KeyError(_(\"Unsupported resource: %s\") % resource)"},{"line_number":71,"context_line":"            notification_method \u003d CRUD_NOTIFICATIONS[resource]"},{"line_number":72,"context_line":"            payload_method \u003d CRUD_PAYLOADS[resource]"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_cad1ac31","line":69,"in_reply_to":"3a71b18c_7357de57","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            exception_message \u003d (_(\"Failed to send baremetal.%(resource)s.\""},{"line_number":85,"context_line":"                                   \"%(action)s.%(status)s notification for \""},{"line_number":86,"context_line":"                                   \"%(resource)% %(uuid)s with level \""},{"line_number":87,"context_line":"                                   \"%(level)s, notification_method \""},{"line_number":88,"context_line":"                                   \"%(notification_method)s, payload_method \""},{"line_number":89,"context_line":"                                   \"%(payload_method)s, error %(error)s\"))"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_330ba67e","line":87,"updated":"2016-12-06 20:20:58.000000000","message":"maybe s/notification_method/notification method/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            exception_message \u003d (_(\"Failed to send baremetal.%(resource)s.\""},{"line_number":85,"context_line":"                                   \"%(action)s.%(status)s notification for \""},{"line_number":86,"context_line":"                                   \"%(resource)% %(uuid)s with level \""},{"line_number":87,"context_line":"                                   \"%(level)s, notification_method \""},{"line_number":88,"context_line":"                                   \"%(notification_method)s, payload_method \""},{"line_number":89,"context_line":"                                   \"%(payload_method)s, error %(error)s\"))"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_0a400407","line":87,"in_reply_to":"3a71b18c_330ba67e","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                   \"%(action)s.%(status)s notification for \""},{"line_number":86,"context_line":"                                   \"%(resource)% %(uuid)s with level \""},{"line_number":87,"context_line":"                                   \"%(level)s, notification_method \""},{"line_number":88,"context_line":"                                   \"%(notification_method)s, payload_method \""},{"line_number":89,"context_line":"                                   \"%(payload_method)s, error %(error)s\"))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        payload \u003d payload_method(obj, **kwargs)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_73299ee5","line":88,"updated":"2016-12-06 20:20:58.000000000","message":"maybe s/payload_method/payload method/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                   \"%(action)s.%(status)s notification for \""},{"line_number":86,"context_line":"                                   \"%(resource)% %(uuid)s with level \""},{"line_number":87,"context_line":"                                   \"%(level)s, notification_method \""},{"line_number":88,"context_line":"                                   \"%(notification_method)s, payload_method \""},{"line_number":89,"context_line":"                                   \"%(payload_method)s, error %(error)s\"))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        payload \u003d payload_method(obj, **kwargs)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_ea3ae897","line":88,"in_reply_to":"3a71b18c_73299ee5","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@contextlib.contextmanager"},{"line_number":127,"context_line":"def emit_status_notifications(obj, context, action, **kwargs):"},{"line_number":128,"context_line":"    \"\"\"Context manager for emitting api status notifications."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_367b947c","line":127,"updated":"2016-12-06 20:20:58.000000000","message":"I see why you have this method, but I find it confusing. When I was looking at the code, I expected to see a pair of notify.emit_start_notification / notify.emit_end_notification, and something that handled errors.\n\nI suppose this could be renamed to something like emit_start_and_handle_error_notification()?\n\nMy preference would be to make this a context manager *only* to handle any errors, so the code would look like:\n\nnotify.emit_start_notification()\nwith notify.handle_error_notification(...)\n    ...\nnotify.emit_end_notification()","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"@contextlib.contextmanager"},{"line_number":127,"context_line":"def emit_status_notifications(obj, context, action, **kwargs):"},{"line_number":128,"context_line":"    \"\"\"Context manager for emitting api status notifications."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_2a5b0030","line":127,"in_reply_to":"3a71b18c_367b947c","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                  fields.NotificationLevel.ERROR,"},{"line_number":145,"context_line":"                                  fields.NotificationStatus.ERROR,"},{"line_number":146,"context_line":"                                  **kwargs)"},{"line_number":147,"context_line":"    # a new resource should be used for update all resources and create node"},{"line_number":148,"context_line":"    if action \u003d\u003d \u0027delete\u0027:"},{"line_number":149,"context_line":"        emit_api_notification(obj, context, action,"},{"line_number":150,"context_line":"                              fields.NotificationLevel.INFO,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_73c7de95","line":147,"updated":"2016-12-06 20:20:58.000000000","message":"not just creating a node. And you\u0027re just doing this if it is a delete. Actually, I\u0027m not sure what this comment is referring to.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                  fields.NotificationLevel.ERROR,"},{"line_number":145,"context_line":"                                  fields.NotificationStatus.ERROR,"},{"line_number":146,"context_line":"                                  **kwargs)"},{"line_number":147,"context_line":"    # a new resource should be used for update all resources and create node"},{"line_number":148,"context_line":"    if action \u003d\u003d \u0027delete\u0027:"},{"line_number":149,"context_line":"        emit_api_notification(obj, context, action,"},{"line_number":150,"context_line":"                              fields.NotificationLevel.INFO,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_aa47104a","line":147,"in_reply_to":"3a71b18c_73c7de95","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e0e0c7e93399a7a24d52c147f1af3e5c8e1432b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        emit_api_notification(obj, context, action,"},{"line_number":150,"context_line":"                              fields.NotificationLevel.INFO,"},{"line_number":151,"context_line":"                              fields.NotificationStatus.END,"},{"line_number":152,"context_line":"                              **kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def emit_end_notification(obj, context, action, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_36c9d4ac","line":152,"updated":"2016-12-06 20:20:58.000000000","message":"I don\u0027t like this hidden here; it isn\u0027t consistent with the other methods; I expected to see a notify.emit_end_notification() at the end of the delete() methods (similar to post(), patch()).","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        emit_api_notification(obj, context, action,"},{"line_number":150,"context_line":"                              fields.NotificationLevel.INFO,"},{"line_number":151,"context_line":"                              fields.NotificationStatus.END,"},{"line_number":152,"context_line":"                              **kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def emit_end_notification(obj, context, action, **kwargs):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_6a3df8ba","line":152,"in_reply_to":"3a71b18c_36c9d4ac","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"001c4b1b8f55e4c1f5ea2a45ad1a897237c02de2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":60,"context_line":"    # value like wsme.Unset can be passed, use only uuid as a value"},{"line_number":61,"context_line":"    uuids \u003d {k: (v if uuidutils.is_uuid_like(v) else None)"},{"line_number":62,"context_line":"             for k, v in kwargs.items()}"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_3635f045","line":61,"updated":"2016-12-08 18:00:36.000000000","message":"are we only concerned with wsme.Unset, or are we also concerned with it not being a UUID?\n\nIf the former, why not be more explicit and do \u0027(v if v !\u003d wsme.Unset else None)\u0027 or \u0027(None if v \u003d\u003d wsme.Unset else v)\n\nThen it\u0027ll work if we pass something other than UUIDs in the future and we won\u0027t have to mention anything about uuids here.","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0ec022a79e61e07f0c8ea10812732df53e4a213e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \"\"\""},{"line_number":59,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":60,"context_line":"    # value like wsme.Unset can be passed, use only uuid as a value"},{"line_number":61,"context_line":"    uuids \u003d {k: (v if uuidutils.is_uuid_like(v) else None)"},{"line_number":62,"context_line":"             for k, v in kwargs.items()}"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_f1b0bb8d","line":61,"in_reply_to":"3a71b18c_3635f045","updated":"2016-12-09 13:47:59.000000000","message":"Done","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"001c4b1b8f55e4c1f5ea2a45ad1a897237c02de2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":60,"context_line":"    # value like wsme.Unset can be passed, use only uuid as a value"},{"line_number":61,"context_line":"    uuids \u003d {k: (v if uuidutils.is_uuid_like(v) else None)"},{"line_number":62,"context_line":"             for k, v in kwargs.items()}"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_56850c05","line":62,"updated":"2016-12-08 18:00:36.000000000","message":"I think that if we are assuming that the only things in kwargs are of the form \u003cresource\u003e_uuid:uuid, we should document that above in L57.","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0ec022a79e61e07f0c8ea10812732df53e4a213e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":60,"context_line":"    # value like wsme.Unset can be passed, use only uuid as a value"},{"line_number":61,"context_line":"    uuids \u003d {k: (v if uuidutils.is_uuid_like(v) else None)"},{"line_number":62,"context_line":"             for k, v in kwargs.items()}"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_ecf8e47e","line":62,"in_reply_to":"3a71b18c_56850c05","updated":"2016-12-09 13:47:59.000000000","message":"Done","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"001c4b1b8f55e4c1f5ea2a45ad1a897237c02de2","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"@contextlib.contextmanager"},{"line_number":138,"context_line":"def handle_error_notification(context, obj, action, **kwargs):"},{"line_number":139,"context_line":"    \"\"\"Context manager for handle notifications errors."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    :param context: request context."},{"line_number":142,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_5670acdc","line":139,"updated":"2016-12-08 18:00:36.000000000","message":"s/for handle notifications errors/to handle any error notifications/\n\n\u0027notifications errors\u0027 makes it sound like it is handling errors from the notifications.","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0ec022a79e61e07f0c8ea10812732df53e4a213e","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"@contextlib.contextmanager"},{"line_number":138,"context_line":"def handle_error_notification(context, obj, action, **kwargs):"},{"line_number":139,"context_line":"    \"\"\"Context manager for handle notifications errors."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    :param context: request context."},{"line_number":142,"context_line":"    :param obj: resource rpc object."}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_72774a9f","line":139,"in_reply_to":"3a71b18c_5670acdc","updated":"2016-12-09 13:47:59.000000000","message":"Done","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c1ad4ad9aee73027ab73e290f7d28a4ecf221b6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    :param status: Status to go in the EventType. One of"},{"line_number":56,"context_line":"                   `ironic.objects.fields.NotificationStatus.ALL`"},{"line_number":57,"context_line":"    :param **kwargs: kwargs to use when creating the notification payload which"},{"line_number":58,"context_line":"                     contains \u0027\u003cparent_resource\u003e_uuid\u0027:uuid_value."},{"line_number":59,"context_line":"    \"\"\""},{"line_number":60,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":61,"context_line":"    # value wsme.Unset can be passed from API representation of resource"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_68607436","line":58,"updated":"2016-12-13 15:45:40.000000000","message":"it only contains those *_uuid keys, right?\n\ns/contains/only contains/","commit_id":"923a1a310287386ec2b6215c746cae84ab249943"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9c1ad4ad9aee73027ab73e290f7d28a4ecf221b6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":61,"context_line":"    # value wsme.Unset can be passed from API representation of resource"},{"line_number":62,"context_line":"    uuids \u003d {k: (v if v !\u003d wtypes.Unset else None)"},{"line_number":63,"context_line":"             for k, v in kwargs.items()}"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_68187485","line":63,"updated":"2016-12-13 15:45:40.000000000","message":"Oh. wait. this is generalized. I\u0027d prefer if we changed the :param kwargs description. Just delete the \u0027which contains ...\u0027 part, or if you want, something like For example, it could include \u003cparent_resource\u003e_uuid... \n\nAnd then instead of \u0027uuids \u003d ...\u0027 in L62, use something like \u0027extra_args\u0027","commit_id":"923a1a310287386ec2b6215c746cae84ab249943"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3a723098f228d79fe55fd7aef1b868bfd191eb86","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    resource \u003d obj.__class__.__name__.lower()"},{"line_number":61,"context_line":"    # value wsme.Unset can be passed from API representation of resource"},{"line_number":62,"context_line":"    uuids \u003d {k: (v if v !\u003d wtypes.Unset else None)"},{"line_number":63,"context_line":"             for k, v in kwargs.items()}"},{"line_number":64,"context_line":"    try:"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            if resource not in CRUD_NOTIFICATIONS:"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_e672f57b","line":63,"in_reply_to":"1a6eadb0_68187485","updated":"2016-12-13 16:23:13.000000000","message":"Done","commit_id":"923a1a310287386ec2b6215c746cae84ab249943"}],"ironic/api/controllers/v1/port.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2da11aa665cf4cdfec55acda1427ace72de68913","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(context, port_uuid)"},{"line_number":637,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context, rpc_port.node_id)"},{"line_number":638,"context_line":"        notify.emit_start_notification(context, rpc_port, \u0027delete\u0027,"},{"line_number":639,"context_line":"                                       node_uuid\u003drpc_node.uuid)"},{"line_number":640,"context_line":"        with notify.handle_error_notification(context, rpc_port, \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_8c53a0e1","line":637,"updated":"2016-12-15 20:53:57.000000000","message":"am wondering. if there is an error getting this node, it would be some internal ironic error, not a user error -- maybe worth putting inside the error_notification handler.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e8ad997a2eb3743f96555a2e52b9f360d0bf6e","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            raise exception.OperationNotPermitted()"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"        rpc_port \u003d objects.Port.get_by_uuid(context, port_uuid)"},{"line_number":637,"context_line":"        rpc_node \u003d objects.Node.get_by_id(context, rpc_port.node_id)"},{"line_number":638,"context_line":"        notify.emit_start_notification(context, rpc_port, \u0027delete\u0027,"},{"line_number":639,"context_line":"                                       node_uuid\u003drpc_node.uuid)"},{"line_number":640,"context_line":"        with notify.handle_error_notification(context, rpc_port, \u0027delete\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"1a6eadb0_9798f279","line":637,"in_reply_to":"1a6eadb0_8c53a0e1","updated":"2016-12-16 11:58:16.000000000","message":"In this case all start notifications will be emitted without node_uuid in payload.","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"}],"ironic/common/service_name.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ad57c77c016344e3fc9554e8252e1ebc3c462dfa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"SERVICE \u003d None"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def set_service_name(name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a98d1f4_1a4003a5","line":13,"updated":"2016-10-14 21:46:42.000000000","message":"Why not just put all this in ironic/common/service.py, instead of creating a whole new file? This seems like a very small change to have its own module.","commit_id":"a7716adc83b41d923272f0412871e8bb9fe2696d"}],"ironic/objects/chassis.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":214,"context_line":"class ChassisCRUDPayload(notification.NotificationPayloadBase):"},{"line_number":215,"context_line":"    # Version 1.0: Initial version, based off of Port version 1.6."},{"line_number":216,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_1abc59db","line":215,"range":{"start_line":215,"start_character":49,"end_line":215,"end_character":66},"updated":"2016-11-25 16:01:54.000000000","message":"copypaste, should be Chassis version 1.3","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":214,"context_line":"class ChassisCRUDPayload(notification.NotificationPayloadBase):"},{"line_number":215,"context_line":"    # Version 1.0: Initial version, based off of Port version 1.6."},{"line_number":216,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_26dd5be0","line":215,"range":{"start_line":215,"start_character":49,"end_line":215,"end_character":66},"in_reply_to":"5a74a57a_1abc59db","updated":"2016-11-28 08:54:39.000000000","message":"Done","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":203,"context_line":"class ChassisCRUDNotification(notification.NotificationBase):"},{"line_number":204,"context_line":"    \"\"\"Notification emitted when ironic create, update or delete chassis.\"\"\""},{"line_number":205,"context_line":"    # Version 1.0: Initial version"},{"line_number":206,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_96d9c8f5","line":204,"updated":"2016-12-06 20:48:15.000000000","message":"this is a nit, but might as well get the grammar correct since it is copy/pasted several times.\n\ns/create/creates/\n\ns/update/updates/\n\ns/delete/deletes a/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":203,"context_line":"class ChassisCRUDNotification(notification.NotificationBase):"},{"line_number":204,"context_line":"    \"\"\"Notification emitted when ironic create, update or delete chassis.\"\"\""},{"line_number":205,"context_line":"    # Version 1.0: Initial version"},{"line_number":206,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_05af157e","line":204,"in_reply_to":"3a71b18c_96d9c8f5","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"}],"ironic/objects/node.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9d3ed62481fc9b161a9080d9210a26a2253312ec","unresolved":false,"context_lines":[{"line_number":591,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":592,"context_line":"class NodeCRUDPayload(NodePayload):"},{"line_number":593,"context_line":"    \"\"\"Payload schema for when ironic create, update or delete node.\"\"\""},{"line_number":594,"context_line":"    # Version 1.0: Initial version"},{"line_number":595,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_3aa8358d","line":594,"updated":"2016-11-25 16:01:54.000000000","message":"just a question, do we need to mention the object version the notification is based on everywhere?","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"b0e8a2b7608f93ab2fee24d8f6695c78c6660da6","unresolved":false,"context_lines":[{"line_number":591,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":592,"context_line":"class NodeCRUDPayload(NodePayload):"},{"line_number":593,"context_line":"    \"\"\"Payload schema for when ironic create, update or delete node.\"\"\""},{"line_number":594,"context_line":"    # Version 1.0: Initial version"},{"line_number":595,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"}],"source_content_type":"text/x-python","patch_set":21,"id":"5a74a57a_e6b36398","line":594,"in_reply_to":"5a74a57a_3aa8358d","updated":"2016-11-28 08:54:39.000000000","message":"Done","commit_id":"74e8f47ae091671a902f146bb07a268ecb3d663c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":576,"context_line":""},{"line_number":577,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":578,"context_line":"class NodeCRUDNotification(notification.NotificationBase):"},{"line_number":579,"context_line":"    \"\"\"Notification emitted when ironic create, update or delete node.\"\"\""},{"line_number":580,"context_line":"    # Version 1.0: Initial version"},{"line_number":581,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_d64340ad","line":579,"updated":"2016-12-06 20:48:15.000000000","message":"this is a nit, but might as well get the grammar correct since it is copy/pasted several times.\n\ns/create/creates/\n\ns/update/updates/\n\ns/delete/deletes a/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":576,"context_line":""},{"line_number":577,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":578,"context_line":"class NodeCRUDNotification(notification.NotificationBase):"},{"line_number":579,"context_line":"    \"\"\"Notification emitted when ironic create, update or delete node.\"\"\""},{"line_number":580,"context_line":"    # Version 1.0: Initial version"},{"line_number":581,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_c55efd78","line":579,"in_reply_to":"3a71b18c_d64340ad","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":589,"context_line":"class NodeCRUDPayload(NodePayload):"},{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic create, update or delete node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_360b947e","line":590,"updated":"2016-12-06 20:48:15.000000000","message":"ditto","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":589,"context_line":"class NodeCRUDPayload(NodePayload):"},{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic create, update or delete node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_e52e99f9","line":590,"in_reply_to":"3a71b18c_360b947e","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic create, update or delete node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"},{"line_number":596,"context_line":"                  **{\u0027instance_info\u0027: (\u0027node\u0027, \u0027instance_info\u0027),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_7670ac0b","line":593,"updated":"2016-12-06 20:48:15.000000000","message":"Isn\u0027t this a new class? Why can\u0027t it be version 1.0 with the parent payload being version 1.1?","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic create, update or delete node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"},{"line_number":596,"context_line":"                  **{\u0027instance_info\u0027: (\u0027node\u0027, \u0027instance_info\u0027),"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_056c7507","line":593,"in_reply_to":"3a71b18c_7670ac0b","updated":"2016-12-07 17:10:10.000000000","message":"This class extends fields set from parent, parent has been changed. Each payload is independent for consumer point of view, therefore makes sense update version here (see also l558).","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        \u0027driver_info\u0027: object_fields.FlexibleDictField(nullable\u003dTrue)"},{"line_number":603,"context_line":"    }"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def __init__(self, node, chassis_uuid):"},{"line_number":606,"context_line":"        super(NodeCRUDPayload, self).__init__(node, chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_16cdb830","line":605,"updated":"2016-12-06 20:48:15.000000000","message":"would it be useful to do s/chassis_uuid/chassis_uuid\u003dNone/ ? (Just wondering. maybe not.)","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        \u0027driver_info\u0027: object_fields.FlexibleDictField(nullable\u003dTrue)"},{"line_number":603,"context_line":"    }"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def __init__(self, node, chassis_uuid):"},{"line_number":606,"context_line":"        super(NodeCRUDPayload, self).__init__(node, chassis_uuid\u003dchassis_uuid)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_e57cd9ed","line":605,"in_reply_to":"3a71b18c_16cdb830","updated":"2016-12-07 17:10:10.000000000","message":"chassis_uuid is mandatory parameter here, we should know it before even it\u0027s None.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"001c4b1b8f55e4c1f5ea2a45ad1a897237c02de2","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic creates, updates or deletes a node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"},{"line_number":596,"context_line":"                  **{\u0027instance_info\u0027: (\u0027node\u0027, \u0027instance_info\u0027),"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_064a8383","line":593,"updated":"2016-12-08 18:00:36.000000000","message":"This seems odd to me since the initial version 1.0 will be using NodePayload version 1.1. Or maybe I\u0027m wrong. Is there any diff between version 1.0 \u0026 1.1?","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0ec022a79e61e07f0c8ea10812732df53e4a213e","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic creates, updates or deletes a node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"},{"line_number":596,"context_line":"                  **{\u0027instance_info\u0027: (\u0027node\u0027, \u0027instance_info\u0027),"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a71b18c_9220669d","line":593,"in_reply_to":"3a71b18c_064a8383","updated":"2016-12-09 13:47:59.000000000","message":"Yes, there is a difference: https://review.openstack.org/#/c/401311/12/ironic/objects/node.py If we change the type of field we should bump version.","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"edc8bae47cfd813f2a48f304a4c3b575938a58a9","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic creates, updates or deletes a node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"},{"line_number":596,"context_line":"                  **{\u0027instance_info\u0027: (\u0027node\u0027, \u0027instance_info\u0027),"}],"source_content_type":"text/x-python","patch_set":26,"id":"1a6eadb0_6b74ee9b","line":593,"in_reply_to":"3a71b18c_9220669d","updated":"2016-12-13 15:49:16.000000000","message":"Yes, I realize that. But this is the very first version of NodeCRUDPayload. So I don\u0027t see why it needs to be 1.1 instead of 1.0. I must be missing something.","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e22bffc17317c6f1f932838535c1cf435721f1c0","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    \"\"\"Payload schema for when ironic creates, updates or deletes a node.\"\"\""},{"line_number":591,"context_line":"    # Version 1.0: Initial version"},{"line_number":592,"context_line":"    # Version 1.1: Parent NodePayload version 1.1"},{"line_number":593,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    SCHEMA \u003d dict(NodePayload.SCHEMA,"},{"line_number":596,"context_line":"                  **{\u0027instance_info\u0027: (\u0027node\u0027, \u0027instance_info\u0027),"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_01119b52","line":593,"updated":"2016-12-13 16:24:36.000000000","message":"We had an IRC discussion [1] about this, and agreed that it should be version 1.0, not 1.1. Even though it inherits from NodePayload (which is at version 1.1), this class is new, so it starts at version 1.0.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2016-12-13.log.html#t2016-12-13T15:47:04","commit_id":"923a1a310287386ec2b6215c746cae84ab249943"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"3a3dce2fddbbf6489a14b715034bcd43c816e530","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":443,"context_line":"    fields \u003d {"},{"line_number":444,"context_line":"        \u0027clean_step\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":445,"context_line":"        \u0027console_enabled\u0027: object_fields.BooleanField(),"},{"line_number":446,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":447,"context_line":"        \u0027driver\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":448,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a6eadb0_3754e21f","line":445,"updated":"2016-12-20 19:26:35.000000000","message":"After https://review.openstack.org/#/c/413197/ or some other fix for https://bugs.launchpad.net/ironic/+bug/1651517 lands, this will need to have nullable\u003dTrue for .start notifications to succeed.\n\nOtherwise, I think NotImplementedError will be raised during the POST since most API requests don\u0027t have console_enabled set before the node gets initialized in the DB.","commit_id":"bd66d4a3dae87ba47a09ba7d45a97cbeec41a9e7"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"3a3dce2fddbbf6489a14b715034bcd43c816e530","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        \u0027inspection_started_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":451,"context_line":"        \u0027instance_uuid\u0027: object_fields.UUIDField(nullable\u003dTrue),"},{"line_number":452,"context_line":"        \u0027last_error\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":453,"context_line":"        \u0027maintenance\u0027: object_fields.BooleanField(),"},{"line_number":454,"context_line":"        \u0027maintenance_reason\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":455,"context_line":"        \u0027network_interface\u0027: object_fields.StringField(nullable\u003dTrue),"},{"line_number":456,"context_line":"        \u0027name\u0027: object_fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a6eadb0_3702220c","line":453,"updated":"2016-12-20 19:26:35.000000000","message":"ditto here, should have nullable\u003dTrue","commit_id":"bd66d4a3dae87ba47a09ba7d45a97cbeec41a9e7"}],"ironic/objects/notification.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":183,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":184,"context_line":"    if hasattr(payload, \u0027driver_info\u0027):"},{"line_number":185,"context_line":"        payload.driver_info \u003d strutils.mask_dict_password("},{"line_number":186,"context_line":"            payload.driver_info, mask)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_20a4bea4","line":185,"updated":"2016-11-08 19:28:46.000000000","message":"It\u0027s possible for image_url (tempurl) to be here and not be masked for node update/delete notifications.","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":183,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":184,"context_line":"    if hasattr(payload, \u0027driver_info\u0027):"},{"line_number":185,"context_line":"        payload.driver_info \u003d strutils.mask_dict_password("},{"line_number":186,"context_line":"            payload.driver_info, mask)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_6ff4bef1","line":185,"in_reply_to":"9a629dbe_20a4bea4","updated":"2016-11-09 14:02:56.000000000","message":"How tempurl will be added to driver_info? Maybe only if operator mistake.","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"8adc21c2b1dee28887a3d156cc9109ec630dc90e","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            \u0027temp_url_sig\u003d\u0027 in payload.instance_info[\u0027image_url\u0027]):"},{"line_number":183,"context_line":"            payload.instance_info[\u0027image_url\u0027] \u003d mask"},{"line_number":184,"context_line":"    if hasattr(payload, \u0027driver_info\u0027):"},{"line_number":185,"context_line":"        payload.driver_info \u003d strutils.mask_dict_password("},{"line_number":186,"context_line":"            payload.driver_info, mask)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_454efb96","line":185,"in_reply_to":"9a629dbe_6ff4bef1","updated":"2016-11-09 14:42:15.000000000","message":"You are right: https://github.com/openstack/ironic/blob/95de92c63798830cc3f387909491eec635d116e0/ironic/drivers/modules/deploy_utils.py#L1291\n\nI was referencing your comment here when I was mentioning that:\nhttps://review.openstack.org/#/c/348437/20/ironic/conductor/notification_utils.py","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"}],"ironic/objects/port.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"9e4febb249ddf2e8a567cdae2cb6101b4b928ffe","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def _emit_create_notification(self):"},{"line_number":307,"context_line":"        \"\"\"Send port created notification.\"\"\""},{"line_number":308,"context_line":"        node \u003d self.dbapi.get_node_by_id(self.node_id)"},{"line_number":309,"context_line":"        payload \u003d PortDataPayload(node_uuid\u003dnode[\u0027uuid\u0027])"},{"line_number":310,"context_line":"        payload.populate_schema(port\u003dself)"},{"line_number":311,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_155d1747","line":308,"updated":"2016-08-17 15:21:02.000000000","message":"The best solution is get rid of resources \u0027id\u0027 in ironic at all.","commit_id":"a1b267c4820b47bc96454a8865fc2d09b6645d48"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":301,"context_line":"class PortCRUDNotification(notification.NotificationBase):"},{"line_number":302,"context_line":"    \"\"\"Notification emitted when ironic create, update or delete port.\"\"\""},{"line_number":303,"context_line":"    # Version 1.0: Initial version"},{"line_number":304,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_36b3940b","line":302,"updated":"2016-12-06 20:48:15.000000000","message":"this is a nit, but might as well get the grammar correct since it is copy/pasted several times.\n\ns/create/creates/\n\ns/update/updates/\n\ns/delete/deletes a/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"@base.IronicObjectRegistry.register"},{"line_number":301,"context_line":"class PortCRUDNotification(notification.NotificationBase):"},{"line_number":302,"context_line":"    \"\"\"Notification emitted when ironic create, update or delete port.\"\"\""},{"line_number":303,"context_line":"    # Version 1.0: Initial version"},{"line_number":304,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_2024ffad","line":302,"in_reply_to":"3a71b18c_36b3940b","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":334,"context_line":"        \u0027updated_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":335,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField()"},{"line_number":336,"context_line":"    }"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def __init__(self, port, node_uuid):"},{"line_number":339,"context_line":"        super(PortCRUDPayload, self).__init__(node_uuid\u003dnode_uuid)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_96c8e856","line":336,"updated":"2016-12-06 20:48:15.000000000","message":"we\u0027re not showing portgroup UUID. Is that cuz we aren\u0027t doing portgroup-related notifications yet? If so, maybe we should add a TODO comment. Guess that\u0027ll change the VERSION too.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":334,"context_line":"        \u0027updated_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":335,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField()"},{"line_number":336,"context_line":"    }"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def __init__(self, port, node_uuid):"},{"line_number":339,"context_line":"        super(PortCRUDPayload, self).__init__(node_uuid\u003dnode_uuid)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_c0b8abeb","line":336,"in_reply_to":"3a71b18c_96c8e856","updated":"2016-12-07 17:10:10.000000000","message":"TODO done, notifications for portgroup will be added in the separate patch.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"876534801938fdfbf5acbc274af2d655d287125c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        \u0027node_uuid\u0027: object_fields.UUIDField(),"},{"line_number":328,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":329,"context_line":"        \u0027updated_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":330,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField()"},{"line_number":331,"context_line":"        # TODO(yuriyz): add \"portgroup_uuid\" field with portgroup notifications"},{"line_number":332,"context_line":"    }"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_c980018e","line":330,"updated":"2016-12-16 16:11:10.000000000","message":"with attach/detach it will be possible to change interal_info field, we may add it here, or when attach/detach merged. Don\u0027t know which patch should go first.","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"62a6b66cf49bcd24d4a6ed669145247c08513fd8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        \u0027node_uuid\u0027: object_fields.UUIDField(),"},{"line_number":328,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":329,"context_line":"        \u0027updated_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":330,"context_line":"        \u0027uuid\u0027: object_fields.UUIDField()"},{"line_number":331,"context_line":"        # TODO(yuriyz): add \"portgroup_uuid\" field with portgroup notifications"},{"line_number":332,"context_line":"    }"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_38e9bcb7","line":330,"in_reply_to":"1a6eadb0_c980018e","updated":"2016-12-16 16:37:42.000000000","message":"Agree if it\u0027s requirement for real use cases. But \"interal_info\" name confuse me, it looks like for internal ironic purposes.","commit_id":"94f9d2ccb2464e3ddaf10eaaee00d01e365bf2a6"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"140656259909ca4ce729291bebc5602bfa53b531","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        \u0027extra\u0027: object_fields.FlexibleDictField(nullable\u003dTrue),"},{"line_number":324,"context_line":"        \u0027local_link_connection\u0027: object_fields.FlexibleDictField("},{"line_number":325,"context_line":"            nullable\u003dTrue),"},{"line_number":326,"context_line":"        \u0027pxe_enabled\u0027: object_fields.BooleanField(),"},{"line_number":327,"context_line":"        \u0027node_uuid\u0027: object_fields.UUIDField(),"},{"line_number":328,"context_line":"        \u0027created_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"},{"line_number":329,"context_line":"        \u0027updated_at\u0027: object_fields.DateTimeField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":32,"id":"1a6eadb0_daaf53e1","line":326,"updated":"2016-12-20 19:27:58.000000000","message":"this should have nullable\u003dTrue, as well as node_uuid below, unless we expect this to *always* be present before the POST makes the port in the DB","commit_id":"bd66d4a3dae87ba47a09ba7d45a97cbeec41a9e7"}],"ironic/tests/unit/api/v1/test_chassis.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        result \u003d self.get_json(\u0027/chassis/%s\u0027 % chassis.uuid)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        extra[\"foo2\"] \u003d new_value"},{"line_number":293,"context_line":"        self.assertEqual(extra, result[\u0027extra\u0027])"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_remove_singular(self):"},{"line_number":296,"context_line":"        chassis \u003d obj_utils.create_test_chassis(self.context, extra\u003d{\u0027a\u0027: \u0027b\u0027},"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_c02ea2f9","line":293,"updated":"2016-11-08 19:28:46.000000000","message":"Can you also add the mock_notify test here?","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        result \u003d self.get_json(\u0027/chassis/%s\u0027 % chassis.uuid)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        extra[\"foo2\"] \u003d new_value"},{"line_number":293,"context_line":"        self.assertEqual(extra, result[\u0027extra\u0027])"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_remove_singular(self):"},{"line_number":296,"context_line":"        chassis \u003d obj_utils.create_test_chassis(self.context, extra\u003d{\u0027a\u0027: \u0027b\u0027},"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_6f42fe11","line":293,"in_reply_to":"9a629dbe_c02ea2f9","updated":"2016-11-09 14:02:56.000000000","message":"Done","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"}],"ironic/tests/unit/objects/test_chassis.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ad57c77c016344e3fc9554e8252e1ebc3c462dfa","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @mock.patch.object(objects.Chassis.dbapi, \u0027create_chassis\u0027)"},{"line_number":132,"context_line":"    @mock.patch(\u0027ironic.objects.chassis.ChassisDataNotification\u0027)"},{"line_number":133,"context_line":"    def test_create(self, mock_data_notify, mock_create):"},{"line_number":134,"context_line":"        mock_create.return_value \u003d self.fake_chassis"},{"line_number":135,"context_line":"        self.chassis.create()"},{"line_number":136,"context_line":"        init_kwargs \u003d mock_data_notify.call_args[1]"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_54fd766c","line":133,"updated":"2016-10-14 21:46:42.000000000","message":"I think it\u0027d be good to test that emit() gets called on the notification for all of these tests, too.","commit_id":"a7716adc83b41d923272f0412871e8bb9fe2696d"}],"releasenotes/notes/resources-crud-notifications-70cba9f761da3afe.yaml":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ee0a7ae6878251ee8656c5d9156e703a4b295805","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources."},{"line_number":4,"context_line":"    Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_2ba49fa4","line":4,"updated":"2016-11-08 19:28:46.000000000","message":"nit: should also note that it\u0027s only for port, node, and chassis here","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a9a7194101085a1c81ff74966258a3633fd5bfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources."},{"line_number":4,"context_line":"    Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a629dbe_8faf5293","line":4,"in_reply_to":"9a629dbe_2ba49fa4","updated":"2016-11-09 14:02:56.000000000","message":"Done","commit_id":"bc6b3b13184c85d10ae6a0af710f890686cd2614"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_59f5a3ea","line":3,"updated":"2016-12-06 20:48:15.000000000","message":"s/Add/Adds/\n\ns/create, update/or delete/creation, updates, or deletions of/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_59a7630a","line":4,"updated":"2016-12-06 20:48:15.000000000","message":"maybe s/Event types general form/Event types are formatted as follows: /","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_06cb9c1f","line":4,"in_reply_to":"3a71b18c_59a7630a","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_99ad7beb","line":5,"updated":"2016-12-06 20:48:15.000000000","message":"missing period at the end.","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_e65ea078","line":5,"in_reply_to":"3a71b18c_99ad7beb","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"eeb5a3f52f13ae527f278f99a22f0f8f96325eca","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_d92e138b","line":6,"updated":"2016-12-06 20:48:15.000000000","message":"how about s/the developer documentation/http://docs.openstack.org/developer/ironic/deploy/notifications.html/","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"76d7f075102244c08ea967a3bc782ba6c0cc987d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add notifications for create, update or delete ironic resources (node,"},{"line_number":4,"context_line":"    port and chassis). Event types general form is"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\""},{"line_number":6,"context_line":"    For more details, see the developer documentation."}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3a71b18c_06647c47","line":6,"in_reply_to":"3a71b18c_d92e138b","updated":"2016-12-07 17:10:10.000000000","message":"Done","commit_id":"a88ecd82ee79dca8a544b2e114488f0a5486a9fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"001c4b1b8f55e4c1f5ea2a45ad1a897237c02de2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    (node, port and chassis). Event types are formatted as follows"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\"."},{"line_number":6,"context_line":"    For more details, see the developer documentation"},{"line_number":7,"context_line":"    /http://docs.openstack.org/developer/ironic/deploy/notifications.html"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3a71b18c_96bfa4fb","line":7,"updated":"2016-12-08 18:00:36.000000000","message":"missing period at the end.","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0ec022a79e61e07f0c8ea10812732df53e4a213e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    (node, port and chassis). Event types are formatted as follows"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\"."},{"line_number":6,"context_line":"    For more details, see the developer documentation"},{"line_number":7,"context_line":"    /http://docs.openstack.org/developer/ironic/deploy/notifications.html"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3a71b18c_cc0fa886","line":7,"in_reply_to":"3a71b18c_96bfa4fb","updated":"2016-12-09 13:47:59.000000000","message":"Done","commit_id":"6595f65f791c523f1bee1a3366fc52f2548bfe6e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2da11aa665cf4cdfec55acda1427ace72de68913","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds notifications for creation, updates, or deletions of ironic resources"},{"line_number":4,"context_line":"    (node, port and chassis). Event types are formatted as follows"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\"."},{"line_number":6,"context_line":"    For more details, see the developer documentation"},{"line_number":7,"context_line":"    /http://docs.openstack.org/developer/ironic/deploy/notifications.html."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a6eadb0_cc891828","line":5,"updated":"2016-12-15 20:53:57.000000000","message":"s/success,//","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"55e8ad997a2eb3743f96555a2e52b9f360d0bf6e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds notifications for creation, updates, or deletions of ironic resources"},{"line_number":4,"context_line":"    (node, port and chassis). Event types are formatted as follows"},{"line_number":5,"context_line":"    \"baremetal.\u003cresource\u003e.{create,update,delete}.{start,end,success,error}\"."},{"line_number":6,"context_line":"    For more details, see the developer documentation"},{"line_number":7,"context_line":"    /http://docs.openstack.org/developer/ironic/deploy/notifications.html."}],"source_content_type":"text/x-yaml","patch_set":30,"id":"1a6eadb0_b7e5ee09","line":5,"in_reply_to":"1a6eadb0_cc891828","updated":"2016-12-16 11:58:16.000000000","message":"Done","commit_id":"737614a2ea07adbcc5da0e7d23ab86777886814e"}]}
