)]}'
{"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"757da9dbc64cdef2078fd845d33073c05f927998","unresolved":false,"context_lines":[{"line_number":300,"context_line":"def is_dynamic_allocation_enabled(node):"},{"line_number":301,"context_line":"    flag \u003d node.driver_info.get(\u0027dynamic_allocation\u0027)"},{"line_number":302,"context_line":"    if flag:"},{"line_number":303,"context_line":"        if str(flag).lower() \u003d\u003d \u0027true\u0027:"},{"line_number":304,"context_line":"            return True"},{"line_number":305,"context_line":"        elif str(flag).lower() \u003d\u003d \u0027false\u0027:"},{"line_number":306,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_c9a2114b","line":303,"updated":"2016-08-25 16:34:40.000000000","message":"I think it would be better to use using strutils bool_from_string\n\nhttp://docs.openstack.org/developer/oslo.utils/api/strutils.html","commit_id":"074fc4569f3e71aec62ea6d8738a92c8e123e429"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"d1312285e000d5e64e422412763aadc0f6736c76","unresolved":false,"context_lines":[{"line_number":300,"context_line":"def is_dynamic_allocation_enabled(node):"},{"line_number":301,"context_line":"    flag \u003d node.driver_info.get(\u0027dynamic_allocation\u0027)"},{"line_number":302,"context_line":"    if flag:"},{"line_number":303,"context_line":"        if str(flag).lower() \u003d\u003d \u0027true\u0027:"},{"line_number":304,"context_line":"            return True"},{"line_number":305,"context_line":"        elif str(flag).lower() \u003d\u003d \u0027false\u0027:"},{"line_number":306,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f17bd279","line":303,"in_reply_to":"1ac06dbe_c9a2114b","updated":"2016-08-25 21:29:43.000000000","message":"Julia, please see patch set 3. :)","commit_id":"074fc4569f3e71aec62ea6d8738a92c8e123e429"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ab106cc3a5f0ff4aab9561b9c733b918fd777876","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            return strutils.bool_from_string(flag, strict\u003dTrue)"},{"line_number":275,"context_line":"        except ValueError:"},{"line_number":276,"context_line":"            msg \u003d (_LE(\"Invalid dynamic_allocation parameter value \""},{"line_number":277,"context_line":"                       \"\u0027%(flag)s\u0027 in node\u0027s %(node_uuid)s driver_info. \") %"},{"line_number":278,"context_line":"                   {\"flag\": flag, \"node_uuid\": node.uuid})"},{"line_number":279,"context_line":"            raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_296d9c98","line":277,"range":{"start_line":277,"start_character":71,"end_line":277,"end_character":72},"updated":"2016-08-26 15:39:35.000000000","message":"extra space","commit_id":"354234f85281d7034a7dd0b7c406d5057fe44509"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f7274dcdf3f00bc519a9f62ab2c74f5755730212","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            msg \u003d (_LE(\"Invalid dynamic_allocation parameter value \""},{"line_number":277,"context_line":"                       \"\u0027%(flag)s\u0027 in node\u0027s %(node_uuid)s driver_info.\") %"},{"line_number":278,"context_line":"                   {\"flag\": flag, \"node_uuid\": node.uuid})"},{"line_number":279,"context_line":"            raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_64d5fbb7","line":279,"updated":"2016-08-26 20:33:02.000000000","message":"Missing the test with raising of this exception.","commit_id":"c645881c805069583a9cf8dfc1e3dc5bd0ab4209"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"6f6907c02850a7c7945eff6eddd1294fa007d263","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            msg \u003d (_LE(\"Invalid dynamic_allocation parameter value \""},{"line_number":277,"context_line":"                       \"\u0027%(flag)s\u0027 in node\u0027s %(node_uuid)s driver_info.\") %"},{"line_number":278,"context_line":"                   {\"flag\": flag, \"node_uuid\": node.uuid})"},{"line_number":279,"context_line":"            raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_351cff76","line":279,"in_reply_to":"fa7ab95a_64d5fbb7","updated":"2016-08-26 21:29:32.000000000","message":"Done","commit_id":"c645881c805069583a9cf8dfc1e3dc5bd0ab4209"}],"releasenotes/notes/check-dynamic-allocation-enabled-e94f3b8963b114d0.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f7274dcdf3f00bc519a9f62ab2c74f5755730212","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Dynamic Allocation flag was not been validated when"},{"line_number":4,"context_line":"    the flag was added to the node by using ironic CLI."},{"line_number":5,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_04bd0f68","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2016-08-26 20:33:02.000000000","message":"issues section is for known issues, now when it\u0027s fixed it should not be here.","commit_id":"c645881c805069583a9cf8dfc1e3dc5bd0ab4209"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"6f6907c02850a7c7945eff6eddd1294fa007d263","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Dynamic Allocation flag was not been validated when"},{"line_number":4,"context_line":"    the flag was added to the node by using ironic CLI."},{"line_number":5,"context_line":"fixes:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_f502970a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"fa7ab95a_04bd0f68","updated":"2016-08-26 21:29:32.000000000","message":"Done","commit_id":"c645881c805069583a9cf8dfc1e3dc5bd0ab4209"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f7274dcdf3f00bc519a9f62ab2c74f5755730212","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Dynamic Allocation flag was not been validated when"},{"line_number":4,"context_line":"    the flag was added to the node by using ironic CLI."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - A new schema for validating the flag is introduced"},{"line_number":7,"context_line":"    in this patch."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_1703830e","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":18},"updated":"2016-08-26 20:33:02.000000000","message":"in the release notes it will be unclear what \"this patch\" is, as all the notes from the release are rendered in a single page. What about the following:\n\ndynamic_allocation flag in node\u0027s driver_info can now accept all the values that can be converted to booleans by bool_from_string function from oslo_utils.","commit_id":"c645881c805069583a9cf8dfc1e3dc5bd0ab4209"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"6f6907c02850a7c7945eff6eddd1294fa007d263","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Dynamic Allocation flag was not been validated when"},{"line_number":4,"context_line":"    the flag was added to the node by using ironic CLI."},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - A new schema for validating the flag is introduced"},{"line_number":7,"context_line":"    in this patch."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa7ab95a_30032d0f","line":7,"range":{"start_line":6,"start_character":4,"end_line":7,"end_character":18},"in_reply_to":"fa7ab95a_1703830e","updated":"2016-08-26 21:29:32.000000000","message":"Done","commit_id":"c645881c805069583a9cf8dfc1e3dc5bd0ab4209"}]}
