)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"43ed5440193f0b59eeaef1bdc66230a03fe68250","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables fetching the service URL from keystone catalog."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If862481533cf121bc6e829f0f39893134578ec30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_5fac84ed","line":11,"updated":"2016-08-25 23:28:25.000000000","message":"nit: is there a bug for this?","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"43ed5440193f0b59eeaef1bdc66230a03fe68250","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"#project_name \u003d \u003cNone\u003e"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"# ironic-inspector HTTP endpoint. If this is not set, the"},{"line_number":1399,"context_line":"# service catalog will be used. (string value)"},{"line_number":1400,"context_line":"#service_url \u003d \u003cNone\u003e"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"# period (in seconds) to check status of nodes on inspection"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa7ab95a_ff7b9879","line":1399,"updated":"2016-08-25 23:28:25.000000000","message":"Is this a breaking change? Should we worry about backwards compatibility for folks with this currently set to None?","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"588e9c6e94099e30279bb0d78350618b08cfc046","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"#project_name \u003d \u003cNone\u003e"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"# ironic-inspector HTTP endpoint. If this is not set, the"},{"line_number":1399,"context_line":"# service catalog will be used. (string value)"},{"line_number":1400,"context_line":"#service_url \u003d \u003cNone\u003e"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"# period (in seconds) to check status of nodes on inspection"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa7ab95a_61c194e4","line":1399,"in_reply_to":"fa7ab95a_c13a60cd","updated":"2016-08-26 10:12:46.000000000","message":"Yeah, true, but it is not changes with this patch.","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4eb9915e785b0936646dac65d429c11ec659a016","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"#project_name \u003d \u003cNone\u003e"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"# ironic-inspector HTTP endpoint. If this is not set, the"},{"line_number":1399,"context_line":"# service catalog will be used. (string value)"},{"line_number":1400,"context_line":"#service_url \u003d \u003cNone\u003e"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"# period (in seconds) to check status of nodes on inspection"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa7ab95a_c13a60cd","line":1399,"in_reply_to":"fa7ab95a_e5369ab3","updated":"2016-08-26 10:09:29.000000000","message":"The default value is $my_ip which, default is source IP address of default interface. It fallback to 127.0.0.1 if default route is not configured which is not a usual case. http://docs.openstack.org/developer/oslo.utils/api/netutils.html#oslo_utils.netutils.get_my_ipv4","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e47498d8a412e88dcb88ed5c40f429867f922530","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"#project_name \u003d \u003cNone\u003e"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"# ironic-inspector HTTP endpoint. If this is not set, the"},{"line_number":1399,"context_line":"# service catalog will be used. (string value)"},{"line_number":1400,"context_line":"#service_url \u003d \u003cNone\u003e"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"# period (in seconds) to check status of nodes on inspection"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa7ab95a_e5369ab3","line":1399,"in_reply_to":"fa7ab95a_ff7b9879","updated":"2016-08-26 07:50:53.000000000","message":"My bad, I should have clarified it here better. Actually if we can\u0027t get it from service catalog, we\u0027ll fall back to 127.0.0.1:5050 as before. See this relevant code: https://github.com/openstack/python-ironic-inspector-client/blob/master/ironic_inspector_client/common/http.py#L120-L129","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"}],"ironic/drivers/modules/inspector.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"70045998414996d6cc66359566bf8fe882c17603","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"\"\"Helper to get inspector client instance.\"\"\""},{"line_number":58,"context_line":"    return client.ClientV1(api_version\u003dINSPECTOR_API_VERSION,"},{"line_number":59,"context_line":"                           inspector_url\u003dCONF.inspector.service_url,"},{"line_number":60,"context_line":"                           session\u003d_get_inspector_session())"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class Inspector(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_0909ea2c","line":60,"updated":"2016-08-25 22:25:41.000000000","message":"I didn\u0027t look at your library; I\u0027m going to assume it is OK to set the session to None","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e47498d8a412e88dcb88ed5c40f429867f922530","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"\"\"Helper to get inspector client instance.\"\"\""},{"line_number":58,"context_line":"    return client.ClientV1(api_version\u003dINSPECTOR_API_VERSION,"},{"line_number":59,"context_line":"                           inspector_url\u003dCONF.inspector.service_url,"},{"line_number":60,"context_line":"                           session\u003d_get_inspector_session())"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class Inspector(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_250fa2e2","line":60,"in_reply_to":"fa7ab95a_0909ea2c","updated":"2016-08-26 07:50:53.000000000","message":"Yes, it is equivalent to what we had before when we passed just auth_token: https://github.com/openstack/python-ironic-inspector-client/blob/master/ironic_inspector_client/common/http.py#L108-L117","commit_id":"08e66ef8ecebabf97549a89e0ded8986a844fd76"}]}