)]}'
{"ironic/drivers/modules/oneview/common.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"546a03da70b8b488f1ce734ae2262aa273ebf74f","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":"    def inner(*args, **kwargs):"},{"line_number":275,"context_line":"        oneview_client \u003d args[0].oneview_client"},{"line_number":276,"context_line":"        task \u003d args[1]"},{"line_number":277,"context_line":"        oneview_info \u003d get_oneview_info(task.node)"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_391a007e","line":275,"updated":"2016-08-29 12:29:36.000000000","message":"I personally find it quite important to be explicit. If we expect that the first argument is always \"self\" or whatever we expect it to be, it must be explicit. Otherwise we have chances of failing with IndexError when this function is misused.","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e74b431b22cb78d44605c0a3402025204bbdf2b5","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":"    def inner(*args, **kwargs):"},{"line_number":275,"context_line":"        oneview_client \u003d args[0].oneview_client"},{"line_number":276,"context_line":"        task \u003d args[1]"},{"line_number":277,"context_line":"        oneview_info \u003d get_oneview_info(task.node)"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_cfad1e33","line":275,"range":{"start_line":275,"start_character":25,"end_line":275,"end_character":32},"updated":"2016-08-26 13:37:06.000000000","message":"The positional use makes me feel a little uncomfortable, I\u0027d rather see self used, but this does align with the existing code style, and that would be more invasive to the code to change as part of this patch.","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"2f3abbf1a72017f07667b18b89a10c8fbd738b4a","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":"    def inner(*args, **kwargs):"},{"line_number":275,"context_line":"        oneview_client \u003d args[0].oneview_client"},{"line_number":276,"context_line":"        task \u003d args[1]"},{"line_number":277,"context_line":"        oneview_info \u003d get_oneview_info(task.node)"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_e06a90b2","line":275,"in_reply_to":"fa7ab95a_391a007e","updated":"2016-08-29 14:09:23.000000000","message":"I\u0027m not sure how I\u0027m supposed to handle this since this is a decorator function... Do you have a suggestion?","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"9e6e2ec3f0b953b9e9b1ca7cfe1be88d4a2e37e9","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":"    def inner(*args, **kwargs):"},{"line_number":275,"context_line":"        oneview_client \u003d args[0].oneview_client"},{"line_number":276,"context_line":"        task \u003d args[1]"},{"line_number":277,"context_line":"        oneview_info \u003d get_oneview_info(task.node)"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_eb0eda8a","line":275,"in_reply_to":"fa7ab95a_b400bc02","updated":"2016-08-29 20:20:57.000000000","message":"Done. But its still strange since now I cannot apply it to other methods than the ones in the interface. But I couldn\u0027t do that before either, so I think it\u0027s ok.","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"619578a242ebec674aeaa53ef590058dc7e71107","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":"    def inner(*args, **kwargs):"},{"line_number":275,"context_line":"        oneview_client \u003d args[0].oneview_client"},{"line_number":276,"context_line":"        task \u003d args[1]"},{"line_number":277,"context_line":"        oneview_info \u003d get_oneview_info(task.node)"},{"line_number":278,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_b400bc02","line":275,"in_reply_to":"fa7ab95a_e06a90b2","updated":"2016-08-29 17:52:58.000000000","message":"mmm\n\n def inner(self, *args, **kwargs)\n\nor whatever variable name you find appropriate","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"}],"ironic/drivers/modules/oneview/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"f89e3bba451247dcf8c4a8fff0ab7ee0308890a4","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def prepare(self, task):"},{"line_number":216,"context_line":"        if common.is_dynamic_allocation_enabled(task.node):"},{"line_number":217,"context_line":"            deploy_utils.prepare(self.oneview_client, task)"},{"line_number":218,"context_line":"        super(OneViewIscsiDeploy, self).prepare(task)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def tear_down(self, task):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_2cf12ace","line":217,"range":{"start_line":217,"start_character":33,"end_line":217,"end_character":52},"updated":"2016-08-31 17:25:31.000000000","message":"Where does it come from here? Ditto for all other occurrences in this file, and they are not unittested.","commit_id":"fca1ef587aa56f4fbf521b0a801f48d04b2178a9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b57e5ccad7a4e960d3dc94f886198a77d244e791","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        self.oneview_client \u003d common.get_oneview_client()"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def get_properties(self):"},{"line_number":229,"context_line":"        return deploy_utils.get_properties()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def validate(self, task):"},{"line_number":232,"context_line":"        common.verify_node_info(task.node)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_d2882f25","line":229,"updated":"2016-10-31 08:55:17.000000000","message":"this seems unrelated bug fix, could you please split it out?","commit_id":"f66b1a722632e0d3bfca0b384e0181b3a713143f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b57e5ccad7a4e960d3dc94f886198a77d244e791","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        if (common.is_dynamic_allocation_enabled(task.node) and"},{"line_number":247,"context_line":"           not CONF.conductor.automated_clean):"},{"line_number":248,"context_line":"            deploy_utils.tear_down(self.oneview_client, task)"},{"line_number":249,"context_line":"        return super(OneViewIscsiDeploy, self).tear_down(task)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def prepare_cleaning(self, task):"},{"line_number":252,"context_line":"        if common.is_dynamic_allocation_enabled(task.node):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_f28b731c","line":249,"updated":"2016-10-31 08:55:17.000000000","message":"ditto","commit_id":"f66b1a722632e0d3bfca0b384e0181b3a713143f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b57e5ccad7a4e960d3dc94f886198a77d244e791","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    def tear_down_cleaning(self, task):"},{"line_number":257,"context_line":"        if common.is_dynamic_allocation_enabled(task.node):"},{"line_number":258,"context_line":"            deploy_utils.tear_down_cleaning(self.oneview_client, task)"},{"line_number":259,"context_line":"        super(OneViewIscsiDeploy, self).tear_down_cleaning(task)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"class OneViewAgentDeploy(agent.AgentDeploy, OneViewPeriodicTasks):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5da102_12838705","line":259,"updated":"2016-10-31 08:55:17.000000000","message":"ditto","commit_id":"f66b1a722632e0d3bfca0b384e0181b3a713143f"}],"ironic/drivers/modules/oneview/deploy_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"546a03da70b8b488f1ce734ae2262aa273ebf74f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":31,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"oneview_client \u003d common.get_oneview_client()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def get_properties():"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_591fc46b","line":33,"updated":"2016-08-29 12:29:36.000000000","message":"I\u0027m not sure how I feel about an object created at top level... For me a bit cleaner would be to create a helper function that cashes its result. What about making common.get_oneview_client caching?","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"619578a242ebec674aeaa53ef590058dc7e71107","unresolved":false,"context_lines":[{"line_number":30,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":31,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"oneview_client \u003d common.get_oneview_client()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def get_properties():"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_7432b4f3","line":33,"in_reply_to":"fa7ab95a_40ffbca9","updated":"2016-08-29 17:52:58.000000000","message":"then I think a saner option is to create a client per interface and pass it explicitly to these functions.","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"2f3abbf1a72017f07667b18b89a10c8fbd738b4a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":31,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"oneview_client \u003d common.get_oneview_client()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def get_properties():"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_40ffbca9","line":33,"in_reply_to":"fa7ab95a_591fc46b","updated":"2016-08-29 14:09:23.000000000","message":"I know the feeling, but we have a requirement for each interface to have it\u0027s own instance of oneview_client for audit purposes.","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"9e6e2ec3f0b953b9e9b1ca7cfe1be88d4a2e37e9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"oneview_exception \u003d importutils.try_import(\u0027oneview_client.exceptions\u0027)"},{"line_number":31,"context_line":"oneview_utils \u003d importutils.try_import(\u0027oneview_client.utils\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"oneview_client \u003d common.get_oneview_client()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def get_properties():"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_fd1dc762","line":33,"in_reply_to":"fa7ab95a_7432b4f3","updated":"2016-08-29 20:20:57.000000000","message":"Done","commit_id":"645efefb9626a6b13c79ea3c58fbad5685a46acc"}],"ironic/drivers/modules/oneview/inspect.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"d02453a72e660e30e8e9f028102f33e47cfbbaa8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(OneViewInspect, self).__init__()"},{"line_number":44,"context_line":"        self.oneview_client \u003d common.get_oneview_client()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_properties(self):"},{"line_number":47,"context_line":"        return deploy_utils.get_properties()"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_d2a3c14d","line":44,"updated":"2016-12-14 13:46:04.000000000","message":"Instead of duplicating it in all interfaces related to oneview, maybe better to introduce that on the driver level? And then use task.driver.oneview_client where needed.","commit_id":"83b2d563a91dcdf4aada78895dcfefa93c6d796f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"28922481b5432431b92c42778f0c0a8dd964cd1c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        super(OneViewInspect, self).__init__()"},{"line_number":44,"context_line":"        self.oneview_client \u003d common.get_oneview_client()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def get_properties(self):"},{"line_number":47,"context_line":"        return deploy_utils.get_properties()"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a6eadb0_71782a90","line":44,"in_reply_to":"1a6eadb0_d2a3c14d","updated":"2016-12-14 14:09:48.000000000","message":"Considering driver comp is going to more-so allow the picking and choosing of interfaces, I think the existing approach is right for this driver.","commit_id":"83b2d563a91dcdf4aada78895dcfefa93c6d796f"}],"ironic/drivers/modules/oneview/management.py":[{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"8b8dfd8ec1404cdfdaa1eb16a32b673a10dccff1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            )"},{"line_number":121,"context_line":"            raise exception.OneViewError(error\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @common.node_has_server_profile"},{"line_number":124,"context_line":"    def get_boot_device(self, task):"},{"line_number":125,"context_line":"        \"\"\"Get the current boot device for the task\u0027s node."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_b2bbcc74","line":123,"range":{"start_line":123,"start_character":4,"end_line":123,"end_character":35},"updated":"2016-08-25 13:28:54.000000000","message":"a new client is created here too...","commit_id":"8509794599071bdee242e153c0c49ac98e15e08b"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"7fcc0cedcabf8be989720753d1f929a9701e2fb8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            )"},{"line_number":121,"context_line":"            raise exception.OneViewError(error\u003dmsg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @common.node_has_server_profile"},{"line_number":124,"context_line":"    def get_boot_device(self, task):"},{"line_number":125,"context_line":"        \"\"\"Get the current boot device for the task\u0027s node."},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_7fd638f2","line":123,"range":{"start_line":123,"start_character":4,"end_line":123,"end_character":35},"in_reply_to":"1ac06dbe_b2bbcc74","updated":"2016-08-25 13:58:51.000000000","message":"Done","commit_id":"8509794599071bdee242e153c0c49ac98e15e08b"}],"ironic/drivers/modules/oneview/power.py":[{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"8b8dfd8ec1404cdfdaa1eb16a32b673a10dccff1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        common.verify_node_info(task.node)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            common.validate_oneview_resources_compatibility(task)"},{"line_number":63,"context_line":"        except exception.OneViewError as oneview_exc:"},{"line_number":64,"context_line":"            raise exception.InvalidParameterValue(oneview_exc)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2657a103","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":65},"updated":"2016-08-25 13:28:54.000000000","message":"a new client is created here too","commit_id":"8509794599071bdee242e153c0c49ac98e15e08b"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"7fcc0cedcabf8be989720753d1f929a9701e2fb8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        common.verify_node_info(task.node)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            common.validate_oneview_resources_compatibility(task)"},{"line_number":63,"context_line":"        except exception.OneViewError as oneview_exc:"},{"line_number":64,"context_line":"            raise exception.InvalidParameterValue(oneview_exc)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_1c263268","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":65},"in_reply_to":"1ac06dbe_2657a103","updated":"2016-08-25 13:58:51.000000000","message":"Done","commit_id":"8509794599071bdee242e153c0c49ac98e15e08b"}]}
