)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-api"},{"line_number":28,"context_line":"3) Install OSprofiler:"},{"line_number":29,"context_line":"  Enable_plugin osprofiler"},{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_5110fe4e","line":30,"updated":"2016-08-25 21:58:26.000000000","message":"s/ironic(baremetal)/openstack baremetal/\n\nit might be confusing otherwise, since the ironic cli is \u0027ironic xxx\u0027.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  ENABLED_SERVICES+\u003d,ceilometer-api"},{"line_number":28,"context_line":"3) Install OSprofiler:"},{"line_number":29,"context_line":"  Enable_plugin osprofiler"},{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_d8556ec2","line":30,"in_reply_to":"fa7ab95a_5110fe4e","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":28,"context_line":"3) Install OSprofiler:"},{"line_number":29,"context_line":"  Enable_plugin osprofiler"},{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"},{"line_number":34,"context_line":"4)Get HTML with traces:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_51655edf","line":31,"updated":"2016-08-25 21:58:26.000000000","message":"maybe add \u0027. For example, the following will cause the \u003cTrace  ID\u003e to be printed: \u0027","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"3) Install OSprofiler:"},{"line_number":29,"context_line":"  Enable_plugin osprofiler"},{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"},{"line_number":34,"context_line":"4)Get HTML with traces:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_18743666","line":31,"in_reply_to":"fa7ab95a_51655edf","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  Enable_plugin osprofiler"},{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"},{"line_number":34,"context_line":"4)Get HTML with traces:"},{"line_number":35,"context_line":"  $ osprofiler trace show --html \u003cTrace ID\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_9148c65d","line":32,"updated":"2016-08-25 21:58:26.000000000","message":"\u0027baremetal list\u0027 is deprecated. better to use \u0027baremetal node list\u0027.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  Enable_plugin osprofiler"},{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"},{"line_number":34,"context_line":"4)Get HTML with traces:"},{"line_number":35,"context_line":"  $ osprofiler trace show --html \u003cTrace ID\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_3871fa76","line":32,"in_reply_to":"fa7ab95a_9148c65d","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"},{"line_number":34,"context_line":"4)Get HTML with traces:"},{"line_number":35,"context_line":"  $ osprofiler trace show --html \u003cTrace ID\u003e"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_91b6063c","line":33,"updated":"2016-08-25 21:58:26.000000000","message":"where will it get printed?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"3) Use openstackclient and run ironic(baremetal) command with"},{"line_number":31,"context_line":"  --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"  $ openstack --profile \u003cSECRET_KEY\u003e baremetal list"},{"line_number":33,"context_line":"  # it will print \u003cTrace ID\u003e"},{"line_number":34,"context_line":"4)Get HTML with traces:"},{"line_number":35,"context_line":"  $ osprofiler trace show --html \u003cTrace ID\u003e"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_18fb56c2","line":33,"in_reply_to":"fa7ab95a_91b6063c","updated":"2016-08-29 20:12:00.000000000","message":"It will print to stdout along with node list output.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dac16ff514f481883d62cad4293e626386bcdb37","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    to osprofiler, which will be used to send notifications to Ceilometer."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"NOTE to test this:"},{"line_number":21,"context_line":"1) Enable profiler option(s) in ironic.conf."},{"line_number":22,"context_line":"2) Enable the following services in localrc for devstack:"},{"line_number":23,"context_line":"   CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"},{"line_number":24,"context_line":"   ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_cd7aba76","line":21,"updated":"2016-09-08 19:26:01.000000000","message":"maybe specify which options. There is a trace_sqlalchemy config -- will that work if it is set to true?","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    to osprofiler, which will be used to send notifications to Ceilometer."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"NOTE to test this:"},{"line_number":21,"context_line":"1) Enable profiler option(s) in ironic.conf."},{"line_number":22,"context_line":"2) Enable the following services in localrc for devstack:"},{"line_number":23,"context_line":"   CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"},{"line_number":24,"context_line":"   ENABLED_SERVICES+\u003d,ceilometer-acompute,ceilometer-acentral"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_5d5c54ed","line":21,"in_reply_to":"9a89bdaa_cd7aba76","updated":"2016-09-14 17:53:35.000000000","message":"Done. trace_sqlalchemy is not checked or used in this patch. The other two options need to be set in order to trace any calls.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2edb0b1ff684628938067dfdecdcf7d8fc433159","unresolved":false,"context_lines":[{"line_number":28,"context_line":"3) Install OSProfiler:"},{"line_number":29,"context_line":"   Enable_plugin osprofiler"},{"line_number":30,"context_line":"4) Use openstackclient and run baremetal command with"},{"line_number":31,"context_line":"   --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"   For example, the following will cause the \u003cTrace ID\u003e to be printed"},{"line_number":33,"context_line":"   after node list:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_6317ff44","line":31,"updated":"2016-09-08 19:44:55.000000000","message":"before i forget, I get this message:\nThe --profile option is deprecated, please use --os-profile instead. Using osprofiler v1.4.0.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":28,"context_line":"3) Install OSProfiler:"},{"line_number":29,"context_line":"   Enable_plugin osprofiler"},{"line_number":30,"context_line":"4) Use openstackclient and run baremetal command with"},{"line_number":31,"context_line":"   --profile \u003cSECRET_KEY\u003e"},{"line_number":32,"context_line":"   For example, the following will cause the \u003cTrace ID\u003e to be printed"},{"line_number":33,"context_line":"   after node list:"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_bd0478c0","line":31,"in_reply_to":"9a89bdaa_6317ff44","updated":"2016-09-14 17:53:35.000000000","message":"Thanks. Mentioned both in the doc.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dac16ff514f481883d62cad4293e626386bcdb37","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   For example, the following will cause the \u003cTrace ID\u003e to be printed"},{"line_number":33,"context_line":"   after node list:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   $ openstack --profile \u003cSECRET_KEY\u003e baremetal node list"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   # Trace ID: \u003cTrace ID\u003e"},{"line_number":38,"context_line":"   # Display trace with command:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_2ddb267d","line":35,"updated":"2016-09-08 19:26:01.000000000","message":"By default, the hmac_key is \u0027SECRET_KEY\u0027. So you could mention that, and then change this to s/\u003cSECRET_KEY\u003e/SECRET_KEY/","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   For example, the following will cause the \u003cTrace ID\u003e to be printed"},{"line_number":33,"context_line":"   after node list:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   $ openstack --profile \u003cSECRET_KEY\u003e baremetal node list"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   # Trace ID: \u003cTrace ID\u003e"},{"line_number":38,"context_line":"   # Display trace with command:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_ddff84a8","line":35,"in_reply_to":"9a89bdaa_2ddb267d","updated":"2016-09-14 17:53:35.000000000","message":"Done.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dac16ff514f481883d62cad4293e626386bcdb37","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   # Trace ID: \u003cTrace ID\u003e"},{"line_number":38,"context_line":"   # Display trace with command:"},{"line_number":39,"context_line":"   # osprofiler trace show --html \u003cTrace ID\u003e"},{"line_number":40,"context_line":"5) The trace results can be seen using this command:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   $ osprofiler trace show --html \u003cTrace ID\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_4dbdca00","line":39,"updated":"2016-09-08 19:26:01.000000000","message":"I saw these lines, but not with the \u0027#\u0027 in front.\n\nAlso, I saw these even when there was no trace.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   # Trace ID: \u003cTrace ID\u003e"},{"line_number":38,"context_line":"   # Display trace with command:"},{"line_number":39,"context_line":"   # osprofiler trace show --html \u003cTrace ID\u003e"},{"line_number":40,"context_line":"5) The trace results can be seen using this command:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   $ osprofiler trace show --html \u003cTrace ID\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_fdd36036","line":39,"in_reply_to":"9a89bdaa_4dbdca00","updated":"2016-09-14 17:53:35.000000000","message":"Done.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"}],"doc/source/contributor/osprofiler-support.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98d14e2883e3ca1c898ec4d7e7a3978cba1a5100","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    [profiler]"},{"line_number":71,"context_line":"    enabled \u003d True"},{"line_number":72,"context_line":"    hmac_keys \u003d SECRET_KEY # default value used across several OpenStack projects"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"In order to trace ironic using OSProfiler, use openstackclient to run"},{"line_number":76,"context_line":"baremetal commands with"}],"source_content_type":"text/x-rst","patch_set":35,"id":"df3967d1_d5885ac7","line":73,"updated":"2017-07-31 20:05:39.000000000","message":"should we mention trace_sqlalchemy?","commit_id":"3773f17403bb02b372673643780b9619151d22ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f18fe380f494e6d06455059968e4751994a6fdeb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"The trace results can be saved in a file with ``--out file-name`` option::"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    $ osprofiler trace show --html \u003ctrace-id\u003e --out trace.html"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Sample Trace:"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. figure:: ../images/sample_trace.svg"}],"source_content_type":"text/x-rst","patch_set":35,"id":"df3967d1_f0d00c53","line":97,"updated":"2017-07-31 20:08:47.000000000","message":"It would be nice to document what is being traced. Is this correct? the time spent in ironic-api, ironic-conductor, and db calls -- more db detailed numbers if trace-sqlalchemy is set to true.","commit_id":"3773f17403bb02b372673643780b9619151d22ea"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d183a88d61206646a16d41dbd4ff7001a1f71ca7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"   :width: 660px"},{"line_number":102,"context_line":"   :align: left"},{"line_number":103,"context_line":"   :alt: Sample Trace"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":".. figure:: ../images/sample_trace_details.svg"},{"line_number":107,"context_line":"   :width: 660px"}],"source_content_type":"text/x-rst","patch_set":35,"id":"df3967d1_d229829b","line":104,"updated":"2017-08-01 07:15:00.000000000","message":"nit: I\u0027d prefer something between these two images, maybe a comment. otherwise they look like one huge image","commit_id":"3773f17403bb02b372673643780b9619151d22ea"}],"doc/source/deploy/osprofiler-support.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":3,"context_line":"OSprofiler Cross-Project Library"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_d1beced3","line":6,"updated":"2016-08-25 21:58:26.000000000","message":"Is this to be used by developers or operators? If developers, it fits better in doc/source/dev/.\n\nAlso, it should be linked from the main page:  http://docs.openstack.org/developer/ironic/","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"OSprofiler Cross-Project Library"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_ab885272","line":6,"in_reply_to":"fa7ab95a_d1beced3","updated":"2016-08-29 20:12:00.000000000","message":"It is for developers. I will add it to doc/source/dev/ and link it to main page.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"},{"line_number":10,"context_line":"through all involved services, and builds a tree of calls."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_b1a06aa7","line":7,"updated":"2016-08-25 21:58:26.000000000","message":"Is it \u0027OSProfiler\u0027 or \u0027OSprofiler\u0027?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"},{"line_number":10,"context_line":"through all involved services, and builds a tree of calls."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_eb597a36","line":7,"in_reply_to":"fa7ab95a_b1a06aa7","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"},{"line_number":10,"context_line":"through all involved services, and builds a tree of calls."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_119e7656","line":8,"updated":"2016-08-25 21:58:26.000000000","message":"Maybe \u0027OS\u003cp\u003erofiler may be used between OpenStack projects (via their python clients) to look at performance issues and detect bottlenecks.\u0027 \n\nI\u0027m not quite sure why you singled out the python clients (the clients are part of the projects). So maybe some clarification would help.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"},{"line_number":10,"context_line":"through all involved services, and builds a tree of calls."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_2b40c233","line":8,"in_reply_to":"fa7ab95a_119e7656","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"},{"line_number":10,"context_line":"through all involved services, and builds a tree of calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"How OSprofiler works"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_917446fe","line":9,"updated":"2016-08-25 21:58:26.000000000","message":"Maybe  \u0027OS\u003cp\u003erofiler will generate a trace for a request. This trace will go through all the services that are used to satisfy the request.\n\nI\u0027m not sure what the \u0027builds a tree of calls\u0027 is for. What builds the tree of calls, and why does it matter? The trace has the info?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"OSProfiler is an OpenStack cross-project profiling library."},{"line_number":7,"context_line":"OSprofiler is going to be used by all OpenStack projects and"},{"line_number":8,"context_line":"their python clients to locate any bottlenecks. The purpose"},{"line_number":9,"context_line":"is to be able to generate one trace per request, that goes"},{"line_number":10,"context_line":"through all involved services, and builds a tree of calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"How OSprofiler works"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_eb709aa6","line":9,"in_reply_to":"fa7ab95a_917446fe","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        \"info\": \u003cdict\u003e"},{"line_number":25,"context_line":"    }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The fields are defined as the following:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"``base_id`` - \u003cuuid\u003e that is equal for all trace points that belong to"},{"line_number":30,"context_line":"one trace, this is done to simplify the process of retrieving all"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_31db7aef","line":27,"updated":"2016-08-25 21:58:26.000000000","message":"s/the following/follows/","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The fields are defined as the following:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"``base_id`` - \u003cuuid\u003e that is equal for all trace points that belong to"},{"line_number":30,"context_line":"one trace, this is done to simplify the process of retrieving all"},{"line_number":31,"context_line":"trace points related to one trace from collector."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_f1b5927e","line":29,"updated":"2016-08-25 21:58:26.000000000","message":"not sure if you mean s/equal/the same UUID/ or \u0027should be the same\u0027 ?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":27,"context_line":"The fields are defined as the following:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"``base_id`` - \u003cuuid\u003e that is equal for all trace points that belong to"},{"line_number":30,"context_line":"one trace, this is done to simplify the process of retrieving all"},{"line_number":31,"context_line":"trace points related to one trace from collector."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"``parent_id`` - \u003cuuid\u003e of parent trace point."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_71aa621b","line":30,"updated":"2016-08-25 21:58:26.000000000","message":"s/, this is done/. This is used/","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":35,"context_line":"``trace_id`` - \u003cuuid\u003e of current trace point."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"``info`` - the dictionary that contains user information passed when"},{"line_number":38,"context_line":"calling profiler start() \u0026 stop() methods."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The profiler uses Ceilometer as a centralized collector. A notifier is"},{"line_number":41,"context_line":"setup to send notifications to Ceilometer using oslo.messaging and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_11403656","line":38,"updated":"2016-08-25 21:58:26.000000000","message":"are these start(), stop() methods different from the above start and stop  messages (Line 16)?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"cd904e17d4eeb594597df0d712c66d5992fc24db","unresolved":false,"context_lines":[{"line_number":37,"context_line":"``info`` - the dictionary that contains user information passed when"},{"line_number":38,"context_line":"calling profiler start() \u0026 stop() methods."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The profiler uses Ceilometer as a centralized collector. A notifier is"},{"line_number":41,"context_line":"setup to send notifications to Ceilometer using oslo.messaging and"},{"line_number":42,"context_line":"Ceilometer API to retrieve all messages related to one trace. "},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ac06dbe_c39237f6","line":40,"updated":"2016-08-24 19:41:38.000000000","message":"please update this paragraph with latest state of the OSprofiler - right now at least pure MongoDB driver can be an alternative for Ceilometer, Elasticsearch is almost merged","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"121ca98fa2e3f1b1a854ee140d639e0691497c17","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The profiler uses Ceilometer as a centralized collector. A notifier is"},{"line_number":41,"context_line":"setup to send notifications to Ceilometer using oslo.messaging and"},{"line_number":42,"context_line":"Ceilometer API to retrieve all messages related to one trace. "},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OSprofiler has entry point that allows the user to retrieve information"},{"line_number":45,"context_line":"about traces and present it in html/json using CLI."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ac06dbe_99fffd00","line":42,"updated":"2016-08-19 23:45:59.000000000","message":"Will fix the trailing whitespace in the next patch.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"The profiler uses Ceilometer as a centralized collector. A notifier is"},{"line_number":41,"context_line":"setup to send notifications to Ceilometer using oslo.messaging and"},{"line_number":42,"context_line":"Ceilometer API to retrieve all messages related to one trace. "},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OSprofiler has entry point that allows the user to retrieve information"},{"line_number":45,"context_line":"about traces and present it in html/json using CLI."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_3c68b1ba","line":42,"in_reply_to":"1ac06dbe_99fffd00","updated":"2016-08-25 21:58:26.000000000","message":"I\u0027m not sure how to parse the above sentence. Is it \u0027A notifier is set up to send notifications to Ceilometer using oslo.messaging and Ceilometer API (then I can\u0027t figure out how \u0027to retrieve ... \u0027 fits in)\n\nOr is it \u0027A notifier is set up to send notifications to Ceilometer using oslo.messaging. Then the Ceilometer API is used to retrieve ...","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Ceilometer API to retrieve all messages related to one trace. "},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OSprofiler has entry point that allows the user to retrieve information"},{"line_number":45,"context_line":"about traces and present it in html/json using CLI."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Additional information is available"},{"line_number":48,"context_line":"`here \u003chttp://docs.openstack.org/developer/osprofiler/index.html\u003e`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_dced0527","line":45,"updated":"2016-08-25 21:58:26.000000000","message":"html/json -\u003e HTML/JSON","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Enabling OSprofiler in Ironic to trace HTTP/RPC/DB API calls"},{"line_number":59,"context_line":"requires the following steps:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- Add OSprofiler WSGI middleware to Ironic service."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Enable profiler config options in /etc/ironic.conf."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_dcbee5d3","line":61,"updated":"2016-08-25 21:58:26.000000000","message":"doesn\u0027t this patch take care of this?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"``To display trace use next command:"},{"line_number":82,"context_line":"osprofiler trace show --html \u003ctrace-id\u003e``"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa7ab95a_bc2be132","line":83,"updated":"2016-08-25 21:58:26.000000000","message":"What is the intent of this document? It looks to me like it is describing how osprofiler is hooked into ironic.\n\nGiven that your patch is merged. As a developer, if I wanted to use osprofiler to do some tracing, what do i have to do?","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"}],"doc/source/dev/dev-quickstart.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9cae0a1062c948e8bbb3567f007cf90bec6d8d7e","unresolved":false,"context_lines":[{"line_number":759,"context_line":""},{"line_number":760,"context_line":"OSProfiler is an OpenStack cross-project profiling library. It is being"},{"line_number":761,"context_line":"used among OpenStack projects to look at performance issues and detect"},{"line_number":762,"context_line":"bottlenecks. For details on how OSProfiler works and how to use it in Ironic,"},{"line_number":763,"context_line":"please refer to `OSProfiler Support Documentation \u003cosprofiler-support\u003e`_."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_c23916d9","line":762,"updated":"2017-01-27 22:14:52.000000000","message":"lowercase \"I\" in \"ironic\" please, per the docs style guide http://docs.openstack.org/contributor-guide/writing-style/openstack-components.html","commit_id":"7a5c33606221c7448b1d06bd0c6b1886ff5c8aa9"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"8d6894c89fd19f68c61d37c7ef72af029313787c","unresolved":false,"context_lines":[{"line_number":759,"context_line":""},{"line_number":760,"context_line":"OSProfiler is an OpenStack cross-project profiling library. It is being"},{"line_number":761,"context_line":"used among OpenStack projects to look at performance issues and detect"},{"line_number":762,"context_line":"bottlenecks. For details on how OSProfiler works and how to use it in Ironic,"},{"line_number":763,"context_line":"please refer to `OSProfiler Support Documentation \u003cosprofiler-support\u003e`_."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_10736416","line":762,"in_reply_to":"3a461143_c23916d9","updated":"2017-01-27 23:49:04.000000000","message":"Done","commit_id":"7a5c33606221c7448b1d06bd0c6b1886ff5c8aa9"}],"doc/source/dev/osprofiler-support.rst":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a6a171b70bcc0db5c6476848d5ccce513a44c484","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _OSProfiler-support:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"OSProfiler Cross-Project Library"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a89bdaa_44302008","line":3,"updated":"2016-09-09 11:26:01.000000000","message":"I was thinking that it might be useful to include here, how to use osprofiler+ironic in devstack. Eg, the instructions you have in the commit message could be elaborated here. You could mention that in addition to the setup described at http://docs.openstack.org/developer/ironic/dev/dev-quickstart.html#deploying-ironic-with-devstack, you need to \u003cwhatever\u003e.\n\nWhat do you think? If you wanted to use osprofiler, what information would be useful for you in order to get it working etc?","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. _OSProfiler-support:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"OSProfiler Cross-Project Library"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a8ec9b2_bdc9d87a","line":3,"in_reply_to":"9a89bdaa_44302008","updated":"2016-09-14 17:53:35.000000000","message":"Thanks. Done.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dac16ff514f481883d62cad4293e626386bcdb37","unresolved":false,"context_lines":[{"line_number":52,"context_line":"`here \u003chttp://docs.openstack.org/developer/osprofiler/index.html\u003e`_."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Enabling OSProfiler in Ironic"},{"line_number":55,"context_line":"-----------------------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable cross service profiling, we need to send base_id and"},{"line_number":58,"context_line":"trace_id from caller to callee, so that callee will be able to initialize"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a89bdaa_68e19c29","line":55,"updated":"2016-09-08 19:26:01.000000000","message":"I think, if this is geared for someone who wants to *use* osprofiler, that it would be good to indicate in perhaps two sections, 1. what this patch does; 2. what the user needs to do to actually enable \u0026 use it. It isn\u0027t clear when reading this, if I have to add OSProfiler to middleware or put in headers in client request. Do I have to initialize the profiler at start of service?","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":52,"context_line":"`here \u003chttp://docs.openstack.org/developer/osprofiler/index.html\u003e`_."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Enabling OSProfiler in Ironic"},{"line_number":55,"context_line":"-----------------------------"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To enable cross service profiling, we need to send base_id and"},{"line_number":58,"context_line":"trace_id from caller to callee, so that callee will be able to initialize"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a8ec9b2_dda9447d","line":55,"in_reply_to":"9a89bdaa_68e19c29","updated":"2016-09-14 17:53:35.000000000","message":"Done. Made it clear in the doc and commit message.\n\nThe patch does the initialization. User needs to setup the environment with OSProfiler and Ceilometer and set the [profiler] options in ironic.conf.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"dac16ff514f481883d62cad4293e626386bcdb37","unresolved":false,"context_lines":[{"line_number":58,"context_line":"trace_id from caller to callee, so that callee will be able to initialize"},{"line_number":59,"context_line":"its profiler with these values."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Enabling OSProfiler in Ironic to trace HTTP/RPC/DB API calls"},{"line_number":62,"context_line":"requires the following steps:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- Add OSProfiler WSGI middleware to Ironic service."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a89bdaa_685c3c19","line":61,"updated":"2016-09-08 19:26:01.000000000","message":"does this patch enable tracing of HTTP, RPC and DB api?","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":58,"context_line":"trace_id from caller to callee, so that callee will be able to initialize"},{"line_number":59,"context_line":"its profiler with these values."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Enabling OSProfiler in Ironic to trace HTTP/RPC/DB API calls"},{"line_number":62,"context_line":"requires the following steps:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- Add OSProfiler WSGI middleware to Ironic service."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a8ec9b2_7dcbd053","line":61,"in_reply_to":"9a89bdaa_685c3c19","updated":"2016-09-14 17:53:35.000000000","message":"Yes. The tracing wasn\u0027t added for DB Api before. In the new patch, added the trace for DB Api.","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9ca1ecdd99a659c99f05c2897f724fe6cf2b53d7","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The trace results can be saved in a file with ``--out file-name`` option."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Sample Trace:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. figure:: ../images/sample_trace.svg"},{"line_number":96,"context_line":"   :width: 660px"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a89bdaa_68a7dca6","line":93,"updated":"2016-09-08 19:32:59.000000000","message":"Nice graphic.\n\nIt shows keystone as well as ironic. Should the profiler be enabled in keystone too?","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"9ca8d434649c7f992abacd7eb80504acead68b16","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The trace results can be saved in a file with ``--out file-name`` option."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Sample Trace:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. figure:: ../images/sample_trace.svg"},{"line_number":96,"context_line":"   :width: 660px"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a8ec9b2_dd45c4b3","line":93,"in_reply_to":"9a89bdaa_68a7dca6","updated":"2016-09-14 17:53:35.000000000","message":"Profiler is already enabled in keystone.\n\nIf profiler option is not set to enabled \u003d true in ironic.conf, you would still see a trace through keystone (for any baremetal calls).","commit_id":"bf9916a3dc8d3262c0a7de3f8aa414168ac58aa5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9cae0a1062c948e8bbb3567f007cf90bec6d8d7e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``info`` - the dictionary that contains user information passed when"},{"line_number":30,"context_line":"calling profiler start() \u0026 stop() methods."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The profiler uses Ceilometer as a centralized collector. Two other"},{"line_number":33,"context_line":"alternatives for Ceilometer are pure MongoDB driver and Elasticsearch."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"A notifier is setup to send notifications to Ceilometer using oslo.messaging"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_825aae28","line":32,"updated":"2017-01-27 22:14:52.000000000","message":"please lowercase ceilometer per http://docs.openstack.org/contributor-guide/writing-style/openstack-components.html","commit_id":"7a5c33606221c7448b1d06bd0c6b1886ff5c8aa9"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"8d6894c89fd19f68c61d37c7ef72af029313787c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``info`` - the dictionary that contains user information passed when"},{"line_number":30,"context_line":"calling profiler start() \u0026 stop() methods."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The profiler uses Ceilometer as a centralized collector. Two other"},{"line_number":33,"context_line":"alternatives for Ceilometer are pure MongoDB driver and Elasticsearch."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"A notifier is setup to send notifications to Ceilometer using oslo.messaging"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_905d947b","line":32,"in_reply_to":"3a461143_825aae28","updated":"2017-01-27 23:49:04.000000000","message":"Done","commit_id":"7a5c33606221c7448b1d06bd0c6b1886ff5c8aa9"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"0602d713cadb77dad209a4e7003cfc7dbc9c8a31","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    hmac_keys \u003d SECRET_KEY # default value used across several OpenStack projects"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Run stack.sh. In order to trace Ironic using OSProfiler, use openstackclient to run"},{"line_number":77,"context_line":"baremetal commands with"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    ``--os-profile SECRET_KEY``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a461143_1d028db4","line":76,"updated":"2017-01-29 16:32:21.000000000","message":"Do we need to do restack here? Restarting the ironic services won\u0027t help?","commit_id":"f1622f923e979174b4dc960a9fbefabfcccd935f"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"43532f483398b6414029e02584a36276354704b2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    hmac_keys \u003d SECRET_KEY # default value used across several OpenStack projects"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Run stack.sh. In order to trace Ironic using OSProfiler, use openstackclient to run"},{"line_number":77,"context_line":"baremetal commands with"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    ``--os-profile SECRET_KEY``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a461143_4fcd18b6","line":76,"in_reply_to":"3a461143_1d028db4","updated":"2017-01-30 21:07:33.000000000","message":"Done","commit_id":"f1622f923e979174b4dc960a9fbefabfcccd935f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"How OSProfiler works"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSProfiler API provides four different ways to add a new trace"},{"line_number":8,"context_line":"point. Trace points contain 2 messages (start and stop)."}],"source_content_type":"text/x-rst","patch_set":28,"id":"5ff73747_91821e00","line":5,"updated":"2017-05-02 22:11:38.000000000","message":"I was looking at the rendered pages. The index shows two entries for OSProfiler. I think it might be better with one entry. And I think you can do that by changing the level of the headings here. So eg\n\n- add a main heading (that will be shown on index page), eg \u0027OSProfiler\u0027 or \u0027Using OSProfiler with Ironic\u0027 or ??. It should have the \u003d\u003d\u003d\u003d lines above/below the text.\n- for this and the section below L45, remove the \u003d\u003d\u003d\u003d\u003d above the text, eg, delete L3 \u0026 L44.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"OSProfiler has entry point that allows the user to retrieve information"},{"line_number":39,"context_line":"about traces and present it in HTML/JSON using CLI."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"For more details see `OSProfiler – Cross-project profiling library`_."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"5ff73747_f4e1502c","line":40,"updated":"2017-05-02 22:11:38.000000000","message":"it would be useful to mention/add a section somewhere, that describes how to add more tracing to ironic -- with that tracing decorator, right? at L7, you mention that there are 4 different ways to add a trace point, but then nothing about what those 4 ways are?\n\nand maybe mention what is being traced right now. i think it is just the db API calls?","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    enable_plugin osprofiler https://git.openstack.org/openstack/osprofiler.git"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # Install Ceilometer"},{"line_number":58,"context_line":"    enable_plugin ceilometer https://git.openstack.org/openstack/ceilometer.git"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Enable the following services"},{"line_number":61,"context_line":"    CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"}],"source_content_type":"text/x-rst","patch_set":28,"id":"5ff73747_ae2ed5f7","line":58,"updated":"2017-05-02 22:11:38.000000000","message":"The commit msg also has panko plugin.\n\nThe commit msg mentions that the order of enabling plugins matter, and the order here is diff from the order in the commit msg.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"or"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    ``--profile SECRET_KEY # --profile option is deprecated``"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"For example, the following will cause a \u003ctrace-id\u003e to be printed after node list:"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"5ff73747_b1087ad9","line":85,"updated":"2017-05-02 22:11:38.000000000","message":"nit, probably shouldn\u0027t mention deprecated option.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4064ea84d93be2c91fc7be40d0ff861dca04105c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"About OSProfiler"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSProfiler is an OpenStack cross-project profiling library. Its API"},{"line_number":8,"context_line":"provides different ways to add a new trace point. Trace points contain"},{"line_number":9,"context_line":"two messages (start and stop). Messages like below are sent to a collector::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_3885125b","line":6,"updated":"2017-05-08 20:03:46.000000000","message":"Say I\u0027m an ironic developer and I want to add more tracepoints, since eg. this patch only adds tracepoints around the DB. How would I add more tracepoints?","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"5a6f4108a09a092f44f09496c827ac1903e557f0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"About OSProfiler"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSProfiler is an OpenStack cross-project profiling library. Its API"},{"line_number":8,"context_line":"provides different ways to add a new trace point. Trace points contain"},{"line_number":9,"context_line":"two messages (start and stop). Messages like below are sent to a collector::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_498b721e","line":6,"in_reply_to":"3f044301_3885125b","updated":"2017-05-09 01:28:58.000000000","message":"OSprofiler documentation has a section [1] for that. However, do we need to include it here? I don\u0027t think that we should, giving a reference is better.\n\n[1] https://docs.openstack.org/developer/osprofiler/api.html#five-ways-to-add-a-new-trace-point","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6c41014936621f43c432662923eb4877027ad50e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"About OSProfiler"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSProfiler is an OpenStack cross-project profiling library. Its API"},{"line_number":8,"context_line":"provides different ways to add a new trace point. Trace points contain"},{"line_number":9,"context_line":"two messages (start and stop). Messages like below are sent to a collector::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_dfccc9bd","line":6,"in_reply_to":"3f044301_498b721e","updated":"2017-05-09 13:21:29.000000000","message":"Maybe I misunderstood, but I thought you added a new decorator. It doesn\u0027t look like the same one that is documented in [1] and given that they have the same name, it is very confusing. Now I really think it needs to be documented.","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"e591d51e1364097f248e743075814407fb56a6f7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"About OSProfiler"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSProfiler is an OpenStack cross-project profiling library. Its API"},{"line_number":8,"context_line":"provides different ways to add a new trace point. Trace points contain"},{"line_number":9,"context_line":"two messages (start and stop). Messages like below are sent to a collector::"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_8fa7290c","line":6,"in_reply_to":"3f044301_dfccc9bd","updated":"2017-05-10 02:31:02.000000000","message":"I agree with you in some points.\nWe add profiler.trace_cls at profiler.py:47 to wrap osprofiler.profiler.trace_cls (there is a docstring for that).\nAnd, every other things are the same with [1].\nMaybe the only confusing things here are the name of module, function/method name in profiler.py.\n\nDo you think that we have to re-name them or document them (or docstring is enough)?","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4064ea84d93be2c91fc7be40d0ff861dca04105c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``info`` - the dictionary that contains user information passed when"},{"line_number":30,"context_line":"calling profiler start() \u0026 stop() methods."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The profiler uses Ceilometer as a centralized collector. Two other"},{"line_number":33,"context_line":"alternatives for Ceilometer are pure MongoDB driver and Elasticsearch."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"A notifier is setup to send notifications to Ceilometer using oslo.messaging"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_f809ea2b","line":32,"updated":"2017-05-08 20:03:46.000000000","message":"i believe we lowercase project names.","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"5a6f4108a09a092f44f09496c827ac1903e557f0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``info`` - the dictionary that contains user information passed when"},{"line_number":30,"context_line":"calling profiler start() \u0026 stop() methods."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The profiler uses Ceilometer as a centralized collector. Two other"},{"line_number":33,"context_line":"alternatives for Ceilometer are pure MongoDB driver and Elasticsearch."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"A notifier is setup to send notifications to Ceilometer using oslo.messaging"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_c97e6218","line":32,"in_reply_to":"3f044301_f809ea2b","updated":"2017-05-09 01:28:58.000000000","message":"Oh, I don\u0027t know that convention :D\nGot that!","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4064ea84d93be2c91fc7be40d0ff861dca04105c","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    enable_plugin panko https://git.openstack.org/openstack/panko"},{"line_number":54,"context_line":"    enable_plugin ceilometer https://git.openstack.org/openstack/ceilometer"},{"line_number":55,"context_line":"    enable_plugin osprofiler https://git.openstack.org/openstack/osprofiler"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # Enable the following services"},{"line_number":58,"context_line":"    CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_f8220aa4","line":55,"updated":"2017-05-08 20:03:46.000000000","message":"Does the order matter? The commit msg says it does.","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"5a6f4108a09a092f44f09496c827ac1903e557f0","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    enable_plugin panko https://git.openstack.org/openstack/panko"},{"line_number":54,"context_line":"    enable_plugin ceilometer https://git.openstack.org/openstack/ceilometer"},{"line_number":55,"context_line":"    enable_plugin osprofiler https://git.openstack.org/openstack/osprofiler"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # Enable the following services"},{"line_number":58,"context_line":"    CEILOMETER_NOTIFICATION_TOPICS\u003dnotifications,profiler"}],"source_content_type":"text/x-rst","patch_set":29,"id":"3f044301_89ca9a6a","line":55,"in_reply_to":"3f044301_f8220aa4","updated":"2017-05-09 01:28:58.000000000","message":"Yes, the order matters!\n\nhttps://github.com/openstack/osprofiler/commit/52f0df9428aa7a243a9266d1315878c0b4279a8e","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"}],"doc/source/index.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"542f9042aad358a19ef2a91eb0f49b4a07112a8e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  Ironic System Architecture \u003cdev/architecture\u003e"},{"line_number":78,"context_line":"  Provisioning State Machine \u003cdev/states\u003e"},{"line_number":79,"context_line":"  Developing New Notifications \u003cdev/notifications\u003e"},{"line_number":80,"context_line":"  OSProfiler Tracing \u003cdev/osprofiler-support\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"These pages contain information for PTLs, cross-project liaisons, and core"},{"line_number":83,"context_line":"reviewers."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba5201f7_634edac2","line":80,"updated":"2017-01-10 18:40:28.000000000","message":"This is specifically about OSProfiler tracing in devstack, this should be updated to reflect it\u0027s talking about devstack. Also, I think this is in the wrong area, as this isn\u0027t about \"the architecture of the bare metal service\". I\u0027d suggest it be linked from the dev/quickstart page.\n\nIs there a use case for osprofiler in a production environment? If so, we should consider adding install guide support.","commit_id":"bf3d64cc559649b91302fb15e2981d3cf38a7569"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"072cbef067af218ee741e97376f5c8f2f3507afe","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  Ironic System Architecture \u003cdev/architecture\u003e"},{"line_number":78,"context_line":"  Provisioning State Machine \u003cdev/states\u003e"},{"line_number":79,"context_line":"  Developing New Notifications \u003cdev/notifications\u003e"},{"line_number":80,"context_line":"  OSProfiler Tracing \u003cdev/osprofiler-support\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"These pages contain information for PTLs, cross-project liaisons, and core"},{"line_number":83,"context_line":"reviewers."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba5201f7_15d459bb","line":80,"in_reply_to":"ba5201f7_634edac2","updated":"2017-01-10 22:41:40.000000000","message":"Done","commit_id":"bf3d64cc559649b91302fb15e2981d3cf38a7569"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"0602d713cadb77dad209a4e7003cfc7dbc9c8a31","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  Releasing Ironic Projects \u003cdev/releasing\u003e"},{"line_number":88,"context_line":"  Ironic Governance Structure \u003cdev/governance\u003e"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Writing Drivers"},{"line_number":92,"context_line":"---------------"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a461143_5d2ed543","side":"PARENT","line":90,"updated":"2017-01-29 16:32:21.000000000","message":"Is this change intentional?","commit_id":"31d889a7c45c63664969c89878e88652697b7949"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"43532f483398b6414029e02584a36276354704b2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  Releasing Ironic Projects \u003cdev/releasing\u003e"},{"line_number":88,"context_line":"  Ironic Governance Structure \u003cdev/governance\u003e"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Writing Drivers"},{"line_number":92,"context_line":"---------------"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a461143_8fae20e4","side":"PARENT","line":90,"in_reply_to":"3a461143_5d2ed543","updated":"2017-01-30 21:07:33.000000000","message":"Yes. Previously, the doc was linked here; but, now it is linked in dev-quickstart.","commit_id":"31d889a7c45c63664969c89878e88652697b7949"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"b06c43b8ba67b79ec130dc8962061fe4941e853d","unresolved":false,"context_lines":[{"line_number":3146,"context_line":"# profiling. Also, to generate correct profiling information"},{"line_number":3147,"context_line":"# across all services"},{"line_number":3148,"context_line":"# at least one key needs to be consistent between OpenStack"},{"line_number":3149,"context_line":"# projects. This"},{"line_number":3150,"context_line":"# ensures it can be used from client side to generate the"},{"line_number":3151,"context_line":"# trace, containing"},{"line_number":3152,"context_line":"# information from all possible resources. (string value)"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba5201f7_f00b637b","line":3149,"updated":"2017-01-10 23:29:28.000000000","message":"line breaking in this section doesn\u0027t look very clear","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"d738fc8ed46536ca4d513d154b80e9e77a2f3f5b","unresolved":false,"context_lines":[{"line_number":3146,"context_line":"# profiling. Also, to generate correct profiling information"},{"line_number":3147,"context_line":"# across all services"},{"line_number":3148,"context_line":"# at least one key needs to be consistent between OpenStack"},{"line_number":3149,"context_line":"# projects. This"},{"line_number":3150,"context_line":"# ensures it can be used from client side to generate the"},{"line_number":3151,"context_line":"# trace, containing"},{"line_number":3152,"context_line":"# information from all possible resources. (string value)"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba5201f7_722f3b88","line":3149,"in_reply_to":"ba5201f7_f00b637b","updated":"2017-01-11 23:04:15.000000000","message":"This is generated by OSProfiler library, not this patch.","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":3268,"context_line":"# * True: Enables the feature"},{"line_number":3269,"context_line":"# * False: Disables the feature. The profiling cannot be"},{"line_number":3270,"context_line":"# started via this project"},{"line_number":3271,"context_line":"# operations. If the profiling is triggered by another"},{"line_number":3272,"context_line":"# project, this project part"},{"line_number":3273,"context_line":"# will be empty."},{"line_number":3274,"context_line":"#  (boolean value)"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"5ff73747_11abae75","line":3271,"updated":"2017-05-02 22:11:38.000000000","message":"too bad the formatting isn\u0027t great, but we can\u0027t do much about that.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"}],"ironic/cmd/api.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a7892c5ebaad1f876a8bc29af14549e75da11070","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.common import profiler as profile"},{"line_number":25,"context_line":"from ironic.common import service as ironic_service"},{"line_number":26,"context_line":"from ironic.objects import base"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_fce649e7","line":24,"updated":"2016-08-25 21:58:26.000000000","message":"curious why you didn\u0027t call it \u0027profiler\u0027; seems more consistent that way. And grammatically, it makes more sense too I think.","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.common import profiler as profile"},{"line_number":25,"context_line":"from ironic.common import service as ironic_service"},{"line_number":26,"context_line":"from ironic.objects import base"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_2b952286","line":24,"in_reply_to":"fa7ab95a_fce649e7","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"da9bf08f73cb0d4ed47b56fab65382f53b5c7e45","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.common import profiler as profiler"},{"line_number":25,"context_line":"from ironic.common import service as ironic_service"},{"line_number":26,"context_line":"from ironic.common import wsgi_service"},{"line_number":27,"context_line":"from ironic.objects import base"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_8a248960","line":24,"range":{"start_line":24,"start_character":34,"end_line":24,"end_character":46},"updated":"2016-12-15 07:31:06.000000000","message":"Redundant?","commit_id":"e9f3b5cd733b49fd6451b71d2a3744c761733b33"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"90699f442f93b59d85bd2c932ec41b0291317b0f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_config import cfg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ironic.common import profiler as profiler"},{"line_number":25,"context_line":"from ironic.common import service as ironic_service"},{"line_number":26,"context_line":"from ironic.common import wsgi_service"},{"line_number":27,"context_line":"from ironic.objects import base"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_ce166b4b","line":24,"range":{"start_line":24,"start_character":34,"end_line":24,"end_character":46},"in_reply_to":"1a6eadb0_8a248960","updated":"2016-12-15 22:26:35.000000000","message":"Done","commit_id":"e9f3b5cd733b49fd6451b71d2a3744c761733b33"}],"ironic/cmd/conductor.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5711a3743db0ec2206d59caae195e91db81d36f0","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    _check_auth_options(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    profiler.setup(\u0027rpc\u0027, CONF.host)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    launcher \u003d service.launch(CONF, mgr)"},{"line_number":74,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_da7662d6","line":71,"updated":"2016-09-15 21:45:11.000000000","message":"why do we call the api one, \u0027ironic-api\u0027, and this one \u0027rpc\u0027 instead of \u0027ironic-conductor\u0027?","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"017fb6785b31a9e114f42817fc5abd31048bb33c","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    _check_auth_options(CONF)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    profiler.setup(\u0027rpc\u0027, CONF.host)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    launcher \u003d service.launch(CONF, mgr)"},{"line_number":74,"context_line":"    launcher.wait()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_67cf5c56","line":71,"in_reply_to":"7a8ec9b2_da7662d6","updated":"2016-09-21 19:26:28.000000000","message":"Done","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"}],"ironic/common/profiler.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"cd904e17d4eeb594597df0d712c66d5992fc24db","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    if CONF.profiler.enabled:"},{"line_number":32,"context_line":"        _notifier \u003d profiler_notifier.create("},{"line_number":33,"context_line":"            \"Messaging\", oslo_messaging, {},"},{"line_number":34,"context_line":"            oslo_messaging.get_transport(CONF), \"ironic\", name, host)"},{"line_number":35,"context_line":"        profiler_notifier.set(_notifier)"},{"line_number":36,"context_line":"        profiler_web.enable(CONF.profiler.hmac_keys)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_871faa5a","line":33,"updated":"2016-08-24 19:41:38.000000000","message":"please use new OSprofiler API for this purpose with initializer being used","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":"    if CONF.profiler.enabled:"},{"line_number":32,"context_line":"        _notifier \u003d profiler_notifier.create("},{"line_number":33,"context_line":"            \"Messaging\", oslo_messaging, {},"},{"line_number":34,"context_line":"            oslo_messaging.get_transport(CONF), \"ironic\", name, host)"},{"line_number":35,"context_line":"        profiler_notifier.set(_notifier)"},{"line_number":36,"context_line":"        profiler_web.enable(CONF.profiler.hmac_keys)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_abef721c","line":33,"in_reply_to":"1ac06dbe_871faa5a","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5711a3743db0ec2206d59caae195e91db81d36f0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if CONF.profiler.enabled:"},{"line_number":30,"context_line":"        osprofiler.initializer.init_from_conf(conf\u003dCONF, context\u003d{},"},{"line_number":31,"context_line":"                                              project\u003d\"ironic\", service\u003dname,"},{"line_number":32,"context_line":"                                              host\u003dhost)"},{"line_number":33,"context_line":"        LOG.info(\"OSProfiler is enabled.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_bf5b45f5","line":30,"updated":"2016-09-15 21:45:11.000000000","message":"should we pass in the admin context? I see that cinder does [1]. They also emit a warning; wondering if we might want to do a similar thing. (I\u0027m not sure.)\n\n[1] https://github.com/openstack/cinder/blob/6e4333e9c1211389d0c7f0db6d8660f6e5c6a731/cinder/service.py#L99","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"017fb6785b31a9e114f42817fc5abd31048bb33c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if CONF.profiler.enabled:"},{"line_number":30,"context_line":"        osprofiler.initializer.init_from_conf(conf\u003dCONF, context\u003d{},"},{"line_number":31,"context_line":"                                              project\u003d\"ironic\", service\u003dname,"},{"line_number":32,"context_line":"                                              host\u003dhost)"},{"line_number":33,"context_line":"        LOG.info(\"OSProfiler is enabled.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_2700f465","line":30,"in_reply_to":"7a8ec9b2_bf5b45f5","updated":"2016-09-21 19:26:28.000000000","message":"Thanks. Passing admin context. Done.","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5711a3743db0ec2206d59caae195e91db81d36f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        osprofiler.initializer.init_from_conf(conf\u003dCONF, context\u003d{},"},{"line_number":31,"context_line":"                                              project\u003d\"ironic\", service\u003dname,"},{"line_number":32,"context_line":"                                              host\u003dhost)"},{"line_number":33,"context_line":"        LOG.info(\"OSProfiler is enabled.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_dc973f46","line":33,"updated":"2016-09-15 21:45:11.000000000","message":"you should use the _() macro for this string (for internationalization purposes): LOG.info(_LI(\"OSProfiler is enabled.\"))","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"017fb6785b31a9e114f42817fc5abd31048bb33c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        osprofiler.initializer.init_from_conf(conf\u003dCONF, context\u003d{},"},{"line_number":31,"context_line":"                                              project\u003d\"ironic\", service\u003dname,"},{"line_number":32,"context_line":"                                              host\u003dhost)"},{"line_number":33,"context_line":"        LOG.info(\"OSProfiler is enabled.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_c712f0b3","line":33,"in_reply_to":"7a8ec9b2_dc973f46","updated":"2016-09-21 19:26:28.000000000","message":"Done","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"542f9042aad358a19ef2a91eb0f49b4a07112a8e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                              project\u003d\"ironic\","},{"line_number":37,"context_line":"                                              service\u003dname,"},{"line_number":38,"context_line":"                                              host\u003dhost)"},{"line_number":39,"context_line":"        LOG.info(_LI(\"OSProfiler is enabled.\\nIt means that the person \""},{"line_number":40,"context_line":"                     \"who knows any of hmac_keys that are specified in \""},{"line_number":41,"context_line":"                     \"/etc/ironic/ironic.conf can trace his requests. \\n\""},{"line_number":42,"context_line":"                     \"In real life only operator can read this file, so there \""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_03eb4e79","line":39,"updated":"2017-01-10 18:40:28.000000000","message":"This is much, much too long for a log message. Can we summarize it better, especially since it defaults to off, most of this disclaimer can go in the configuration option description.","commit_id":"bf3d64cc559649b91302fb15e2981d3cf38a7569"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"072cbef067af218ee741e97376f5c8f2f3507afe","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                              project\u003d\"ironic\","},{"line_number":37,"context_line":"                                              service\u003dname,"},{"line_number":38,"context_line":"                                              host\u003dhost)"},{"line_number":39,"context_line":"        LOG.info(_LI(\"OSProfiler is enabled.\\nIt means that the person \""},{"line_number":40,"context_line":"                     \"who knows any of hmac_keys that are specified in \""},{"line_number":41,"context_line":"                     \"/etc/ironic/ironic.conf can trace his requests. \\n\""},{"line_number":42,"context_line":"                     \"In real life only operator can read this file, so there \""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_95e04998","line":39,"in_reply_to":"ba5201f7_03eb4e79","updated":"2017-01-10 22:41:40.000000000","message":"Done","commit_id":"bf3d64cc559649b91302fb15e2981d3cf38a7569"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"b06c43b8ba67b79ec130dc8962061fe4941e853d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param name: name of the service that will be profiled"},{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_10470778","line":29,"updated":"2017-01-10 23:29:28.000000000","message":"but more specified/but specifying","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"d738fc8ed46536ca4d513d154b80e9e77a2f3f5b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :param name: name of the service that will be profiled"},{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_52b79739","line":29,"in_reply_to":"ba5201f7_10470778","updated":"2017-01-11 23:04:15.000000000","message":"Will update in the next patch.","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"b06c43b8ba67b79ec130dc8962061fe4941e853d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :param name: name of the service that will be profiled"},{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"},{"line_number":33,"context_line":"        admin_context \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_305ecb45","line":30,"updated":"2017-01-10 23:29:28.000000000","message":"are there any exceptions raised?\nif not, maybe it\u0027s a good idea to check if profiler was initialized? It could be problematic that we don\u0027t detect if profiler was initialized properly when enabled","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"d738fc8ed46536ca4d513d154b80e9e77a2f3f5b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :param name: name of the service that will be profiled"},{"line_number":28,"context_line":"    :param host: hostname or host IP address that the service will be"},{"line_number":29,"context_line":"                 running on. By default host will be set to 0.0.0.0, but more"},{"line_number":30,"context_line":"                 specified host name / address usage is highly recommended."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    if CONF.profiler.enabled:"},{"line_number":33,"context_line":"        admin_context \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_72501bd5","line":30,"in_reply_to":"ba5201f7_305ecb45","updated":"2017-01-11 23:04:15.000000000","message":"Yes, exception raised in osprofiler.","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                   project\u003d\"ironic\","},{"line_number":41,"context_line":"                                   service\u003dname,"},{"line_number":42,"context_line":"                                   host\u003dhost)"},{"line_number":43,"context_line":"        LOG.info(_LI(\"OSProfiler is enabled. Trace is generated using \""},{"line_number":44,"context_line":"                     \"[profiler]/hmac_keys specified in ironic.conf. \""},{"line_number":45,"context_line":"                     \"To disable, set [profiler]/enabled\u003dfalse\"))"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_d49f7463","line":43,"updated":"2017-05-02 22:11:38.000000000","message":"if you feel like it, we aren\u0027t using _LI() any more.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\"Wrap the OSProfiler trace_cls decorator"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Wrap the OSProfiler trace_cls decorator so that it will not try to"},{"line_number":52,"context_line":"    patch the class unless OSProfiler is present and enabled in the config"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    :param name: The name of action. For example, wsgi, rpc, db, etc.."},{"line_number":55,"context_line":"    :param kwargs: Any other keyword args used by profiler.trace_cls"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_b1099a96","line":52,"updated":"2017-05-02 22:11:38.000000000","message":"nit, missing period at the end.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4064ea84d93be2c91fc7be40d0ff861dca04105c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\"Wrap the OSProfiler trace_cls decorator"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    Wrap the OSProfiler trace_cls decorator so that it will not try to"},{"line_number":51,"context_line":"    patch the class unless OSProfiler is present and enabled in the config"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    :param name: The name of action. For example, wsgi, rpc, db, etc.."},{"line_number":54,"context_line":"    :param kwargs: Any other keyword args used by profiler.trace_cls"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f044301_d873ceb0","line":51,"updated":"2017-05-08 20:03:46.000000000","message":"nit, missing period at the end.","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"5a6f4108a09a092f44f09496c827ac1903e557f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\"Wrap the OSProfiler trace_cls decorator"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    Wrap the OSProfiler trace_cls decorator so that it will not try to"},{"line_number":51,"context_line":"    patch the class unless OSProfiler is present and enabled in the config"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    :param name: The name of action. For example, wsgi, rpc, db, etc.."},{"line_number":54,"context_line":"    :param kwargs: Any other keyword args used by profiler.trace_cls"}],"source_content_type":"text/x-python","patch_set":29,"id":"3f044301_89785a2a","line":51,"in_reply_to":"3f044301_d873ceb0","updated":"2017-05-09 01:28:58.000000000","message":"+1","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d183a88d61206646a16d41dbd4ff7001a1f71ca7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                       a notifier backend, which is set in"},{"line_number":33,"context_line":"                       osprofiler.initializer.init_from_conf."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    if CONF.profiler.enabled:"},{"line_number":36,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":37,"context_line":"        initializer.init_from_conf(conf\u003dCONF,"},{"line_number":38,"context_line":"                                   context\u003dadmin_context.to_dict(),"}],"source_content_type":"text/x-python","patch_set":35,"id":"df3967d1_b21a7e7a","line":35,"updated":"2017-08-01 07:15:00.000000000","message":"nit:\n\n if not CONF.profiler.enabled:\n     return","commit_id":"3773f17403bb02b372673643780b9619151d22ea"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d183a88d61206646a16d41dbd4ff7001a1f71ca7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    :param kwargs: Any other keyword args used by profiler.trace_cls"},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"    def decorator(cls):"},{"line_number":57,"context_line":"        if profiler and \u0027profiler\u0027 in CONF and CONF.profiler.enabled:"},{"line_number":58,"context_line":"            trace_decorator \u003d profiler.trace_cls(name, kwargs)"},{"line_number":59,"context_line":"            return trace_decorator(cls)"},{"line_number":60,"context_line":"        return cls"}],"source_content_type":"text/x-python","patch_set":35,"id":"df3967d1_921d3a75","line":57,"updated":"2017-08-01 07:15:00.000000000","message":"I think most of this check is redundant. \"profiler\" module is import unconditionally, it cannot be None. and CONF.profiler is something we make sure gets added, and we rely on it in ironic.api.app. I\u0027d leave\n\n if CONF.profiler.enabled:","commit_id":"3773f17403bb02b372673643780b9619151d22ea"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5711a3743db0ec2206d59caae195e91db81d36f0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ironic.objects import base as objects_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@profiler.trace_cls(\"rpc\")"},{"line_number":35,"context_line":"class ConductorAPI(object):"},{"line_number":36,"context_line":"    \"\"\"Client side of the conductor RPC API."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_5fc96125","line":34,"updated":"2016-09-15 21:45:11.000000000","message":"I was wondering about this. (I\u0027m still trying to understand all this). Why would we want to trace this class? It is part of the ironic-api process. Aren\u0027t we interested in the time the ironic-conductor process takes?","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"017fb6785b31a9e114f42817fc5abd31048bb33c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ironic.objects import base as objects_base"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@profiler.trace_cls(\"rpc\")"},{"line_number":35,"context_line":"class ConductorAPI(object):"},{"line_number":36,"context_line":"    \"\"\"Client side of the conductor RPC API."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_275c747c","line":34,"in_reply_to":"7a8ec9b2_5fc96125","updated":"2016-09-21 19:26:28.000000000","message":"Yes. after passing admin context, conductor process is getting traced. Removed tracing here.","commit_id":"dd68464d758fd70300185fbf1570cc1f534c20e9"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"da9bf08f73cb0d4ed47b56fab65382f53b5c7e45","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    return query.all()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"@profiler.trace_cls(\"db api\")"},{"line_number":182,"context_line":"class Connection(api.Connection):"},{"line_number":183,"context_line":"    \"\"\"SqlAlchemy connection.\"\"\""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_ca0e813a","line":181,"range":{"start_line":181,"start_character":21,"end_line":181,"end_character":27},"updated":"2016-12-15 07:31:06.000000000","message":"db_api would be better :D","commit_id":"e9f3b5cd733b49fd6451b71d2a3744c761733b33"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"90699f442f93b59d85bd2c932ec41b0291317b0f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    return query.all()"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"@profiler.trace_cls(\"db api\")"},{"line_number":182,"context_line":"class Connection(api.Connection):"},{"line_number":183,"context_line":"    \"\"\"SqlAlchemy connection.\"\"\""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_4e297b89","line":181,"range":{"start_line":181,"start_character":21,"end_line":181,"end_character":27},"in_reply_to":"1a6eadb0_ca0e813a","updated":"2016-12-15 22:26:35.000000000","message":"Done","commit_id":"e9f3b5cd733b49fd6451b71d2a3744c761733b33"}],"ironic/tests/unit/common/test_profiler.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # Unfortunately, this leads to subtle failures of other test cases"},{"line_number":41,"context_line":"        # (e.g. super() is performed on a \"new\" version of a class instance"},{"line_number":42,"context_line":"        # created after a module reload while the class name is a reference to"},{"line_number":43,"context_line":"        # an \"old\" version of the class). Thus, this test is run in isolation."},{"line_number":44,"context_line":"        if not os.getenv(\u0027TEST_OSPROFILER\u0027, False):"},{"line_number":45,"context_line":"            self.skipTest(\u0027TEST_OSPROFILER env variable is not set. \u0027"},{"line_number":46,"context_line":"                          \u0027Skipping osprofiler tests...\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_9f9ea5b6","line":43,"updated":"2017-05-02 22:11:38.000000000","message":"don\u0027t we need/want this test to be run at the gate?","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                if isinstance(obj, staticmethod):"},{"line_number":70,"context_line":"                    continue"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"                self.assertTrue(getattr(obj, \u0027__traced__\u0027, False), obj)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @mock.patch.object(initializer, \u0027init_from_conf\u0027)"},{"line_number":75,"context_line":"    def test_setup_profiler(self, mock_init):"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_ffe4893e","line":72,"updated":"2017-05-02 22:11:38.000000000","message":"Now I\u0027m wondering whether we even need this test. Isn\u0027t it really testing OSProfiler code (osprofiler.profiler.trace_cls()? If so, I think we should be able to assume that it works, and that osprofiler has unit tests that test this :)","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"bb329f5b1af7fd2a22bb02ee61db56fbd6e93c52","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                if isinstance(obj, staticmethod):"},{"line_number":70,"context_line":"                    continue"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"                self.assertTrue(getattr(obj, \u0027__traced__\u0027, False), obj)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @mock.patch.object(initializer, \u0027init_from_conf\u0027)"},{"line_number":75,"context_line":"    def test_setup_profiler(self, mock_init):"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f044301_c9cc226c","line":72,"in_reply_to":"5ff73747_ffe4893e","updated":"2017-05-09 01:28:37.000000000","message":"Oh, I think that we should not put this test in ironic code.","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                                          host\u003d\u0027localhost\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @mock.patch.object(initializer, \u0027init_from_conf\u0027)"},{"line_number":87,"context_line":"    @mock.patch.object(conf, \u0027CONF\u0027, new\u003dcfg.ConfigOpts())"},{"line_number":88,"context_line":"    def test_setup_profiler_without_osprofiler(self, mock_init):"},{"line_number":89,"context_line":"        profiler.setup(\u0027foo\u0027, \u0027localhost\u0027)"},{"line_number":90,"context_line":"        self.assertFalse(mock_init.called)"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_7f5ab983","line":87,"updated":"2017-05-02 22:11:38.000000000","message":"is this needed?","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c00d813c79e122d623e10fcd1a14f01196351abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5ff73747_ff4da9c4","line":91,"updated":"2017-05-02 22:11:38.000000000","message":"wondering if we want a unit test for trace_cls().","commit_id":"6ff684e194c91520313985ceedef82642fc374cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"4064ea84d93be2c91fc7be40d0ff861dca04105c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"3f044301_986546e4","line":91,"updated":"2017-05-08 20:03:46.000000000","message":"I had comments in previous patch set that don\u0027t seem to have been addressed?","commit_id":"8d31142f46e5e41dbca0a8ba4eb9214837e60508"}],"releasenotes/notes/enable-osprofiler-support-e3839b0fa90d3831.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"542f9042aad358a19ef2a91eb0f49b4a07112a8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    provides the ability to trace various OpenStack requests through all"},{"line_number":6,"context_line":"    OpenStack services that support it. To initiate OpenStack request tracing,"},{"line_number":7,"context_line":"    `--profile \u003cHMAC_KEY\u003e` option needs to be added to the CLI command."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ba5201f7_03a26e4b","line":4,"updated":"2017-01-10 18:40:28.000000000","message":"Release notes should be written in present tense (i.e., Adds OSProfiler support vs Added OSProfiler support).","commit_id":"bf3d64cc559649b91302fb15e2981d3cf38a7569"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"072cbef067af218ee741e97376f5c8f2f3507afe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    OSprofiler support was added. This cross-project profiling library"},{"line_number":5,"context_line":"    provides the ability to trace various OpenStack requests through all"},{"line_number":6,"context_line":"    OpenStack services that support it. To initiate OpenStack request tracing,"},{"line_number":7,"context_line":"    `--profile \u003cHMAC_KEY\u003e` option needs to be added to the CLI command."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ba5201f7_d5f01169","line":4,"in_reply_to":"ba5201f7_03a26e4b","updated":"2017-01-10 22:41:40.000000000","message":"Done","commit_id":"bf3d64cc559649b91302fb15e2981d3cf38a7569"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"b06c43b8ba67b79ec130dc8962061fe4941e853d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds OSProfiler support. This cross-project profiling library"},{"line_number":5,"context_line":"    provides the ability to trace various OpenStack requests through all"},{"line_number":6,"context_line":"    OpenStack services that support it. To initiate OpenStack request tracing,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_1038e73c","line":3,"updated":"2017-01-10 23:29:28.000000000","message":"what is the reason for this line woth only one character?","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"d738fc8ed46536ca4d513d154b80e9e77a2f3f5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds OSProfiler support. This cross-project profiling library"},{"line_number":5,"context_line":"    provides the ability to trace various OpenStack requests through all"},{"line_number":6,"context_line":"    OpenStack services that support it. To initiate OpenStack request tracing,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ba5201f7_12226f52","line":3,"in_reply_to":"ba5201f7_1038e73c","updated":"2017-01-11 23:04:15.000000000","message":"This is to format the below text as a paragraph in the release note.","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"9d522dfa7bcf3db98a04a9c939fe40c64b1588ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds OSProfiler support. This cross-project profiling library"},{"line_number":5,"context_line":"    provides the ability to trace various OpenStack requests through all"},{"line_number":6,"context_line":"    OpenStack services that support it. To initiate OpenStack request tracing,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9a57fde8_f42ab7e6","line":3,"in_reply_to":"ba5201f7_12226f52","updated":"2017-01-12 17:55:09.000000000","message":"These are YAML files, and take all yams syntax. \"- |\" is the way you start a HEREDOC in YAML :)","commit_id":"871442cba7399f2b05dd63b3979f8de4acc225fd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d183a88d61206646a16d41dbd4ff7001a1f71ca7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    OpenStack services that support it. To initiate OpenStack request tracing,"},{"line_number":7,"context_line":"    `--profile \u003cHMAC_KEY\u003e` option needs to be added to the CLI command."},{"line_number":8,"context_line":"    As part of the output, there will be a message with \u003ctrace_id\u003e."},{"line_number":9,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":10,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`. See"},{"line_number":11,"context_line":"    OSProfiler documentation: http://docs.openstack.org/developer/osprofiler/."},{"line_number":12,"context_line":"security:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"df3967d1_7214164f","line":9,"updated":"2017-08-01 07:15:00.000000000","message":"please put the command on a separate line using literal syntax (::)","commit_id":"3773f17403bb02b372673643780b9619151d22ea"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d183a88d61206646a16d41dbd4ff7001a1f71ca7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    As part of the output, there will be a message with \u003ctrace_id\u003e."},{"line_number":9,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":10,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`. See"},{"line_number":11,"context_line":"    OSProfiler documentation: http://docs.openstack.org/developer/osprofiler/."},{"line_number":12,"context_line":"security:"},{"line_number":13,"context_line":"  - OSProfiler support requires passing of trace information between"},{"line_number":14,"context_line":"    various OpenStack services. This information is securely signed"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"df3967d1_5217d252","line":11,"updated":"2017-08-01 07:15:00.000000000","message":"+1, but it redirects correctly, so it\u0027s fine for a follow-up","commit_id":"3773f17403bb02b372673643780b9619151d22ea"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"98d14e2883e3ca1c898ec4d7e7a3978cba1a5100","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    As part of the output, there will be a message with \u003ctrace_id\u003e."},{"line_number":9,"context_line":"    To see the HTML graphs, the following command should be used -"},{"line_number":10,"context_line":"    `$ osprofiler trace show \u003ctrace_id\u003e --html --out result.html`. See"},{"line_number":11,"context_line":"    OSProfiler documentation: http://docs.openstack.org/developer/osprofiler/."},{"line_number":12,"context_line":"security:"},{"line_number":13,"context_line":"  - OSProfiler support requires passing of trace information between"},{"line_number":14,"context_line":"    various OpenStack services. This information is securely signed"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"df3967d1_1514a24d","line":11,"updated":"2017-07-31 20:05:39.000000000","message":"this link needs to be updated","commit_id":"3773f17403bb02b372673643780b9619151d22ea"}],"requirements.txt":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"cd904e17d4eeb594597df0d712c66d5992fc24db","unresolved":false,"context_lines":[{"line_number":31,"context_line":"oslo.serialization\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.service\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.utils\u003e\u003d3.16.0 # Apache-2.0"},{"line_number":34,"context_line":"osprofiler\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":35,"context_line":"pecan\u003e\u003d1.0.0 # BSD"},{"line_number":36,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":2,"id":"1ac06dbe_876deace","line":34,"updated":"2016-08-24 19:41:38.000000000","message":"please use the latest version: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L119","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"a49e320a0cafdc64dbafeb61f9193228c441de0f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"oslo.serialization\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.service\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.utils\u003e\u003d3.16.0 # Apache-2.0"},{"line_number":34,"context_line":"osprofiler\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":35,"context_line":"pecan\u003e\u003d1.0.0 # BSD"},{"line_number":36,"context_line":"requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":37,"context_line":"six\u003e\u003d1.9.0 # MIT"}],"source_content_type":"text/plain","patch_set":2,"id":"fa7ab95a_cbf03600","line":34,"in_reply_to":"1ac06dbe_876deace","updated":"2016-08-29 20:12:00.000000000","message":"Done","commit_id":"c1d269d974e3d95208f23467f10822f91b763428"}]}
