)]}'
{"ironic/drivers/modules/ssh.py":[{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"0b6b6fe9199598ed4fe7108e59fac73c37838852","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            \"SSHPowerDriver requires one of ssh_password, \""},{"line_number":399,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    # Set only credential file or contant but not both"},{"line_number":402,"context_line":"    if key_filename and key_contents:"},{"line_number":403,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":404,"context_line":"            \"SSHPowerDriver requires one and only one of \""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_b776b603","line":401,"range":{"start_line":401,"start_character":34,"end_line":401,"end_character":41},"updated":"2016-10-03 20:08:03.000000000","message":"I think is \"content\" here right?","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"3e5243afc5273c74fbb6343a6da180612da03bce","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            \"SSHPowerDriver requires one of ssh_password, \""},{"line_number":399,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    # Set only credential file or contant but not both"},{"line_number":402,"context_line":"    if key_filename and key_contents:"},{"line_number":403,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":404,"context_line":"            \"SSHPowerDriver requires one and only one of \""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_90a60452","line":401,"range":{"start_line":401,"start_character":34,"end_line":401,"end_character":41},"in_reply_to":"3a98d1f4_b776b603","updated":"2016-10-04 12:57:05.000000000","message":"thanks!","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b2002dcb084564e732fea74bca9aaeb1a926256a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \"for authentication. One of this, ssh_key_contents, \""},{"line_number":65,"context_line":"                          \"or ssh_password must be specified.\"),"},{"line_number":66,"context_line":"    \u0027ssh_password\u0027: _(\"password to use for authentication or for unlocking a \""},{"line_number":67,"context_line":"                      \"private key. One of this, ssh_key_contents, or \""},{"line_number":68,"context_line":"                      \"ssh_key_filename must be specified.\"),"},{"line_number":69,"context_line":"    \u0027ssh_port\u0027: _(\"port on the node to connect to; default is 22. Optional.\"),"},{"line_number":70,"context_line":"    \u0027vbox_use_headless\u0027: _(\"True or False (Default). Optional. \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_18f6738f","line":67,"updated":"2016-10-11 19:51:15.000000000","message":"Are the above descriptions sufficient, or should they be updated?","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"06f3bea34747b730c03683ea530617f8f4c44094","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \"for authentication. One of this, ssh_key_contents, \""},{"line_number":65,"context_line":"                          \"or ssh_password must be specified.\"),"},{"line_number":66,"context_line":"    \u0027ssh_password\u0027: _(\"password to use for authentication or for unlocking a \""},{"line_number":67,"context_line":"                      \"private key. One of this, ssh_key_contents, or \""},{"line_number":68,"context_line":"                      \"ssh_key_filename must be specified.\"),"},{"line_number":69,"context_line":"    \u0027ssh_port\u0027: _(\"port on the node to connect to; default is 22. Optional.\"),"},{"line_number":70,"context_line":"    \u0027vbox_use_headless\u0027: _(\"True or False (Default). Optional. \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_c0b72ed6","line":67,"in_reply_to":"fa6399be_168fc9cc","updated":"2016-10-13 22:22:41.000000000","message":"I like your suggestion. And a similar thing for \u0027ssh_key_filename\u0027 ?","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9bd9f8cb673917e70b25d7540e5f9435bbceb902","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \"for authentication. One of this, ssh_key_contents, \""},{"line_number":65,"context_line":"                          \"or ssh_password must be specified.\"),"},{"line_number":66,"context_line":"    \u0027ssh_password\u0027: _(\"password to use for authentication or for unlocking a \""},{"line_number":67,"context_line":"                      \"private key. One of this, ssh_key_contents, or \""},{"line_number":68,"context_line":"                      \"ssh_key_filename must be specified.\"),"},{"line_number":69,"context_line":"    \u0027ssh_port\u0027: _(\"port on the node to connect to; default is 22. Optional.\"),"},{"line_number":70,"context_line":"    \u0027vbox_use_headless\u0027: _(\"True or False (Default). Optional. \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_168fc9cc","line":67,"in_reply_to":"fa6399be_18f6738f","updated":"2016-10-13 14:22:50.000000000","message":"For the record, we\u0027re talking about five possible scenarios:\n* password\n* key_filename\n* key_contents\n* key_filename + password\n* key_contents + password\n\nI think these descriptions are quite accurate for each parameter but there is room for improvement. We could point in this direction:\n\n\u0027ssh_key_contents\u0027: _(\"private key(s). If ssh_password is also specified it will be used for unlocking the private key. Do not specify ssh_key_filename when this property is specified.\")\n\nWhat do you think?","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"7026fa3c270bcdff8e8e6bdcc6b174892bb559eb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \"for authentication. One of this, ssh_key_contents, \""},{"line_number":65,"context_line":"                          \"or ssh_password must be specified.\"),"},{"line_number":66,"context_line":"    \u0027ssh_password\u0027: _(\"password to use for authentication or for unlocking a \""},{"line_number":67,"context_line":"                      \"private key. One of this, ssh_key_contents, or \""},{"line_number":68,"context_line":"                      \"ssh_key_filename must be specified.\"),"},{"line_number":69,"context_line":"    \u0027ssh_port\u0027: _(\"port on the node to connect to; default is 22. Optional.\"),"},{"line_number":70,"context_line":"    \u0027vbox_use_headless\u0027: _(\"True or False (Default). Optional. \""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_92401409","line":67,"in_reply_to":"fa6399be_c0b72ed6","updated":"2016-10-14 12:45:46.000000000","message":"Done","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b2002dcb084564e732fea74bca9aaeb1a926256a","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    # Set at least one credential method."},{"line_number":396,"context_line":"    if len([v for v in (password, key_filename, key_contents) if v]) \u003d\u003d 0:"},{"line_number":397,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":398,"context_line":"            \"SSHPowerDriver requires one of ssh_password, \""},{"line_number":399,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    # Set only credential file or content but not both"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_183d932b","line":398,"updated":"2016-10-11 19:51:15.000000000","message":"not sure if we want to s/one/at least one/","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9bd9f8cb673917e70b25d7540e5f9435bbceb902","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    # Set at least one credential method."},{"line_number":396,"context_line":"    if len([v for v in (password, key_filename, key_contents) if v]) \u003d\u003d 0:"},{"line_number":397,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":398,"context_line":"            \"SSHPowerDriver requires one of ssh_password, \""},{"line_number":399,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    # Set only credential file or content but not both"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_78d7134b","line":398,"in_reply_to":"fa6399be_183d932b","updated":"2016-10-13 14:22:50.000000000","message":"The bug exists because only one was being allowed. My intention here was to make clear that at least one must be set...","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"7026fa3c270bcdff8e8e6bdcc6b174892bb559eb","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    # Set at least one credential method."},{"line_number":396,"context_line":"    if len([v for v in (password, key_filename, key_contents) if v]) \u003d\u003d 0:"},{"line_number":397,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":398,"context_line":"            \"SSHPowerDriver requires one of ssh_password, \""},{"line_number":399,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    # Set only credential file or content but not both"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_326748b8","line":398,"in_reply_to":"fa6399be_20854a06","updated":"2016-10-14 12:45:46.000000000","message":"I got it! \u0027at least one\u0027 seems better to me...","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"06f3bea34747b730c03683ea530617f8f4c44094","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    # Set at least one credential method."},{"line_number":396,"context_line":"    if len([v for v in (password, key_filename, key_contents) if v]) \u003d\u003d 0:"},{"line_number":397,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":398,"context_line":"            \"SSHPowerDriver requires one of ssh_password, \""},{"line_number":399,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    # Set only credential file or content but not both"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_20854a06","line":398,"in_reply_to":"fa6399be_78d7134b","updated":"2016-10-13 22:22:41.000000000","message":"right, which is why I suggested s/one/at least one/.\n\nIf it is just \u0027one\u0027, it isn\u0027t clear whether it is exactly one or at least one.","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"365a4d588480e2276cee2303e17efe37f3491b52","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    res[\u0027cmd_set\u0027] \u003d cmd_set"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    # Set at least one credential method."},{"line_number":400,"context_line":"    if len([v for v in (password, key_filename, key_contents) if v]) \u003d\u003d 0:"},{"line_number":401,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":402,"context_line":"            \"SSHPowerDriver requires at least one of ssh_password, \""},{"line_number":403,"context_line":"            \"ssh_key_contents and ssh_key_filename to be set.\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa6399be_1f4bcbb1","line":400,"updated":"2016-10-18 08:57:02.000000000","message":"if not any([password, key_filename, key_contents]):","commit_id":"50c7fdc45c2de132013887fbdb7b906a8ec746fd"}],"ironic/tests/unit/drivers/modules/test_ssh.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"050930b9551f986b65ad9cfff6a9dd2eae9fdc37","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test__parse_driver_info_too_many(self):"},{"line_number":149,"context_line":"        d_info \u003d db_utils.get_test_ssh_info(\u0027too_many\u0027)"},{"line_number":150,"context_line":"        tempdir \u003d tempfile.mkdtemp()"},{"line_number":151,"context_line":"        key_path \u003d tempdir + \u0027/foo\u0027"},{"line_number":152,"context_line":"        open(key_path, \u0027wt\u0027).close()"},{"line_number":153,"context_line":"        d_info[\u0027ssh_key_filename\u0027] \u003d key_path"},{"line_number":154,"context_line":"        node \u003d obj_utils.get_test_node("},{"line_number":155,"context_line":"            self.context,"},{"line_number":156,"context_line":"            driver\u003d\u0027fake_ssh\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_4eea4375","line":153,"range":{"start_line":150,"start_character":8,"end_line":153,"end_character":45},"updated":"2016-10-03 18:29:10.000000000","message":"Is not needed to create any file here.","commit_id":"2d3a0a7b28e49fcaeca3931af51b2729aaa86521"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c04403f2f2ac26ee5b151b5f4d83a33a334cee3f","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test__parse_driver_info_too_many(self):"},{"line_number":149,"context_line":"        d_info \u003d db_utils.get_test_ssh_info(\u0027too_many\u0027)"},{"line_number":150,"context_line":"        tempdir \u003d tempfile.mkdtemp()"},{"line_number":151,"context_line":"        key_path \u003d tempdir + \u0027/foo\u0027"},{"line_number":152,"context_line":"        open(key_path, \u0027wt\u0027).close()"},{"line_number":153,"context_line":"        d_info[\u0027ssh_key_filename\u0027] \u003d key_path"},{"line_number":154,"context_line":"        node \u003d obj_utils.get_test_node("},{"line_number":155,"context_line":"            self.context,"},{"line_number":156,"context_line":"            driver\u003d\u0027fake_ssh\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_f1df6e0a","line":153,"range":{"start_line":150,"start_character":8,"end_line":153,"end_character":45},"in_reply_to":"3a98d1f4_4eea4375","updated":"2016-10-03 18:55:43.000000000","message":"oh that\u0027s a great point!\n\nLet\u0027s keep the filesystem clean","commit_id":"2d3a0a7b28e49fcaeca3931af51b2729aaa86521"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"6127cdf5488802971aa0f38e438bbe6ecc1ebcdf","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test__parse_driver_info_too_many(self):"},{"line_number":149,"context_line":"        d_info \u003d db_utils.get_test_ssh_info(\u0027too_many\u0027)"},{"line_number":150,"context_line":"        tempdir \u003d tempfile.mkdtemp()"},{"line_number":151,"context_line":"        key_path \u003d tempdir + \u0027/foo\u0027"},{"line_number":152,"context_line":"        open(key_path, \u0027wt\u0027).close()"},{"line_number":153,"context_line":"        d_info[\u0027ssh_key_filename\u0027] \u003d key_path"},{"line_number":154,"context_line":"        node \u003d obj_utils.get_test_node("},{"line_number":155,"context_line":"            self.context,"},{"line_number":156,"context_line":"            driver\u003d\u0027fake_ssh\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_b7acf68c","line":153,"range":{"start_line":150,"start_character":8,"end_line":153,"end_character":45},"in_reply_to":"3a98d1f4_f1df6e0a","updated":"2016-10-03 19:57:13.000000000","message":"got it!","commit_id":"2d3a0a7b28e49fcaeca3931af51b2729aaa86521"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"0b6b6fe9199598ed4fe7108e59fac73c37838852","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":97,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test__parse_driver_info_good_file_with_passphrase(self):"},{"line_number":100,"context_line":"        # make sure we get back the expected things"},{"line_number":101,"context_line":"        d_info \u003d db_utils.get_test_ssh_info(\u0027file_with_passphrase\u0027)"},{"line_number":102,"context_line":"        tempdir \u003d tempfile.mkdtemp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_37e706ad","line":99,"range":{"start_line":99,"start_character":32,"end_line":99,"end_character":36},"updated":"2016-10-03 20:08:03.000000000","message":"Maybe \"valid\" instead would be better.","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"3e5243afc5273c74fbb6343a6da180612da03bce","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":97,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test__parse_driver_info_good_file_with_passphrase(self):"},{"line_number":100,"context_line":"        # make sure we get back the expected things"},{"line_number":101,"context_line":"        d_info \u003d db_utils.get_test_ssh_info(\u0027file_with_passphrase\u0027)"},{"line_number":102,"context_line":"        tempdir \u003d tempfile.mkdtemp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_6b48adcd","line":99,"range":{"start_line":99,"start_character":32,"end_line":99,"end_character":36},"in_reply_to":"3a98d1f4_37e706ad","updated":"2016-10-04 12:57:05.000000000","message":"I agree \"good\" cannot be good, I just stuck to the pattern... there are another 11 test cases with \"good\" on the name (and 4 with \"bad\"), should I evaluate each of them or is it out of scope for this change?","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"43f00931b2801afb4f077a006c7f9ce09baff389","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":97,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test__parse_driver_info_good_file_with_passphrase(self):"},{"line_number":100,"context_line":"        # make sure we get back the expected things"},{"line_number":101,"context_line":"        d_info \u003d db_utils.get_test_ssh_info(\u0027file_with_passphrase\u0027)"},{"line_number":102,"context_line":"        tempdir \u003d tempfile.mkdtemp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_816f8c91","line":99,"range":{"start_line":99,"start_character":32,"end_line":99,"end_character":36},"in_reply_to":"3a98d1f4_6b48adcd","updated":"2016-10-04 20:04:10.000000000","message":"Actually Ricardo, it is not a good idea to change things out of the scope of your commit, so maybe it\u0027s for the best if you keep this way. But it is still strange for me, some words would be much more clear and meaningful than \"good\".","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"0b6b6fe9199598ed4fe7108e59fac73c37838852","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":119,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test__parse_driver_info_good_key_with_passphrase(self):"},{"line_number":122,"context_line":"        # make sure we get back the expected things"},{"line_number":123,"context_line":"        node \u003d obj_utils.get_test_node("},{"line_number":124,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_77050e44","line":121,"range":{"start_line":121,"start_character":32,"end_line":121,"end_character":36},"updated":"2016-10-03 20:08:03.000000000","message":"ditto","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"b2002dcb084564e732fea74bca9aaeb1a926256a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(\u0027virsh\u0027, info[\u0027virt_type\u0027])"},{"line_number":134,"context_line":"        self.assertIsNotNone(info[\u0027cmd_set\u0027])"},{"line_number":135,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":136,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test__parse_driver_info_bad_file(self):"},{"line_number":139,"context_line":"        # A filename that doesn\u0027t exist errors."}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_33f358a0","line":136,"updated":"2016-10-11 19:51:15.000000000","message":"makes me wonder if we should have a helper function instead of so much copy/paste, but i suppose we can leave that for a different patch.","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"7026fa3c270bcdff8e8e6bdcc6b174892bb559eb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(\u0027virsh\u0027, info[\u0027virt_type\u0027])"},{"line_number":134,"context_line":"        self.assertIsNotNone(info[\u0027cmd_set\u0027])"},{"line_number":135,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":136,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test__parse_driver_info_bad_file(self):"},{"line_number":139,"context_line":"        # A filename that doesn\u0027t exist errors."}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_9225745d","line":136,"in_reply_to":"fa6399be_2001ca6a","updated":"2016-10-14 12:45:46.000000000","message":"ok, I\u0027ll leave it as is...","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9bd9f8cb673917e70b25d7540e5f9435bbceb902","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(\u0027virsh\u0027, info[\u0027virt_type\u0027])"},{"line_number":134,"context_line":"        self.assertIsNotNone(info[\u0027cmd_set\u0027])"},{"line_number":135,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":136,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test__parse_driver_info_bad_file(self):"},{"line_number":139,"context_line":"        # A filename that doesn\u0027t exist errors."}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_3b5e7512","line":136,"in_reply_to":"fa6399be_33f358a0","updated":"2016-10-13 14:22:50.000000000","message":"What about a \u0027_check_driver_info(self, info)\u0027? :D","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"06f3bea34747b730c03683ea530617f8f4c44094","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertEqual(\u0027virsh\u0027, info[\u0027virt_type\u0027])"},{"line_number":134,"context_line":"        self.assertIsNotNone(info[\u0027cmd_set\u0027])"},{"line_number":135,"context_line":"        self.assertEqual(\u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027,"},{"line_number":136,"context_line":"                         info[\u0027uuid\u0027])"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def test__parse_driver_info_bad_file(self):"},{"line_number":139,"context_line":"        # A filename that doesn\u0027t exist errors."}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_2001ca6a","line":136,"in_reply_to":"fa6399be_3b5e7512","updated":"2016-10-13 22:22:41.000000000","message":"I suppose you could do that, and have it return info, to do additional checks. Or leave it as is and see if anyone else comments on it. I mean, I\u0027m fine with what you have, I was just thinking...","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"}],"releasenotes/notes/bug-1607527-75885e145db62d69.yaml":[{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"0b6b6fe9199598ed4fe7108e59fac73c37838852","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when one tried to configure the"},{"line_number":4,"context_line":"    ssh power drive using a private key protected by a"},{"line_number":5,"context_line":"    passphrase."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_57a1f244","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":39},"updated":"2016-10-03 20:08:03.000000000","message":"In this case maybe \"Tries\" is better.","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"0b6b6fe9199598ed4fe7108e59fac73c37838852","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when one tried to configure the"},{"line_number":4,"context_line":"    ssh power drive using a private key protected by a"},{"line_number":5,"context_line":"    passphrase."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_f7975ee9","line":3,"range":{"start_line":3,"start_character":30,"end_line":3,"end_character":33},"updated":"2016-10-03 20:08:03.000000000","message":"Who? The user?","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"3e5243afc5273c74fbb6343a6da180612da03bce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when one tried to configure the"},{"line_number":4,"context_line":"    ssh power drive using a private key protected by a"},{"line_number":5,"context_line":"    passphrase."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_4b221103","line":3,"range":{"start_line":3,"start_character":30,"end_line":3,"end_character":33},"in_reply_to":"3a98d1f4_f7975ee9","updated":"2016-10-04 12:57:05.000000000","message":"got it!","commit_id":"6325244e7eff351eba0b951f9c375231d8b73abe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"06f3bea34747b730c03683ea530617f8f4c44094","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when the user tries to configure"},{"line_number":4,"context_line":"    the ssh power drive using a private key protected by"},{"line_number":5,"context_line":"    a passphrase."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_a044fab6","line":3,"updated":"2016-10-13 22:22:41.000000000","message":"we don\u0027t tend to mention bug numbers, but I think it is fine. Although the single quotes aren\u0027t needed?","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"7026fa3c270bcdff8e8e6bdcc6b174892bb559eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when the user tries to configure"},{"line_number":4,"context_line":"    the ssh power drive using a private key protected by"},{"line_number":5,"context_line":"    a passphrase."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_b2ad189d","line":3,"in_reply_to":"fa6399be_a044fab6","updated":"2016-10-14 12:45:46.000000000","message":"I updated it... would you mind checking it again?","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7ed673f939fa86c48eb44486cda20e4648685531","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when the user tries to configure"},{"line_number":4,"context_line":"    the ssh power drive using a private key protected by"},{"line_number":5,"context_line":"    a passphrase."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a95cdbc_376b3a20","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":23},"updated":"2016-10-05 12:28:38.000000000","message":"nit - driver","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"9bd9f8cb673917e70b25d7540e5f9435bbceb902","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes bug \u0027#1607527\u0027 when the user tries to configure"},{"line_number":4,"context_line":"    the ssh power drive using a private key protected by"},{"line_number":5,"context_line":"    a passphrase."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_fbaebde4","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":23},"in_reply_to":"1a95cdbc_376b3a20","updated":"2016-10-13 14:22:50.000000000","message":"updating in the next patch set, thanks!","commit_id":"cdd5375c3b6583fbb71dcc07c1abddfd05b2434e"}]}
