)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1cbebe45d0496b08b5fae1caa5700572d8f368c0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add volume_connectors and volume_targets to task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding volume_connectors and volume_targets to the task object"},{"line_number":10,"context_line":"to allow for match the existing model leveraged by ports and"},{"line_number":11,"context_line":"portgroups which allows for simplified storage_interface use."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iea1af5b939ba9374feef56ce22ae718eb6c7a672"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa6399be_d8ad749c","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":18},"updated":"2016-10-20 17:56:17.000000000","message":"nit: s/match/matching","commit_id":"b65deb8c47af542d48001bc86e854c5e43b215e7"}],"ironic/tests/unit/conductor/test_task_manager.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"ef98eb8c21c10e42c33d8468144f927257e82770","unresolved":false,"context_lines":[{"line_number":41,"context_line":"@mock.patch.object(objects.Port, \u0027list_by_node_id\u0027)"},{"line_number":42,"context_line":"@mock.patch.object(objects.Portgroup, \u0027list_by_node_id\u0027)"},{"line_number":43,"context_line":"@mock.patch.object(objects.VolumeConnector, \u0027list_by_node_id\u0027)"},{"line_number":44,"context_line":"@mock.patch.object(objects.VolumeTarget, \u0027list_by_node_id\u0027)"},{"line_number":45,"context_line":"class TaskManagerTestCase(tests_db_base.DbTestCase):"},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TaskManagerTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_bec09251","line":44,"updated":"2016-12-05 21:02:26.000000000","message":"super nit: I\u0027d prefer new mocks to be prepended, not appended (to keep existing arguments order in methods)","commit_id":"f11d3deff55ebb6bfd5a9d0db3257302bf7826f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"63113220499a76f893a2b7ad85afb0e0c46d1faf","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        reserve_mock.assert_called_once_with(self.context, self.host,"},{"line_number":231,"context_line":"                                             \u0027fake-node-id\u0027)"},{"line_number":232,"context_line":"        get_ports_mock.assert_called_once_with(self.context, self.node.id)"},{"line_number":233,"context_line":"        self.assertFalse(build_driver_mock.called)"},{"line_number":234,"context_line":"        release_mock.assert_called_once_with(self.context, self.host,"},{"line_number":235,"context_line":"                                             self.node.id)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_4f85f957","line":233,"range":{"start_line":233,"start_character":8,"end_line":233,"end_character":50},"updated":"2016-12-06 09:26:19.000000000","message":"Need to add:\nself.assertFalse(get_volconn_mock.called)\nself.assertFalse(get_voltgt_mock.called)","commit_id":"f11d3deff55ebb6bfd5a9d0db3257302bf7826f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"63113220499a76f893a2b7ad85afb0e0c46d1faf","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        reserve_mock.assert_called_once_with(self.context, self.host,"},{"line_number":251,"context_line":"                                             \u0027fake-node-id\u0027)"},{"line_number":252,"context_line":"        get_portgroups_mock.assert_called_once_with(self.context, self.node.id)"},{"line_number":253,"context_line":"        self.assertFalse(build_driver_mock.called)"},{"line_number":254,"context_line":"        release_mock.assert_called_once_with(self.context, self.host,"},{"line_number":255,"context_line":"                                             self.node.id)"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_cfc74994","line":253,"range":{"start_line":253,"start_character":8,"end_line":253,"end_character":50},"updated":"2016-12-06 09:26:19.000000000","message":"Need to add:\nself.assertFalse(get_volconn_mock.called)\nself.assertFalse(get_voltgt_mock.called)","commit_id":"f11d3deff55ebb6bfd5a9d0db3257302bf7826f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"63113220499a76f893a2b7ad85afb0e0c46d1faf","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        reserve_mock.assert_called_once_with(self.context, self.host,"},{"line_number":270,"context_line":"                                             \u0027fake-node-id\u0027)"},{"line_number":271,"context_line":"        get_volconn_mock.assert_called_once_with(self.context, self.node.id)"},{"line_number":272,"context_line":"        self.assertFalse(get_voltgt_mock.called)"},{"line_number":273,"context_line":"        release_mock.assert_called_once_with(self.context, self.host,"},{"line_number":274,"context_line":"                                             self.node.id)"},{"line_number":275,"context_line":"        node_get_mock.assert_called_once_with(self.context, \u0027fake-node-id\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_8f0e31e3","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":48},"updated":"2016-12-06 09:26:19.000000000","message":"Need to add self.assertFalse() for Port and Portgroup calls as well.","commit_id":"f11d3deff55ebb6bfd5a9d0db3257302bf7826f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"63113220499a76f893a2b7ad85afb0e0c46d1faf","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        reserve_mock.assert_called_once_with(self.context, self.host,"},{"line_number":290,"context_line":"                                             \u0027fake-node-id\u0027)"},{"line_number":291,"context_line":"        get_voltgt_mock.assert_called_once_with(self.context, self.node.id)"},{"line_number":292,"context_line":"        self.assertFalse(build_driver_mock.called)"},{"line_number":293,"context_line":"        release_mock.assert_called_once_with(self.context, self.host,"},{"line_number":294,"context_line":"                                             self.node.id)"},{"line_number":295,"context_line":"        node_get_mock.assert_called_once_with(self.context, \u0027fake-node-id\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_0fadc187","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":50},"updated":"2016-12-06 09:26:19.000000000","message":"Need to add self.assertFalse() for Port and Portgroup calls as well.\nAlso need to add get_volconn_mock.assert_called_once_with()","commit_id":"f11d3deff55ebb6bfd5a9d0db3257302bf7826f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"63113220499a76f893a2b7ad85afb0e0c46d1faf","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        reserve_mock.assert_called_once_with(self.context, self.host,"},{"line_number":312,"context_line":"                                             \u0027fake-node-id\u0027)"},{"line_number":313,"context_line":"        get_ports_mock.assert_called_once_with(self.context, self.node.id)"},{"line_number":314,"context_line":"        get_portgroups_mock.assert_called_once_with(self.context, self.node.id)"},{"line_number":315,"context_line":"        build_driver_mock.assert_called_once_with(mock.ANY, driver_name\u003dNone)"},{"line_number":316,"context_line":"        release_mock.assert_called_once_with(self.context, self.host,"},{"line_number":317,"context_line":"                                             self.node.id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a71b18c_2fec3df2","line":314,"range":{"start_line":314,"start_character":8,"end_line":314,"end_character":51},"updated":"2016-12-06 09:26:19.000000000","message":"Need to add \nget_voltgt_mock.assert_called_once_with()\nget_volconn_mock.assert_called_once_with()","commit_id":"f11d3deff55ebb6bfd5a9d0db3257302bf7826f1"}]}