)]}'
{"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b33054f6f61dd32eb1f658ec131951a63ff43445","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            cpus \u003d client.list_cpus()"},{"line_number":80,"context_line":"            if cpus:"},{"line_number":81,"context_line":"                properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":82,"context_line":"                properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            virtual_disks \u003d client.list_virtual_disks()"},{"line_number":85,"context_line":"            root_disk \u003d self._guess_root_disk(virtual_disks)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_73ad369a","line":82,"updated":"2016-09-08 08:49:32.000000000","message":"Can we add a unittest with cpus\u003d0 just to make sure we are going fail later ? (L100)","commit_id":"fb379c71bd4b840171248826587e7f0e7a4133f0"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"af0d2194be831d3d7a2be44c599d68fd35eca75b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            cpus \u003d client.list_cpus()"},{"line_number":80,"context_line":"            if cpus:"},{"line_number":81,"context_line":"                properties[\u0027cpus\u0027] \u003d len(cpus)"},{"line_number":82,"context_line":"                properties[\u0027cpu_arch\u0027] \u003d \u0027x86_64\u0027 if cpus[0].arch64 else \u0027x86\u0027"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            virtual_disks \u003d client.list_virtual_disks()"},{"line_number":85,"context_line":"            root_disk \u003d self._guess_root_disk(virtual_disks)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_6d1ae0c7","line":82,"in_reply_to":"9a89bdaa_73ad369a","updated":"2016-09-13 09:21:19.000000000","message":"Done","commit_id":"fb379c71bd4b840171248826587e7f0e7a4133f0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b33054f6f61dd32eb1f658ec131951a63ff43445","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        disks.sort(key\u003dlambda disk: disk.size_mb)"},{"line_number":146,"context_line":"        for disk in disks:"},{"line_number":147,"context_line":"            if disk.size_mb \u003e\u003d min_size_required_mb:"},{"line_number":148,"context_line":"                return disk"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_93a63aac","line":148,"updated":"2016-09-08 08:49:32.000000000","message":"The fact that we changed this parameter and tests didn\u0027t fail, means that this method is not being tested as a unit. It should :-)","commit_id":"fb379c71bd4b840171248826587e7f0e7a4133f0"},{"author":{"_account_id":7419,"name":"Imre Farkas","email":"farkas.imre@gmail.com","username":"ifarkas"},"change_message_id":"af0d2194be831d3d7a2be44c599d68fd35eca75b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        disks.sort(key\u003dlambda disk: disk.size_mb)"},{"line_number":146,"context_line":"        for disk in disks:"},{"line_number":147,"context_line":"            if disk.size_mb \u003e\u003d min_size_required_mb:"},{"line_number":148,"context_line":"                return disk"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_6ddf40d6","line":148,"in_reply_to":"9a89bdaa_93a63aac","updated":"2016-09-13 09:21:19.000000000","message":"This method was tested via inspect_hardware, that\u0027s why it didn\u0027t fail.\n\nI will add a separate one just for this method.","commit_id":"fb379c71bd4b840171248826587e7f0e7a4133f0"}]}