)]}'
{"ironic/api/controllers/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0567de564ab5e281259f487db807d2ea98760bb5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                setattr(self, k, wsme.Unset)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"@functools.total_ordering"},{"line_number":55,"context_line":"class Version(object):"},{"line_number":56,"context_line":"    \"\"\"API Version object.\"\"\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_d220294c","line":54,"updated":"2016-09-12 09:03:56.000000000","message":"because of this we should not have added __ne__..","commit_id":"aeaf273c07cf7dffbe2e6879ca247d0af557cd52"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5637f5fd76472290f4ad67bf6500176d0298c4be","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                setattr(self, k, wsme.Unset)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"@functools.total_ordering"},{"line_number":55,"context_line":"class Version(object):"},{"line_number":56,"context_line":"    \"\"\"API Version object.\"\"\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_cff94d50","line":54,"in_reply_to":"9a89bdaa_93ddb172","updated":"2016-09-12 14:36:02.000000000","message":"Yeah, it\u0027s strange","commit_id":"aeaf273c07cf7dffbe2e6879ca247d0af557cd52"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c6c2e8358993edc9b00b5ed4a6e8ee0840123495","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                setattr(self, k, wsme.Unset)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"@functools.total_ordering"},{"line_number":55,"context_line":"class Version(object):"},{"line_number":56,"context_line":"    \"\"\"API Version object.\"\"\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_93ddb172","line":54,"in_reply_to":"9a89bdaa_b821b2fe","updated":"2016-09-12 14:13:17.000000000","message":"I had even -1 the original __ne__() patch https://review.openstack.org/#/c/365491/ but then did additional testing and discovered the total_ordering doesn\u0027t add __ne__. Surprised me!","commit_id":"aeaf273c07cf7dffbe2e6879ca247d0af557cd52"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"4023bfdd88021ce91e299f4f814b96fe5ab559f6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                setattr(self, k, wsme.Unset)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"@functools.total_ordering"},{"line_number":55,"context_line":"class Version(object):"},{"line_number":56,"context_line":"    \"\"\"API Version object.\"\"\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_b821b2fe","line":54,"in_reply_to":"9a89bdaa_d220294c","updated":"2016-09-12 14:05:07.000000000","message":"That is what I thought. But functools ordering does not do __ne__ :(\n\nhttps://github.com/python/cpython/blob/ff5e32d12eafd8de5ea89dc23a7e400cf0e8cd39/Lib/functools.py#L178-L204\n\nRemoving the __ne__() function will cause the unit test to fail and not just the \u0027hasattr\u0027 check.","commit_id":"aeaf273c07cf7dffbe2e6879ca247d0af557cd52"}]}