)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"57ee334015ef589ecdcdb449a3549af288244e5b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"   for internal usage, exclude them from Neutron."},{"line_number":16,"context_line":" * Add IRONIC_PROVISION_SUBNET_SUBNODE_IP variable, by default is 10.0.5.2."},{"line_number":17,"context_line":"   The IP address from provisioning network that is assigned to subnode."},{"line_number":18,"context_line":" * Set MTU on VM_BRIDGE to 100"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Related-Bug: #1622653"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a98d1f4_8ad445ec","line":18,"range":{"start_line":18,"start_character":26,"end_line":18,"end_character":30},"updated":"2016-10-03 14:11:30.000000000","message":"Vasyl, in patch i see MTU 1400:\n$OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID mtu 1400","commit_id":"7cba60a1f7ceaa81135825535f2a1e6364f5d2e5"}],"devstack/lib/ironic":[{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"5fb5a22b5ec06bd48f666b5461cd2194b5af210a","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":578,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":579,"context_line":"            sudo ip addr add dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $ironic_provision_network_ip/$provision_net_prefix"},{"line_number":580,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID mtu 1450"},{"line_number":581,"context_line":"        else"},{"line_number":582,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE up"},{"line_number":583,"context_line":"            sudo ip addr add dev $OVS_PHYSICAL_BRIDGE $ironic_provision_network_ip/$provision_net_prefix"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_cebf98fa","line":580,"range":{"start_line":580,"start_character":92,"end_line":580,"end_character":96},"updated":"2016-09-12 12:36:06.000000000","message":"Should MTU be equal to 1400 like in this patch? \nhttps://review.openstack.org/#/c/368645/","commit_id":"0fc0254bf99d09f3fca4667eb610cfff0fa06992"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"11d9211163d7d9e0a7ec64174b2b2c5053d765c8","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            sudo vconfig add $OVS_PHYSICAL_BRIDGE $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":578,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":579,"context_line":"            sudo ip addr add dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $ironic_provision_network_ip/$provision_net_prefix"},{"line_number":580,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID mtu 1450"},{"line_number":581,"context_line":"        else"},{"line_number":582,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE up"},{"line_number":583,"context_line":"            sudo ip addr add dev $OVS_PHYSICAL_BRIDGE $ironic_provision_network_ip/$provision_net_prefix"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a89bdaa_6523debd","line":580,"range":{"start_line":580,"start_character":92,"end_line":580,"end_character":96},"in_reply_to":"9a89bdaa_cebf98fa","updated":"2016-09-13 07:31:48.000000000","message":"yes, it should be 1400.","commit_id":"0fc0254bf99d09f3fca4667eb610cfff0fa06992"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"f70d80e686c9f96a804e02445dd6f3a67f630728","unresolved":false,"context_lines":[{"line_number":308,"context_line":"# IRONIC_PROVISION_SUBNET_GATEWAY - is configured on primary node."},{"line_number":309,"context_line":"# Ironic provision subnet gateway."},{"line_number":310,"context_line":"IRONIC_PROVISION_SUBNET_GATEWAY\u003d${IRONIC_PROVISION_SUBNET_GATEWAY:-\u002710.0.5.1\u0027}"},{"line_number":311,"context_line":"IRONIC_PROVISION_SUBNET_SUBNODE_IP\u003d${IRONIC_PROVISION_SUBNET_SUBNODE_IP:-\u002710.0.5.2\u0027}"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"# Ironic provision subnet prefix"},{"line_number":314,"context_line":"# Example: IRONIC_PROVISION_SUBNET_PREFIX\u003d10.0.5.0/24"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9a629dbe_c9f9b34f","line":311,"range":{"start_line":311,"start_character":0,"end_line":311,"end_character":34},"updated":"2016-11-07 14:28:59.000000000","message":"Why do we need to configure subnode ip and not just picking it up from pool?","commit_id":"3a0c516abf26de6d8ebcf45e6891731a0cb0b22b"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"f70d80e686c9f96a804e02445dd6f3a67f630728","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        ironic_provision_network_ip\u003d$IRONIC_PROVISION_SUBNET_SUBNODE_IP"},{"line_number":595,"context_line":"    fi"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        IRONIC_PROVISION_SEGMENTATION_ID\u003d${IRONIC_PROVISION_SEGMENTATION_ID:-`openstack network show ${net_id} -f value -c provider:segmentation_id`}"},{"line_number":598,"context_line":"        provision_net_prefix\u003d${IRONIC_PROVISION_SUBNET_PREFIX##*/}"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        # Set provision network GW on physical interface"},{"line_number":601,"context_line":"        # Add vlan on br interface in case of IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\u003d\u003dvlan"},{"line_number":602,"context_line":"        # othervise assign ip to br interface directly."},{"line_number":603,"context_line":"        if [[ \"$IRONIC_PROVISION_PROVIDER_NETWORK_TYPE\" \u003d\u003d \"vlan\" ]]; then"},{"line_number":604,"context_line":"            sudo ip link add link $OVS_PHYSICAL_BRIDGE name $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID type vlan id $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":605,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":606,"context_line":"            sudo ip addr add dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $ironic_provision_network_ip/$provision_net_prefix"},{"line_number":607,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID mtu 1400"},{"line_number":608,"context_line":"        else"},{"line_number":609,"context_line":"            sudo ip link set dev $OVS_PHYSICAL_BRIDGE up"},{"line_number":610,"context_line":"            sudo ip addr add dev $OVS_PHYSICAL_BRIDGE $ironic_provision_network_ip/$provision_net_prefix"},{"line_number":611,"context_line":"        fi"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    iniset $IRONIC_CONF_FILE neutron provisioning_network_uuid $net_id"},{"line_number":614,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9a629dbe_656fed92","line":611,"range":{"start_line":597,"start_character":0,"end_line":611,"end_character":10},"updated":"2016-11-07 14:28:59.000000000","message":"looks like wrong indentation","commit_id":"3a0c516abf26de6d8ebcf45e6891731a0cb0b22b"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"e0d15afa1b6e0c90d885e6c6f79787ce8cd9b012","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"        if [[ -n \"${IRONIC_NETWORK_INTERFACE}\" ]]; then"},{"line_number":1224,"context_line":"            local n_id"},{"line_number":1225,"context_line":"            ironic node-set-maintenance $node_id true"},{"line_number":1226,"context_line":"            n_id\u003d$(ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_INTERFACE | grep \" uuid \" | awk \u0027{ print $4; }\u0027)"},{"line_number":1227,"context_line":"            die_if_not_set $LINENO n_id \"Failed to update network interface for node\""},{"line_number":1228,"context_line":"            ironic node-set-maintenance $node_id false"},{"line_number":1229,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9a629dbe_93130666","line":1226,"range":{"start_line":1226,"start_character":117,"end_line":1226,"end_character":152},"updated":"2016-11-09 10:54:52.000000000","message":"Can we use awk \u0027/uuid/ { print $4}\u0027","commit_id":"3a0c516abf26de6d8ebcf45e6891731a0cb0b22b"},{"author":{"_account_id":15784,"name":"Igor Pukha","email":"ipukha@mirantis.com","username":"ingwarr"},"change_message_id":"67710ba6afa5e31b2f479a941024d3736fada8c0","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"        if [[ -n \"${IRONIC_NETWORK_INTERFACE}\" ]]; then"},{"line_number":1224,"context_line":"            local n_id"},{"line_number":1225,"context_line":"            ironic node-set-maintenance $node_id true"},{"line_number":1226,"context_line":"            n_id\u003d$(ironic $ironic_api_version node-update $node_id add network_interface\u003d$IRONIC_NETWORK_INTERFACE | grep \" uuid \" | awk \u0027{ print $4; }\u0027)"},{"line_number":1227,"context_line":"            die_if_not_set $LINENO n_id \"Failed to update network interface for node\""},{"line_number":1228,"context_line":"            ironic node-set-maintenance $node_id false"},{"line_number":1229,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9a629dbe_1cee23ec","line":1226,"range":{"start_line":1226,"start_character":117,"end_line":1226,"end_character":152},"in_reply_to":"9a629dbe_93130666","updated":"2016-11-09 11:44:54.000000000","message":"yep it will be a little bit faster","commit_id":"3a0c516abf26de6d8ebcf45e6891731a0cb0b22b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ca095e1027b26ff64f84aceba9b4bb7375a8f1fb","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        sudo ip link add link $OVS_PHYSICAL_BRIDGE name $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID type vlan id $IRONIC_PROVISION_SEGMENTATION_ID"},{"line_number":605,"context_line":"        sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID up"},{"line_number":606,"context_line":"        sudo ip addr add dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID $ironic_provision_network_ip/$provision_net_prefix"},{"line_number":607,"context_line":"        sudo ip link set dev $OVS_PHYSICAL_BRIDGE.$IRONIC_PROVISION_SEGMENTATION_ID mtu 1400"},{"line_number":608,"context_line":"    else"},{"line_number":609,"context_line":"        sudo ip link set dev $OVS_PHYSICAL_BRIDGE up"},{"line_number":610,"context_line":"        sudo ip addr add dev $OVS_PHYSICAL_BRIDGE $ironic_provision_network_ip/$provision_net_prefix"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a629dbe_b4726b0f","line":607,"updated":"2016-11-10 16:18:12.000000000","message":"nit: would be a good thing to just have a comment about setting the mtu to 1400.\n\nI\u0027ve wondered why myself and asked the author on IRC:\n\n\u003clucasagomes\u003e vsaienk0, why the mtu has to be 1400 for the vm bridge ? /me remembers we had to set mtu to 1450 for the public bridge awhile ago\n\u003cvsaienk0\u003e lucasagomes, because on multinode job we need to take into account additional 50 bytes for vxlan header","commit_id":"f5713a91e8260144a13f9563d8d95d88f69018ae"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e5c669df2e2eadea8cff0c894d6753334bb07881","unresolved":false,"context_lines":[{"line_number":303,"context_line":"# Ironic provision subnet name."},{"line_number":304,"context_line":"IRONIC_PROVISION_PROVIDER_SUBNET_NAME\u003d${IRONIC_PROVISION_PROVIDER_SUBNET_NAME:-${IRONIC_PROVISION_NETWORK_NAME}-subnet}"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"# With multinode case all ironic-conductors should have IP from provisioning network."},{"line_number":308,"context_line":"# IRONIC_PROVISION_SUBNET_GATEWAY - is configured on primary node."},{"line_number":309,"context_line":"# Ironic provision subnet gateway."}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9a629dbe_51f47486","line":306,"updated":"2016-11-13 22:36:46.000000000","message":"super nit - redundant empty line","commit_id":"485259c808896c6a068f8e48168acdf8af4b9c22"}],"devstack/plugin.sh":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e5c669df2e2eadea8cff0c894d6753334bb07881","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                create_bridge_and_vms"},{"line_number":43,"context_line":"            fi"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            if is_service_enabled neutron || [[ \"$HOST_TOPOLOGY\" \u003d\u003d \"multinode\" ]]; then"},{"line_number":46,"context_line":"                echo_summary \"Configuring Ironic networks\""},{"line_number":47,"context_line":"                configure_ironic_networks"},{"line_number":48,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"9a629dbe_91ee0cb3","line":45,"updated":"2016-11-13 22:36:46.000000000","message":"We could also use $HOST_TOPOLOGY_ROLE \u003d\u003d subnode here right? Would be a bit more clear.","commit_id":"485259c808896c6a068f8e48168acdf8af4b9c22"}]}