)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"807cf0aa0f3ad1500b3e576da0d8c401781b6165","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update ironic node names for multinode case"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ironic node name is unique. This patch updates _ironic_bm_names()"},{"line_number":10,"context_line":"function to generate uniq name for primary and subnodes."},{"line_number":11,"context_line":"On primary node node name is node-{id}."},{"line_number":12,"context_line":"On subnode node name is subnode-{id}. Where {id} is the node"},{"line_number":13,"context_line":"number from 0 to $IRONIC_VM_COUNT"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a629dbe_d974a169","line":10,"updated":"2016-11-09 21:45:17.000000000","message":"s/uniq/unique","commit_id":"9675640da2a349c88b688bf7d0704ffaa6a51319"}],"devstack/lib/ironic":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e210fa721de591cdf861079871fc6cf3d6483e13","unresolved":false,"context_lines":[{"line_number":858,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":859,"context_line":"        node_prefix\u003d\"node\""},{"line_number":860,"context_line":"    else"},{"line_number":861,"context_line":"        node_prefix\u003d\"sub-node\""},{"line_number":862,"context_line":"    fi"},{"line_number":863,"context_line":"    num_vms\u003d$(($IRONIC_VM_COUNT - 1))"},{"line_number":864,"context_line":"    for idx in $(seq 0 $num_vms); do"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"fa6399be_01787af1","line":861,"updated":"2016-10-19 21:23:39.000000000","message":"maybe this is a nit, but it might be better as s/sub-node/subnode/. at the very least, that is the same string as $HOST_TOPOLOGY_ROLE. (What other value does $HOST_TOPOLOGY_ROLE have, maybe you can use that value as the prefix.\n\nAlso, using \u0027sub-node\u0027 means that the final name will have \u0027sub-node-something\u0027 so it has two hyphens, if you do it as \u0027subnode-something\u0027 it is clearer what the prefix might be, i know it isn\u0027t a big deal.","commit_id":"0d46ba6ea260fa3a3f1d536279a9f1c4e8673de4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"57b34a44a0e64b8a33b18b2195cdc1f266be4de9","unresolved":false,"context_lines":[{"line_number":858,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":859,"context_line":"        node_prefix\u003d\"node\""},{"line_number":860,"context_line":"    else"},{"line_number":861,"context_line":"        node_prefix\u003d\"sub-node\""},{"line_number":862,"context_line":"    fi"},{"line_number":863,"context_line":"    num_vms\u003d$(($IRONIC_VM_COUNT - 1))"},{"line_number":864,"context_line":"    for idx in $(seq 0 $num_vms); do"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a629dbe_0707a6ca","line":861,"in_reply_to":"fa6399be_01787af1","updated":"2016-11-09 15:24:20.000000000","message":"Done","commit_id":"0d46ba6ea260fa3a3f1d536279a9f1c4e8673de4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a91d9b9a082c33797a318471e9e2f99f0764287f","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"    chassis_id\u003d$(ironic chassis-create -d \"ironic test chassis\" | grep \" uuid \" | get_field 2)"},{"line_number":1045,"context_line":"    die_if_not_set $LINENO chassis_id \"Failed to create chassis\""},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    local node_prefix\u003d\"node\""},{"line_number":1048,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027subnode\u0027 ]]; then"},{"line_number":1049,"context_line":"        node_prefix\u003d\"sub-$node_prefix\""},{"line_number":1050,"context_line":"    fi"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"    if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":1053,"context_line":"        local ironic_node_cpu\u003d$IRONIC_VM_SPECS_CPU"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"fa6399be_b38128fe","line":1050,"range":{"start_line":1047,"start_character":4,"end_line":1050,"end_character":6},"updated":"2016-10-18 15:21:58.000000000","message":"nit - these two pieces are doing the same thing but written differently.","commit_id":"0d46ba6ea260fa3a3f1d536279a9f1c4e8673de4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"57b34a44a0e64b8a33b18b2195cdc1f266be4de9","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"    chassis_id\u003d$(ironic chassis-create -d \"ironic test chassis\" | grep \" uuid \" | get_field 2)"},{"line_number":1045,"context_line":"    die_if_not_set $LINENO chassis_id \"Failed to create chassis\""},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    local node_prefix\u003d\"node\""},{"line_number":1048,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027subnode\u0027 ]]; then"},{"line_number":1049,"context_line":"        node_prefix\u003d\"sub-$node_prefix\""},{"line_number":1050,"context_line":"    fi"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"    if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":1053,"context_line":"        local ironic_node_cpu\u003d$IRONIC_VM_SPECS_CPU"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"9a629dbe_270caaec","line":1050,"range":{"start_line":1047,"start_character":4,"end_line":1050,"end_character":6},"in_reply_to":"fa6399be_41c7d211","updated":"2016-11-09 15:24:20.000000000","message":"Done","commit_id":"0d46ba6ea260fa3a3f1d536279a9f1c4e8673de4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"e210fa721de591cdf861079871fc6cf3d6483e13","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"    chassis_id\u003d$(ironic chassis-create -d \"ironic test chassis\" | grep \" uuid \" | get_field 2)"},{"line_number":1045,"context_line":"    die_if_not_set $LINENO chassis_id \"Failed to create chassis\""},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    local node_prefix\u003d\"node\""},{"line_number":1048,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027subnode\u0027 ]]; then"},{"line_number":1049,"context_line":"        node_prefix\u003d\"sub-$node_prefix\""},{"line_number":1050,"context_line":"    fi"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"    if [[ \"$IRONIC_IS_HARDWARE\" \u003d\u003d \"False\" ]]; then"},{"line_number":1053,"context_line":"        local ironic_node_cpu\u003d$IRONIC_VM_SPECS_CPU"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"fa6399be_41c7d211","line":1050,"range":{"start_line":1047,"start_character":4,"end_line":1050,"end_character":6},"in_reply_to":"fa6399be_b38128fe","updated":"2016-10-19 21:23:39.000000000","message":"yeah, even though the code is small, might be better to create a helper function for it. Instead of copying or ummm (which might be worse) having two diff ways of generating it.","commit_id":"0d46ba6ea260fa3a3f1d536279a9f1c4e8673de4"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"4fc9f374538f369431c477eadabd415da7179e66","unresolved":false,"context_lines":[{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"function get_ironic_node_prefix {"},{"line_number":1569,"context_line":"    local node_prefix\u003d\"node\""},{"line_number":1570,"context_line":"    if [[ -n \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]];"},{"line_number":1571,"context_line":"        node_prefix\u003d\"$HOST_TOPOLOGY_ROLE\""},{"line_number":1572,"context_line":"    fi"},{"line_number":1573,"context_line":"    echo $node_prefix"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a629dbe_5c24095f","line":1570,"range":{"start_line":1570,"start_character":48,"end_line":1570,"end_character":51},"updated":"2016-11-09 17:53:06.000000000","message":"Missing \u0027then\u0027","commit_id":"2005cd9157f391db1889c5089146de00240a51b7"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"1570f9136a98f312938e096c2499bafbdbdc5ba5","unresolved":false,"context_lines":[{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"function get_ironic_node_prefix {"},{"line_number":1569,"context_line":"    local node_prefix\u003d\"node\""},{"line_number":1570,"context_line":"    if [[ -n \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]];"},{"line_number":1571,"context_line":"        node_prefix\u003d\"$HOST_TOPOLOGY_ROLE\""},{"line_number":1572,"context_line":"    fi"},{"line_number":1573,"context_line":"    echo $node_prefix"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a629dbe_d040fd36","line":1570,"range":{"start_line":1570,"start_character":48,"end_line":1570,"end_character":51},"in_reply_to":"9a629dbe_5c24095f","updated":"2016-11-09 18:10:12.000000000","message":"Also, what is the purpose of the -n? I would think you just need to check for equivalency (it\u0027s also causing a syntax error in a little test script I wrote)","commit_id":"2005cd9157f391db1889c5089146de00240a51b7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bf1bcc01f268c1c0fa4ad0a0e6c0e3b61c5a249a","unresolved":false,"context_lines":[{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"function get_ironic_node_prefix {"},{"line_number":1569,"context_line":"    local node_prefix\u003d\"node\""},{"line_number":1570,"context_line":"    if [[ -n \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]];"},{"line_number":1571,"context_line":"        node_prefix\u003d\"$HOST_TOPOLOGY_ROLE\""},{"line_number":1572,"context_line":"    fi"},{"line_number":1573,"context_line":"    echo $node_prefix"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"9a629dbe_a45b4bf5","line":1570,"range":{"start_line":1570,"start_character":48,"end_line":1570,"end_character":51},"in_reply_to":"9a629dbe_d040fd36","updated":"2016-11-09 19:47:48.000000000","message":"Done","commit_id":"2005cd9157f391db1889c5089146de00240a51b7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f966f89c4800a674c94aa67ea4207a7b3dc32b46","unresolved":false,"context_lines":[{"line_number":1570,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]]; then"},{"line_number":1571,"context_line":"        node_prefix\u003d\"$HOST_TOPOLOGY_ROLE\""},{"line_number":1572,"context_line":"    fi"},{"line_number":1573,"context_line":"    echo $node_prefix"},{"line_number":1574,"context_line":"}"},{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"# Restore xtrace + pipefail"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9a629dbe_b746ed4c","line":1573,"updated":"2016-11-10 16:25:47.000000000","message":"(nothing to do here)\n\nNot sure if an one-liner would be simpler but, just in case it would look like:\n\nfunction get_ironic_node_prefix {\n    [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027subnode\u0027 ]] \u0026\u0026 echo \"subnode\" || echo \"node\"\n}","commit_id":"9675640da2a349c88b688bf7d0704ffaa6a51319"}]}
