)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e1201723342f78182b351776eba342cde2a5f7f7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Increase the verbosity of devstack/lib/ironic by enabling xtrace for"},{"line_number":10,"context_line":"when sourcing devstack/lib/ironic. This information is useful to be able"},{"line_number":11,"context_line":"to see what variables are set to along with other information.  This"},{"line_number":12,"context_line":"will increase the devstack log size by about 1%."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also print which stage the ironic devstack plugin is being called for."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3a71b18c_2eeca68e","line":12,"range":{"start_line":12,"start_character":45,"end_line":12,"end_character":47},"updated":"2016-12-02 16:21:31.000000000","message":"Actually, comparing devstack.log sizes, it seems like this number is around 6, not 1.","commit_id":"a788fd72b49f6ff435e6aa9e230b47e8404b8a47"}],"devstack/lib/ironic":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2b7e1e205210f9e3892f84746b4ca70d41eb8f83","unresolved":false,"context_lines":[{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"set +o pipefail"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DEVSTACK_LIB_IRONIC_SRC\u003d$(( $DEVSTACK_LIB_IRONIC_SRC + 1 ))"},{"line_number":40,"context_line":"echo \"Sourcing $BASH_SOURCE Sourcing count: $DEVSTACK_LIB_IRONIC_SRC\""},{"line_number":41,"context_line":"echo \"xtrace is ${XTRACE_IRONIC_STATUS}\""},{"line_number":42,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a95cdbc_8a472e76","line":39,"updated":"2016-10-06 21:57:46.000000000","message":"nit: this seems like a strange name for something that is a number.\n\nDo you need the DEVSTACK_LIB part? Maybe COUNT_IRONIC_SOURCED?","commit_id":"9f08e53987ca607ba76c2e5d998521ae3de6f5a9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7acd1938eacec2330cae8cb21201ec402f7af2c4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":"set +o pipefail"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DEVSTACK_LIB_IRONIC_SRC\u003d$(( $DEVSTACK_LIB_IRONIC_SRC + 1 ))"},{"line_number":40,"context_line":"echo \"Sourcing $BASH_SOURCE Sourcing count: $DEVSTACK_LIB_IRONIC_SRC\""},{"line_number":41,"context_line":"echo \"xtrace is ${XTRACE_IRONIC_STATUS}\""},{"line_number":42,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a95cdbc_a801526c","line":39,"in_reply_to":"1a95cdbc_8a472e76","updated":"2016-10-06 22:37:35.000000000","message":"I was using \"DEVSTACK_LIB\" to help make sure it wouldn\u0027t conflict with anyone else. Since this variable will end up in the overall devstack namespace.\n\nIt isn\u0027t local to this file.","commit_id":"9f08e53987ca607ba76c2e5d998521ae3de6f5a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2b7e1e205210f9e3892f84746b4ca70d41eb8f83","unresolved":false,"context_lines":[{"line_number":1495,"context_line":"    fi"},{"line_number":1496,"context_line":"}"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"echo \"Finished sourcing $BASH_SOURCE Sourcing count: $DEVSTACK_LIB_IRONIC_SRC\""},{"line_number":1499,"context_line":"echo \"Restoring xtrace to previous state\""},{"line_number":1500,"context_line":"# Restore xtrace + pipefail"},{"line_number":1501,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a95cdbc_8a5d6e7b","line":1498,"updated":"2016-10-06 21:57:46.000000000","message":"Do we want a period after $BASH_SOURCE?","commit_id":"9f08e53987ca607ba76c2e5d998521ae3de6f5a9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7acd1938eacec2330cae8cb21201ec402f7af2c4","unresolved":false,"context_lines":[{"line_number":1495,"context_line":"    fi"},{"line_number":1496,"context_line":"}"},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"echo \"Finished sourcing $BASH_SOURCE Sourcing count: $DEVSTACK_LIB_IRONIC_SRC\""},{"line_number":1499,"context_line":"echo \"Restoring xtrace to previous state\""},{"line_number":1500,"context_line":"# Restore xtrace + pipefail"},{"line_number":1501,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a95cdbc_08f16695","line":1498,"in_reply_to":"1a95cdbc_8a5d6e7b","updated":"2016-10-06 22:37:35.000000000","message":"Sure. I can add that :)","commit_id":"9f08e53987ca607ba76c2e5d998521ae3de6f5a9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"824215d95012aa98618c17a382d001ba4b2831e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if [[ -z \"$DEVSTACK_LIB_IRONIC_SRC_COUNT\" ]]; then"},{"line_number":28,"context_line":"    # The first time through enable xtrace"},{"line_number":29,"context_line":"    DEVSTACK_LIB_IRONIC_SRC_COUNT\u003d0"},{"line_number":30,"context_line":"    set -o xtrace"},{"line_number":31,"context_line":"    _XTRACE_IRONIC_STATUS\u003denabled"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Subsequent times through disable xtrace"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_8c215050","line":30,"updated":"2016-10-12 08:39:31.000000000","message":"I\u0027m not sure that we should set -o xtrace here.\nBy it we just enable debugging for variable assignment which will generate a tonn of logs, it is disabled in all components please have look at devstack/lib/{nova|horizon|keystone} etc... Nova example [1]\n\nAt the moment xtrace is enabled when we do actual functions calls under plugin.sh, we can find variable values at the point of function calls so showing variables at stage of theirs assignment is just information duplication.\n\nMight be I\u0027m missing something?\n\n[1] https://github.com/openstack-dev/devstack/blob/master/lib/nova#L29","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5d31e4a858fe7e01563974c06fb18e7d0e9927ce","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if [[ -z \"$DEVSTACK_LIB_IRONIC_SRC_COUNT\" ]]; then"},{"line_number":28,"context_line":"    # The first time through enable xtrace"},{"line_number":29,"context_line":"    DEVSTACK_LIB_IRONIC_SRC_COUNT\u003d0"},{"line_number":30,"context_line":"    set -o xtrace"},{"line_number":31,"context_line":"    _XTRACE_IRONIC_STATUS\u003denabled"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Subsequent times through disable xtrace"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_9a59745d","line":30,"in_reply_to":"fa6399be_8c215050","updated":"2016-10-12 14:15:52.000000000","message":"Understand that other projects don\u0027t.\n\nThis adds about 165 lines of log output and the total logfile is 19440 lines. A 1% increase doesn\u0027t seem like that much considering the extra info we get.\n\nIn my debugging work I have wanted to go find out what these variables are set to and it has been difficult at times. This makes it easier.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f968839632412fae3ed71e5f7148f486aeff7cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if [[ -z \"$DEVSTACK_LIB_IRONIC_SRC_COUNT\" ]]; then"},{"line_number":28,"context_line":"    # The first time through enable xtrace"},{"line_number":29,"context_line":"    DEVSTACK_LIB_IRONIC_SRC_COUNT\u003d0"},{"line_number":30,"context_line":"    set -o xtrace"},{"line_number":31,"context_line":"    _XTRACE_IRONIC_STATUS\u003denabled"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Subsequent times through disable xtrace"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_78d81d1e","line":30,"in_reply_to":"fa6399be_98009103","updated":"2016-10-12 18:32:44.000000000","message":"1-5% increase in log size sounds fine to me.\n\nMaybe this would be more acceptable if there were a boolean parameter one could use to disable xtrace. You can disable it by setting DEVSTACK_LIB_IRONIC_SRC_COUNT !\u003d 0, but that\u0027s a bit hacky.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7c83532f30a72c86f16f29f7e634f6c33ea991ec","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if [[ -z \"$DEVSTACK_LIB_IRONIC_SRC_COUNT\" ]]; then"},{"line_number":28,"context_line":"    # The first time through enable xtrace"},{"line_number":29,"context_line":"    DEVSTACK_LIB_IRONIC_SRC_COUNT\u003d0"},{"line_number":30,"context_line":"    set -o xtrace"},{"line_number":31,"context_line":"    _XTRACE_IRONIC_STATUS\u003denabled"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Subsequent times through disable xtrace"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_a6161def","line":30,"in_reply_to":"fa6399be_9a59745d","updated":"2016-10-12 15:15:39.000000000","message":"I suggest to  print them each time we doing source, becase who knows might be other variables were changed and during next source variable will have a new value.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3e9e814a724b201c676a79153b143d1b22f22f43","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if [[ -z \"$DEVSTACK_LIB_IRONIC_SRC_COUNT\" ]]; then"},{"line_number":28,"context_line":"    # The first time through enable xtrace"},{"line_number":29,"context_line":"    DEVSTACK_LIB_IRONIC_SRC_COUNT\u003d0"},{"line_number":30,"context_line":"    set -o xtrace"},{"line_number":31,"context_line":"    _XTRACE_IRONIC_STATUS\u003denabled"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Subsequent times through disable xtrace"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_b203b40c","line":30,"in_reply_to":"fa6399be_a6161def","updated":"2016-10-12 17:35:07.000000000","message":"I\u0027m okay with doing that. That was my first thought. It would make the log file about 5% larger.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fd2f772f8a8a542339cc45ad68d495118c7d6b06","unresolved":false,"context_lines":[{"line_number":27,"context_line":"if [[ -z \"$DEVSTACK_LIB_IRONIC_SRC_COUNT\" ]]; then"},{"line_number":28,"context_line":"    # The first time through enable xtrace"},{"line_number":29,"context_line":"    DEVSTACK_LIB_IRONIC_SRC_COUNT\u003d0"},{"line_number":30,"context_line":"    set -o xtrace"},{"line_number":31,"context_line":"    _XTRACE_IRONIC_STATUS\u003denabled"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Subsequent times through disable xtrace"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_98009103","line":30,"in_reply_to":"fa6399be_b203b40c","updated":"2016-10-12 18:21:00.000000000","message":"if we print only once there is no guarantee that variables are not changed when we doing source next times. That is why xtrace is disabled in devstack by default, printing it during every source will generate a lot of output. and useless because xtrace is enabled when we calling functions.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"824215d95012aa98618c17a382d001ba4b2831e2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# containing the word \u0027xtrace\u0027 (case senstive). So don\u0027t use \u0027xtrace\u0027 in an"},{"line_number":43,"context_line":"# echo."},{"line_number":44,"context_line":"# https://github.com/openstack-dev/devstack/blob/148d0e6e08caaaa9c6ca828c8404e5e82b6de8ee/tools/outfilter.py#L29"},{"line_number":45,"context_line":"echo \"Tracing (XTRACE) is: ${_XTRACE_IRONIC_STATUS}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Defaults"},{"line_number":48,"context_line":"# --------"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_4cb578ec","line":45,"updated":"2016-10-12 08:39:31.000000000","message":"We can see if xtrace is enabled or not by output. It is just cosmetic thing.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5d31e4a858fe7e01563974c06fb18e7d0e9927ce","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# containing the word \u0027xtrace\u0027 (case senstive). So don\u0027t use \u0027xtrace\u0027 in an"},{"line_number":43,"context_line":"# echo."},{"line_number":44,"context_line":"# https://github.com/openstack-dev/devstack/blob/148d0e6e08caaaa9c6ca828c8404e5e82b6de8ee/tools/outfilter.py#L29"},{"line_number":45,"context_line":"echo \"Tracing (XTRACE) is: ${_XTRACE_IRONIC_STATUS}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Defaults"},{"line_number":48,"context_line":"# --------"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_9a309403","line":45,"in_reply_to":"fa6399be_4cb578ec","updated":"2016-10-12 14:15:52.000000000","message":"I was just trying to be clear that it was enabled or not enabled.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7c83532f30a72c86f16f29f7e634f6c33ea991ec","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# containing the word \u0027xtrace\u0027 (case senstive). So don\u0027t use \u0027xtrace\u0027 in an"},{"line_number":43,"context_line":"# echo."},{"line_number":44,"context_line":"# https://github.com/openstack-dev/devstack/blob/148d0e6e08caaaa9c6ca828c8404e5e82b6de8ee/tools/outfilter.py#L29"},{"line_number":45,"context_line":"echo \"Tracing (XTRACE) is: ${_XTRACE_IRONIC_STATUS}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Defaults"},{"line_number":48,"context_line":"# --------"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_a68c5d80","line":45,"in_reply_to":"fa6399be_9a309403","updated":"2016-10-12 15:15:39.000000000","message":"it will print just specific line, if user doesn\u0027t understand if xtrace is enabled by output, how he will know how many lines before it was enabled? I propose to drop this as well.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3e9e814a724b201c676a79153b143d1b22f22f43","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# containing the word \u0027xtrace\u0027 (case senstive). So don\u0027t use \u0027xtrace\u0027 in an"},{"line_number":43,"context_line":"# echo."},{"line_number":44,"context_line":"# https://github.com/openstack-dev/devstack/blob/148d0e6e08caaaa9c6ca828c8404e5e82b6de8ee/tools/outfilter.py#L29"},{"line_number":45,"context_line":"echo \"Tracing (XTRACE) is: ${_XTRACE_IRONIC_STATUS}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Defaults"},{"line_number":48,"context_line":"# --------"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_475a9850","line":45,"in_reply_to":"fa6399be_a68c5d80","updated":"2016-10-12 17:35:07.000000000","message":"If we are going to print it every time, then yes this serves no purpose.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"824215d95012aa98618c17a382d001ba4b2831e2","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"    fi"},{"line_number":1500,"context_line":"}"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"echo \"Finished sourcing $BASH_SOURCE. Sourcing count: $DEVSTACK_LIB_IRONIC_SRC_COUNT\""},{"line_number":1503,"context_line":"echo \"Restoring tracing (XTRACE) to previous state\""},{"line_number":1504,"context_line":"# Restore xtrace + pipefail"},{"line_number":1505,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_4cac98a0","line":1502,"updated":"2016-10-12 08:39:31.000000000","message":"How knowing source count may be used?","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9f968839632412fae3ed71e5f7148f486aeff7cf","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"    fi"},{"line_number":1500,"context_line":"}"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"echo \"Finished sourcing $BASH_SOURCE. Sourcing count: $DEVSTACK_LIB_IRONIC_SRC_COUNT\""},{"line_number":1503,"context_line":"echo \"Restoring tracing (XTRACE) to previous state\""},{"line_number":1504,"context_line":"# Restore xtrace + pipefail"},{"line_number":1505,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_b81635a5","line":1502,"in_reply_to":"fa6399be_070ee03a","updated":"2016-10-12 18:32:44.000000000","message":"+1 not needed","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5d31e4a858fe7e01563974c06fb18e7d0e9927ce","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"    fi"},{"line_number":1500,"context_line":"}"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"echo \"Finished sourcing $BASH_SOURCE. Sourcing count: $DEVSTACK_LIB_IRONIC_SRC_COUNT\""},{"line_number":1503,"context_line":"echo \"Restoring tracing (XTRACE) to previous state\""},{"line_number":1504,"context_line":"# Restore xtrace + pipefail"},{"line_number":1505,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_8d1e9c61","line":1502,"in_reply_to":"fa6399be_4cac98a0","updated":"2016-10-12 14:15:52.000000000","message":"Not sure :) I found it slightly interesting that this file does get sourced 5 times.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7c83532f30a72c86f16f29f7e634f6c33ea991ec","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"    fi"},{"line_number":1500,"context_line":"}"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"echo \"Finished sourcing $BASH_SOURCE. Sourcing count: $DEVSTACK_LIB_IRONIC_SRC_COUNT\""},{"line_number":1503,"context_line":"echo \"Restoring tracing (XTRACE) to previous state\""},{"line_number":1504,"context_line":"# Restore xtrace + pipefail"},{"line_number":1505,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_c69b11c8","line":1502,"in_reply_to":"fa6399be_8d1e9c61","updated":"2016-10-12 15:15:39.000000000","message":"I don\u0027t think we need this.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3e9e814a724b201c676a79153b143d1b22f22f43","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"    fi"},{"line_number":1500,"context_line":"}"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"echo \"Finished sourcing $BASH_SOURCE. Sourcing count: $DEVSTACK_LIB_IRONIC_SRC_COUNT\""},{"line_number":1503,"context_line":"echo \"Restoring tracing (XTRACE) to previous state\""},{"line_number":1504,"context_line":"# Restore xtrace + pipefail"},{"line_number":1505,"context_line":"$_XTRACE_IRONIC"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"fa6399be_070ee03a","line":1502,"in_reply_to":"fa6399be_c69b11c8","updated":"2016-10-12 17:35:07.000000000","message":"agreed. Especially if we print the content every time.","commit_id":"60c55ed691f73e8ae88b3152c6c260a08ed0702a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3e736da47882a2c1b8748875e5c2f5da356d5195","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Save xtrace and pipefail settings"},{"line_number":24,"context_line":"_XTRACE_IRONIC\u003d$(set +o | grep xtrace)"},{"line_number":25,"context_line":"_PIPEFAIL_IRONIC\u003d$(set +o | grep pipefail)"},{"line_number":26,"context_line":"set -o xtrace"},{"line_number":27,"context_line":"set +o pipefail"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Defaults"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9a629dbe_89c03ce2","line":26,"updated":"2016-11-09 09:58:28.000000000","message":"As I already mentioned this enabled verbose only for phase when we assigning variables. Assigning variables occurs each time when devstack calls \u0027source ironic/devstack/lib/ironic\u0027 (it occurs near 10 times). This will increase log output a lot and normally (in other plugins in devstack tree) xtrace is disabled during variables assignment. Since we can easily trace the value of variable at time when functions that using variable is called. During function calls xtrace is already enabled.","commit_id":"a788fd72b49f6ff435e6aa9e230b47e8404b8a47"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"fbf20b7eae14abc91a57c9a8747c7a4c1dda08e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# Save xtrace and pipefail settings"},{"line_number":24,"context_line":"_XTRACE_IRONIC\u003d$(set +o | grep xtrace)"},{"line_number":25,"context_line":"_PIPEFAIL_IRONIC\u003d$(set +o | grep pipefail)"},{"line_number":26,"context_line":"set -o xtrace"},{"line_number":27,"context_line":"set +o pipefail"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Defaults"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"9a629dbe_421356b8","line":26,"in_reply_to":"9a629dbe_89c03ce2","updated":"2016-11-09 12:44:13.000000000","message":"Vasyl: the number 1 question I ask myself during debugging is \"how did this variable get assigned an incorrect value?\" So variable assignment is the *most* helpful time to log things.","commit_id":"a788fd72b49f6ff435e6aa9e230b47e8404b8a47"}],"devstack/plugin.sh":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2b7e1e205210f9e3892f84746b4ca70d41eb8f83","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# devstack plugin contract defined at:"},{"line_number":5,"context_line":"# http://docs.openstack.org/developer/devstack/plugins.html"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"echo_summary \"ironic\u0027s plugin.sh was called: $1/$2 ...\""},{"line_number":8,"context_line":"source $DEST/ironic/devstack/lib/ironic"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if is_service_enabled ir-api ir-cond; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_aad30a03","line":7,"updated":"2016-10-06 21:57:46.000000000","message":"nit: i\u0027m not sure what the \u0027...\u0027 are for. I interpreted it as \u0027other arguments\u0027.","commit_id":"9f08e53987ca607ba76c2e5d998521ae3de6f5a9"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"7acd1938eacec2330cae8cb21201ec402f7af2c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# devstack plugin contract defined at:"},{"line_number":5,"context_line":"# http://docs.openstack.org/developer/devstack/plugins.html"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"echo_summary \"ironic\u0027s plugin.sh was called: $1/$2 ...\""},{"line_number":8,"context_line":"source $DEST/ironic/devstack/lib/ironic"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"if is_service_enabled ir-api ir-cond; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_68e4aae0","line":7,"in_reply_to":"1a95cdbc_aad30a03","updated":"2016-10-06 22:37:35.000000000","message":"My intention was that we were called with $1/$2 and here comes the output.\n\nBut I can get rid of the ellipsis","commit_id":"9f08e53987ca607ba76c2e5d998521ae3de6f5a9"}]}