)]}'
{"tools/config/check_uptodate.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a68de978fee16b9044ca0410707680bd6c2af8cc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    echo \"${0##*/}: ${PROJECT_NAME}.conf.sample is not up to date.\""},{"line_number":26,"context_line":"    echo \"${0##*/}: Please run oslo-config-generator --config-file\u003d${OSLO_CFGFILE_OPTION}\""},{"line_number":27,"context_line":"    exit 1"},{"line_number":28,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1a95cdbc_c5b865e8","line":28,"updated":"2016-10-06 14:00:59.000000000","message":"Was bashate complaining about the previous syntax ? It\u0027s so picky :-)","commit_id":"3cedd6f924e2769b91c272c5229be3a5c41f0389"}],"tools/run_bashate.sh":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a1f19d890693941640242bea0e348db022e9d85","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"find  \"$@\"  -not \\( -type d -name .?\\* -prune \\)    \\"},{"line_number":16,"context_line":"            -type f                                 \\"},{"line_number":17,"context_line":"            -not -name \\*.swp                       \\"},{"line_number":18,"context_line":"            -not -name \\*~                          \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_6dbd8867","line":15,"updated":"2016-09-21 16:33:47.000000000","message":"This line prevents it from running on .* directories like .git","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ed6d1c75f9c4bc906d4503c3916aed078535ae32","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            -not -name \\*.xml                       \\"},{"line_number":20,"context_line":"            -not -name \\*.template                  \\"},{"line_number":21,"context_line":"            -not -name \\*.py                        \\"},{"line_number":22,"context_line":"            -not -name \\*.conf                      \\"},{"line_number":23,"context_line":"            \\(                                      \\"},{"line_number":24,"context_line":"                -name \\*.sh -or                     \\"},{"line_number":25,"context_line":"                -wholename \\*/lib/\\* -or            \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_7261e738","line":22,"updated":"2016-09-21 16:17:25.000000000","message":"Hm, should we add .rst and .inc here then?","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"3a1f19d890693941640242bea0e348db022e9d85","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            -not -name \\*.xml                       \\"},{"line_number":20,"context_line":"            -not -name \\*.template                  \\"},{"line_number":21,"context_line":"            -not -name \\*.py                        \\"},{"line_number":22,"context_line":"            -not -name \\*.conf                      \\"},{"line_number":23,"context_line":"            \\(                                      \\"},{"line_number":24,"context_line":"                -name \\*.sh -or                     \\"},{"line_number":25,"context_line":"                -wholename \\*/lib/\\* -or            \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_2860cece","line":22,"in_reply_to":"7a8ec9b2_7261e738","updated":"2016-09-21 16:33:47.000000000","message":"These -not lines are just for ignoring files in directories we explicitly include: \u0027*/lib/\u0027 and \u0027*/tools/\u0027\n\nWhich basically means:  devstack/lib/ and tools/","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d3416d9bb764701a213e239caff7b2dbee336747","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            -not -name \\*.conf                      \\"},{"line_number":23,"context_line":"            \\(                                      \\"},{"line_number":24,"context_line":"                -name \\*.sh -or                     \\"},{"line_number":25,"context_line":"                -wholename \\*/lib/\\* -or            \\"},{"line_number":26,"context_line":"                -wholename \\*/tools/\\*              \\"},{"line_number":27,"context_line":"            \\)                                      \\"},{"line_number":28,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_fe870210","line":25,"updated":"2016-09-22 14:28:24.000000000","message":"If we are run tests for all directories why need to keep -wholename \\*/lib/\\* -or -wholename \\*/tools/\\* here? -name \\*.sh should be enough.","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a7692d147f0ba7577918bf7570ea7aa362adccf9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            -not -name \\*.conf                      \\"},{"line_number":23,"context_line":"            \\(                                      \\"},{"line_number":24,"context_line":"                -name \\*.sh -or                     \\"},{"line_number":25,"context_line":"                -wholename \\*/lib/\\* -or            \\"},{"line_number":26,"context_line":"                -wholename \\*/tools/\\*              \\"},{"line_number":27,"context_line":"            \\)                                      \\"},{"line_number":28,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_b5366601","line":25,"in_reply_to":"5a8bc5a2_40bba7c4","updated":"2016-09-22 19:54:20.000000000","message":"That doesn\u0027t work. As \u0027wholename\u0027 is the whole path name.","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a77dd46f00204ec493581dbf7f8dfe397214cb53","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            -not -name \\*.conf                      \\"},{"line_number":23,"context_line":"            \\(                                      \\"},{"line_number":24,"context_line":"                -name \\*.sh -or                     \\"},{"line_number":25,"context_line":"                -wholename \\*/lib/\\* -or            \\"},{"line_number":26,"context_line":"                -wholename \\*/tools/\\*              \\"},{"line_number":27,"context_line":"            \\)                                      \\"},{"line_number":28,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_d8b087e0","line":25,"in_reply_to":"5a8bc5a2_b5366601","updated":"2016-09-22 20:03:55.000000000","message":"-name ironic should work just fine","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"fa56a1323dd9b5f383a7d6d79d9b4f19930f2852","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            -not -name \\*.conf                      \\"},{"line_number":23,"context_line":"            \\(                                      \\"},{"line_number":24,"context_line":"                -name \\*.sh -or                     \\"},{"line_number":25,"context_line":"                -wholename \\*/lib/\\* -or            \\"},{"line_number":26,"context_line":"                -wholename \\*/tools/\\*              \\"},{"line_number":27,"context_line":"            \\)                                      \\"},{"line_number":28,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_40bba7c4","line":25,"in_reply_to":"5a8bc5a2_fe870210","updated":"2016-09-22 17:21:19.000000000","message":"John: \nThe file devstack/lib/ironic is bash code but does not end in .sh\n\nI prefer to add here -wholename devstack\\/lib\\/ironic if it is the only one exception.","commit_id":"fb480ffa138c022f40e4ba96d5a5f61ce1fa301f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bea7415d7ecc6668d2e28221ddb527aa776e571b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"                -wholename \\*/devstack/lib/ironic -or               \\"},{"line_number":20,"context_line":"                -name \\*.sh                                         \\"},{"line_number":21,"context_line":"            \\)                                                      \\"},{"line_number":22,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a8bc5a2_122715b7","line":22,"updated":"2016-09-23 08:48:33.000000000","message":"Have another thought, why not find bash files by shebang string? It works slower comparing to search by file extension but it takes near ~1sec to find all bash file in ironic tree.\n\nvsaienko@vsaienko-pc:/tmp/ironic$ time find . -type f -wholename \\*/devstack/files/hooks/qemu -or -wholename \\*/devstack/lib/ironic -or -name \\*.sh\n./devstack/upgrade/upgrade.sh\n./devstack/upgrade/shutdown.sh\n./devstack/upgrade/resources.sh\n./devstack/plugin.sh\n./devstack/files/hooks/qemu\n./devstack/tools/ironic/scripts/create-node.sh\n./devstack/tools/ironic/scripts/setup-network.sh\n./devstack/tools/ironic/scripts/cleanup-node.sh\n./devstack/lib/ironic\n./api-ref/regenerate-samples.sh\n./tools/with_venv.sh\n./tools/flake8wrap.sh\n./tools/config/check_uptodate.sh\n./tools/run_bashate.sh\n\nreal    0m0.008s\nuser    0m0.000s\nsys     0m0.004s\n\nvsaienko@vsaienko-pc:/tmp/ironic$ time find . -type f -not -path \\*\\/.git\\/\\* -exec awk \u0027/^#!.*(bash|sh)/{r\u003d1};{exit} END {exit(1-r)}\u0027 {} \\; -print./devstack/upgrade/upgrade.sh\n./devstack/upgrade/shutdown.sh\n./devstack/upgrade/resources.sh\n./devstack/plugin.sh\n./devstack/files/hooks/qemu\n./devstack/tools/ironic/scripts/create-node.sh\n./devstack/tools/ironic/scripts/setup-network.sh\n./devstack/tools/ironic/scripts/cleanup-node.sh\n./devstack/lib/ironic\n./api-ref/regenerate-samples.sh\n./tools/with_venv.sh\n./tools/flake8wrap.sh\n./tools/config/check_uptodate.sh\n./tools/run_bashate.sh\n\nreal    0m1.072s\nuser    0m0.016s\nsys     0m0.080s\nvsaienko@vsaienko-pc:/tmp/ironic$","commit_id":"1025d40cd89c5ddd62d168f4b037f7ec284a913a"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"2564fb08318d4bf8777790ba279ae9fee6f42f20","unresolved":false,"context_lines":[{"line_number":19,"context_line":"                -wholename \\*/devstack/lib/ironic -or               \\"},{"line_number":20,"context_line":"                -name \\*.sh                                         \\"},{"line_number":21,"context_line":"            \\)                                                      \\"},{"line_number":22,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a8bc5a2_36deb36d","line":22,"in_reply_to":"5a8bc5a2_122715b7","updated":"2016-09-23 14:04:27.000000000","message":"It seems like this is getting overly complicated to me.\n\nThe current solution seems mostly readable and works for the most part.\n\nThat find command with \u0027awk\u0027 looks like it would take me about ten minutes to figure out what it is doing :)","commit_id":"1025d40cd89c5ddd62d168f4b037f7ec284a913a"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de0eb95bafd76c01ae4d208b98897891db7cca67","unresolved":false,"context_lines":[{"line_number":19,"context_line":"                -wholename \\*/devstack/lib/ironic -or               \\"},{"line_number":20,"context_line":"                -name \\*.sh                                         \\"},{"line_number":21,"context_line":"            \\)                                                      \\"},{"line_number":22,"context_line":"            -print0 | xargs -0 bashate -v -iE006 -eE005,E042"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a95cdbc_7dde5312","line":22,"in_reply_to":"5a8bc5a2_36deb36d","updated":"2016-10-06 10:11:15.000000000","message":"I don\u0027t think it is too complicated. It just looks at the first line in all files and check if \u0027#!.*bash|sh\u0027 shebang is present.\nWith current approach we hardcoding specific directories to look for shell files in, and keep a lot exceptions to do not check specific file extensions.","commit_id":"1025d40cd89c5ddd62d168f4b037f7ec284a913a"}]}
