)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"37f174a4db028a430dac353c903bcba231019407","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* -L (UEFI Loader): For specifying the absolute path to the UEFI LOADER"},{"line_number":13,"context_line":"* -N (UEFI NVRAM): For specifying the absolute path to the non-volatile"},{"line_number":14,"context_line":"                   memory to store the UEFI variables, if needed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partial-Bug: #1625616"},{"line_number":17,"context_line":"Change-Id: I3a05ff339877ff31eefda8a5a35b6e343bd4627b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_bf5e5343","line":15,"updated":"2016-10-05 04:00:13.000000000","message":"+1 Jay\u0027s comment. This patch needs a Depends-On:374988 tag","commit_id":"47a5f48995808b6eafa0b973a984b383d03be47a"}],"devstack/tools/ironic/scripts/create-node.sh":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2cc507d1c06905c273b016f82b34eb6311ea0d9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Keep track of the DevStack directory"},{"line_number":10,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"while getopts \"n:c:m:d:a:b:e:p:f:l:L:N:\" arg; do"},{"line_number":13,"context_line":"    case $arg in"},{"line_number":14,"context_line":"        n) NAME\u003d$OPTARG;;"},{"line_number":15,"context_line":"        c) CPU\u003d$OPTARG;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_7c0310b9","line":12,"updated":"2016-09-22 09:06:14.000000000","message":"does getopts support long options? if so, I\u0027d prefer we use them","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c605b70f16e29c00d82f2fdc9b3b10d8dc4dfe63","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Keep track of the DevStack directory"},{"line_number":10,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"while getopts \"n:c:m:d:a:b:e:p:f:l:L:N:\" arg; do"},{"line_number":13,"context_line":"    case $arg in"},{"line_number":14,"context_line":"        n) NAME\u003d$OPTARG;;"},{"line_number":15,"context_line":"        c) CPU\u003d$OPTARG;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_34ca78a2","line":12,"in_reply_to":"5a8bc5a2_7c0310b9","updated":"2016-09-22 11:51:03.000000000","message":"Apparently getopts only support short options. Alternatively we could use getopt (without \u0027s\u0027) or a while-loop to be able to use both, short and long options [0].\n\nThat said, I prefer to keep getopts as part of this patch. We can add support for long and short options on a separated patch improving the usability.\n\n[0] http://stackoverflow.com/a/12026302","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2cc507d1c06905c273b016f82b34eb6311ea0d9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        --bootdev network --name $NAME --image \"$volume_path\" \\"},{"line_number":89,"context_line":"        --arch $ARCH --cpus $CPU --memory $MEM --libvirt-nic-driver $LIBVIRT_NIC_DRIVER \\"},{"line_number":90,"context_line":"        --emulator $EMULATOR --bridge br-$NAME --disk-format $DISK_FORMAT \\"},{"line_number":91,"context_line":"        --uefi-loader $UEFI_LOADER --uefi-nvram $UEFI_NVRAM $VM_LOGGING \u003e\u00262"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Createa Virtual BMC for the node if IPMI is used"},{"line_number":94,"context_line":"    if [[ $(type -P vbmc) !\u003d \"\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_9c00dcac","line":91,"updated":"2016-09-22 09:06:14.000000000","message":"+1","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"70f097dfb14232e28137bfd68300bbffab04a10c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        --bootdev network --name $NAME --image \"$volume_path\" \\"},{"line_number":89,"context_line":"        --arch $ARCH --cpus $CPU --memory $MEM --libvirt-nic-driver $LIBVIRT_NIC_DRIVER \\"},{"line_number":90,"context_line":"        --emulator $EMULATOR --bridge br-$NAME --disk-format $DISK_FORMAT \\"},{"line_number":91,"context_line":"        --uefi-loader $UEFI_LOADER --uefi-nvram $UEFI_NVRAM $VM_LOGGING \u003e\u00262"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Createa Virtual BMC for the node if IPMI is used"},{"line_number":94,"context_line":"    if [[ $(type -P vbmc) !\u003d \"\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a8ec9b2_6d465ac1","line":91,"updated":"2016-09-21 21:15:03.000000000","message":"can\u0027t pass nothing to the --options. We\u0027d either need if..then append to cmdline, or have a dummy arg always passed and deal with it in configure-vim.py","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c605b70f16e29c00d82f2fdc9b3b10d8dc4dfe63","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        --bootdev network --name $NAME --image \"$volume_path\" \\"},{"line_number":89,"context_line":"        --arch $ARCH --cpus $CPU --memory $MEM --libvirt-nic-driver $LIBVIRT_NIC_DRIVER \\"},{"line_number":90,"context_line":"        --emulator $EMULATOR --bridge br-$NAME --disk-format $DISK_FORMAT \\"},{"line_number":91,"context_line":"        --uefi-loader $UEFI_LOADER --uefi-nvram $UEFI_NVRAM $VM_LOGGING \u003e\u00262"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Createa Virtual BMC for the node if IPMI is used"},{"line_number":94,"context_line":"    if [[ $(type -P vbmc) !\u003d \"\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a8bc5a2_74c40092","line":91,"in_reply_to":"5a8bc5a2_9c00dcac","updated":"2016-09-22 11:51:03.000000000","message":"++ ops my bad","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"db4a063cda9bd89744deabf02a81dd1264e4fb6d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if [ ! -n \"UEFI_LOADER\" ]; then"},{"line_number":69,"context_line":"    UEFI_OPTS\u003d\"--uefi-loader $UEFI_LOADER\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if [ ! -n \"UEFI_NVRAM\" ]; then"},{"line_number":72,"context_line":"        UEFI_OPTS+\u003d\" --uefi-nvram $UEFI_NVRAM\""},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a8bc5a2_a2b7d384","line":71,"updated":"2016-09-23 16:45:13.000000000","message":"I think we should also test for the \"UEFI_NVRAM has been specified but not UEFI_LOADER\" case and issue a warning or error, rather than silently ignoring it.","commit_id":"da9c34f74ae043e584393783540791c19d8c7312"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1dc837bee26202c011fef032956ef3de2d7007a8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"if [ ! -n \"UEFI_LOADER\" ]; then"},{"line_number":69,"context_line":"    UEFI_OPTS\u003d\"--uefi-loader $UEFI_LOADER\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    if [ ! -n \"UEFI_NVRAM\" ]; then"},{"line_number":72,"context_line":"        UEFI_OPTS+\u003d\" --uefi-nvram $UEFI_NVRAM\""},{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a8bc5a2_45ee19ed","line":71,"in_reply_to":"5a8bc5a2_a2b7d384","updated":"2016-09-23 16:56:35.000000000","message":"++ good point","commit_id":"da9c34f74ae043e584393783540791c19d8c7312"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"37f174a4db028a430dac353c903bcba231019407","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Keep track of the DevStack directory"},{"line_number":10,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"while getopts \"n:c:m:d:a:b:e:p:f:l:L:N:\" arg; do"},{"line_number":13,"context_line":"    case $arg in"},{"line_number":14,"context_line":"        n) NAME\u003d$OPTARG;;"},{"line_number":15,"context_line":"        c) CPU\u003d$OPTARG;;"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_ffe53ba8","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":36},"updated":"2016-10-05 04:00:13.000000000","message":"Even though this practice occurs frequently in Linux tools, I feel that mixing case in options presents a horrible UX to the user. In this instance, it\u0027s exacerbated by having the same letter appear in both upper and lower cases: -n/-N, -l/-L. I suggest changing L,N to u,r","commit_id":"47a5f48995808b6eafa0b973a984b383d03be47a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a438d3713beeb3238a0f77d6373f70167b46cbe9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Keep track of the DevStack directory"},{"line_number":10,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"while getopts \"n:c:m:d:a:b:e:p:f:l:L:N:\" arg; do"},{"line_number":13,"context_line":"    case $arg in"},{"line_number":14,"context_line":"        n) NAME\u003d$OPTARG;;"},{"line_number":15,"context_line":"        c) CPU\u003d$OPTARG;;"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_94632c1a","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":36},"in_reply_to":"1a95cdbc_ffe53ba8","updated":"2016-10-05 12:20:07.000000000","message":"That\u0027s a fair point, I will do that","commit_id":"47a5f48995808b6eafa0b973a984b383d03be47a"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"37f174a4db028a430dac353c903bcba231019407","unresolved":false,"context_lines":[{"line_number":73,"context_line":"if [ ! -z \"$UEFI_LOADER\" ]; then"},{"line_number":74,"context_line":"    UEFI_OPTS\u003d\"--uefi-loader $UEFI_LOADER\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if [ ! -z \"$UEFI_NVRAM\" ]; then"},{"line_number":77,"context_line":"        UEFI_OPTS+\u003d\" --uefi-nvram $UEFI_NVRAM\""},{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_dfff9f32","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":35},"updated":"2016-10-05 04:00:13.000000000","message":"This check is redundant, lines 33-36 ensure that UEFI_NVRAM is not empty if UEFI_LOADER is specified.","commit_id":"47a5f48995808b6eafa0b973a984b383d03be47a"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c5717723b7f67a1cc0c685aa34691db17d89074f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"if [ ! -z \"$UEFI_LOADER\" ]; then"},{"line_number":74,"context_line":"    UEFI_OPTS\u003d\"--uefi-loader $UEFI_LOADER\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if [ ! -z \"$UEFI_NVRAM\" ]; then"},{"line_number":77,"context_line":"        UEFI_OPTS+\u003d\" --uefi-nvram $UEFI_NVRAM\""},{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_9deee820","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":35},"in_reply_to":"1a95cdbc_d43bf4e9","updated":"2016-10-05 14:16:46.000000000","message":"You are correct! My bad.","commit_id":"47a5f48995808b6eafa0b973a984b383d03be47a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a438d3713beeb3238a0f77d6373f70167b46cbe9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"if [ ! -z \"$UEFI_LOADER\" ]; then"},{"line_number":74,"context_line":"    UEFI_OPTS\u003d\"--uefi-loader $UEFI_LOADER\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    if [ ! -z \"$UEFI_NVRAM\" ]; then"},{"line_number":77,"context_line":"        UEFI_OPTS+\u003d\" --uefi-nvram $UEFI_NVRAM\""},{"line_number":78,"context_line":"    fi"},{"line_number":79,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a95cdbc_d43bf4e9","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":35},"in_reply_to":"1a95cdbc_dfff9f32","updated":"2016-10-05 12:20:07.000000000","message":"That\u0027s not right, in fact it\u0027s the otherway around. Those lines (33-36) assert that UEFI_NVRAM is not set if UEFI_LOADER is empty because NVRAM depends on the loader but, (some) loaders do not depend on the NVRAM.","commit_id":"47a5f48995808b6eafa0b973a984b383d03be47a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"57e22c0ca26a5877812474973cd612f020cb6171","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Keep track of the DevStack directory"},{"line_number":10,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"while getopts \"n:c:m:d:a:b:e:E:p:f:l:L:N:\" arg; do"},{"line_number":13,"context_line":"    case $arg in"},{"line_number":14,"context_line":"        n) NAME\u003d$OPTARG;;"},{"line_number":15,"context_line":"        c) CPU\u003d$OPTARG;;"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_b4ff3400","line":12,"updated":"2016-11-08 17:31:00.000000000","message":"So you decided to go with mixed case?","commit_id":"793e2b1e3f8f3a067627122eb927e41dc13d5368"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6c2ceeb35d068f44ab31667c4a3418e8c6f3a2e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# Keep track of the DevStack directory"},{"line_number":10,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\")/.. \u0026\u0026 pwd)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"while getopts \"n:c:m:d:a:b:e:E:p:f:l:L:N:\" arg; do"},{"line_number":13,"context_line":"    case $arg in"},{"line_number":14,"context_line":"        n) NAME\u003d$OPTARG;;"},{"line_number":15,"context_line":"        c) CPU\u003d$OPTARG;;"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a629dbe_4d5f0fe5","line":12,"in_reply_to":"9a629dbe_b4ff3400","updated":"2016-11-09 10:07:56.000000000","message":"Yeah, because in the meantime these options got mixed (the E capital-case for ENGINE)","commit_id":"793e2b1e3f8f3a067627122eb927e41dc13d5368"}],"devstack/tools/ironic/templates/vm.xml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2cc507d1c06905c273b016f82b34eb6311ea0d9","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    {% if uefi_loader %}"},{"line_number":9,"context_line":"        \u003cloader readonly\u003d\u0027yes\u0027 type\u003d\u0027pflash\u0027\u003e{{ uefi_loader }}\u003c/loader\u003e"},{"line_number":10,"context_line":"        {% if uefi_nvram %}"},{"line_number":11,"context_line":"            \u003cnvram\u003e{{ uefi_nvram }}\u003c/nvram\u003e"},{"line_number":12,"context_line":"        {% endif %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"    \u003cbootmenu enable\u003d\u0027no\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"5a8bc5a2_bc2bd832","line":11,"updated":"2016-09-22 09:06:14.000000000","message":"just a question: this nvram tag, should it be separate or go under loader?","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c605b70f16e29c00d82f2fdc9b3b10d8dc4dfe63","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    {% if uefi_loader %}"},{"line_number":9,"context_line":"        \u003cloader readonly\u003d\u0027yes\u0027 type\u003d\u0027pflash\u0027\u003e{{ uefi_loader }}\u003c/loader\u003e"},{"line_number":10,"context_line":"        {% if uefi_nvram %}"},{"line_number":11,"context_line":"            \u003cnvram\u003e{{ uefi_nvram }}\u003c/nvram\u003e"},{"line_number":12,"context_line":"        {% endif %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"    \u003cbootmenu enable\u003d\u0027no\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"5a8bc5a2_542b8430","line":11,"in_reply_to":"5a8bc5a2_bc2bd832","updated":"2016-09-22 11:51:03.000000000","message":"It\u0027s separated, just under \u003cloader\u003e (same alignment level) [0]. Some firmwares doesn\u0027t even require passing the UEFI VARS for it that\u0027s why I made it into 2 different options.\n\nI just added some alignment in the template to make it more readable.\n\n[0] e.g:\n\n \u003cloader\u003e .../\u003e\n \u003cnvra\u003e .../\u003e","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2cc507d1c06905c273b016f82b34eb6311ea0d9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      \u003c!-- NOTE(lucasagomes): The virtio disk controller apparently does"},{"line_number":32,"context_line":"           not work with UEFI, so lets use IDE. --\u003e"},{"line_number":33,"context_line":"      {% if uefi_loader %}"},{"line_number":34,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":35,"context_line":"      {% else %}"},{"line_number":36,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e"},{"line_number":37,"context_line":"          \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x06\u0027 function\u003d\u00270x0\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"5a8bc5a2_dc30a4a1","line":34,"updated":"2016-09-22 09:06:14.000000000","message":"huh, what about sata? should be a bit less brutal..","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c605b70f16e29c00d82f2fdc9b3b10d8dc4dfe63","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      \u003c!-- NOTE(lucasagomes): The virtio disk controller apparently does"},{"line_number":32,"context_line":"           not work with UEFI, so lets use IDE. --\u003e"},{"line_number":33,"context_line":"      {% if uefi_loader %}"},{"line_number":34,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":35,"context_line":"      {% else %}"},{"line_number":36,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e"},{"line_number":37,"context_line":"          \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x06\u0027 function\u003d\u00270x0\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"5a8bc5a2_149adc14","line":34,"in_reply_to":"5a8bc5a2_dc30a4a1","updated":"2016-09-22 11:51:03.000000000","message":"I can give it a test. I\u0027ve only used IDE because in my tests that was the first that worked flawlessly after I\u0027ve changed it from virtio.\n\nLater I googled a bit and found out that other people have experienced the same, the main problem of OVMF + VMs at the moment is that apparently not many people uses it so it\u0027s a lot of trial and errors to get things working without a proper explanation.","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c2cc507d1c06905c273b016f82b34eb6311ea0d9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":35,"context_line":"      {% else %}"},{"line_number":36,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e"},{"line_number":37,"context_line":"          \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x06\u0027 function\u003d\u00270x0\u0027/\u003e"},{"line_number":38,"context_line":"      {% endif %}"},{"line_number":39,"context_line":"    \u003c/disk\u003e"},{"line_number":40,"context_line":"    \u003ccontroller type\u003d\u0027ide\u0027 index\u003d\u00270\u0027\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"5a8bc5a2_fc25605c","line":37,"updated":"2016-09-22 09:06:14.000000000","message":"is this address only for virtio?","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c605b70f16e29c00d82f2fdc9b3b10d8dc4dfe63","unresolved":false,"context_lines":[{"line_number":34,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":35,"context_line":"      {% else %}"},{"line_number":36,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e"},{"line_number":37,"context_line":"          \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x00\u0027 slot\u003d\u00270x06\u0027 function\u003d\u00270x0\u0027/\u003e"},{"line_number":38,"context_line":"      {% endif %}"},{"line_number":39,"context_line":"    \u003c/disk\u003e"},{"line_number":40,"context_line":"    \u003ccontroller type\u003d\u0027ide\u0027 index\u003d\u00270\u0027\u003e"}],"source_content_type":"application/xml","patch_set":1,"id":"5a8bc5a2_74b0808c","line":37,"in_reply_to":"5a8bc5a2_fc25605c","updated":"2016-09-22 11:51:03.000000000","message":"Address can be omitted even for virtio. If it\u0027s not present the disk will be assigned to an address at boot time (which is what happens for baremetal (w/o udev rules). \n\nAdding the \u003caddress\u003e tag here just make it to have a fixed address.\n\nThat said, I can add an address to IDE/SATA as well to make it consistent with this virtio.","commit_id":"8d1e5808c4d49360570d9fd0ddc71502de051d20"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"db4a063cda9bd89744deabf02a81dd1264e4fb6d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      \u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027{{ disk_format }}\u0027 cache\u003d\u0027writeback\u0027/\u003e"},{"line_number":30,"context_line":"      \u003csource file\u003d\u0027{{ imagefile }}\u0027/\u003e"},{"line_number":31,"context_line":"      \u003c!-- NOTE(lucasagomes): The virtio disk controller apparently does"},{"line_number":32,"context_line":"           not work with UEFI, so lets use IDE. --\u003e"},{"line_number":33,"context_line":"      {% if uefi_loader %}"},{"line_number":34,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":35,"context_line":"          \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":2,"id":"5a8bc5a2_a26ef3fe","line":32,"updated":"2016-09-23 16:45:13.000000000","message":"Typo: \"let\u0027s\"","commit_id":"da9c34f74ae043e584393783540791c19d8c7312"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1dc837bee26202c011fef032956ef3de2d7007a8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      \u003cdriver name\u003d\u0027qemu\u0027 type\u003d\u0027{{ disk_format }}\u0027 cache\u003d\u0027writeback\u0027/\u003e"},{"line_number":30,"context_line":"      \u003csource file\u003d\u0027{{ imagefile }}\u0027/\u003e"},{"line_number":31,"context_line":"      \u003c!-- NOTE(lucasagomes): The virtio disk controller apparently does"},{"line_number":32,"context_line":"           not work with UEFI, so lets use IDE. --\u003e"},{"line_number":33,"context_line":"      {% if uefi_loader %}"},{"line_number":34,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":35,"context_line":"          \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":2,"id":"5a8bc5a2_85be61d2","line":32,"in_reply_to":"5a8bc5a2_a26ef3fe","updated":"2016-09-23 16:56:35.000000000","message":"Done","commit_id":"da9c34f74ae043e584393783540791c19d8c7312"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"57e22c0ca26a5877812474973cd612f020cb6171","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      \u003c!-- NOTE(lucasagomes): The virtio disk controller apparently does"},{"line_number":35,"context_line":"           not work with UEFI, so let\u0027s use IDE. --\u003e"},{"line_number":36,"context_line":"      {% if uefi_loader %}"},{"line_number":37,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":38,"context_line":"          \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e"},{"line_number":39,"context_line":"      {% else %}"},{"line_number":40,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":5,"id":"9a629dbe_74bf5cfb","line":37,"updated":"2016-11-08 17:31:00.000000000","message":"Is there any benefit in using virtio in case of bios? Maybe make ide for both cases?","commit_id":"793e2b1e3f8f3a067627122eb927e41dc13d5368"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6c2ceeb35d068f44ab31667c4a3418e8c6f3a2e5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      \u003c!-- NOTE(lucasagomes): The virtio disk controller apparently does"},{"line_number":35,"context_line":"           not work with UEFI, so let\u0027s use IDE. --\u003e"},{"line_number":36,"context_line":"      {% if uefi_loader %}"},{"line_number":37,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027ide\u0027/\u003e"},{"line_number":38,"context_line":"          \u003caddress type\u003d\u0027drive\u0027 controller\u003d\u00270\u0027 bus\u003d\u00270\u0027 target\u003d\u00270\u0027 unit\u003d\u00270\u0027/\u003e"},{"line_number":39,"context_line":"      {% else %}"},{"line_number":40,"context_line":"          \u003ctarget dev\u003d\u0027vda\u0027 bus\u003d\u0027virtio\u0027/\u003e"}],"source_content_type":"application/xml","patch_set":5,"id":"9a629dbe_4dbb8fe5","line":37,"in_reply_to":"9a629dbe_74bf5cfb","updated":"2016-11-09 10:07:56.000000000","message":"I think the main reason is performance, AFAIK, virtio should perform better (faster) than IDE.\n\nI\u0027ve did some google about and found this: https://kparal.wordpress.com/2012/09/12/kvm-disk-performance-ide-vs-virtio/\n\n(it\u0027s old tho)\n\nWhat do you think, should we replace it all with IDE ? I would prefer to just keep the BIOS mode as-is today.","commit_id":"793e2b1e3f8f3a067627122eb927e41dc13d5368"}]}
