)]}'
{"ironic/conf/deploy.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"0a5bfc75a9e7ad6ea9b060557da156b4aeaf8f77","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                help\u003d_(\u0027Whether to power off a node after deploy failure. \u0027"},{"line_number":70,"context_line":"                       \u0027Defaults to True.\u0027)),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027default_boot_option\u0027,"},{"line_number":72,"context_line":"               default\u003dNone,"},{"line_number":73,"context_line":"               choices\u003d[\u0027netboot\u0027, \u0027local\u0027],"},{"line_number":74,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":75,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Currently the \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_06a737bd","line":72,"updated":"2016-09-27 12:31:10.000000000","message":"nit: this line is not needed, options value is None if not set","commit_id":"ac29cd201fc836e4e95badc2856b4581fe6b299d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7bf898549f88683e1ceeb1063ac28c6f6c285565","unresolved":false,"context_lines":[{"line_number":73,"context_line":"               choices\u003d[\u0027netboot\u0027, \u0027local\u0027],"},{"line_number":74,"context_line":"               help\u003d_(\u0027Default boot option to use when no boot option is \u0027"},{"line_number":75,"context_line":"                      \u0027requested in node\\\u0027s driver_info. Currently the \u0027"},{"line_number":76,"context_line":"                      \u0027default is \"netboot\", but it will be changed to \u0027"},{"line_number":77,"context_line":"                      \u0027\"local\" in the future. It is recommended to set \u0027"},{"line_number":78,"context_line":"                      \u0027an explicit value for this option.\u0027)),"},{"line_number":79,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_b99ab361","line":76,"range":{"start_line":76,"start_character":34,"end_line":76,"end_character":43},"updated":"2016-09-23 14:37:40.000000000","message":"kind of a default, the real default is None, but dunno if it\u0027s worth explaining.","commit_id":"ac29cd201fc836e4e95badc2856b4581fe6b299d"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"7bf898549f88683e1ceeb1063ac28c6f6c285565","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"        self.node.instance_info \u003d {}"},{"line_number":1397,"context_line":"        result \u003d utils.get_boot_option(self.node)"},{"line_number":1398,"context_line":"        self.assertEqual(\"netboot\", result)"},{"line_number":1399,"context_line":"        self.assertEqual(\"netboot\", utils.DEFAULT_BOOT_OPTION)"},{"line_number":1400,"context_line":"        self.assertTrue(mock_log.called)"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"    @mock.patch.object(utils.LOG, \u0027warning\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_394dc36c","line":1399,"updated":"2016-09-23 14:37:40.000000000","message":"This may introduce races in unittests :(","commit_id":"ac29cd201fc836e4e95badc2856b4581fe6b299d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"39b495c7edb54a0e5d3b854a0574ef643a935b0c","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"        self.node.instance_info \u003d {}"},{"line_number":1397,"context_line":"        result \u003d utils.get_boot_option(self.node)"},{"line_number":1398,"context_line":"        self.assertEqual(\"netboot\", result)"},{"line_number":1399,"context_line":"        self.assertEqual(\"netboot\", utils.DEFAULT_BOOT_OPTION)"},{"line_number":1400,"context_line":"        self.assertTrue(mock_log.called)"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"    @mock.patch.object(utils.LOG, \u0027warning\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a8bc5a2_1525a35a","line":1399,"in_reply_to":"5a8bc5a2_394dc36c","updated":"2016-09-27 11:38:27.000000000","message":"Ugh :( do you know how we usually handle it?","commit_id":"ac29cd201fc836e4e95badc2856b4581fe6b299d"}],"releasenotes/notes/default_boot_option-f22c01f976bc2de7.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0302b45fa0b17e1a2f9c4a23560bf29396426d2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new option \"[deploy]/default_boot_option\" for setting the default"},{"line_number":4,"context_line":"    boot option when no explicit boot option is requested via driver_info."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - We are going to change the default value of \"[deploy]/default_boot_option\""},{"line_number":7,"context_line":"    from \"netboot\" to \"local\" eventually. To avoid disruptions, it is"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_94c18383","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":73},"updated":"2016-10-11 11:56:42.000000000","message":"boot option is defined in properties/capabilities:boot_option not in driver_info\n\nhttps://github.com/openstack/ironic/blob/6394c279ca298afc5887ac884df35bfa36c3dd9c/install-guide/source/include/local-boot-partition-images.rst#enabling-local-boot-with-compute-service","commit_id":"c8312723e9eaa335ec06922750f88d4989ebcd59"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9e4694241e8a532cb36d9bfdc6923b217d56995e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new option \"[deploy]/default_boot_option\" for setting the default"},{"line_number":4,"context_line":"    boot option when no explicit boot option is requested via driver_info."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - We are going to change the default value of \"[deploy]/default_boot_option\""},{"line_number":7,"context_line":"    from \"netboot\" to \"local\" eventually. To avoid disruptions, it is"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_dcc7a143","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":73},"in_reply_to":"fa6399be_94c18383","updated":"2016-10-11 12:58:08.000000000","message":"Actually, the correct one is instance_info (see below in your link).","commit_id":"c8312723e9eaa335ec06922750f88d4989ebcd59"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"519c505fb5e54cadd219f5a1390dc446b1fad034","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new option \"[deploy]/default_boot_option\" for setting the default"},{"line_number":4,"context_line":"    boot option when no explicit boot option is requested via driver_info."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - We are going to change the default value of \"[deploy]/default_boot_option\""},{"line_number":7,"context_line":"    from \"netboot\" to \"local\" eventually. To avoid disruptions, it is"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_3ceedd8b","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":73},"in_reply_to":"fa6399be_dcc7a143","updated":"2016-10-11 13:02:58.000000000","message":"Right, it may be set in instance_info for standalone case, but when we using ironic+nova it should be set via properties/capabilities","commit_id":"c8312723e9eaa335ec06922750f88d4989ebcd59"}]}