)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2d79d3ea66b7abf5fb3f67c47626fa7ef0f3e34c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding Timing metrics for DRAC drivers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds timing metrics for method in the bios, deploy, inspect, management,"},{"line_number":10,"context_line":"power, raid, vendor_passthru modules"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib301f203badecf4834dae5bba35175d13c4545cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_5311daab","line":9,"updated":"2016-10-04 19:14:49.000000000","message":"nit: you should be wrapping these lines at 70char\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"d3104c86060a6c236859a1d1c278a9a05a225f6b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding Timing metrics for DRAC drivers."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds timing metrics for method in the bios, deploy, inspect, management,"},{"line_number":10,"context_line":"power, raid, vendor_passthru modules"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib301f203badecf4834dae5bba35175d13c4545cf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa6399be_984e0395","line":9,"updated":"2016-10-18 15:11:13.000000000","message":"nit: In the future please wrap these lines at 72 characters.","commit_id":"f91d83a56eb3e3901d043ce06456da9d04853aa5"}],"ironic/drivers/modules/drac/bios.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"@METRICS.timer(\u0027set_config\u0027)"},{"line_number":104,"context_line":"def set_config(task, **kwargs):"},{"line_number":105,"context_line":"    \"\"\"Sets the pending_value parameter for each of the values passed in."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_d355ea1d","line":104,"updated":"2016-10-04 19:25:43.000000000","message":"why would you do a metric for set_config, but not for get_config (above, L34)?","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":20462,"name":"Annie Lezil","email":"annie.lezil@gmail.com","username":"alezil"},"change_message_id":"1107c5342adff3cb790e7b296fabe1414a816997","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"@METRICS.timer(\u0027set_config\u0027)"},{"line_number":104,"context_line":"def set_config(task, **kwargs):"},{"line_number":105,"context_line":"    \"\"\"Sets the pending_value parameter for each of the values passed in."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_dc2b3732","line":104,"in_reply_to":"1a95cdbc_d355ea1d","updated":"2016-10-04 22:03:09.000000000","message":"get_config() returns static response.","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@METRICS.timer(\u0027commit_config\u0027)"},{"line_number":132,"context_line":"def commit_config(task, reboot\u003dFalse):"},{"line_number":133,"context_line":"    \"\"\"Commits pending changes added by set_config"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_b634ccde","line":131,"updated":"2016-10-04 19:25:43.000000000","message":"these functions aren\u0027t in classes. Remind me again, what will this metric look like? Will it be apparent that it is in drac/bios?","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"925ef251832d0049c42a43fa87c2799c179d82ba","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@METRICS.timer(\u0027commit_config\u0027)"},{"line_number":132,"context_line":"def commit_config(task, reboot\u003dFalse):"},{"line_number":133,"context_line":"    \"\"\"Commits pending changes added by set_config"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_767c0421","line":131,"in_reply_to":"1a95cdbc_b634ccde","updated":"2016-10-04 19:28:38.000000000","message":"I think due to METRICS \u003d metrics_utils.get_metrics_logger(__NAME__) above this will be logged with the module name.","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"84e7b5cae6460494dc235714af78883f8b30f3c1","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        raise exception.DracOperationError(error\u003dexc)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"@METRICS.timer(\u0027commit_config\u0027)"},{"line_number":132,"context_line":"def commit_config(task, reboot\u003dFalse):"},{"line_number":133,"context_line":"    \"\"\"Commits pending changes added by set_config"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_168d8031","line":131,"in_reply_to":"1a95cdbc_b634ccde","updated":"2016-10-04 19:28:50.000000000","message":"When you initialize the metrics logger with __name__ above, you\u0027re adding the module name/path to the metric value, so it\u0027ll include drac/bios","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"92527c057365de33d425a2585b26090b955d1c31","unresolved":false,"context_lines":[{"line_number":31,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def get_config(node):"},{"line_number":35,"context_line":"    \"\"\"Get the BIOS configuration."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_d4b4d4f3","line":34,"updated":"2016-10-05 12:12:35.000000000","message":"Why are you saying that it returns static config? It still calls the drac client.","commit_id":"1957380cd7ae74c3ce89f62c2bc5892f1349b32d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6af35e4830bb87e8b3703cfbcb9bae43293484e1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"@METRICS.timer(\u0027get_config\u0027)"},{"line_number":35,"context_line":"def get_config(node):"},{"line_number":36,"context_line":"    \"\"\"Get the BIOS configuration."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    :param node: an ironic node object."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_39ba5924","line":35,"updated":"2016-10-11 20:31:58.000000000","message":"I\u0027m not familiar with the DRAC code. But I am wondering -- if all these functions here are being called by other functions, and you have added timing metrics to those other functions, do we really want to emit these metrics too?","commit_id":"cb1867702bd50ae4ba3906c5dfd22f417b4cd208"}],"ironic/drivers/modules/drac/common.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"be6e24db7291eaff124c48650411484effa4bd1f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    return parsed_driver_info"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"@METRICS.timer(\u0027get_drac_client\u0027)"},{"line_number":102,"context_line":"def get_drac_client(node):"},{"line_number":103,"context_line":"    \"\"\"Returns a DRACClient object from python-dracclient library."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa6399be_2e5791cb","line":101,"updated":"2016-10-17 20:35:22.000000000","message":"I was wondering why we\u0027d want to metric this. Isn\u0027t this going to be part of some other timing metric? (I\u0027m only guessing, I\u0027m not familiar with this code and don\u0027t want to look into this in detail.)","commit_id":"846a4e4dc72d60f8fda04ae6673a5a485b66d3e7"}],"ironic/drivers/modules/drac/deploy.py":[{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"c561a9e18afddf05608e35a166000a1c7f325199","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from ironic_lib import metrics_utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":21,"context_line":"from ironic.drivers.modules import iscsi_deploy"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_f265a944","line":19,"updated":"2016-10-03 21:48:19.000000000","message":"nitpicking here, but maybe get rid of this extra new line","commit_id":"be4f91f63ce8c8b6a25ff69b080e0c23ee2c18fe"},{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"c561a9e18afddf05608e35a166000a1c7f325199","unresolved":false,"context_lines":[{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class DracDeploy(iscsi_deploy.ISCSIDeploy):"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_b2ec01bc","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":0},"updated":"2016-10-03 21:48:19.000000000","message":"nitpicking here, but maybe delete this extra new line. Two new line spaces might be unnecessary.","commit_id":"be4f91f63ce8c8b6a25ff69b080e0c23ee2c18fe"}],"ironic/drivers/modules/drac/inspect.py":[{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"c561a9e18afddf05608e35a166000a1c7f325199","unresolved":false,"context_lines":[{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"METRICS \u003d metrics_utils.get_metrics_logger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class DracInspect(base.InspectInterface):"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_f2c129e5","line":38,"updated":"2016-10-03 21:48:19.000000000","message":"nitpick - possibly delete one line space, don\u0027t need two empty lines.","commit_id":"be4f91f63ce8c8b6a25ff69b080e0c23ee2c18fe"}],"ironic/drivers/modules/drac/management.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"92527c057365de33d425a2585b26090b955d1c31","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        return drac_common.parse_driver_info(task.node)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @METRICS.timer(\u0027DracManagement.get_supported_boot_devices\u0027)"},{"line_number":145,"context_line":"    def get_supported_boot_devices(self, task):"},{"line_number":146,"context_line":"        \"\"\"Get a list of the supported boot devices."},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_b47e68e2","line":144,"updated":"2016-10-05 12:12:35.000000000","message":"I\u0027m not completely sure in the intent of the metrics, but what\u0027s the point of having it here? Is someone going to try to optimize dict conversion to list here? Or is it obligatory for all public methods?","commit_id":"1957380cd7ae74c3ce89f62c2bc5892f1349b32d"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"92527c057365de33d425a2585b26090b955d1c31","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        node.driver_internal_info \u003d driver_internal_info"},{"line_number":213,"context_line":"        node.save()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @METRICS.timer(\u0027DracManagement.get_sensors_data\u0027)"},{"line_number":216,"context_line":"    def get_sensors_data(self, task):"},{"line_number":217,"context_line":"        \"\"\"Get sensors data."},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_146e3c2f","line":215,"updated":"2016-10-05 12:12:35.000000000","message":"ditto here","commit_id":"1957380cd7ae74c3ce89f62c2bc5892f1349b32d"}],"ironic/drivers/modules/drac/raid.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":823,"context_line":"                             \"Skip.\"), {\u0027node\u0027: node_uuid})"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    @METRICS.timer(\u0027DracRAID._check_node_raid_jobs\u0027)"},{"line_number":826,"context_line":"    def _check_node_raid_jobs(self, task):"},{"line_number":827,"context_line":"        \"\"\"Check the progress of running RAID config jobs of a node.\"\"\""},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        node \u003d task.node"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_f65d74ed","line":826,"updated":"2016-10-04 19:25:43.000000000","message":"why do you have a metric for this check, but no metric for _query_raid_config_job_status (L794)?","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":854,"context_line":"                self._set_clean_failed(task, config_job)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"    @METRICS.timer(\u0027DracRAID._set_raid_config_job_failure\u0027)"},{"line_number":857,"context_line":"    def _set_raid_config_job_failure(self, node):"},{"line_number":858,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":859,"context_line":"        driver_internal_info[\u0027raid_config_job_failure\u0027] \u003d True"},{"line_number":860,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_565d48e8","line":857,"updated":"2016-10-04 19:25:43.000000000","message":"I don\u0027t see the need to time this?","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":861,"context_line":"        node.save()"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    @METRICS.timer(\u0027DracRAID._clear_raid_config_job_failure\u0027)"},{"line_number":864,"context_line":"    def _clear_raid_config_job_failure(self, node):"},{"line_number":865,"context_line":"        driver_internal_info \u003d node.driver_internal_info"},{"line_number":866,"context_line":"        del driver_internal_info[\u0027raid_config_job_failure\u0027]"},{"line_number":867,"context_line":"        node.driver_internal_info \u003d driver_internal_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_7672447e","line":864,"updated":"2016-10-04 19:25:43.000000000","message":"I don\u0027t see the need to time this?","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":875,"context_line":"                              if job_id not in finished_config_job_ids]"},{"line_number":876,"context_line":"        driver_internal_info[\u0027raid_config_job_ids\u0027] \u003d unfinished_job_ids"},{"line_number":877,"context_line":"        node.driver_internal_info \u003d driver_internal_info"},{"line_number":878,"context_line":"        node.save()"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"    @METRICS.timer(\u0027DracRAID._set_clean_failed\u0027)"},{"line_number":881,"context_line":"    def _set_clean_failed(self, task, config_job):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_b66ccc9d","line":878,"updated":"2016-10-04 19:25:43.000000000","message":"ditto","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                  {\u0027node\u0027: task.node.uuid, \u0027config_job_id\u0027: config_job.id,"},{"line_number":886,"context_line":"                   \u0027message\u0027: config_job.message})"},{"line_number":887,"context_line":"        task.node.last_error \u003d config_job.message"},{"line_number":888,"context_line":"        task.process_event(\u0027fail\u0027)"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    @METRICS.timer(\u0027DracRAID._resume_cleaning\u0027)"},{"line_number":891,"context_line":"    def _resume_cleaning(self, task):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_d669588d","line":888,"updated":"2016-10-04 19:25:43.000000000","message":"ditto","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6af35e4830bb87e8b3703cfbcb9bae43293484e1","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        node.save()"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    @METRICS.timer(\u0027DracRAID._delete_cached_config_job_id\u0027)"},{"line_number":870,"context_line":"    def _delete_cached_config_job_id(self, node, finished_config_job_ids\u003dNone):"},{"line_number":871,"context_line":"        if finished_config_job_ids is None:"},{"line_number":872,"context_line":"            finished_config_job_ids \u003d []"},{"line_number":873,"context_line":"        driver_internal_info \u003d node.driver_internal_info"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_193835d3","line":870,"updated":"2016-10-11 20:31:58.000000000","message":"why do we want to time this?","commit_id":"cb1867702bd50ae4ba3906c5dfd22f417b4cd208"}],"ironic/drivers/modules/drac/vendor_passthru.py":[{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"c561a9e18afddf05608e35a166000a1c7f325199","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from ironic_lib import metrics_utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironic.common.i18n import _"},{"line_number":21,"context_line":"from ironic.conductor import task_manager"},{"line_number":22,"context_line":"from ironic.drivers import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_45b2194d","line":19,"updated":"2016-10-03 21:48:19.000000000","message":"nitpick - maybe delete this extra new line","commit_id":"be4f91f63ce8c8b6a25ff69b080e0c23ee2c18fe"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c4347b1ad0964edc3e0b645205cdce2602dfecce","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                                 \u0027\"unfinished_jobs\"; its value is a list of \u0027"},{"line_number":150,"context_line":"                                 \u0027dictionaries. Each dictionary represents \u0027"},{"line_number":151,"context_line":"                                 \u0027an unfinished config Job object.\u0027))"},{"line_number":152,"context_line":"    def list_unfinished_jobs(self, task, **kwargs):"},{"line_number":153,"context_line":"        \"\"\"List unfinished config jobs of the node."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        :param task: a TaskManager instance containing the node to act on."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_163100a3","line":152,"updated":"2016-10-04 19:25:43.000000000","message":"why no metrics for this?","commit_id":"becb5d92c35a882a648c759c53c54f2472c3b996"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6af35e4830bb87e8b3703cfbcb9bae43293484e1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        :param kwargs: not used."},{"line_number":143,"context_line":"        :raises: DracOperationError on an error from python-dracclient."},{"line_number":144,"context_line":"        \"\"\""},{"line_number":145,"context_line":"        drac_bios.abandon_config(task)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @METRICS.timer(\u0027DracVendorPassthru.list_unfinished_jobs\u0027)"},{"line_number":148,"context_line":"    @base.passthru([\u0027GET\u0027], async\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_5960edce","line":145,"updated":"2016-10-11 20:31:58.000000000","message":"hmm, do we want to do a timing inside a timing? this also emits a metric.","commit_id":"cb1867702bd50ae4ba3906c5dfd22f417b4cd208"}],"releasenotes/notes/bug-1611555-de1ec64ba46982ec.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"be6e24db7291eaff124c48650411484effa4bd1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds Timing Metrics to DRAC drivers."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa6399be_aef001cb","line":3,"updated":"2016-10-17 20:35:22.000000000","message":"nit s/Timing Metrics/timing metrics/","commit_id":"846a4e4dc72d60f8fda04ae6673a5a485b66d3e7"}]}
