)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"678ff192c7d10f02b869afe3cc9c57be9af23462","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Naohiro Tamura \u003cnaohirot@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-02 11:56:20 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the existing APIs due to adding get_supported_power_states"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the existing APIs due to adding"},{"line_number":10,"context_line":"get_supported_power_states of the generic power interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1a430d35_5e6f3492","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"updated":"2017-02-03 09:00:54.000000000","message":"Please limit the title to 50 chars.\n\nFor reference, see https://wiki.openstack.org/wiki/GitCommitMessages\n\nAlso specify the \u0027node APIs\u0027 in title.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1b1338d8b9e7b193613a1411736488301d8535a8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Naohiro Tamura \u003cnaohirot@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-02 11:56:20 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the existing APIs due to adding get_supported_power_states"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the existing APIs due to adding"},{"line_number":10,"context_line":"get_supported_power_states of the generic power interface."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1a430d35_98c9797b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"in_reply_to":"1a430d35_5e6f3492","updated":"2017-02-06 02:07:23.000000000","message":"I\u0027ll fix that.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"96c0cf104fac4105c7716c53ebf428143ee25c1f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the existing APIs due to adding get_supported_power_states"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the existing APIs due to adding"},{"line_number":10,"context_line":"get_supported_power_states of the generic power interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1526226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1a430d35_648d2c31","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":36},"updated":"2017-02-03 21:41:46.000000000","message":"Can you please elaborate more to state what APIs would be updated by adding \"get_supported_power_states\"","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1b1338d8b9e7b193613a1411736488301d8535a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the existing APIs due to adding get_supported_power_states"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the existing APIs due to adding"},{"line_number":10,"context_line":"get_supported_power_states of the generic power interface."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1526226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"1a430d35_58cf117f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":36},"in_reply_to":"1a430d35_648d2c31","updated":"2017-02-06 02:07:23.000000000","message":"I\u0027ll fix that.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"f3390280242404b621e568da55bf5fc0d10d5569","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds ``supported_power_states`` field in the responses"},{"line_number":10,"context_line":"of the requests to the following Ironic APIs. This feature is"},{"line_number":11,"context_line":"supported in Ironic API microversion 1.32 and above."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Create Node, `/v1/nodes`"},{"line_number":14,"context_line":"    * List Nodes Detailed, `/v1/nodes/detail`"},{"line_number":15,"context_line":"    * Show Node Details, `/v1/nodes/{node_ident}`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"da36d5c6_b8a269ac","line":12,"updated":"2017-02-23 14:26:41.000000000","message":"Also rpcapi updated.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds ``supported_power_states`` field in the responses"},{"line_number":10,"context_line":"of the requests to the following Ironic APIs. This feature is"},{"line_number":11,"context_line":"supported in Ironic API microversion 1.32 and above."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Create Node, `/v1/nodes`"},{"line_number":14,"context_line":"    * List Nodes Detailed, `/v1/nodes/detail`"},{"line_number":15,"context_line":"    * Show Node Details, `/v1/nodes/{node_ident}`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"da36d5c6_0e6d9dcb","line":12,"in_reply_to":"da36d5c6_b8a269ac","updated":"2017-02-27 02:59:27.000000000","message":"I\u0027ll fix that.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"bbf9d03a897917be389d88d7f39e61432b7ebfb9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    * Node State Summary, `/v1/nodes/{node_ident}/states`"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Co-Authored-By: Hironori Shiina \u003cshiina.hironori@jp.fujitsu.com\u003e"},{"line_number":21,"context_line":"Partial-Bug: #1526226"},{"line_number":22,"context_line":"Change-Id: Ic4ce99d58febdb5c702ebbfc9276979e6ca6fba0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"7f515b1d_7c39c4a1","line":21,"updated":"2017-10-03 11:52:52.000000000","message":"I personally don\u0027t think this is the right bug/RFE for this commit, its pretty much a separate feature at this point...","commit_id":"a5ea003849a96be1650872e29d9072711a01323c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b795a87e58521a3271a5a21c05081ae04f2196f4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    * Node State Summary, `/v1/nodes/{node_ident}/states`"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Co-Authored-By: Hironori Shiina \u003cshiina.hironori@jp.fujitsu.com\u003e"},{"line_number":21,"context_line":"Partial-Bug: #1526226"},{"line_number":22,"context_line":"Change-Id: Ic4ce99d58febdb5c702ebbfc9276979e6ca6fba0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":39,"id":"7f515b1d_233640e9","line":21,"in_reply_to":"7f515b1d_7c39c4a1","updated":"2017-10-05 14:07:47.000000000","message":"We did approve this change as part of that spec IIRC","commit_id":"a5ea003849a96be1650872e29d9072711a01323c"}],"doc/source/contributor/webapi-version-history.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2cca790025e36faa6e7db2ed2ab6e31b7b03629d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"REST API Version History"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.35** (Pike)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Adds a new field called ``supported_power_states`` to the Node object."},{"line_number":8,"context_line":"    The new field holds a list with all the allowed power states for that node."}],"source_content_type":"text/x-rst","patch_set":37,"id":"7f287b81_6769fb89","line":5,"range":{"start_line":5,"start_character":10,"end_line":5,"end_character":14},"updated":"2017-09-04 07:00:45.000000000","message":"nit: Change it to Queens","commit_id":"da837a62020b99e9f325712c7a443171dd4d52f1"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a806859270b2ceec260eafb50d3d7bd237dc56c5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"REST API Version History"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.35** (Pike)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Adds a new field called ``supported_power_states`` to the Node object."},{"line_number":8,"context_line":"    The new field holds a list with all the allowed power states for that node."}],"source_content_type":"text/x-rst","patch_set":37,"id":"7f287b81_2f96d6f1","line":5,"range":{"start_line":5,"start_character":10,"end_line":5,"end_character":14},"in_reply_to":"7f287b81_6769fb89","updated":"2017-09-07 02:04:04.000000000","message":"Done. Thanks.","commit_id":"da837a62020b99e9f325712c7a443171dd4d52f1"}],"doc/source/dev/webapi-version-history.rst":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"281059a8741dadd397d822513fb84a15eceb2a3b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.32** (Ocata)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":8,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to"},{"line_number":9,"context_line":"    show supported_power_states response field for a node."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"**1.31** (Ocata)"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"fa31d9ce_6b0aa08b","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":8},"updated":"2017-02-15 14:45:13.000000000","message":"(mostly nit):\n\nMaybe it\u0027s only me but this sounds confusing. I would prefer it to be more straight forward in saying what has been done in the patch, for example:\n\n\"Add a new field called ``supported_power_states`` to the Node object. The new field holds a list with all the allowed power states for that node.\"","commit_id":"0d60e7850e43e3816b9c6dc05cf621b22e91307f"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3ab6ba0e0e37aa3aaeb5a6b3f864e1b64f6c5b30","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.32** (Ocata)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":8,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to"},{"line_number":9,"context_line":"    show supported_power_states response field for a node."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"**1.31** (Ocata)"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"fa31d9ce_7b75f92f","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":8},"in_reply_to":"fa31d9ce_6b0aa08b","updated":"2017-02-16 02:26:20.000000000","message":"I\u0027ll fix that.","commit_id":"0d60e7850e43e3816b9c6dc05cf621b22e91307f"}],"ironic/api/controllers/v1/node.py":[{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"1e076a039b98667f0e08ed6360ca8a8be0acb510","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        # DB. Ironic counts with a periodic task that verify the current"},{"line_number":419,"context_line":"        # power states of the nodes and update the DB accordingly."},{"line_number":420,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":421,"context_line":"        # NOTE(naohirot): As an excepttion, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":422,"context_line":"        # come from the DB."},{"line_number":423,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":424,"context_line":"            rpc_node.supported_power_states \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_06c5e959","line":421,"range":{"start_line":421,"start_character":32,"end_line":421,"end_character":42},"updated":"2016-10-06 17:46:13.000000000","message":"s/excepttion/exception/","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"702675ea94215c2b376343a5034e3457727560c1","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        # DB. Ironic counts with a periodic task that verify the current"},{"line_number":419,"context_line":"        # power states of the nodes and update the DB accordingly."},{"line_number":420,"context_line":"        rpc_node \u003d api_utils.get_rpc_node(node_ident)"},{"line_number":421,"context_line":"        # NOTE(naohirot): As an excepttion, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":422,"context_line":"        # come from the DB."},{"line_number":423,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":424,"context_line":"            rpc_node.supported_power_states \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_dd04994b","line":421,"range":{"start_line":421,"start_character":32,"end_line":421,"end_character":42},"in_reply_to":"1a95cdbc_06c5e959","updated":"2016-10-07 02:28:21.000000000","message":"I\u0027ll fix that.","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"1e076a039b98667f0e08ed6360ca8a8be0acb510","unresolved":false,"context_lines":[{"line_number":875,"context_line":"            if node.instance_info.get(\u0027image_url\u0027):"},{"line_number":876,"context_line":"                node.instance_info[\u0027image_url\u0027] \u003d \"******\""},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        # NOTE(naohirot): As an excepttion, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":879,"context_line":"        # come from the DB."},{"line_number":880,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":881,"context_line":"            node.supported_power_states \u003d _get_supported_power_states(rpc_node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_e6dc7d14","line":878,"range":{"start_line":878,"start_character":32,"end_line":878,"end_character":42},"updated":"2016-10-06 17:46:13.000000000","message":"ditto","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"702675ea94215c2b376343a5034e3457727560c1","unresolved":false,"context_lines":[{"line_number":875,"context_line":"            if node.instance_info.get(\u0027image_url\u0027):"},{"line_number":876,"context_line":"                node.instance_info[\u0027image_url\u0027] \u003d \"******\""},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"        # NOTE(naohirot): As an excepttion, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":879,"context_line":"        # come from the DB."},{"line_number":880,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":881,"context_line":"            node.supported_power_states \u003d _get_supported_power_states(rpc_node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_bdeb4d77","line":878,"range":{"start_line":878,"start_character":32,"end_line":878,"end_character":42},"in_reply_to":"1a95cdbc_e6dc7d14","updated":"2016-10-07 02:28:21.000000000","message":"I\u0027ll fix that.","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1124f08bdda1386a1a7d476bb8f3a36f66257d34","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                     provision_state\u003dNone,"},{"line_number":390,"context_line":"                     raid_config\u003dNone,"},{"line_number":391,"context_line":"                     target_raid_config\u003dNone,"},{"line_number":392,"context_line":"                     supported_power_states\u003d[])"},{"line_number":393,"context_line":"        return sample"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_fdadb69b","line":392,"updated":"2016-10-07 17:03:10.000000000","message":"please add something here.","commit_id":"ea9c51199a9b4202b3a9ea6c038f52023aa4d265"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e873b127ef1fc30e02405e95a1419b79b8b6a318","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                     provision_state\u003dNone,"},{"line_number":390,"context_line":"                     raid_config\u003dNone,"},{"line_number":391,"context_line":"                     target_raid_config\u003dNone,"},{"line_number":392,"context_line":"                     supported_power_states\u003d[])"},{"line_number":393,"context_line":"        return sample"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_17b58bcc","line":392,"in_reply_to":"1a95cdbc_fdadb69b","updated":"2016-10-11 02:45:26.000000000","message":"I\u0027ll fix that.","commit_id":"ea9c51199a9b4202b3a9ea6c038f52023aa4d265"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1124f08bdda1386a1a7d476bb8f3a36f66257d34","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":422,"context_line":"        # come from the DB."},{"line_number":423,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":424,"context_line":"            rpc_node.supported_power_states \u003d ("},{"line_number":425,"context_line":"                _get_supported_power_states(rpc_node))"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        return NodeStates.convert(rpc_node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_fd37764a","line":424,"range":{"start_line":424,"start_character":12,"end_line":424,"end_character":20},"updated":"2016-10-07 17:03:10.000000000","message":"Umm, I\u0027m not sure I like setting a non-existent attribute on an object. Can it be passed as a parameter to convert instead?","commit_id":"ea9c51199a9b4202b3a9ea6c038f52023aa4d265"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e873b127ef1fc30e02405e95a1419b79b8b6a318","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":422,"context_line":"        # come from the DB."},{"line_number":423,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":424,"context_line":"            rpc_node.supported_power_states \u003d ("},{"line_number":425,"context_line":"                _get_supported_power_states(rpc_node))"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        return NodeStates.convert(rpc_node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_fad0fecb","line":424,"range":{"start_line":424,"start_character":12,"end_line":424,"end_character":20},"in_reply_to":"1a95cdbc_fd37764a","updated":"2016-10-11 02:45:26.000000000","message":"I\u0027ll fix that.","commit_id":"ea9c51199a9b4202b3a9ea6c038f52023aa4d265"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"1124f08bdda1386a1a7d476bb8f3a36f66257d34","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":879,"context_line":"        # come from the DB."},{"line_number":880,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":881,"context_line":"            node.supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"        update_state_in_older_versions(node)"},{"line_number":884,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_3d3e3e28","line":881,"range":{"start_line":881,"start_character":17,"end_line":881,"end_character":39},"updated":"2016-10-07 17:03:10.000000000","message":"ditto","commit_id":"ea9c51199a9b4202b3a9ea6c038f52023aa4d265"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e873b127ef1fc30e02405e95a1419b79b8b6a318","unresolved":false,"context_lines":[{"line_number":878,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":879,"context_line":"        # come from the DB."},{"line_number":880,"context_line":"        if api_utils.allow_soft_power_off():"},{"line_number":881,"context_line":"            node.supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"        update_state_in_older_versions(node)"},{"line_number":884,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_5013895c","line":881,"range":{"start_line":881,"start_character":17,"end_line":881,"end_character":39},"in_reply_to":"1a95cdbc_3d3e3e28","updated":"2016-10-11 02:45:26.000000000","message":"I\u0027ll fix that.","commit_id":"ea9c51199a9b4202b3a9ea6c038f52023aa4d265"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"59061240fef871c1b8f454b3e092690a4319fc23","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_2ab4b3cf","line":115,"updated":"2017-01-26 16:17:19.000000000","message":"Should we not still return the supported power states when soft power off is disabled?","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"892fadeb44b0b200e24c57a1e647b9335bb2aa99","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_76e68bb5","line":115,"in_reply_to":"3a461143_2ab4b3cf","updated":"2017-01-27 02:25:29.000000000","message":"The purpose of this function get_supported_power_states() is to let user know what kind of power operation a driver supports. So if a driver doesn\u0027t support soft operation, get_supported_power_states() should return just [\"power on\", \"power off\", \"rebooting\"].","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c498e53de256fb838cc6dbb2c7d737d1f696cd2f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_5b54b6c8","line":115,"in_reply_to":"3a461143_58198021","updated":"2017-02-01 11:43:07.000000000","message":"I misunderstood the purpose of api_utils.allow_soft_power_off(). This is fine as it is. Sorry for the trouble!","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"433985c8bbedb27cfb6b6f5a813705a5b23f4558","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_58198021","line":115,"in_reply_to":"3a461143_75b4a1d0","updated":"2017-01-30 02:26:00.000000000","message":"Could you put your test results and how did you test it such as below?\n\n $ curl -i -X GET -H \u0027X-OpenStack-Ironic-API-Version: 1.30\u0027 -H \"X-Auth-Token: $TOKEN\" -H \u0027Content-Type: application/json\u0027 -$ \u0027Accept: application/json\u0027 -d \u0027{}\u0027 http://192.168.222.222:6385/v1/nodes/${NODE_UUID}/states\n \n {\n     \"console_enabled\": false,\n     \"last_error\": null,\n     \"power_state\": \"power off\",\n     \"provision_state\": \"active\",\n     \"provision_updated_at\": \"2017-01-25T05:34:25+00:00\",\n     \"raid_config\": {},\n     \"supported_power_states\": [\n         \"power on\",\n         \"power off\",\n         \"rebooting\",\n         \"soft rebooting\",\n         \"soft power off\"\n     ],\n     \"target_power_state\": null,\n     \"target_provision_state\": null,\n     \"target_raid_config\": {}\n }\n \n $ curl -i -X GET -H \u0027X-OpenStack-Ironic-API-Version: 1.29\u0027 -H \"X-Auth-Token: $TOKEN\" -H \u0027Content-Type: application/json\u0027 -H \u0027Accept: application/json\u0027 -d \u0027{}\u0027 http://192.168.222.222:6385/v1/nodes/${NODE_UUID}/states\n \n {\n     \"console_enabled\": false,\n     \"last_error\": null,\n     \"power_state\": \"power off\",\n     \"provision_state\": \"active\",\n     \"provision_updated_at\": \"2017-01-25T05:34:25+00:00\",\n     \"raid_config\": {},\n     \"target_power_state\": null,\n     \"target_provision_state\": null,\n     \"target_raid_config\": {}\n }","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"282d164fcd062c50b23dfb89d00efe502309b5da","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_75b4a1d0","line":115,"in_reply_to":"3a461143_76e68bb5","updated":"2017-01-27 19:16:23.000000000","message":"I agree, but the function currently returns None when soft power off, rather than [\"power on\", \"power off\", \"rebooting\"].\n\nAm I missing something elsewhere that fills in these defaults?","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dbff51e567ccd76d3a6def718d6e4241d1c6f913","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_63387da1","line":115,"updated":"2017-01-27 12:48:57.000000000","message":"Unfortunately, this adds a new field to response, so it has to be a new microversion :(","commit_id":"ca5269dbd3608ccc0481b3dce44672452d370bbc"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6f0b1cab52be77b564bf863de403d5457fdf8811","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_soft_power_off():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_35a3dd9e","line":115,"in_reply_to":"3a461143_63387da1","updated":"2017-01-30 02:11:43.000000000","message":"I\u0027ll fix that.","commit_id":"ca5269dbd3608ccc0481b3dce44672452d370bbc"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"6f318ab40dfe035251b111f040e9df9e4dff6444","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_4ccfe928","line":115,"updated":"2017-01-30 19:36:36.000000000","message":"I think BAD_REQUEST error should be thrown if lower APIs try to make the api call?","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a5d8f5a11c1f43ad579e408723b2ea63727a81bf","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_683ac39a","line":115,"in_reply_to":"3a461143_4ccfe928","updated":"2017-01-31 04:35:14.000000000","message":"No, if lower API microversion is specified, it should work without BAD_REQUEST exception so as not to break compatibility.","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"96c0cf104fac4105c7716c53ebf428143ee25c1f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               ir_states.SOFT_POWER_OFF)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_d81de067","line":112,"range":{"start_line":112,"start_character":32,"end_line":112,"end_character":40},"updated":"2017-02-03 21:41:46.000000000","message":"Do you think passing node_ident would be better than passing the whole node?","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1b1338d8b9e7b193613a1411736488301d8535a8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               ir_states.SOFT_POWER_OFF)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_187d896e","line":112,"range":{"start_line":112,"start_character":32,"end_line":112,"end_character":40},"in_reply_to":"1a430d35_d81de067","updated":"2017-02-06 02:07:23.000000000","message":"No, because we need to call api_utils.get_rpc_node(node_ident) again, and we don\u0027t use any information in node object in this function,but rcp_node.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"96c0cf104fac4105c7716c53ebf428143ee25c1f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_380a64d3","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":45},"updated":"2017-02-03 21:41:46.000000000","message":"Can you please add else module to throw an exception or return what was being supported till last version","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1b1338d8b9e7b193613a1411736488301d8535a8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"def _get_supported_power_states(rpc_node):"},{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_98e89912","line":115,"range":{"start_line":115,"start_character":4,"end_line":115,"end_character":45},"in_reply_to":"1a430d35_380a64d3","updated":"2017-02-06 02:07:23.000000000","message":"As I answered in the patch set 17 [1], throwing exception breaks compatibility, so we cannot do that.\n\nOur customer has many programs which call lower api version, then customer\u0027s task will fail if we changed the behavior of the lower version.\n\n [1] https://review.openstack.org/#/c/382194/17..20/ironic/api/controllers/v1/node.py","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("},{"line_number":119,"context_line":"                pecan.request.context, rpc_node.uuid, topic))"},{"line_number":120,"context_line":"    return supported_power_states"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_f5da2c4a","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":61},"updated":"2017-02-23 14:19:55.000000000","message":"l116 - recreate hash ring with select conductors and driver(interfaces) from DB. l118 - RPC call. Both for GET requests. IMO supported states can be cached in the API service for node.uuid,driver(power_interface) pair. What you think?","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    \"\"\"\"Get a list of the supported power states\"\"\""},{"line_number":114,"context_line":"    supported_power_states \u003d None"},{"line_number":115,"context_line":"    if api_utils.allow_supported_power_states():"},{"line_number":116,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":117,"context_line":"        supported_power_states \u003d ("},{"line_number":118,"context_line":"            pecan.request.rpcapi.get_supported_power_states("},{"line_number":119,"context_line":"                pecan.request.context, rpc_node.uuid, topic))"},{"line_number":120,"context_line":"    return supported_power_states"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_0e6cbd06","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":61},"in_reply_to":"da36d5c6_f5da2c4a","updated":"2017-02-27 02:59:27.000000000","message":"I agree with you that caching makes performance better than not caching theoretically.\nIn this case, however, ROE (return on effort) would be very low.\nBecause even if we spent a lot of effort especially for how to expire the cache so as not to sneak any subtle bug, we will gain unnoticeable performance improvement.\n\nSo IMO, if this code became a bottle neck,  then we should introduce the cache by issuing a bug report.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    \"\"\"A list of the supported power states of the node\"\"\""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @staticmethod"},{"line_number":415,"context_line":"    def convert(rpc_node, supported_power_states\u003dNone):"},{"line_number":416,"context_line":"        attr_list \u003d [\u0027console_enabled\u0027, \u0027last_error\u0027, \u0027power_state\u0027,"},{"line_number":417,"context_line":"                     \u0027provision_state\u0027, \u0027target_power_state\u0027,"},{"line_number":418,"context_line":"                     \u0027target_provision_state\u0027, \u0027provision_updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_f5414c64","line":415,"range":{"start_line":415,"start_character":48,"end_line":415,"end_character":53},"updated":"2017-02-23 14:19:55.000000000","message":"Why default value used here? We always know states (l473).","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    \"\"\"A list of the supported power states of the node\"\"\""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @staticmethod"},{"line_number":415,"context_line":"    def convert(rpc_node, supported_power_states\u003dNone):"},{"line_number":416,"context_line":"        attr_list \u003d [\u0027console_enabled\u0027, \u0027last_error\u0027, \u0027power_state\u0027,"},{"line_number":417,"context_line":"                     \u0027provision_state\u0027, \u0027target_power_state\u0027,"},{"line_number":418,"context_line":"                     \u0027target_provision_state\u0027, \u0027provision_updated_at\u0027]"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_310ba625","line":415,"range":{"start_line":415,"start_character":48,"end_line":415,"end_character":53},"in_reply_to":"da36d5c6_f5414c64","updated":"2017-02-27 02:59:27.000000000","message":"At this moment, only L473 happens to be a caller, that is my understanding.\nAa a public public method, the default value is necessary for the condition at L421.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            attr_list.extend([\u0027raid_config\u0027, \u0027target_raid_config\u0027])"},{"line_number":421,"context_line":"        if supported_power_states is not None:"},{"line_number":422,"context_line":"            attr_list.extend([\u0027supported_power_states\u0027])"},{"line_number":423,"context_line":"            rpc_node.supported_power_states \u003d supported_power_states"},{"line_number":424,"context_line":"        states \u003d NodeStates()"},{"line_number":425,"context_line":"        for attr in attr_list:"},{"line_number":426,"context_line":"            setattr(states, attr, getattr(rpc_node, attr))"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_d5e368d7","line":423,"updated":"2017-02-23 14:19:55.000000000","message":"This code can confuse because supported_power_states is not field of rpc_node. Why not set this attribute separately later?","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            attr_list.extend([\u0027raid_config\u0027, \u0027target_raid_config\u0027])"},{"line_number":421,"context_line":"        if supported_power_states is not None:"},{"line_number":422,"context_line":"            attr_list.extend([\u0027supported_power_states\u0027])"},{"line_number":423,"context_line":"            rpc_node.supported_power_states \u003d supported_power_states"},{"line_number":424,"context_line":"        states \u003d NodeStates()"},{"line_number":425,"context_line":"        for attr in attr_list:"},{"line_number":426,"context_line":"            setattr(states, attr, getattr(rpc_node, attr))"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_31280633","line":423,"in_reply_to":"da36d5c6_d5e368d7","updated":"2017-02-27 02:59:27.000000000","message":"convert() is the last call of get() from L.475.\nI couldn\u0027t fully understand the appropriate place you mentioned \"separately later\".\nIt would be helpful if you advised me more concretely.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                     raid_config\u003dNone,"},{"line_number":440,"context_line":"                     target_raid_config\u003dNone,"},{"line_number":441,"context_line":"                     supported_power_states\u003d["},{"line_number":442,"context_line":"                         \"power on\", \"power off\", \"rebooting\"])"},{"line_number":443,"context_line":"        return sample"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_553e9828","line":442,"updated":"2017-02-23 14:19:55.000000000","message":"Better to use ir_states.POWER_ON etc here.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":439,"context_line":"                     raid_config\u003dNone,"},{"line_number":440,"context_line":"                     target_raid_config\u003dNone,"},{"line_number":441,"context_line":"                     supported_power_states\u003d["},{"line_number":442,"context_line":"                         \"power on\", \"power off\", \"rebooting\"])"},{"line_number":443,"context_line":"        return sample"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_911c526b","line":442,"in_reply_to":"da36d5c6_553e9828","updated":"2017-02-27 02:59:27.000000000","message":"I\u0027ll fix that.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":900,"context_line":"    @staticmethod"},{"line_number":901,"context_line":"    def _convert_with_links(node, url, fields\u003dNone, show_states_links\u003dTrue,"},{"line_number":902,"context_line":"                            show_portgroups\u003dTrue,"},{"line_number":903,"context_line":"                            supported_power_states\u003dNone):"},{"line_number":904,"context_line":"        # NOTE(lucasagomes): Since we are able to return a specified set of"},{"line_number":905,"context_line":"        # fields the \"uuid\" can be unset, so we need to save it in another"},{"line_number":906,"context_line":"        # variable to use when building the links"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_d8d63d4e","line":903,"range":{"start_line":903,"start_character":50,"end_line":903,"end_character":55},"updated":"2017-02-23 14:19:55.000000000","message":"ditto","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":900,"context_line":"    @staticmethod"},{"line_number":901,"context_line":"    def _convert_with_links(node, url, fields\u003dNone, show_states_links\u003dTrue,"},{"line_number":902,"context_line":"                            show_portgroups\u003dTrue,"},{"line_number":903,"context_line":"                            supported_power_states\u003dNone):"},{"line_number":904,"context_line":"        # NOTE(lucasagomes): Since we are able to return a specified set of"},{"line_number":905,"context_line":"        # fields the \"uuid\" can be unset, so we need to save it in another"},{"line_number":906,"context_line":"        # variable to use when building the links"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_d19deabc","line":903,"range":{"start_line":903,"start_character":50,"end_line":903,"end_character":55},"in_reply_to":"da36d5c6_d8d63d4e","updated":"2017-02-27 02:59:27.000000000","message":"same answer as above.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                     management_interface\u003dNone, power_interface\u003dNone,"},{"line_number":1025,"context_line":"                     raid_interface\u003dNone, vendor_interface\u003dNone,"},{"line_number":1026,"context_line":"                     supported_power_states\u003d["},{"line_number":1027,"context_line":"                         \"power on\", \"power off\", \"rebooting\"])"},{"line_number":1028,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":1029,"context_line":"        # _chassis_uuid variable:"},{"line_number":1030,"context_line":"        sample._chassis_uuid \u003d \u0027edcad704-b2da-41d5-96d9-afd580ecfa12\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_78b7113a","line":1027,"updated":"2017-02-23 14:19:55.000000000","message":"ditto","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                     management_interface\u003dNone, power_interface\u003dNone,"},{"line_number":1025,"context_line":"                     raid_interface\u003dNone, vendor_interface\u003dNone,"},{"line_number":1026,"context_line":"                     supported_power_states\u003d["},{"line_number":1027,"context_line":"                         \"power on\", \"power off\", \"rebooting\"])"},{"line_number":1028,"context_line":"        # NOTE(matty_dubs): The chassis_uuid getter() is based on the"},{"line_number":1029,"context_line":"        # _chassis_uuid variable:"},{"line_number":1030,"context_line":"        sample._chassis_uuid \u003d \u0027edcad704-b2da-41d5-96d9-afd580ecfa12\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"da36d5c6_11a4e205","line":1027,"in_reply_to":"da36d5c6_78b7113a","updated":"2017-02-27 02:59:27.000000000","message":"I\u0027ll fix that.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"10814099b4457802769397e0b053ca6fafaa85e4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_20_NETWORK_INTERFACE:"},{"line_number":157,"context_line":"        obj.network_interface \u003d wsme.Unset"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_32_SUPPORTED_POWER_STATES:"},{"line_number":160,"context_line":"        obj.supported_power_states \u003d wsme.Unset"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if not api_utils.allow_resource_class():"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f044301_5f7c48b4","line":159,"updated":"2017-05-08 20:16:42.000000000","message":"Seems like should use allow_supported_power_states()\n\n if not api_utils.allow_supported_power_states():\n   ...","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f753ceaafee8db6d962e11be9dbf0f8e35ef99dd","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_20_NETWORK_INTERFACE:"},{"line_number":157,"context_line":"        obj.network_interface \u003d wsme.Unset"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    if pecan.request.version.minor \u003c versions.MINOR_32_SUPPORTED_POWER_STATES:"},{"line_number":160,"context_line":"        obj.supported_power_states \u003d wsme.Unset"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    if not api_utils.allow_resource_class():"}],"source_content_type":"text/x-python","patch_set":26,"id":"df140735_a204bfc7","line":159,"in_reply_to":"3f044301_5f7c48b4","updated":"2017-05-28 12:57:49.000000000","message":"This check in unnecessary because this field is not set to the object when this method is called. It\u0027s set in _convert_with_links().","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"10814099b4457802769397e0b053ca6fafaa85e4","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    \"\"\"The desired RAID configuration, to be used the next time the node"},{"line_number":409,"context_line":"    is configured.\"\"\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    supported_power_states \u003d wsme.wsattr([wtypes.text], readonly\u003dTrue)"},{"line_number":412,"context_line":"    \"\"\"A list of the supported power states of the node\"\"\""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f044301_f85a0af1","line":411,"updated":"2017-05-08 20:16:42.000000000","message":"I don\u0027t understand this code that well.\n\nWhy does supported_power_states need to be in both NodeStates and Node?","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f753ceaafee8db6d962e11be9dbf0f8e35ef99dd","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    \"\"\"The desired RAID configuration, to be used the next time the node"},{"line_number":409,"context_line":"    is configured.\"\"\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    supported_power_states \u003d wsme.wsattr([wtypes.text], readonly\u003dTrue)"},{"line_number":412,"context_line":"    \"\"\"A list of the supported power states of the node\"\"\""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":26,"id":"df140735_c2fe93ad","line":411,"in_reply_to":"3f044301_f85a0af1","updated":"2017-05-28 12:57:49.000000000","message":"According to the SPEC[1], the new “supported_power_states” member will be added to the return type both Node and NodeStates.\n\n[1] https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/enhance-power-interface-for-soft-reboot-and-nmi.html#rest-api-impact","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"235c011e74cc72e435be56b8422375747070a220","unresolved":false,"context_lines":[{"line_number":938,"context_line":"                      link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"},{"line_number":939,"context_line":"                                          node_uuid, bookmark\u003dTrue)"},{"line_number":940,"context_line":"                      ]"},{"line_number":941,"context_line":"        if supported_power_states is not None:"},{"line_number":942,"context_line":"            node.supported_power_states \u003d supported_power_states"},{"line_number":943,"context_line":"        return node"},{"line_number":944,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_9c34badf","line":941,"range":{"start_line":941,"start_character":11,"end_line":941,"end_character":33},"updated":"2017-04-21 15:23:05.000000000","message":"if supported_power_states is None, then what will be the value of node.supported_power_states? Will it be None? or something else? IMO the supported_power_states should have default value of on, off and reboot.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4931f42be3725545bb7117544f19b0305747ee16","unresolved":false,"context_lines":[{"line_number":938,"context_line":"                      link.Link.make_link(\u0027bookmark\u0027, url, \u0027nodes\u0027,"},{"line_number":939,"context_line":"                                          node_uuid, bookmark\u003dTrue)"},{"line_number":940,"context_line":"                      ]"},{"line_number":941,"context_line":"        if supported_power_states is not None:"},{"line_number":942,"context_line":"            node.supported_power_states \u003d supported_power_states"},{"line_number":943,"context_line":"        return node"},{"line_number":944,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5ff73747_1e1bae1b","line":941,"range":{"start_line":941,"start_character":11,"end_line":941,"end_character":33},"in_reply_to":"7ffa3b31_9c34badf","updated":"2017-04-24 13:40:09.000000000","message":"If the value is None, a response doesn\u0027t have supported_power_states. It makes sense because we shouldn\u0027t show this new attribute to older API versions for compatibility. Please see line 115.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"235c011e74cc72e435be56b8422375747070a220","unresolved":false,"context_lines":[{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":984,"context_line":"        # come from the DB."},{"line_number":985,"context_line":"        supported_power_states \u003d None"},{"line_number":986,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":987,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":988,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"7ffa3b31_fcf4def2","line":985,"range":{"start_line":985,"start_character":8,"end_line":985,"end_character":37},"updated":"2017-04-21 15:23:05.000000000","message":"ditto.IMO the default should be \"On, off and reboot\"","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"4931f42be3725545bb7117544f19b0305747ee16","unresolved":false,"context_lines":[{"line_number":982,"context_line":""},{"line_number":983,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":984,"context_line":"        # come from the DB."},{"line_number":985,"context_line":"        supported_power_states \u003d None"},{"line_number":986,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":987,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":988,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"5ff73747_be8efa2b","line":985,"range":{"start_line":985,"start_character":8,"end_line":985,"end_character":37},"in_reply_to":"7ffa3b31_fcf4def2","updated":"2017-04-24 13:40:09.000000000","message":"ditto.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"10814099b4457802769397e0b053ca6fafaa85e4","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":984,"context_line":"        # come from the DB."},{"line_number":985,"context_line":"        supported_power_states \u003d None"},{"line_number":986,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":987,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        update_state_in_older_versions(node)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f044301_180936dc","line":986,"updated":"2017-05-08 20:16:42.000000000","message":"I don\u0027t understand why when fields is None that set supported_power_states.\n\nIf the comment on line 903 is explaining it, then I think the comment needs to be better as I don\u0027t understand.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f753ceaafee8db6d962e11be9dbf0f8e35ef99dd","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 doesn\u0027t"},{"line_number":984,"context_line":"        # come from the DB."},{"line_number":985,"context_line":"        supported_power_states \u003d None"},{"line_number":986,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":987,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        update_state_in_older_versions(node)"}],"source_content_type":"text/x-python","patch_set":26,"id":"df140735_422cc346","line":986,"in_reply_to":"3f044301_180936dc","updated":"2017-05-28 12:57:49.000000000","message":"Because RPC node obj doesn\u0027t have supported_power_states, it should be got with another RPC API if necessary. When fields is None, a API node obj should have all attributes.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0f2ac6e8af0e06b425ec9bc70e4464a6c8b39cf7","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        # a member of RPC node. It is got by another RPC call when necessary."},{"line_number":984,"context_line":"        supported_power_states \u003d None"},{"line_number":985,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":986,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"        update_state_in_older_versions(node)"},{"line_number":989,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":28,"id":"df140735_47c5ec8d","line":986,"updated":"2017-05-29 07:37:55.000000000","message":"I don\u0027t think this is a good idea. getting supported power states may result in a call to the BMC (and IIRC it does in case of Redfish). this is not something we want to do synchronously. We may want to cache supported power states in a power state sync loop, for example.","commit_id":"fd4b8e7906de316607cd4b8c64e9efcb8740decf"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"3781d0b12cb2f6284785afb9fee01b130465ea36","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        # a member of RPC node. It is got by another RPC call when necessary."},{"line_number":984,"context_line":"        supported_power_states \u003d None"},{"line_number":985,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":986,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":"        update_state_in_older_versions(node)"},{"line_number":989,"context_line":"        hide_fields_in_newer_versions(node)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff346bd7_516db296","line":986,"in_reply_to":"df140735_47c5ec8d","updated":"2017-07-24 07:45:39.000000000","message":"I added caching for each power interface because power states supported by the interfaces are static. No interface doesn\u0027t call the BMC.","commit_id":"fd4b8e7906de316607cd4b8c64e9efcb8740decf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e718e812fb5d037cb76d43580d1eb66c90ba0ca9","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def _get_supported_power_states_rpc():"},{"line_number":120,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":121,"context_line":"        return pecan.request.rpcapi.get_supported_power_states("},{"line_number":122,"context_line":"            pecan.request.context, rpc_node.uuid, topic)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    if not api_utils.allow_supported_power_states():"},{"line_number":125,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_4805a313","line":122,"updated":"2017-07-26 14:40:03.000000000","message":"This will need to be avoided during a rolling upgrade. See https://review.openstack.org/#/c/485773/ for how I\u0027m proposing to do this for the create_port RPC.\n\nThere was also this: https://review.openstack.org/#/c/469933/14/ironic/api/controllers/v1/utils.py in the API, you might need something similar.","commit_id":"425beeb6d4163086345a37f47895f5e5d230ef67"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"c9cc7dc3645f28f370cd08614fb9b282facaa775","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    def _get_supported_power_states_rpc():"},{"line_number":120,"context_line":"        topic \u003d pecan.request.rpcapi.get_topic_for(rpc_node)"},{"line_number":121,"context_line":"        return pecan.request.rpcapi.get_supported_power_states("},{"line_number":122,"context_line":"            pecan.request.context, rpc_node.uuid, topic)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    if not api_utils.allow_supported_power_states():"},{"line_number":125,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_f7df440a","line":122,"in_reply_to":"ff346bd7_4805a313","updated":"2017-07-28 13:27:38.000000000","message":"I added a change to rpcapi for a rolling upgrade.","commit_id":"425beeb6d4163086345a37f47895f5e5d230ef67"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbffc4ecdd6c5e74a9fb66aeb56bcf35ac71d5ee","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            attr_list.extend([\u0027raid_config\u0027, \u0027target_raid_config\u0027])"},{"line_number":438,"context_line":"        if supported_power_states is not None:"},{"line_number":439,"context_line":"            attr_list.extend([\u0027supported_power_states\u0027])"},{"line_number":440,"context_line":"            rpc_node.supported_power_states \u003d supported_power_states"},{"line_number":441,"context_line":"        states \u003d NodeStates()"},{"line_number":442,"context_line":"        for attr in attr_list:"},{"line_number":443,"context_line":"            setattr(states, attr, getattr(rpc_node, attr))"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_2715059d","line":440,"updated":"2017-08-02 08:25:03.000000000","message":"Actually, nothing else modifies rpc_node in this method. How about this on L444:\n\nif supported_power_states is not None:\n   states.supported_power_states \u003d supported_power_states","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"889cdba71d10fd10c2e69dbf5d8c2f9082140373","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            attr_list.extend([\u0027raid_config\u0027, \u0027target_raid_config\u0027])"},{"line_number":438,"context_line":"        if supported_power_states is not None:"},{"line_number":439,"context_line":"            attr_list.extend([\u0027supported_power_states\u0027])"},{"line_number":440,"context_line":"            rpc_node.supported_power_states \u003d supported_power_states"},{"line_number":441,"context_line":"        states \u003d NodeStates()"},{"line_number":442,"context_line":"        for attr in attr_list:"},{"line_number":443,"context_line":"            setattr(states, attr, getattr(rpc_node, attr))"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_3dafb295","line":440,"in_reply_to":"df3967d1_2715059d","updated":"2017-08-08 14:44:51.000000000","message":"It seems better. Thanks.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a14d6e6d29ca89dc474248a675dfc6edda13a2b4","unresolved":false,"context_lines":[{"line_number":981,"context_line":"            api_utils.check_for_invalid_fields("},{"line_number":982,"context_line":"                fields,"},{"line_number":983,"context_line":"                list(node.as_dict().keys()) + [\u0027supported_power_states\u0027])"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":986,"context_line":"        # NOTE(deva): the \u0027show_password\u0027 policy setting name exists for legacy"},{"line_number":987,"context_line":"        #             purposes and can not be changed. Changing it will cause"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_66d2065f","line":984,"updated":"2017-08-01 16:41:13.000000000","message":"there is no need to change this, please see comments below.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6b68631c63fb3b6abbaba740c1e58ee26e6c591f","unresolved":false,"context_lines":[{"line_number":981,"context_line":"            api_utils.check_for_invalid_fields("},{"line_number":982,"context_line":"                fields,"},{"line_number":983,"context_line":"                list(node.as_dict().keys()) + [\u0027supported_power_states\u0027])"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":986,"context_line":"        # NOTE(deva): the \u0027show_password\u0027 policy setting name exists for legacy"},{"line_number":987,"context_line":"        #             purposes and can not be changed. Changing it will cause"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_40b5d830","line":984,"in_reply_to":"9f436f4f_612c7847","updated":"2017-08-09 05:43:23.000000000","message":"Got it, thanks","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"889cdba71d10fd10c2e69dbf5d8c2f9082140373","unresolved":false,"context_lines":[{"line_number":981,"context_line":"            api_utils.check_for_invalid_fields("},{"line_number":982,"context_line":"                fields,"},{"line_number":983,"context_line":"                list(node.as_dict().keys()) + [\u0027supported_power_states\u0027])"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":986,"context_line":"        # NOTE(deva): the \u0027show_password\u0027 policy setting name exists for legacy"},{"line_number":987,"context_line":"        #             purposes and can not be changed. Changing it will cause"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_612c7847","line":984,"in_reply_to":"df3967d1_47a7e950","updated":"2017-08-08 14:44:51.000000000","message":"This is necessary to allow to set \u0027supported_power_states\u0027 to a field parameter since this attribute is not a member of an RPC node object.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbffc4ecdd6c5e74a9fb66aeb56bcf35ac71d5ee","unresolved":false,"context_lines":[{"line_number":981,"context_line":"            api_utils.check_for_invalid_fields("},{"line_number":982,"context_line":"                fields,"},{"line_number":983,"context_line":"                list(node.as_dict().keys()) + [\u0027supported_power_states\u0027])"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        cdict \u003d pecan.request.context.to_policy_values()"},{"line_number":986,"context_line":"        # NOTE(deva): the \u0027show_password\u0027 policy setting name exists for legacy"},{"line_number":987,"context_line":"        #             purposes and can not be changed. Changing it will cause"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_47a7e950","line":984,"in_reply_to":"df3967d1_66d2065f","updated":"2017-08-02 08:25:03.000000000","message":"I disagree. Without this, supported_power_states could not be passed as a field as it would not be in the list of valid fields passed to check_for_invalid_fields.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a14d6e6d29ca89dc474248a675dfc6edda13a2b4","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 is not"},{"line_number":1017,"context_line":"        # a member of RPC node. It is got by another RPC call when necessary."},{"line_number":1018,"context_line":"        supported_power_states \u003d None"},{"line_number":1019,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":1020,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        update_state_in_older_versions(node)"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_06733ab3","line":1019,"range":{"start_line":1019,"start_character":8,"end_line":1019,"end_character":64},"updated":"2017-08-01 16:41:13.000000000","message":"it\u0027s unnecessary, the code between L932-L961 handles this logic.\nwe can just load power states and set to node here.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"6b68631c63fb3b6abbaba740c1e58ee26e6c591f","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 is not"},{"line_number":1017,"context_line":"        # a member of RPC node. It is got by another RPC call when necessary."},{"line_number":1018,"context_line":"        supported_power_states \u003d None"},{"line_number":1019,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":1020,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        update_state_in_older_versions(node)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_80c2a084","line":1019,"range":{"start_line":1019,"start_character":8,"end_line":1019,"end_character":64},"in_reply_to":"9f436f4f_9d133eb9","updated":"2017-08-09 05:43:23.000000000","message":"I see, you are caching power status for each driver, i am ok with that.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbffc4ecdd6c5e74a9fb66aeb56bcf35ac71d5ee","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 is not"},{"line_number":1017,"context_line":"        # a member of RPC node. It is got by another RPC call when necessary."},{"line_number":1018,"context_line":"        supported_power_states \u003d None"},{"line_number":1019,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":1020,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        update_state_in_older_versions(node)"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_071e816f","line":1019,"range":{"start_line":1019,"start_character":8,"end_line":1019,"end_character":64},"in_reply_to":"df3967d1_06733ab3","updated":"2017-08-02 08:25:03.000000000","message":"That\u0027s true, although by only doing this when necessary we can avoid an RPC call in some cases.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"889cdba71d10fd10c2e69dbf5d8c2f9082140373","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        # NOTE(naohirot): As an exception, \u0027supported_power_states\u0027 is not"},{"line_number":1017,"context_line":"        # a member of RPC node. It is got by another RPC call when necessary."},{"line_number":1018,"context_line":"        supported_power_states \u003d None"},{"line_number":1019,"context_line":"        if fields is None or \u0027supported_power_states\u0027 in fields:"},{"line_number":1020,"context_line":"            supported_power_states \u003d _get_supported_power_states(rpc_node)"},{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"        update_state_in_older_versions(node)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_9d133eb9","line":1019,"range":{"start_line":1019,"start_character":8,"end_line":1019,"end_character":64},"in_reply_to":"df3967d1_071e816f","updated":"2017-08-08 14:44:51.000000000","message":"I prefer avoiding an unnecessary RPC call.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a14d6e6d29ca89dc474248a675dfc6edda13a2b4","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"            show_states_links\u003dshow_states_links,"},{"line_number":1032,"context_line":"            show_portgroups\u003dshow_portgroups,"},{"line_number":1033,"context_line":"            show_volume\u003dshow_volume,"},{"line_number":1034,"context_line":"            supported_power_states\u003dsupported_power_states)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    @classmethod"},{"line_number":1037,"context_line":"    def sample(cls, expand\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_e6127658","line":1034,"range":{"start_line":1034,"start_character":12,"end_line":1034,"end_character":57},"updated":"2017-08-01 16:41:13.000000000","message":"It\u0027s odd by directly passing power states to _convert_with_links, and power states doesn\u0027t look like have a subpath. I think a more consistent way is passing boolean according to api microversion.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"889cdba71d10fd10c2e69dbf5d8c2f9082140373","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"            show_states_links\u003dshow_states_links,"},{"line_number":1032,"context_line":"            show_portgroups\u003dshow_portgroups,"},{"line_number":1033,"context_line":"            show_volume\u003dshow_volume,"},{"line_number":1034,"context_line":"            supported_power_states\u003dsupported_power_states)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    @classmethod"},{"line_number":1037,"context_line":"    def sample(cls, expand\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_61d0f851","line":1034,"range":{"start_line":1034,"start_character":12,"end_line":1034,"end_character":57},"in_reply_to":"df3967d1_e25a4b28","updated":"2017-08-08 14:44:51.000000000","message":"It would be better to set this attribute to an API node object in this method like NodeStates.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbffc4ecdd6c5e74a9fb66aeb56bcf35ac71d5ee","unresolved":false,"context_lines":[{"line_number":1031,"context_line":"            show_states_links\u003dshow_states_links,"},{"line_number":1032,"context_line":"            show_portgroups\u003dshow_portgroups,"},{"line_number":1033,"context_line":"            show_volume\u003dshow_volume,"},{"line_number":1034,"context_line":"            supported_power_states\u003dsupported_power_states)"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"    @classmethod"},{"line_number":1037,"context_line":"    def sample(cls, expand\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_e25a4b28","line":1034,"range":{"start_line":1034,"start_character":12,"end_line":1034,"end_character":57},"in_reply_to":"df3967d1_e6127658","updated":"2017-08-02 08:25:03.000000000","message":"The difference between this an show_* is that the rpc node object does not have the supported power states data already, whereas all information required to make the show_* links is already present in the node object.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"61869f08a27a2c8e0aeab5f20da8de0bfb4bc7d7","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"_SUPPORTED_POWER_STATES \u003d {}"},{"line_number":96,"context_line":"_SUPPORTED_POWER_STATES_CLASSIC \u003d {}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"_DEFAULT_RETURN_FIELDS \u003d (\u0027instance_uuid\u0027, \u0027maintenance\u0027, \u0027power_state\u0027,"},{"line_number":99,"context_line":"                          \u0027provision_state\u0027, \u0027uuid\u0027, \u0027name\u0027)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"9f436f4f_80cce089","line":97,"updated":"2017-08-09 06:20:54.000000000","message":"one dictionary would be enough, there is no name overlap between classic drivers and hardware types, but i\u0027m fine to leave it as is.","commit_id":"705b3f729e941e05f381bb14514d31034ba83481"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"61869f08a27a2c8e0aeab5f20da8de0bfb4bc7d7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            _SUPPORTED_POWER_STATES_CLASSIC[rpc_node.driver] \u003d ("},{"line_number":134,"context_line":"                _get_supported_power_states_rpc())"},{"line_number":135,"context_line":"        return _SUPPORTED_POWER_STATES_CLASSIC[rpc_node.driver]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Dynamic driver"},{"line_number":138,"context_line":"    if rpc_node.power_interface not in _SUPPORTED_POWER_STATES:"},{"line_number":139,"context_line":"        _SUPPORTED_POWER_STATES[rpc_node.power_interface] \u003d ("}],"source_content_type":"text/x-python","patch_set":36,"id":"9f436f4f_00a6b0c2","line":136,"updated":"2017-08-09 06:20:54.000000000","message":"I\u0027m suggesting insert a todo here, as we are going to remove classic drivers in queens.","commit_id":"705b3f729e941e05f381bb14514d31034ba83481"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a3508536a41fd5639fa81475f8dee6aaa9cd5ef7","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    field for the node."},{"line_number":592,"context_line":"    \"\"\""},{"line_number":593,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":594,"context_line":"            versions.MINOR_35_SUPPORTED_POWER_STATES)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"def get_controller_reserved_names(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"ff346bd7_978478d4","line":594,"updated":"2017-07-28 13:30:39.000000000","message":"Do we need to check whether we can get the supported power states via RPC here?","commit_id":"7418d2462f96878e0914321f6f2c0f1fd8195dce"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7c1d3d7762027e5bd75c19e572c0ac51464277e1","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    field for the node."},{"line_number":592,"context_line":"    \"\"\""},{"line_number":593,"context_line":"    return (pecan.request.version.minor \u003e\u003d"},{"line_number":594,"context_line":"            versions.MINOR_35_SUPPORTED_POWER_STATES)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"def get_controller_reserved_names(cls):"}],"source_content_type":"text/x-python","patch_set":32,"id":"ff346bd7_a2105801","line":594,"in_reply_to":"ff346bd7_978478d4","updated":"2017-07-28 14:02:28.000000000","message":"Though I\u0027m not sure it\u0027s appropriate to check rpc in this method, a fix seems necessary for the case \u0027supported_power_states\u0027 is specified to \u0027fields\u0027.","commit_id":"7418d2462f96878e0914321f6f2c0f1fd8195dce"}],"ironic/conductor/manager.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"d43cdfb04e201555d6228e1c6ccc49842d647fc9","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                             task, new_state, timeout\u003dpower_timeout)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    @METRICS.timer(\u0027ConductorManager.get_supported_power_states\u0027)"},{"line_number":210,"context_line":"    @messaging.expected_exceptions(exception.NodeLocked)"},{"line_number":211,"context_line":"    def get_supported_power_states(self, context, node_id):"},{"line_number":212,"context_line":"        \"\"\"RPC method to encapsulate getting node\u0027s supported power states."},{"line_number":213,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_ae60b536","line":210,"range":{"start_line":210,"start_character":4,"end_line":210,"end_character":56},"updated":"2016-10-05 23:47:36.000000000","message":"remove","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"6f318ab40dfe035251b111f040e9df9e4dff6444","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             task, new_state, timeout\u003dpower_timeout)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @METRICS.timer(\u0027ConductorManager.get_supported_power_states\u0027)"},{"line_number":245,"context_line":"    def get_supported_power_states(self, context, node_id):"},{"line_number":246,"context_line":"        \"\"\"RPC method to encapsulate getting node\u0027s supported power states."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Synchronously get node\u0027s supported power states."}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_677f5e66","line":245,"updated":"2017-01-30 19:36:36.000000000","message":"I am not sure, but what if task.node.driver do not support management? Should this method throw UnsupportedDriverExtension exception?","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a5d8f5a11c1f43ad579e408723b2ea63727a81bf","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                             task, new_state, timeout\u003dpower_timeout)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @METRICS.timer(\u0027ConductorManager.get_supported_power_states\u0027)"},{"line_number":245,"context_line":"    def get_supported_power_states(self, context, node_id):"},{"line_number":246,"context_line":"        \"\"\"RPC method to encapsulate getting node\u0027s supported power states."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        Synchronously get node\u0027s supported power states."}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_e8b2334b","line":245,"in_reply_to":"3a461143_677f5e66","updated":"2017-01-31 04:35:14.000000000","message":"\u003e I am not sure, but what if task.node.driver do not support management? \n\nThis function is nothing to do with management driver, but power driver.\n\n \u003e Should this method throw UnsupportedDriverExtension exception?\n\nNo, because all driver supports this function in the base class [1].\n\n [1] https://github.com/openstack/ironic/blob/master/ironic/drivers/base.py#L520-L527","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"}],"ironic/conductor/rpcapi.py":[{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"1e076a039b98667f0e08ed6360ca8a8be0acb510","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":191,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":194,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":195,"context_line":"                          node_id\u003dnode_id)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_2664a520","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":13},"updated":"2016-10-06 17:46:13.000000000","message":"Even though this is a local variable, I think it would be better if you rename it. In order to get it faster when reading the code.","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"702675ea94215c2b376343a5034e3457727560c1","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":191,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":194,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":195,"context_line":"                          node_id\u003dnode_id)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_fdda35e7","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":13},"in_reply_to":"1a95cdbc_2664a520","updated":"2016-10-07 02:28:21.000000000","message":"It seems that \u0027cctxt\u0027 is a kind of convention in rpcapi.py as blow, so it would be better to follow the way. WDYT?\n\nnaohirot@ubuntu:~/work/src/ironic[master]$ git grep \u0027cctxt \u003d self.client.prepare(\u0027\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.1\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.6\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.20\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.20\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.21\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.21\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.22\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.6\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.23\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.27\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.5\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.9\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.11\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.11\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.13\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.33\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.33\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.16\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.17\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.17\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.17\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.24\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.25\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.30\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.30\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.32\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.34\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dself.topic, version\u003d\u00271.31\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dself.topic, version\u003d\u00271.31\u0027)\nironic/conductor/rpcapi.py:        cctxt \u003d self.client.prepare(topic\u003dself.topic, version\u003d\u00271.31\u0027)","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"7aebaa21097947b69e4219b7da679a803b6580b9","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":191,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":192,"context_line":"        \"\"\""},{"line_number":193,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":194,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":195,"context_line":"                          node_id\u003dnode_id)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_7d1f056c","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":13},"in_reply_to":"1a95cdbc_fdda35e7","updated":"2016-10-07 02:39:59.000000000","message":"Yeah, you\u0027re right, my apologies. Better keep this way.","commit_id":"2521ab7969566809260efb7bdc7176a32e58948e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3ed886ed7aa4d0a79c7285fe1bd1285cdeabfea9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return cctxt.call(context, \u0027change_node_power_state\u0027, node_id\u003dnode_id,"},{"line_number":183,"context_line":"                          new_state\u003dnew_state, timeout\u003dtimeout)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def get_supported_power_states(self, context, node_id, topic\u003dNone):"},{"line_number":186,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_176d9432","line":185,"updated":"2016-11-07 09:08:16.000000000","message":"This require rpc version bump.","commit_id":"f77c40850dd793bc1483b11c59ff1f98a62c935a"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"e13561d8ce7be190472055fe1995e01bb48a4e46","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        return cctxt.call(context, \u0027change_node_power_state\u0027, node_id\u003dnode_id,"},{"line_number":183,"context_line":"                          new_state\u003dnew_state, timeout\u003dtimeout)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def get_supported_power_states(self, context, node_id, topic\u003dNone):"},{"line_number":186,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_faec8591","line":185,"in_reply_to":"9a629dbe_176d9432","updated":"2016-11-07 09:29:53.000000000","message":"The base patch [1] bumped the rpc version.\n\n [1] https://review.openstack.org/#/c/216730/21/ironic/conductor/rpcapi.py@84","commit_id":"f77c40850dd793bc1483b11c59ff1f98a62c935a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"59061240fef871c1b8f454b3e092690a4319fc23","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":212,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":215,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":216,"context_line":"                          node_id\u003dnode_id)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_0a837705","line":214,"updated":"2017-01-26 16:17:19.000000000","message":"Doesn\u0027t this require an RPCAPI version bump to 1.40?","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"892fadeb44b0b200e24c57a1e647b9335bb2aa99","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":212,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":215,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":216,"context_line":"                          node_id\u003dnode_id)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_d62e5ff9","line":214,"in_reply_to":"3a461143_0a837705","updated":"2017-01-27 02:25:29.000000000","message":"I\u0027ll fix that, it should be 1.39.\n\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L89-L90","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"433985c8bbedb27cfb6b6f5a813705a5b23f4558","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":212,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":215,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":216,"context_line":"                          node_id\u003dnode_id)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_d8b2d005","line":214,"in_reply_to":"3a461143_55b7a585","updated":"2017-01-30 02:26:00.000000000","message":"I\u0027ll fix that.","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"282d164fcd062c50b23dfb89d00efe502309b5da","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":212,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003d\u00271.35\u0027)"},{"line_number":215,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":216,"context_line":"                          node_id\u003dnode_id)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_55b7a585","line":214,"in_reply_to":"3a461143_d62e5ff9","updated":"2017-01-27 19:16:23.000000000","message":"This patch is adding a new RPC call, does that not require a version bump? Looks like there is already 1.40 so it will need to be 1.41.","commit_id":"b01ddad84d8b0a4eaf8253d919c456911d8c3634"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"dbff51e567ccd76d3a6def718d6e4241d1c6f913","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":94,"context_line":"    RPC_API_VERSION \u003d \u00271.39\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":97,"context_line":"        super(ConductorAPI, self).__init__()"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_4369c18a","line":94,"updated":"2017-01-27 12:48:57.000000000","message":"RPC version bump please.","commit_id":"ca5269dbd3608ccc0481b3dce44672452d370bbc"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"6f0b1cab52be77b564bf863de403d5457fdf8811","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    \"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # NOTE(rloo): This must be in sync with manager.ConductorManager\u0027s."},{"line_number":94,"context_line":"    RPC_API_VERSION \u003d \u00271.39\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __init__(self, topic\u003dNone):"},{"line_number":97,"context_line":"        super(ConductorAPI, self).__init__()"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_d597f937","line":94,"in_reply_to":"3a461143_4369c18a","updated":"2017-01-30 02:11:43.000000000","message":"I\u0027ll fix that.","commit_id":"ca5269dbd3608ccc0481b3dce44672452d370bbc"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"6f318ab40dfe035251b111f040e9df9e4dff6444","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        return cctxt.call(context, \u0027change_node_power_state\u0027, node_id\u003dnode_id,"},{"line_number":206,"context_line":"                          new_state\u003dnew_state, timeout\u003dtimeout)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_supported_power_states(self, context, node_id, topic\u003dNone):"},{"line_number":209,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_ac120d55","line":208,"updated":"2017-01-30 19:36:36.000000000","message":"what will happen if node is acquired by some other conductor? If it raises some exception should it be commented here?","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"e5704b43a71997141570581800d8daab36392784","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        return cctxt.call(context, \u0027change_node_power_state\u0027, node_id\u003dnode_id,"},{"line_number":206,"context_line":"                          new_state\u003dnew_state, timeout\u003dtimeout)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_supported_power_states(self, context, node_id, topic\u003dNone):"},{"line_number":209,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_7c118c5c","line":208,"in_reply_to":"3a461143_3a72c111","updated":"2017-01-31 16:54:26.000000000","message":"There is NodeLocked exception which I thought, but if supported_power_states do not take exclusive locks then I guess not needed.","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a5d8f5a11c1f43ad579e408723b2ea63727a81bf","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        return cctxt.call(context, \u0027change_node_power_state\u0027, node_id\u003dnode_id,"},{"line_number":206,"context_line":"                          new_state\u003dnew_state, timeout\u003dtimeout)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_supported_power_states(self, context, node_id, topic\u003dNone):"},{"line_number":209,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        :param context: request context."}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_3a72c111","line":208,"in_reply_to":"3a461143_ac120d55","updated":"2017-01-31 04:35:14.000000000","message":"\u003e what will happen if node is acquired by some other conductor? \n\nNothing will happen, because supported_power_states doesn\u0027t take exclusive lock.\n\n \u003e If it raises some exception should it be commented here?\n\nYes, but what kind of exception is that?\nMy understanding is that there is no such exception.","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"6f318ab40dfe035251b111f040e9df9e4dff6444","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        :param context: request context."},{"line_number":212,"context_line":"        :param node_id: node id or uuid."},{"line_number":213,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":214,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":215,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_a15db648","line":212,"updated":"2017-01-30 19:36:36.000000000","message":"nit: param topic needs to be added just to be consistent with other methods.","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a5d8f5a11c1f43ad579e408723b2ea63727a81bf","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        \"\"\"Get a list of the supported power states."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        :param context: request context."},{"line_number":212,"context_line":"        :param node_id: node id or uuid."},{"line_number":213,"context_line":"        :returns: A list with the supported power states defined"},{"line_number":214,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":215,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_ba37914b","line":212,"in_reply_to":"3a461143_a15db648","updated":"2017-01-31 04:35:14.000000000","message":"Good catch! I\u0027ll fix that.","commit_id":"eee61f2d052e27d493666ba657602fdbda57b3c9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"a14d6e6d29ca89dc474248a675dfc6edda13a2b4","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        version \u003d \u00271.42\u0027"},{"line_number":232,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":233,"context_line":"            return None"},{"line_number":234,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003dversion)"},{"line_number":235,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":236,"context_line":"                          node_id\u003dnode_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_468dc22f","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":23},"updated":"2017-08-01 16:41:13.000000000","message":"i don\u0027t think it\u0027s required, the request with lower microversion will not reach here, and conductor would not have a version lower to api.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbffc4ecdd6c5e74a9fb66aeb56bcf35ac71d5ee","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        version \u003d \u00271.42\u0027"},{"line_number":232,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":233,"context_line":"            return None"},{"line_number":234,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003dversion)"},{"line_number":235,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":236,"context_line":"                          node_id\u003dnode_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"df3967d1_e2448b1d","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":23},"in_reply_to":"df3967d1_468dc22f","updated":"2017-08-02 08:25:03.000000000","message":"+1. Ruby argued against putting this kind of logic in the RPC stub methods, and ensuring that the caller handles it explicitly.\n\nI agree that we do already handle this in the API, but not due to the API microversion - it\u0027s due to checking can_get_supported_power_states() in api.utils.allow_supported_power_states(). We shouldn\u0027t conflate the API and RPC versions here.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"889cdba71d10fd10c2e69dbf5d8c2f9082140373","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                  in :mod:`ironic.common.states`."},{"line_number":230,"context_line":"        \"\"\""},{"line_number":231,"context_line":"        version \u003d \u00271.42\u0027"},{"line_number":232,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":233,"context_line":"            return None"},{"line_number":234,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dtopic or self.topic, version\u003dversion)"},{"line_number":235,"context_line":"        return cctxt.call(context, \u0027get_supported_power_states\u0027,"},{"line_number":236,"context_line":"                          node_id\u003dnode_id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9f436f4f_e4ecf6f4","line":233,"range":{"start_line":232,"start_character":0,"end_line":233,"end_character":23},"in_reply_to":"df3967d1_e2448b1d","updated":"2017-08-08 14:44:51.000000000","message":"I agree that an RPC caller should confirm if the RPC is available.","commit_id":"89d2ed2367700085017c7b26eddb419d24c6a50d"}],"ironic/tests/unit/api/v1/test_nodes.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3d5b555ce3b1a8199c2881b71706dc98e4bf6db3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3a461143_5b575625","updated":"2017-02-01 12:02:02.000000000","message":"How about a test that checks that a previous API version does not return the supported power states?","commit_id":"ab84de05a32f2b966e5c36cc0a677e5a13c16f76"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"a1104d4805a2f6cbc5150be26c0822c1c517bf15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3a461143_ef4bc05d","in_reply_to":"3a461143_5b575625","updated":"2017-02-02 02:54:17.000000000","message":"Okay, I\u0027ll add that.","commit_id":"ab84de05a32f2b966e5c36cc0a677e5a13c16f76"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"57f4566d69a1127b2f9005e42ac90f7ee1f4e8f5","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        new_data \u003d self.get_json("},{"line_number":448,"context_line":"            \u0027/nodes/detail\u0027, headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":449,"context_line":"        self.assertEqual([\"power on\", \"power off\", \"rebooting\"],"},{"line_number":450,"context_line":"                         new_data[\u0027nodes\u0027][0][\u0027supported_power_states\u0027])"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def test_many(self):"},{"line_number":453,"context_line":"        nodes \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_e5d05acc","line":450,"range":{"start_line":450,"start_character":35,"end_line":450,"end_character":40},"updated":"2017-02-03 02:40:24.000000000","message":"Can we create a separate test for the two asserts? A unit test should only check for a single assert.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"f65238d8e95861ca9fffdf803503423ef7fcf23f","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        new_data \u003d self.get_json("},{"line_number":448,"context_line":"            \u0027/nodes/detail\u0027, headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":449,"context_line":"        self.assertEqual([\"power on\", \"power off\", \"rebooting\"],"},{"line_number":450,"context_line":"                         new_data[\u0027nodes\u0027][0][\u0027supported_power_states\u0027])"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def test_many(self):"},{"line_number":453,"context_line":"        nodes \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_77fc1b3f","line":450,"range":{"start_line":450,"start_character":35,"end_line":450,"end_character":40},"in_reply_to":"1a430d35_576f1f92","updated":"2017-02-03 17:44:15.000000000","message":"Makes sense","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"324fe5ea86909cbef8614be9219757f05844bed9","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        new_data \u003d self.get_json("},{"line_number":448,"context_line":"            \u0027/nodes/detail\u0027, headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":449,"context_line":"        self.assertEqual([\"power on\", \"power off\", \"rebooting\"],"},{"line_number":450,"context_line":"                         new_data[\u0027nodes\u0027][0][\u0027supported_power_states\u0027])"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def test_many(self):"},{"line_number":453,"context_line":"        nodes \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_10a66bc1","line":450,"range":{"start_line":450,"start_character":35,"end_line":450,"end_character":40},"in_reply_to":"1a430d35_576f1f92","updated":"2017-02-03 16:22:38.000000000","message":"Yeah, this seems fine to me.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b39fe00c1cdc2b09e038e0df413c82b16c3a28ad","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        new_data \u003d self.get_json("},{"line_number":448,"context_line":"            \u0027/nodes/detail\u0027, headers\u003d{api_base.Version.string: \u00271.32\u0027})"},{"line_number":449,"context_line":"        self.assertEqual([\"power on\", \"power off\", \"rebooting\"],"},{"line_number":450,"context_line":"                         new_data[\u0027nodes\u0027][0][\u0027supported_power_states\u0027])"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def test_many(self):"},{"line_number":453,"context_line":"        nodes \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_576f1f92","line":450,"range":{"start_line":450,"start_character":35,"end_line":450,"end_character":40},"in_reply_to":"1a430d35_e5d05acc","updated":"2017-02-03 04:57:44.000000000","message":"Rushil, \n\nThanks for the kind review.\nI think it depends on the context.\nIn this particular case, it\u0027s would be better to follow the convention of the other test_hide_fields_in_newer_versions_* cases.\nOtherwise we should refactor all test cases so as to be consistent by issuing another bug report.\n\nBest regards,\nNaohiro","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"57f4566d69a1127b2f9005e42ac90f7ee1f4e8f5","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        new_data \u003d self.get_json(\u0027/nodes/%s/states\u0027 % node.uuid,"},{"line_number":720,"context_line":"                                 headers\u003d{api_base.Version.string: \"1.32\"})"},{"line_number":721,"context_line":"        self.assertEqual([\"power on\", \"power off\", \"rebooting\"],"},{"line_number":722,"context_line":"                         new_data[\u0027supported_power_states\u0027])"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def test_node_by_instance_uuid(self):"},{"line_number":725,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_25db42ef","line":722,"range":{"start_line":722,"start_character":0,"end_line":722,"end_character":25},"updated":"2017-02-03 02:40:24.000000000","message":"Same comment as above.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"b39fe00c1cdc2b09e038e0df413c82b16c3a28ad","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        new_data \u003d self.get_json(\u0027/nodes/%s/states\u0027 % node.uuid,"},{"line_number":720,"context_line":"                                 headers\u003d{api_base.Version.string: \"1.32\"})"},{"line_number":721,"context_line":"        self.assertEqual([\"power on\", \"power off\", \"rebooting\"],"},{"line_number":722,"context_line":"                         new_data[\u0027supported_power_states\u0027])"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def test_node_by_instance_uuid(self):"},{"line_number":725,"context_line":"        node \u003d obj_utils.create_test_node("}],"source_content_type":"text/x-python","patch_set":20,"id":"1a430d35_7776db3f","line":722,"range":{"start_line":722,"start_character":0,"end_line":722,"end_character":25},"in_reply_to":"1a430d35_25db42ef","updated":"2017-02-03 04:57:44.000000000","message":"see the answer above.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"}],"ironic/tests/unit/conductor/test_manager.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"10814099b4457802769397e0b053ca6fafaa85e4","unresolved":false,"context_lines":[{"line_number":3616,"context_line":"        power_states \u003d self.service.get_supported_power_states("},{"line_number":3617,"context_line":"            self.context, node.uuid)"},{"line_number":3618,"context_line":""},{"line_number":3619,"context_line":"        self.assertEqual([\u0027power on\u0027, \u0027power off\u0027, \u0027rebooting\u0027],"},{"line_number":3620,"context_line":"                         power_states)"},{"line_number":3621,"context_line":""},{"line_number":3622,"context_line":"    def test_get_supported_power_states_soft(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f044301_f8f32a09","line":3619,"updated":"2017-05-08 20:16:42.000000000","message":"I wonder if these should be:\n\n states.POWER_ON, states.POWER_OFF, ...\n\nWhat do you think?","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f753ceaafee8db6d962e11be9dbf0f8e35ef99dd","unresolved":false,"context_lines":[{"line_number":3616,"context_line":"        power_states \u003d self.service.get_supported_power_states("},{"line_number":3617,"context_line":"            self.context, node.uuid)"},{"line_number":3618,"context_line":""},{"line_number":3619,"context_line":"        self.assertEqual([\u0027power on\u0027, \u0027power off\u0027, \u0027rebooting\u0027],"},{"line_number":3620,"context_line":"                         power_states)"},{"line_number":3621,"context_line":""},{"line_number":3622,"context_line":"    def test_get_supported_power_states_soft(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"df140735_c2ec53f5","line":3619,"in_reply_to":"3f044301_f8f32a09","updated":"2017-05-28 12:57:49.000000000","message":"I agree.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"}],"ironic/tests/unit/conductor/test_rpcapi.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"61869f08a27a2c8e0aeab5f20da8de0bfb4bc7d7","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        mock_can_send.return_value \u003d can_send"},{"line_number":505,"context_line":"        rpcapi \u003d conductor_rpcapi.ConductorAPI(topic\u003d\u0027fake-topic\u0027)"},{"line_number":506,"context_line":"        self.assertEqual(can_send, rpcapi.can_get_supported_power_states())"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def test_can_get_supported_power_states_true(self):"},{"line_number":509,"context_line":"        self._test_can_get_supported_power_states(True)"},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"9f436f4f_40fa7842","line":507,"updated":"2017-08-09 06:20:54.000000000","message":"can we add a rpc version check here? otherwise the test is fully mocked. L149-162 in this file can be a reference.","commit_id":"705b3f729e941e05f381bb14514d31034ba83481"}],"releasenotes/notes/supported-power-states-c68a88dceae6e5ea.yaml":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"678ff192c7d10f02b869afe3cc9c57be9af23462","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":4,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to show"},{"line_number":5,"context_line":"    supported_power_states response field for a node in Ironic API microversion"},{"line_number":6,"context_line":"    1.32."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1a430d35_3ecee883","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":9},"updated":"2017-02-03 09:00:54.000000000","message":"Can we rephrase it to something like \"This feature is supported in microversion 1.32 and above\" to make it more readable.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"f65238d8e95861ca9fffdf803503423ef7fcf23f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":4,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to show"},{"line_number":5,"context_line":"    supported_power_states response field for a node in Ironic API microversion"},{"line_number":6,"context_line":"    1.32."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1a430d35_15bc9804","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":9},"in_reply_to":"1a430d35_10bf4bd1","updated":"2017-02-03 17:44:15.000000000","message":"+1","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"96c0cf104fac4105c7716c53ebf428143ee25c1f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":4,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to show"},{"line_number":5,"context_line":"    supported_power_states response field for a node in Ironic API microversion"},{"line_number":6,"context_line":"    1.32."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1a430d35_f103970d","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":9},"in_reply_to":"1a430d35_15bc9804","updated":"2017-02-03 21:41:46.000000000","message":"+1 Agree with Madhuri. Also it would be better to list for what APIs, like, \"...response field for GET /v1/nodes and something\". If there are various APIs, then creating bullets and listing them would be good. http://docs.openstack.org/releasenotes/ironic/current-series.html","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"324fe5ea86909cbef8614be9219757f05844bed9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":4,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to show"},{"line_number":5,"context_line":"    supported_power_states response field for a node in Ironic API microversion"},{"line_number":6,"context_line":"    1.32."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1a430d35_10bf4bd1","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":9},"in_reply_to":"1a430d35_3ecee883","updated":"2017-02-03 16:22:38.000000000","message":"yup, 1.32 and later","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1b1338d8b9e7b193613a1411736488301d8535a8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for \"Create Node\", \"List Nodes\", \"List Nodes Detailed\","},{"line_number":4,"context_line":"    \"Show Node Details\", \"Update Node\" and \"Node State Summary\" APIs to show"},{"line_number":5,"context_line":"    supported_power_states response field for a node in Ironic API microversion"},{"line_number":6,"context_line":"    1.32."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1a430d35_5896314d","line":6,"range":{"start_line":5,"start_character":56,"end_line":6,"end_character":9},"in_reply_to":"1a430d35_f103970d","updated":"2017-02-06 02:07:23.000000000","message":"I\u0027ll fix that.","commit_id":"76b9c205ec55b5ccc4675e81d2e7901196b344a5"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"1f207fbba04f91a00fb7812db03c86b1b56827cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``supported_power_states`` response field in the following Ironic APIs."},{"line_number":5,"context_line":"    This feature is supported in Ironic API microversion 1.32 and above."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * Create Node, `/v1/nodes`"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1a430d35_68b131e1","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2017-02-06 21:39:00.000000000","message":"In case of posting another patch, please consider:\n\nnit: s/Add/Adds","commit_id":"dcb4484f87425e0dee098efaee4b3a0458012aaa"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f66e60f1b4fb8352e8df641c2f6419f315c40522","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``supported_power_states`` response field in the following Ironic APIs."},{"line_number":5,"context_line":"    This feature is supported in Ironic API microversion 1.32 and above."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * Create Node, `/v1/nodes`"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1a430d35_fb507fd6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"1a430d35_68b131e1","updated":"2017-02-07 04:16:04.000000000","message":"Thanks, I\u0027ll fix that if another patch is necessary.","commit_id":"dcb4484f87425e0dee098efaee4b3a0458012aaa"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"296834d40f059d045bc28e63249a5a528beafb56","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``supported_power_states`` response field in the following Ironic APIs."},{"line_number":5,"context_line":"    This feature is supported in Ironic API microversion 1.32 and above."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * Create Node, `/v1/nodes`"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fa31d9ce_c2592600","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":80},"updated":"2017-02-13 10:59:09.000000000","message":"field in the responses of the requests to the following API endpoints.","commit_id":"7753d8ffd9c1c98e031c5870d224421ce913d218"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"8ef6c7f434a28f6a599702a9b70690b51671422e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds ``supported_power_states`` response field in the following Ironic APIs."},{"line_number":5,"context_line":"    This feature is supported in Ironic API microversion 1.32 and above."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * Create Node, `/v1/nodes`"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fa31d9ce_e4953387","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":80},"in_reply_to":"fa31d9ce_c2592600","updated":"2017-02-14 06:34:54.000000000","message":"I\u0027ll fix that.","commit_id":"7753d8ffd9c1c98e031c5870d224421ce913d218"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"296834d40f059d045bc28e63249a5a528beafb56","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds ``supported_power_states`` response field in the following Ironic APIs."},{"line_number":5,"context_line":"    This feature is supported in Ironic API microversion 1.32 and above."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * Create Node, `/v1/nodes`"},{"line_number":8,"context_line":"    * List Nodes, `/v1/nodes`"},{"line_number":9,"context_line":"    * List Nodes Detailed, `/v1/nodes/detail`"},{"line_number":10,"context_line":"    * Show Node Details, `/v1/nodes/{node_ident}`"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fa31d9ce_226f6293","line":7,"updated":"2017-02-13 10:59:09.000000000","message":"Please add the method then, like `POST /v1/nodes` etc.","commit_id":"7753d8ffd9c1c98e031c5870d224421ce913d218"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"8ef6c7f434a28f6a599702a9b70690b51671422e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds ``supported_power_states`` response field in the following Ironic APIs."},{"line_number":5,"context_line":"    This feature is supported in Ironic API microversion 1.32 and above."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * Create Node, `/v1/nodes`"},{"line_number":8,"context_line":"    * List Nodes, `/v1/nodes`"},{"line_number":9,"context_line":"    * List Nodes Detailed, `/v1/nodes/detail`"},{"line_number":10,"context_line":"    * Show Node Details, `/v1/nodes/{node_ident}`"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"fa31d9ce_a4f6dbf6","line":7,"in_reply_to":"fa31d9ce_226f6293","updated":"2017-02-14 06:34:54.000000000","message":"I\u0027ll fix that.","commit_id":"7753d8ffd9c1c98e031c5870d224421ce913d218"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"281059a8741dadd397d822513fb84a15eceb2a3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":10,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"},{"line_number":11,"context_line":"    * Update Node, `PATCH /v1/nodes/{node_ident}`"},{"line_number":12,"context_line":"    * Node State Summary, `GET /v1/nodes/{node_ident}/states`"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"fa31d9ce_4bbf9c60","line":12,"updated":"2017-02-15 14:45:13.000000000","message":"Ditto in webapi-version-history.rst. I think the release note should be less confusing and just points out what the change is exactly.","commit_id":"0d60e7850e43e3816b9c6dc05cf621b22e91307f"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"3ab6ba0e0e37aa3aaeb5a6b3f864e1b64f6c5b30","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":10,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"},{"line_number":11,"context_line":"    * Update Node, `PATCH /v1/nodes/{node_ident}`"},{"line_number":12,"context_line":"    * Node State Summary, `GET /v1/nodes/{node_ident}/states`"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"fa31d9ce_3b61c105","line":12,"in_reply_to":"fa31d9ce_4bbf9c60","updated":"2017-02-16 02:26:20.000000000","message":"I\u0027ll fix that.","commit_id":"0d60e7850e43e3816b9c6dc05cf621b22e91307f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new field called ``supported_power_states`` to the Node object."},{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"da36d5c6_b556f5cb","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":74},"updated":"2017-02-23 14:19:55.000000000","message":"s/Node object/Node API object","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new field called ``supported_power_states`` to the Node object."},{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"da36d5c6_ce7625a3","line":4,"range":{"start_line":4,"start_character":62,"end_line":4,"end_character":74},"in_reply_to":"da36d5c6_b556f5cb","updated":"2017-02-27 02:59:27.000000000","message":"I\u0027ll fix that.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"298ae300895c89e2de843794707fb8bd30070875","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node, `POST /v1/nodes`"},{"line_number":10,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":11,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"da36d5c6_d80b9dd4","line":8,"updated":"2017-02-23 14:19:55.000000000","message":"Please mention also that rpcapi version bumped.","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"ecb4899efa6a8c9dcb86f1f35a6128a14e588852","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node, `POST /v1/nodes`"},{"line_number":10,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":11,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"da36d5c6_2e2261a3","line":8,"in_reply_to":"da36d5c6_d80b9dd4","updated":"2017-02-27 02:59:27.000000000","message":"I think release note should not mention internal changes, but external changes which Ironic user is affected.\nAs a fact, I couldn\u0027t find any release note which mentions rpc version [1].\n\n [1] https://docs.openstack.org/releasenotes/ironic/unreleased.html","commit_id":"48a4d4348aa8a49244a0c05c6644e8301227ef7c"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"10814099b4457802769397e0b053ca6fafaa85e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node, `POST /v1/nodes`"},{"line_number":10,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":11,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"},{"line_number":12,"context_line":"    * Update Node, `PATCH /v1/nodes/{node_ident}`"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3f044301_d8250ead","line":9,"updated":"2017-05-08 20:16:42.000000000","message":"nit: for these I think colon would be nicer looking than comma\n\n * Create Node: ```POST /v1/nodes```\n\ns/,/:/","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f753ceaafee8db6d962e11be9dbf0f8e35ef99dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node, `POST /v1/nodes`"},{"line_number":10,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":11,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"},{"line_number":12,"context_line":"    * Update Node, `PATCH /v1/nodes/{node_ident}`"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"df140735_a2bb9fe3","line":9,"in_reply_to":"3f044301_d8250ead","updated":"2017-05-28 12:57:49.000000000","message":"Done","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"10814099b4457802769397e0b053ca6fafaa85e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node, `POST /v1/nodes`"},{"line_number":10,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":11,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"},{"line_number":12,"context_line":"    * Update Node, `PATCH /v1/nodes/{node_ident}`"},{"line_number":13,"context_line":"    * Node State Summary, `GET /v1/nodes/{node_ident}/states`"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"3f044301_5831feeb","line":10,"updated":"2017-05-08 20:16:42.000000000","message":"Please use ``` as it makes it code style.  Just ` makes it italic.","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"f753ceaafee8db6d962e11be9dbf0f8e35ef99dd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node, `POST /v1/nodes`"},{"line_number":10,"context_line":"    * List Nodes Detailed, `GET /v1/nodes/detail`"},{"line_number":11,"context_line":"    * Show Node Details, `GET /v1/nodes/{node_ident}`"},{"line_number":12,"context_line":"    * Update Node, `PATCH /v1/nodes/{node_ident}`"},{"line_number":13,"context_line":"    * Node State Summary, `GET /v1/nodes/{node_ident}/states`"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"df140735_82c09b52","line":10,"in_reply_to":"3f044301_5831feeb","updated":"2017-05-28 12:57:49.000000000","message":"Done","commit_id":"e0257bc7b36f335cb409074167751b58ed39ff7e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e718e812fb5d037cb76d43580d1eb66c90ba0ca9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds a new field called ``supported_power_states`` to the Node API object."},{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node: ```POST /v1/nodes```"},{"line_number":10,"context_line":"    * List Nodes Detailed: ```GET /v1/nodes/detail```"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ff346bd7_687507cb","line":7,"updated":"2017-07-26 14:40:03.000000000","message":"1.35","commit_id":"425beeb6d4163086345a37f47895f5e5d230ef67"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"c9cc7dc3645f28f370cd08614fb9b282facaa775","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds a new field called ``supported_power_states`` to the Node API object."},{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.32 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node: ```POST /v1/nodes```"},{"line_number":10,"context_line":"    * List Nodes Detailed: ```GET /v1/nodes/detail```"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"ff346bd7_17a648ac","line":7,"in_reply_to":"ff346bd7_687507cb","updated":"2017-07-28 13:27:38.000000000","message":"Done\nThanks.","commit_id":"425beeb6d4163086345a37f47895f5e5d230ef67"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"61869f08a27a2c8e0aeab5f20da8de0bfb4bc7d7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The new field holds a list with all the allowed power states for that node."},{"line_number":6,"context_line":"    The following API endpoints support this feature in Ironic API"},{"line_number":7,"context_line":"    microversion 1.35 and above."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    * Create Node: ```POST /v1/nodes```"},{"line_number":10,"context_line":"    * List Nodes Detailed: ```GET /v1/nodes/detail```"},{"line_number":11,"context_line":"    * Show Node Details: ```GET /v1/nodes/{node_ident}```"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"9f436f4f_2063f41c","line":8,"updated":"2017-08-09 06:20:54.000000000","message":"worth to note this field is readonly.","commit_id":"705b3f729e941e05f381bb14514d31034ba83481"}]}
