)]}'
{"ironic_tempest_plugin/config.py":[{"author":{"_account_id":14943,"name":"Caio Oliveira","email":"caiobo@lsd.ufcg.edu.br","username":"caiobo"},"change_message_id":"cff753b55d6430ab387242f04a9fb47e2e33c6ee","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    cfg.BoolOpt(\u0027use_provision_network\u0027,"},{"line_number":85,"context_line":"                default\u003dFalse,"},{"line_number":86,"context_line":"                help\u003d\"Whether the Ironic/Neutron tenant isolation is enabled\"),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027use_portgroups\u0027,"},{"line_number":88,"context_line":"                help\u003d\"Whether the Ironic portgroups are enabled.\"),"},{"line_number":89,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_fcc40a60","line":87,"updated":"2016-10-06 18:14:00.000000000","message":"Why not adding here a default option too?","commit_id":"34a1ef1387563297c31e1e770432ebae1c12751c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2c181486031a5ac7ccc91324784a9548508b7bc3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    cfg.BoolOpt(\u0027use_provision_network\u0027,"},{"line_number":85,"context_line":"                default\u003dFalse,"},{"line_number":86,"context_line":"                help\u003d\"Whether the Ironic/Neutron tenant isolation is enabled\"),"},{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027use_portgroups\u0027,"},{"line_number":88,"context_line":"                help\u003d\"Whether the Ironic portgroups are enabled.\"),"},{"line_number":89,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_35190923","line":87,"in_reply_to":"1a95cdbc_fcc40a60","updated":"2016-10-07 10:51:21.000000000","message":"Done","commit_id":"34a1ef1387563297c31e1e770432ebae1c12751c"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f040746952952290c66eae37145eec14d3e44543","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027use_portgroups\u0027,"},{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\"Whether the Ironic portgroups are enabled.\"),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"7a3c09a3_70917a52","line":90,"updated":"2017-01-19 00:04:41.000000000","message":"I have an impression that if \u0027ref\u0027 was replaced by id (or uuid?) it would be clearer","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"257ef862d48b8a6fb408362be52235b59b0a3a6f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027use_portgroups\u0027,"},{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\"Whether the Ironic portgroups are enabled.\"),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"fa31d9ce_1b1e8bba","line":90,"in_reply_to":"7a3c09a3_70917a52","updated":"2017-02-10 15:00:04.000000000","message":"+1","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ea7c365fd9738f97d51edd1d9d40faf994489ba8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.BoolOpt(\u0027use_portgroups\u0027,"},{"line_number":88,"context_line":"                default\u003dFalse,"},{"line_number":89,"context_line":"                help\u003d\"Whether the Ironic portgroups are enabled.\"),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"da36d5c6_bde1099d","line":90,"in_reply_to":"fa31d9ce_1b1e8bba","updated":"2017-02-27 20:42:30.000000000","message":"Yes, please specify UUID if that\u0027s indeed what\u0027s allowed. This makes me think that I could use a flavor by name or UUID.","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ea7c365fd9738f97d51edd1d9d40faf994489ba8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                help\u003d\"Whether the Ironic portgroups are enabled.\"),"},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"},{"line_number":94,"context_line":"               default\u003dNone,"},{"line_number":95,"context_line":"               help\u003d\u0027Image UUID that is used for portgroup test.\u0027),"}],"source_content_type":"text/x-python","patch_set":33,"id":"da36d5c6_3dec398f","line":92,"updated":"2017-02-27 20:42:30.000000000","message":"Please specify flavor UUID here as well.","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f040746952952290c66eae37145eec14d3e44543","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"},{"line_number":94,"context_line":"               default\u003dNone,"},{"line_number":95,"context_line":"               help\u003d\u0027Image UUID that is used for portgroup test.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027portgroup_mode\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"7a3c09a3_909ee661","line":93,"updated":"2017-01-19 00:04:41.000000000","message":"ref/uuid","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"257ef862d48b8a6fb408362be52235b59b0a3a6f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"},{"line_number":94,"context_line":"               default\u003dNone,"},{"line_number":95,"context_line":"               help\u003d\u0027Image UUID that is used for portgroup test.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027portgroup_mode\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"fa31d9ce_fb77f7ff","line":93,"in_reply_to":"7a3c09a3_909ee661","updated":"2017-02-10 15:00:04.000000000","message":"+1","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ea7c365fd9738f97d51edd1d9d40faf994489ba8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    cfg.StrOpt(\u0027portgroups_flavor_ref\u0027,"},{"line_number":91,"context_line":"               default\u003dNone,"},{"line_number":92,"context_line":"               help\u003d\u0027Nova flavor that is used for portgroups tests.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027portgroups_image_ref\u0027,"},{"line_number":94,"context_line":"               default\u003dNone,"},{"line_number":95,"context_line":"               help\u003d\u0027Image UUID that is used for portgroup test.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027portgroup_mode\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"da36d5c6_5d01ed38","line":93,"in_reply_to":"fa31d9ce_fb77f7ff","updated":"2017-02-27 20:42:30.000000000","message":"+1","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"ea7c365fd9738f97d51edd1d9d40faf994489ba8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"               help\u003d\u0027Image UUID that is used for portgroup test.\u0027),"},{"line_number":96,"context_line":"    cfg.StrOpt(\u0027portgroup_mode\u0027,"},{"line_number":97,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":98,"context_line":"               help\u003d\u0027Portgroup mode to check in the tests.\u0027),"},{"line_number":99,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":33,"id":"da36d5c6_5d764dd9","line":98,"updated":"2017-02-27 20:42:30.000000000","message":"nit: it might be good to specify available options here - e.g. balance-rr, balance-xor, etc.\n\nor \"See kernel documentation on bonding for possible options.\" if this isn\u0027t a strict set","commit_id":"0154efb6eb29c6f2f76909393b404a8d8827e2a9"}],"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"cb7cc576e03a7388ff4ad8c5f7432f809816d951","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        dest.validate_authentication()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def boot_instance(self, clients\u003dNone, keypair\u003dNone,"},{"line_number":149,"context_line":"                      net_id\u003dNone, fixed_ip\u003dNone, flavor_ref\u003dNone,"},{"line_number":150,"context_line":"                      image_ref\u003dNone):"},{"line_number":151,"context_line":"        if clients is None:"},{"line_number":152,"context_line":"            servers_client \u003d self.servers_client"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_3c833ece","line":149,"range":{"start_line":149,"start_character":50,"end_line":149,"end_character":65},"updated":"2016-11-07 19:09:56.000000000","message":"Why not have CONF.compute.flavor_ref be the default value of flavor_ref? Then you don\u0027t need to set conditionally below and can use flavor_ref as the value of flavor to the calls below.","commit_id":"84f52d4fb1610e85ab32de242727ae3684cdc7b0"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"cb7cc576e03a7388ff4ad8c5f7432f809816d951","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        if keypair is None:"},{"line_number":156,"context_line":"            keypair \u003d self.keypair"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        flavor \u003d flavor_ref or CONF.compute.flavor_ref"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if any([net_id, fixed_ip]):"},{"line_number":161,"context_line":"            network \u003d {}"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_9c6a8a19","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":54},"updated":"2016-11-07 19:09:56.000000000","message":"See above comment (this would be deleted)","commit_id":"84f52d4fb1610e85ab32de242727ae3684cdc7b0"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"cb7cc576e03a7388ff4ad8c5f7432f809816d951","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":168,"context_line":"                networks\u003d[network],"},{"line_number":169,"context_line":"                clients\u003dclients,"},{"line_number":170,"context_line":"                flavor\u003dflavor,"},{"line_number":171,"context_line":"                image_id\u003dimage_ref,"},{"line_number":172,"context_line":"            )"},{"line_number":173,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_fc5f0673","line":170,"range":{"start_line":170,"start_character":16,"end_line":170,"end_character":29},"updated":"2016-11-07 19:09:56.000000000","message":"See above comment (this would become flavor\u003dflavor_ref)","commit_id":"84f52d4fb1610e85ab32de242727ae3684cdc7b0"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"cb7cc576e03a7388ff4ad8c5f7432f809816d951","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            instance \u003d self.create_server("},{"line_number":175,"context_line":"                key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":176,"context_line":"                clients\u003dclients,"},{"line_number":177,"context_line":"                flavor\u003dflavor,"},{"line_number":178,"context_line":"                image_id\u003dimage_ref,"},{"line_number":179,"context_line":"            )"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a629dbe_5c5f1272","line":177,"range":{"start_line":177,"start_character":15,"end_line":177,"end_character":29},"updated":"2016-11-07 19:09:56.000000000","message":"See above comment (this would become flavor\u003dflavor_ref)","commit_id":"84f52d4fb1610e85ab32de242727ae3684cdc7b0"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_multitenancy.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"884efb9902d2a41781d872d0e32446681962c652","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            output \u003d remote.exec_command(cmd)"},{"line_number":91,"context_line":"            self.assertIn(\"MII Status: up\", output)"},{"line_number":92,"context_line":"            self.assertIn(\"802.3ad info\", output)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @test.idempotent_id(\u002726e2f145-2a8e-4dc7-8457-7f2eb2c6749d\u0027)"},{"line_number":95,"context_line":"    @test.services(\u0027baremetal\u0027, \u0027compute\u0027, \u0027image\u0027, \u0027network\u0027)"},{"line_number":96,"context_line":"    def test_baremetal_multitenancy(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5da102_03d891ee","line":93,"updated":"2016-10-31 15:59:17.000000000","message":"Might also be good to verify the number of ports here, something like:\n\nself.assertIn(\"Number of ports: 2\", output)\n\nassuming that this is something that will stay stable within the flavors used for testing.","commit_id":"6c297c456d0b03c9eaf6feeb6eb4a3a0050c943a"}]}