)]}'
{"ironic/drivers/modules/agent_config.template":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"81a197963ce45fc7f789079a9b298fe85aa0d17a","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"label deploy"},{"line_number":4,"context_line":"kernel {{ pxe_options.deployment_aki_path }}"},{"line_number":5,"context_line":"append initrd\u003d{{ pxe_options.deployment_ari_path }} text {{ pxe_options.pxe_append_params }} ipa-api-url\u003d{{ pxe_options[\u0027ipa-api-url\u0027] }} ipa-driver-name\u003d{{ pxe_options[\u0027ipa-driver-name\u0027] }}{% if pxe_options.root_device %} root_device\u003d{{ pxe_options.root_device }}{% endif %} coreos.configdrive\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"label boot_partition"},{"line_number":8,"context_line":"kernel {{ pxe_options.aki_path }}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa6399be_7fee6e23","side":"PARENT","line":5,"updated":"2016-10-11 23:46:21.000000000","message":"I think ipa-driver-name can be removed now too, as a newer ironic deployment would be using the actual agent lookup/heartbeat API rather than vendor passthru.","commit_id":"6587a48dd0c29a527cb6b00ed1e1cbd02fa65eaf"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8ba58d2ee4158fbcd27b6d9aa51c51e97e466fe4","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"label deploy"},{"line_number":4,"context_line":"kernel {{ pxe_options.deployment_aki_path }}"},{"line_number":5,"context_line":"append initrd\u003d{{ pxe_options.deployment_ari_path }} text {{ pxe_options.pxe_append_params }} ipa-api-url\u003d{{ pxe_options[\u0027ipa-api-url\u0027] }} ipa-driver-name\u003d{{ pxe_options[\u0027ipa-driver-name\u0027] }}{% if pxe_options.root_device %} root_device\u003d{{ pxe_options.root_device }}{% endif %} coreos.configdrive\u003d0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"label boot_partition"},{"line_number":8,"context_line":"kernel {{ pxe_options.aki_path }}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa6399be_3bebd814","side":"PARENT","line":5,"in_reply_to":"fa6399be_7fee6e23","updated":"2016-10-13 13:17:41.000000000","message":"+1\n\nSounds correct. I\u0027m ok removing it in another patch tho (that depends on another one removing the code abstraction from IPA as well)","commit_id":"6587a48dd0c29a527cb6b00ed1e1cbd02fa65eaf"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6bbc777f5bb5ba142ffefd2d789165247db70027","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"    }"},{"line_number":1052,"context_line":"    # TODO(dtantsur): deprecate in favor of reading root hints directly from a"},{"line_number":1053,"context_line":"    # node record."},{"line_number":1054,"context_line":"    root_device \u003d parse_root_device_hints(node)"},{"line_number":1055,"context_line":"    if root_device:"},{"line_number":1056,"context_line":"        agent_config_opts[\u0027root_device\u0027] \u003d root_device"},{"line_number":1057,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_4a90e2ec","side":"PARENT","line":1054,"updated":"2016-10-06 13:45:44.000000000","message":"this code is doing validation of root device hints, could you please check if we still have a place where we validate them? I suspect the deploy interface validate may be that place.","commit_id":"6587a48dd0c29a527cb6b00ed1e1cbd02fa65eaf"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"11f875e494088a434dde8ca54badfb767ff01c9c","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"    }"},{"line_number":1052,"context_line":"    # TODO(dtantsur): deprecate in favor of reading root hints directly from a"},{"line_number":1053,"context_line":"    # node record."},{"line_number":1054,"context_line":"    root_device \u003d parse_root_device_hints(node)"},{"line_number":1055,"context_line":"    if root_device:"},{"line_number":1056,"context_line":"        agent_config_opts[\u0027root_device\u0027] \u003d root_device"},{"line_number":1057,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_05ffad34","side":"PARENT","line":1054,"in_reply_to":"1a95cdbc_4a90e2ec","updated":"2016-10-06 14:06:03.000000000","message":"yes, it is both called from \"AgentDeploy.validate\" [0] and \"ISCSIDeploy.validate\" [1,2] so IMO it is safe to drop it here\n\n[0] http://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/agent.py#n397\n[1] http://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/iscsi_deploy.py#n340\n[2] http://git.openstack.org/cgit/openstack/ironic/tree/ironic/drivers/modules/iscsi_deploy.py#n411","commit_id":"6587a48dd0c29a527cb6b00ed1e1cbd02fa65eaf"}],"ironic/drivers/modules/elilo_efi_pxe_config.template":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"81a197963ce45fc7f789079a9b298fe85aa0d17a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"image\u003d{{pxe_options.deployment_aki_path}}"},{"line_number":4,"context_line":"        label\u003ddeploy"},{"line_number":5,"context_line":"        initrd\u003d{{pxe_options.deployment_ari_path}}"},{"line_number":6,"context_line":"        append\u003d\"selinux\u003d0 troubleshoot\u003d0 text {{ pxe_options.pxe_append_params|default(\"\", true) }} ip\u003d%I:{{pxe_options.tftp_server}}:%G:%M:%H::on ipa-api-url\u003d{{ pxe_options[\u0027ipa-api-url\u0027] }} ipa-driver-name\u003d{{ pxe_options[\u0027ipa-driver-name\u0027] }} coreos.configdrive\u003d0\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"image\u003d{{pxe_options.aki_path}}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa6399be_df205a4c","line":6,"updated":"2016-10-11 23:46:21.000000000","message":"same comment as earlier re: ipa-driver-name","commit_id":"fb70e05ae9cd33d74122460dff073251afac9db0"}]}