)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5ed6aab4b535fed10f539d902dca00b04c871742","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The patch also adds a link to the documentation in the release note."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1561137"},{"line_number":16,"context_line":"Change-Id: I419ca5b07238a3996bcc0c76560349ad70a93f52"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_c845df70","line":15,"updated":"2016-11-16 14:29:10.000000000","message":"This is the last patch for that bug, right? If so, after this lands, please do whatever (if anything) to that bug to indicate it is done :)","commit_id":"0ce625df47ec43adfe8e43208939693b4e087241"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"01967511acb78685b6585bb69d2e0599dfbd4d1b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The patch also adds a link to the documentation in the release note."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1561137"},{"line_number":16,"context_line":"Change-Id: I419ca5b07238a3996bcc0c76560349ad70a93f52"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_96d4e820","line":15,"in_reply_to":"7a77a97e_c845df70","updated":"2016-11-16 14:42:24.000000000","message":"ops, yeah it should Closes-Bug:... lemme update it","commit_id":"0ce625df47ec43adfe8e43208939693b4e087241"}],"install-guide/source/include/root-device-hints.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1374fa71ef1d8d8b7f5c6086a4ceaaa2aa6e23cd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"has the ``wwn`` equal to the specified wwn value, or fail the deployment if it"},{"line_number":48,"context_line":"can not be found."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_f5d59342","line":50,"updated":"2016-10-17 00:25:14.000000000","message":"s/Ocataca/Ocata/\n\nAlso, for purposes of the install guide, this is forked and versioned along with our stable releases, so I\u0027d simply update the guide to reflect the new behavior, and avoid saying when exactly it was introduced.","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"has the ``wwn`` equal to the specified wwn value, or fail the deployment if it"},{"line_number":48,"context_line":"can not be found."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_89f750f4","line":50,"in_reply_to":"fa6399be_8bac0f37","updated":"2016-11-01 09:45:12.000000000","message":"Agreed, will remove it!","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"has the ``wwn`` equal to the specified wwn value, or fail the deployment if it"},{"line_number":48,"context_line":"can not be found."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_8bac0f37","line":50,"in_reply_to":"fa6399be_f5d59342","updated":"2016-10-17 20:24:16.000000000","message":"++, no need to mention \u0027From the ...\u0027.","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_eefd9909","line":52,"updated":"2016-10-17 20:24:16.000000000","message":"s/assumed/. We know what the default operator is, we don\u0027t need to assume :)\n\nYou could probably s/If no operator is specified//","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_c9d94885","line":52,"in_reply_to":"fa6399be_eefd9909","updated":"2016-11-01 09:45:12.000000000","message":"hah ++","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"},{"line_number":56,"context_line":"    * \u003d\u003d (equal to as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_6e3989d8","line":53,"updated":"2016-10-17 20:24:16.000000000","message":"s/Currently the/The/\n\nbecause I don\u0027t like using \u0027currently\u0027.","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"From the Ocataca release on, the hints can have an operator at the"},{"line_number":51,"context_line":"beginning of the value string. If no operator is specified the default"},{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"},{"line_number":56,"context_line":"    * \u003d\u003d (equal to as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_e9e8cc12","line":53,"in_reply_to":"fa6399be_6e3989d8","updated":"2016-11-01 09:45:12.000000000","message":"Done","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"},{"line_number":56,"context_line":"    * \u003d\u003d (equal to as a number)"},{"line_number":57,"context_line":"    * !\u003d (not equal to as a number)"},{"line_number":58,"context_line":"    * \u003e\u003d (greater than or equal to as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_4e7205af","line":55,"updated":"2016-10-17 20:24:16.000000000","message":"i\u0027m not sure this is grammatically correct. Do you mean \u0027equal to or greater than a number\u0027? (Ie, what is the \u0027as\u0027 meant to mean?)\n\nor ...greater than the specified number?","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"30440d93dac3fd5197897b86ac98e1f7b26707da","unresolved":false,"context_lines":[{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"},{"line_number":56,"context_line":"    * \u003d\u003d (equal to as a number)"},{"line_number":57,"context_line":"    * !\u003d (not equal to as a number)"},{"line_number":58,"context_line":"    * \u003e\u003d (greater than or equal to as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_099c2068","line":55,"in_reply_to":"ba5da102_09bb400f","updated":"2016-11-01 09:52:12.000000000","message":"Back on this... I will add a \",\" (greater than, as a number) to separate the \"as a \u003ctype\u003e\" because that\u0027s the type of the value you input.\n\nMostly because \"greater than a string\" doesn\u0027t make much sense","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"operator assumed is ``\u003d\u003d`` (for numerical values) and ``s\u003d\u003d`` (for"},{"line_number":53,"context_line":"string values). Currently the supported operators are::"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    * \u003d (equal to or greater than as a number)"},{"line_number":56,"context_line":"    * \u003d\u003d (equal to as a number)"},{"line_number":57,"context_line":"    * !\u003d (not equal to as a number)"},{"line_number":58,"context_line":"    * \u003e\u003d (greater than or equal to as a number)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_09bb400f","line":55,"in_reply_to":"fa6399be_4e7205af","updated":"2016-11-01 09:45:12.000000000","message":"It was mostly copied from the Nova docs [0], but I also find it weird. It\u0027s \"as a number\" because we have a different syntax for numbers and strings (s\u003d\u003d, \u003d\u003d etc...).\n\nThat said, I also think that \"than a number\" makes more sense.\n\n[0] http://docs.openstack.org/developer/nova/filter_scheduler.html#ComputeCapabilitiesFilter","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    * s\u003c (less than as a string)"},{"line_number":68,"context_line":"    * \u003cin\u003e (substring)"},{"line_number":69,"context_line":"    * \u003call-in\u003e (all elements contained in collection)"},{"line_number":70,"context_line":"    * \u003cor\u003e (find one of these)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Examples are:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_eee75944","line":70,"updated":"2016-10-17 20:24:16.000000000","message":"remind me. All or most of these operators take one value with the exception of \u003cin\u003e, \u003call-in\u003e and \u003cor\u003e  which can take one or more values?","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    * s\u003c (less than as a string)"},{"line_number":68,"context_line":"    * \u003cin\u003e (substring)"},{"line_number":69,"context_line":"    * \u003call-in\u003e (all elements contained in collection)"},{"line_number":70,"context_line":"    * \u003cor\u003e (find one of these)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Examples are:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_8913d00c","line":70,"in_reply_to":"fa6399be_eee75944","updated":"2016-11-01 09:45:12.000000000","message":"They can take multiple values because we now URL parse them [0]\n\n[0] https://github.com/openstack/ironic-lib/blob/master/ironic_lib/tests/test_utils.py#L439-L449","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    * \u003cin\u003e (substring)"},{"line_number":69,"context_line":"    * \u003call-in\u003e (all elements contained in collection)"},{"line_number":70,"context_line":"    * \u003cor\u003e (find one of these)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Examples are:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_6e67c9ea","line":71,"updated":"2016-10-17 20:24:16.000000000","message":"might be a nit, but I don\u0027t like seeing the operators in a black box. Can\u0027t we just list them as part of normal text?","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    * \u003cin\u003e (substring)"},{"line_number":69,"context_line":"    * \u003call-in\u003e (all elements contained in collection)"},{"line_number":70,"context_line":"    * \u003cor\u003e (find one of these)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Examples are:"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_c947881b","line":71,"in_reply_to":"fa6399be_6e67c9ea","updated":"2016-11-01 09:45:12.000000000","message":"hah yes","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"787b09dd0a83a60f90756a590e3ec7f2b40abb9d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/root_device\u003d\u0027{\"size\": \"\u003e\u003d 60\", \"rotational\": false}\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Finding a disk which vendor is ``samsung`` or ``winsys``::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/root_device\u003d\u0027{\"vendor\": \"\u003cor\u003e samsung \u003cor\u003e winsys\"}\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa6399be_aeb8012c","line":79,"updated":"2016-10-17 20:24:16.000000000","message":"s/which/whose/","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a32cc0b01e4181457c476dbe8fded064407f8ed1","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/root_device\u003d\u0027{\"size\": \"\u003e\u003d 60\", \"rotational\": false}\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"* Finding a disk which vendor is ``samsung`` or ``winsys``::"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    ironic node-update \u003cnode-uuid\u003e add properties/root_device\u003d\u0027{\"vendor\": \"\u003cor\u003e samsung \u003cor\u003e winsys\"}\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_e9560cd1","line":79,"in_reply_to":"fa6399be_aeb8012c","updated":"2016-11-01 09:45:12.000000000","message":"Done","commit_id":"2b339ff0daa7c7ad5f6ead7155d2c03262e73b02"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"b93927da34b803f2db98eb0708f461b3411e7446","unresolved":false,"context_lines":[{"line_number":51,"context_line":"no operator is specified the default is ``\u003d\u003d`` (for numerical values)"},{"line_number":52,"context_line":"and ``s\u003d\u003d`` (for string values). The supported operators are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* \u003d (equal to or greater than, as a number)"},{"line_number":55,"context_line":"* \u003d\u003d (equal to, as a number)"},{"line_number":56,"context_line":"* !\u003d (not equal to, as a number)"},{"line_number":57,"context_line":"* \u003e\u003d (greater than or equal to, as a number)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_e8f0b893","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":3},"updated":"2016-11-01 15:53:43.000000000","message":"Just double checking my understanding - this is the exact same as the \"\u003e\u003d\" operator, right?","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"b93927da34b803f2db98eb0708f461b3411e7446","unresolved":false,"context_lines":[{"line_number":51,"context_line":"no operator is specified the default is ``\u003d\u003d`` (for numerical values)"},{"line_number":52,"context_line":"and ``s\u003d\u003d`` (for string values). The supported operators are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* \u003d (equal to or greater than, as a number)"},{"line_number":55,"context_line":"* \u003d\u003d (equal to, as a number)"},{"line_number":56,"context_line":"* !\u003d (not equal to, as a number)"},{"line_number":57,"context_line":"* \u003e\u003d (greater than or equal to, as a number)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_c8f77489","line":54,"range":{"start_line":54,"start_character":31,"end_line":54,"end_character":42},"updated":"2016-11-01 15:53:43.000000000","message":"might be better to say \"for numbers\" and \"for strings\", but I think this is clear enough","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9e44bceaa4b0744caf3381fab1704a18643112db","unresolved":false,"context_lines":[{"line_number":51,"context_line":"no operator is specified the default is ``\u003d\u003d`` (for numerical values)"},{"line_number":52,"context_line":"and ``s\u003d\u003d`` (for string values). The supported operators are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* \u003d (equal to or greater than, as a number)"},{"line_number":55,"context_line":"* \u003d\u003d (equal to, as a number)"},{"line_number":56,"context_line":"* !\u003d (not equal to, as a number)"},{"line_number":57,"context_line":"* \u003e\u003d (greater than or equal to, as a number)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_93ba3d22","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":3},"in_reply_to":"9a629dbe_654fa8bd","updated":"2016-11-08 21:43:08.000000000","message":"i\u0027m not sure we should be adding that nova link.\n\nWe could put something like \u0027This is equivalent to \"\u003e\u003d\" and is supported for legacy reasons.\u0027 ? And if you want the link, maybe hide it under \u0027legacy reasons\u0027?","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e53632dc8ca9b1b67fd613f292775ef9c5a9dc2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"no operator is specified the default is ``\u003d\u003d`` (for numerical values)"},{"line_number":52,"context_line":"and ``s\u003d\u003d`` (for string values). The supported operators are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* \u003d (equal to or greater than, as a number)"},{"line_number":55,"context_line":"* \u003d\u003d (equal to, as a number)"},{"line_number":56,"context_line":"* !\u003d (not equal to, as a number)"},{"line_number":57,"context_line":"* \u003e\u003d (greater than or equal to, as a number)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_c1022609","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":3},"in_reply_to":"9a629dbe_93ba3d22","updated":"2016-11-16 10:57:00.000000000","message":"++\n\nI think it\u0027s a great suggestion","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e6475ec34064e468c639c894e46b8eb4f7c631f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"no operator is specified the default is ``\u003d\u003d`` (for numerical values)"},{"line_number":52,"context_line":"and ``s\u003d\u003d`` (for string values). The supported operators are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* \u003d (equal to or greater than, as a number)"},{"line_number":55,"context_line":"* \u003d\u003d (equal to, as a number)"},{"line_number":56,"context_line":"* !\u003d (not equal to, as a number)"},{"line_number":57,"context_line":"* \u003e\u003d (greater than or equal to, as a number)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_654fa8bd","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":3},"in_reply_to":"ba5da102_3f98d61b","updated":"2016-11-08 18:50:45.000000000","message":"Could you add this link here somewhere?","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9723201ba69caf7fcdcd127030aec34277fc630b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"no operator is specified the default is ``\u003d\u003d`` (for numerical values)"},{"line_number":52,"context_line":"and ``s\u003d\u003d`` (for string values). The supported operators are:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* \u003d (equal to or greater than, as a number)"},{"line_number":55,"context_line":"* \u003d\u003d (equal to, as a number)"},{"line_number":56,"context_line":"* !\u003d (not equal to, as a number)"},{"line_number":57,"context_line":"* \u003e\u003d (greater than or equal to, as a number)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_3f98d61b","line":54,"range":{"start_line":54,"start_character":2,"end_line":54,"end_character":3},"in_reply_to":"ba5da102_e8f0b893","updated":"2016-11-03 11:29:32.000000000","message":"It is, this came from the nova filters [0] that was later put in oslo. I think that this operator is an abomination!\n\n[0] http://docs.openstack.org/developer/nova/filter_scheduler.html#ComputeCapabilitiesFilter","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"b93927da34b803f2db98eb0708f461b3411e7446","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* s\u003d\u003d (equal to, as a string)"},{"line_number":62,"context_line":"* s!\u003d (not equal to, as a string)"},{"line_number":63,"context_line":"* s\u003e\u003d (greater than or equal to, as a string)"},{"line_number":64,"context_line":"* s\u003e (greater than, as a string)"},{"line_number":65,"context_line":"* s\u003c\u003d (less than or equal to, as a string)"},{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_4880c4c0","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":4},"updated":"2016-11-01 15:53:43.000000000","message":"What exactly does this mean? \n\nIs it \u003e\u003d as an ASCII code comparison? i.e. something like this, if device_name were an attribute of disks:\n\n\u0027{\"device_name\": \"\u003e\u003d /dev/sdb\"}\u0027\n\nwould specify that only /dev/sdb, /dev/sdc, etc. could be used but not /dev/sda?","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e53632dc8ca9b1b67fd613f292775ef9c5a9dc2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* s\u003d\u003d (equal to, as a string)"},{"line_number":62,"context_line":"* s!\u003d (not equal to, as a string)"},{"line_number":63,"context_line":"* s\u003e\u003d (greater than or equal to, as a string)"},{"line_number":64,"context_line":"* s\u003e (greater than, as a string)"},{"line_number":65,"context_line":"* s\u003c\u003d (less than or equal to, as a string)"},{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_a1744a9c","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":4},"in_reply_to":"9a629dbe_13cb8da6","updated":"2016-11-16 10:57:00.000000000","message":"Done","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e6475ec34064e468c639c894e46b8eb4f7c631f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* s\u003d\u003d (equal to, as a string)"},{"line_number":62,"context_line":"* s!\u003d (not equal to, as a string)"},{"line_number":63,"context_line":"* s\u003e\u003d (greater than or equal to, as a string)"},{"line_number":64,"context_line":"* s\u003e (greater than, as a string)"},{"line_number":65,"context_line":"* s\u003c\u003d (less than or equal to, as a string)"},{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_e5e8187f","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":4},"in_reply_to":"9a629dbe_5745ff6d","updated":"2016-11-08 18:50:45.000000000","message":"ditto","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9e44bceaa4b0744caf3381fab1704a18643112db","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* s\u003d\u003d (equal to, as a string)"},{"line_number":62,"context_line":"* s!\u003d (not equal to, as a string)"},{"line_number":63,"context_line":"* s\u003e\u003d (greater than or equal to, as a string)"},{"line_number":64,"context_line":"* s\u003e (greater than, as a string)"},{"line_number":65,"context_line":"* s\u003c\u003d (less than or equal to, as a string)"},{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_13cb8da6","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":4},"in_reply_to":"9a629dbe_e5e8187f","updated":"2016-11-08 21:43:08.000000000","message":"I suppose you could mention somewhere that string comparisons are done using python comparisons. Or eg s/as a string/as a string (Python comparison)/ ?","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9723201ba69caf7fcdcd127030aec34277fc630b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* s\u003d\u003d (equal to, as a string)"},{"line_number":62,"context_line":"* s!\u003d (not equal to, as a string)"},{"line_number":63,"context_line":"* s\u003e\u003d (greater than or equal to, as a string)"},{"line_number":64,"context_line":"* s\u003e (greater than, as a string)"},{"line_number":65,"context_line":"* s\u003c\u003d (less than or equal to, as a string)"},{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_e23fa5b1","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":4},"in_reply_to":"ba5da102_4880c4c0","updated":"2016-11-03 11:29:32.000000000","message":"It\u0027s not that smart, same as the comment on L54. I also don\u0027t get why it was there in the first place. But what this operator will do when compare strings is the same as what pyhton would do (compare the length of it), e.g:\n\n\"abc\" \u003e\u003d \"abcd\" (False)","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"93e211196e890949ad1060b51b4bf413d3464c12","unresolved":false,"context_lines":[{"line_number":61,"context_line":"* s\u003d\u003d (equal to, as a string)"},{"line_number":62,"context_line":"* s!\u003d (not equal to, as a string)"},{"line_number":63,"context_line":"* s\u003e\u003d (greater than or equal to, as a string)"},{"line_number":64,"context_line":"* s\u003e (greater than, as a string)"},{"line_number":65,"context_line":"* s\u003c\u003d (less than or equal to, as a string)"},{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_5745ff6d","line":64,"range":{"start_line":64,"start_character":2,"end_line":64,"end_character":4},"in_reply_to":"ba5da102_e23fa5b1","updated":"2016-11-08 16:27:21.000000000","message":"Ugh. I guess it\u0027s fine to leave as-is since it\u0027s the same as Python behavior.\n\nIf you wanted to, you could include this doc about it: https://docs.python.org/3/reference/expressions.html#value-comparisons\n\nI think in Python 2, it\u0027ll use ASCII instead of Unicode.\n\nIn Python 2, the /dev/sdb example works in limited cases, but it wouldn\u0027t work if there were an extra character at the end like you mentioned:\n\n\u003e\u003e\u003e \"/dev/sdc\" \u003e \"/dev/sdb\"\nTrue\n\u003e\u003e\u003e \"/dev/sda\" \u003e \"/dev/sdb\"\nFalse","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5e6475ec34064e468c639c894e46b8eb4f7c631f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"},{"line_number":68,"context_line":"* \u003call-in\u003e (all elements contained in collection)"},{"line_number":69,"context_line":"* \u003cor\u003e (find one of these)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Examples are:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_85f83c4b","line":69,"updated":"2016-11-08 18:50:45.000000000","message":"This is the only one requiring adding an operator multiple times?","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e53632dc8ca9b1b67fd613f292775ef9c5a9dc2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"* s\u003c (less than, as a string)"},{"line_number":67,"context_line":"* \u003cin\u003e (substring)"},{"line_number":68,"context_line":"* \u003call-in\u003e (all elements contained in collection)"},{"line_number":69,"context_line":"* \u003cor\u003e (find one of these)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Examples are:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_c150660d","line":69,"in_reply_to":"9a629dbe_85f83c4b","updated":"2016-11-16 10:57:00.000000000","message":"Yes","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9e44bceaa4b0744caf3381fab1704a18643112db","unresolved":false,"context_lines":[{"line_number":67,"context_line":"* \u003cin\u003e (substring)"},{"line_number":68,"context_line":"* \u003call-in\u003e (all elements contained in collection)"},{"line_number":69,"context_line":"* \u003cor\u003e (find one of these)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Examples are:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_13d2add2","line":70,"updated":"2016-11-08 21:43:08.000000000","message":"I was looking at the rendering of the above. It seems to me that there\u0027s no need to put the descriptions in parentheses. Maybe we should just highlight the actual operators. Eg:\n\n* ``!\u003d``: not equal to, as a number\n\nor\n\n* ``!\u003d``: not equal to, for numerical values\n\nor\n\n* * ``!\u003d``: not equal to, for numbers\n\nor \n\n* for numerical values:\n    * ``!\u003d``: not equal to\n    ...\n* for strings (as Python comparisons):\n   ...\n\n* for collections??:\n   * \u003call-in\u003e\n   * \u003cor\u003e","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e53632dc8ca9b1b67fd613f292775ef9c5a9dc2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"* \u003cin\u003e (substring)"},{"line_number":68,"context_line":"* \u003call-in\u003e (all elements contained in collection)"},{"line_number":69,"context_line":"* \u003cor\u003e (find one of these)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Examples are:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_c19ea6b7","line":70,"in_reply_to":"9a629dbe_13d2add2","updated":"2016-11-16 10:57:00.000000000","message":"I like breaking it in different categories depending on the type","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"}],"releasenotes/notes/support-root-device-hints-with-operators-96cf34fa37b5b2e8.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9e44bceaa4b0744caf3381fab1704a18643112db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for using operators with the root device hints mechanism."},{"line_number":4,"context_line":"    The currently supported operators are, ``\u003d``, ``\u003d\u003d``, ``!\u003d``,"},{"line_number":5,"context_line":"    ``\u003e\u003d``, ``\u003c\u003d``, ``\u003e``, ``\u003c``, ``s\u003d\u003d``, ``s!\u003d``, ``s\u003e\u003d``, ``s\u003e``,"},{"line_number":6,"context_line":"    ``s\u003c\u003d``, ``s\u003c``, ``\u003cin\u003e``, ``\u003call-in\u003e`` and ``\u003cor\u003e``. See"},{"line_number":7,"context_line":"    http://docs.openstack.org/project-install-guide/baremetal/draft/advanced.html#specifying-the-disk-for-deployment-root-device-hints"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a629dbe_9059535d","line":4,"updated":"2016-11-08 21:43:08.000000000","message":"s/currently//\n\ns/are,/are:/","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9f0b29dca92f455b41629b52435458f44e3a2d72","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for using operators with the root device hints mechanism."},{"line_number":4,"context_line":"    The currently supported operators are, ``\u003d``, ``\u003d\u003d``, ``!\u003d``,"},{"line_number":5,"context_line":"    ``\u003e\u003d``, ``\u003c\u003d``, ``\u003e``, ``\u003c``, ``s\u003d\u003d``, ``s!\u003d``, ``s\u003e\u003d``, ``s\u003e``,"},{"line_number":6,"context_line":"    ``s\u003c\u003d``, ``s\u003c``, ``\u003cin\u003e``, ``\u003call-in\u003e`` and ``\u003cor\u003e``. See"},{"line_number":7,"context_line":"    http://docs.openstack.org/project-install-guide/baremetal/draft/advanced.html#specifying-the-disk-for-deployment-root-device-hints"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_0b4191a9","line":4,"in_reply_to":"7a77a97e_41ca966f","updated":"2016-11-16 14:29:17.000000000","message":"Oh. might be a formatting thing -- maybe it expects what follows to be in a new line. No \u0027,\u0027 would be better but that is a nit.","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e53632dc8ca9b1b67fd613f292775ef9c5a9dc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for using operators with the root device hints mechanism."},{"line_number":4,"context_line":"    The currently supported operators are, ``\u003d``, ``\u003d\u003d``, ``!\u003d``,"},{"line_number":5,"context_line":"    ``\u003e\u003d``, ``\u003c\u003d``, ``\u003e``, ``\u003c``, ``s\u003d\u003d``, ``s!\u003d``, ``s\u003e\u003d``, ``s\u003e``,"},{"line_number":6,"context_line":"    ``s\u003c\u003d``, ``s\u003c``, ``\u003cin\u003e``, ``\u003call-in\u003e`` and ``\u003cor\u003e``. See"},{"line_number":7,"context_line":"    http://docs.openstack.org/project-install-guide/baremetal/draft/advanced.html#specifying-the-disk-for-deployment-root-device-hints"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_41ca966f","line":4,"in_reply_to":"9a629dbe_9059535d","updated":"2016-11-16 10:57:00.000000000","message":"I can\u0027t use \":\" for the second suggestion. For some reason the release notes will fail to generate if I use it, that\u0027s why I put a \",\" instead","commit_id":"69a892c6efa09e9fe80a08a176dd17d529385dc4"}]}