)]}'
{"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ec0d5d7e3bd91c59ace6f659f808516daf7a820","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        :raises: MissingParameterValue if required ipmi parameters are missing."},{"line_number":829,"context_line":"        :raises: InvalidParameterValue if an invalid power state was specified."},{"line_number":830,"context_line":"        :raises: PowerStateFailure if the final state of the node is not"},{"line_number":831,"context_line":"            POWER_ON."},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        \"\"\""},{"line_number":834,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_4eca1370","line":831,"updated":"2016-10-17 15:25:45.000000000","message":"might want to update this.","commit_id":"8e306d540d22154408f33ef56c104e7820a15f0c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"291be833cd77fd01455fb5957f2f525d86cb8f6e","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        :raises: MissingParameterValue if required ipmi parameters are missing."},{"line_number":829,"context_line":"        :raises: InvalidParameterValue if an invalid power state was specified."},{"line_number":830,"context_line":"        :raises: PowerStateFailure if the final state of the node is not"},{"line_number":831,"context_line":"            POWER_ON."},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"        \"\"\""},{"line_number":834,"context_line":"        driver_info \u003d _parse_driver_info(task.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_65027f71","line":831,"in_reply_to":"fa6399be_4eca1370","updated":"2016-10-18 01:55:57.000000000","message":"I\u0027ll fix that.","commit_id":"8e306d540d22154408f33ef56c104e7820a15f0c"}],"releasenotes/notes/add-error-check-ipmitool-reboot-ca7823202c5ab71d.yaml":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"7247a0b62bbd1fe964c36d7c40d2ca02c44570ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - adds a missing error check into ipmitool power driver\u0027s reboot so"},{"line_number":4,"context_line":"    that the reboot can be done properly in case of failing power off."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_668f0975","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":69},"updated":"2016-10-17 11:25:16.000000000","message":"This sentence looks confusing for me.","commit_id":"8e306d540d22154408f33ef56c104e7820a15f0c"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"291be833cd77fd01455fb5957f2f525d86cb8f6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - adds a missing error check into ipmitool power driver\u0027s reboot so"},{"line_number":4,"context_line":"    that the reboot can be done properly in case of failing power off."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_0511c3af","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":69},"in_reply_to":"fa6399be_2e0b1f2d","updated":"2016-10-18 01:55:57.000000000","message":"I\u0027ll fix here and the commit message.","commit_id":"8e306d540d22154408f33ef56c104e7820a15f0c"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2ec0d5d7e3bd91c59ace6f659f808516daf7a820","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - adds a missing error check into ipmitool power driver\u0027s reboot so"},{"line_number":4,"context_line":"    that the reboot can be done properly in case of failing power off."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_2e0b1f2d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":69},"in_reply_to":"fa6399be_668f0975","updated":"2016-10-17 15:25:45.000000000","message":"Yes, this is confusing. I thought you wanted the reboot to fail if the power off failed. This makes it sound like even if powering off failed, the reboot will still be done.","commit_id":"8e306d540d22154408f33ef56c104e7820a15f0c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"15115630c71449f16d2ac4b3dde1795fb85e7255","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - adds a missing error check into ipmitool power driver\u0027s reboot so"},{"line_number":4,"context_line":"    that the reboot can fail properly if power off failed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa6399be_7cdcd546","line":3,"updated":"2016-10-18 08:28:59.000000000","message":"Should start with capital letter to be consistent with other releasenotes.","commit_id":"c073fb714df0477a625e2e4eee89edfee4a03576"}]}
