)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"673e4a6226d714925880a457f287393ba0618120","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Account for Infiniband GID when validating an address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is extending the address validation to supporta Infiniband"},{"line_number":10,"context_line":"GIDs. Without this, when a Infiniband NIC is present and IPA tries to"},{"line_number":11,"context_line":"lookup for the node booting the Ironic API will fail validation and the"},{"line_number":12,"context_line":"deployment won\u0027t suceed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_f078042e","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":58},"updated":"2016-10-18 10:04:21.000000000","message":"s/to supporta/to support an/","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Account for Infiniband GID when validating an address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is extending the address validation to supporta Infiniband"},{"line_number":10,"context_line":"GIDs. Without this, when a Infiniband NIC is present and IPA tries to"},{"line_number":11,"context_line":"lookup for the node booting the Ironic API will fail validation and the"},{"line_number":12,"context_line":"deployment won\u0027t suceed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_d173ffe5","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":58},"in_reply_to":"fa6399be_f078042e","updated":"2016-10-18 12:23:37.000000000","message":"Done","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"673e4a6226d714925880a457f287393ba0618120","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Account for Infiniband GID when validating an address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is extending the address validation to supporta Infiniband"},{"line_number":10,"context_line":"GIDs. Without this, when a Infiniband NIC is present and IPA tries to"},{"line_number":11,"context_line":"lookup for the node booting the Ironic API will fail validation and the"},{"line_number":12,"context_line":"deployment won\u0027t suceed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_70931450","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":26},"updated":"2016-10-18 10:04:21.000000000","message":"s/a/an/","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Account for Infiniband GID when validating an address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is extending the address validation to supporta Infiniband"},{"line_number":10,"context_line":"GIDs. Without this, when a Infiniband NIC is present and IPA tries to"},{"line_number":11,"context_line":"lookup for the node booting the Ironic API will fail validation and the"},{"line_number":12,"context_line":"deployment won\u0027t suceed."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_f180038e","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":26},"in_reply_to":"fa6399be_70931450","updated":"2016-10-18 12:23:37.000000000","message":"Done","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8dd9543d18bebe1e38de0754c5541abc0c0851dc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch is extending the address validation to support an Infiniband"},{"line_number":10,"context_line":"GIDs. Without this, when a Infiniband NIC is present and IPA tries to"},{"line_number":11,"context_line":"lookup for the node booting the Ironic API will fail validation and the"},{"line_number":12,"context_line":"deployment won\u0027t suceed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The method validate_and_normalize_mac() from the common/utils.py module"},{"line_number":15,"context_line":"has been renamed to validate_and_normalize_address() to better reflect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6895a0_fb3e10b7","line":12,"updated":"2016-10-23 07:33:21.000000000","message":"succeed","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch is extending the address validation to support an Infiniband"},{"line_number":10,"context_line":"GIDs. Without this, when a Infiniband NIC is present and IPA tries to"},{"line_number":11,"context_line":"lookup for the node booting the Ironic API will fail validation and the"},{"line_number":12,"context_line":"deployment won\u0027t suceed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The method validate_and_normalize_mac() from the common/utils.py module"},{"line_number":15,"context_line":"has been renamed to validate_and_normalize_address() to better reflect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_0387dfb5","line":12,"in_reply_to":"da6895a0_fb3e10b7","updated":"2016-10-28 09:40:23.000000000","message":"Done","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"}],"ironic/common/utils.py":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"10067cc7a1d26c8ff5ba1cb15e0b2bbf4b2ce663","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    Check if it\u0027s a valid MAC address (6 octets) or an Infiniband GID"},{"line_number":122,"context_line":"    (20 octets). Accepts colon-separated format only."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    :param address: MAC address to be validated."},{"line_number":125,"context_line":"    :returns: True if valid. False if not."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_e848318d","line":124,"range":{"start_line":124,"start_character":20,"end_line":124,"end_character":23},"updated":"2016-10-17 19:50:35.000000000","message":"Nit - maybe change param description to include GID","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    Check if it\u0027s a valid MAC address (6 octets) or an Infiniband GID"},{"line_number":122,"context_line":"    (20 octets). Accepts colon-separated format only."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    :param address: MAC address to be validated."},{"line_number":125,"context_line":"    :returns: True if valid. False if not."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_117e57ae","line":124,"range":{"start_line":124,"start_character":20,"end_line":124,"end_character":23},"in_reply_to":"fa6399be_e848318d","updated":"2016-10-18 12:23:37.000000000","message":"Done","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"10067cc7a1d26c8ff5ba1cb15e0b2bbf4b2ce663","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    octets) or a valid Infiniband GID (20 octets) and normalize it to"},{"line_number":242,"context_line":"    all lower case."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    :param address: MAC address to be validated and normalized."},{"line_number":245,"context_line":"    :returns: Normalized and validated MAC address."},{"line_number":246,"context_line":"    :raises: InvalidMAC If the MAC address is not valid."},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8808952f","line":244,"range":{"start_line":244,"start_character":20,"end_line":244,"end_character":23},"updated":"2016-10-17 19:50:35.000000000","message":"Nit - same comment that param description should include GID.","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    octets) or a valid Infiniband GID (20 octets) and normalize it to"},{"line_number":242,"context_line":"    all lower case."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    :param address: MAC address to be validated and normalized."},{"line_number":245,"context_line":"    :returns: Normalized and validated MAC address."},{"line_number":246,"context_line":"    :raises: InvalidMAC If the MAC address is not valid."},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_514e0f97","line":244,"range":{"start_line":244,"start_character":20,"end_line":244,"end_character":23},"in_reply_to":"fa6399be_502a90e8","updated":"2016-10-18 12:23:37.000000000","message":"Done","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"673e4a6226d714925880a457f287393ba0618120","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    octets) or a valid Infiniband GID (20 octets) and normalize it to"},{"line_number":242,"context_line":"    all lower case."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    :param address: MAC address to be validated and normalized."},{"line_number":245,"context_line":"    :returns: Normalized and validated MAC address."},{"line_number":246,"context_line":"    :raises: InvalidMAC If the MAC address is not valid."},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_502a90e8","line":244,"range":{"start_line":244,"start_character":20,"end_line":244,"end_character":23},"in_reply_to":"fa6399be_8808952f","updated":"2016-10-18 10:04:21.000000000","message":"+1, to update it here and in next two lines.","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c3dbf44454717c7fec0c9ce8835a01b970f4ebf","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    \"\"\""},{"line_number":249,"context_line":"    if not is_valid_address(address):"},{"line_number":250,"context_line":"        raise exception.InvalidMAC(mac\u003daddress)"},{"line_number":251,"context_line":"    return address.lower()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_3fdc0f18","line":250,"updated":"2016-10-18 08:53:59.000000000","message":"+1, let\u0027s do it","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"10067cc7a1d26c8ff5ba1cb15e0b2bbf4b2ce663","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    \"\"\""},{"line_number":249,"context_line":"    if not is_valid_address(address):"},{"line_number":250,"context_line":"        raise exception.InvalidMAC(mac\u003daddress)"},{"line_number":251,"context_line":"    return address.lower()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_e8167157","line":250,"range":{"start_line":250,"start_character":24,"end_line":250,"end_character":34},"updated":"2016-10-17 19:50:35.000000000","message":"Wondering if need to change InvalidMAC exception to include text about GID. Currently it is - \"Expected a MAC address but received %(mac)s.\"","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    \"\"\""},{"line_number":249,"context_line":"    if not is_valid_address(address):"},{"line_number":250,"context_line":"        raise exception.InvalidMAC(mac\u003daddress)"},{"line_number":251,"context_line":"    return address.lower()"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_3130bb07","line":250,"in_reply_to":"fa6399be_3fdc0f18","updated":"2016-10-18 12:23:37.000000000","message":"good point!","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"e52637b904462ad38db1c0c2bcf271d8bb78aff3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"def is_valid_address(address):"},{"line_number":148,"context_line":"    \"\"\"Verify the format of the address."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    Check if the address is a valid MAC address of Infiniband GID. Accepts"},{"line_number":151,"context_line":"    colon-separated format only."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    :param address: address to be validated."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_8d5c0827","line":150,"range":{"start_line":150,"start_character":48,"end_line":150,"end_character":50},"updated":"2016-10-21 19:46:31.000000000","message":"Nit - typo","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"def is_valid_address(address):"},{"line_number":148,"context_line":"    \"\"\"Verify the format of the address."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    Check if the address is a valid MAC address of Infiniband GID. Accepts"},{"line_number":151,"context_line":"    colon-separated format only."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    :param address: address to be validated."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_c3a40759","line":150,"range":{"start_line":150,"start_character":48,"end_line":150,"end_character":50},"in_reply_to":"da6895a0_8d5c0827","updated":"2016-10-28 09:40:23.000000000","message":"Done","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"}],"ironic/db/sqlalchemy/api.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8dd9543d18bebe1e38de0754c5541abc0c0851dc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    \"\"\"Adds a port-specific filter to a query."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    Filters results by address, if supplied value is a valid MAC"},{"line_number":99,"context_line":"    address. Otherwise attempts to filter results by identity."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    :param query: Initial query to add filter to."},{"line_number":102,"context_line":"    :param value: Value for filtering results by."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_5b4d3c71","line":99,"updated":"2016-10-23 07:33:21.000000000","message":"or GID","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    \"\"\"Adds a port-specific filter to a query."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    Filters results by address, if supplied value is a valid MAC"},{"line_number":99,"context_line":"    address. Otherwise attempts to filter results by identity."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    :param query: Initial query to add filter to."},{"line_number":102,"context_line":"    :param value: Value for filtering results by."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_23fdc33a","line":99,"in_reply_to":"da6895a0_5b4d3c71","updated":"2016-10-28 09:40:23.000000000","message":"Done","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8dd9543d18bebe1e38de0754c5541abc0c0851dc","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def add_portgroup_filter(query, value):"},{"line_number":121,"context_line":"    \"\"\"Adds a portgroup-specific filter to a query."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    Filters results by address, if supplied value is a valid MAC"},{"line_number":124,"context_line":"    address. Otherwise attempts to filter results by identity."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    :param query: Initial query to add filter to."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_7b520015","line":123,"updated":"2016-10-23 07:33:21.000000000","message":"ditto","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"def add_portgroup_filter(query, value):"},{"line_number":121,"context_line":"    \"\"\"Adds a portgroup-specific filter to a query."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    Filters results by address, if supplied value is a valid MAC"},{"line_number":124,"context_line":"    address. Otherwise attempts to filter results by identity."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    :param query: Initial query to add filter to."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_6395fbe2","line":123,"in_reply_to":"da6895a0_7b520015","updated":"2016-10-28 09:40:23.000000000","message":"Done","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c3dbf44454717c7fec0c9ce8835a01b970f4ebf","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                mac_addresses.append(utils.validate_and_normalize_address("},{"line_number":837,"context_line":"                    interface.get(\u0027mac_address\u0027)))"},{"line_number":838,"context_line":"            except exception.InvalidMAC:"},{"line_number":839,"context_line":"                LOG.warning(_LW(\u0027Malformed MAC: %s\u0027), interface.get("},{"line_number":840,"context_line":"                    \u0027mac_address\u0027))"},{"line_number":841,"context_line":"        return mac_addresses"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5fe1c3cf","line":839,"updated":"2016-10-18 08:53:59.000000000","message":"this needs fixing as well","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                mac_addresses.append(utils.validate_and_normalize_address("},{"line_number":837,"context_line":"                    interface.get(\u0027mac_address\u0027)))"},{"line_number":838,"context_line":"            except exception.InvalidMAC:"},{"line_number":839,"context_line":"                LOG.warning(_LW(\u0027Malformed MAC: %s\u0027), interface.get("},{"line_number":840,"context_line":"                    \u0027mac_address\u0027))"},{"line_number":841,"context_line":"        return mac_addresses"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_913fc7d5","line":839,"in_reply_to":"fa6399be_5fe1c3cf","updated":"2016-10-18 12:23:37.000000000","message":"Done","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7e3436fa0260d78b67c6004ea5ba148964fa12ae","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                mac_addresses.append(utils.validate_and_normalize_address("},{"line_number":837,"context_line":"                    interface.get(\u0027mac_address\u0027)))"},{"line_number":838,"context_line":"            except exception.InvalidMAC:"},{"line_number":839,"context_line":"                LOG.warning(_LW(\u0027Malformed MAC: %s\u0027), interface.get("},{"line_number":840,"context_line":"                    \u0027mac_address\u0027))"},{"line_number":841,"context_line":"        return mac_addresses"},{"line_number":842,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_903a4fe6","line":839,"in_reply_to":"fa6399be_913fc7d5","updated":"2016-10-18 19:28:39.000000000","message":"there\u0027s loads of \"MAC\u0027s\" in this file :-/ (and potentially others) I wonder if we should refactor it all or simple consider a infiniband gid a \"mac address\"","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8dd9543d18bebe1e38de0754c5541abc0c0851dc","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        return interfaces"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def _get_mac_addresses(self, interfaces):"},{"line_number":838,"context_line":"        \"\"\"Returns MACs for the network devices.\"\"\""},{"line_number":839,"context_line":"        mac_addresses \u003d []"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        for interface in interfaces:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_3b3248f2","line":838,"updated":"2016-10-23 07:33:21.000000000","message":"or GIDs","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        return interfaces"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"    def _get_mac_addresses(self, interfaces):"},{"line_number":838,"context_line":"        \"\"\"Returns MACs for the network devices.\"\"\""},{"line_number":839,"context_line":"        mac_addresses \u003d []"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        for interface in interfaces:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_0300bf33","line":838,"in_reply_to":"da6895a0_3b3248f2","updated":"2016-10-28 09:40:23.000000000","message":"Done","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"}],"ironic/objects/port.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8dd9543d18bebe1e38de0754c5541abc0c0851dc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        Find a port based on its id or uuid or MAC address and return a Port"},{"line_number":69,"context_line":"        object."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        :param port_id: the id *or* uuid *or* MAC address of a port."},{"line_number":72,"context_line":"        :returns: a :class:`Port` object."},{"line_number":73,"context_line":"        :raises: InvalidIdentity"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6895a0_9b57d401","line":71,"updated":"2016-10-23 07:33:21.000000000","message":"ditto","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        Find a port based on its id or uuid or MAC address and return a Port"},{"line_number":69,"context_line":"        object."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        :param port_id: the id *or* uuid *or* MAC address of a port."},{"line_number":72,"context_line":"        :returns: a :class:`Port` object."},{"line_number":73,"context_line":"        :raises: InvalidIdentity"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_83f3ef72","line":71,"in_reply_to":"da6895a0_9b57d401","updated":"2016-10-28 09:40:23.000000000","message":"Done","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"}],"ironic/tests/unit/common/test_utils.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"673e4a6226d714925880a457f287393ba0618120","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            \"80-00-02-48-fe-80-00-00-00-00-00-00-f4-52-14-03-00-54-06-c2\"))"},{"line_number":270,"context_line":"        # space instead of colons"},{"line_number":271,"context_line":"        self.assertFalse(utils.is_valid_address("},{"line_number":272,"context_line":"            \"80 00 02 48 fe 80 00 00 00 00 00 00 f4 52 14 03 00 54 06 c2\"))"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_is_valid_datapath_id(self):"},{"line_number":275,"context_line":"        self.assertTrue(utils.is_valid_datapath_id(\"525400cf2d319fdf\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_50c61017","line":272,"updated":"2016-10-18 10:04:21.000000000","message":"nit: test with capital letters is missed.","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44ac7bbb4840f0aeeb5409035b28c2ba001ddba6","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            \"80-00-02-48-fe-80-00-00-00-00-00-00-f4-52-14-03-00-54-06-c2\"))"},{"line_number":270,"context_line":"        # space instead of colons"},{"line_number":271,"context_line":"        self.assertFalse(utils.is_valid_address("},{"line_number":272,"context_line":"            \"80 00 02 48 fe 80 00 00 00 00 00 00 f4 52 14 03 00 54 06 c2\"))"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_is_valid_datapath_id(self):"},{"line_number":275,"context_line":"        self.assertTrue(utils.is_valid_datapath_id(\"525400cf2d319fdf\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_b124cbc6","line":272,"in_reply_to":"fa6399be_50c61017","updated":"2016-10-18 12:23:37.000000000","message":"Done","commit_id":"4fcc6594dde1aae761cf143ee4bbe9f130dbb9fe"}],"releasenotes/notes/infiniband-gid-validation-95500225a16aad26.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"8dd9543d18bebe1e38de0754c5541abc0c0851dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a problem where Ironic would fail validation if the port"},{"line_number":4,"context_line":"    address was an Infiniband GID. Prior to this patch deploying a node"},{"line_number":5,"context_line":"    with an Infiniband card would fail when the IPA ramdisk tried to"},{"line_number":6,"context_line":"    invoke the lookup method in the Ironic\u0027s API to figure out which"},{"line_number":7,"context_line":"    node was being deployed."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da6895a0_db414c3b","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":54},"updated":"2016-10-23 07:33:21.000000000","message":"I\u0027d just say previously, there is no notion of this patch in reno.","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e7f292cc43db4a8782e0cfaa3cb7c640347f81c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes a problem where Ironic would fail validation if the port"},{"line_number":4,"context_line":"    address was an Infiniband GID. Prior to this patch deploying a node"},{"line_number":5,"context_line":"    with an Infiniband card would fail when the IPA ramdisk tried to"},{"line_number":6,"context_line":"    invoke the lookup method in the Ironic\u0027s API to figure out which"},{"line_number":7,"context_line":"    node was being deployed."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5da102_43e397a3","line":4,"range":{"start_line":4,"start_character":35,"end_line":4,"end_character":54},"in_reply_to":"da6895a0_db414c3b","updated":"2016-10-28 09:40:23.000000000","message":"++","commit_id":"205e92c24a626fa70c29fae854e1b950e20ee3ee"}]}
